Changes by INADA Naoki :
--
pull_requests: +162
___
Python tracker
<http://bugs.python.org/issue28331>
___
___
Python-bugs-list mailing list
Unsubscribe:
INADA Naoki added the comment:
https://github.com/python/cpython/pull/194#issuecomment-281054701
Xiang Zhang found Python 3.6+ have similar issue.
--
versions: +Python 3.6, Python 3.7
___
Python tracker
<http://bugs.python.org/issue24
INADA Naoki added the comment:
New changeset 66fa9d4205e0da672ed19a397069281a4b177af4 by GitHub in branch
'3.5':
bpo-24274: fix comment in dictobject.c (GH-194)
https://github.com/python/cpython/commit/66fa9d4205e0da672ed19a39706928
Changes by INADA Naoki :
--
pull_requests: +163
___
Python tracker
<http://bugs.python.org/issue24274>
___
___
Python-bugs-list mailing list
Unsubscribe:
INADA Naoki added the comment:
close this issue because lack of information.
--
resolution: -> rejected
stage: -> resolved
status: open -> closed
___
Python tracker
<http://bugs.python.or
Changes by INADA Naoki :
--
resolution: -> wont fix
stage: -> resolved
status: open -> closed
___
Python tracker
<http://bugs.python.org/issue26382>
___
___
Changes by INADA Naoki :
--
pull_requests: +164
___
Python tracker
<http://bugs.python.org/issue29509>
___
___
Python-bugs-list mailing list
Unsubscribe:
Changes by INADA Naoki :
--
pull_requests: +166
___
Python tracker
<http://bugs.python.org/issue15216>
___
___
Python-bugs-list mailing list
Unsubscribe:
INADA Naoki added the comment:
New changeset 1b8df107f867fb05ff39ebee7c55f0a907e7ad5f by GitHub in branch
'master':
bpo-24274: fix erroneous comment in dictobject.c (GH-196)
https://github.com/python/cpython/commit/1b8df107f867fb05ff39ebee7c55f0
Changes by INADA Naoki :
--
pull_requests: +167
___
Python tracker
<http://bugs.python.org/issue24274>
___
___
Python-bugs-list mailing list
Unsubscribe:
INADA Naoki added the comment:
New changeset ce552e2d5c4ff90218fb41847e8ffb1fd3ba3b2d by GitHub in branch
'3.6':
bpo-24274: fix erroneous comment in dictobject.c (GH-200)
https://github.com/python/cpython/commit/ce552e2d5c4ff90218fb41847e8ffb
Changes by INADA Naoki :
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<http://bugs.python.or
Changes by INADA Naoki :
--
pull_requests: +179
___
Python tracker
<http://bugs.python.org/issue29165>
___
___
Python-bugs-list mailing list
Unsubscribe:
INADA Naoki added the comment:
I like current, minimum example to describe API.
No need to make it complex only for checking it's really executed in parallel.
Adding more and more "may be useful for someone" code in the doc make the
document long, hard and tedious to re
Changes by INADA Naoki :
--
nosy: +inada.naoki
___
Python tracker
<http://bugs.python.org/issue24340>
___
___
Python-bugs-list mailing list
Unsubscribe:
New submission from INADA Naoki:
In C implementation, write() calls underlaying flush() method when
write_through=True.
https://github.com/python/cpython/blob/3.6/Modules/_io/textio.c
if (self->write_through)
text_needflush = 1;
if (self->line_buffering &&
INADA Naoki added the comment:
> but the code with PyObject_HEAD_INIT() doesn't look incompatible with Python
> 3.
It's incompatible actually.
https://github.com/python/cpython/blob/2.7/Include/object.h
/* PyObject_HEAD defines the initial segment of every PyObj
INADA Naoki added the comment:
New changeset 9436bbd87b7eed18dec4c32f25b88452fe282e1c by GitHub in branch
'2.7':
bpo-29165: doc: make extending/newtypes more Python 3 friendly (GH-211)
https://github.com/python/cpython/commit/9436bbd87b7eed18dec4c32f25b884
Changes by INADA Naoki :
--
resolution: -> fixed
stage: -> resolved
status: open -> closed
___
Python tracker
<http://bugs.python.org/issue29165>
___
INADA Naoki added the comment:
> And it seems to me that Doc/includes/shoddy.c in Python 3 is not correct.
I created another pull request PR 215.
--
___
Python tracker
<http://bugs.python.org/issu
INADA Naoki added the comment:
New changeset 3e8d6cb1892377394e4b11819c33fbac728ea9e0 by GitHub in branch
'master':
bpo-29509: skip redundant intern (GH-197)
https://github.com/python/cpython/commit/3e8d6cb1892377394e4b11819c33fb
Changes by INADA Naoki :
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<http://bugs.python.or
Changes by INADA Naoki :
--
pull_requests: +183
___
Python tracker
<http://bugs.python.org/issue29607>
___
___
Python-bugs-list mailing list
Unsubscribe:
INADA Naoki added the comment:
Thanks, Matthieu.
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<http://bugs.python.or
INADA Naoki added the comment:
New changeset 3ab24bdd47fdd9d45719ad49f93d3878d4442d7e by GitHub in branch
'3.6':
bpo-29607: Fix stack_effect computation for CALL_FUNCTION_EX (GH-219)
https://github.com/python/cpython/commit/3ab24bdd47fdd9d45719ad49f93d3878d4442d7e
-
INADA Naoki added the comment:
I'm -1 on suppress log silently.
While error message is bit surprising,
Traceback (most recent call last):
File "/usr/lib/python3.5/asyncio/tasks.py", line 93, in __del__
File "/usr/lib/python3.5/asyncio/base_events.py", line 1160, i
INADA Naoki added the comment:
I don't feel TableReader is really useful.
Would you show some realistic example when TableReader is better than
normal csv.Reader?
--
nosy: +inada.naoki
___
Python tracker
<http://bugs.python.org/is
New submission from INADA Naoki:
asyncio for Python 3.3 has not been released for two years.
https://pypi.python.org/pypi/asyncio
We have many code in asyncio for support Python 3.3.
How about removing them?
--
components: asyncio
messages: 288332
nosy: gvanrossum, inada.naoki
Changes by INADA Naoki :
--
pull_requests: +195
___
Python tracker
<http://bugs.python.org/issue29617>
___
___
Python-bugs-list mailing list
Unsubscribe:
INADA Naoki added the comment:
New changeset 03f68b60e17b57f6f13729ff73245dbb37b30a4c by INADA Naoki in branch
'master':
bpo-29110: Fix file object leak in `aifc.open` when given invalid AIFF file.
(GH-162)
https://github.com/python/cpython/commit/03f68b60e17b57f6f13729ff73245d
INADA Naoki added the comment:
OK, let's continue on #29522, and close this issue.
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<http://bugs.pyth
INADA Naoki added the comment:
s/ #29522 / #29622 /
--
___
Python tracker
<http://bugs.python.org/issue29463>
___
___
Python-bugs-list mailing list
Unsubscribe:
INADA Naoki added the comment:
AST type doesn't have any information about optional fields. And I don't know
it's worth enough to add it.
When AST is instantiated by keyword arguments, there are no check about absence
of some fields.
I suppose we can just loosen positiona
Changes by INADA Naoki :
--
pull_requests: +216
___
Python tracker
<http://bugs.python.org/issue29622>
___
___
Python-bugs-list mailing list
Unsubscribe:
INADA Naoki added the comment:
Now trailing optional fields are optional arguments of AST type.
--
___
Python tracker
<http://bugs.python.org/issue29622>
___
___
INADA Naoki added the comment:
@mbussonn With PR 249, "import os" and "%timeit" works fine.
--
___
Python tracker
<http://bugs.python.org/issue29622>
___
_
Changes by INADA Naoki :
--
resolution: -> fixed
stage: -> resolved
status: open -> closed
___
Python tracker
<http://bugs.python.org/issue29622>
___
Changes by INADA Naoki :
--
resolution: -> fixed
stage: -> resolved
status: open -> closed
___
Python tracker
<http://bugs.python.org/issue29637>
___
Changes by INADA Naoki :
--
pull_requests: +263
___
Python tracker
<http://bugs.python.org/issue29110>
___
___
Python-bugs-list mailing list
Unsubscribe:
INADA Naoki added the comment:
I close this issue, because there are no enough evidence
it's Python's issue. When hit ulimit is just a OS's detail.
Please ping or file a new issue when memory usage is really grown.
--
resolution: -> not a bug
stage: ->
Changes by INADA Naoki :
--
pull_requests: +271
___
Python tracker
<http://bugs.python.org/issue29110>
___
___
Python-bugs-list mailing list
Unsubscribe:
Changes by INADA Naoki :
--
pull_requests: +272
___
Python tracker
<http://bugs.python.org/issue29110>
___
___
Python-bugs-list mailing list
Unsubscribe:
INADA Naoki added the comment:
Anyone mind Python 2.7?
Since Python 2.7 doesn't have mock and check_no_resource_warning context
manager, I can't cherry-pick easily.
Backporting is bother to me, and the issue doesn't seem so critical.
Can I just c
INADA Naoki added the comment:
I'm afraid this change makes testloader searches unrelated directory contains
massive files (like node_modules).
I don't think loading all tests from whole namespace package is not usual use
case.
--
nosy: +i
INADA Naoki added the comment:
When using import, (namespace) package name is explicitly specified.
Only specified name is searched.
In test loader's case, there are no such limit.
Loader may search millions of completely unrelated directories.
It may include directories in NFS or samba
Changes by INADA Naoki :
--
pull_requests: +303
___
Python tracker
<http://bugs.python.org/issue29110>
___
___
Python-bugs-list mailing list
Unsubscribe:
INADA Naoki added the comment:
OK, since Aifc_write is harder to test, and the exception is very unlikely
happens, I fixed only Aifc_read.
--
___
Python tracker
<http://bugs.python.org/issue29
Changes by INADA Naoki :
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<http://bugs.python.or
INADA Naoki added the comment:
thanks.
for summary, notable changes are:
(print_callers)
+{method 'append' of 'list' objects} <- 40.0000.000
profilee.py:73(helper1)
Stats.print_callees output for Profile doesn't fit expectation!
and
New submission from INADA Naoki:
This issue is spin off issue29548.
PyEval_CallObjectWithKeywords(PyObject *func, PyObject *args, PyObject *kwargs)
should raise TypeError when kwargs is not dict.
But after this commit [1], assert(PyDict_Check(kwargs)) can be called when
args==NULL.
[1]
https
Changes by INADA Naoki :
--
pull_requests: +314
___
Python tracker
<http://bugs.python.org/issue29684>
___
___
Python-bugs-list mailing list
Unsubscribe:
Changes by INADA Naoki :
--
pull_requests: +317
___
Python tracker
<http://bugs.python.org/issue29684>
___
___
Python-bugs-list mailing list
Unsubscribe:
INADA Naoki added the comment:
See also
http://www.unicode.org/reports/tr29/
http://www.unicode.org/reports/tr14/
--
___
Python tracker
<http://bugs.python.org/issue24
New submission from INADA Naoki:
I've implemented compact ordered dictionary, introduced in PyPy blog [1].
To finish my work, I really need core developer's help. Please see TODO comment
in the patch.
[1]:
https://morepypy.blogspot.jp/2015/01/faster-more-memory-efficient-and-more
Changes by INADA Naoki :
--
type: -> resource usage
___
Python tracker
<http://bugs.python.org/issue27350>
___
___
Python-bugs-list mailing list
Unsubscrib
INADA Naoki added the comment:
>> How to support sizeof(Py_ssize_t) == 4?
>#if SIZEOF_VOID_P == 4
Thanks!
>> Can I use int8_t, int16_t and int32_t
> You can use PY_INT32_T for 32-bit signed integers, short for 16-bit signed
> integers (if SIZEOF_SHORT == 2) and signed
Changes by INADA Naoki :
Added file: http://bugs.python.org/file43465/compact-dict.patch
___
Python tracker
<http://bugs.python.org/issue27350>
___
___
Python-bugs-list m
INADA Naoki added the comment:
Make sense! I did it.
--
Added file: http://bugs.python.org/file43467/compact-dict.patch
___
Python tracker
<http://bugs.python.org/issue27
Changes by INADA Naoki :
Added file: http://bugs.python.org/file43472/compact-dict.patch
___
Python tracker
<http://bugs.python.org/issue27350>
___
___
Python-bugs-list m
Changes by INADA Naoki :
Added file: http://bugs.python.org/file43480/compact-dict.patch
___
Python tracker
<http://bugs.python.org/issue27350>
___
___
Python-bugs-list m
Changes by INADA Naoki :
Added file: http://bugs.python.org/file43484/compact-dict.patch
___
Python tracker
<http://bugs.python.org/issue27350>
___
___
Python-bugs-list m
INADA Naoki added the comment:
As I posted to python-dev ML, this compact ordered dict doesn't keep insertion
order
for key-shared dict.
>>> class A:
... ...
...
>>> a = A()
>>> b = A()
>>> a.a = 1
>>> a.b = 2
>>> b.b = 3
>&
INADA Naoki added the comment:
Thank you, mark.
I've added PY_INT16_T and PY_UINT16_T for windows, too.
https://github.com/methane/cpython/pull/1/commits/dfaa44c051b2dbf580701729944cd0fda00cb541
https://github.com/methane/cpython/pull/1/commits/af80dc27dd381af9d211792963a23c5cecfa7009
Changes by INADA Naoki :
Added file: http://bugs.python.org/file43509/compact-dict.patch
___
Python tracker
<http://bugs.python.org/issue27350>
___
___
Python-bugs-list m
INADA Naoki added the comment:
FYI, bench result of USABLE_FRACTION(n) = (n/2):
Report on Linux ip-10-0-1-249 3.16.0-4-amd64 #1 SMP Debian 3.16.7-ckt25-1
(2016-03-06) x86_64
Total CPU cores: 2
+--+-++--++
| Benchmark
Changes by INADA Naoki :
Added file: http://bugs.python.org/file43520/compact-dict.patch
___
Python tracker
<http://bugs.python.org/issue27350>
___
___
Python-bugs-list m
Changes by INADA Naoki :
Added file: http://bugs.python.org/file43542/compact-dict.patch
___
Python tracker
<http://bugs.python.org/issue27350>
___
___
Python-bugs-list m
Changes by INADA Naoki :
Added file: http://bugs.python.org/file43558/compact-dict.patch
___
Python tracker
<http://bugs.python.org/issue27350>
___
___
Python-bugs-list m
INADA Naoki added the comment:
Last patch I've posted implements "strict ordering rule" on key sharing dict.
* Insertion order should be strictly equal to order in shared key.
If insertion position is not equal to ma_used, convert it to combined
form.
* Deleting from
INADA Naoki added the comment:
And Python benchmark result is here.
https://gist.github.com/methane/e7a2ae389ca13905508905f5fa4ad46c
pickup
---
### call_method_slots ###
Min: 0.282221 -> 0.266215: 1.06x faster
Avg: 0.282379 -> 0.266448: 1.06x faster
Significant (t=780.35)
Stddev: 0
INADA Naoki added the comment:
Anyone can review this by Python 3.6a3 ?
--
___
Python tracker
<http://bugs.python.org/issue27350>
___
___
Python-bugs-list mailin
INADA Naoki added the comment:
Maybe, `socket.getfqdn()` returns non-ASCII string in your environment.
smtpd.py has `-u` option which enables utf-8 support.
smtpd.SMTPServer has enable_SMTPUTF8 option.
test_logging.TestSMTPServer should enable this option.
Could you test adding
INADA Naoki added the comment:
Updated, based on 102241:908b801f8a62
--
nosy: +naoki
Added file: http://bugs.python.org/file43599/call_method_2.patch
___
Python tracker
<http://bugs.python.org/issue26
INADA Naoki added the comment:
Oops, previous patch doesn't update magic number in PC/launcher.c
Should I update it? Or don't touch it to avoid additional conflicts?
--
Added file: http://bugs.python.org/file43601/call_method_3.patch
New submission from INADA Naoki:
PyDict_SetDefault() was added Python 3.4
Currently, PyUnicode_InternInPlace() uses PyDict_GetItem, and PyDict_SetItem if
no item found.
It can be replaced PyDict_SetDefault() easily.
--
components: Interpreter Core
files: intern-setdefault.patch
INADA Naoki added the comment:
Thank you for pointing it out.
That comment seems useless when removing PyDict_GetItem(). So I removed it.
--
Added file: http://bugs.python.org/file43634/intern-setdefault2.patch
___
Python tracker
<h
INADA Naoki added the comment:
I'm working on this. Some bugs are fixed, but doesn't pass tests for now.
https://github.com/methane/cpython/pull/5
--
nosy: +methane
___
Python tracker
<http://bugs.python.o
INADA Naoki added the comment:
Passing all tests now.
Yury, could you explain what the comment "This isn't a Future class; it's a
BaseFuture" means?
Should it be "_futures.Future" or "_futures.BaseFuture"?
--
_
INADA Naoki added the comment:
Should I send pull request to github.com/python/asyncio?
Or should I post patch here?
--
___
Python tracker
<http://bugs.python.org/issue26
INADA Naoki added the comment:
OK. Here is current version.
--
Added file: http://bugs.python.org/file43670/futures.patch
___
Python tracker
<http://bugs.python.org/issue26
INADA Naoki added the comment:
In my patch, test_asyncio runs against C version Future.
I saw how test_json tests against C version and pure Python version.
But test_asyncio is more larger than test_json.
Before working on it, could someone give me idea to run whole test_asyncio
with and
INADA Naoki added the comment:
Thanks. I'll working on test_asyncio in next few days.
--
___
Python tracker
<http://bugs.python.org/issue26081>
___
___
Pytho
INADA Naoki added the comment:
> asyncio uses loop.create_future() to create sockets. I'd suggest you to
> create two base test classes: one that monkeypatches loop.create_future to
> return pure python Future in its setUp method; an another, that makes
> create_future to r
INADA Naoki added the comment:
docstring says:
The integer is represented using length bytes. An OverflowError is
raised if the integer is not representable with the given number of
bytes.
(Python 3.5.2)
--
nosy: +methane
___
Python tracker
<h
INADA Naoki added the comment:
@mmarkk
Do you read full docstring? It's documented very clearly.
---
int.to_bytes(length, byteorder, *, signed=False) -> bytes
Return an array of bytes representing an integer.
The integer is represented using length bytes. An OverflowError is
raise
New submission from INADA Naoki:
https://docs.python.org/3/faq/design.html#why-does-python-use-methods-for-some-functionality-e-g-list-index-but-functions-for-other-e-g-len-list
> The major reason is history.
...
> but it’s a part of Python, and it’s too late to make such fundamental c
INADA Naoki added the comment:
ping
--
___
Python tracker
<http://bugs.python.org/issue27350>
___
___
Python-bugs-list mailing list
Unsubscribe:
https://mail.pyth
New submission from INADA Naoki:
When bytes(x), bytes_new checks if x is integer via PyNumber_AsSize_t(x).
It cause TypeError internally.
When x is not an integer, especially bytearray or memoryview, the internal
exception cause significant overhead.
# HEAD
$ ./python -m timeit -s '
INADA Naoki added the comment:
I see, and I'm sorry about that.
--
___
Python tracker
<http://bugs.python.org/issue27350>
___
___
Python-bugs-list m
INADA Naoki added the comment:
Yury, could you review this before 3.6a4?
--
___
Python tracker
<http://bugs.python.org/issue26081>
___
___
Python-bugs-list mailin
INADA Naoki added the comment:
Thanks for comments.
--
Added file: http://bugs.python.org/file44059/fast-bytearray-fromobject.patch
___
Python tracker
<http://bugs.python.org/issue27
INADA Naoki added the comment:
> Left a couple of comments; the important one -- Future.__await__ (and
> Future.__iter__) should always return a *new* instance of a generator-like
> object (tied to the Future object).
Implementing full behavior of generator seems difficult to
INADA Naoki added the comment:
Implemented FutureIter
--
Added file: http://bugs.python.org/file44081/futures.patch
___
Python tracker
<http://bugs.python.org/issue26
Changes by INADA Naoki :
Added file: http://bugs.python.org/file44086/compact-dict.patch
___
Python tracker
<http://bugs.python.org/issue27350>
___
___
Python-bugs-list m
Changes by INADA Naoki :
Added file: http://bugs.python.org/file44110/compact-dict.patch
___
Python tracker
<http://bugs.python.org/issue27350>
___
___
Python-bugs-list m
Changes by INADA Naoki :
Added file: http://bugs.python.org/file44194/compact-dict.patch
___
Python tracker
<http://bugs.python.org/issue27350>
___
___
Python-bugs-list m
INADA Naoki added the comment:
There are only two weeks until 3.6 beta.
Yury, could you review this again?
Or should I implement freelist before review?
Implementing freelist may be easy, but measuring the effect of freelist from
realistic application is not easy
Changes by INADA Naoki :
Added file: https://bugs.python.org/file44259/compact-dict.patch
___
Python tracker
<https://bugs.python.org/issue27350>
___
___
Python-bug
Changes by INADA Naoki :
Added file: https://bugs.python.org/file44267/compact-dict.patch
___
Python tracker
<https://bugs.python.org/issue27350>
___
___
Python-bug
Changes by INADA Naoki :
--
nosy: +naoki
___
Python tracker
<http://bugs.python.org/issue17636>
___
___
Python-bugs-list mailing list
Unsubscribe:
2701 - 2800 of 3039 matches
Mail list logo
