INADA Naoki added the comment:
> A dictionary (treated as a synonym for dict) can't have an order different
> than insertion order, because that is one of the guarantees a *dictionary*
> provides.
When subclassing dict and overrides `__iter__` etc., the subclass is dic
INADA Naoki added the comment:
List is documented in “sequence” section and O(1) index access is typical for
sequences. At least, every builtin types have it.
So adding such note only to list seems a bit curious to me.
--
nosy: +inada.naoki
INADA Naoki added the comment:
In case of "difference with linked-list", I don't want to make list definition
longer and longer for readers only small part of people. I think that's why
difference with "linked-list" is documented only in glossary.
By addin
INADA Naoki added the comment:
Andrés Delfino :
>
> Andrés Delfino added the comment:
>
> IMHO, if we deem it useful for users not to expect the time complexity of
> a linked list for list elements access to the extent of adding a comment in
> the glossary, there's no
INADA Naoki added the comment:
Andrés, you seems making pull request to document at very high pace.
First of all, thank you for trying improving document.
But some of your pull request seems very little benefit for most readers. Your
motivation seems consistency than real people.
In PEP 8
INADA Naoki added the comment:
New changeset 5092439c2cb32112a5869b138011d38491db90a9 by INADA Naoki (Andrés
Delfino) in branch 'master':
bpo-33892: Doc: Use gender neutral words (GH-7770)
https://github.com/python/cpython/commit/5092439c2cb32112a5869b138011d38491db90a9
-
INADA Naoki added the comment:
Andrés, would you create PR for 2.7?
It can't be backported automatically.
--
___
Python tracker
<https://bugs.python.org/is
INADA Naoki added the comment:
New changeset 60c888d0eb673272920fa3b33f6e5b176d217dc9 by INADA Naoki (Andrés
Delfino) in branch '2.7':
bpo-33892: Doc: Use gender neutral words (GH-7770)
https://github.com/python/cpython/commit/60c888d0eb673272920fa3b33f6e5b
INADA Naoki added the comment:
thanks
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
New submission from INADA Naoki :
New changeset e57f91a0f0d5700ec466c9dd0fd2d2b5323a5e76 by INADA Naoki in branch
'master':
bpo-33866: enum: Stop using OrderedDict (GH-7698)
https://github.com/python/cpython/commit/e57f91a0f0d5700ec466c9dd0fd2d2
Change by INADA Naoki :
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
INADA Naoki added the comment:
> IMO we should create new issues for AC conversion of the collections and
> random modules (assuming they haven't been converted yet), and close this
> issue.
I agree with you. Let's finish derby.
--
___
Change by INADA Naoki :
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
INADA Naoki added the comment:
New changeset 698865dcbb302ae742b76be883822f1563764ff9 by INADA Naoki in branch
'master':
bpo-33843: Remove deprecated stuff in cgi module (GH-7662)
https://github.com/python/cpython/commit/698865dcbb302ae742b76be883822f
Change by INADA Naoki :
--
pull_requests: +7408
___
Python tracker
<https://bugs.python.org/issue17237>
___
___
Python-bugs-list mailing list
Unsubscribe:
INADA Naoki added the comment:
In _lzmamodule.c
self->lock = PyThread_allocate_lock();
This seems leak some resource. But I'm not sure this lock contains refcnt on
Windows.
--
nosy: +inada.naoki
___
Python tracker
<https://bugs
INADA Naoki added the comment:
I think I can describe what two function does/for.
But I'm not good English writer. Would you write document instead?
---
"Finalizer" is __del__ in Python and tp_finalize in C.
Calling finalizer requires some tricks, including avoiding call
Change by INADA Naoki :
--
nosy: +inada.naoki
___
Python tracker
<https://bugs.python.org/issue33865>
___
___
Python-bugs-list mailing list
Unsubscribe:
INADA Naoki added the comment:
When I grepped "Unknown encoding 874", I see some people got trouble from
anaconda installation.
I don't know about what anaconda setup does, but it will not happen on normal
CPython.
We use UTF-8 by default on Windows, for fsencoding and c
INADA Naoki added the comment:
I grepped PYTHONIOENCODING and found this line.
https://github.com/conda/conda/blob/082fe8fd7458ecd9dd7547749039f4b1f06d76db/conda/activate.py#L726
--
___
Python tracker
<https://bugs.python.org/issue33
INADA Naoki added the comment:
I found original pull request and issue report
https://github.com/conda/conda/pull/4558
https://github.com/ContinuumIO/anaconda-issues/issues/1410
--
___
Python tracker
<https://bugs.python.org/issue33
Change by INADA Naoki :
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
versions: -Python 3.6
___
Python tracker
<https://bugs.python.or
Change by INADA Naoki :
--
versions: +Python 2.7, Python 3.7, Python 3.8
___
Python tracker
<https://bugs.python.org/issue33958>
___
___
Python-bugs-list mailin
INADA Naoki added the comment:
thanks
--
nosy: +inada.naoki
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
INADA Naoki added the comment:
New changeset 461a1c4b497e5e118ebb6b77eb59348cc4ec83f9 by INADA Naoki in branch
'master':
bpo-33842: Remove tarfile.filemode (GH-7661)
https://github.com/python/cpython/commit/461a1c4b497e5e118ebb6b77eb5934
Change by INADA Naoki :
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
INADA Naoki added the comment:
I think this is not only chm, but same to all HTML based (online, zipped html,
maybe ePub).
max-width was added for readability.
https://github.com/python/python-docs-theme/issues/4
There are no absolute right answer and there are many personal preferences
INADA Naoki added the comment:
It seems PR author removed his repository and the PR can't be merge via
conflict.
In master branch:
02:18 $ ll **/*.png
-rw-r--r-- 1 inada-n staff 3732 7 1 02:13 faq/python-video-icon.png
-rwxr-xr-x 1 inada-n staff 49648 7 1 02:09
INADA Naoki added the comment:
Hmm, I want to deprecate chm because it uses legacy HTML (doesn't support
UTF-8!), hard to build, hard to confirm issues
--
___
Python tracker
<https://bugs.python.org/is
INADA Naoki added the comment:
03:19 $ find . -name '*.png' | xargs optipng -o7
03:20 $ ll **/*.png
-rw-r--r-- 1 inada-n staff 2888 7 1 03:20 faq/python-video-icon.png
-rw-r--r-- 1 inada-n staff 22058 7 1 03:20 howto/logging_flow.png
-rw-r--r-- 1 inada-n staff 11146
Change by INADA Naoki :
--
keywords: +patch
pull_requests: +7641
stage: -> patch review
___
Python tracker
<https://bugs.python.org/issue30660>
___
___
Py
INADA Naoki added the comment:
I prefer limiting width on browser, but I'm OK to remove limitation from chm
files.
Rational:
Changing window size to control line width for readable length is bad UX
because all modern browsers are tabbed. Or it may be impossible on iPad.
On the other
INADA Naoki added the comment:
New changeset c6cd164cffedb306a4c6644d9d03072f24da246d by INADA Naoki in branch
'master':
bpo-30660: Doc: Optimize PNG files by optipng (GH-8032)
https://github.com/python/cpython/commit/c6cd164cffedb306a4c6644d9d0307
Change by INADA Naoki :
--
assignee: -> docs@python
components: +Documentation
nosy: +docs@python
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
versions: +Python 3.8 -Python 3.7
___
Python tra
INADA Naoki added the comment:
http://www.sphinx-doc.org/en/master/theming.html#builtin-themes
> body_max_width (int or str): Maximal width of the document body. This can be
> an int, which is interpreted as pixels or a valid CSS dimension string such
> as ‘70em’ or ‘50%’. Use ‘non
INADA Naoki added the comment:
I think "See also" is better than sidebar.
Many other sections in data-model chapter have it.
--
nosy: +inada.naoki
___
Python tracker
<https://bugs.python.o
INADA Naoki added the comment:
Nice catch.
I confirmed this is a hard regression of performance.
Decompressing a file must be O(n) when n=filesize, but O(n^2) now.
While we live with this regression for a long time, I feel it's worth enough to
backport.
This can be DoS vulnerability.
Change by INADA Naoki :
--
resolution: -> out of date
stage: -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.org/issue25345>
___
___
INADA Naoki added the comment:
I think we can't fix this until Python 4.
May I close this issue as "won't fix" for now?
Or can we add "Python 4" keyword to list backward incompatible changes we want
to do in the future?
--
nosy: +inada.naoki
ver
Change by INADA Naoki :
--
keywords: +patch
pull_requests: +7667
stage: -> patch review
___
Python tracker
<https://bugs.python.org/issue33418>
___
___
Py
INADA Naoki added the comment:
I'm not sure this should be backported to 3.6 and 2.7.
While this is a obvious bug, f.__module__ = f seems very unnatural.
--
nosy: +inada.naoki
___
Python tracker
<https://bugs.python.org/is
Change by INADA Naoki :
--
versions: -Python 3.4, Python 3.5
___
Python tracker
<https://bugs.python.org/issue34010>
___
___
Python-bugs-list mailing list
Unsub
INADA Naoki added the comment:
In case repro2, unreturned memory is in glibc malloc.
jemalloc mitigates this issue.
There are some fragmentation in pymalloc, but I think it's acceptable level.
$ python3 -B repro2.py
ready
1079124
VmHWM: 1079124 kB
VmRSS: 83588 kB
$ LD_PRELOAD=/us
INADA Naoki added the comment:
since anon_city_hoods has massive constants, compiler_add_const makes dict
larger and larger. It creates many large tuples too.
I suspect it makes glibc malloc unhappy.
Maybe, we can improve pymalloc for medium and large objects, by porting
strategy from
INADA Naoki added the comment:
New changeset 3c452404ae178b742967589a0bb4a5ec768d76e0 by INADA Naoki in branch
'master':
bpo-33418: Add tp_clear for function object (GH-8058)
https://github.com/python/cpython/commit/3c452404ae178b742967589a0bb4a5
Change by INADA Naoki :
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
versions: -Python 2.7, Python 3.6, Python 3.7
___
Python tracker
<https://bugs.python.or
Change by INADA Naoki :
--
keywords: +3.2regression
title: tarfile stream read performance -> tarfile stream read performance
regression
___
Python tracker
<https://bugs.python.org/issu
INADA Naoki added the comment:
New changeset 12a08c47601cadea8e7d3808502cdbcca87b2ce2 by INADA Naoki
(hajoscher) in branch 'master':
bpo-34010: Fix tarfile read performance regression (GH-8020)
https://github.com/python/cpython/commit/12a08c47601cadea8e7d3808502cdb
INADA Naoki added the comment:
thanks
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Change by INADA Naoki :
--
components: Library (Lib)
nosy: inada.naoki
priority: normal
severity: normal
status: open
title: Optimize tarfile uncompression performance
type: performance
versions: Python 3.8
___
Python tracker
<ht
Change by INADA Naoki :
--
keywords: +patch
pull_requests: +7690
stage: -> patch review
___
Python tracker
<https://bugs.python.org/issue34043>
___
___
Py
New submission from INADA Naoki :
tarfile._Stream has two buffer for compressed and uncompressed data.
Those buffers are not aligned so unnecessary bytes slicing happens
for every reading chunks.
This commit bypass compressed buffering.
In this benchmark [1], user time become 250ms from 300ms
INADA Naoki added the comment:
@Victor I think removing unused code is better than adding test for it and
maintain it.
So I removed that unused code block in GH-8089.
--
___
Python tracker
<https://bugs.python.org/issue34
INADA Naoki added the comment:
New changeset 8d130913cb9359c01de412178f9942419e921170 by INADA Naoki in branch
'master':
bpo-34043: Optimize tarfile uncompress performance (GH-8089)
https://github.com/python/cpython/commit/8d130913cb9359c01de412178f9942
Change by INADA Naoki :
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
INADA Naoki added the comment:
In C version, we don't use key func.
items = PyMapping_Items(dct);
if (items == NULL)
goto bail;
if (s->sort_keys && PyList_Sort(items) < 0) {
Like that, how about removing key function completely?
--
Change by INADA Naoki :
--
keywords: +patch
pull_requests: +7709
stage: -> patch review
___
Python tracker
<https://bugs.python.org/issue23493>
___
___
Py
INADA Naoki added the comment:
I can't confirm significant performance benefit.
sort_keys is not bottleneck of pure Python encoder.
BTW, benefit from C encoder is more significant. It's about 3x faster.
Adding `indent` option support to C encoder may be good target for new
contri
INADA Naoki added the comment:
New changeset e25399b40cd15620e77c9ad2ed24549006ae9b47 by INADA Naoki in branch
'master':
bpo-23493: json: Change sort_keys in Python encoder same to C (GH-8131)
https://github.com/python/cpython/commit/e25399b40cd15620e77c9ad2ed2454
INADA Naoki added the comment:
I'm not expert of this area, but Korean support is still totally broken:
>>> import unicodedata
>>> s = "\u1100\u1161\u11a8"
>>> unicodedata.east_asian_width(s[0])
'W'
>>> unicodedata.east_asian_wid
Change by INADA Naoki :
--
title: CJK support for textwrap -> Use unicodedata.east_asian_width in textwrap
versions: +Python 3.8 -Python 3.7
___
Python tracker
<https://bugs.python.org/issu
INADA Naoki added the comment:
Thanks, Terry.
I have doubt about "east asian width" support should be merged.
While I agree it is "better than nothing", it may make textwrap much slower.
But I didn't have courage to reject the PR.
Textwrap focused on ASCII and Engl
INADA Naoki added the comment:
Signature mismatch should raise TypeError, not IndexError.
I think this should be backported to 3.6 and 3.7.
--
nosy: +inada.naoki
versions: +Python 3.7, Python 3.8
___
Python tracker
<https://bugs.python.
INADA Naoki added the comment:
New changeset 445f1b35ce8461268438c8a6b327ddc764287e05 by INADA Naoki (Dong-hee
Na) in branch 'master':
bpo-33967: Fix singledispatch raised IndexError when no args (GH-8184)
https://github.com/python/cpython/commit/445f1b35ce8461268438c8a6b327dd
Change by INADA Naoki :
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
INADA Naoki added the comment:
New changeset 5ac9e6eee5ed18172d70d28cf438df0be4e3b83d by INADA Naoki in branch
'master':
bpo-33597: Reduce PyGC_Head size (GH-7043)
https://github.com/python/cpython/commit/5ac9e6eee5ed18172d70d28cf438df
Change by INADA Naoki :
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
INADA Naoki added the comment:
Is this issue for only known marshal issue?
Or is this issue for all issues in distutils including unknowns?
--
nosy: +inada.naoki
___
Python tracker
<https://bugs.python.org/issue34
Change by INADA Naoki :
--
pull_requests: +7764
___
Python tracker
<https://bugs.python.org/issue34033>
___
___
Python-bugs-list mailing list
Unsubscribe:
INADA Naoki added the comment:
It's difficult to investigate without reproducible example.
Do you use 3rd party extension module?
Typical cause of these crash is bug in 3rd party extensions.
--
nosy: +inada.naoki
___
Python tracker
&
Change by INADA Naoki :
--
pull_requests: +7772
___
Python tracker
<https://bugs.python.org/issue33597>
___
___
Python-bugs-list mailing list
Unsubscribe:
INADA Naoki added the comment:
If example cannot be small, you can share the project on Github or other place.
If your project is private, you can create OSS version of reproducer.
If you can't create OSS reproducer, we can't debug it.
3rd party library list may helpful, but I&
INADA Naoki added the comment:
I doubt that interning cause reproduciblity problem.
AFAIK, all strings in code object are interned or not
interned deterministically.
https://bugzilla.opensuse.org/show_bug.cgi?id=1049186
This issue seems be caused by w_ref() based on object refcnt,
not
INADA Naoki added the comment:
New changeset d5c875bbf1ef9b24349d3243b1ffaab6a9d5a78e by INADA Naoki in branch
'master':
bpo-33597: Add What's New for PyGC_Head (GH-8236)
https://github.com/python/cpython/commit/d5c875bbf1ef9b24349d3243b
Change by INADA Naoki :
--
nosy: -inada.naoki
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
versions: +Python 3.8 -Python 3.7
___
Python tracker
<https://bugs.python.or
INADA Naoki added the comment:
New changeset 09b2bece78f62c3d363236dce593ecfe130afd2f by INADA Naoki
(Chih-Hsuan Yen) in branch 'master':
bpo-29442: Replace optparse with argparse in setup.py (GH-139)
https://github.com/python/cpython/commit/09b2bece78f62c3d363236dce593ec
INADA Naoki added the comment:
New changeset 5e5bbbec467a1569c914a048a94e7597528f92cf by INADA Naoki (Stig
Johan Berggren) in branch 'master':
bpo-34083: Update dict order in Functional HOWTO (GH-8230)
https://github.com/python/cpython/commit/5e5bbbec467a1569c914a048a94e75
INADA Naoki added the comment:
Thanks, Stig.
And I'm sorry about I missed Raymond assigned himself.
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.pyth
Change by INADA Naoki :
--
components: Extension Modules
nosy: inada.naoki
priority: normal
severity: normal
status: open
title: Reproducible pyc: FLAG_REF is not stable.
versions: Python 3.8
___
Python tracker
<https://bugs.python.org/issue34
Change by INADA Naoki :
--
keywords: +patch
pull_requests: +7779
stage: -> patch review
___
Python tracker
<https://bugs.python.org/issue34093>
___
___
Py
INADA Naoki added the comment:
OK, I created sub issue for pyc.
--
dependencies: +Reproducible pyc: FLAG_REF is not stable., remove *_INTERNED
opcodes from marshal
___
Python tracker
<https://bugs.python.org/issue34
New submission from INADA Naoki :
PR-8226 makes marshal two-pass. It may have small overhead.
In case of compiling module, marshal performance is negligible.
But how in other cases? Should this change optional?
And should we backport this to Python 3.7?
Or should distributors cherrypick
INADA Naoki added the comment:
New changeset b91a3a0d61596cafb1b46c98fab65fee16a8 by INADA Naoki (Eitan
Adler) in branch 'master':
bpo-33648: Remove PY_WARN_ON_C_LOCALE (GH-7114)
https://github.com/python/cpython/commit/b91a3a0d61596cafb1b46c98fab65fee16a8
-
INADA Naoki added the comment:
thanks
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
INADA Naoki added the comment:
Hm, it seems safe to backport.
--
___
Python tracker
<https://bugs.python.org/issue33648>
___
___
Python-bugs-list mailin
Change by INADA Naoki :
--
versions: +Python 3.7
___
Python tracker
<https://bugs.python.org/issue33648>
___
___
Python-bugs-list mailing list
Unsubscribe:
INADA Naoki added the comment:
marshal: Mean +- std dev: [master] 123 us +- 7 us -> [patched] 173 us +- 2 us:
1.41x slower (+41%)
compile+marshal: Mean +- std dev: [master] 5.28 ms +- 0.02 ms -> [patched] 5.47
ms +- 0.34 ms: 1.04x slower (+4%)
--
Added file: https://bugs.pyth
INADA Naoki added the comment:
Thank you for finding it.
I had worked on constant merging. [1]
It didn't fix this case for now. I'll continue the suspended work.
[1]: https://github.com/methane/cpython/pull/14/files
But it may be a too big to fix only this regression.
H
INADA Naoki added the comment:
New changeset 9e9b2c32a34594e901b5b9a03c561a2a2bf63ece by INADA Naoki (Zackery
Spytz) in branch 'master':
bpo-33967: Remove use of deprecated assertRaisesRegexp() (GH-8261)
https://github.com/python/cpython/commit/9e9b2c32a34594e901b5b9a03c561a
Change by INADA Naoki :
--
components: +Interpreter Core
keywords: +3.7regression
title: Python doesn't intern integers in a tuple of constant literals -> Same
integers in a tuple of constant literals are not merged
type: behavior -> resource usage
versions:
INADA Naoki added the comment:
OK, unless example code this regression affects seriously is shown, I target
only 3.8.
--
versions: -Python 3.7
___
Python tracker
<https://bugs.python.org/issue34
INADA Naoki added the comment:
FYI, same constants are shared even when they are in different tuples on 3.6.
For modules having large constant table containing large integer or floats, non
name-like string, and bytes are affected significantly
Change by INADA Naoki :
--
nosy: +benjamin.peterson, serhiy.storchaka
___
Python tracker
<https://bugs.python.org/issue34093>
___
___
Python-bugs-list mailin
INADA Naoki added the comment:
> STINNER Victor added the comment:
>
> According to Serhiy Storchaka, currently marshal.dumps() writes frozenset in
> arbitrary order, and so frozenset serialization is not reproducible:
> https://mail.python.org/pipermail/python-dev/2018-J
INADA Naoki added the comment:
> STINNER Victor added the comment:
>
> What is the time spent in marshal.dumps() at Python startup when Python has
> to create all .pyc files? For example "./python -c pass" in the master branch
> with no external dependency? My qu
Change by INADA Naoki :
--
title: Same integers in a tuple of constant literals are not merged -> Same
constants in tuples are not merged while compile()
___
Python tracker
<https://bugs.python.org/issu
INADA Naoki added the comment:
Would you provide list of extension modules?
What happens when removing some of them?
--
___
Python tracker
<https://bugs.python.org/issue34
INADA Naoki added the comment:
Hmm, all segfault are happend on macOS?
--
___
Python tracker
<https://bugs.python.org/issue34087>
___
___
Python-bugs-list mailin
INADA Naoki added the comment:
inada-n@rinrin:~/t$ ../pyenv/versions/3.7.0/bin/python ../fset.py
['/home/inada-n', '/home/inada-n/pyenv/versions/3.7.0/lib/python37.zip',
'/home/inada-n/pyenv/versions/3.7.0/lib/python3.7',
'/home/inada-n/pyenv/versi
INADA Naoki added the comment:
@jonash, Thank you. Would you share core file too?
You can get core file when reproducing it after `ulimit -c unlimited`.
My mail address is "songofacandy [at] gmail.com".
Please share it via Dropbox or Go
2101 - 2200 of 3039 matches
Mail list logo