Change by Inada Naoki :
--
nosy: +pitrou
___
Python tracker
<https://bugs.python.org/issue36694>
___
___
Python-bugs-list mailing list
Unsubscribe:
Inada Naoki added the comment:
Could you paste how the test fails?
--
nosy: +inada.naoki
___
Python tracker
<https://bugs.python.org/issue36778>
___
___
Pytho
Inada Naoki added the comment:
@Victor It seems you added cp65001 as Windows-only encoding in bpo-13216.
How do you think about removing cp65001 encoding, and add 'cp65001' -> 'utf_8'
alias which is available on all platforms?
---
Inada Naoki added the comment:
FYI, https://github.com/python/cpython/pull/7773#issuecomment-398262396
--
nosy: +inada.naoki
___
Python tracker
<https://bugs.python.org/issue36
Change by Inada Naoki :
--
keywords: +patch
pull_requests: +13018
stage: -> patch review
___
Python tracker
<https://bugs.python.org/issue36684>
___
___
Py
Inada Naoki added the comment:
FYI, I expect cp65001 will be used more widely in near future,
because non UTF-8 default encoding reduced Developer eXperience,
and Microsoft try to improve DX recent years.
Today, Microsoft announced new Terminal application.
It seems use `SetConsoleOutputCP
Inada Naoki added the comment:
This bug is happened only on x86, not amd64.
--
___
Python tracker
<https://bugs.python.org/issue33153>
___
___
Python-bugs-list m
Inada Naoki added the comment:
@Eryk I didn't say new Terminal will cause this issue. I know ConsoeIO too.
I just meant Microsoft use cp65001 more widely for better UTF-8 support
nowadays.
So I want to make cp65001 as alias of UTF-8.
> Python could similarly special case CP_UTF8 a
Inada Naoki added the comment:
> I dislike lying in the locale module. This change is basically useless with
> my PR 13230.
Note that Python produce "cpNNN" encoding name, not Windows.
https://github.com/python/cpython/blob/137be34180a20dba53948d126b961069f299f153/Modules
Inada Naoki added the comment:
New changeset a2fedd8c910cb5f5b9bd568d6fd44d63f8f5cfa5 by Inada Naoki (Emmanuel
Arias) in branch 'master':
bpo-36869: fix warning of unused variables (GH-13182)
https://github.com/python/cpython/commit/a2fedd8c910cb5f5b9bd568d6fd44d63f8f5cfa5
-
Inada Naoki added the comment:
New changeset 87068ed00927bdeaa2ae556e4241c16cf8a845eb by Inada Naoki (Gordon
P. Hemsley) in branch 'master':
bpo-36684: Split out gcc and test coverage builds (GH-13146)
https://github.com/python/cpython/commit/87068ed00927bdeaa2ae556e4241c1
Change by Inada Naoki :
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Inada Naoki added the comment:
Why is sitevendor required in addition to sitecustomize?
--
nosy: +inada.naoki
___
Python tracker
<https://bugs.python.org/issue36
Inada Naoki added the comment:
> vx1920 added the comment:
>
> "sitevendor" is required because "sitecustomize" already "taken": imagine
> organization XYZ , they install Python/Anaconda for workers in XYZ. Admin
> in XYZ places some XYZ-specific c
Inada Naoki added the comment:
$ ./python -m perf compare_to master-mem.json align16-mem.json -G --min-speed=2
Slower (30):
- float: 20.6 MB +- 12.6 kB -> 23.8 MB +- 30.3 kB: 1.16x slower (+16%)
- mako: 14.3 MB +- 760.5 kB -> 15.1 MB +- 54.1 kB: 1.06x slower (+6%)
- xml_etree_iterparse
Inada Naoki added the comment:
$ ./python -m perf compare_to master.json align16.json -G --min-speed=1
Slower (13):
- pickle_list: 4.40 us +- 0.03 us -> 4.59 us +- 0.04 us: 1.04x slower (+4%)
- xml_etree_iterparse: 129 ms +- 2 ms -> 133 ms +- 2 ms: 1.04x slower (+4%)
- regex_dna: 201 m
Inada Naoki added the comment:
New changeset f0be4bbb9b3cee876249c23f2ae6f38f43fa7495 by Inada Naoki in branch
'master':
bpo-27987: pymalloc: align by 16bytes on 64bit platform (GH-12850)
https://github.com/python/cpython/commit/f0be4bbb9b3cee876249c23f2ae6f3
Inada Naoki added the comment:
yes. sys.getsizeof(3.14) is 24. And it becomes 32 byte in 16byte aligned
pymalloc. (+33%)
FYI, jemalloc has 8, 16, 32 size classes, but no 24 too.
http://jemalloc.net/jemalloc.3.html#size_classes
--
___
Python
Inada Naoki added the comment:
New changeset 5e48e3db6f5a937023e99d89cef8884d22bd8533 by Inada Naoki (Nicolai
Moore) in branch 'master':
bpo-36845: validate integer network prefix when constructing IP networks
(GH-13298)
https://github.com/python/cpyt
Inada Naoki added the comment:
New changeset 30cccf084d1560d9e3382e69d828b3be8cdb0286 by Inada Naoki (Miss
Islington (bot)) in branch '3.7':
bpo-36845: validate integer network prefix when constructing IP networks
(GH-13298)
https://github.com/python/cpyt
Change by Inada Naoki :
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Change by Inada Naoki :
--
pull_requests: +13247
___
Python tracker
<https://bugs.python.org/issue27987>
___
___
Python-bugs-list mailing list
Unsubscribe:
Change by Inada Naoki :
--
pull_requests: +13248
___
Python tracker
<https://bugs.python.org/issue27987>
___
___
Python-bugs-list mailing list
Unsubscribe:
Change by Inada Naoki :
--
pull_requests: -13146
___
Python tracker
<https://bugs.python.org/issue36338>
___
___
Python-bugs-list mailing list
Unsubscribe:
Inada Naoki added the comment:
New changeset bfba8c373e362d48d4ee0e0cf55b8d9c169344ae by Inada Naoki in branch
'master':
bpo-36748: optimize TextIOWrapper.write() for ASCII string (GH-13002)
https://github.com/python/cpython/commit/bfba8c373e362d48d4ee0e0cf55b8d
Change by Inada Naoki :
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
INADA Naoki added the comment:
New changeset ae12f5d4c98f2095c2aadd58981453e955044697 by INADA Naoki
(yahya-abou-imran) in branch 'master':
bpo-32473: Improve ABCMeta._dump_registry() readability (GH-5091)
https://github.com/python/cpython/commit/ae12f5d4c98f2095c2aadd58981453
INADA Naoki added the comment:
As my understand, this patch creates cache for all classe,
not only for parent classes.
Caches may has much tuples, and they are GC tracked because
they contains function descriptors. And they actually creates
reference cycles.
Am I correct?
If so, I want
INADA Naoki added the comment:
New changeset a91662affeb0aae2515cdc5e8f82269337105bf4 by INADA Naoki (Miss
Islington (bot)) in branch '3.6':
bpo-32473: Improve ABCMeta._dump_registry() readability (GH-5091)
https://github.com/python/cpython/commit/a91662affeb0aae2515cdc5e8f8226
Change by INADA Naoki :
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
INADA Naoki added the comment:
> Note this is really a worst-case benchmark: lots of classes, no methods, no
> user data beside the classes.
Since benchgcclasses.py doesn't creates dunder methods,
cache doesn't have GC-tracked tuples, and ref cycles.
benchgcclasses2.py a
New submission from INADA Naoki :
ABCMeta.__new__ calls `getattr(value, "__isabstractmethod__", False)` many
times.
https://github.com/python/cpython/blob/0f31c74fcfdec8f9e6157de2c366f2273de81677/Lib/abc.py#L135-L142
Since metaclass is used by subclasses, it checks all memb
Change by INADA Naoki :
--
keywords: +patch
pull_requests: +5026
stage: -> patch review
___
Python tracker
<https://bugs.python.org/issue32544>
___
___
Python-
INADA Naoki added the comment:
I run pyperformance.
It seems django_template is significant faster.
# Without PGO+LTO
./python -m perf compare_to -G --min-speed=2 default.json patched.json
Slower (6):
- scimark_monte_carlo: 217 ms +- 9 ms -> 237 ms +- 10 ms: 1.09x slower (+9%)
- scimark
INADA Naoki added the comment:
FYI, jemalloc can reduce memory usage, especially when application
is multithreaded.
https://www.speedshop.co/2017/12/04/malloc-doubles-ruby-memory.html
https://zapier.com/engineering/celery-python-jemalloc/
--
nosy: +inada.naoki
INADA Naoki added the comment:
New changeset 378edee0a3b913d60653dc17dfe61d83405a8135 by INADA Naoki in branch
'master':
bpo-32544: Speed up hasattr() and getattr() (GH-5173)
https://github.com/python/cpython/commit/378edee0a3b913d60653dc17dfe61d
Change by INADA Naoki :
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
INADA Naoki added the comment:
I confirmed django_template is `hasattr`-heavy benchmark.
Functionwas called by...
ncalls tottime cumtime
{built-in method builtins.hasattr} <- 10.0000.000
/home/inada-n/lo
INADA Naoki added the comment:
I didn't notice this is implemented.
Congrats, Ivan!
BTW, would you update the PEP status to Final?
--
nosy: +inada.naoki
___
Python tracker
<https://bugs.python.org/is
New submission from INADA Naoki :
Since PEP 562 is implemented, we can use lazy imports easily.
Asyncio uses concurrent.futures.Future and
concurrent.futures.ThreadPoolExecutor,
but not concurrent.futures.ProcessPoolExecutor by default.
Since importing concurrent.futures.process is slow, I
Change by INADA Naoki :
--
keywords: +patch
pull_requests: +5087
stage: -> patch review
___
Python tracker
<https://bugs.python.org/issue32596>
___
___
Python-
INADA Naoki added the comment:
New changeset 6690bb9f17d34eb3dec0aca8919d8d27d6c3c452 by INADA Naoki in branch
'master':
bpo-32596: Lazy import concurrent.futures.process and thread (GH-5241)
https://github.com/python/cpython/commit/6690bb9f17d34eb3dec0aca8919d8d
Change by INADA Naoki :
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Change by INADA Naoki :
--
nosy: +inada.naoki
___
Python tracker
<https://bugs.python.org/issue32616>
___
___
Python-bugs-list mailing list
Unsubscribe:
INADA Naoki added the comment:
For insert/pop loop, reduce table size aggressively on pop may cause
performance regression. So reducing size should be conservative.
So my opinion is:
* When dict size become 0, make the dict shared-empty, like dict.clear()
* When (dict size < dk_size/8), c
Change by INADA Naoki :
--
keywords: +patch
pull_requests: +5144
stage: -> patch review
___
Python tracker
<https://bugs.python.org/issue32623>
___
___
Python-
Change by INADA Naoki :
--
pull_requests: +5147
___
Python tracker
<https://bugs.python.org/issue32623>
___
___
Python-bugs-list mailing list
Unsubscribe:
INADA Naoki added the comment:
> * When dict size become 0, make the dict shared-empty, like dict.clear()
This will cause significant performance regression for `dict[a]=None; del
dict[a]` loop.
del/pop shouldn't do clear().
> * When (dict size < dk_size/8), call insertion_res
INADA Naoki added the comment:
> Should we make sure that all dicts have at least MINSIZE entries?
I don't think so. I think "allocate on first insert" is good idea for
dict.clear()
And I think it's good idea for new dict too:
https://github.com/p
INADA Naoki added the comment:
I think I understand #17563, and I should fix GROWTH_RATE.
Before compact-ordered dict, we can avoid resizing in
"the number of deletions is on a par with the number of insertions."
scenario, by large GROWTH_RATE.
That's because new entry can reus
INADA Naoki added the comment:
New changeset f320be77ffb73e3b9e7fc98c37b8df3975d84b40 by INADA Naoki (Serhiy
Storchaka) in branch 'master':
bpo-32571: Avoid raising unneeded AttributeError and silencing it in C code
(GH-5222)
https://github.com/python/cpyt
Change by INADA Naoki :
--
pull_requests: +5161
___
Python tracker
<https://bugs.python.org/issue32360>
___
___
Python-bugs-list mailing list
Unsubscribe:
INADA Naoki added the comment:
New changeset 2812d3d99287c50bab99625d7240bcf1c2e32369 by INADA Naoki in branch
'master':
bpo-32360: Remove OrderedDict usage from json.tool (GH-5315)
https://github.com/python/cpython/commit/2812d3d99287c50bab99625d7240bc
Change by INADA Naoki :
--
pull_requests: +5162
___
Python tracker
<https://bugs.python.org/issue32596>
___
___
Python-bugs-list mailing list
Unsubscribe:
INADA Naoki added the comment:
New changeset 4666ec597c38eea06a22bcfb4157d92a0abf891c by INADA Naoki in branch
'master':
bpo-32596: Make lazy-load portable (GH-5316)
https://github.com/python/cpython/commit/4666ec597c38eea06a22bcfb4157d9
Change by INADA Naoki :
--
pull_requests: +5178
___
Python tracker
<https://bugs.python.org/issue32571>
___
___
Python-bugs-list mailing list
Unsubscribe:
INADA Naoki added the comment:
New changeset e76daebc0c8afa3981a4c5a8b54537f756e805de by INADA Naoki in branch
'master':
bpo-32571: Fix reading uninitialized memory (GH-5332)
https://github.com/python/cpython/commit/e76daebc0c8afa3981a4c5a8b54537
New submission from INADA Naoki :
int() and str.is*** functions accepts other than ASCII.
But we want to accept only ASCII in some cases. (e.g. ipaddress module)
We can use try-except to check ASCII, but it's inefficient.
try:
s.encode('ascii')
except UnicodeEncodeError:
Change by INADA Naoki :
--
keywords: +patch
pull_requests: +5188
stage: -> patch review
___
Python tracker
<https://bugs.python.org/issue32677>
___
___
Python-
INADA Naoki added the comment:
"Key must be hashable" is precondition of dict operations.
All operations for dict will raise TypeError for unhashable keys.
For example, d[k] will raise TypeError too, but document doesn't
mention about it:
"""
Return the it
New submission from INADA Naoki :
inspect imports ast but it's used only for creating signature.
But asyncio uses inspect module for unwrap(), isgenerator(), etc...
And ast module is relatively heavy for import.
This is output of python -Ximporttime -c 'import asyncio':
import
Change by INADA Naoki :
--
keywords: +patch
pull_requests: +5191
stage: -> patch review
___
Python tracker
<https://bugs.python.org/issue32678>
___
___
Python-
Change by INADA Naoki :
--
title: Add str.isascii() -> Add.isascii() to str, bytes and bytearray
___
Python tracker
<https://bugs.python.org/issue32677>
___
_
INADA Naoki added the comment:
New changeset 37420deb80dcf0fc41a728838b0340b93ca01d90 by INADA Naoki in branch
'master':
bpo-32678: inspect: Import ast lazily (GH-5344)
https://github.com/python/cpython/commit/37420deb80dcf0fc41a728838b0340
Change by INADA Naoki :
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
INADA Naoki added the comment:
New changeset a49ac9902903a798fab4970ccf563c531199c3f8 by INADA Naoki in branch
'master':
bpo-32677: Add .isascii() to str, bytes and bytearray (GH-5342)
https://github.com/python/cpython/commit/a49ac9902903a798fab4970ccf563c
Change by INADA Naoki :
--
pull_requests: +5202
___
Python tracker
<https://bugs.python.org/issue32677>
___
___
Python-bugs-list mailing list
Unsubscribe:
INADA Naoki added the comment:
New changeset bea57060c863d0c3474c79350bd9c557f2ff0e7c by INADA Naoki in branch
'master':
bpo-32677: Optimize str.isascii() (GH-5356)
https://github.com/python/cpython/commit/bea57060c863d0c3474c79350bd9c5
Change by INADA Naoki :
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
INADA Naoki added the comment:
PEP should be accepted before review and merge.
So what you can do is restart discussion on ML again.
--
nosy: +inada.naoki
___
Python tracker
<https://bugs.python.org/issue27
INADA Naoki added the comment:
ML meant mailing list.
There is guide for it.
http://devguide.python.org/communication/
If you really want this new API, you can search previous discussion and post
new mail with summary of the previous discussion
INADA Naoki added the comment:
Please give us reproducible example.
Otherwise, we can't know it's our bug or it's bug of caller.
--
nosy: +inada.naoki
___
Python tracker
<https://bugs.pyt
INADA Naoki added the comment:
It may be bug of raising TimeoutError, not catching.
That's why I want example code to reproduce.
--
___
Python tracker
<https://bugs.python.org/is
INADA Naoki added the comment:
And your screenshot doesn't contain "full" traceback chain.
It can be very important hint about who creates invalid TimeoutError.
--
___
Python tracker
<https://bugs.pyt
INADA Naoki added the comment:
Hmm, can you read this instead?
https://github.com/python/devguide/blob/master/communication.rst
--
___
Python tracker
<https://bugs.python.org/issue27
INADA Naoki added the comment:
> On Linux/Unix, the compile-time headers always consist with the system, so
> there should not has this problem.
> Correct me if I'm wrong.
No. Compile-time and run-time system is not always consist.
Kernel version may be upgraded / downgraded a
INADA Naoki added the comment:
It seems Linux has TCP_KEEPCNT from very old ages and
just checking it's existence was OK for many years.
So I'm +0.5 on this Python-side fix.
--
___
Python tracker
<https://bugs.python.o
INADA Naoki added the comment:
It seems clang4 failed to efficient register assigning.
FYI, --without-computed-gotos configure option make penalty smaller.
clang 5 (wihtout CGs): 2.653426
clang 5 (with CGs): 1.997584
clang 4 (without CGs): 3.330879
clang 4 (with CGs): 8.585673
INADA Naoki added the comment:
> What's about other OS/flags?
> Should we commit that every exposed socket flag is supported in runtime?
It looks like very heavy burden.
I agree with you. It almost impossible.
> Or the issue is specific for TCP_KEEPCNT for Windows only?
INADA Naoki added the comment:
This is assembly code for FAST_DISPATCH()
https://paste.ubuntu.com/26523948/
It seems there are many redundant spills. But I don't know how to remove them.
Are their clang expert?
--
___
Python tracker
&
INADA Naoki added the comment:
Maybe, relating to
https://bugs.launchpad.net/ubuntu/+source/language-pack-zh-hant/+bug/1699540
--
nosy: +inada.naoki
___
Python tracker
<https://bugs.python.org/issue32
INADA Naoki added the comment:
> But even so, I think this bug is still valid, as the lzh_TW does not exist in
> the lib at all.
Python doesn't have locale database, while have some aliases.
Python uses libc's locale.
This exception is raised because `_parse_localename`
INADA Naoki added the comment:
Bad news: --enable-optimization doesn't solve it.
I hope same thing doesn't happen for Python 3.
Anyone tried Xcode 9.3? What version of LLVM does Apple use?
Anyway, I think we need help of LLVM expert.
--
Change by INADA Naoki :
--
keywords: +patch
pull_requests: +5392
stage: -> patch review
___
Python tracker
<https://bugs.python.org/issue32616>
___
___
Python-
INADA Naoki added the comment:
New changeset 2942b909d9a428e6683d90b3436cfa4a81bd5d8a by INADA Naoki in branch
'2.7':
bpo-32616: Disable computed gotos by default for clang < 5 (GH-5574)
https://github.com/python/cpython/commit/2942b909d9a428e6683d90b3436
Change by INADA Naoki :
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
INADA Naoki added the comment:
I'm sorry, my patch doesn't work on Xcode (Apple LLVM).
computed-gotos is still enabled by default.
Apple doesn't expose LLVM version. It's really annoying.
$ cat x.c
#include
int main()
{
printf("__clang__ : %d\n", __clang__
INADA Naoki added the comment:
How can we distinguish Apple LLVM with LLVM easily?
Or should we disable computed-gotos by default on LLVM?
It's only for Python 2.
5x slowdown is too large comparing to 10% speedup.
--
___
Python tracker
&
INADA Naoki added the comment:
I don't know exactly. But as far as I saw, Python 3's eval loop has less
function-wide local variables.
For example, ROT_THREE uses only block local variable.
https://github.com/python/cpython/blob/a48e78a0b7761dd74f1d03fc69e0f6caa6f02fe6/Python/cev
INADA Naoki added the comment:
We missed 3.7 train.
I'm sorry about I couldn't review it. But I have many shine features
I want in 3.7 and I have no time to review all.
Especially, I need to understand tr29. It was hard job to me.
I think publishing this (and any other functions r
INADA Naoki added the comment:
New changeset d019bc8319ea35e93bf4baa38098ff1b57cd3ee5 by INADA Naoki (Oren
Milman) in branch 'master':
bpo-31787: Prevent refleaks when calling __init__() more than once (GH-3995)
https://github.com/python/cpython/commit/d019bc8319ea35e93bf4baa38098ff
Change by INADA Naoki :
--
pull_requests: +5462
___
Python tracker
<https://bugs.python.org/issue31787>
___
___
Python-bugs-list mailing list
Unsubscribe:
INADA Naoki added the comment:
New changeset 47316342417146f62653bc3c3dd505bfacc5e956 by INADA Naoki in branch
'3.6':
bpo-31787: Prevent refleaks when calling __init__() more than once (GH-3995)
https://github.com/python/cpython/commit/47316342417146f62653bc3c3dd505
Change by INADA Naoki :
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
versions: +Python 3.6, Python 3.8
___
Python tracker
<https://bugs.python.or
Change by INADA Naoki :
--
pull_requests: +5463
___
Python tracker
<https://bugs.python.org/issue31787>
___
___
Python-bugs-list mailing list
Unsubscribe:
INADA Naoki added the comment:
New changeset f0bc645dfede8118c84844bad319cd952c4d1905 by INADA Naoki in branch
'master':
bpo-31787: Skip refleak check when _hashlib is not available (GH-5660)
https://github.com/python/cpython/commit/f0bc645dfede8118c84844bad319cd
INADA Naoki added the comment:
lzh_tw was added in this commit:
https://github.com/bminor/glibc/commit/5057e7ce826bb0be3f476408b2ae364042f2a9bb#diff-3d056472e12e5dc464fa44144719b82f
I don't know why Python should have such a large locale alias table.
I added Serhiy to nosy list because
Change by INADA Naoki :
--
nosy: +inada.naoki
___
Python tracker
<https://bugs.python.org/issue32846>
___
___
Python-bugs-list mailing list
Unsubscribe:
INADA Naoki added the comment:
One possible advice; try dict instead of set.
Dict is (surprisingly) little smaller than set.
And dict cleans items in insertion order when the dict is deleted.
--
___
Python tracker
<https://bugs.python.
INADA Naoki added the comment:
> Dict is (surprisingly) little smaller than set.
I'm sorry, I was wrong.
dict is smaller than set only when len(d) is small. (typical case for namespace
dict)
In case of massive keys, dict is larger
1701 - 1800 of 3039 matches
Mail list logo
