INADA Naoki added the comment:
@Luis, would you try dict instead of set? It's little larger than set, but
delete elements by insertion order.
But I don't think builtin data structure can be optimized for such workload.
Maybe, LMBD[1] or some other KVS can help you.
INADA Naoki added the comment:
New changeset 52c6b89796a7ec391db20281e05b256f57e97b35 by INADA Naoki (Harshul
jain) in branch 'master':
bpo-28886: doc: Move deprecated abc decorators to separate section (GH-176)
https://github.com/python/cpython/commit/52c6b89796a7ec391db20281e05b25
INADA Naoki added the comment:
New changeset 7452f6d8fa3ffe5dab20f7e4244851a6eca397be by INADA Naoki (Miss
Islington (bot)) in branch '3.7':
bpo-28886: doc: Move deprecated abc decorators to separate section (GH-176)
https://github.com/python/cpyt
INADA Naoki added the comment:
New changeset 0150dc589439a9a78c80c2aa8d7d6c5d3bba1d6d by INADA Naoki (Miss
Islington (bot)) in branch '3.6':
bpo-28886: doc: Move deprecated abc decorators to separate section (GH-176)
https://github.com/python/cpyt
Change by INADA Naoki :
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
INADA Naoki added the comment:
We have it already:
https://docs.python.org/3/library/stdtypes.html#mapping-types-dict
> A dictionary’s keys are almost arbitrary values. Values that are not
> hashable, that is, values containing lists, dictionaries or other mutable
> types (that are
Change by INADA Naoki :
--
components: +Library (Lib) -IO
versions: +Python 3.8 -Python 3.7
___
Python tracker
<https://bugs.python.org/issue29636>
___
___
Pytho
INADA Naoki added the comment:
I'm OK to options in current pull request.
And I think this bike-shedding discussion is not so important to pay our time
and energy.
Does anyone have strong opinion?
If no, I'll merge the PR.
--
___
Pyth
INADA Naoki added the comment:
AST is changed slightly from Python 3.7.
ast.get_docstring() works for both of 3.6 and 3.7.
$ ./python
Python 3.8.0a0 (heads/master-dirty:451d1edaf4, Feb 22 2018, 21:11:54)
[GCC 7.2.0] on linux
Type "help", "copyright", "credits" or
INADA Naoki added the comment:
ref: https://bugs.python.org/issue29463
--
___
Python tracker
<https://bugs.python.org/issue32911>
___
___
Python-bugs-list mailin
INADA Naoki added the comment:
We implemented AST-level constant folding (#29469) based on the AST change
(#29463).
I feel it's possible to revert AST change without reverting AST constant
folding:
* Docstring is exposed from AST before calling AST optimizer.
* AST optimizer removes u
Change by INADA Naoki :
--
components: +Interpreter Core -Library (Lib)
___
Python tracker
<https://bugs.python.org/issue32911>
___
___
Python-bugs-list mailin
INADA Naoki added the comment:
New changeset 0febc053736112d7bb9081742b3ac0ece7b973e7 by INADA Naoki
(cocoatomo) in branch 'master':
bpo-32087: Doc: Make "deprecated-removed" directive translatable (GH-4473)
https://github.com/python/cpython/commit/0febc053736112d7bb90
Change by INADA Naoki :
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
versions: +Python 3.8
___
Python tracker
<https://bugs.python.or
INADA Naoki added the comment:
I tried this patch:
diff --git a/Python/ast.c b/Python/ast.c
index e2092f0f85..93be2bc839 100644
--- a/Python/ast.c
+++ b/Python/ast.c
@@ -3537,9 +3537,9 @@ docstring_from_stmts(asdl_seq *stmts)
if (s->kind == Expr_kind && s->v.Ex
Change by INADA Naoki :
--
keywords: +patch
pull_requests: +5698
stage: -> patch review
___
Python tracker
<https://bugs.python.org/issue32911>
___
___
Python-
INADA Naoki added the comment:
I'm implementing (2). Please check GH-5927.
--
keywords: -patch
stage: patch review ->
___
Python tracker
<https://bugs.python.org
INADA Naoki added the comment:
Python-list? -dev? -ideas?
--
___
Python tracker
<https://bugs.python.org/issue32911>
___
___
Python-bugs-list mailing list
Unsub
INADA Naoki added the comment:
There are no enough +1 for merging GH-5927 yet on the ML discussion.
https://mail.python.org/pipermail/python-dev/2018-February/152311.html
@Mark.Shannon, would you comment your opinion to the ML thread?
For now, I don't want to break tools supporting Pytho
Change by INADA Naoki :
--
keywords: +patch
pull_requests: +5767
stage: -> patch review
___
Python tracker
<https://bugs.python.org/issue32999>
___
___
Python-
INADA Naoki added the comment:
> BTW, do TypeErrors related to weak references deserve any treatment? Isn't it
> a kind of coincidence that the error raised due to usage of WeakSet in
> issubclass(obj, ABC) is what we expect? (Sorry, I'm not familiar with
> WeakSets
INADA Naoki added the comment:
New changeset fc7df0e664198cb05cafd972f190a18ca422989c by INADA Naoki in branch
'master':
bpo-32999: Fix ABC.__subclasscheck__ crash (GH-6002)
https://github.com/python/cpython/commit/fc7df0e664198cb05cafd972f190a1
Change by INADA Naoki :
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
INADA Naoki added the comment:
Why `issubclass()` doesn't check it? Maybe, non-type class is supported by
Python. But I'm not sure. I'm not meta programming expert.
But we use "duck typing". In this case, if the object (a) supports weakref and
(2) has __mro__
INADA Naoki added the comment:
3e 02 00 00 00 is frozenset(size=2)
72 b6/b5 00 00 00 is reference to b5 or b6
So it seems set order changed. (or items in the set is appearance order is
changed.)
Did you set PYTHONHASHSEED?
Anyway, I think Python 3.7 can't guarantee "reproducibl
INADA Naoki added the comment:
https://bugs.python.org/msg313396
--
___
Python tracker
<https://bugs.python.org/issue33018>
___
___
Python-bugs-list mailin
INADA Naoki added the comment:
issubclass(class-like, class-like) is allowed.
I don't think raising type error for issubclass(class-like, ABC) is good idea.
It should return False.
--
___
Python tracker
<https://bugs.python.org/is
INADA Naoki added the comment:
Hmm, normal class doesn't support issubclass(class-like. class).
```
Python 3.8.0a0 (heads/master:fc7df0e664, Mar 8 2018, 09:00:43)
[GCC 7.2.0] on linux
Type "help", "copyright", "credits" or "license" for more
INADA Naoki added the comment:
> 1. ABCMeta.register() accepts types only.
Yes. While ABC.register() and issubclass() have different users (e.g.
ABC.register() will be used by framework author, and issubclass will be used
by framework users), it's positive reason to remove non-type
INADA Naoki added the comment:
>> Isn't it just a limitation?
>> Most Python-implemented objects supports weakref. I don't think "requiring
>> weakref support implies it must be type object".
> Formally, there is no implication. It is the abc module a
INADA Naoki added the comment:
My current opinion is:
* -1 for 3.6: Behavior should not be changed without strong reason, even the
behavior is not documented.
* +1 for 3.8: I like strict and less magic.
* +0 for 3.7: beta3 is bit late, but this change has very little chance to
cause real
INADA Naoki added the comment:
Another example:
>>> s = "ß"
>>> len(s)
1
>>> len(s.upper())
2
>>> s.upper()
'SS'
>>> ord(s)
223
> This breaks unicode text matching.
What do you talking about? re module?
--
nosy:
INADA Naoki added the comment:
If there are some code which depend on ABC.__subclasscheck__() allow class-like
object, we'll have to revert it in 3.7b4 or rc.
I think it's the only risk.
--
___
Python tracker
<https://bugs.python.o
INADA Naoki added the comment:
Maybe, we should update UnicodeData?
--
___
Python tracker
<https://bugs.python.org/issue33108>
___
___
Python-bugs-list mailin
Change by INADA Naoki :
--
pull_requests: +5933
___
Python tracker
<https://bugs.python.org/issue32999>
___
___
Python-bugs-list mailing list
Unsubscribe:
Change by INADA Naoki :
--
pull_requests: +5934
___
Python tracker
<https://bugs.python.org/issue33018>
___
___
Python-bugs-list mailing list
Unsubscribe:
INADA Naoki added the comment:
New changeset f757b72b2524ce3451d2269f0b8a9f0593a7b27f by INADA Naoki in branch
'master':
bpo-32999: Revert GH-6002 (fc7df0e6) (GH-6189)
https://github.com/python/cpython/commit/f757b72b2524ce3451d2269f0b8a9f
INADA Naoki added the comment:
New changeset f757b72b2524ce3451d2269f0b8a9f0593a7b27f by INADA Naoki in branch
'master':
bpo-32999: Revert GH-6002 (fc7df0e6) (GH-6189)
https://github.com/python/cpython/commit/f757b72b2524ce3451d2269f0b8a9f
Change by INADA Naoki :
--
pull_requests: +5944
___
Python tracker
<https://bugs.python.org/issue32999>
___
___
Python-bugs-list mailing list
Unsubscribe:
INADA Naoki added the comment:
New changeset c65bf3fe4a2bde424b79e350f36b7aaa3f6476f6 by INADA Naoki in branch
'master':
bpo-32999: ast: Convert useless check to assert (GH-6197)
https://github.com/python/cpython/commit/c65bf3fe4a2bde424b79e350f36b7a
INADA Naoki added the comment:
Would you paste traceback?
--
nosy: +inada.naoki
___
Python tracker
<https://bugs.python.org/issue33153>
___
___
Python-bugs-list m
INADA Naoki added the comment:
Why *should*?
Legacy ParentClass.method() call is faster than super().method() call, because
there are no temporary proxy object.
I don't think there are enough reason to replace all legacy parent calls.
--
nosy: +inada.
New submission from INADA Naoki :
https://docs.python.org/3/c-api/arg.html
Py_UNICODE usage is not deprecated in this document.
Before thinking about raising warning, deprecate it in document first.
But... from when? Can I backport the "deprecated" doc to 3.6 or 3.5?
-
Change by INADA Naoki :
--
keywords: +patch
pull_requests: +6042
stage: -> patch review
___
Python tracker
<https://bugs.python.org/issue33195>
___
___
Python-
Change by INADA Naoki :
--
versions: -Python 3.4, Python 3.5
___
Python tracker
<https://bugs.python.org/issue33199>
___
___
Python-bugs-list mailing list
Unsub
Change by INADA Naoki :
--
keywords: +patch
pull_requests: +6052
stage: -> patch review
___
Python tracker
<https://bugs.python.org/issue33199>
___
___
Python-
New submission from INADA Naoki :
GROWTH_RATE is changed from (used*2) to (used*2 + dk_size/2) in #17563, at
Python 3.4.
It was for avoid resizing dict for massive del/insert use case, by increasing
possibility of overwriting DUMMY entry.
>From Python 3.6, there are no DUMMY entry. Wh
Change by INADA Naoki :
--
dependencies: +GROWTH_RATE prevents dict shrinking
___
Python tracker
<https://bugs.python.org/issue32623>
___
___
Python-bugs-list m
INADA Naoki added the comment:
# cap2.json is master (used*2 + dk_size/2)
# used3.json is patched (used*3)
$ ./python-master -m perf compare_to cap2.json used3.json -G
Slower (2):
- rand_access(size=20): 2.67 ms +- 0.01 ms -> 2.80 ms +- 0.04 ms: 1.05x slower
(+5%)
- rand_access(size=10): 2
Change by INADA Naoki :
--
keywords: +patch
pull_requests: +6060
stage: -> patch review
___
Python tracker
<https://bugs.python.org/issue33205>
___
___
Python-
INADA Naoki added the comment:
New changeset d1c82c5cc7be0c21dddf86fd19c1702f6218459b by INADA Naoki in branch
'master':
bpo-33199: Initialize ma_version_tag in PyDict_Copy (GH-6341)
https://github.com/python/cpython/commit/d1c82c5cc7be0c21dddf86fd19c170
Change by INADA Naoki :
--
status: open -> closed
___
Python tracker
<https://bugs.python.org/issue33199>
___
___
Python-bugs-list mailing list
Unsubscrib
Change by INADA Naoki :
--
stage: patch review -> resolved
___
Python tracker
<https://bugs.python.org/issue33199>
___
___
Python-bugs-list mailing list
Un
Change by INADA Naoki :
--
resolution: -> fixed
___
Python tracker
<https://bugs.python.org/issue33199>
___
___
Python-bugs-list mailing list
Unsubscrib
INADA Naoki added the comment:
New changeset 629338f1404ea9cd75e4fb0389a2fbe1b589de43 by INADA Naoki in branch
'master':
bpo-32360: Remove object_pairs_hook=OrderedDict examples (GH-5001)
https://github.com/python/cpython/commit/629338f1404ea9cd75e4fb0389a2fb
Change by INADA Naoki :
--
resolution: -> fixed
___
Python tracker
<https://bugs.python.org/issue32360>
___
___
Python-bugs-list mailing list
Unsubscrib
Change by INADA Naoki :
--
dependencies: -Dict order is now guaranteed, so add tests and doc for it
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.org/i
INADA Naoki added the comment:
OK, I replaced Py_UNICODE with wchar_t in Py_BuildValue document.
--
___
Python tracker
<https://bugs.python.org/issue33
Change by INADA Naoki :
--
resolution: -> duplicate
stage: -> resolved
status: open -> closed
superseder: -> Dict order is now guaranteed, so add tests and doc for it
___
Python tracker
<https://bugs.python
INADA Naoki added the comment:
> I started to add this comment to #33218 but Raymond closed that ticket while
> I was editing it.
Sorry, I closed it, not Raymond.
--
___
Python tracker
<https://bugs.python.org/i
INADA Naoki added the comment:
New changeset dfbbbf16f9aab82330c634913441b5ac73267d9c by INADA Naoki (hui
shang) in branch 'master':
bpo-32337: Update documentats about dict order (GH-4973)
https://github.com/python/cpython/commit/dfbbbf16f9aab82330c634913441b5
INADA Naoki added the comment:
New changeset 42ec190761a2e8503aaa06f0bfaaabe98749179b by INADA Naoki in branch
'master':
bpo-33195: Doc: Deprecate Py_UNICODE in c-api/arg (GH-6329)
https://github.com/python/cpython/commit/42ec190761a2e8503aaa06f0bfaaab
Change by INADA Naoki :
--
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.org/issue33195>
___
___
Pyth
Change by INADA Naoki :
--
resolution: -> fixed
___
Python tracker
<https://bugs.python.org/issue33195>
___
___
Python-bugs-list mailing list
Unsubscrib
INADA Naoki added the comment:
Any other known issue? May I close this issue?
--
___
Python tracker
<https://bugs.python.org/issue32337>
___
___
Python-bug
Change by INADA Naoki :
--
pull_requests: +6092
___
Python tracker
<https://bugs.python.org/issue33195>
___
___
Python-bugs-list mailing list
Unsubscribe:
INADA Naoki added the comment:
New changeset 29bc6f6347b1e05b22180fd296013bb2a104d589 by INADA Naoki in branch
'3.6':
bpo-33195: Doc: Deprecate Py_UNICODE in c-api/arg (GH-6329)
https://github.com/python/cpython/commit/29bc6f6347b1e05b22180fd296013b
INADA Naoki added the comment:
@wolma Would you split your PR? One for fix docstring and one for using
Random.choices.
Since former is document bug, I want to backport it. (while _RandomNameSequence
is private)
--
nosy: +inada.naoki
___
Python
INADA Naoki added the comment:
@Mark.Shannon, @rhettinger How do you think this?
--
___
Python tracker
<https://bugs.python.org/issue33205>
___
___
Python-bug
Change by INADA Naoki :
--
components: Interpreter Core
nosy: inada.naoki
priority: normal
severity: normal
status: open
title: Potential memory leak in normalizestring()
type: resource usage
versions: Python 3.6, Python 3.7, Python 3.8
___
Python
Change by INADA Naoki :
--
keywords: +patch
pull_requests: +6095
stage: -> patch review
___
Python tracker
<https://bugs.python.org/issue33231>
___
___
Python-
INADA Naoki added the comment:
> Only reason I can see to avoid this would be if the codec names could contain
> arbitrary Unicode encoded as UTF-8 (and therefore strlen wouldn't tell you
> the final length in Unicode ordinals), but I'm pretty sure that's not the
>
INADA Naoki added the comment:
New changeset 0c1c4563a65ac451021d927058e4f25013934eb2 by INADA Naoki in branch
'master':
bpo-33231: Fix potential leak in normalizestring() (GH-6386)
https://github.com/python/cpython/commit/0c1c4563a65ac451021d927058e4f2
Change by INADA Naoki :
--
resolution: -> fixed
___
Python tracker
<https://bugs.python.org/issue33231>
___
___
Python-bugs-list mailing list
Unsubscrib
Change by INADA Naoki :
--
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.org/issue33231>
___
___
Pyth
INADA Naoki added the comment:
New changeset 9c463ec88ba21764f6fff8e01d6045a932a89438 by INADA Naoki (Wolfgang
Maier) in branch 'master':
Update docstring of tempfile._RandomNameSequence (GH-6414)
https://github.com/python/cpython/commit/9c463ec88ba21764f6fff8e01d6045
INADA Naoki added the comment:
> "The primary objective of this revision is to bring YAML into compliance with
> JSON as an official subset."
>
> So it should be that YAML is a subset of JSON and not the other way around.
This sentence can be read as "JSON is s
Change by INADA Naoki :
--
keywords: +patch
pull_requests: +6126
stage: -> patch review
___
Python tracker
<https://bugs.python.org/issue33099>
___
___
Python-
INADA Naoki added the comment:
There are some resource leaks:
* When error occurred in setUp() function, server thread is not stopped. It
leaked threads and sockets for the server.
* When error occurred in server thread's run() method, asyncore.close_all() is
not called.
These leaks
INADA Naoki added the comment:
@Christian
Precisely, my PR doesn't fix #32706 and #32753.
It fixes only hang caused by them and print stack trace for them.
--
___
Python tracker
<https://bugs.python.org/is
INADA Naoki added the comment:
On Ubuntu 17.10 (OpenSSL 1.0.2g), this patch fixes test_poplib error.
But I don't know this patch is right.
$ git diff
diff --git a/Lib/test/test_poplib.py b/Lib/test/test_poplib.py
index 6abdc93879..d7a8857b05 100644
--- a/Lib/test/test_poplib.py
+++ b/Lib
Change by INADA Naoki :
--
resolution: -> wont fix
stage: -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.org/issue30686>
___
___
INADA Naoki added the comment:
Maybe, this issue is fixed?
--
___
Python tracker
<https://bugs.python.org/issue31584>
___
___
Python-bugs-list mailing list
Unsub
Change by INADA Naoki :
--
resolution: -> wont fix
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
INADA Naoki added the comment:
> in practice `ast.parse()` is often used with smaller fragments of source code
> that don't directly correspond to a complete module, and this behaviour makes
> no sense in such cases.
>
> The resulting bug in kdev-python took a while to t
INADA Naoki added the comment:
New changeset 5fbc511f56688654a05b9eba23d140318bb9b2d5 by INADA Naoki in branch
'master':
bpo-33205: dict: Change GROWTH_RATE to `used*3` (GH-6350)
https://github.com/python/cpython/commit/5fbc511f56688654a05b9eba23d140
New submission from INADA Naoki :
https://github.com/python/cpython/blob/5fbc511f56688654a05b9eba23d140318bb9b2d5/Lib/test/test_urllib2net.py#L180-L198
This test uses http://www.imdb.com/, but it is gone.
So This test start failing.
Is there any good URL for this test case?
May I skip this
Change by INADA Naoki :
--
keywords: +patch
pull_requests: +6200
stage: -> patch review
___
Python tracker
<https://bugs.python.org/issue33295>
___
___
Python-
Change by INADA Naoki :
--
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.org/issue33205>
___
___
Pyth
Change by INADA Naoki :
--
resolution: -> fixed
___
Python tracker
<https://bugs.python.org/issue33205>
___
___
Python-bugs-list mailing list
Unsubscrib
INADA Naoki added the comment:
Isn't it an expected behavior of SSL with nonblocking socket?
What's wrong?
--
nosy: +inada.naoki
___
Python tracker
<https://bugs.python.o
Change by INADA Naoki :
--
nosy: +inada.naoki
___
Python tracker
<https://bugs.python.org/issue33298>
___
___
Python-bugs-list mailing list
Unsubscribe:
INADA Naoki added the comment:
Why not just remove TODO comment?
Thread is cheap, but not zero-cost.
--
nosy: +inada.naoki
___
Python tracker
<https://bugs.python.org/issue24
Change by INADA Naoki :
--
nosy: +inada.naoki
___
Python tracker
<https://bugs.python.org/issue33312>
___
___
Python-bugs-list mailing list
Unsubscribe:
INADA Naoki added the comment:
New changeset 491bbedc209fea314a04cb3015da68fb0aa63238 by INADA Naoki (lekma)
in branch 'master':
bpo-33391: Fix refleak in set_symmetric_difference (GH-6670)
https://github.com/python/cpython/commit/491bbedc209fea314a04cb3015da68fb0aa63238
-
Change by INADA Naoki :
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
INADA Naoki added the comment:
I'm sorry. I just reviewed some easy pull requests when I have time.
I'll skip pull requests you assigned yourself next time.
--
___
Python tracker
<https://bugs.python.o
INADA Naoki added the comment:
"t.ClassVar" looks ugly...
How about dropping ClassVar support of dataclass module for 3.7?
--
nosy: +inada.naoki
___
Python tracker
<https://bugs.python.o
INADA Naoki added the comment:
> We can't break the API at this point in the release cycle.
We hadn't release RC, and we hadn't documented dataclass module yet.
How about making "dataclass" module as porvisional state?
I think we've learned lesson that we shou
INADA Naoki added the comment:
> > I think we've learned lesson that we shouldn't use typing in modules
other than typing...
> This is a blanket statement that as hurtful as it is factually
incorrect. Let me address the latter.
> 1. Dataclasses are entirely depend
1801 - 1900 of 3039 matches
Mail list logo
