Hynek Schlawack added the comment:
So, IMHO if someone calls os.makedirs with a mode != 0o777, they expect to have
the directories having those modes afterward. So raising no error if they exist
and have the wrong mode would be a plain bug.
Python 3.3 already has a helpful error message
Hynek Schlawack added the comment:
do you want it by default or a new flag? default sounds like a source for
obscure bugs to me.
--
___
Python tracker
<http://bugs.python.org/issue13
Hynek Schlawack added the comment:
How about something along of:
new arg on_wrong_perm=
1. WRONG_PERM_IGNORE
2. WRONG_PERM_FAIL
3. callable that gets called with the directory name and maybe the existing
perms to save stat call_
?
--
___
Python
Hynek Schlawack added the comment:
Silence means consent, so I will supply a patch as soon as 3.4 is open.
Meanwhile, I reworded the docs for os.makedirs, the patch is attached. Please
have a look at it so we can get it in for 3.3.
--
keywords: +patch
stage: needs patch -> pa
Hynek Schlawack added the comment:
> Silence doesn't mean consent, but it does mean you can go ahead and see if
> anyone complains :)
Well that's what I meant. :)
> I think your proposal is fine, but I'd prefer making the sentinels just
> "IGNORE" and &q
Hynek Schlawack added the comment:
Ok, let’s do it here, that’s easier:
.. function:: makedirs(path, mode=0o777, exist_ok=False)
.. index::
single: directory; creating
single: UNC paths; and os.makedirs()
Recursive directory creation function. Like :func:`mkdir`, but makes
Hynek Schlawack added the comment:
Seems related to #15645, no?
--
nosy: +hynek
___
Python tracker
<http://bugs.python.org/issue15760>
___
___
Python-bugs-list m
Hynek Schlawack added the comment:
What does bother you? Both sigs look like in py3 if I'm looking correctly.
--
___
Python tracker
<http://bugs.python.org/is
Hynek Schlawack added the comment:
It seems correct like that:
static PyObject *
csv_register_dialect(PyObject *module, PyObject *args, PyObject *kwargs)
{
PyObject *name_obj, *dialect_obj = NULL;
PyObject *dialect;
if (!PyArg_UnpackTuple(args, "", 1, 2, &name_obj
Hynek Schlawack added the comment:
Thank you for your contribution Chris!
--
resolution: -> fixed
stage: patch review -> committed/rejected
status: open -> closed
___
Python tracker
<http://bugs.python.or
Changes by Hynek Schlawack :
--
nosy: +hynek
___
Python tracker
<http://bugs.python.org/issue16040>
___
___
Python-bugs-list mailing list
Unsubscribe:
Hynek Schlawack added the comment:
Let's get this rolling again. First let's fix the docs for 3.2+ first. My
current suggestion would be the following:
~~~
.. function:: makedirs(path, mode=0o777, exist_ok=False)
.. index::
single: directory; creating
single: UNC
Hynek Schlawack added the comment:
Any suggestions on the value for _MAXLINE or just steal the 64k from httplib?
--
___
Python tracker
<http://bugs.python.org/issue16
Hynek Schlawack added the comment:
Pong? I understand we have to close #15411 & #9949 first? Can't help here out
due to lack of Windows.
--
dependencies: +os.chmod() does not follow symlinks on Windows, os.path.realpath
on Windows does not follow symbo
Changes by Hynek Schlawack :
--
nosy: +brian.curtin, tim.golden
___
Python tracker
<http://bugs.python.org/issue15411>
___
___
Python-bugs-list mailing list
Unsub
Changes by Hynek Schlawack :
--
nosy: +hynek
___
Python tracker
<http://bugs.python.org/issue16099>
___
___
Python-bugs-list mailing list
Unsubscribe:
Hynek Schlawack added the comment:
Actually, that’s not the point here, the code has a deeper flaw.
You’re computing hashlib.md5() on `data.encode()` and `str(jsonData).encode()`.
Did you have a look how they look like?
>>> data.encode()
b'{"key1":"value1&q
Changes by Hynek Schlawack :
--
nosy: +hynek
___
Python tracker
<http://bugs.python.org/issue16202>
___
___
Python-bugs-list mailing list
Unsubscribe:
Changes by Hynek Schlawack :
--
nosy: +hynek
___
Python tracker
<http://bugs.python.org/issue16244>
___
___
Python-bugs-list mailing list
Unsubscribe:
Hynek Schlawack added the comment:
> To be honest I don't really understand the point of the ignore_errors flag on
> rmtree. If rmtree fails to delete the directory tree (which will happen if
> one of the files can't be deleted), why would you want it to return
> succes
Hynek Schlawack added the comment:
As announced, I hereby present an idea how to solve this problem for 3.4.
Please have a look at it. :)
--
assignee: docs@python ->
versions: -Python 3.2, Python 3.3
Added file: http://bugs.python.org/file27683/makedirs-on_wrong_mode-1.d
Hynek Schlawack added the comment:
Could you add a test please? Thanks!
--
___
Python tracker
<http://bugs.python.org/issue16307>
___
___
Python-bugs-list mailin
Hynek Schlawack added the comment:
Isn’t this a dupe of #5411?
--
___
Python tracker
<http://bugs.python.org/issue16313>
___
___
Python-bugs-list mailin
Hynek Schlawack added the comment:
Thanks for taking the time! I remember my frustrations when trying to grok how
the mp test suite works. :)
A small nit-pick first: you have a lot of extra white space in your patches.
Just run 'make patchcheck' first, that should warn you about
Hynek Schlawack added the comment:
True, it makes sense to push this assert to the end.
--
___
Python tracker
<http://bugs.python.org/issue16307>
___
___
Pytho
Hynek Schlawack added the comment:
LGTM.
Presuming you want to submit more patches in future, please take the time to
sign a Python contributor agreement: http://www.python.org/psf/contrib/ .
You'll get a pretty star next to your name in the bug tracker in r
Hynek Schlawack added the comment:
Applied. Thank you for your contribution!
--
resolution: -> fixed
stage: patch review -> committed/rejected
status: open -> closed
___
Python tracker
<http://bugs.python.or
Hynek Schlawack added the comment:
You're welcome. :)
--
___
Python tracker
<http://bugs.python.org/issue1492704>
___
___
Python-bugs-list mailing list
Hynek Schlawack added the comment:
Éric, what’s your take on this approach (not code)? We have time enough till
3.4 but it seems this doesn't really move forward. Any thoughts how to get this
moving? Unfortunately I'm not invested enough in this to make a educated
Changes by Hynek Schlawack :
--
nosy: +hynek
___
Python tracker
<http://bugs.python.org/issue16381>
___
___
Python-bugs-list mailing list
Unsubscribe:
Changes by Hynek Schlawack :
--
versions: +Python 3.4
___
Python tracker
<http://bugs.python.org/issue14794>
___
___
Python-bugs-list mailing list
Unsubscribe:
Hynek Schlawack added the comment:
Fun fact, on 2.7 & 3.2 I get infinite loops @ 100% CPU. 3.3 & default crash.
Unless someone yells, I'll polish this up and commit next week.
--
stage: -> commit review
versions: +Python 3.4 -Python 3.1
__
Hynek Schlawack added the comment:
Any reason why this is still open?
--
___
Python tracker
<http://bugs.python.org/issue15148>
___
___
Python-bugs-list mailin
Changes by Hynek Schlawack :
--
nosy: -hynek
___
Python tracker
<http://bugs.python.org/issue15104>
___
___
Python-bugs-list mailing list
Unsubscribe:
Changes by Hynek Schlawack :
--
nosy: -hynek
___
Python tracker
<http://bugs.python.org/issue15490>
___
___
Python-bugs-list mailing list
Unsubscribe:
Changes by Hynek Schlawack :
--
nosy: +orsenthil
___
Python tracker
<http://bugs.python.org/issue16099>
___
___
Python-bugs-list mailing list
Unsubscribe:
Hynek Schlawack added the comment:
This should be fixed now, thanks to all who helped!
--
resolution: -> fixed
stage: commit review -> committed/rejected
status: open -> closed
___
Python tracker
<http://bugs.python.or
Hynek Schlawack added the comment:
“I wish I were wrangling inconsistent Windows buildbots.”
Nobody. Ever. *sigh*
It appears they are appeased now, so finally closing. Thanks for the patches
everyone!
--
resolution: -> fixed
stage: patch review -> committed/rejected
status
New submission from Hynek Schlawack:
See issue16664.
--
assignee: docs@python
components: Documentation
keywords: easy
messages: 177584
nosy: Sebastian.Kreft, docs@python, hynek, pitrou
priority: normal
severity: normal
stage: needs patch
status: open
title: Clarify fnmatch & glob
Hynek Schlawack added the comment:
Patch LGTM and will be applied, I have opened issue16695 for the related update
of the docs.
BTW how did you create the patch? The bugtracker/Rietveld didn't recognize it
for review and applying it took some effort too.
--
title: [PATCH] Test
Changes by Hynek Schlawack :
--
nosy: +hynek
___
Python tracker
<http://bugs.python.org/issue16618>
___
___
Python-bugs-list mailing list
Unsubscribe:
Hynek Schlawack added the comment:
Thank you for your patch and welcome to CPython core development!
Presuming you want to submit more patches in future, please take the time to
sign a Python contributor agreement: http://www.python.org/psf/contrib/ .
You'll get a pretty star next to
New submission from Hynek Schlawack:
Ah yeah I support this endeavor, I fixed a few instances in rmtree while
working on it. It’s just confusing.
JFTR, is there any rationale/reason to do it? Last time I checked it wasn’t
deprecated.
--
nosy: +hynek
Hynek Schlawack added the comment:
> I think deprecation makes not big value.
> We should continue aliases support and there are no place to raise warning.
> What we can do — mention deprecation in the doc.
That’s what I meant. I saw it in shutil code, were confused, looked it up,
won
Hynek Schlawack added the comment:
Serhiy, are you going to update your patches? I can implement the feedback of
our Q4 Community Service Award awardee too in case you’re busy.
--
___
Python tracker
<http://bugs.python.org/issue16
Hynek Schlawack added the comment:
Thanks Serhiy!
--
resolution: -> fixed
stage: patch review -> committed/rejected
status: open -> closed
___
Python tracker
<http://bugs.python.or
Hynek Schlawack added the comment:
I agree that standardize behavior here would be useful. But it sounds like a
candidate for 3.4. Unifying/changing it for existing releases appears rather
hairy to me?
--
assignee: docs@python ->
type: -> behavior
versions: +Pyth
Hynek Schlawack added the comment:
Any news? Wouldn’t Apple give us a license for our buildbots like MSFT does?
--
___
Python tracker
<http://bugs.python.org/issue15
Hynek Schlawack added the comment:
Turns out, Larry fixed these two while working on #14626.
--
resolution: -> fixed
stage: needs patch -> committed/rejected
status: open -> closed
___
Python tracker
<http://bugs.python.or
Hynek Schlawack added the comment:
I think we should resolve this one line change.
Jessica’s patch looks just fine, so I tend to apply it. However, I’d like to
document the current behavior in 2.7, 3.2, 3.3 and 3.4.
Am I missing anything?
--
nosy: +hynek
versions: +Python 2.7
Hynek Schlawack added the comment:
It would be great if someone could port this patch to Python 3.4 and verify its
effectiveness.
--
keywords: +easy -patch
stage: test needed -> needs patch
versions: +Python 3.4 -Python 3.2, Python 3.3
___
Pyt
Hynek Schlawack added the comment:
The patch hasn’t incorporated Antoine’s comments AFAICT.
Also I don’t see this fit for back porting to bug fix releases. Correct me if
I’m wrong.
--
nosy: +hynek
stage: patch review -> needs patch
versions: +Python 3.4 -Python 2.7, Python 3.2, Pyt
Changes by Hynek Schlawack :
--
nosy: +hynek
___
Python tracker
<http://bugs.python.org/issue15450>
___
___
Python-bugs-list mailing list
Unsubscribe:
New submission from Hynek Schlawack:
Glad to hear.
--
nosy: +hynek
resolution: -> invalid
stage: -> committed/rejected
status: open -> closed
___
Python tracker
<http://bugs.python.or
Hynek Schlawack added the comment:
$(pwd)
--
stage: -> patch review
versions: +Python 3.4
___
Python tracker
<http://bugs.python.org/issue16591>
___
___
Py
Hynek Schlawack added the comment:
I’m fine with that. My focus was fixing the ticket metadata. :)
--
___
Python tracker
<http://bugs.python.org/issue16
Hynek Schlawack added the comment:
I will review this first thing tomorrow.
--
___
Python tracker
<http://bugs.python.org/issue6975>
___
___
Python-bugs-list m
Changes by Hynek Schlawack :
--
title: symlinks incorrectly resolved on Linux -> symlinks incorrectly resolved
on POSIX platforms
___
Python tracker
<http://bugs.python.org/iss
Changes by Hynek Schlawack :
--
nosy: +hynek
___
Python tracker
<http://bugs.python.org/issue15881>
___
___
Python-bugs-list mailing list
Unsubscribe:
Hynek Schlawack added the comment:
I think since we ship cryptographic functions, we should take responsibility
and warn against the most common mistakes people do.
--
nosy: +hynek
___
Python tracker
<http://bugs.python.org/issue17
Hynek Schlawack added the comment:
Could you add regression tests to your patch please?
--
assignee: -> hynek
priority: high -> normal
type: crash -> behavior
___
Python tracker
<http://bugs.python.or
Hynek Schlawack added the comment:
I would strongly prefer to back port certificate validation instead. Is there
anything *practical* that makes it hard/impossible?
If we want to keep features stable, we can add it privately so it’s only usable
by distutils. The susceptibility to (easy!) MITM
Changes by Hynek Schlawack :
--
versions: +Python 3.4
___
Python tracker
<http://bugs.python.org/issue17076>
___
___
Python-bugs-list mailing list
Unsubscribe:
Hynek Schlawack added the comment:
The buildbots look happy, thank you for spotting & the patch Thomas!
--
resolution: -> fixed
status: open -> closed
___
Python tracker
<http://bugs.python.o
Changes by Hynek Schlawack :
--
nosy: +hynek
___
Python tracker
<http://bugs.python.org/issue17153>
___
___
Python-bugs-list mailing list
Unsubscribe:
Hynek Schlawack added the comment:
I would have long ago if I had any domain knowlege on this topic, but alas….
--
___
Python tracker
<http://bugs.python.org/issue1610
Hynek Schlawack added the comment:
I’m +1 too since supporting it serves no other purpose then enabling downgrade
attacks. Shipping a client with SSL 2 on is nothing short a security bug.
--
nosy: +hynek
___
Python tracker
<http://bugs.python.
Hynek Schlawack added the comment:
More explicitly:
The doc sells the function short. If you have a bunch of futures and want to
know as soon as one of them is ready: this is the function for you.
The only hint that this is the actual behavior comes from the *name* of the
function; not the
Hynek Schlawack added the comment:
JFTR the main compatibility impact on the browser side is the loss of IE8 on
WinXP whose last stable release is qua Wikipedia from “February 22, 2011; 5
years ago”.
--
nosy: +hynek
___
Python tracker
<h
Hynek Schlawack added the comment:
While I agree that it’s a problem, I’m a bit uneasy about changing that back to
2.7. I’m pretty sure this would break numerous programs.
--
___
Python tracker
<http://bugs.python.org/issue17
Hynek Schlawack added the comment:
Yeah, I’m thinking about backup scripts etc.
--
___
Python tracker
<http://bugs.python.org/issue17180>
___
___
Python-bug
Hynek Schlawack added the comment:
SGTM. I’d like an explicit warning on the security implications in the docs
though.
--
___
Python tracker
<http://bugs.python.org/issue17
Hynek Schlawack added the comment:
Jyrki, roundup doesn’t seem to recognize you patch so we can’t review it in
Rietveld. Could you re-try, maybe using hg?
--
___
Python tracker
<http://bugs.python.org/issue11
Hynek Schlawack added the comment:
I feel like there should be a warning in Doc/library/xml.rst too.
Is there any actual reason why we don’t ship defusedxml with Python and add an
easy way to monkeypatch so there’s as little passive barriers as possible to
use XML “safely”?
I’m sorry I
Changes by Hynek Schlawack :
--
nosy: -hynek
___
Python tracker
<http://bugs.python.org/issue21859>
___
___
Python-bugs-list mailing list
Unsubscribe:
Hynek Schlawack added the comment:
Such an idiom is IMHO not the main usefulness of this function tho.
As an (untested) example, something like
async def f(n):
await asyncio.sleep(n)
return n
for f in asyncio.as_completed([f(3), f(2), f(1)]):
print(await f)
will print:
1
2
3
301 - 376 of 376 matches
Mail list logo
