Hirokazu Yamamoto added the comment:
Here is a patch.
--
keywords: +patch
Added file: http://bugs.python.org/file13117/fix_offset_and_resize.patch
___
Python tracker
<http://bugs.python.org/issue5
Hirokazu Yamamoto added the comment:
Tim, I confirmed your test fails on my machine, and is fixed by your patch.
I want to commit this. Can I?
--
components: +Extension Modules, Windows -Library (Lib)
nosy: +ocean-city
stage: -> commit review
versions: +Python 2.6, Python 2.7, Pyt
Hirokazu Yamamoto added the comment:
I hope this is obvious too. Fixed in r69718.
--
resolution: -> fixed
status: open -> closed
___
Python tracker
<http://bugs.python.org/
Hirokazu Yamamoto added the comment:
I reconsidered this issue. When mmap is anonymous,
self->file_handle == INVALID_HANDLE_VALUE (-1), so we should not call
SetFilePointer and SetEndOfFile for this handle.
And the behavior of mmap.resize is not documented clearly though,
current behavior
Changes by Hirokazu Yamamoto :
Added file: http://bugs.python.org/file13131/mmapmodule.patch
___
Python tracker
<http://bugs.python.org/issue2733>
___
___
Python-bug
Hirokazu Yamamoto added the comment:
I think change for posixmodule.c is missing from r69495. (I confirmed
other merges don't include posixmodule.c modification)
Attached patch will fix this. (I don't have VS2005 or later, so I cannot
test this on my machine)
--
keywords: +
Hirokazu Yamamoto added the comment:
And I think r69268 should be merged too.
___
Python tracker
<http://bugs.python.org/issue5306>
___
___
Python-bugs-list mailin
Hirokazu Yamamoto added the comment:
Can you try this with 3.0.1?
http://python.org/download/releases/3.0.1
--
nosy: +ocean-city
___
Python tracker
<http://bugs.python.org/issue5
Hirokazu Yamamoto added the comment:
Thanks, I'll close this entry.
--
resolution: -> out of date
status: open -> closed
___
Python tracker
<http://bugs.python
New submission from Hirokazu Yamamoto :
I noticed following code crashes on windows. Attached patch will fix this.
/
// Crash code
import mmap, tempfile
f = tempfile.TemporaryFile()
m1 = mmap.mmap(f.fileno(), 1000, tagname="foo")
m2 = mmap.mma
Hirokazu Yamamoto added the comment:
This is duplicated issue of issue1733986. So I'll closing...
--
resolution: -> duplicate
status: open -> closed
superseder: -> mmap.mmap can overrun buffer
___
Python tracker
<http://bugs.pyt
Hirokazu Yamamoto added the comment:
I came from issue5335. I think attached patch will fix this issue.
--
keywords: +patch
nosy: +ocean-city
priority: normal -> high
type: -> crash
versions: +Python 2.6, Python 2.7, Python 3.0, Python 3.1
Added file: http://bugs.python.org/fil
Hirokazu Yamamoto added the comment:
Probably attached patch will fix this issue. But this patch doesn't
cover other similar problematic codes.
It seems this is multi inheritance problem. Following code shows B.setUp
and B.tearDown are called twice respectively. (In this issue, B
repre
Hirokazu Yamamoto added the comment:
Patch attached.
--
components: +Extension Modules -Library (Lib)
keywords: +patch
nosy: +ocean-city
versions: +Python 3.1
Added file: http://bugs.python.org/file13192/py3k_fix_array_fromfile.patch
___
Python
Hirokazu Yamamoto added the comment:
I think this is not array modules' bug. Attached test program outputs
different results on trunk/py3k.
debian:~/python-dev/trunk# ./python /mnt/windows/simple_test.py
os.pipe: success
pty.openpty: success
debian:~/python-dev/py3k# ./python /mnt/wi
Hirokazu Yamamoto added the comment:
This OSError(5) happens when we tries to read from pty after data runs out.
So simple_test_2.py fails with same error even if we don't use io module.
Modules/posixmodule.c (posix_read) simply calls read(2) once, but io module
while avai
Changes by Hirokazu Yamamoto :
--
nosy: +pitrou
___
Python tracker
<http://bugs.python.org/issue5380>
___
___
Python-bugs-list mailing list
Unsubscribe:
New submission from Hirokazu Yamamoto :
It seems mmap module is using inappropriate exception types. For example,
if (! (PyString_Check(v)) ) {
PyErr_SetString(PyExc_IndexError,
"mmap slice assignment must be a s
New submission from Hirokazu Yamamoto :
On windows, after mmap.resize fails, self->map_handle
becomes NULL, but it should become INVALID_HANDLE_VALUE otherwise
CHECK_VALID is passed through, it can cause crash like bellow.
import mmap
m = mmap.mmap(-1, 5)
try:
m.resize(-1)
exc
Changes by Hirokazu Yamamoto :
--
type: -> crash
___
Python tracker
<http://bugs.python.org/issue5385>
___
___
Python-bugs-list mailing list
Unsubscri
New submission from Hirokazu Yamamoto :
mmap.write_byte doesn't check buffer size, so it can cause crash like
bellow.
import mmap
m = mmap.mmap(-1, 1)
for i in xrange(1): # enough?
print i
m.write_byte('1') # crash
The patch is in r69945.
--
components: Ex
New submission from Hirokazu Yamamoto :
mmap.move crashes by integer overflow. See
http://www.nabble.com/Segv-in-mmap.move()-td18617044.html
import mmap
data = mmap.mmap(-1, 1)
data.move(1,1,-1) # crash
Maybe mmap.move should use Py_ssize_t and raise
IndexError(OverflowError?) for negative
Hirokazu Yamamoto added the comment:
Fixed in r70052(trunk), r70053(py3k).
--
resolution: -> fixed
status: open -> closed
___
Python tracker
<http://bugs.python.org/
New submission from Hirokazu Yamamoto :
On Python3000, mmap.read_byte returns str not bytes, and mmap.write_byte
accepts str. Is this intended behavior?
>>> import mmap
>>> m = mmap.mmap(-1, 10)
>>> type(m.read_byte())
>>> m.write_byte("a")
>
Hirokazu Yamamoto added the comment:
Fixed in r70056(trunk) and r70057(py3k).
--
resolution: -> fixed
status: open -> closed
___
Python tracker
<http://bugs.python.org/iss
Changes by Hirokazu Yamamoto :
--
versions: -Python 3.0
___
Python tracker
<http://bugs.python.org/issue5391>
___
___
Python-bugs-list mailing list
Unsubscribe:
Hirokazu Yamamoto added the comment:
I think more *bytes* cleanup is needed for mmap module documentation &
implementation. (and other modules?) Especially mmap.find() and its friends.
>>> import mmap
>>> m = mmap.mmap(-1, 10)
>>> m[:] = b"0123456789"
Hirokazu Yamamoto added the comment:
Patch attached. read_byte and write_byte use integer as byte, and other
bytes related cleanup.
--
keywords: +patch
Added file: http://bugs.python.org/file13215/py3k_mmap_and_bytes.patch
___
Python tracker
<h
New submission from Hirokazu Yamamoto :
I noticed test_md5 and test_multiprocessing crashed on trunk. I hope
attached patch will fix this issue. (Maybe the patch can be simplified
with goto)
--
components: Extension Modules
files: fix_md5_without_goto.patch
keywords: patch
messages
Hirokazu Yamamoto added the comment:
Or, use NULL as invalid handle value for map handle instead of
INVALID_HANDLE_VALUE. Maybe this is simpler.
--
keywords: +patch
Added file: http://bugs.python.org/file13230/fix_mmap_resize_v2.patch
___
Python
Hirokazu Yamamoto added the comment:
Sorry for interruption. Maybe is this CRT internal hack needed for debug
build only? I believe _ASSERTE is only enabled for debug build.
___
Python tracker
<http://bugs.python.org/issue5
Hirokazu Yamamoto added the comment:
This one was fixed in r70119.
--
resolution: -> fixed
status: open -> closed
___
Python tracker
<http://bugs.python.org/
Hirokazu Yamamoto added the comment:
OK, sorry for interruption.
___
Python tracker
<http://bugs.python.org/issue5407>
___
___
Python-bugs-list mailing list
Unsubscribe:
New submission from Hirokazu Yamamoto :
I came from issue5391. Here is quote of Victor's message.
>* msvcrt.putch(char), msvcrt.ungetch(char): msvcrt has also:
> - msvcrt.getch()->byte string of 1 byte
> - msvcrt.getwch()->unicode string of 1 character
> - msvcrt.put
Hirokazu Yamamoto added the comment:
This issue is not fixed on windows yet. (test_leaking_fds_on_error fails)
I think attached patch will fix this.
==
ERROR: test_writes_before_communicate (__main__.ProcessTestCase
Hirokazu Yamamoto added the comment:
Thanks, fixed in r70137(trunk), r70142(py3k), r70146(release30-maint),
r70147(release26-maint)
--
priority: release blocker -> high
resolution: -> fixed
status: open -> closed
___
Python track
Changes by Hirokazu Yamamoto :
--
priority: -> release blocker
___
Python tracker
<http://bugs.python.org/issue5273>
___
___
Python-bugs-list mailing list
Un
Changes by Hirokazu Yamamoto :
--
priority: -> release blocker
versions: +Python 3.1
___
Python tracker
<http://bugs.python.org/issue5334>
___
___
Python-
Hirokazu Yamamoto added the comment:
Thanks, fixed in r70157(py3k) and r70158(release30-maint)
--
priority: release blocker ->
resolution: -> fixed
status: open -> closed
___
Python tracker
<http://bugs.python.o
Hirokazu Yamamoto added the comment:
Probably this happens because receiever.py doesn't wait for flooder.py
termination, and pipe end is closed when recieiver.py terminates.
Does this code work for you?
p = subprocess.Popen("python
flooder.py",stdin=subprocess.PIPE,stdout=
Hirokazu Yamamoto added the comment:
This happens because when flooder.py terminates, its stdout will be
closed, but another pipe end in receirver.py process is already closed, so
Python\sysmodule.c(1098): _check_and_flush (FILE *stream)
In this function, fflush() fails. The reason why error
Hirokazu Yamamoto added the comment:
I believe this issue is duplicate of issue5273, and fixed yesterday. Can
you try latest svn checkout?
--
nosy: +ocean-city
___
Python tracker
<http://bugs.python.org/issue5
Changes by Hirokazu Yamamoto :
--
dependencies: +3.0.1 crashes in unicode path
resolution: -> duplicate
status: open -> closed
___
Python tracker
<http://bugs.python.org/
Changes by Hirokazu Yamamoto :
--
dependencies: -3.0.1 crashes in unicode path
superseder: -> 3.0.1 crashes in unicode path
___
Python tracker
<http://bugs.python.org/iss
Hirokazu Yamamoto added the comment:
Fixed in r70189.
--
resolution: -> fixed
status: open -> closed
___
Python tracker
<http://bugs.python.org/
Hirokazu Yamamoto added the comment:
More two cents which I noticed. (After the patch was applied)
1. On windows, resize for anonymous map can clear its contents.
>>> import mmap
>>> m = mmap.mmap(-1, 10)
>>> m[:] = "0123456789"
>>> m[:]
'
Hirokazu Yamamoto added the comment:
- Sorry for having clear solution for this.
+ Sorry for having no clear solution for this.
___
Python tracker
<http://bugs.python.org/issue2
Hirokazu Yamamoto added the comment:
Committed in r70203(py3k)
--
priority: release blocker ->
resolution: -> fixed
status: open -> closed
___
Python tracker
<http://bugs.python.o
Hirokazu Yamamoto added the comment:
I tried on coLinux(debian) and I got similar errors. But I'm not unix
guy, I don't know well what "permission denied" means.
debian:~/python-dev/py3k# ./python Lib/test/test_httpservers.py
test_command (__main__.BaseHTTPServerTestCase)
Hirokazu Yamamoto added the comment:
Probably this is short code to reproduce "permission denied".
import os, pwd
nobody = pwd.getpwnam('nobody')[2]
os.setuid(nobody)
open("dummy.txt", "w").write("foo") # permission denied
Still I cannot unde
Hirokazu Yamamoto added the comment:
I tried r69943 on coLinux, and I got compile error "max is not defined".
Here is updated patch.
--
keywords: +patch
message_count: 1.0 -> 2.0
Added file: http://bugs.python.org/file13272/fix_mm
Hirokazu Yamamoto added the comment:
The support for Win9x,Me,NT4 was dropped from python2.6. See
http://www.python.org/dev/peps/pep-0011/
--
nosy: +ocean-city
resolution: -> wont fix
status: open -> closed
___
Python tracker
New submission from Hirokazu Yamamoto :
I ported "compile openssl without perl" scheme into PC/VC6 from PCBuild.
And I noticed openssl compilation fails with a message "IDEA is
disabled" if I use original source code from openssl homepage.
I hope attached patch will
Hirokazu Yamamoto added the comment:
>In the python-dev thread, most people agree to use bytes in mmap. Did
>anyone reviewed the patch?
Well, there is no conclusion which of your choices (a or b) is preferred.
http://www.nabble.com/What-type-of-object-mmap.read_byte-should-return-o
Hirokazu Yamamoto added the comment:
Ah, no, this should not be backported to 3.0. Martin saids so in
msg82904, and I agreed.
--
___
Python tracker
<http://bugs.python.org/issue5
Changes by Hirokazu Yamamoto :
--
nosy: +ocean-city
___
Python tracker
<http://bugs.python.org/issue5499>
___
___
Python-bugs-list mailing list
Unsubscribe:
Hirokazu Yamamoto added the comment:
I can reproduce this on coLinux(debian). But coLinux is running on
windows, so its console behavior may not be same as native linux.
(You need to use Ctrl+D on coLinux instead of Ctrl+Z)
--
nosy: +ocean-city
Hirokazu Yamamoto added the comment:
With following patch for investigation, (release30-maint)
Index: Lib/io.py
===
--- Lib/io.py (revision 70450)
+++ Lib/io.py (working copy)
@@ -57,6 +57,7 @@
import os
import abc
+import
Hirokazu Yamamoto added the comment:
Hmm, I'm using coLinux with root user. (default)
Maybe that's difference.
--
___
Python tracker
<http://bugs.python.
Hirokazu Yamamoto added the comment:
I cannot test this because I don't have recent VC, but last week change
to _fileio.c is this.
http://svn.python.org/view/python/branches/py3k/Modules/_fileio.c?r1=70187&r2=70352
On windows, lseek was used before, but _lseeki64 in portable_lseek is
Hirokazu Yamamoto added the comment:
I hope attached patch will fix test_fileio leak.
--
keywords: +patch
nosy: +ocean-city
Added file: http://bugs.python.org/file13459/py3k_fix_leak_of_fileio.patch
___
Python tracker
<http://bugs.python.
Hirokazu Yamamoto added the comment:
I hope attached patch will fix leak of test_socket.py.
Leak is happening in FileObjectClassTestCase#testFullRead and
testCloseAfterMakefile. (actually, IOBase#readall)
--
Added file: http://bugs.python.org/file13460
Hirokazu Yamamoto added the comment:
It seems not happening on VC6. Stack size modification was checked in
r65663 to workaround this issue, but SEGV doesn't occur even if I
reverted this change on working copy. But when I lowered stack size of
python_d.exe too much, SEGV occurred.
Pleas
Hirokazu Yamamoto added the comment:
About test_urllib2_localnet, this leak happens because FakeProxyHandler
has class variable digest_auth_handler and its instance variables are
modified. Following workaround can fix this leak, but I'm not sure this
can be committed.
Index: Lib
Hirokazu Yamamoto added the comment:
PyMem_Free is needed when "es" is used with PyArg_ParseTuple. See other
part of import.c. I did same mistake before. ;-)
--
nosy: +ocean-city
___
Python tracker
<http://bugs.python.
Hirokazu Yamamoto added the comment:
This issue seems to be fixed on py3k by r70755. (issue5236)
--
___
Python tracker
<http://bugs.python.org/issue5239>
___
___
Changes by Hirokazu Yamamoto :
--
nosy: +christian.heimes
___
Python tracker
<http://bugs.python.org/issue5497>
___
___
Python-bugs-list mailing list
Unsubscribe:
Hirokazu Yamamoto added the comment:
Really? Hmm weird...
I'm using Win2000, maybe are you using newer OS?
Or maybe larger data is needed. This guy says error occurs around 200MB.
(This is async IO though)
>http://www.gamedev.net/community/forums/topic.asp?topic_id=382135
If this happ
Hirokazu Yamamoto added the comment:
Ah, I forgot this. Process#set_daemon doesn't exist on trunk, I had to
use "p.daemon = True" instead.
--
___
Python tracker
<http://bugs.py
Hirokazu Yamamoto added the comment:
>malloc: *** mmap(size=-9223372036854775808) failed
Does this error occur even if you revert Modules/mmapmodule.c to ｒ69214?
I have touched this module recently (I believe I fixed only SEGV bugs,
not changed behavior) so I want to know it.
--
n
Hirokazu Yamamoto added the comment:
Sorry, this is not related to mmap module... Forgot my comments.
--
___
Python tracker
<http://bugs.python.org/issue5
Changes by Hirokazu Yamamoto :
--
nosy: -ocean-city
___
Python tracker
<http://bugs.python.org/issue5614>
___
___
Python-bugs-list mailing list
Unsubscribe:
Hirokazu Yamamoto added the comment:
Probably these are related too. #5259 #5304
--
dependencies: +email/base64mime.py cannot work, smtplib is broken in Python3
nosy: +ocean-city
___
Python tracker
<http://bugs.python.org/issue1685
Hirokazu Yamamoto added the comment:
Well, I think your patch has some issues.
>>> import mmap
>>> m = mmap.mmap(-1, 10)
>>> m.move(10, 10, 0) # legal, should not fail
Traceback (most recent call last):
File "", line 1, in
ValueError: source out of ra
Hirokazu Yamamoto added the comment:
I noticed this warning still happens on release26-maint. Is backporting
this to release26-maint not good for binary compatibility reason?
--
___
Python tracker
<http://bugs.python.org/issue5
Hirokazu Yamamoto added the comment:
Committed in r70800(trunk), r70803(release26-maint), r70808(py3k),
r70811(release30-maint).
--
resolution: -> fixed
status: open -> closed
___
Python tracker
<http://bugs.python.org/
Hirokazu Yamamoto added the comment:
Yes, you are right... My patch was not correct neigher. :-(
Here is revised patch.
--
resolution: fixed ->
status: closed -> open
Added file: http://bugs.python.org/file13519/fix_mmap_move_v2.patch
___
Changes by Hirokazu Yamamoto :
--
dependencies: +only accept byte for getarg('c') and unicode for getarg('C')
___
Python tracker
<http://bu
Changes by Hirokazu Yamamoto :
--
dependencies: +only accept byte for getarg('c') and unicode for getarg('C')
___
Python tracker
<http://bu
Changes by Hirokazu Yamamoto :
--
priority: -> release blocker
___
Python tracker
<http://bugs.python.org/issue5499>
___
___
Python-bugs-list mailing list
Un
Hirokazu Yamamoto added the comment:
Note: #5391 and #5410 are depends on this issue.
--
___
Python tracker
<http://bugs.python.org/issue5499>
___
___
Python-bug
Hirokazu Yamamoto added the comment:
I've committed your test with some modification. (r70879) Thanks!
--
___
Python tracker
<http://bugs.python.org/i
Changes by Hirokazu Yamamoto :
--
priority: -> release blocker
___
Python tracker
<http://bugs.python.org/issue5410>
___
___
Python-bugs-list mailing list
Un
Changes by Hirokazu Yamamoto :
--
priority: -> release blocker
___
Python tracker
<http://bugs.python.org/issue5391>
___
___
Python-bugs-list mailing list
Un
New submission from Hirokazu Yamamoto :
This is related to #5499. PyArg_ParseTuple treats "c" as bytes of 1
length now, but Py_BuildValue still treats "c" as unicode of 1 length.
--
components: Interpreter Core
files: py3k_build_value.patch
keywords: patch
message
Hirokazu Yamamoto added the comment:
Yes, here is the patch. But I noticed Py_BuildValue('c') still returns
unicode. To pass the test, #5666 is needed.
--
dependencies: +Py_BuildValue("c") should return bytes?
Added file:
http://bugs.
Changes by Hirokazu Yamamoto :
Removed file:
http://bugs.python.org/file13575/py3k_mmap_bytes_cleanup_with_getarg_c.patch
___
Python tracker
<http://bugs.python.org/issue5
Changes by Hirokazu Yamamoto :
Added file:
http://bugs.python.org/file13576/py3k_mmap_bytes_cleanup_with_getarg_c.patch
___
Python tracker
<http://bugs.python.org/issue5
Hirokazu Yamamoto added the comment:
Yes, you can do
m.write_byte(b"a")
but on the other hand you cannot do
a = b"abc"
m.write_byte(a[1])
instead you should do
a = b"abc"
m.write_byte(a[1:2])
This is trade off, though.
I'll update &q
Changes by Hirokazu Yamamoto :
Removed file: http://bugs.python.org/file13215/py3k_mmap_and_bytes.patch
___
Python tracker
<http://bugs.python.org/issue5391>
___
___
Pytho
Hirokazu Yamamoto added the comment:
I'm sure, but with following test code,
def run(module):
print("///")
print("//", module)
memio = module.StringIO(newline=None)
# The C StringIO decodes newlines in writ
Changes by Hirokazu Yamamoto :
--
nosy: +pitrou
___
Python tracker
<http://bugs.python.org/issue5645>
___
___
Python-bugs-list mailing list
Unsubscribe:
Hirokazu Yamamoto added the comment:
I confirmed the patch works.
--
___
Python tracker
<http://bugs.python.org/issue5645>
___
___
Python-bugs-list mailin
Hirokazu Yamamoto added the comment:
I got SEGV on test_types on VC6, but after clean build, it seems SEGV
was gone. Maybe build problem?
--
nosy: +ocean-city
___
Python tracker
<http://bugs.python.org/issue5
Hirokazu Yamamoto added the comment:
This happens when running test from root directory. Following patch can
workaround this, but this code is there because it is needed, isn't it?
(Related to #4710?)
Index: Lib/zipfi
Hirokazu Yamamoto added the comment:
MSDN says _ungetwch returns WEOF instead of EOF when error occurs.
http://msdn.microsoft.com/en-us/library/yezzac74(VS.80).aspx
I cannot see any remarks about masking behavior. :-(
--
___
Python tracker
<h
Changes by Hirokazu Yamamoto :
--
superseder: os.renames() crashes NTFS junctions -> Patch for bug 1438185:
os.renames deletes junction points
___
Python tracker
<http://bugs.python.org/issue1
New submission from Hirokazu Yamamoto :
See http://docs.python.org/library/email.mime.html
Inside MIMEApplication documentation, link to MIMEApplication is enabled
but link to MIMENonMultipart is disabled. This happens because
MIMENonMultipart is not in email.mime.application (specified by
Hirokazu Yamamoto added the comment:
Sorry, I shouldn't call this a bug. Rather I should use the word
"proposal". I think a link to MIMENonMultipart is also useful. What I
can imagine how to achieve this is...
1. Rewrite MIMENonMultipart to email.mime.MIMENonMultipart
2. Intr
Hirokazu Yamamoto added the comment:
Thanks, I'll create the patch using this.
--
___
Python tracker
<http://bugs.python.org/issue5703>
___
___
Python-bugs-l
701 - 800 of 918 matches
Mail list logo
