Change by hai shi :
--
pull_requests: +20927
pull_request: https://github.com/python/cpython/pull/21785
___
Python tracker
<https://bugs.python.org/issue40
hai shi added the comment:
Hi, terry. When creating the new test helpers, the docs have been updated.
such as:
https://docs.python.org/3.10/library/test.html#module-test.support.os_helper
--
___
Python tracker
<https://bugs.python.org/issue40
hai shi added the comment:
# Confusing, especially now that PR #s are catching up to issue #s.
Maybe we need redefine the matching rule(I am not sure about it).
--
versions: +Python 3.10 -Python 3.9
___
Python tracker
<https://bugs.python.
hai shi added the comment:
> Hai Shi: Would you mind to investigate this issue?
Oh, sure, I will check the test cases again.
--
___
Python tracker
<https://bugs.python.org/issu
Change by hai shi :
--
pull_requests: +20944
pull_request: https://github.com/python/cpython/pull/21811
___
Python tracker
<https://bugs.python.org/issue40
Change by hai shi :
--
nosy: +shihai1991
___
Python tracker
<https://bugs.python.org/issue40949>
___
___
Python-bugs-list mailing list
Unsubscribe:
hai shi added the comment:
Hi, victor:
About https://bugs.python.org/issue40275#msg369214, shall we continue to
improve the libregretest?
1. Running test cases sequential: you have use a mechanism to unload the
modules which load in the running test cases stage:
https://github.com/python
hai shi added the comment:
There will have many unicode strs releaks when we calling `Py_Initialize()`
again after `Py_Finalize()`: interned will be cleared in `Py_Finalize()`, but
those unicodes str will still alive all the time.
Q: How to solve the probleam?
A: MAYBE we need share the
Change by hai shi :
--
nosy: +paul.j3, rhettinger
___
Python tracker
<https://bugs.python.org/issue41534>
___
___
Python-bugs-list mailing list
Unsubscribe:
hai shi added the comment:
> Py_Finalize() calls _PyUnicode_ClearInterned() which clears interned strings.
> Which strings are still alive after Py_Finalize()?
Yes.especially those encodings, interpreter leaks much encodings refcount after
Py_Finalize(). I am not sure they are corner
hai shi added the comment:
If someone wants to continue the effort in libregrtest, I suggest to open a new
issue.
+1. And if there have any other test cases blocked by test.support, I suggest
this bpo.
--
___
Python tracker
<ht
hai shi added the comment:
oh, sorry, missing a word: I suggest this bpo.->I suggest close this bpo.
--
___
Python tracker
<https://bugs.python.org/issu
Change by hai shi :
--
pull_requests: +21015
pull_request: https://github.com/python/cpython/pull/21896
___
Python tracker
<https://bugs.python.org/issue1635
Change by hai shi :
--
nosy: +shihai1991
___
Python tracker
<https://bugs.python.org/issue41551>
___
___
Python-bugs-list mailing list
Unsubscribe:
Change by hai shi :
--
pull_requests: +21022
pull_request: https://github.com/python/cpython/pull/21902
___
Python tracker
<https://bugs.python.org/issue1635
Change by hai shi :
--
pull_requests: +21044
pull_request: https://github.com/python/cpython/pull/21931
___
Python tracker
<https://bugs.python.org/issue41
New submission from hai shi :
In order to resolve bpo41073, we want to extend `PyType_GetSlot()` to accept
static types. But there have another question we should be considered: How many
slots should be exposed in `PyType_GetSlot()`.
petr's opinion from PR-21931:I would not want to e
hai shi added the comment:
related bpo: bpo-41073
--
___
Python tracker
<https://bugs.python.org/issue41618>
___
___
Python-bugs-list mailing list
Unsubscribe:
New submission from hai shi :
After the EOL of python2, the shebang of tools should be ported from python2 to
python3.
some files like:
https://github.com/python/cpython/blob/master/Objects/typeslots.py#L1
--
messages: 375855
nosy: shihai1991
priority: normal
severity: normal
status
Change by hai shi :
--
keywords: +patch
pull_requests: +21058
stage: -> patch review
pull_request: https://github.com/python/cpython/pull/21948
___
Python tracker
<https://bugs.python.org/issu
Change by hai shi :
--
nosy: +shihai1991
___
Python tracker
<https://bugs.python.org/issue41631>
___
___
Python-bugs-list mailing list
Unsubscribe:
Change by hai shi :
--
nosy: +shihai1991
___
Python tracker
<https://bugs.python.org/issue41625>
___
___
Python-bugs-list mailing list
Unsubscribe:
Change by hai shi :
--
nosy: +shihai1991
___
Python tracker
<https://bugs.python.org/issue41654>
___
___
Python-bugs-list mailing list
Unsubscribe:
hai shi added the comment:
Hm, Looks like we need check the double free risk of `Py_DECREF()`.
--
___
Python tracker
<https://bugs.python.org/issue41
Change by hai shi :
--
nosy: +shihai1991
___
Python tracker
<https://bugs.python.org/issue41692>
___
___
Python-bugs-list mailing list
Unsubscribe:
Change by hai shi :
--
nosy: +shihai1991
___
Python tracker
<https://bugs.python.org/issue41713>
___
___
Python-bugs-list mailing list
Unsubscribe:
hai shi added the comment:
+1
--
___
Python tracker
<https://bugs.python.org/issue41692>
___
___
Python-bugs-list mailing list
Unsubscribe:
https://mail.pyth
New submission from hai shi :
`PyType_FromModuleAndSpec` in docs doesn't show the info:`Return value: New
reference.`
--
assignee: docs@python
components: Documentation
messages: 376432
nosy: docs@python, petr.viktorin, shihai1991
priority: normal
severity: normal
status: open
Change by hai shi :
--
keywords: +patch
pull_requests: +21196
stage: -> patch review
pull_request: https://github.com/python/cpython/pull/22112
___
Python tracker
<https://bugs.python.org/issu
Change by hai shi :
--
title: Update the refcounts.dat of `PyType_FromModuleAndSpec` -> Update
refcounts info of PyType_FromModuleAndSpec in refcounts.dat
___
Python tracker
<https://bugs.python.org/issu
Change by hai shi :
--
nosy: +shihai1991
___
Python tracker
<https://bugs.python.org/issue41739>
___
___
Python-bugs-list mailing list
Unsubscribe:
Change by hai shi :
--
nosy: +shihai1991
___
Python tracker
<https://bugs.python.org/issue41736>
___
___
Python-bugs-list mailing list
Unsubscribe:
Change by hai shi :
--
pull_requests: +21274
pull_request: https://github.com/python/cpython/pull/22219
___
Python tracker
<https://bugs.python.org/issue39
Change by hai shi :
--
nosy: +shihai1991
___
Python tracker
<https://bugs.python.org/issue40288>
___
___
Python-bugs-list mailing list
Unsubscribe:
Change by hai shi :
--
nosy: +shihai1991
___
Python tracker
<https://bugs.python.org/issue41798>
___
___
Python-bugs-list mailing list
Unsubscribe:
Change by hai shi :
--
nosy: +shihai1991
___
Python tracker
<https://bugs.python.org/issue41797>
___
___
Python-bugs-list mailing list
Unsubscribe:
hai shi added the comment:
Hi, petr. Can you help me merge this PR to 3.9 too?
--
___
Python tracker
<https://bugs.python.org/issue41726>
___
___
Python-bug
Change by hai shi :
--
pull_requests: +21401
pull_request: https://github.com/python/cpython/pull/22360
___
Python tracker
<https://bugs.python.org/issue39
Change by hai shi :
--
nosy: +shihai1991
___
Python tracker
<https://bugs.python.org/issue41832>
___
___
Python-bugs-list mailing list
Unsubscribe:
Change by hai shi :
--
keywords: +patch
nosy: +shihai1991
nosy_count: 3.0 -> 4.0
pull_requests: +21424
stage: -> patch review
pull_request: https://github.com/python/cpython/pull/22360
___
Python tracker
<https://bugs.python.org/i
New submission from hai shi :
Do we need add PyList_Remove() in C level? same thing like list.remove().
As victor comment in:
https://github.com/python/cpython/pull/19069#discussion_r491893466.
--
components: C API
messages: 377566
nosy: shihai1991, vstinner
priority: normal
severity
hai shi added the comment:
> You always can use PyObject_CallMethod(). It is not a method called in tight
> loop for which the overhead of calling method is significant.
Thanks, serhiy. You are right.
To PR19069, it's fine to use `PyList_SetSlice` or `PyObject_CallMethod`.
We don
hai shi added the comment:
> If add a function for unregistering a codec search function, it would be
> worth to add also a function for unregistering an error handler.
Registering an error handler have no refleaks when registering multiple search
functions.
+1 if end user nee
hai shi added the comment:
oh, sorry, typo error. multiple search functions-->multiple error handler.
--
___
Python tracker
<https://bugs.python.org/issu
Change by hai shi :
--
nosy: +shihai1991
___
Python tracker
<https://bugs.python.org/issue41902>
___
___
Python-bugs-list mailing list
Unsubscribe:
Change by hai shi :
--
nosy: +shihai1991
___
Python tracker
<https://bugs.python.org/issue40455>
___
___
Python-bugs-list mailing list
Unsubscribe:
New submission from hai shi :
After PR22360 merged, we can move the codecs' register operation to testcases.
--
components: Tests
messages: 377863
nosy: shihai1991, vstinner
priority: normal
severity: normal
status: open
title: Move the codecs' register operation to test
Change by hai shi :
--
keywords: +patch
pull_requests: +21522
stage: -> patch review
pull_request: https://github.com/python/cpython/pull/22513
___
Python tracker
<https://bugs.python.org/issu
Change by hai shi :
--
title: Move the codecs' register operation to testcases -> Move the
codecs.register operation to testcases
___
Python tracker
<https://bugs.python.org
hai shi added the comment:
Thanks for everyone's continus review :)
--
___
Python tracker
<https://bugs.python.org/issue39337>
___
___
Python-bugs-list m
hai shi added the comment:
> Definitely. Sorry for the delay -- I missed the notification here.
No problem. This is not a block issue :)
--
___
Python tracker
<https://bugs.python.org/issu
hai shi added the comment:
Thanks petr for your review and merge.
--
___
Python tracker
<https://bugs.python.org/issue41726>
___
___
Python-bugs-list mailin
Change by hai shi :
--
pull_requests: +21888
pull_request: https://github.com/python/cpython/pull/22973
___
Python tracker
<https://bugs.python.org/issue41
hai shi added the comment:
> AS this is masking other issues in the build bots, we need to revert the
> commit unless is fixed in 24 hours per the buildbot workflow
Thanks, Pablo. I checked that only test_io.py have resource leak.
I create PR-22973, pls take a look if you have fre
hai shi added the comment:
I created a possible fix PR: PR-22973
--
___
Python tracker
<https://bugs.python.org/issue42145>
___
___
Python-bugs-list mailin
Change by hai shi :
--
nosy: +shihai1991
___
Python tracker
<https://bugs.python.org/issue38865>
___
___
Python-bugs-list mailing list
Unsubscribe:
Change by hai shi :
--
nosy: +shihai1991
___
Python tracker
<https://bugs.python.org/issue41796>
___
___
Python-bugs-list mailing list
Unsubscribe:
Change by hai shi :
--
nosy: +shihai1991
___
Python tracker
<https://bugs.python.org/issue42171>
___
___
Python-bugs-list mailing list
Unsubscribe:
Change by hai shi :
--
nosy: +shihai1991
___
Python tracker
<https://bugs.python.org/issue42111>
___
___
Python-bugs-list mailing list
Unsubscribe:
hai shi added the comment:
> IMO, a slot should be exposed if there is some reason for exposing it.
Can we write those info to docs? In case some developer want to exposing slot
in future.
> Which other slots are we missing?
nb_inserved in PyNumberMethods should be r
hai shi added the comment:
Sorry for my delay~
>I think some of these work with any Python, but some need the locally built
>interpreter to give correct results.
>It could avoid confusion and mistakes to remove the shebangs and executable
>bits from the scripts that need a local
hai shi added the comment:
typo error: PR21913->PR21931
--
___
Python tracker
<https://bugs.python.org/issue41626>
___
___
Python-bugs-list mailing list
Un
Change by hai shi :
--
nosy: +shihai1991
___
Python tracker
<https://bugs.python.org/issue42100>
___
___
Python-bugs-list mailing list
Unsubscribe:
Change by hai shi :
--
pull_requests: +22010
stage: resolved -> patch review
pull_request: https://github.com/python/cpython/pull/23096
___
Python tracker
<https://bugs.python.org/issu
hai shi added the comment:
I will take a look in this weekend :)
--
___
Python tracker
<https://bugs.python.org/issue41832>
___
___
Python-bugs-list mailin
Change by hai shi :
--
versions: +Python 3.10 -Python 3.9
___
Python tracker
<https://bugs.python.org/issue40077>
___
___
Python-bugs-list mailing list
Unsub
Change by hai shi :
--
keywords: +patch
pull_requests: +22039
stage: -> patch review
pull_request: https://github.com/python/cpython/pull/23123
___
Python tracker
<https://bugs.python.org/issu
Change by hai shi :
--
nosy: +shihai1991
___
Python tracker
<https://bugs.python.org/issue42035>
___
___
Python-bugs-list mailing list
Unsubscribe:
hai shi added the comment:
> If you change this, why do it only for tp_doc, but for all the slots? NULL
> should *always* mean that the slot is set to NULL instead of inherited.
> (Except maybe in cases where this is dangerous; then it should result in an
> error?
IMO, it
Change by hai shi :
--
nosy: +shihai1991
___
Python tracker
<https://bugs.python.org/issue42260>
___
___
Python-bugs-list mailing list
Unsubscribe:
hai shi added the comment:
Thank you all:)
--
___
Python tracker
<https://bugs.python.org/issue41832>
___
___
Python-bugs-list mailing list
Unsubscribe:
New submission from hai shi :
I like your improvement.
But I suggest you should copy your first comment from your PR to here.(It's
easy for discuss in here;)
--
nosy: +paul.j3, rhettinger, shihai1991
___
Python tracker
<https://bugs.py
hai shi added the comment:
> Do you mean something like "only expose a slot if you have a reason for >
> exposing it"? That sounds like a tautology.
> Where in the docs would this go?
Add a friend Note in docs of `PyType_GetSlot` MAYBE?
> You mean nb_reserved, ri
Change by hai shi :
--
nosy: +shihai1991
___
Python tracker
<https://bugs.python.org/issue42294>
___
___
Python-bugs-list mailing list
Unsubscribe:
Change by hai shi :
--
versions: +Python 3.10 -Python 3.9
___
Python tracker
<https://bugs.python.org/issue40137>
___
___
Python-bugs-list mailing list
Unsub
Change by hai shi :
--
pull_requests: +22132
pull_request: https://github.com/python/cpython/pull/23235
___
Python tracker
<https://bugs.python.org/issue40
hai shi added the comment:
> The PR entirely removed the note that a slot's value "May not be NULL".
> In fact, only tp_doc may be NULL. AFAIK, the restriction is still there > for
> other slots.
> Can that note be added back?
`May not be NULL` means evert
Change by hai shi :
--
pull_requests: +22140
stage: resolved -> patch review
pull_request: https://github.com/python/cpython/pull/23243
___
Python tracker
<https://bugs.python.org/issu
Change by hai shi :
--
nosy: +shihai1991
___
Python tracker
<https://bugs.python.org/issue42333>
___
___
Python-bugs-list mailing list
Unsubscribe:
hai shi added the comment:
Hi, petr. If there is no other doubt about this bpo, I suggest close this bpo.
--
___
Python tracker
<https://bugs.python.org/issue41
Change by hai shi :
--
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.org/issue41832>
___
___
Python-bugs-
Change by hai shi :
--
nosy: +shihai1991
___
Python tracker
<https://bugs.python.org/issue41861>
___
___
Python-bugs-list mailing list
Unsubscribe:
Change by hai shi :
--
nosy: +shihai1991
___
Python tracker
<https://bugs.python.org/issue40600>
___
___
Python-bugs-list mailing list
Unsubscribe:
Change by hai shi :
--
pull_requests: +22298
stage: resolved -> patch review
pull_request: https://github.com/python/cpython/pull/23405
___
Python tracker
<https://bugs.python.org/issu
hai shi added the comment:
Duplicated issue: bpo-40137, so I closed this one.
--
___
Python tracker
<https://bugs.python.org/issue40891>
___
___
Python-bug
Change by hai shi :
--
resolution: -> duplicate
stage: -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.org/issue40891>
___
New submission from hai shi :
Touch an error when convert _functools module to use PyType_FromModuleAndSpec,
the error info:
_pickle.PicklingError: Can't pickle : it's not the
same object as functools.partial
The related PR: PR3405
--
components: Extension Modules
messag
hai shi added the comment:
Oh, sorry, wrong PR number. the right one: PR23405
--
___
Python tracker
<https://bugs.python.org/issue42410>
___
___
Python-bug
Change by hai shi :
--
keywords: +patch
pull_requests: +22300
stage: -> patch review
pull_request: https://github.com/python/cpython/pull/23407
___
Python tracker
<https://bugs.python.org/issu
hai shi added the comment:
>I propose to either a guard to PyType_GetModule() to prevent misuse of the
>function or to add a variant of the function that prevents misuse.
+1. Looks like check Py_TPFLAGS_BASETYPE in PyType_GetModule() is an easy way:)
--
nosy: +shih
hai shi added the comment:
> You should analyze why "cls != obj" conditon is true: why cls is not obj?
You are right. I am in the wrong way definitely. It's weird to me.I try to
figure it out in this week~
--
___
Pyth
hai shi added the comment:
> It looks like you imported the functools module twice and have two different
> classes functools.partial. When you try to import one of them, you found the
> other one.
You are right. Serhiy:)
The key point is `import_helper.import_fresh_module()`.
`
hai shi added the comment:
I updated the test_functools.py in PR23405, the CI have all passed.
--
___
Python tracker
<https://bugs.python.org/issue42
hai shi added the comment:
> Does it mean that this issue is invalid and can be closed?
I think it's can be closed if I can update test_functools.py in PR23405 :)
--
___
Python tracker
<https://bugs.python.org
Change by hai shi :
--
resolution: -> not a bug
___
Python tracker
<https://bugs.python.org/issue42410>
___
___
Python-bugs-list mailing list
Unsubscrib
Change by hai shi :
--
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.org/issue42410>
___
___
Python-bugs-
Change by hai shi :
--
nosy: +shihai1991
___
Python tracker
<https://bugs.python.org/issue42376>
___
___
Python-bugs-list mailing list
Unsubscribe:
Change by hai shi :
--
pull_requests: +13491
stage: backport needed -> patch review
pull_request: https://github.com/python/cpython/pull/13584
___
Python tracker
<https://bugs.python.org/issu
hai shi added the comment:
hi, everyone. I am a freshman,so let me do it from easy issues:)
--
nosy: +shihai1991
___
Python tracker
<https://bugs.python.org/issue33
hai shi added the comment:
I think you are right, so i remain meaningful intro. Anyone else has an thought?
--
versions: -Python 3.7, Python 3.8
___
Python tracker
<https://bugs.python.org/issue33
501 - 600 of 700 matches
Mail list logo