Change by hai shi :
--
nosy: +shihai1991
___
Python tracker
<https://bugs.python.org/issue40221>
___
___
Python-bugs-list mailing list
Unsubscribe:
Change by hai shi :
--
keywords: +patch
nosy: +shihai1991
nosy_count: 2.0 -> 3.0
pull_requests: +18836
stage: -> patch review
pull_request: https://github.com/python/cpython/pull/19482
___
Python tracker
<https://bugs.python.org/i
hai shi added the comment:
If I understand correctly, `p->depth--` associated with `p->error` could be
removed?
--
___
Python tracker
<https://bugs.python.org/i
Change by hai shi :
--
nosy: +shihai1991
___
Python tracker
<https://bugs.python.org/issue40255>
___
___
Python-bugs-list mailing list
Unsubscribe:
hai shi added the comment:
> Py_TRASHCAN_BEGIN() access directly PyTypeObject.tp_dealloc
Looks like this macro not recorded in docs. Do we need using function to
replace this macro?
--
___
Python tracker
<https://bugs.python.org/issu
Change by hai shi :
--
pull_requests: +18889
pull_request: https://github.com/python/cpython/pull/19541
___
Python tracker
<https://bugs.python.org/issue40
hai shi added the comment:
> It never prevented anyone to use a function of the C API :-)
Got it. If possible someone uses it, I will try to add a function to repalce
it(MAYBE udpate this docs too;) )
--
___
Python tracker
<
Change by hai shi :
--
nosy: +shihai1991
___
Python tracker
<https://bugs.python.org/issue40294>
___
___
Python-bugs-list mailing list
Unsubscribe:
Change by hai shi :
--
nosy: +shihai1991
___
Python tracker
<https://bugs.python.org/issue40092>
___
___
Python-bugs-list mailing list
Unsubscribe:
hai shi added the comment:
> Hai: if you want to move on this issue, you have to find who uses this CI and
> how it should behave.
Copy that. I found PR7773 updated the travis' coverage ci and a discussion
issue in https://github.com/python/core-workflow/issues/2, so I add brett
Change by hai shi :
--
keywords: +patch
nosy: +shihai1991
nosy_count: 1.0 -> 2.0
pull_requests: +18929
stage: -> patch review
pull_request: https://github.com/python/cpython/pull/19592
___
Python tracker
<https://bugs.python.org/i
hai shi added the comment:
> "import test.support" imports not less than 171... That's quite "heavy".
If we split some "heavy" modules to xxxutils, what benefits will we make in
fact(more exact module importing behavior)?
--
Change by hai shi :
--
nosy: +shihai1991
___
Python tracker
<https://bugs.python.org/issue40284>
___
___
Python-bugs-list mailing list
Unsubscribe:
hai shi added the comment:
> asyncio is now imported in unittest. Removing direct import from test.support
> does not help.
Oh, thanks, you are right. Looks like we need check which submodules should be
splitted.
--
___
Python tracker
Change by hai shi :
--
pull_requests: +18935
pull_request: https://github.com/python/cpython/pull/19599
___
Python tracker
<https://bugs.python.org/issue40
hai shi added the comment:
> These three PRs combined reduce the number of imported modules from 179 to
> 105 (not including 24 modules imported by the bare interpreter) and reduce
> the hot import time from 160 ms to 80 ms.
Good job, serhiy. I tested your patches in my vm, the
hai shi added the comment:
> I used -X importtime.
copy that, thanks.
In master branch:
import time: 5011 | 133562 | test.support
After apply serhiy's patches:
import time: 4863 | 66940 | test.support
--
___
Python
Change by hai shi :
--
keywords: +patch
nosy: +shihai1991
nosy_count: 2.0 -> 3.0
pull_requests: +18947
stage: -> patch review
pull_request: https://github.com/python/cpython/pull/19615
___
Python tracker
<https://bugs.python.org/i
hai shi added the comment:
I found this warning too(ps: my gcc is 9.3.0 ;)
Can we add a inner macro like `_unused(var) (void) var`?
Hi, serhiy, can you give us some advice?
--
___
Python tracker
<https://bugs.python.org/issue39
Change by hai shi :
--
pull_requests: +18952
pull_request: https://github.com/python/cpython/pull/19623
___
Python tracker
<https://bugs.python.org/issue39
Change by hai shi :
--
nosy: +shihai1991
___
Python tracker
<https://bugs.python.org/issue40338>
___
___
Python-bugs-list mailing list
Unsubscribe:
hai shi added the comment:
> The historical background is code coverage of C code seemed like a good idea,
> so we set it up. :) Not much else to it.
Hm, code coverage of C code including two parts:
1) coverage of inner c code;
2) extension modules built by distutils;
If I unde
hai shi added the comment:
>It seems to behave as expected
+1. This is an interesting test;)
--
___
Python tracker
<https://bugs.python.org/issue40338>
___
_
hai shi added the comment:
>since we are going to delete the threading.Thread object with its _tstate_lock
>object anymore.
Do we have any pep or discuss record about this plan?
> * Modify release_sentinel() to not use the lock: avoid
> PyThread_release_lock() call.
Hm, I
Change by hai shi :
--
pull_requests: +19041
pull_request: https://github.com/python/cpython/pull/19716
___
Python tracker
<https://bugs.python.org/issue40
hai shi added the comment:
> "since we are going to delete the threading.Thread object with its
> _tstate_lock object anyway" sentence is a description of the current
> _PyThreadState_DeleteExcept() implementation.
Oh, got it. thanks f
Change by hai shi :
--
pull_requests: +19102
pull_request: https://github.com/python/cpython/pull/19761
___
Python tracker
<https://bugs.python.org/issue40
hai shi added the comment:
> Sadly (again), closing/reopening a PR re-runs all CIs. At the first run, GH
> Action macOS job passed. At the second run, the "Tests" step of GH Action
> macOS job, but I'm clueless with its logs: (...)
Oh, I encountered the sam
Change by hai shi :
--
pull_requests: +19194
pull_request: https://github.com/python/cpython/pull/19882
___
Python tracker
<https://bugs.python.org/issue39
Change by hai shi :
--
keywords: +patch
nosy: +shihai1991
nosy_count: 1.0 -> 2.0
pull_requests: +19203
stage: -> patch review
pull_request: https://github.com/python/cpython/pull/19892
___
Python tracker
<https://bugs.python.org/i
hai shi added the comment:
The easy way to fix this test case is that don't define the shared memory
block's name. `test_shared_memory_basics` has tested against the shared memory
block's name, so canceling the shared memory block'nam
Change by hai shi :
--
pull_requests: +19220
pull_request: https://github.com/python/cpython/pull/19905
___
Python tracker
<https://bugs.python.org/issue40
Change by hai shi :
--
nosy: +shihai1991
___
Python tracker
<https://bugs.python.org/issue40513>
___
___
Python-bugs-list mailing list
Unsubscribe:
New submission from hai shi :
Nick left a comment in `pydebug.h`
/* These global variable are defined in pylifecycle.c */
/* XXX (ncoghlan): move these declarations to pylifecycle.h? */
I have checked those global variables are not only debug variables and they are
defined in `Python
Change by hai shi :
--
keywords: +patch
pull_requests: +19245
stage: -> patch review
pull_request: https://github.com/python/cpython/pull/19930
___
Python tracker
<https://bugs.python.org/issu
Change by hai shi :
--
pull_requests: +19246
pull_request: https://github.com/python/cpython/pull/19931
___
Python tracker
<https://bugs.python.org/issue40
hai shi added the comment:
Got it, thanks for your explanation, victor ;)
--
___
Python tracker
<https://bugs.python.org/issue40520>
___
___
Python-bugs-list m
hai shi added the comment:
Thanks, Dong-hee Na ;)
--
___
Python tracker
<https://bugs.python.org/issue40520>
___
___
Python-bugs-list mailing list
Unsubscribe:
Change by hai shi :
--
nosy: +shihai1991
___
Python tracker
<https://bugs.python.org/issue40512>
___
___
Python-bugs-list mailing list
Unsubscribe:
Change by hai shi :
--
nosy: +shihai1991
___
Python tracker
<https://bugs.python.org/issue40533>
___
___
Python-bugs-list mailing list
Unsubscribe:
Change by hai shi :
--
nosy: +shihai1991
___
Python tracker
<https://bugs.python.org/issue38787>
___
___
Python-bugs-list mailing list
Unsubscribe:
Change by hai shi :
--
pull_requests: +19296
pull_request: https://github.com/python/cpython/pull/19980
___
Python tracker
<https://bugs.python.org/issue38
Change by hai shi :
--
nosy: +shihai1991
___
Python tracker
<https://bugs.python.org/issue40549>
___
___
Python-bugs-list mailing list
Unsubscribe:
New submission from hai shi :
update the links of buildbot in CONTRIBUTING.rst.
I don't know why I can not visit `http://buildbot.python.org/3.8.stable/`
--
assignee: docs@python
components: Documentation
messages: 368422
nosy: docs@python, shihai1991
priority: normal
severity: n
Change by hai shi :
--
keywords: +patch
pull_requests: +19305
stage: -> patch review
pull_request: https://github.com/python/cpython/pull/19989
___
Python tracker
<https://bugs.python.org/issu
hai shi added the comment:
> That redirect just didn't exist yet :). It now does, and I went ahead and
> added it for 3.9 ahead of time.
Thanks, Zachary. It worked.
--
___
Python tracker
<https://bugs.python.
Change by hai shi :
--
nosy: +shihai1991
___
Python tracker
<https://bugs.python.org/issue40574>
___
___
Python-bugs-list mailing list
Unsubscribe:
New submission from hai shi :
some typeobject using `tp_vectorcall_offset`, if we use
`PyType_FromModuleAndSpec` to create the the typeobject, it will be faild due
to `PyType_FromModuleAndSpec` lack the process of `tp_vectorcall_offset`.
so we should adding some process like
https
Change by hai shi :
--
keywords: +patch
pull_requests: +19336
stage: -> patch review
pull_request: https://github.com/python/cpython/pull/20026
___
Python tracker
<https://bugs.python.org/issu
hai shi added the comment:
> Note that __dictoffset__ and __weaklistoffset__ are also exposed as members
> (in PyMemberDef type_members) and documented (Doc/c-api/structures.rst). A
> new __vectorcalloffset__ should have that as well.
Thanks for your comment, petr. And I updated t
Change by hai shi :
--
pull_requests: +19364
pull_request: https://github.com/python/cpython/pull/20055
___
Python tracker
<https://bugs.python.org/issue40
hai shi added the comment:
In PR19982, petr have mentioned that `PyType_GetModule` can not worked if the
type is the subtype.
I try to use pep573 in functools, I get the error info from testcases:
==
ERROR
Change by hai shi :
--
nosy: +shihai1991
___
Python tracker
<https://bugs.python.org/issue40601>
___
___
Python-bugs-list mailing list
Unsubscribe:
hai shi added the comment:
> I guess I'll need to clarify the documentation here.
> Call `PyType_GetModule` on the *defining class*, not on type(self).
+1, I didn't notice this detail until I got the error.
> The associated module is not inherited; each class in the MRO
hai shi added the comment:
Hi, folks.
If there have no other imports should be improved, I suggest to close this bpo
;)
--
___
Python tracker
<https://bugs.python.org/issue40
hai shi added the comment:
> It seems like there is coverage on both C and Python code.
Great, MAYBE we can use this coverage result to improve our testcases.
--
___
Python tracker
<https://bugs.python.org/issu
Change by hai shi :
--
pull_requests: +19433
pull_request: https://github.com/python/cpython/pull/20128
___
Python tracker
<https://bugs.python.org/issue40
hai shi added the comment:
OK, I continue to reduce the import module in test.supports.
--
___
Python tracker
<https://bugs.python.org/issue40275>
___
___
Pytho
hai shi added the comment:
After PR20128, the import modules from 132 to 123.
--
___
Python tracker
<https://bugs.python.org/issue40275>
___
___
Python-bug
Change by hai shi :
--
pull_requests: +19436
pull_request: https://github.com/python/cpython/pull/20131
___
Python tracker
<https://bugs.python.org/issue40
hai shi added the comment:
> Hai: do you want to work on a PR?
Oh, Looks like I am late, Christian have crated a PR ;)
--
___
Python tracker
<https://bugs.python.org/issu
Change by hai shi :
--
pull_requests: +22459
pull_request: https://github.com/python/cpython/pull/23581
___
Python tracker
<https://bugs.python.org/issue41
hai shi added the comment:
I create PR23581 to remove the inner Tools' shebang.
But I am not remove Tools/ssl/make_ssl_data.py, Tools/gdb/libpython.py in
PR23581.
* To make_ssl_data.py, I guess Christian may give us some guide.
* libpython.py will be installed in kinds of OS, some OS
Change by hai shi :
--
nosy: +christian.heimes
___
Python tracker
<https://bugs.python.org/issue41626>
___
___
Python-bugs-list mailing list
Unsubscribe:
Change by hai shi :
--
nosy: +shihai1991
___
Python tracker
<https://bugs.python.org/issue42522>
___
___
Python-bugs-list mailing list
Unsubscribe:
Change by hai shi :
--
nosy: +shihai1991
___
Python tracker
<https://bugs.python.org/issue42519>
___
___
Python-bugs-list mailing list
Unsubscribe:
Change by hai shi :
--
versions: +Python 3.10 -Python 3.4
___
Python tracker
<https://bugs.python.org/issue15674>
___
___
Python-bugs-list mailing list
Unsub
hai shi added the comment:
>On the other side, defining a Py_mod_exec_once that supports execution > >for
>just once can be a way.
>Although the usage is little, it will be fine because the use case will >exist.
IMHO, `Py_mod_exec_once` is more like a slot control flag. M
Change by hai shi :
--
keywords: +patch
pull_requests: +22547
stage: test needed -> patch review
pull_request: https://github.com/python/cpython/pull/23683
___
Python tracker
<https://bugs.python.org/issu
hai shi added the comment:
> MAYBE we need add a module flag in `PyModuleDef`.
I created a demo in PR 23683.
--
___
Python tracker
<https://bugs.python.org/issu
New submission from hai shi :
PyModule_GetWarningsModule() of pylifecycle.c is useless when _warning module
was converted to a builtin module in 2.6. So move it directly now is OK.
--
components: Interpreter Core
messages: 382727
nosy: petr.viktorin, shihai1991, vstinner
priority
Change by hai shi :
--
keywords: +patch
pull_requests: +22559
stage: -> patch review
pull_request: https://github.com/python/cpython/pull/23691
___
Python tracker
<https://bugs.python.org/issu
hai shi added the comment:
> But it would not harm to document the removal in
> https://docs.python.org/dev/whatsnew/3.10.html#id4 section.
Copy that. I will update it soon.
--
___
Python tracker
<https://bugs.python.org/i
hai shi added the comment:
> another solution is to move the "module state" into the interpreter,
OK, I am agree victor's solution too. It's a more simpler way.
--
___
Python tracker
<https://
hai shi added the comment:
Hi, Thanks for your report, Deepanshu. Can you upload your code in here?
Adding victor in this bpo, MAYBE he can give some suggestions about it.
--
nosy: +shihai1991, vstinner
___
Python tracker
<https://bugs.python.
hai shi added the comment:
>This code could be made much safer if there were a
>PyType_FromSpecWithBasesMeta which used the meta class to allocate the memory
IMHO, `PyType_FromSpecWithBases` is a atomic API of `TypeObject`.
Adding a class as a param will result in `PyType_FromSpecWit
New submission from hai shi :
PyState_AddModule(NULL, &_testcapimodule) in _testcapi module will get a
segmentation fault. And it's a C API, so a little improvement will be better.
--
assignee: shihai1991
components: C API
messages: 382915
nosy: petr.viktorin, shihai1991,
Change by hai shi :
--
keywords: +patch
pull_requests: +22603
stage: -> patch review
pull_request: https://github.com/python/cpython/pull/23745
___
Python tracker
<https://bugs.python.org/issu
hai shi added the comment:
> When does this actually happen? Is there a common situation where you'd
> mistakenly pass NULL to PyState_AddModule?
If created mod haven't been checked will have this risk. PyState_AddModule
is a exposing C API, we should make sure that calling
Change by hai shi :
--
nosy: +shihai1991
___
Python tracker
<https://bugs.python.org/issue42639>
___
___
Python-bugs-list mailing list
Unsubscribe:
Change by hai shi :
--
pull_requests: +22634
pull_request: https://github.com/python/cpython/pull/23683
___
Python tracker
<https://bugs.python.org/issue42
hai shi added the comment:
Thanks victor, petr for your comment and review. I closed this bpo and PR.
I paste victor's explanation in here in case other developers have the same
question too: Getting a crash is the
expected behaviour if you don't respect a function API. Most C
fun
Change by hai shi :
--
nosy: +paul.j3, rhettinger
___
Python tracker
<https://bugs.python.org/issue42650>
___
___
Python-bugs-list mailing list
Unsubscribe:
Change by hai shi :
--
keywords: +patch
pull_requests: +22757
stage: -> patch review
pull_request: https://github.com/python/cpython/pull/23903
___
Python tracker
<https://bugs.python.org/issu
hai shi added the comment:
>I don't see the purpose of the Py_TPFLAGS_HAVE_VERSION_TAG flag.
IMO, There have no more exact description of `Py_TPFLAGS_HAVE_VERSION_TAG`in
docs, so I perfer to remove it.
> By the way, is it worth it to remove Py_TPFLAGS_HAVE_FINALIZE? Or is it
Change by hai shi :
--
nosy: +shihai1991
___
Python tracker
<https://bugs.python.org/issue42767>
___
___
Python-bugs-list mailing list
Unsubscribe:
hai shi added the comment:
> #define XxoObject_CheckExact(v) (Py_TYPE(v) == &Xxo_Type)
`#define Xxo_CheckExact(obj) Py_IS_TYPE(obj, &Xxo_Type)` would be better to
hide details now.
> #define XxoObject_Check(v) PyObject_TypeCheck(v, &Xxo_Type)
+1
I think the annotatio
hai shi added the comment:
Thanks Patrick for your PR.
Thanks Serhiy for your merge.
--
nosy: +shihai1991
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
hai shi added the comment:
> I wrote PR 24006 to fix the leak.
Oh, thanks for your fix, victor.
--
___
Python tracker
<https://bugs.python.org/issu
hai shi added the comment:
After PR 23405 and PR 24006 merged, I think this bpo can be closed.
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Change by hai shi :
--
nosy: +shihai1991
___
Python tracker
<https://bugs.python.org/issue40522>
___
___
Python-bugs-list mailing list
Unsubscribe:
hai shi added the comment:
>The Check code is now commented out, and the issue of type checking is
>mentioned in PEP 630.
Got it, thanks for your supplement :)
--
___
Python tracker
<https://bugs.python.org/i
Change by hai shi :
--
keywords: +patch
pull_requests: +22895
stage: -> patch review
pull_request: https://github.com/python/cpython/pull/24061
___
Python tracker
<https://bugs.python.org/issu
Change by hai shi :
--
pull_requests: +22927
pull_request: https://github.com/python/cpython/pull/24096
___
Python tracker
<https://bugs.python.org/issue41
hai shi added the comment:
> Hai Shi, do you mind if I have a go at the socket module CAPI capsule?
Welcome to join this bpo, you can enhance those extension modules if you like :)
--
___
Python tracker
<https://bugs.python.org/issu
Change by hai shi :
--
nosy: +vinay.sajip
___
Python tracker
<https://bugs.python.org/issue42842>
___
___
Python-bugs-list mailing list
Unsubscribe:
Change by hai shi :
--
pull_requests: +23014
pull_request: https://github.com/python/cpython/pull/24186
___
Python tracker
<https://bugs.python.org/issue41
Change by hai shi :
--
nosy: +paul.j3, rhettinger
___
Python tracker
<https://bugs.python.org/issue42875>
___
___
Python-bugs-list mailing list
Unsubscribe:
hai shi added the comment:
>Not a function, shouldn't be used with PyType_Slot:
> * tp_dict - I'd add a PyType_GetDict if there is a need to get this
> * tp_mro - I'd add a PyType_GetMRO if there is a need to get this
I checked some other projects which use type
Change by hai shi :
--
nosy: +shihai1991
___
Python tracker
<https://bugs.python.org/issue42972>
___
___
Python-bugs-list mailing list
Unsubscribe:
301 - 400 of 700 matches
Mail list logo