Guilherme Polo added the comment:
Uhm, is it fine to remove it for good in 3.1 ? And then add a warning in
2.7 when it gets called which in turns just call Tkapp_Call ?
___
Python tracker
<http://bugs.python.org/issue1581
Guilherme Polo added the comment:
Any chance I can get this in ? I'm using something very similar to test
the ttk wrapper and will also be using in other tests, extensions would
also benefit from it, and old code doesn't get affected to it.
--
versions: +Python 3.1 -
Guilherme Polo added the comment:
Commited in r69217 (r69219), r69220, r69222, r69223
Martin, I will open another ticket about GlobalCall deprecation, later
today.
--
resolution: accepted -> fixed
status: open -> closed
___
Python tracker
Guilherme Polo added the comment:
It is much more important to fix the memory leak anyway, it is possible
to notice real problems using test_tkleak1.py and watching the process
with ps or something else provided by the platform. Besides, not calling
ConditionFinalize doesn't introduce m
Guilherme Polo added the comment:
>> Besides, not calling ConditionFinalize doesn't introduce memory leaks
>
> Are you sure about this? On Unix, TclpFinalizeCondition does
>
>pthread_cond_destroy(pcondPtr);
>ckfree((char *) pcondPtr);
>
> bo
New submission from Guilherme Polo :
Hi, I'm going to try explaining in short why I think each of these
functions in _tkinter could be marked as deprecated and then removed on
2.8 (if it is decided to do it) and 3.1.
globalcall: It is not used anywhere in tkinter. It was abandoned, and
do
Guilherme Polo added the comment:
Can you tell what:
print(tkinter.Tcl().tk.call('info', 'patchlevel'))
prints ? Specifically to know which tk 8.5.x has the problem.
___
Python tracker
<http://bu
Guilherme Polo added the comment:
> That's not really a meaningful difference, though.. if the application
> uses this code continuously then the conditions will pile up in memory
> until it fills up.
I'm not trying to discourage you to do the complete fix (for these two
New submission from Guilherme Polo :
Hi,
It seems to me that it would be useful to add something to indicate
which packages should be loaded, and how they should be loaded, when a
Tcl interpreter is created through Tkinter.Tk. Right now every extension
has to add some boilerplate code to load a
Guilherme Polo added the comment:
Attaching patch to show how ttk.py would be with this new module.
Added file: http://bugs.python.org/file12948/ttk_withdeploader.diff
___
Python tracker
<http://bugs.python.org/issue5
Guilherme Polo added the comment:
Eric, I noticed you said Fedora 6, so I checked which tcl/tk it
includes and apparently it is 8.4.13, is that correct ?
I tried using tcl/tk 8.4.13 and I managed to hang it too :)
Try running test_tcl followed by test_ttk_guionly with regrtest
Guilherme Polo added the comment:
> When I run "./python Lib/test/regrtest.py test_tcl test_ttk_guionly", it
> hangs.
I have isolated it now:
Traceback (most recent call last):
File "", line 1, in
File "/home/gpolo/python-dev/python-trunk/Lib/lib-tk/Tk
Guilherme Polo added the comment:
After "I have isolated it now:", there should be this interactive
session (but gmail ate it apparently):
>>> import os
>>> del os.environ['DISPLAY']
>>> import Tkinter
>>> t = Tkinter.Tcl()
>>> t
Guilherme Polo added the comment:
Ok, I've found the cause of the problem and the patch attached should
solve it but shouldn't be applied! This was just a quick fix I did to
confirm what I expected, I will add something more correct later.
_tkinter is aware of this deadlock that we a
Guilherme Polo added the comment:
Here is a better patch, for some definition of better.
It syncs the failed attempt to load tk that may occur in
_tkinter.Tkapp_TkInit, _tkinter.Tcl_AppInit and tkappinit.Tcl_AppInit.
And that is done only for tk < 8.4.14 now.
Said that, I'm a bit
Guilherme Polo added the comment:
Any chance you can look at the proposed patch, Martin ? I found out that
it was you who reported this deadlock back then, so you might want to
review the patch.
--
nosy: +loewis
___
Python tracker
<h
Guilherme Polo added the comment:
Found a place still out of sync, it is fixed on this new patch. To
reproduce the problem with the previous patch try this:
import os
del os.environ['DISPLAY']
import Tkinter
Tkinter.Tk()
Tkinter.Tcl().loadtk() # should hang now (with a proper
Guilherme Polo added the comment:
> Eric Smith added the comment:
> .
> .
> Which I assume is the expected behavior.
Yes it is expected.
>
> Also with the third patch installed, the regrtest's all pass.
>
Very nice.
And Eric, thanks for the patienc
Guilherme Polo added the comment:
Committed now.
trunk: r69376, r69377
release26-maint: r69378
py3k: r69380
release30-maint: r69381 (hand-merged, as you may notice I forgot to
split the patch in two again in py3k)
--
resolution: -> fixed
status: open ->
Guilherme Polo added the comment:
Another way to reproduce it (tested using debug build):
Python 2.7a0 (trunk:69375:69376M, Feb 6 2009, 20:27:09)
[GCC 4.3.2] on linux2
Type "help", "copyright", "credits" or "license" for more information.
>>>
Guilherme Polo added the comment:
A bit cleaner patch.
Added file: http://bugs.python.org/file12971/protect_tk_loading.diff
___
Python tracker
<http://bugs.python.org/issue5
Changes by Guilherme Polo :
Removed file:
http://bugs.python.org/file12960/checking_for_failed_tk_load-2.diff
___
Python tracker
<http://bugs.python.org/issue5
Changes by Guilherme Polo :
Removed file: http://bugs.python.org/file12958/checking_for_failed_tk_load.diff
___
Python tracker
<http://bugs.python.org/issue5122>
___
___
Guilherme Polo added the comment:
This is a duplicate, see issue1028.
--
nosy: +gpolo
resolution: -> duplicate
status: open -> closed
___
Python tracker
<http://bugs.python.org/
Changes by Guilherme Polo :
--
assignee: -> gpolo
___
Python tracker
<http://bugs.python.org/issue4890>
___
___
Python-bugs-list mailing list
Unsubscri
Guilherme Polo added the comment:
Fixed on r69461, r69462, r69463 and r69464, thanks.
Will be adding tests for Tkinter.Text.search for trunk and py3k only.
--
resolution: -> fixed
status: open -> closed
___
Python tracker
<http://bugs.p
New submission from Guilherme Polo :
Tkinter.Text.search is supposed to return a string, but this is not
always true. The problem is much more likely to be noticed while using
Tk 8.5.
--
components: Tkinter
files: ensure_search_returns_str.diff
keywords: patch
messages: 81465
nosy
Guilherme Polo added the comment:
The abort still happens occasionally, see:
http://www.python.org/dev/buildbot/all/OS%20X%20x86%20trunk/builds/118/step-test/0
(last lines)
I've talked with Daniel Steffen, who is one of the maintainers of Tcl/Tk
on Mac OSX, and I was told that all
Guilherme Polo added the comment:
I've added some tests for it on r69467 now.
___
Python tracker
<http://bugs.python.org/issue4890>
___
___
Python-bugs-list m
Guilherme Polo added the comment:
Thanks Eric, committed in r69473.
--
resolution: -> fixed
status: open -> closed
___
Python tracker
<http://bugs.python.org/
Guilherme Polo added the comment:
Thanks for remembering, Daniel.
Closing as noted above.
--
resolution: -> out of date
status: open -> closed
superseder: -> Remove dead code from Tkinter.py
___
Python tracker
<http://bugs.python.org
Changes by Guilherme Polo :
--
keywords: +patch
Added file: http://bugs.python.org/file13000/oldtkaqua.diff
___
Python tracker
<http://bugs.python.org/issue5
Guilherme Polo added the comment:
Wouldn't it be better if you only ignored the 'illegal seek' error
instead of ignoring any ioerror (should it even be always discarded) ? I
get a 'bad file descriptor' under Windows 7, but, again, can it be
always discarded ?
Y
Guilherme Polo added the comment:
I see what you want to do, but I fell really uncomfortable by totally
ignoring IOError. I could get a bad file descriptor under Linux too, and
I wouldn't like to see it discarded for no reason.
Now, is there some problem if we remove the calls to the
New submission from Guilherme Polo :
I guess this happened due to the transition from rsplit to rindex.
--
assignee: brett.cannon
components: Library (Lib)
files: _resolve_name_rindex.diff
keywords: easy, patch
messages: 81621
nosy: brett.cannon, gpolo
severity: normal
status: open
New submission from Guilherme Polo :
Hi,
I find it weird that given this sample code:
def g():
yield iter(None)
list(*g())
I get this traceback:
Traceback (most recent call last):
File "a1.py", line 3, in
list(*g())
TypeError: type object argument after * must be a seq
Changes by Guilherme Polo :
--
components: +Interpreter Core
type: -> behavior
versions: +Python 2.7, Python 3.1
___
Python tracker
<http://bugs.python.org/iss
Guilherme Polo added the comment:
(Btw, the suggestion to check for tp_iter came from Antoine Pitrou. It
seemed fine to me.)
___
Python tracker
<http://bugs.python.org/issue5
Guilherme Polo added the comment:
Thanks for taking a look, my bad for taking so long to reply.
I'm adding a new patch now. This one, besides the fix needed mentioned
above, disregards tp_iter from old class instances (since they are
always available and tell us nothing).
Added file:
Guilherme Polo added the comment:
Nice.
I said tests in hope wave gets more tests, since right one there is a
single one. I will see if I can produce something.
___
Python tracker
<http://bugs.python.org/issue5
Guilherme Polo added the comment:
agreed. most platforms should be using the openssl version, i will
update the non-openssl implementations to behave the same.
I don't think this is worth being a release blocker. I'll do it for 3.0.1.
--
nosy: +grego
Changes by Guilherme Polo :
___
Python tracker
<http://bugs.python.org/issue3833>
___
___
Python-bugs-list mailing list
Unsubscribe:
http://mail.python.org/mailman/o
Changes by Guilherme Polo :
___
Python tracker
<http://bugs.python.org/issue3833>
___
___
Python-bugs-list mailing list
Unsubscribe:
http://mail.python.org/mailman/o
Changes by Guilherme Polo :
--
nosy: -gregory.p.smith
___
Python tracker
<http://bugs.python.org/issue3833>
___
___
Python-bugs-list mailing list
Unsubscribe:
Guilherme Polo added the comment:
Why close ? It is still a valid feature request (with no patch yet).
--
nosy: +gpolo
___
Python tracker
<http://bugs.python.org/issue539
Changes by Guilherme Polo :
Removed file:
http://bugs.python.org/file13035/check_tpiter_before_overriding_msg.diff
___
Python tracker
<http://bugs.python.org/issue5
Guilherme Polo added the comment:
It is a well known fact that the readprofile function uses exec, and it has
been like that for more than 18 years. The parameters baseName and className
defines the execution of the files $HOME/.{className}.tcl,
$HOME/.{className}.py, $HOME/.{baseName}.tcl
Guilherme Polo added the comment:
For something that has been around for so long, I would be a little more
careful.
My suggestion is: no longer declare readprofile as an internal function; remove
the direct call to readprofile from Tk.__init__; tell users about the new
behavior, and the need
Guilherme Polo added the comment:
I can ignore it, but let us be honest. If you got sudo privilege already, why
are you bothering to break (or whatever else) the system using IDLE ? The issue
here did not give you the sudo privilege. If it did, then we have an actual
security bug
Guilherme Polo added the comment:
It is not IDLE specific. But I still fail to see how this actually is a
security bug. It doesn't give more power to the user than the user already
gave to it. If you are recklessly installing untrusted libraries or
anything for the matter, then you already
Guilherme Polo added the comment:
Please include a short version of the widget class you mentioned. It must be
only long enough to show the issue.
--
___
Python tracker
<http://bugs.python.org/issue15
Guilherme Polo added the comment:
If doing list(kw.items()) works, I'm fine with that. If it does not, then
ttk._format_optdict(kw) should.
--
___
Python tracker
<http://bugs.python.org/is
Guilherme Polo added the comment:
Calm down for a moment. This is just incorrect usage of Entry. There is no
"text" parameter documented for this class (see its docstring, for a quick
reference on that). Also, there is a lot of Tkinter documentation, the official
one at can be foun
Guilherme Polo added the comment:
I consider myself the main responsible for this bug, so if the current patch
(which I didn't look at) passes all tests, doesn't slow things up (unlikely, I
would think) and also works with some more involved styling code then I'm fine
Guilherme Polo added the comment:
Hi Mark,
I don't think I remember very well where those element options are used.
For instance, where can you use the 'embossed' option ? Would it be only
when using style.configure/style.map with '.' as the style name ?
Knowing that
Guilherme Polo added the comment:
Closing. I have seen the code changes regarding idle and mac and I
believe this issue has been fixed (some time after the OP started this,
but it has).
--
resolution: -> out of date
status: open ->
Guilherme Polo added the comment:
This seems to be problematic in general. I have worked on a patch now,
but it fails to succeed while pasting multiple lines. The problem is
that when a second line is pasted, IDLE is still marked as "executing"
so it ends up just pasting the li
Guilherme Polo added the comment:
btw, I just added a patch for issue3559 which could be easily adjusted
to work as described in this issue.
--
___
Python tracker
<http://bugs.python.org/issue5
Guilherme Polo added the comment:
I'm attaching a very similar patch that I tested on Linux and Windows.
It just combines the default behaviour with the details required for
Windows, that is, the default extension is set to '.py' for Windows and
'' elsewhere (the de
Guilherme Polo added the comment:
I have reviewed the latest patch now, it is nice in general but I
dislike the idea of increasing even more EditorWindow. I would really
prefer to put this somewhere else, like.. idlelib/dialogs.py. Also, I'm
inclined to remove this master/parent hidin
Guilherme Polo added the comment:
I thought the main point of this issue was to define standard functions,
methods, classes (or something in that sense), in order to make the
creation of tk dialogs uniform across IDLE.
Right now it seems reasonable to keep the parent hidden, but I think it
may
Guilherme Polo added the comment:
I can't seem to reproduce that, maybe it could be a tk issue ?
Can you try writing anything (that doesn't work on IDLE) on a
tkinter.Text widget to see if it shows there ? You could use this code
below:
from tkinter import Text
text = Te
Guilherme Polo added the comment:
Amaury, from what I remember your suggestion has been applied some time
ago. Can you check if the newest Windows installer still adds an '-n' by
default ?
--
___
Python tracker
<http://bugs.python.
Guilherme Polo added the comment:
This looks good Scott, I'm just attaching the .diff here with real minor
changes and will be applying if no one is against it.
--
keywords: +patch
Added file: http://bugs.python.org/file14638/idle_fixwarnings
Guilherme Polo added the comment:
Closing this in favour of issue1721083.
--
resolution: -> duplicate
status: open -> closed
superseder: -> Add File - Reload
___
Python tracker
<http://bugs.python.org/
Guilherme Polo added the comment:
I have done a very initial patch in an attempt to define where we should
go with this feature. There are several different proposals around this
issue and the superseded one, I opted to implement the simplest one
which is to add a 'Revert' entry i
Guilherme Polo added the comment:
This is a tk issue, so the best way to fix this (if you don't want to
install something newer than Python 2.4 on Windows) is to install a
newer tcl/tk version.
Unfortunately the proposed workaround is way too specific, imagine if
other bindings had si
Guilherme Polo added the comment:
Hi Don,
I don't think this is an issue about idle competing for tkinter
resources (or idle and tkinter competing for resources -- the other
meaning I got when reading your message).
>From what I remember this WSAEWOULDBLOCK is just a way for Windows
Changes by Guilherme Polo :
--
nosy: +gpolo
___
Python tracker
<http://bugs.python.org/issue5712>
___
___
Python-bugs-list mailing list
Unsubscribe:
Guilherme Polo added the comment:
Richard, IDLE doesn't support browsing the history of the commands
entered (see issue2704), so I believe this is not related to IDLE and I
believe you meant to talk about the standard python shell.
Since you have compiled python yourself it is possible
Guilherme Polo added the comment:
Interesting, this is reproducible in any version under any OS but it is
more noticeable under Windows. In the step 6 you mentioned, IDLE is busy
printing warnings that you will never see if you don't run IDLE from a
terminal. Also, when you tried resta
Changes by Guilherme Polo :
--
versions: +Python 2.6, Python 2.7
___
Python tracker
<http://bugs.python.org/issue4765>
___
___
Python-bugs-list mailing list
Unsub
Guilherme Polo added the comment:
> With this new patch, is it possible to create a file without extension
> on Windows?
It is tricky but, answering your question, you could enter a name
ending with a period to save without an extension.
It seems this isn't going anywhere then.
Guilherme Polo added the comment:
> With 2.6.2 on Windows, I get filenames surrounded by {}, all in a
> single unicode string.
This string surrounded by { } indicates it is supposed to be a tcl
list, which didn't get converted but should be done by tkFileDialog.
> The change may
Guilherme Polo added the comment:
> AFAIK, WSAEWOULDBLOCK means that the socket is in nonblocking mode and
> the attempted operation could wait indefinitely to complete.
Rather pessimistic way to see it :) I've always read it as "operation
cannot be completed without blo
New submission from Guilherme Polo :
SocketIO.exithook on idlelib/rpc.py is missing the exit status, this is
a minor issue since both client and server used on IDLE override this
method to do something else.
--
components: IDLE
files: missing_exitstatus.diff
keywords: patch
messages
Guilherme Polo added the comment:
I just tried writing tests for it, but I don't know idlelib/rpc.py
enough yet. You can see this first attempt at:
http://svn.python.org/view?view=rev&revision=74320
I started trying to test rpc.RPCClient together with run.main but it
seemed too h
Changes by Guilherme Polo :
--
resolution: -> out of date
status: open -> closed
___
Python tracker
<http://bugs.python.org/issue3600>
___
___
Python-bugs-
Guilherme Polo added the comment:
This isn't going to happen, closing.
--
resolution: -> wont fix
status: open -> closed
___
Python tracker
<http://bugs.python
Guilherme Polo added the comment:
I've looked into this again and now I'm attaching a patch very similar
to xview_yview.patch. Is anyone against adding these mixins ?
--
Added file: http://bugs.python.org/file14673/xview_yview_mixins.diff
Guilherme Polo added the comment:
Attaching a patch against trunk, I believe this solves the problems
described here.
--
versions: +Python 2.6, Python 2.7
Added file: http://bugs.python.org/file14674/issue1028.diff
___
Python tracker
<h
Guilherme Polo added the comment:
>From what I read here this is not a problem caused by the sources
distributed by python.org, so I'm closing this. It seems more
appropriate to move this to Ubuntu's bug tracker.
--
nosy: +gpolo
resolution: -> invalid
status
Guilherme Polo added the comment:
Uhm, in the long run I believe it will be better to move to
Tcl_CreateObjCommand since it is said that commands created by it are
significantly faster than the ones created by Tcl_CreateCommand (more
information about this can be found at tcl documentation
Guilherme Polo added the comment:
I notice this some time ago, let's continue this on issue5120. Can you
test the patch attached there on a mac ? I don't have one, so I'm not
sure if it fixes the issue or not.
--
resolution: -> duplicate
stat
Guilherme Polo added the comment:
Today I noticed the StringObj manpage (from tcl) says that the bytes
that represent an tcl object should be treated as read-only (although it
uses char *) so this issue1028.diff may very well cause a segfault at
some point.
I'm attaching a new patch that
Guilherme Polo added the comment:
What do you think about adding a third element for each tuple in
rmenu_specs ? This new element would be a string determining the name of
a function that would be called to define the state of each entry in the
right menu. If None is used in place of a string
Guilherme Polo added the comment:
> 2) display assigned hot keys in popup menu
Is that really necessary ? I've looked for that on some applications I
use most and none of them include hot keys in right menus.
--
___
Python tracke
Guilherme Polo added the comment:
The attached patch adds support for nested objects in pyclbr and also in
ClassBrowser.
I have yet to find an optimal way to test this on test_pyclbr (I did
some things here, none very nice), so you will notice tests are missing
on this patch
New submission from Guilherme Polo :
I have worked on a patch for adding support for nested classes and
nested functions in pyclbr. I believe this might be useful for some
applications, and also for issue1612262.
The patch attached also contains a test and updated documentation
Changes by Guilherme Polo :
Removed file: http://bugs.python.org/file14703/pyclbr_nested_objects.diff
___
Python tracker
<http://bugs.python.org/issue6691>
___
___
Pytho
Changes by Guilherme Polo :
--
dependencies: +Support for nested classes and function for pyclbr
Added file: http://bugs.python.org/file14704/classbrowser_nesting_support.diff
___
Python tracker
<http://bugs.python.org/issue6
Changes by Guilherme Polo :
Removed file: http://bugs.python.org/file14704/classbrowser_nesting_support.diff
___
Python tracker
<http://bugs.python.org/issue6691>
___
___
Changes by Guilherme Polo :
--
dependencies: -Support for nested classes and function for pyclbr
Added file: http://bugs.python.org/file14705/pyclbr_nested_objects.diff
___
Python tracker
<http://bugs.python.org/issue6
Guilherme Polo added the comment:
I've removed the previous patch from here and attached an updated one on
issue6691.
Now the patch attached here only contains changes related to
idlelib.ClassBrowser.
--
dependencies: +Support for nested classes and function for pyclbr
Added
Changes by Guilherme Polo :
Removed file: http://bugs.python.org/file14699/show_nested_objects.diff
___
Python tracker
<http://bugs.python.org/issue1612262>
___
___
Pytho
Changes by Guilherme Polo :
--
superseder: -> Idle hangs when given a nonexistent filename.
___
Python tracker
<http://bugs.python.org/issue3573>
___
___
Py
Changes by Guilherme Polo :
--
superseder: Idle hangs when given a nonexistent filename. ->
___
Python tracker
<http://bugs.python.org/issue3573>
___
___
Py
Guilherme Polo added the comment:
Closing this in favour of issue 3573.
--
resolution: -> duplicate
status: open -> closed
superseder: -> IDLE hangs when passing invalid command line args
(directory(ies) instead of file(s))
___
Pytho
Guilherme Polo added the comment:
This has been closed but why not promote reindent.py to a module and add
an option on IDLE to allow a complete reindent.py run ?
--
___
Python tracker
<http://bugs.python.org/issue5
New submission from Guilherme Polo :
If someone configure IDLE to start a edit window by default, I believe
it should open only an edit window without starting shell window. This
has been the behaviour in previous version, but it is acting different now.
I looked into r71126 and I think this
401 - 500 of 659 matches
Mail list logo
