[issue2444] Adding __iter__ to class Values of module optparse

2008-03-23 Thread Guilherme Polo
Guilherme Polo <[EMAIL PROTECTED]> added the comment: I consider iterating over opts to be nicer and more pythonic than using vars(opts), since the latter is just a mask over the ugly opts.__dict__ __ Tracker <[EMAIL PROTECTED]> <http://bugs.pytho

[issue2444] Adding __iter__ to class Values of module optparse

2008-03-23 Thread Guilherme Polo
Guilherme Polo <[EMAIL PROTECTED]> added the comment: There is another reason for considering __iter__ as a more pythonic solution here. If you print opts, it may lead you to believe that it is just a regular dict, while it is not. If you were just able to iterate over it, I think it wo

[issue2489] Patch for bugs in pty.py

2008-03-25 Thread Guilherme Polo
Guilherme Polo <[EMAIL PROTECTED]> added the comment: Hi Fergus, I would suggest using "if not data" to check for EOF -- nosy: +gpolo __ Tracker <[EMAIL PROTECTED]> <http://

[issue2406] Improvement suggestions for the gzip module documentation

2008-03-27 Thread Guilherme Polo
Guilherme Polo <[EMAIL PROTECTED]> added the comment: Hello, (some comments) What about using gzip.open instead of GzipFile ? It is just a shorthand, but I prefer it (just my opinion). Also, remove those semicolons. At the second example you called close on the string object, I gue

[issue2406] Improvement suggestions for the gzip module documentation

2008-03-27 Thread Guilherme Polo
Guilherme Polo <[EMAIL PROTECTED]> added the comment: If I could I would commit it, but you have my support on this one nevertheless ;) __ Tracker <[EMAIL PROTECTED]> <http://bugs.pytho

[issue2444] Adding __iter__ to class Values of module optparse

2008-04-02 Thread Guilherme Polo
Guilherme Polo <[EMAIL PROTECTED]> added the comment: I have asked that myself, shawnmore. Why not let Value subclass dict ? __ Tracker <[EMAIL PROTECTED]> <http://bugs.pytho

[issue2444] Adding __iter__ to class Values of module optparse

2008-04-02 Thread Guilherme Polo
Guilherme Polo <[EMAIL PROTECTED]> added the comment: Given the disagreement found here, I suggest closing this rfe and moving further discussions to c.l.p. Thanks djc and rhettinger for your support, and, bethard and shawnmorel for your different

[issue2455] stat.ST_CTIME and stat.ST_ATIME problem

2008-04-03 Thread Guilherme Polo
Guilherme Polo <[EMAIL PROTECTED]> added the comment: Not here, ST_CTIME is 9 and ST_ATIME is 7, both are the correct indices at the tuple returned by os.stat. Could you recheck that and then and include some output (if it is really incorrect) ? -- nosy:

[issue799428] tk_focusNext() fails

2008-04-04 Thread Guilherme Polo
Guilherme Polo <[EMAIL PROTECTED]> added the comment: While we are at it, can't we revamp nametowidget too ? Patch attached -- nosy: +gpolo Added file: http://bugs.python.org/file9938/bugfix_and_revamp_nametowidget.diff Tracker <[E

[issue802310] tkFont may reuse font names

2008-04-04 Thread Guilherme Polo
Guilherme Polo <[EMAIL PROTECTED]> added the comment: This still happens, but around 2000 iterations here on newer Python versions (trunk, 3alpha, 2.5.x, 2.4.x). Using Python 1.6 I've got it at 2 iterations (min), but.. is this going to be fixed or given the amount of iterations need

[issue869780] curselection() in Tkinter.py should return ints

2008-04-04 Thread Guilherme Polo
Guilherme Polo <[EMAIL PROTECTED]> added the comment: Indeed, it should call self._getints, not sure why it was never done. Fixing this gives curselection the correct behavior according to the Tk Reference Manual: http://tmml.sourceforge.net/doc/tk/listbox.html -- nosy:

[issue1164742] Tkdnd.py crashes due to read-only attributes

2008-04-05 Thread Guilherme Polo
Guilherme Polo <[EMAIL PROTECTED]> added the comment: This was fixed on rev 39219 (2 years and 8 months ago) This surely could be closed by now. -- nosy: +gpolo _ Tracker <[EMAIL PROTECTED]> <http://bugs.python.o

[issue2558] Document pickle protocol 3

2008-04-05 Thread Guilherme Polo
Guilherme Polo <[EMAIL PROTECTED]> added the comment: There. -- nosy: +gpolo Added file: http://bugs.python.org/file9950/pickle_protocol3.rst __ Tracker <[EMAIL PROTECTED]> <http://bugs.pytho

[issue2558] Document pickle protocol 3

2008-04-05 Thread Guilherme Polo
Changes by Guilherme Polo <[EMAIL PROTECTED]>: Removed file: http://bugs.python.org/file9950/pickle_protocol3.rst __ Tracker <[EMAIL PROTECTED]> <http://bugs.pytho

[issue2558] Document pickle protocol 3

2008-04-05 Thread Guilherme Polo
Guilherme Polo <[EMAIL PROTECTED]> added the comment: Sent wrong file before, this is the correct one. -- keywords: +patch Added file: http://bugs.python.org/file9951/pickle_protocol3.rst.diff __ Tracker <[EMAIL PROTECTED]> <http://

[issue2240] setitimer, getitimer wrapper

2008-04-05 Thread Guilherme Polo
Guilherme Polo <[EMAIL PROTECTED]> added the comment: I'm investigating the problem loewis, thanks for reporting. But it would be better if someone with running FreeBSD could help me there, in case I find the cause for this. Also some changes were made to the original patch: neal.no

[issue2240] setitimer, getitimer wrapper

2008-04-05 Thread Guilherme Polo
Guilherme Polo <[EMAIL PROTECTED]> added the comment: FreeBSD's man page for setitimer/getitimer doesn't look different from the one in Linux. But.. both tests assumes the computer is not so fast that it finishes "for i in xrange(1)" before the timer expire, ma

[issue2240] setitimer, getitimer wrapper

2008-04-07 Thread Guilherme Polo
Guilherme Polo <[EMAIL PROTECTED]> added the comment: Trent Nelson kindly gave me access to his FreeBSD 6.2 buildbot so I had chance to do some tests. The problem happens when Python is built against or libc_r, or if you are using libmap you won't need to recompile but the problem st

[issue2577] cmd.py should track input file objects so macros with submacros can be easily written

2008-04-07 Thread Guilherme Polo
Guilherme Polo <[EMAIL PROTECTED]> added the comment: You should include a diff, not the entire file with your changes -- nosy: +gpolo __ Tracker <[EMAIL PROTECTED]> <http://bugs.pytho

[issue2564] Python hangs on FreeBSD7 in test_capi

2008-04-08 Thread Guilherme Polo
Guilherme Polo <[EMAIL PROTECTED]> added the comment: Hi Trent, FreeBSD 7 uses libthr as default, which would possibly eliminate this problem. -- nosy: +gpolo __ Tracker <[EMAIL PROTECTED]> <http://bugs.pytho

[issue2585] urllib2.HTTPError broken due to urllib.addinfourl changes

2008-04-09 Thread Guilherme Polo
Guilherme Polo <[EMAIL PROTECTED]> added the comment: It seems the fix is just passing code to addinfourl __init__, not sure if someone forgot this or this is just totally wrong. Patch added. -- keywords: +patch nosy: +gpolo Added file: http://bugs.python.org/file9992/urllib2_258

[issue2606] trace module crashes due to using wrong sort idiom

2008-04-10 Thread Guilherme Polo
Guilherme Polo <[EMAIL PROTECTED]> added the comment: I've changed them to sorted(obj.keys()) -- keywords: +patch nosy: +gpolo Added file: http://bugs.python.org/file9996/issue_2606.diff __ Tracker <[EMAIL PROTECTED]> <http://bugs.

[issue2618] Tile module: Add support for themed widgets

2008-04-11 Thread Guilherme Polo
Guilherme Polo <[EMAIL PROTECTED]> added the comment: Is this complete ? I see several methods with just a pass, where the docstring says it returns a dict, for example. -- nosy: +gpolo __ Tracker <[EMAIL PROTECTED]> <http://bugs.pytho

[issue2240] setitimer, getitimer wrapper

2008-04-12 Thread Guilherme Polo
Changes by Guilherme Polo <[EMAIL PROTECTED]>: Removed file: http://bugs.python.org/file9611/py-itimer-0.1.2.tar.gz __ Tracker <[EMAIL PROTECTED]> <http://bugs.pytho

[issue2240] setitimer, getitimer wrapper

2008-04-12 Thread Guilherme Polo
Changes by Guilherme Polo <[EMAIL PROTECTED]>: Removed file: http://bugs.python.org/file9613/setitimer_getitimer_wrapper.diff __ Tracker <[EMAIL PROTECTED]> <http://bugs.pytho

[issue2240] setitimer, getitimer wrapper

2008-04-12 Thread Guilherme Polo
Changes by Guilherme Polo <[EMAIL PROTECTED]>: Removed file: http://bugs.python.org/file9615/setitimer_getitimer_wrapper_rename.diff __ Tracker <[EMAIL PROTECTED]> <http://bugs.pytho

[issue2240] setitimer, getitimer wrapper

2008-04-12 Thread Guilherme Polo
Changes by Guilherme Polo <[EMAIL PROTECTED]>: Removed file: http://bugs.python.org/file9619/setitimer_getitimer_wrapper_fixes.diff __ Tracker <[EMAIL PROTECTED]> <http://bugs.pytho

[issue2240] setitimer, getitimer wrapper

2008-04-12 Thread Guilherme Polo
Changes by Guilherme Polo <[EMAIL PROTECTED]>: Removed file: http://bugs.python.org/file9622/setitimer_getitimer_wrapper_doc_update.diff __ Tracker <[EMAIL PROTECTED]> <http://bugs.pytho

[issue2240] setitimer, getitimer wrapper

2008-04-12 Thread Guilherme Polo
Changes by Guilherme Polo <[EMAIL PROTECTED]>: Removed file: http://bugs.python.org/file9620/setitimer_getitimer_wrapper_doc.diff __ Tracker <[EMAIL PROTECTED]> <http://bugs.pytho

[issue2240] setitimer, getitimer wrapper

2008-04-12 Thread Guilherme Polo
Changes by Guilherme Polo <[EMAIL PROTECTED]>: Removed file: http://bugs.python.org/file9623/setitimer_getitimer_wrapper_test.diff __ Tracker <[EMAIL PROTECTED]> <http://bugs.pytho

[issue2622] Import errors in email.message.py

2008-04-12 Thread Guilherme Polo
Guilherme Polo <[EMAIL PROTECTED]> added the comment: You may not like the naming applied there, but surely it is not a import error. Can you actually manage to get an ImportError ? -- nosy: +gpolo __ Tracker <[EMAIL PROTECTED]> <http://

[issue2622] Import errors in email.message.py

2008-04-12 Thread Guilherme Polo
Guilherme Polo <[EMAIL PROTECTED]> added the comment: Can you send a sample code that reproduces that ? __ Tracker <[EMAIL PROTECTED]> <http://bugs.python.org/issue2622> __

[issue2638] tkSimpleDialog Window Flashing

2008-04-15 Thread Guilherme Polo
Guilherme Polo <[EMAIL PROTECTED]> added the comment: Isn't overrideredirect only used to enable/disable borders in the window ? Why doing this fix what you described ? Also, make a patch against python-trunk instead of sending the entire file. -- n

[issue1529142] Allowing multiple instances of IDLE with sub-processes

2008-04-16 Thread Guilherme Polo
Guilherme Polo <[EMAIL PROTECTED]> added the comment: Works fine for me, I just dislike that Port binding error message because it is a bit misleading. It says "IDLE can't bind any TCP/IP port, ..." which is not entirely true. --

[issue1529142] Allowing multiple instances of IDLE with sub-processes

2008-04-16 Thread Guilherme Polo
Guilherme Polo <[EMAIL PROTECTED]> added the comment: I tested under Linux (Ubuntu distro), Python trunk _ Tracker <[EMAIL PROTECTED]> <http://bugs.python.o

[issue799428] tk_focusNext() fails

2008-04-24 Thread Guilherme Polo
Changes by Guilherme Polo <[EMAIL PROTECTED]>: Removed file: http://bugs.python.org/file9938/bugfix_and_revamp_nametowidget.diff Tracker <[EMAIL PROTECTED]> <http://bugs.python.

[issue799428] tk_focusNext() fails

2008-04-24 Thread Guilherme Polo
Guilherme Polo <[EMAIL PROTECTED]> added the comment: There was a problem with my previous patch if the widget name was just '.' New patch attached Added file: http://bugs.python.org/file10087/bugfix_and_revamp_nametowidget.diff Tracker &

[issue799428] tk_focusNext() fails

2008-04-24 Thread Guilherme Polo
Changes by Guilherme Polo <[EMAIL PROTECTED]>: Removed file: http://bugs.python.org/file10087/bugfix_and_revamp_nametowidget.diff Tracker <[EMAIL PROTECTED]> <http://bugs.python.

[issue799428] tk_focusNext() fails

2008-04-24 Thread Guilherme Polo
Guilherme Polo <[EMAIL PROTECTED]> added the comment: Sorry for the previous patch, correct one attached now Added file: http://bugs.python.org/file10088/bugfix_and_revamp_nametowidget.diff Tracker <[EMAIL PROTECTED]> <http://bugs.python.

[issue2688] Error when nesting many while loops

2008-04-25 Thread Guilherme Polo
Guilherme Polo <[EMAIL PROTECTED]> added the comment: Apparently this was fixed at rev 52504 python-trunk. Which python version did you use ? -- nosy: +gpolo __ Tracker <[EMAIL PROTECTED]> <http://bugs.pytho

[issue2709] tk.rst possibly wrong ?

2008-04-28 Thread Guilherme Polo
New submission from Guilherme Polo <[EMAIL PROTECTED]>: tk.rst tells, among other things: "`Tkinter`'s chief virtues are that it is fast, and that it usually comes bundled with Python. Although it has been used to create some very good applications, including IDLE, it has we

[issue2805] 2to3 doesn't correct divisions

2008-05-09 Thread Guilherme Polo
New submission from Guilherme Polo <[EMAIL PROTECTED]>: Given the sample code: for i in range(len([1, 2]) / 2): pass print 2 / 3 2to3 tells no files need to be modified after running it over this code, but range doesn't accept float values and the print result will differ. Woul

[issue2805] 2to3 doesn't correct divisions

2008-05-09 Thread Guilherme Polo
Guilherme Polo <[EMAIL PROTECTED]> added the comment: If I were to add such fixer, should I wait for changes coming by gsoc projects ? I did a quick pass through 2to3 code a while ago, but I'm very far from understanding it in a good manner so I'm not sure if I should startin

[issue2535] duplicate Misc.lower

2008-05-10 Thread Guilherme Polo
Guilherme Polo <[EMAIL PROTECTED]> added the comment: It hasn't changed that much, but here is a patch against py3k branch rev 62992 -- nosy: +gpolo Added file: http://bugs.python.org/file10245/remove_lowerdup.patch __ Tracker <[EMAIL PRO

[issue869780] curselection() in Tkinter.py should return ints

2008-05-10 Thread Guilherme Polo
Guilherme Polo <[EMAIL PROTECTED]> added the comment: Not sure what you did, but calling _getints didn't raise an exception here neither returned an empty string if no item was selected, it returned None. Added file: http://bugs.python.org/file10249/curselection_tu

[issue869780] curselection() in Tkinter.py should return ints

2008-05-10 Thread Guilherme Polo
Guilherme Polo <[EMAIL PROTECTED]> added the comment: _getints already call splitlist, so there isn't much point in calling _getints after calling splitlist. And the Tk documentation says an empty string should be returned in case there is no selection, but that is Tk. I don't

[issue869780] curselection() in Tkinter.py should return ints

2008-05-10 Thread Guilherme Polo
Guilherme Polo <[EMAIL PROTECTED]> added the comment: Are you aware of any code checking against empty tuple specifically to verify that nothing is selected ? Tracker <[EMAIL PROTECTED]> <http://bugs.python.

[issue869780] curselection() in Tkinter.py should return ints

2008-05-10 Thread Guilherme Polo
Guilherme Polo <[EMAIL PROTECTED]> added the comment: I found some code using map(int, curselection..) directly, so this new patch fixes the problem related to returning None when nothing was selected. Added file: http://bugs.python.org/file10259/curselection_tuplein

[issue869780] curselection() in Tkinter.py should return ints

2008-05-10 Thread Guilherme Polo
Changes by Guilherme Polo <[EMAIL PROTECTED]>: Removed file: http://bugs.python.org/file10259/curselection_tupleint.diff Tracker <[EMAIL PROTECTED]> <http://bugs.python.

[issue869780] curselection() in Tkinter.py should return ints

2008-05-10 Thread Guilherme Polo
Changes by Guilherme Polo <[EMAIL PROTECTED]>: Removed file: http://bugs.python.org/file10249/curselection_tupleint.diff Tracker <[EMAIL PROTECTED]> <http://bugs.python.

[issue869780] curselection() in Tkinter.py should return ints

2008-05-10 Thread Guilherme Polo
Changes by Guilherme Polo <[EMAIL PROTECTED]>: Added file: http://bugs.python.org/file10260/curselection_tupleint.diff Tracker <[EMAIL PROTECTED]> <http://bugs.python.

[issue2709] tk.rst possibly wrong ?

2008-05-11 Thread Guilherme Polo
Guilherme Polo <[EMAIL PROTECTED]> added the comment: Hi again, Sorry for not trying harder on this issue, I should have included my own patch(es) on what should be changed. These could be improved tho, of course. Added file: http://bugs.python.org/file10283/tk.rs

[issue2709] tk.rst possibly wrong ?

2008-05-11 Thread Guilherme Polo
Changes by Guilherme Polo <[EMAIL PROTECTED]>: Added file: http://bugs.python.org/file10284/othergui.rst.diff __ Tracker <[EMAIL PROTECTED]> <http://bugs.pytho

[issue2775] Implement PEP 3108

2008-05-11 Thread Guilherme Polo
Guilherme Polo <[EMAIL PROTECTED]> added the comment: I'm working on the new package tkinter and dialogs merging where appropriate. -- nosy: +gpolo __ Tracker <[EMAIL PROTECTED]> <http://bugs.

[issue2775] Implement PEP 3108

2008-05-11 Thread Guilherme Polo
Guilherme Polo <[EMAIL PROTECTED]> added the comment: Patch regarding the move to tkinter package added. What this patch does * Moved lib-tk to tkinter and renamed modules according to PEP 3108 * Merged tkFileDialog into filedialog * Merged tkSimpleDialo

[issue2775] Implement PEP 3108

2008-05-11 Thread Guilherme Polo
Guilherme Polo <[EMAIL PROTECTED]> added the comment: New patch regarding the move to tkinter package, now with docs updated. This one should be the "final" patch, and while the patch is relatively large it mostly trivial to review. Added file: http://bugs.pyth

[issue2775] Implement PEP 3108

2008-05-11 Thread Guilherme Polo
Changes by Guilherme Polo <[EMAIL PROTECTED]>: Removed file: http://bugs.python.org/file10290/tkinter_package_and_fixes.diff __ Tracker <[EMAIL PROTECTED]> <http://bugs.pytho

[issue2835] Py30a5: webbrowser.open() inf recursion

2008-05-12 Thread Guilherme Polo
Guilherme Polo <[EMAIL PROTECTED]> added the comment: It doesn't happen here, I'm using Linux too (Ubuntu 8.04) and py3k rev 63074 -- nosy: +gpolo versions: +Python 2.6 -Python 3.0 __ Tracker <[EMAIL PROTECTED]> <http://

[issue2839] Moving lib-tk to tkinter package

2008-05-12 Thread Guilherme Polo
New submission from Guilherme Polo <[EMAIL PROTECTED]>: I'm moving lib-tk to a tkinter package, I've sent a patch for this which can be found at issue 2775 but I started wrong (did a patch against py3k directly). -- components: Library (Lib) messages: 66747 nosy: gpolo

[issue2775] Implement PEP 3108

2008-05-12 Thread Guilherme Polo
Changes by Guilherme Polo <[EMAIL PROTECTED]>: -- dependencies: +Moving lib-tk to tkinter package __ Tracker <[EMAIL PROTECTED]> <http://bugs.python.org/issue2775> __

[issue4187] IDLE will not start.

2008-10-23 Thread Guilherme Polo
Guilherme Polo <[EMAIL PROTECTED]> added the comment: Closing this in favor of issue4017. Check if anything there works for you, or add something new. -- nosy: +gpolo resolution: -> duplicate status: open -> closed ___ Python tra

[issue4188] Lib/threading.py causes infinite recursion when running as verbose

2008-10-23 Thread Guilherme Polo
New submission from Guilherme Polo <[EMAIL PROTECTED]>: Lib/threading.py gets into infinite recursion while testing (or using) it with verbose set. This didn't happen before because Thread.__started didn't use to be an Event, but now it is. Typical situation: _D

[issue639266] Tkinter sliently discards all Tcl errors

2008-10-24 Thread Guilherme Polo
Guilherme Polo <[EMAIL PROTECTED]> added the comment: Uhm, long time without discussion but I'm hoping someone interested may read this. You have to provide a "bgerror" command to Tcl, so it will get invoked when a background error happens. Either _tkinter.c could create o

[issue2983] Ttk support for Tkinter

2008-10-24 Thread Guilherme Polo
Guilherme Polo <[EMAIL PROTECTED]> added the comment: Now that the new branches are around I guess we could consider adding it then ? I will help with anything. ___ Python tracker <[EMAIL PROTECTED]> <http://bugs.pytho

[issue4223] inspect.getsource doesn't work on functions imported from a zipfile

2008-10-28 Thread Guilherme Polo
Guilherme Polo <[EMAIL PROTECTED]> added the comment: doesn't it ? it works here -- nosy: +gpolo ___ Python tracker <[EMAIL PROTECTED]> <http://bugs.

[issue4223] inspect.getsource doesn't work on functions imported from a zipfile

2008-10-28 Thread Guilherme Polo
Guilherme Polo <[EMAIL PROTECTED]> added the comment: Well anyway, some sample code: import zipfile z = zipfile.ZipFile('aaa.zip', mode='w') z.writestr('aa.py', 'def x(): print "hi there"\n\ndef y(): print "hi"') z.close()

[issue4333] Reworked Dialog.py

2008-11-16 Thread Guilherme Polo
New submission from Guilherme Polo <[EMAIL PROTECTED]>: Hi, I have changed the lib-tk/Dialog.py so it handles the cases where one might receive a tuple as a result containing a Tcl_Obj. I've also modified all the rest of it to make it "cleaner". It is b/w compatible a

[issue4342] (Tkinter) Please backport these

2008-11-17 Thread Guilherme Polo
New submission from Guilherme Polo <[EMAIL PROTECTED]>: Please consider backporting r59653 and r59654 to release25-maint branch. It may be of interest to backport r52688 too, also, r63776 together with r63914 (without these last two I get segfault when passing a list as an option

[issue3248] ScrolledText can't be placed in a PanedWindow

2008-11-17 Thread Guilherme Polo
Guilherme Polo <[EMAIL PROTECTED]> added the comment: anyone ? -- versions: +Python 2.5.3, Python 2.7, Python 3.0 ___ Python tracker <[EMAIL PROTECTED]> <http://bugs.pytho

[issue3248] ScrolledText can't be placed in a PanedWindow

2008-11-17 Thread Guilherme Polo
Guilherme Polo <[EMAIL PROTECTED]> added the comment: I've changed it a bit more now, this includes dropping support for cnf. My wish is to actually remove the cnf usage all over Tkinter :) Added file: http://bugs.python.org/file12037/Scroll

[issue4343] New function in Tkinter.py: setup_master

2008-11-18 Thread Guilherme Polo
New submission from Guilherme Polo <[EMAIL PROTECTED]>: Hi, I've added a new function called setup_master. This function is responsible for returning an usable master to the caller, or fail and say so. The function is useful for any wrapper basically, since all them has to set

[issue4343] New function in Tkinter.py: setup_master

2008-11-18 Thread Guilherme Polo
Changes by Guilherme Polo <[EMAIL PROTECTED]>: Added file: http://bugs.python.org/file12041/applying_setup_master.diff ___ Python tracker <[EMAIL PROTECTED]> <http://bugs.pytho

[issue4343] New function in Tkinter.py: setup_master

2008-11-18 Thread Guilherme Polo
Changes by Guilherme Polo <[EMAIL PROTECTED]>: Removed file: http://bugs.python.org/file12040/setup_master.diff ___ Python tracker <[EMAIL PROTECTED]> <http://bugs.pytho

[issue4343] New function in Tkinter.py: setup_master

2008-11-18 Thread Guilherme Polo
Changes by Guilherme Polo <[EMAIL PROTECTED]>: Added file: http://bugs.python.org/file12042/setup_master.diff ___ Python tracker <[EMAIL PROTECTED]> <http://bugs.pytho

[issue3767] tkColorChooser may fail if no color is selected

2008-11-18 Thread Guilherme Polo
Guilherme Polo <[EMAIL PROTECTED]> added the comment: I've noticed a problem with the previous patch, so this new one includes a comment too so people can remember about the check being applied. -- versions: +Python 2.5.3, Python 2.7 Added file: http://bugs.python.or

[issue4345] Implement nb_nonzero for PyTclObject

2008-11-18 Thread Guilherme Polo
New submission from Guilherme Polo <[EMAIL PROTECTED]>: Implementing it makes this "crazy" check in http://bugs.python.org/issue3767 (http://bugs.python.org/file12043/tkColorChooser.diff) be no longer needed -- components: Tkinter files: _tkinter__nonzero__.diff keywords

[issue4346] PyObject_CallMethod changes the exception message already set by PyObject_GetAttr

2008-11-18 Thread Guilherme Polo
New submission from Guilherme Polo <[EMAIL PROTECTED]>: Why is PyObject_CallMethod resetting the exception message that is already set (if an exception happened, that is) by PyObject_Getattr ? -- components: Interpreter Core files: abstract_dont_re_set_except_msg.diff keywords:

[issue4117] missing update() in _Screen.setup() of Lib/turtle.py

2008-11-18 Thread Guilherme Polo
Guilherme Polo <[EMAIL PROTECTED]> added the comment: Why are you using update instead of update_idletasks ? I'm not talking exactly about this line being added, but this ends up calling TurtleScreenBase._update which calls self.cv.update(), cv being a canvas. update_idletasks sho

[issue4350] Remove dead code from Tkinter.py

2008-11-18 Thread Guilherme Polo
New submission from Guilherme Polo <[EMAIL PROTECTED]>: There are some methods (which call tk commands) that no longer exist, for a long time now so this patch remove them. There are also these "indices" functions, which do not belong to the module space and now are gone too.

[issue1028] Tkinter binding involving Control-spacebar raises unicode error

2008-11-18 Thread Guilherme Polo
Guilherme Polo <[EMAIL PROTECTED]> added the comment: I can reproduce it here with tk8.4, using tk8.5 doesn't cause this. -- nosy: +gpolo ___ Python tracker <[EMAIL PROTECTED]> <http://bugs.

[issue1028] Tkinter binding involving Control-spacebar raises unicode error

2008-11-18 Thread Guilherme Polo
Guilherme Polo <[EMAIL PROTECTED]> added the comment: Here is a patch that doesn't use magic numbers :P I didn't hit the problem described in issue4313 with this one, and PythonCmd should be doing this anyway, but ideally we should move to Tcl_CreateObjCommand.

[issue1028] Tkinter binding involving Control-spacebar raises unicode error

2008-11-18 Thread Guilherme Polo
Changes by Guilherme Polo <[EMAIL PROTECTED]>: Removed file: http://bugs.python.org/file12053/PythonCmd_check_for_utf.diff ___ Python tracker <[EMAIL PROTECTED]> <http://bugs.pytho

[issue1028] Tkinter binding involving Control-spacebar raises unicode error

2008-11-18 Thread Guilherme Polo
Guilherme Polo <[EMAIL PROTECTED]> added the comment: Removed some repeated code in the patch Added file: http://bugs.python.org/file12054/PythonCmd_check_for_utf.diff ___ Python tracker <[EMAIL PROTECTED]> <http://bugs.pytho

[issue1028] Tkinter binding involving Control-spacebar raises unicode error

2008-11-19 Thread Guilherme Polo
Guilherme Polo <[EMAIL PROTECTED]> added the comment: tk 8.4.19 here, but windows and linux almost surely uses different window managers (you could run gnome and others under windows, but I'm betting it is not the case). Now, it is very hard to say that we shouldn't care abo

[issue1447222] tkinter Dialog fails when more than four buttons are used

2008-11-20 Thread Guilherme Polo
Guilherme Polo <[EMAIL PROTECTED]> added the comment: issue4333 fixes this too, btw ___ Python tracker <[EMAIL PROTECTED]> <http://bugs.python.org/issue1447222> ___

[issue1028] Tkinter binding involving Control-spacebar raises unicode error

2008-11-21 Thread Guilherme Polo
Guilherme Polo <[EMAIL PROTECTED]> added the comment: You are missing the point on using Tcl_CreateObjCommand, I didn't mean to just go and and do s/Tcl_CreateCommand/Tcl_CreateObjCommand/ because if you are going to convert everything to unicode then there is no poi

[issue1028] Tkinter binding involving Control-spacebar raises unicode error

2008-11-21 Thread Guilherme Polo
Guilherme Polo <[EMAIL PROTECTED]> added the comment: I'm sorry if it sounded like I were bashing you, I was just pointing out my view of the patch -- you didn't need to remove it. The patch I submitted here can also be improved (although it "works"), but I'm le

[issue1028] Tkinter binding involving Control-spacebar raises unicode error

2008-11-21 Thread Guilherme Polo
Guilherme Polo <[EMAIL PROTECTED]> added the comment: > Hirokazu Yamamoto added the comment: > >>You are missing the point on using Tcl_CreateObjCommand, I didn't mean >>to just go and and do s/Tcl_CreateCommand/Tcl_CreateObjCommand/ because >>if you are goi

[issue4406] In Lib\tkinter\filedialog.py, class Directory define loss a"_"

2008-11-24 Thread Guilherme Polo
Guilherme Polo <[EMAIL PROTECTED]> added the comment: Actually it should be commondialog.Dialog -- keywords: +patch nosy: +gpolo Added file: http://bugs.python.org/file12118/Directory_fix_subclass.diff ___ Python tracker <[EMAIL PROTECTE

[issue4406] In Lib\tkinter\filedialog.py, class Directory define loss a"_"

2008-11-24 Thread Guilherme Polo
Guilherme Polo <[EMAIL PROTECTED]> added the comment: It is important to commit this actually, since right now tkinter.filedialog.Directory is pretty broken but also very simple to fix. -- components: +Tkinter -Library (Lib) type: compile

[issue775309] button methods tkButtonDown, etc don't work

2008-11-24 Thread Guilherme Polo
Guilherme Polo <[EMAIL PROTECTED]> added the comment: There is a more general patch on issue4350 now ___ Python tracker <[EMAIL PROTECTED]> <http://bugs.python.

[issue1532] Refleak run of test_tcl fails

2008-11-24 Thread Guilherme Polo
Guilherme Polo <[EMAIL PROTECTED]> added the comment: Disable it while running regrtest with -R ? -- keywords: +patch nosy: +gpolo Added file: http://bugs.python.org/file12120/disable_testLoadTkFailure_in_regrtest.diff ___ Python tracker &

[issue1191726] about shift key

2008-11-24 Thread Guilherme Polo
Guilherme Polo <[EMAIL PROTECTED]> added the comment: I can reproduce this under windows vista with tk8.4 and tk8.5, but the problem doesn't show up in Linux and it is not tkinter fault either. -- nosy: +gpolo Added file: http://bugs.python.org/file12121/issu

[issue1191726] about shift key

2008-11-24 Thread Guilherme Polo
Changes by Guilherme Polo <[EMAIL PROTECTED]>: Added file: http://bugs.python.org/file12122/test1.tcl ___ Python tracker <[EMAIL PROTECTED]> <http://bugs.python.o

[issue1191726] about shift key

2008-11-24 Thread Guilherme Polo
Changes by Guilherme Polo <[EMAIL PROTECTED]>: -- resolution: -> wont fix status: open -> closed ___ Python tracker <[EMAIL PROTECTED]> <http://bugs.py

[issue4475] More verbose error message for Py_FindMethod

2008-11-30 Thread Guilherme Polo
New submission from Guilherme Polo <[EMAIL PROTECTED]>: As was told in http://mail.python.org/pipermail/python-dev/2008-November/083782.html some objects may print a not so nice message when an attribute is not found. I considered this was due to Py_FindMethod being so easy to use t

[issue4475] More verbose error message for Py_FindMethod

2008-11-30 Thread Guilherme Polo
Changes by Guilherme Polo <[EMAIL PROTECTED]>: -- versions: -Python 3.0, Python 3.1 ___ Python tracker <[EMAIL PROTECTED]> <http://bugs.pytho

[issue4475] More verbose error message for Py_FindMethod

2008-11-30 Thread Guilherme Polo
Guilherme Polo <[EMAIL PROTECTED]> added the comment: Yes, it was a mistake to set the version for py3k too, that is why I removed after noticing it. ___ Python tracker <[EMAIL PROTECTED]> <http://bugs.pytho

[issue1028] Tkinter binding involving Control-spacebar raises unicode error

2008-12-01 Thread Guilherme Polo
Guilherme Polo <[EMAIL PROTECTED]> added the comment: Some more clarifications about this bug: Tcl shouldn't be giving us a UTF-8 string with a 0xC0 byte, since that is not valid UTF-8. I'm aware that Tcl uses the sequence 0xC0 0x80 for special purposes but it is also said tha

[issue1028] Tkinter binding involving Control-spacebar raises unicode error

2008-12-03 Thread Guilherme Polo
Guilherme Polo <[EMAIL PROTECTED]> added the comment: I've been working on a new _tkinter (named it as "plumage") these days and I hit this same problem for trusting too much that nothing from tcl, including tk and extensions, would give me this embedded null. Checking

<    1   2   3   4   5   6   7   >