Guido van Rossum added the comment:
Cool. How hard do you think it would be to extend your work on
StringIO into a translation of TextIOWrapper into C?
On Nov 7, 2007 3:55 PM, Alexandre Vassalotti <[EMAIL PROTECTED]> wrote:
> On 11/7/07, Guido van Rossum <[EMAIL PROTECTED]> wro
Guido van Rossum added the comment:
No, I didn't write the parser module (which isn't the parser, just a
wrapper to make it accessible from Python).
--
assignee: gvanrossum -> fdrake
nosy: +fdrake
__
Tracker <[EMAIL PROTECTED]>
<
Guido van Rossum added the comment:
It's still odd though. Why does object() == Anything() pass control to
the right hand side, while (lambda: None) == Anything() doesn't?
There's no definition of equality in PyFunction_Type, so it would seem
to fall back on the definition in Py
Guido van Rossum added the comment:
FWIW, I'm +1 on the part of this patch that disables \u in raw strings.
I just had a problem with a doctest that couldn't be run in verbose mode
because \u was being interpreted in raw mode... But I'm still solidly
-1 on al
Guido van Rossum added the comment:
I wouldn't close this until it's fixed.
--
status: closed -> open
__
Tracker <[EMAIL PROTECTED]>
<http://bug
Guido van Rossum added the comment:
Do you have a patch? Then we could consider fixing this in 2.5.2.
--
nosy: +gvanrossum
__
Tracker <[EMAIL PROTECTED]>
<http://bugs.python.org/
Guido van Rossum added the comment:
> Considering that test_csv is failing on windows even without any changes
> related to this issue, I looked at it and came up with this patch:
>
> -
> Index: Lib/t
Guido van Rossum added the comment:
I don't think anything was accepted yet.
--
nosy: +gvanrossum
resolution: accepted ->
__
Tracker <[EMAIL PROTECTED]>
<http://bugs.pyt
Guido van Rossum added the comment:
Sorry, I still don't like it. You'll have to come up with a darned good
use case to justify this.
__
Tracker <[EMAIL PROTECTED]>
<http://bugs.p
Guido van Rossum added the comment:
I think I agree this is a bug.
Who is setting all bugs to 'accepted'?
--
nosy: +gvanrossum
resolution: accepted ->
__
Tracker <[EMAIL PROTECTED]>
<http://bug
Guido van Rossum added the comment:
Hm, I was hoping more for patches to the C code that would make these
initializations reentrant (e.g. by testing a flag in C that says "I'm
already initialized").
__
Tracker <[EMAIL PROTECTED]>
<http://b
Guido van Rossum added the comment:
Why is it still open?
--
nosy: +gvanrossum
__
Tracker <[EMAIL PROTECTED]>
<http://bugs.python.org/issue1403>
__
___
Python-bugs-
Guido van Rossum added the comment:
How do you know the memory isn't given back? It may be available for
reallocation within Python, just not given back to the operating system.
That's not necessarily a leak or a bug; that could just be heap
fragmentation. There's nothing you
Changes by Guido van Rossum:
--
resolution: -> invalid
status: open -> closed
__
Tracker <[EMAIL PROTECTED]>
<http://bugs.python.org/issue1410>
__
___
Python
Guido van Rossum added the comment:
To find out what really happens, use pdb to step through the example.
This gives much better insight than adding a printf() call to
PyObject_Call(). I've notice myself when stepping through I/O that there
are a lot of checks for closed -- this may have
New submission from Guido van Rossum:
Here's an implementation of the idea I floated recently on python-dev
(Subject: Declaring setters with getters). This implements the kind of
syntax that I believe won over most folks in the end:
@property
def foo(self): ...
@foo.setter
de
Changes by Guido van Rossum:
--
resolution: -> invalid
status: open -> closed
__
Tracker <[EMAIL PROTECTED]>
<http://bugs.python.org/issue1405>
__
___
Python
Guido van Rossum added the comment:
propset2.diff is a new version that improves upon the heuristic for
making the deleter match the setter: when changing setters, if the old
deleter is the same as the old setter, it will replace both the deleter
and setter.
This diff is relative to the 2.6
Guido van Rossum added the comment:
propset3.diff removes the hack that makes the deleter equal to the
setter when no separate deleter has been specified. If you want a
single method to be used as setter and deleter, write this:
@foo.setter
@foo.deleter
def foo(self, value=None): ...
Added
Guido van Rossum added the comment:
Checked into trunk as revision 58929.
--
resolution: -> accepted
status: open -> closed
__
Tracker <[EMAIL PROTECTED]>
<http://bugs.pytho
Guido van Rossum added the comment:
Hmm... In internal_close() there's still a test for self->fd >= 0. I'm
not sure if this is an oversight or intentional.
Also, I don't understand under what circumstances fds < 0 can occur. I
presume this is only on Windows. Can you p
Guido van Rossum added the comment:
I would use _x instead of __x. Otherwise looks good.
__
Tracker <[EMAIL PROTECTED]>
<http://bugs.python.org/issue1428>
__
___
Python-bugs-
Guido van Rossum added the comment:
BTW, what's the best way of reporting bugs in python.org?
--
nosy: +gvanrossum
__
Tracker <[EMAIL PROTECTED]>
<http://bugs.python
Guido van Rossum added the comment:
I don't think this is worth fixing; you'll get an I/O error as soon as
I/O is attempted, which is upon the first read() for input, or upon the
firsh (implicit or explicit) flush() on output. You can't tell whether
a fd is valid or not without
Guido van Rossum added the comment:
I'm with Martin. Adam, why do you think tokenize should use bytes
instead of text strings?
--
nosy: +gvanrossum
__
Tracker <[EMAIL PROTECTED]>
<http://bugs.python
Guido van Rossum added the comment:
What software do you use to play the sample? Is it perhaps ignoring the
nchannels value from the header?
--
nosy: +gvanrossum
__
Tracker <[EMAIL PROTECTED]>
<http://bugs.python.org/
Guido van Rossum added the comment:
Can't reproduce this (Ubuntu dapper). I get the expected output.
--
nosy: +gvanrossum
__
Tracker <[EMAIL PROTECTED]>
<http://bugs.python
Guido van Rossum added the comment:
Go for it!
--
nosy: +gvanrossum
priority: high -> normal
__
Tracker <[EMAIL PROTECTED]>
<http://bugs.python.org/issue1426>
__
Guido van Rossum added the comment:
BTW Bill, how's the 3.0 port of SSL going?
--
nosy: +gvanrossum
__
Tracker <[EMAIL PROTECTED]>
<http://bugs.python
Guido van Rossum added the comment:
Got it. Checked in as revision 58951.
--
resolution: -> accepted
status: open -> closed
__
Tracker <[EMAIL PROTECTED]>
<http://bugs.pytho
Guido van Rossum added the comment:
Please check in the frozen-related fixes.
Your changes to test_tcl break that test even when run without -R!
For test_pkg, I would rather see a fix that undoes all the changes to
sys.modules (note that it already restores sys.path and deletes the
files it
Guido van Rossum added the comment:
IMO you don't need the 'closed' flag and you should continue to test for
fd < 0. Whether it's -1 or -2, you still can't write to it...
__
Tracker <[EMAIL PROTECTED]>
Guido van Rossum added the comment:
If that makes the test pass with and without -R::, go for it!
On Nov 12, 2007 11:14 AM, Christian Heimes <[EMAIL PROTECTED]> wrote:
>
> Christian Heimes added the comment:
>
> How do you like;
>
> class TestPkg(unittest.TestCase)
Guido van Rossum added the comment:
Fixed in 2.5 branch (to be released with 2.5.2). Unit test added to 2.6
(trunk).
--
resolution: -> accepted
status: open -> closed
_
Tracker <[EMAIL PROTECTED]>
<http://bugs.python.o
Guido van Rossum added the comment:
I don't understand. When does the difference matter?
On Nov 12, 2007 10:14 AM, Christian Heimes <[EMAIL PROTECTED]> wrote:
>
> Christian Heimes added the comment:
>
> W/o the closed flag it's impossible to distinguish betwee
Guido van Rossum added the comment:
> > I don't understand. When does the difference matter?
>
> When the check for fd < 0 is removed from fileio_init() there is no way
> to tell if fd < 0 means fd closed or invalid fd.
I still don't understand. Why do you need
Guido van Rossum added the comment:
> I don't want to treat the fd differently. I want to return a sensible
> error message that is different from "file closed" when the fd is invalid.
Doesn't sound too important. Anyway, from which call do you want to
issue different
Guido van Rossum added the comment:
Good work indeed!
Here's another way:
>>> class C:
... @property
... def __class__(self): return D
...
>>> class D: pass
...
>>> C().__class__
>>>
__
Tracker <[EMAIL P
Guido van Rossum added the comment:
BTW: if you can show (e.g. with your unittest) that this indeed breaks
in 2.6 and 2.5, please do backport it.
BTW**2: I've noticed that abc.py's __instancecheck__ gets called a lot
at times when I don't expect it. Can you rese
Guido van Rossum added the comment:
PPSS. When backporting, a note in Misc/NEWS is appreciated.
__
Tracker <[EMAIL PROTECTED]>
<http://bugs.python.org/issue1265>
__
___
Pyth
New submission from Guido van Rossum:
[Guido]
> > I've noticed that abc.py's __instancecheck__ gets called a lot
> > at times when I don't expect it. Can you research this a bit?
[Amaury]
> In classobject.c, method_call() calls PyObject_IsInstance() on the
Changes by Guido van Rossum:
--
assignee: -> gvanrossum
__
Tracker <[EMAIL PROTECTED]>
<http://bugs.python.org/issue1438>
__
___
Python-bugs-list mailing li
Guido van Rossum added the comment:
I think this is unavoidable. Depending on whether you happen to be using
a narrow or wide unicode build of Python, \U may be turned into
a pair of surrogates anyway. It's not just marshal that's not
roundtripping; the utf-8 codec has the
Guido van Rossum added the comment:
Please provide a self-contained example program that behaves correctly
in 2.4.3 and fails in 2.4.4 if you want us to investigate this further.
How does it behave with 2.5.1?
--
nosy: +gvanrossum
__
Tracker <[EM
Guido van Rossum added the comment:
I don't think the added syntactic complexity is worth the relatively
rare use case, especially since there's already an implementation of
nested() in the contextlib library.
--
nosy: +gvanrossum
resolution: -> wont fix
status: o
Guido van Rossum added the comment:
Somebody please propose a patch!
--
nosy: +gvanrossum
__
Tracker <[EMAIL PROTECTED]>
<http://bugs.python.org/issue1436>
__
___
Guido van Rossum added the comment:
If this doesn't cause any problems on other platforms, go for it.
__
Tracker <[EMAIL PROTECTED]>
<http://bugs.python.org/issue1342>
__
__
Guido van Rossum added the comment:
Amaury, can you have a look at this? I think it's a bug in tok_nextc()
in tokenizer.c.
--
assignee: nnorwitz -> amaury.forgeotdarc
nosy: +amaury.forgeotdarc
__
Tracker <[EMAIL PROTECTED]>
<http:
Guido van Rossum added the comment:
Is this also broken in the 3.0a1 release? If not, it might be useful
to try to find the most recent rev where it's not broken.
__
Tracker <[EMAIL PROTECTED]>
<http://bugs.python
Guido van Rossum added the comment:
The patch looks okay, but I just thought of something -- why not make
sys.stdout and friends be undefined (i.e. NULL) instead of setting them
to None? That way this patch isn't necessary and you only need one
small change to builtin_print() -- which you
Guido van Rossum added the comment:
Crys, can you test this on Windows and if it does, assign back to me?
--
assignee: gvanrossum -> tiran
nosy: +tiran
__
Tracker <[EMAIL PROTECTED]>
<http://bugs.python.o
Guido van Rossum added the comment:
Never mind. I must've searched for fromdf. Crys, I think this is good
to go into 2.6 and be merged into 3.0. Then in 3.0 we can simplify Bill
Janssen's patch further.
--
assignee: -> tiran
__
Tr
Guido van Rossum added the comment:
BTW for reference, see http://www.python.org/download/releases/2.3/mro/
Tracker <[EMAIL PROTECTED]>
<http://bugs.python.org/is
Guido van Rossum added the comment:
I'd like to see this applied, HOWEVER I'm confused. I don't see any
mention of fromfd in the patch except in a comment. Now, in 3.0,
fromfd() is implemented in socket.py using os.dup(); but in 2.6 i don't
see it there either. What'
Guido van Rossum added the comment:
Go for it.
On Nov 14, 2007 10:39 AM, Christian Heimes <[EMAIL PROTECTED]> wrote:
>
> Christian Heimes added the comment:
>
> Guido van Rossum wrote:
> > The patch looks okay, but I just thought of something -- why not make
>
Guido van Rossum added the comment:
I'm disappointed that this doesn't implement socket.fromfd() properly.
Perhaps fromfd() needs to be implemented in socketmodule.c?
Also, the whole mess with the _base slot can be gotten rid of;
accept() can use the dup() meth
Guido van Rossum added the comment:
Go ask on c.l.py why this is not a bug.
--
nosy: +gvanrossum
resolution: -> invalid
status: open -> closed
__
Tracker <[EMAIL PROTECTED]>
<http://bugs.pytho
Guido van Rossum added the comment:
> On Windows socket.fromfd() is not possible. Socket handlers and file
> descriptors are different types using different API methods. Other
> examples for the discrepancy are select.select() and select.poll(). On
> Windows they don't work on f
Guido van Rossum added the comment:
I take it back. You can check this in.
__
Tracker <[EMAIL PROTECTED]>
<http://bugs.python.org/issue1440>
__
___
Python-bugs-list
Guido van Rossum added the comment:
Committed revision 58970 (with slight changes).
Bill, you can now submit your SSL code for review.
--
assignee: gvanrossum -> tiran
resolution: -> accepted
status: open -> closed
__
Tracker <[EMAIL PROTE
Guido van Rossum added the comment:
Crys, did you actually run the tests for the 3.0 port of the patch? I
think accept() is broken, as it checks for _can_dup_socket and will
attempt to call os.dup().
I'm thinking that we should change the C class to not create new objects
on accept() an
Guido van Rossum added the comment:
Here's a new version along the lines I described. Please test on
Windows. It works on Linux and OSX. What this includes:
- the dup-on-windows implementation by R Oudkerk, with the
GetLastError() suggestion from Thomas Heller.
- Replace the C implementa
Changes by Guido van Rossum:
Removed file: http://bugs.python.org/file8747/socket.diff
__
Tracker <[EMAIL PROTECTED]>
<http://bugs.python.org/issue1378>
__
___
Python-bugs-
Guido van Rossum added the comment:
New version of socket.diff. The only change is better docstrings for
accept() and dup().
Added file: http://bugs.python.org/file8748/socket.diff
__
Tracker <[EMAIL PROTECTED]>
<http://bugs.python.org/
Guido van Rossum added the comment:
PS. socket.diff is for 3.0. I'll backport once this is accepted.
__
Tracker <[EMAIL PROTECTED]>
<http://bugs.python.org/issue1378>
__
__
Guido van Rossum added the comment:
Can you submit a unittest that catches this? Then I can check in the fix.
--
assignee: fdrake -> gvanrossum
__
Tracker <[EMAIL PROTECTED]>
<http://bugs.python.o
Guido van Rossum added the comment:
Committed revision 58987.
--
status: open -> closed
__
Tracker <[EMAIL PROTECTED]>
<http://bugs.python.org/issue1144>
__
___
P
Guido van Rossum added the comment:
roudkerk, can you turn that suggestion into a proper patch?
__
Tracker <[EMAIL PROTECTED]>
<http://bugs.python.org/issue1378>
__
___
Pyth
Guido van Rossum added the comment:
Forgot to upload socket3.diff.
Added file: http://bugs.python.org/file8759/socket3.diff
__
Tracker <[EMAIL PROTECTED]>
<http://bugs.python.org/issue1378>
__Index: Include/
Guido van Rossum added the comment:
socket3.diff builds on socket2.diff:
- Rename socket class to Socket; add socket() as a factory function.
- Implement roudkerk's suggestion of using a duplicate socket in
makefile() to get rid of the manual reference counting. Yay!
Note: this dinter
Guido van Rossum added the comment:
socket2.diff makes dup() a module-level function in _socket (and hence
in socket.py) and uses that to implement fromfd() in socket.py.
No changes otherwise compared to py3k_another_socket.patch.
Added file: http://bugs.python.org/file8758/socket2.diff
Guido van Rossum added the comment:
> I've reviewed your patch and merged it was some pending changes of my
> own. The socket tests are passing on Windows. Great work :)
You didn't upload this though.
__
Tracker <[EMAIL PROTECTED]>
&
Guido van Rossum added the comment:
Looks good (after skimming). Some stylistic nits:
- Please fold lines >= 80 chars.
- Please strip trailing whitespace (for Python code, you won't be
allowed to submit with it present).
- You can fold long imports without using the dreaded backslash
Guido van Rossum added the comment:
- I'm hoping that Bill can submit his SSL changes first.
- If we make _dup() a module-level function, we can implement fromfd()
in Python. I'll do this now.
__
Tracker <[EMAIL PROTECTED]>
<http://bugs.p
Guido van Rossum added the comment:
> In release25-maint, PyErr_Print() should be replaced with
> PyErr_Clear() also.
Committed revision 58991.
_
Tracker <[EMAIL PROTECTED]>
<http://bugs.python.o
Guido van Rossum added the comment:
If you haven't checked this in by tomorrow morning, I'll submit issue
1378 (socket3.diff) first, and you'll have to do a bunch of cleanup.
Or, if you like, I can submit that now and you can do the cleanup this
afternoon. (Basically, we can d
Guido van Rossum added the comment:
Patch anyone?
--
nosy: +gvanrossum
__
Tracker <[EMAIL PROTECTED]>
<http://bugs.python.org/issue1445>
__
___
Python-bugs-list
Guido van Rossum added the comment:
Thanks! To be continued in issue 1378...
--
resolution: -> accepted
status: open -> closed
__
Tracker <[EMAIL PROTECTED]>
<http://bugs.pytho
Guido van Rossum added the comment:
Hold on, socket3.diff breaks four unit tests:
test_ftplib test_poplib test_smtplib test_urllib2net
> newfd = _socket.dup(socket_instance)
But that doesn't allow fromfd to work. I found some real use cases for
fromfd where the fd is passed in thro
Guido van Rossum added the comment:
Crys, since you apparently have working sound on Windows, could you have
a look at this? There's also an (unrelated) issue with sunau.py on
Py3k, it doesn't work (but the unittests aren't strong enough to
discover that :-).
--
assi
Guido van Rossum added the comment:
Thanks! roudkerk's patch is submitted as revision 59004.
BTW I need to go back to the drawing board for the rest of the socket
patch here. Using dup() in makefile() doesn't work for the
ssl.SSLSocket class. Maybe the explicit reference counting i
Guido van Rossum added the comment:
I don't think tokenizer.py needs to be changed -- it never interpreted
backslashes in string literals anyway (not even in regular, non-raw
literals).
The tokenizer.c cleanup is submitted as revision 59007.
I still am not warming up towards the no-raw-es
Guido van Rossum added the comment:
I've submitted socket2.diff plus small changes to ssl.py.
This seems the best I can do given that I don't think I can make dup()
work on ssl sockets.
--
resolution: -> accepted
status: open -> closed
__
Guido van Rossum added the comment:
This depends on the version of Make used. See the man page for Make.
--
nosy: +gvanrossum
__
Tracker <[EMAIL PROTECTED]>
<http://bugs.python.org/
Guido van Rossum added the comment:
I think you misunderstand. Passing a variable to configure makes that
setting have effect *during the configure run*.
__
Tracker <[EMAIL PROTECTED]>
<http://bugs.python.org/
Guido van Rossum added the comment:
> Any "standard" way to add custom compilation flags?.
Beats me. I'm no autoconf expert.
--
resolution: -> wont fix
status: open -> closed
__
Tracker <[EMAIL PROTECTED]>
<
Guido van Rossum added the comment:
I think this was fixed in svn this week! See issue 1265. Let me know
if your issue is different.
--
nosy: +gvanrossum
__
Tracker <[EMAIL PROTECTED]>
<http://bugs.python.org/
Guido van Rossum added the comment:
Thanks anyway!
--
resolution: -> duplicate
status: open -> closed
superseder: -> pdb bug with "with" statement
__
Tracker <[EMAIL PROTECTED]>
<http
Guido van Rossum added the comment:
I can look into this, as I have OSX on my laptop.
_
Tracker <[EMAIL PROTECTED]>
<http://bugs.python.org/issue1739468>
_
___
Pyth
Guido van Rossum added the comment:
Right.
--
nosy: +gvanrossum
resolution: -> wont fix
status: open -> closed
__
Tracker <[EMAIL PROTECTED]>
<http://bugs.pytho
Guido van Rossum added the comment:
Actually the failures aren't OSX-specific:
==
FAIL: test_directory (__main__.CmdLineTest)
--
Traceback (most recent
Guido van Rossum added the comment:
Oops, those are failures under 3.0, probably due to Crys's merge. On
Linux, the 2.6 version of the test doesn't fail. I see 2 failing tests
on OSX with the 2.6 version, which I will look into.
_
Tracker <[EM
Guido van Rossum added the comment:
Fixed the OSX failure in revision 59055; it was due to /tmp being a
symlink, and fixed by application of realpath().
Keeping this open until the 3.0 version is working.
_
Tracker <[EMAIL PROTECTED]>
<http://bugs.p
Guido van Rossum added the comment:
No. If you're testing something that's not implemented, it is correct to
see that as a failure. Talk to anyone doing TDD.
--
nosy: +gvanrossum
resolution: -> wont fix
status: open -> closed
__
Guido van Rossum added the comment:
3.0 fix committed as revision 59058.
--
resolution: -> accepted
status: open -> closed
versions: +Python 3.0
_
Tracker <[EMAIL PROTECTED]>
<http://bugs.python.o
Guido van Rossum added the comment:
Sorry, just comment out those tests until you're ready to write the code.
__
Tracker <[EMAIL PROTECTED]>
<http://bugs.python
Guido van Rossum added the comment:
Sorry Erik, but I don't think you should try to compensate for your
flawed methodology by trying to change the unittest framework. End of
discussion.
__
Tracker <[EMAIL PROTECTED]>
<http://bugs.python
Changes by Guido van Rossum:
--
nosy: -gvanrossum
__
Tracker <[EMAIL PROTECTED]>
<http://bugs.python.org/issue1328>
__
___
Python-bugs-list mailing list
Unsubs
Guido van Rossum added the comment:
IDLE stuff is never mine.
--
assignee: gvanrossum -> kbk
__
Tracker <[EMAIL PROTECTED]>
<http://bugs.python.org/issue1374>
__
Guido van Rossum added the comment:
I have no way to test this.
--
assignee: gvanrossum ->
priority: high -> normal
__
Tracker <[EMAIL PROTECTED]>
<http://bugs.pytho
601 - 700 of 5533 matches
Mail list logo