Guido van Rossum added the comment:
Only a few modules are involved in the bootstrap. The filename is
mostly used to display in the traceback. There is already a fallback
in the traceback-printing code that tries to look through sys.path for
a file matching the module if it can't ope
Guido van Rossum added the comment:
> Oh stop, the array module doesn't build for me (Ubuntu Linux, i386,
> UCS-4 build, rev58458):
>
> Modules/arraymodule.c: In function 'array_buffer_getbuf':
> Modules/arraymodule.c:1815: error: 'Py_buffer' has no m
Guido van Rossum added the comment:
This looks promising. I'm working on the freeze issue. Once I get that
working I'll check this in. Thanks Alexandre and Christian for all
your hard work!!!
__
Tracker <[EMAIL PROTECTED]>
<http://bugs.p
Guido van Rossum added the comment:
> The problem is the imp module, which modulefinder uses, does not
> detect the encoding of the files from the mode-line. This causes
> TextIOWrapper to crash when it tries to read modules using an encoding
> other than ASCII or UTF-8. Her
Guido van Rossum added the comment:
> > This looks promising. I'm working on the freeze issue. Once I get that
> > working I'll check this in. Thanks Alexandre and Christian for all
> > your hard work!!!
>
> You're welcome. Does the patch qualify me for
Guido van Rossum added the comment:
Committed revision 58466.
Fingers crossed.
--
resolution: -> accepted
status: open -> closed
__
Tracker <[EMAIL PROTECTED]>
<http://bugs.pytho
Guido van Rossum added the comment:
> atsuo ishimoto added the comment:
>
> That's fine with me. Please replace PyErr_Print() with PyErr_Clear().
Done.
Committed revision 58471.
_
Tracker <[EMAIL PROTECTED]>
<http://bugs.
Guido van Rossum added the comment:
Hm? This is a one-word patch to email/generator.py.
On 10/15/07, Christian Heimes <[EMAIL PROTECTED]> wrote:
>
> Christian Heimes added the comment:
>
> Here is an updated patch which applies cleanly and fixes some additional
> unit tests
Guido van Rossum added the comment:
Marc-Andre, do you understand this issue? Your name is in
Tools/unicode/Makefile; the patch deletes the line
$(RM) build/mac_japanese.*
from the apple target, which seems rather arbitrary.
--
assignee: -> lemburg
nosy: +gvanrossum, lemb
Guido van Rossum added the comment:
Patch please?
--
nosy: +gvanrossum
__
Tracker <[EMAIL PROTECTED]>
<http://bugs.python.org/issue1277>
__
___
Python-bugs-list
Guido van Rossum added the comment:
Can you suggest a patch?
Adding Brett Cannon to the list, possibly his import-in-python would
supersede this?
--
nosy: +brett.cannon, gvanrossum
__
Tracker <[EMAIL PROTECTED]>
<http://bugs.python.org/
Guido van Rossum added the comment:
I'll look at this at some point. One quick comment: the lnotab and bytecode
should use PyString, which will be 'bytes' in 3.0a2. They must be immutable
because code objects must be immutable (it must not be possible to modify an
existing code
Guido van Rossum added the comment:
> No, I can't suggest a patch. I don't know how we could get the encoding
> from the tokenizer or AST.
Try harder. :-) Look at the code that accomplishes this feat in the
regular parser...
__
Tracker <[EMAI
Guido van Rossum added the comment:
Call PyTokenizer_Get until the line number is > 2?
On 10/15/07, Christian Heimes <[EMAIL PROTECTED]> wrote:
>
> Christian Heimes added the comment:
>
> > Try harder. :-) Look at the code that accomplishes this feat in the
> &
Guido van Rossum added the comment:
Is it worth my time to review this yet?
__
Tracker <[EMAIL PROTECTED]>
<http://bugs.python.org/issue1261>
__
___
Python-bugs-list
Changes by Guido van Rossum:
__
Tracker <[EMAIL PROTECTED]>
<http://bugs.python.org/issue1258>
__
___
Python-bugs-list mailing list
Unsubscribe:
http://mail.python.org/mai
Guido van Rossum added the comment:
> The unit tests profile, cProfile and doctest fail w/ and w/o this patch.
> They seem to suffer from the latest changes of our previous patch and
> additional calls to utf_8_decode().
Any details on those? They don'
Guido van Rossum added the comment:
I'll check this in as soon as there's agreement on the list about this.
Not that I expect disagreement, but I just realized it was never brought
up and it isn't in PEP 3137 (yet).
__
Tracker <[EMAIL
Guido van Rossum added the comment:
BTW we need a 2to3 fixer for this. Should be trivial -- just replace
*all* occurrences of basestring with str.
__
Tracker <[EMAIL PROTECTED]>
<http://bugs.python.org/
New submission from Guido van Rossum:
Once PEP 3137 is fully implemented, the re module needs to be fixed so
that the regex argument, the substitution argument, and the argument
being searched/replaced are allowed to be arbitrary bytes arrays; where
hashing is needed a copy in an immutable bytes
Guido van Rossum added the comment:
Even before this patch, the re module doesn't work very well on byte
strings. IMO this should be fixed. I've filed a separate bug to remind
us: bug 1282.
__
Tracker <[EMAIL PROTECTED]>
<http://bugs.p
Guido van Rossum added the comment:
Very impressive!
(Apologies if these lines are occasionally out of order.)
+extern PyObject* _bytes_isspace(const char *cptr, const Py_ssize_t len);
IMO all these functions should have names starting with _Py or _Py_,
since they are visible to the linker
Guido van Rossum added the comment:
Good! Check it in before I change my mind. :-)
The words can be tweaked later.
> 04b is the same as 04, i just fixed the docstrings that i had missed in
> stringlib/transmogrify.h to use 'B' instead of 'S' and say they return a
>
Guido van Rossum added the comment:
> I've carefully checked and tested the initstdio() method. I'm sure that
> I've catched every edged case. The unit tests pass w/o complains.
>
> I've also added a PyErr_Display() call to Py_FatalError(). It's still
>
Guido van Rossum added the comment:
Committed revision 58495.
Thanks Christian!!!
--
resolution: -> accepted
status: open -> closed
__
Tracker <[EMAIL PROTECTED]>
<http://bugs.pytho
Guido van Rossum added the comment:
Does this mean I should hold off reviewing the patch?
On 10/16/07, Christian Heimes <[EMAIL PROTECTED]> wrote:
>
> Christian Heimes added the comment:
>
> Christian Heimes wrote:
> > * removed unused import of open in initstdio()
&g
Guido van Rossum added the comment:
Patch please?
--
nosy: +gvanrossum
__
Tracker <[EMAIL PROTECTED]>
<http://bugs.python.org/issue1291>
__
___
Python-bugs-list
Guido van Rossum added the comment:
Would you mind submitting a patch instead of a whole new file?
--
nosy: +gvanrossum
__
Tracker <[EMAIL PROTECTED]>
<http://bugs.python.org/
Guido van Rossum added the comment:
This is tough. On the one hand you are right that different classes that
have different formatException() methods aren't treated correctly; on
the other hand I think the caching is important for other cases where
there are multiple loggers all usin
Guido van Rossum added the comment:
How important is z/OS? I'm very skeptical of the viability of any OS
that uses an encoding that is not a superset of ASCII.
--
nosy: +gvanrossum
__
Tracker <[EMAIL PROTECTED]>
<http://bugs.python
Guido van Rossum added the comment:
I think so.
On 10/18/07, Thomas Heller <[EMAIL PROTECTED]> wrote:
>
> Thomas Heller added the comment:
>
> > > This is tough. On the one hand you are right that different classes that
> > > have different formatException() met
Guido van Rossum added the comment:
Hmm... I don't think this is the right thing to do. The code is broken
in several ways. I recommend you find someone to help you come up with
a better patch in comp.lang.python.
--
keywords: +patch
__
Tr
Guido van Rossum added the comment:
I've committed the half of this patch that doesn't break any tests: the
changes to codecs.c and structmember.c.
Committed revision 58551.
I'm seeking help getting the remaining unit tests to pass. (Thanks
Thomas for the enumeration of th
Changes by Guido van Rossum:
--
assignee: -> gvanrossum
nosy: +gvanrossum
__
Tracker <[EMAIL PROTECTED]>
<http://bugs.python.org/issue1280>
__
___
Python-bugs-li
Guido van Rossum added the comment:
I will take this.
--
assignee: brett.cannon -> gvanrossum
__
Tracker <[EMAIL PROTECTED]>
<http://bugs.python.org/issue1267>
__
Guido van Rossum added the comment:
There were some seriously broken things with exception reporting, most
of which I seem to have fixed.
--
resolution: -> fixed
status: open -> closed
__
Tracker <[EMAIL PROTECTED]>
<http://bugs.pytho
Guido van Rossum added the comment:
There were some seriously broken things with exception reporting, most
of which I seem to have fixed.
--
resolution: -> fixed
status: open -> closed
__
Tracker <[EMAIL PROTECTED]>
<http://bugs.pytho
Guido van Rossum added the comment:
FYI, I checked the moderation queue for python-dev and didn't find your
message. You might want to resend.
__
Tracker <[EMAIL PROTECTED]>
<http://bugs.python
Changes by Guido van Rossum:
--
resolution: -> fixed
status: open -> closed
__
Tracker <[EMAIL PROTECTED]>
<http://bugs.python.org/issue1278>
__
___
Python
Guido van Rossum added the comment:
Committed revision 58553 (with minor tweaks only).
Thanks!
--
resolution: -> accepted
status: open -> closed
__
Tracker <[EMAIL PROTECTED]>
<http://bugs.pytho
Guido van Rossum added the comment:
Checked in. I addressed some of your XXX'es, left others in (sre needs
a serious checkup for compatibility with bytes).
Committed revision 58552.
--
resolution: -> accepted
status: open -> closed
__
Trac
Guido van Rossum added the comment:
Neal, didn't you say you had a fix for this?
--
nosy: +nnorwitz
__
Tracker <[EMAIL PROTECTED]>
<http://bugs.python
Guido van Rossum added the comment:
> OK, I think I might have a solution, and it is really stupid. I will
> run the unit test suite to see if it really fixes everything.
Here's keeping my fingers crossed.
I do note that the new code still leaks the encoding string which is
m
Guido van Rossum added the comment:
FWIW, on Mac I get six failures (all these pass on Linux):
test_cmd_line test_inspect test_modulefinder test_pyclbr test_quopri test_runpy
__
Tracker <[EMAIL PROTECTED]>
<http://bugs.python.org/
Guido van Rossum added the comment:
> How do you measure importance? Z/OS is not important to many
> people in the world, but to those to whom it is important, it is
> _very_ important, in a very tangible way. It was certainly
> important enough for someone to port Python to it. :
Guido van Rossum added the comment:
Thanks for persevering!!!
The dangers of switching between fileno(fp) and fp are actually well
documented in the C and/or POSIX standards. The problem is caused in
PyFile_FromFileEx() -- it creates a Python file object from the file
descriptor. The fix
Guido van Rossum added the comment:
Sorry, I was wrong about the encoding leak; you fixed that. The
FILE/fd issue is real though.
__
Tracker <[EMAIL PROTECTED]>
<http://bugs.python.org/
Guido van Rossum added the comment:
> Guido, Brett, how much of the code should I change? import.c is mainly
> using file pointers. Should I replace all operations on FILE with
> operations on a file descriptor?
I think find_module() should return a file descriptor (fd), not a
FILE*,
Guido van Rossum added the comment:
> Is PyFile_FromFd and PyFile_FromFdEx fine with you or do you prefer a
> different name like PyFile_FromFD and PyFile_FromFDEx or
> PyFile_FromFileDescriptor?
Let's have a single function PyFile_FromFd(fd, name, mode, buffering,
encoding, new
Guido van Rossum added the comment:
Do you have access to Windows? I believe it doesn't have dup(). :-(
__
Tracker <[EMAIL PROTECTED]>
<http://bugs.python.org/issue1267>
__
_
Guido van Rossum added the comment:
> Guido, what do you want to do about the struct module for the various
> string formats (i.e., c, s, p)? Should they return str8 or Unicode?
Oh, tough call. I think they should return str8 (i.e. bytes after the
rename) because the encoding isn't
Guido van Rossum added the comment:
> > Do you have access to Windows? I believe it doesn't have dup(). :-(
>
> I've an old laptop with Win2k at my disposal but it has no VS yet. Can
> you point me to a set of instruction how to install VS 2003? I've just
> VS .N
Changes by Guido van Rossum:
--
resolution: accepted ->
status: closed -> open
__
Tracker <[EMAIL PROTECTED]>
<http://bugs.python.org/issue1267>
__
___
Python
Guido van Rossum added the comment:
OK, checked in.
You might want to compare what I checked in to your patch; I did a few
style cleanups. I also moved the lseek() call into import.c, where it
seems more appropriate.
Committed revision 58587.
--
resolution: -> accepted
status: o
Guido van Rossum added the comment:
Committed revision 58592.
--
nosy: +gvanrossum
resolution: -> accepted
status: open -> closed
__
Tracker <[EMAIL PROTECTED]>
<http://bugs.pytho
Guido van Rossum added the comment:
Thanks!
Committed revision 58594.
Is there time to backport this to 2.5.2?
--
assignee: -> nnorwitz
nosy: +gvanrossum, nnorwitz
resolution: -> accepted
__
Tracker <[EMAIL PROTECTED]>
<http://
Guido van Rossum added the comment:
This doesn't apply cleanly with today's trunk, and that's not just due
to the fix by Christian Heimes (which I checked in before noticing this)
that fixes the same issue (bytes_methods.c).
Can you & Christian please work together on a new p
Guido van Rossum added the comment:
Odd. Smells like an OSX issue that we can't do anything about. I note
that only attempts 250, 500, 750 (and so on if you increase the counter)
have this behavior. I wonder if you'r simply filling up some kernel
queue too fast; if I insert time.s
Guido van Rossum added the comment:
Yup, I think that was it. Sorry.
Committed revision 58597.
--
resolution: -> accepted
status: open -> closed
__
Tracker <[EMAIL PROTECTED]>
<http://bugs.pytho
Guido van Rossum added the comment:
Fine with me!
--
nosy: +gvanrossum
Tracker <[EMAIL PROTECTED]>
<http://bugs.python.org/issue708374>
___
Python-bugs-
Changes by Guido van Rossum:
--
resolution: -> accepted
status: open -> closed
Tracker <[EMAIL PROTECTED]>
<http://bugs.python.org/issue708374>
__
Guido van Rossum added the comment:
Thanks Georg; please check it in!
--
assignee: gvanrossum -> georg.brandl
resolution: -> accepted
__
Tracker <[EMAIL PROTECTED]>
<http://bugs.pytho
Guido van Rossum added the comment:
This will get more attention if you suggest a patch...
--
nosy: +gvanrossum
__
Tracker <[EMAIL PROTECTED]>
<http://bugs.python.org/
Guido van Rossum added the comment:
Please check in and close -- thanks for finding these!
--
assignee: gvanrossum -> georg.brandl
resolution: -> accepted
__
Tracker <[EMAIL PROTECTED]>
<http://bugs.pytho
Guido van Rossum added the comment:
Committed revision 58618.
There better not be any others. :-)
Neal, can you add this to 2.5.2 and then close?
--
assignee: gvanrossum -> nnorwitz
status: closed -> open
__
Tracker <[EMAIL PROTECTE
Changes by Guido van Rossum:
--
assignee: -> tim_one
nosy: +tim_one
__
Tracker <[EMAIL PROTECTED]>
<http://bugs.python.org/issue1312>
__
___
Python-bugs-li
Guido van Rossum added the comment:
Committed revision 58619.
--
assignee: -> gvanrossum
nosy: +gvanrossum
resolution: -> accepted
status: open -> closed
__
Tracker <[EMAIL PROTECTED]>
<http://bugs.py
Guido van Rossum added the comment:
Martin, why do we need to keep these when we already have tempfile.py?
I don't see that they solve any particular POSIX compatibility
requirement. And they *are* unsafe. (Admitted, sometimes there's no
alternative -- even tempfile.py still provi
Guido van Rossum added the comment:
I have no desire or time to continue this discussion. The ASCII
assumption will be ingrained as deeply or deeper in 3.0 than in 2.x,
just like 8-bit bytes and 2's complement. The computer industry has
chosen, and there just isn't any incentive
Guido van Rossum added the comment:
Looks good to me. I can check it in if Thomas is okay with that (or if
he remains silent long enough :-).
--
nosy: +gvanrossum
__
Tracker <[EMAIL PROTECTED]>
<http://bugs.python.org/
Guido van Rossum added the comment:
Do you have a patch? That would help tremendously.
--
nosy: +gvanrossum
__
Tracker <[EMAIL PROTECTED]>
<http://bugs.python.org/
Changes by Guido van Rossum:
--
priority: -> low
__
Tracker <[EMAIL PROTECTED]>
<http://bugs.python.org/issue1317>
__
___
Python-bugs-list mailing list
Uns
Guido van Rossum added the comment:
Let's not get overexcited. I agree that it makes sense for fileinput,
but I disagree about *StringIO; its close() isn't needed to free
resources (since it doesn't use up a scarce resource like a file
descriptor).
Can you whip up a patch for fil
Guido van Rossum added the comment:
Committed revision 58639.
You're welcome, Thomas.
And Thanks, Amaury! Keep them coming...!
--
assignee: theller -> gvanrossum
resolution: -> accepted
status: open -> closed
__
Tracker <[EMAIL
Guido van Rossum added the comment:
Georg, can you check this in even with test_str failing?
And who is working on that? If I don't get a name I'll tackle it myself.
--
assignee: gvanrossum -> georg.brandl
__
Tracker <[EMAIL P
Guido van Rossum added the comment:
I like Chris's patch better, but he should use (sizeof(lower)-1) instead
of 8, and he should use the TOLOWER macro from bytes_methods.h.
Please submit a new one and I'll check it in!
--
priority: -> normal
_
Guido van Rossum added the comment:
Looks good. Can you check it in?
__
Tracker <[EMAIL PROTECTED]>
<http://bugs.python.org/issue1319>
__
___
Python-bugs-list mailing list
Guido van Rossum added the comment:
2007/10/15, Christian Heimes <[EMAIL PROTECTED]>:
>
> Christian Heimes added the comment:
>
> Guido van Rossum wrote:
> > BTW we need a 2to3 fixer for this. Should be trivial -- just replace
> > *all* occurrences of basestring wi
Guido van Rossum added the comment:
We won't be doing it this way.
--
resolution: remind -> rejected
status: open -> closed
__
Tracker <[EMAIL PROTECTED]>
<http://bugs.
Guido van Rossum added the comment:
Phillip, do you have any interest left in moving PEP 3124 forward?
--
assignee: gvanrossum -> pje
nosy: +pje
__
Tracker <[EMAIL PROTECTED]>
<http://bugs.python.o
Guido van Rossum added the comment:
OK, that's fine.
__
Tracker <[EMAIL PROTECTED]>
<http://bugs.python.org/issue1004>
__
___
Python-bugs-list mailing list
U
Changes by Guido van Rossum:
--
nosy: -gvanrossum
__
Tracker <[EMAIL PROTECTED]>
<http://bugs.python.org/issue1322>
__
___
Python-bugs-list mailing list
Unsubs
Guido van Rossum added the comment:
2007/10/25, Yitz Gale <[EMAIL PROTECTED]>:
> I was actually bitten badly by this issue with
> StringIO. I added fileinput only as an afterthought.
>
> In an xml.sax app, I needed seek() support for a
> codec-wrapped file handle, so I
Guido van Rossum added the comment:
Christian can you revise your patch to also remove os.tmpfile per
Martin's request? Make sure unit tests and docs are fixed too.
__
Tracker <[EMAIL PROTECTED]>
<http://bugs.python
Guido van Rossum added the comment:
2007/10/25, Christian Heimes <[EMAIL PROTECTED]>:
> I can do that for you. But I still believe that os.tmpfile() works
> different than tempfile.mkstemp(). The former returns a file descriptor
> of a file w/o directory entry and the
Guido van Rossum added the comment:
Committed revision 58657.
Thanks!
--
resolution: -> accepted
status: open -> closed
__
Tracker <[EMAIL PROTECTED]>
<http://bugs.pytho
Guido van Rossum added the comment:
Looks fine to me.
Committed revision 58658.
--
nosy: +gvanrossum
resolution: -> accepted
status: open -> closed
__
Tracker <[EMAIL PROTECTED]>
<http://bugs.pytho
Guido van Rossum added the comment:
Committed revision 58659.
I'm sorry I confused you; I was fine with the version that has char
lower[N] but I wanted you to not repeat N-1 later in the code. See what
I checked in. :-)
--
resolution: -> accepted
status: open -
Changes by Guido van Rossum:
--
assignee: -> gvanrossum
keywords: +patch, py3k
__
Tracker <[EMAIL PROTECTED]>
<http://bugs.python.org/issue1330>
__
___
Python-bu
Guido van Rossum added the comment:
While I like fixing the position restore in _fileio.c, I also liked
Amaury's flush() call in _BufferedIOMixin. Perhaps you can keep that
part (while losing the position restore)?
__
Tracker <[EMAIL PROTECTED
Guido van Rossum added the comment:
Tested on OSX as well. Thanks!!
Committed revision 58662.
--
assignee: -> gvanrossum
keywords: +patch, py3k
resolution: -> accepted
status: open -> closed
__
Tracker <[EMAIL PROTECTED]>
<http
Guido van Rossum added the comment:
Committed revision 58673.
I made one change, hopefully I didn't screw it up: skip the positional
restore if the truncation itself failed. Otherwise the positional
restore might overwrite the error from the truncation. After an error
from this function
Guido van Rossum added the comment:
Committed revision 58674.
I added a change to _abcoll.py to remove the registration of bytes as a
subclass of Iterable.
--
resolution: -> accepted
status: open -> closed
__
Tracker <[EMAIL PROTECTE
Guido van Rossum added the comment:
If you submit a patch that adds docs and a unit test, your wish will be
fulfilled.
--
nosy: +gvanrossum
__
Tracker <[EMAIL PROTECTED]>
<http://bugs.python.org/
Guido van Rossum added the comment:
Please submit a patch for docs and a unittest...
--
nosy: +gvanrossum
__
Tracker <[EMAIL PROTECTED]>
<http://bugs.python.org/
Guido van Rossum added the comment:
Can you provide a very small shared library that demonstrates this
problem? (E.g. you could start by modifying Modules/xxmodule.c, adding a
'destructor' function.)
--
nosy: +gvanrossum
__
Tracker <[EM
Guido van Rossum added the comment:
Can't you force a BOM by simply writing \ufffe at the start of the file?
--
nosy: +gvanrossum
__
Tracker <[EMAIL PROTECTED]>
<http://bugs.python
Guido van Rossum added the comment:
Can you step through it with a C/C++ debugger to see where it goes wrong?
--
nosy: +gvanrossum
__
Tracker <[EMAIL PROTECTED]>
<http://bugs.python.org/
Guido van Rossum added the comment:
You missed urllib2 I think. :-)
I agree it's a mess. I'm sure it all started out with backwards
compatibility in mind. I find myself often importing cgi only to use
the tiny function escape() that is defined there...
I wonder if web-sig wouldn&#
Guido van Rossum added the comment:
I don't think we can prevent GC from occurring between fork and exec --
it's legal to just call os.fork() and execute Python code in the
subprocess forever. I think the right solution might be to ignore
errors in file_close(). Can you try to whip
401 - 500 of 5533 matches
Mail list logo
