Guido van Rossum added the comment:
Thanks! Applied to 3.5, 3.6, 3.7. (We don't change 3.4 any more except for
security fixes.)
--
resolution: -> fixed
stage: needs patch -> resolved
status: open -> closed
type: enhancement -> behavior
_
Guido van Rossum added the comment:
Done. Thanks!
--
nosy: +gvanrossum
resolution: -> fixed
stage: needs patch -> resolved
status: open -> closed
___
Python tracker
<http://bugs.python.or
Guido van Rossum added the comment:
Thanks again!
--
nosy: +gvanrossum
resolution: -> fixed
stage: -> resolved
status: open -> closed
___
Python tracker
<http://bugs.python.or
Guido van Rossum added the comment:
Can you submit this as a PR upstream, to github.com/python/typing?
--
___
Python tracker
<http://bugs.python.org/issue28
Guido van Rossum added the comment:
Ivan, if you want to apply it upstream be my guest!
--
___
Python tracker
<http://bugs.python.org/issue28482>
___
___
Pytho
Guido van Rossum added the comment:
Martin can you verify that this worked?
--
resolution: -> fixed
stage: patch review -> commit review
status: open -> closed
___
Python tracker
<http://bugs.python.or
Guido van Rossum added the comment:
Hm, I actually like the original proposal better. Perhaps
collections.abc.Mapping is more common than typing.Mapping, but is it more
common *in function annotations*? I don't think so.
Also, I like showing e.g. Iterator[Tuple[int, Any]] rather than
Guido van Rossum added the comment:
OK, sounds good then. I guess most of the work was in typing.py, not in
inspect. :-)
--
___
Python tracker
<http://bugs.python.org/issue27
Changes by Guido van Rossum :
--
resolution: -> fixed
stage: -> resolved
status: open -> closed
___
Python tracker
<http://bugs.python.org/issue27989>
___
___
Guido van Rossum added the comment:
Honestly I think pydoc is already too verbose. It would be better if the class
header looked more like what was written in the source code -- that is the most
compact way to render it. I say open a separate issue since this issue is about
functions
Changes by Guido van Rossum :
--
nosy: -gvanrossum
___
Python tracker
<http://bugs.python.org/issue23749>
___
___
Python-bugs-list mailing list
Unsubscribe:
Guido van Rossum added the comment:
Applied:
remote: notified python-check...@python.org of incoming changeset bb23770f82f1
remote: notified python-check...@python.org of incoming changeset 3b8dfe6f5bcb
--
resolution: -> fixed
status: open ->
Changes by Guido van Rossum :
--
nosy: -gvanrossum
___
Python tracker
<http://bugs.python.org/issue20847>
___
___
Python-bugs-list mailing list
Unsubscribe:
Guido van Rossum added the comment:
Thanks, applied!
--
resolution: -> fixed
status: open -> closed
___
Python tracker
<http://bugs.python.org/i
Guido van Rossum added the comment:
Sorry about that. Should I roll it back or is there a way to make the test pass
(expect this deprecation)?
--
___
Python tracker
<http://bugs.python.org/issue25
Guido van Rossum added the comment:
Serhiy, so should I revert this patch for now? Or are the silent
deprecation warnings outside the test suite okay? (In that case, maybe
Mariatta can upload a patch?)
--
___
Python tracker
<http://bugs.python.
Guido van Rossum added the comment:
OK, backed out the code changes, kept the docs.
--
___
Python tracker
<http://bugs.python.org/issue25002>
___
___
Python-bug
Guido van Rossum added the comment:
Honestly let's just forget about this.
--
resolution: -> wont fix
status: open -> closed
___
Python tracker
<http://bugs.python
Guido van Rossum added the comment:
Where did you report that? I don't see your name on this bug -- it has a patch
that's been unapplied for 5 years, so I doubt it's very important.
--
___
Python tracker
<http://bugs.py
Guido van Rossum added the comment:
Oh sorry. I received the emails in a strange order. I guess it can stay open.
--
resolution: wont fix ->
status: closed -> open
___
Python tracker
<http://bugs.python.org/
Guido van Rossum added the comment:
I don't want to be the decider here. I don't have time to review the
code. I trust you all to do the right thing.
--
___
Python tracker
<http://bugs.python.o
New submission from Guido van Rossum:
Over at https://github.com/python/typeshed we have a number of big changes in
store. I'm eager to get these into 3.6, so I'm merging them in now, in time for
3.6b3. (Recall that PEP 484 and typing.py remain provisional until 3.7 rol
Guido van Rossum added the comment:
LGTM too. Can someone add this to the asyncio docs (starting at the 3.5 branch
please)?
--
___
Python tracker
<http://bugs.python.org/issue28
Guido van Rossum added the comment:
Patch 3 LGTM.
--
___
Python tracker
<http://bugs.python.org/issue28600>
___
___
Python-bugs-list mailing list
Unsubscribe:
Guido van Rossum added the comment:
LGTM, will apply shortly.
--
___
Python tracker
<http://bugs.python.org/issue26980>
___
___
Python-bugs-list mailing list
Unsub
Changes by Guido van Rossum :
--
resolution: -> fixed
stage: needs patch -> resolved
status: open -> closed
___
Python tracker
<http://bugs.python.or
Guido van Rossum added the comment:
PS. I noticed there are a few lines different between the "upstream" repo
and the 3.5 stdlib:
+# Wake up the loop if the finalizer was called from
+# a different thread.
+self._write_to_self()
On Thu, Nov 3, 20
Changes by Guido van Rossum :
--
nosy: -gvanrossum
___
Python tracker
<http://bugs.python.org/issue23996>
___
___
Python-bugs-list mailing list
Unsubscribe:
Guido van Rossum added the comment:
Can you say it in the form of a patch?
--
nosy: +gvanrossum
___
Python tracker
<http://bugs.python.org/issue21501>
___
___
Changes by Guido van Rossum :
--
resolution: -> fixed
stage: -> resolved
status: open -> closed
___
Python tracker
<http://bugs.python.org/issue28622>
___
___
Guido van Rossum added the comment:
Hm... We've seen this exact same crash reported several times before, and it
was closed without a fix AFAICT each time.
- https://github.com/python/asyncio/issues/396
- http://bugs.python.org/issue23548
IIUC the conclusion in the latter was that this i
Guido van Rossum added the comment:
Good point. Thanks Berker!
--
___
Python tracker
<http://bugs.python.org/issue28088>
___
___
Python-bugs-list mailin
Guido van Rossum added the comment:
Reverting is reasonable, though it may break some code that started using this
in 3.6b1. Such is the life of beta testers. The benefit of using Enum for re
constants doesn't seem worth such a big increase in startup time.
--
nosy: +gvanr
Guido van Rossum added the comment:
Agreed.
--Guido (mobile)
--
___
Python tracker
<http://bugs.python.org/issue28637>
___
___
Python-bugs-list mailing list
Unsub
Guido van Rossum added the comment:
So what does that benchmark measure? For me, python 3.6 startup is 44 ms
and python 2.7 startup is 78 ms (real time; user time is proportionally
less).
On Mon, Nov 7, 2016 at 5:40 PM, STINNER Victor
wrote:
>
> STINNER Victor added the c
Guido van Rossum added the comment:
Please make sure this lands in beta 4!
--Guido (mobile)
--
___
Python tracker
<http://bugs.python.org/issue19717>
___
___
Guido van Rossum added the comment:
However, in general you should use a different pattern. Wrap each future in
a coroutine that does whatever you want to do to the first one ready and
maybe cancel the others. Then gather() all coroutines with the flag that
keeps errors.
--Guido (mobile
Guido van Rossum added the comment:
Well, in that case the idiom will be even simpler: wrap each one in a
coroutine that awaits it and prints the result and then gather() all the
coroutine wrappers.
--
___
Python tracker
<http://bugs.python.
Guido van Rossum added the comment:
OK. I believe we also found that the extra slowdown is only in a virtualenv
so that may explain that I saw something different.
--
title: Python startup performance regression due to enum in re -> Python
startup performance regress
Guido van Rossum added the comment:
Honestly now the basic startup time is under control I am fine with
restoring the re enum. We can optimize that later.
--Guido (mobile)
--
___
Python tracker
<http://bugs.python.org/issue28
Guido van Rossum added the comment:
Ivan, this was an early typing.py update (merged into CPython on Sept. 27). But
the refleak is still with us. Do you have any intuition on what could be going
on here?
My own intuition here is lacking, other than thinking there's a lot of
metaclass
Guido van Rossum added the comment:
Serhiy, why is `gc.collect()` returning 2 after `del A` proof of a leak?
Yes, there's a cycle, but it's being GC'ed -- isn't that fine? Without the
slots the collect() call returns a larger number.
--
__
Guido van Rossum added the comment:
I could use a hint on a complete program that establishes whether there is
or is not a refleak.
--
___
Python tracker
<http://bugs.python.org/issue28
Guido van Rossum added the comment:
Good sleuthing! So the bug is in _lru_cache?
On Wed, Nov 9, 2016 at 10:37 AM, Guido van Rossum
wrote:
>
> Guido van Rossum added the comment:
>
> I could use a hint on a complete program that establishes whether there is
> or i
Guido van Rossum added the comment:
I'd be very happy if that landed in 3.6 with the default strict=False.
--
___
Python tracker
<http://bugs.python.org/is
Guido van Rossum added the comment:
I have no objections against typing-clear-caches.patch (though we'll have to
make sure to apply it to the GitHub upstream as well -- I can take care of that
once you merge it to CPython).
Does that patch fix the refleak completely or only partially?
I
Guido van Rossum added the comment:
FYI I've opened https://github.com/python/typing/issues/323 to track this
upstream.
--
___
Python tracker
<http://bugs.python.org/is
Guido van Rossum added the comment:
> It fixes 96% of refleaks.
In typing.py? Or generally?
--
___
Python tracker
<http://bugs.python.org/issue28649>
___
_
Guido van Rossum added the comment:
Thanks!
--
___
Python tracker
<http://bugs.python.org/issue19717>
___
___
Python-bugs-list mailing list
Unsubscribe:
Guido van Rossum added the comment:
Serhiy can you apply the non-typing.py part of typing-clear-caches.patch? The
diff I applied only has the typing.py part (because I've done this upstream
first).
--
___
Python tracker
<http://bugs.py
Guido van Rossum added the comment:
But why is this so different from the C implementation of lru_cache?
--
___
Python tracker
<http://bugs.python.org/issue28
Guido van Rossum added the comment:
Segfault or traceback?
Anyway, it implements a doubly-linked list where each node is implemented
as a list of 4 items... Maybe there's something in the GC code that
recurses down at the C level??? I'm not sure a crash the Python version of
lru_
Guido van Rossum added the comment:
We discussed cache size previously and 128 is fine.
--Guido (mobile)
--
___
Python tracker
<http://bugs.python.org/issue28
Guido van Rossum added the comment:
Thanks a bundle, Ivan! I've merged those two into CPython 3.5, 3.6, 3.7. We can
now watch the build bots for a while and double-check the refleaks.
Yury, when you're happy with the situation can you close
Guido van Rossum added the comment:
BTW, do we still want the tearDown()? Or is that no longer necessary?
--
___
Python tracker
<http://bugs.python.org/issue28
Changes by Guido van Rossum :
--
title: Document recen changes in typing.py -> Document recent changes in
typing.py
___
Python tracker
<http://bugs.python.org/issu
Guido van Rossum added the comment:
I think it's okay to add `enum` back into `re`.
--
___
Python tracker
<http://bugs.python.org/issue28637>
___
___
Pytho
Changes by Guido van Rossum :
--
resolution: -> fixed
stage: -> resolved
status: open -> closed
___
Python tracker
<http://bugs.python.org/issue28644>
___
___
Guido van Rossum added the comment:
So we now have the refleak fixed. Can we apply the patch? Or is it too late for
3.6?
--
nosy: +gvanrossum
___
Python tracker
<http://bugs.python.org/issue24
Guido van Rossum added the comment:
Actually I'm with Raymond -- I'm also not sure or mildly against (-0).
Given how easy it is to do without and how cumbersome using the operator
module is I don't see a great benefit. (IMO the operator module should be
the measure of *last* reso
Guido van Rossum added the comment:
Looks like create_waiter() entered the with-statement but didn't leave it
properly due to the cancellation, right? @1st1 any idea? async with bug or
asyncio bug?
--
___
Python tracker
<http://bugs.py
Changes by Guido van Rossum :
--
nosy: -gvanrossum
___
Python tracker
<http://bugs.python.org/issue28684>
___
___
Python-bugs-list mailing list
Unsubscribe:
Guido van Rossum added the comment:
Might I point out the precedent of b-strings? Those also don't contribute
to __doc__.
--
___
Python tracker
<http://bugs.python.org/is
5501 - 5563 of 5563 matches
Mail list logo