Guido van Rossum added the comment:
asyncio already uses monotonic. The only place patched is a test
utility and I don't care either way. But I do think this is not a good
patch to do in general.
--
___
Python tracker
<http://bugs.py
Guido van Rossum added the comment:
I mostly adhere to the rule of thumb "if it ain't broke, don't fix
it". So I would only endorse such changes if they address actual pain,
rather than possible pain.
Note that that rule of thumb was born out of worry about anothe
Guido van Rossum added the comment:
Looks related (possibly a duplicate) of issue #27136. Also related is a fix for
the latter in https://github.com/python/asyncio/pull/357. That fix is already
in the CPython repo, but I guess it didn't make it into
Guido van Rossum added the comment:
I'll try to get to this during the core dev sprint next week.
--
___
Python tracker
<http://bugs.python.org/is
New submission from Guido van Rossum:
Pending PEP 526's acceptance, I am inviting Ivan Levkivskyi to upload his patch
here so it can be reviewed.
--
assignee: gvanrossum
components: Interpreter Core
messages: 274672
nosy: gvanrossum
priority: normal
severity: normal
stage: needs
Guido van Rossum added the comment:
Thanks Serhiy!
--Guido (mobile)
On Sep 6, 2016 12:35 PM, "Roundup Robot" wrote:
>
> Roundup Robot added the comment:
>
> New changeset cb7ee9d9cddd by Serhiy Storchaka in branch 'default':
> Issue #25596: Optimized
Guido van Rossum added the comment:
Thanks for the report. I've never seen this before, so I doubt it is a
common mistake. Yury have you ever seen this?
--Guido (mobile)
--
___
Python tracker
<http://bugs.python.org/is
Guido van Rossum added the comment:
It seems the output produced here is generated by inspect.signature(), which is
called by pydoc in this case (in both versions of docroutine()).
I don't know if the right thing to do is to change inspect.signature() here, or
to change pydoc to use some
Guido van Rossum added the comment:
Thanks again! Merged to 3.5 and 3.6 (after cleaning up trailing whitespace --
again ;-).
--
resolution: -> fixed
stage: -> resolved
status: open -> closed
___
Python tracker
<http://bugs.python.or
Guido van Rossum added the comment:
I only have a Mac to test -- does anyone else on this issue have a Linux system
to try to reproduce this?
--
___
Python tracker
<http://bugs.python.org/issue27
Guido van Rossum added the comment:
NM I get the same on Mac after rebuilding from scratch. I can repro this with
the 3.5 branch too. Wonder if something changed in asyncio?
--
versions: +Python 3.5
___
Python tracker
<http://bugs.python.
Guido van Rossum added the comment:
Yury this smells of something in async/await?
--
assignee: -> yselivanov
___
Python tracker
<http://bugs.python.org/issu
Guido van Rossum added the comment:
Thanks Benjamin!
--
___
Python tracker
<http://bugs.python.org/issue27968>
___
___
Python-bugs-list mailing list
Unsubscribe:
Guido van Rossum added the comment:
I like fixing this. I suppose it'll be fixed for nonlocal too?
--
___
Python tracker
<http://bugs.python.org/is
Guido van Rossum added the comment:
+1 on getting this in. Who can help reviewing and merging before beta 1?
--
___
Python tracker
<http://bugs.python.org/issue27
Guido van Rossum added the comment:
+1 to add this to 3.6b1.
--
___
Python tracker
<http://bugs.python.org/issue15767>
___
___
Python-bugs-list mailing list
Unsub
Guido van Rossum added the comment:
That sounds a fine solution (except the elif should just test for `in
'typing'`). Can one of you prepare a patch? I think it should be fine
to fix this in 3.5 as well.
There should be a unit tes
Guido van Rossum added the comment:
I've lost you -- why don't you upload a patch?
--
___
Python tracker
<http://bugs.python.org/issue27989>
___
___
Guido van Rossum added the comment:
I strongly prefer to have it as a separate patch (either before or
after) to avoid the appearance of piggy-backing this in with a much
larger change.
--
___
Python tracker
<http://bugs.python.org/issue27
Guido van Rossum added the comment:
Hey Ivan, Brett and I divided the review, he started at the bottom and I
started at the top, we're meeting at Lib/typing.py.
--
___
Python tracker
<http://bugs.python.org/is
Guido van Rossum added the comment:
I played with the REPL, and found this:
>>> del __annotations__
del __annotations__
>>> x: int = 0
x: int = 0
Traceback (most recent call last):
File "", line 1, in
NameError: __annotations__ not found
>>>
I would exp
Guido van Rossum added the comment:
Each statement at the REPL should re-initialize __annotations__ if it
contains any annotations. I think this is how exec() already works. It
adds __annotations__ to the namespace as needed, but just updates it
if present. Inside a class it's different,
Guido van Rossum added the comment:
Oh, dang, I misread the definition of _ClassVar. It's fine then!
Looking forward to the next installment.
--
___
Python tracker
<http://bugs.python.org/is
Guido van Rossum added the comment:
Yury will give you some help. Also, this patch no longer applies
cleanly to hg. :-(
--
___
Python tracker
<http://bugs.python.org/issue27
Guido van Rossum added the comment:
Ivan, I have no idea how to integrate your patch and Yury's. I only use
Mercurial here, I don't trust the github clone (how far behind is it?). Please
sort this out yourself. I am also going through the review on riet
Guido van Rossum added the comment:
(I've renamed the patches so they line up with the numbering in the code review
tool.)
--
___
Python tracker
<http://bugs.python.org/is
Guido van Rossum added the comment:
W00t! Thank Ivan for the code! And thanks Yury and Brett for the review.
--
___
Python tracker
<http://bugs.python.org/issue27
Guido van Rossum added the comment:
The PEPs repo is not on github. Please resubmit this patch as a PR at
https://github.com/python/peps. (Sorry for all the indirections to different
trackers.)
--
resolution: -> rejected
status: open ->
Guido van Rossum added the comment:
(And by "not" I meant "now". Sorry.)
--
___
Python tracker
<http://bugs.python.org/issue26982>
___
___
Pyt
Guido van Rossum added the comment:
I just deleted it, lest people try to report bugs here or make changes.
--
resolution: -> fixed
status: open -> closed
___
Python tracker
<http://bugs.python.org/i
Guido van Rossum added the comment:
(The reason for the removal is that development of this tool is moving
to https://github.com/ilevkivskyi/com2ann -- it was committed briefly
as part of the PEP 526 patch.)
On Fri, Sep 9, 2016 at 9:07 AM, Guido van Rossum wrote:
>
> Guido van Rossum add
Guido van Rossum added the comment:
I'll commit this.
--
assignee: docs@python -> gvanrossum
___
Python tracker
<http://bugs.python.org/issue27999>
___
_
Guido van Rossum added the comment:
Thanks again Ivan!
--
resolution: -> fixed
status: open -> closed
___
Python tracker
<http://bugs.python.org/i
Guido van Rossum added the comment:
Closing this issue in favor of the upstream one:
https://github.com/python/asyncio/issues/341
--
resolution: -> third party
status: open -> closed
___
Python tracker
<http://bugs.python.org/i
Changes by Guido van Rossum :
--
resolution: -> fixed
status: open -> closed
___
Python tracker
<http://bugs.python.org/issue28049>
___
___
Python-bugs-
Guido van Rossum added the comment:
Why? Do you have a dependency on these? None of them are documented.
Do you propose to document them just so we can mark them deprecated?
--
___
Python tracker
<http://bugs.python.org/issue28
Guido van Rossum added the comment:
No, you need to demonstrate that they are used (despite undocumented).
On Fri, Sep 9, 2016 at 2:26 PM, Matthias Klose wrote:
>
> Matthias Klose added the comment:
>
> Since the 3.6 cycle, these modules are regenerated for the build, so the
Guido van Rossum added the comment:
The modules should remain deleted for 3.6b1 so we can see if there are
actually any complaints -- if we get any we can consider restoring
them for b2. I fail to be convinced by the arguments against deletion
brought up so far -- the "evidence" produ
Guido van Rossum added the comment:
> That aspect of the change is clearly a bug fix
I am happy to *rule* that we can treat it as a bugfix, but I disagree
that it's *clearly* a bugfix. It's definitely debatable. This area of
the language is so obscure and so few people remember wh
Guido van Rossum added the comment:
The actual _futures module appears missing from your latest patch -- what's up
with that?
--
___
Python tracker
<http://bugs.python.org/is
Guido van Rossum added the comment:
Nick, if you feel like doing this, go ahead, either before or after
beta1 (but if you want to do it before please do it quickly).
(Off-topic: boy do I miss CI that triggers when you send a patch for review...)
On Sat, Sep 10, 2016 at 11:14 AM, Martin
Guido van Rossum added the comment:
Most things mentioned by Ben have been added (thanks Michael Lee!), but it
seems the 3.5 docs and the 3.6 docs have deviated more than they ought to. I
guess updating the 3.6 docs is more urgent because of the upcoming 3.6b1
release. I'll look
Guido van Rossum added the comment:
Thanks! Busy Saturday night, right? :-)
--
resolution: -> fixed
status: open -> closed
___
Python tracker
<http://bugs.python.org/i
Guido van Rossum added the comment:
I'll figure it out.
--
___
Python tracker
<http://bugs.python.org/issue26141>
___
___
Python-bugs-list mailing list
Guido van Rossum added the comment:
Thanks!
--
resolution: -> fixed
status: open -> closed
___
Python tracker
<http://bugs.python.org/issue26141>
___
___
Guido van Rossum added the comment:
Thanks! I can't review the whole thing, but I patched it in and tried running
the asyncio/examples/crawl.py example, like so:
$ ~/src/cpython36/python.exe examples/crawl.py xkcd.com -q
Exception RuntimeError('yield was used instead of yield fr
Guido van Rossum added the comment:
Thanks! I think you have a PEP update already waiting for me?
--
resolution: -> fixed
status: open -> closed
___
Python tracker
<http://bugs.python.org/i
Guido van Rossum added the comment:
Um, if I apply this to 3.5 it works, but if I then merge forward to 3.6
(default) I get merge conflicts. I'll have to sort that out tonight.
--
___
Python tracker
<http://bugs.python.org/is
Guido van Rossum added the comment:
Thanks! All set.
--
resolution: -> fixed
status: open -> closed
___
Python tracker
<http://bugs.python.org/i
Guido van Rossum added the comment:
Thanks! All set.
--
resolution: -> fixed
status: open -> closed
___
Python tracker
<http://bugs.python.org/i
Guido van Rossum added the comment:
Thanks! All set.
--
resolution: -> fixed
status: open -> closed
___
Python tracker
<http://bugs.python.org/i
Guido van Rossum added the comment:
Yeah, I am generally in favor of this. Just yesterday there was a bug report
(#28070) where someone claimed that the flags from r'(ix)A' were incorrect.
They were 96 and should be 98. (He was right, and it was fixed already.) The
way he had to
Guido van Rossum added the comment:
Yury: What do you think of the code? How solid is it? (The issue I found was
due to my own very recent changes to _blocking.)
Ned: Is it better to do this in 3.6b1 or to wait for 3.6b2?
--
nosy: +ned.deily
Guido van Rossum added the comment:
Yeah, let's do this in 3.6b2.
--
___
Python tracker
<http://bugs.python.org/issue26081>
___
___
Python-bugs-list m
Guido van Rossum added the comment:
Honestly I think it's better if this remains a "hidden" feature until we have
support for it in mypy. So let's wait for that.
--
___
Python tracker
<http://bug
Guido van Rossum added the comment:
This should probably wait until b1 is released; it looks like What's New is
mostly empty anyways. The release manager needs to focus on the release.
--
___
Python tracker
<http://bugs.python.org/is
Guido van Rossum added the comment:
Patch LGTM.
--
___
Python tracker
<http://bugs.python.org/issue28109>
___
___
Python-bugs-list mailing list
Unsubscribe:
Guido van Rossum added the comment:
I'll take the latter. Give me a sec.
--
___
Python tracker
<http://bugs.python.org/issue28109>
___
___
Python-bugs-list m
Guido van Rossum added the comment:
changeset: 103770:2c9e07db0ac4
tag: tip
parent: 103768:879bde95a456
parent: 103769:f9b22b1bec2d
user:Guido van Rossum
date:Tue Sep 13 09:27:07 2016 -0700
summary: Add text about PEP 526 to What's new in 3.6. I
Changes by Guido van Rossum :
--
nosy: -gvanrossum
___
Python tracker
<http://bugs.python.org/issue28055>
___
___
Python-bugs-list mailing list
Unsubscribe:
Changes by Guido van Rossum :
--
nosy: -gvanrossum
___
Python tracker
<http://bugs.python.org/issue28158>
___
___
Python-bugs-list mailing list
Unsubscribe:
Changes by Guido van Rossum :
--
nosy: -gvanrossum
___
Python tracker
<http://bugs.python.org/issue26182>
___
___
Python-bugs-list mailing list
Unsubscribe:
Guido van Rossum added the comment:
Sorry, we didn't get to this. @Yury, do you think you could get to this before
b1 goes out? It's a pure optimization (and a good one!).
--
___
Python tracker
<http://bugs.python.o
Guido van Rossum added the comment:
(Of course I meant b2.)
--
___
Python tracker
<http://bugs.python.org/issue27906>
___
___
Python-bugs-list mailing list
Unsub
Guido van Rossum added the comment:
Maybe with the new code it could log a message if it doesn't exit the
loop via a break? Because that would mean the listen buffer is full.
It would encourage people to configure a larger number.
--
___
P
Changes by Guido van Rossum :
--
nosy: -gvanrossum
___
Python tracker
<http://bugs.python.org/issue27391>
___
___
Python-bugs-list mailing list
Unsubscribe:
Guido van Rossum added the comment:
Hm, maybe the list should just removed and only the link to the wiki preserved?
Agreed that the list here feels outdated. And updating it is always going to be
a political game (e.g. why isn't Wing IDE listed?)
--
nosy: +gvanr
Guido van Rossum added the comment:
You did the right thing. Check out the "review" link.
--
___
Python tracker
<http://bugs.python.org/issue26149>
___
___
Guido van Rossum added the comment:
Can you please supply a complete example?
--Guido (mobile)
--
___
Python tracker
<http://bugs.python.org/issue28212>
___
___
Changes by Guido van Rossum :
--
nosy: +asvetlov
___
Python tracker
<http://bugs.python.org/issue28213>
___
___
Python-bugs-list mailing list
Unsubscribe:
Changes by Guido van Rossum :
--
nosy: -gvanrossum
___
Python tracker
<http://bugs.python.org/issue28212>
___
___
Python-bugs-list mailing list
Unsubscribe:
Guido van Rossum added the comment:
Nice!
--
___
Python tracker
<http://bugs.python.org/issue27998>
___
___
Python-bugs-list mailing list
Unsubscribe:
Guido van Rossum added the comment:
Fixed by 09cc43df4509.
--
resolution: -> fixed
status: open -> closed
___
Python tracker
<http://bugs.python.org/i
Guido van Rossum added the comment:
Fixed by 09cc43df4509.
--
resolution: -> fixed
status: open -> closed
___
Python tracker
<http://bugs.python.org/i
Guido van Rossum added the comment:
Fixed by 09cc43df4509.
--
nosy: +gvanrossum
resolution: -> fixed
status: open -> closed
___
Python tracker
<http://bugs.python.org/i
Guido van Rossum added the comment:
I wonder if we shouldn't close this as "won't fix" and tell the OP to override
the log_message() method. It's kind of curious to complain about *this*
dependency on sys.stderr existing and working, since there are probably 1000
Guido van Rossum added the comment:
A problem with switching to logging is the API design.
There are three functions, log_request(), log_error() and
log_message(). The former two call the latter. The API explicitly
encourages overriding log_message() to customize logging. But it has
no way to
Guido van Rossum added the comment:
Ben Bangert reported to me that this crash caused instabilities in an app using
asyncio (https://github.com/home-assistant/home-assistant/issues/3453). This
hack made his crashes go away:
https://github.com/home-assistant/home-assistant/commit
Guido van Rossum added the comment:
Sorry about that. I haven't looked into this but I suspect this is due to some
manipulation of the ABC registry by typing.py that exceed their intended scope.
I'll ask Ivan to fix it; if he's not available before b2 goes out I
Guido van Rossum added the comment:
Serhiy -- please do what do you think we should do. At this point I'm open to
just about anything, but I don't feel comfortable creating or reviewing patches
any more.
--
assignee: gvanrossum -> ser
Guido van Rossum added the comment:
Offline, Ivan and I have discussed a solution. We can make a small incision in
typing.py that will fix this, at the cost of still allowing
isinstance()/issubclass()). We also have a slightly better quick fix in mind.
Ultimately we will have a more complex
Guido van Rossum added the comment:
I have merged the upstream fix (and some other things) into 3.5, 3.6, 3.7.
changeset: 104262:7f0d27180b6d
tag: tip
parent: 104259:36b052adf5a7
parent: 104261:0e0189b47291
user:Guido van Rossum
date:Mon Oct 03 08:42:17 2016
Guido van Rossum added the comment:
It went back and forth. The current feeling is to *keep* that support,
especially since their deprecation on Windows has been *undone* in
3.6. Feel free to update the title (though the initial comments may be
harder to understand without the context of the
Guido van Rossum added the comment:
It's pretty perverse. But how would you detect this case? Does it
require changes to CPython or only to asyncio? Does it require a spec
change anywhere?
--
___
Python tracker
<http://bugs.python.org/is
Guido van Rossum added the comment:
Is that enough? What if the recursion involves several tasks waiting
for each other in a cycle?
--
___
Python tracker
<http://bugs.python.org/issue27
Guido van Rossum added the comment:
Maybe it could be fixed rather than making this a checked failure?
--
___
Python tracker
<http://bugs.python.org/issue27
Guido van Rossum added the comment:
I've meditated on this and I've changed my mind. A task that awaits
itself is so obviously not following the task protocol that it should
be shot on sight. No exceptions. (Only the task itself should ever set
the result or exception, and *only* by re
Guido van Rossum added the comment:
LGTM. I have a small number of nits that I will apply when merging this.
--
___
Python tracker
<http://bugs.python.org/issue28
Changes by Guido van Rossum :
--
resolution: -> fixed
status: open -> closed
___
Python tracker
<http://bugs.python.org/issue28388>
___
___
Python-bugs-
Guido van Rossum added the comment:
Fixed by the changes for issue #28388.
--
nosy: +gvanrossum
resolution: -> fixed
status: open -> closed
___
Python tracker
<http://bugs.python.org/i
Guido van Rossum added the comment:
Making it a deferred release blocker so we're reminded to do the more thorough
fix before 3.6.0 rc1.
--
priority: release blocker -> deferred blocker
___
Python tracker
<http://bugs.python.org
Guido van Rossum added the comment:
Oh the line
ByteString.register(type(memoryview(b'')))
should be removed from typing.py.
--
priority: deferred blocker -> release blocker
___
Python tracker
<http://bugs.pytho
Guido van Rossum added the comment:
Maybe this fix helps? I tried your repro and it no longer fails.
--
___
Python tracker
<http://bugs.python.org/issue28
Guido van Rossum added the comment:
So is a larger fix not necessary? If so we can close this (assuming
the tests now pass).
--
___
Python tracker
<http://bugs.python.org/issue28
Guido van Rossum added the comment:
Hm. I agree that _getframe() is horrible. But I'm not sure I want code outside
typing.py to be aware of __origin__.
--
priority: release blocker -> deferred blocker
___
Python tracker
<http://bugs
Changes by Guido van Rossum :
--
nosy: -gvanrossum
___
Python tracker
<http://bugs.python.org/issue28414>
___
___
Python-bugs-list mailing list
Unsubscribe:
Guido van Rossum added the comment:
OK, this seems to work for me. I'm, applying this to 3.5, 3.6 and 3.7 (default).
--
nosy: +gvanrossum
___
Python tracker
<http://bugs.python.org/is
Guido van Rossum added the comment:
I applied this to 3.5, 3.6 and 3.7. I'm not sure we should also apply this to
2.7 -- optinions? Bug or feature?
--
versions: +Python 3.5
___
Python tracker
<http://bugs.python.org/is
Guido van Rossum added the comment:
OK will do.
--
___
Python tracker
<http://bugs.python.org/issue24452>
___
___
Python-bugs-list mailing list
Unsubscribe:
Guido van Rossum added the comment:
Thanks everyone! Applied to 2.7, so closing as fixed now.
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
type: -> behavior
___
Python tracker
<http://bugs.python
5401 - 5500 of 5563 matches
Mail list logo
