Changes by Guido van Rossum:
--
priority: -> low
__
Tracker <[EMAIL PROTECTED]>
<http://bugs.python.org/issue1317>
__
___
Python-bugs-list mailing list
Uns
Guido van Rossum added the comment:
Let's not get overexcited. I agree that it makes sense for fileinput,
but I disagree about *StringIO; its close() isn't needed to free
resources (since it doesn't use up a scarce resource like a file
descriptor).
Can you whip up a patch for fil
Guido van Rossum added the comment:
Committed revision 58639.
You're welcome, Thomas.
And Thanks, Amaury! Keep them coming...!
--
assignee: theller -> gvanrossum
resolution: -> accepted
status: open -> closed
__
Tracker <[EMAIL
Guido van Rossum added the comment:
Georg, can you check this in even with test_str failing?
And who is working on that? If I don't get a name I'll tackle it myself.
--
assignee: gvanrossum -> georg.brandl
__
Tracker <[EMAIL P
Guido van Rossum added the comment:
I like Chris's patch better, but he should use (sizeof(lower)-1) instead
of 8, and he should use the TOLOWER macro from bytes_methods.h.
Please submit a new one and I'll check it in!
--
priority: -> normal
_
Guido van Rossum added the comment:
Looks good. Can you check it in?
__
Tracker <[EMAIL PROTECTED]>
<http://bugs.python.org/issue1319>
__
___
Python-bugs-list mailing list
Guido van Rossum added the comment:
2007/10/15, Christian Heimes <[EMAIL PROTECTED]>:
>
> Christian Heimes added the comment:
>
> Guido van Rossum wrote:
> > BTW we need a 2to3 fixer for this. Should be trivial -- just replace
> > *all* occurrences of basestring wi
Guido van Rossum added the comment:
We won't be doing it this way.
--
resolution: remind -> rejected
status: open -> closed
__
Tracker <[EMAIL PROTECTED]>
<http://bugs.
Guido van Rossum added the comment:
Phillip, do you have any interest left in moving PEP 3124 forward?
--
assignee: gvanrossum -> pje
nosy: +pje
__
Tracker <[EMAIL PROTECTED]>
<http://bugs.python.o
Guido van Rossum added the comment:
OK, that's fine.
__
Tracker <[EMAIL PROTECTED]>
<http://bugs.python.org/issue1004>
__
___
Python-bugs-list mailing list
U
Changes by Guido van Rossum:
--
nosy: -gvanrossum
__
Tracker <[EMAIL PROTECTED]>
<http://bugs.python.org/issue1322>
__
___
Python-bugs-list mailing list
Unsubs
Guido van Rossum added the comment:
2007/10/25, Yitz Gale <[EMAIL PROTECTED]>:
> I was actually bitten badly by this issue with
> StringIO. I added fileinput only as an afterthought.
>
> In an xml.sax app, I needed seek() support for a
> codec-wrapped file handle, so I
Guido van Rossum added the comment:
Christian can you revise your patch to also remove os.tmpfile per
Martin's request? Make sure unit tests and docs are fixed too.
__
Tracker <[EMAIL PROTECTED]>
<http://bugs.python
Guido van Rossum added the comment:
2007/10/25, Christian Heimes <[EMAIL PROTECTED]>:
> I can do that for you. But I still believe that os.tmpfile() works
> different than tempfile.mkstemp(). The former returns a file descriptor
> of a file w/o directory entry and the
Guido van Rossum added the comment:
Committed revision 58657.
Thanks!
--
resolution: -> accepted
status: open -> closed
__
Tracker <[EMAIL PROTECTED]>
<http://bugs.pytho
Guido van Rossum added the comment:
Looks fine to me.
Committed revision 58658.
--
nosy: +gvanrossum
resolution: -> accepted
status: open -> closed
__
Tracker <[EMAIL PROTECTED]>
<http://bugs.pytho
Guido van Rossum added the comment:
Committed revision 58659.
I'm sorry I confused you; I was fine with the version that has char
lower[N] but I wanted you to not repeat N-1 later in the code. See what
I checked in. :-)
--
resolution: -> accepted
status: open -
Changes by Guido van Rossum:
--
assignee: -> gvanrossum
keywords: +patch, py3k
__
Tracker <[EMAIL PROTECTED]>
<http://bugs.python.org/issue1330>
__
___
Python-bu
Guido van Rossum added the comment:
While I like fixing the position restore in _fileio.c, I also liked
Amaury's flush() call in _BufferedIOMixin. Perhaps you can keep that
part (while losing the position restore)?
__
Tracker <[EMAIL PROTECTED
Guido van Rossum added the comment:
Tested on OSX as well. Thanks!!
Committed revision 58662.
--
assignee: -> gvanrossum
keywords: +patch, py3k
resolution: -> accepted
status: open -> closed
__
Tracker <[EMAIL PROTECTED]>
<http
Guido van Rossum added the comment:
Committed revision 58673.
I made one change, hopefully I didn't screw it up: skip the positional
restore if the truncation itself failed. Otherwise the positional
restore might overwrite the error from the truncation. After an error
from this function
Guido van Rossum added the comment:
Committed revision 58674.
I added a change to _abcoll.py to remove the registration of bytes as a
subclass of Iterable.
--
resolution: -> accepted
status: open -> closed
__
Tracker <[EMAIL PROTECTE
Guido van Rossum added the comment:
If you submit a patch that adds docs and a unit test, your wish will be
fulfilled.
--
nosy: +gvanrossum
__
Tracker <[EMAIL PROTECTED]>
<http://bugs.python.org/
Guido van Rossum added the comment:
Please submit a patch for docs and a unittest...
--
nosy: +gvanrossum
__
Tracker <[EMAIL PROTECTED]>
<http://bugs.python.org/
Guido van Rossum added the comment:
Can you provide a very small shared library that demonstrates this
problem? (E.g. you could start by modifying Modules/xxmodule.c, adding a
'destructor' function.)
--
nosy: +gvanrossum
__
Tracker <[EM
Guido van Rossum added the comment:
Can't you force a BOM by simply writing \ufffe at the start of the file?
--
nosy: +gvanrossum
__
Tracker <[EMAIL PROTECTED]>
<http://bugs.python
Guido van Rossum added the comment:
Can you step through it with a C/C++ debugger to see where it goes wrong?
--
nosy: +gvanrossum
__
Tracker <[EMAIL PROTECTED]>
<http://bugs.python.org/
Guido van Rossum added the comment:
You missed urllib2 I think. :-)
I agree it's a mess. I'm sure it all started out with backwards
compatibility in mind. I find myself often importing cgi only to use
the tiny function escape() that is defined there...
I wonder if web-sig wouldn&#
Guido van Rossum added the comment:
I don't think we can prevent GC from occurring between fork and exec --
it's legal to just call os.fork() and execute Python code in the
subprocess forever. I think the right solution might be to ignore
errors in file_close(). Can you try to whip
Guido van Rossum added the comment:
Setting to 'high' everything related to PEP 3137.
--
priority: -> high
__
Tracker <[EMAIL PROTECTED]>
<http://bug
New submission from Guido van Rossum:
Alexandre Vassalotti suggested the following:
A simple way to add specific pickling support for bytes/buffer objects
would be to define two new constants:
BYTES = b'\x8c' # push a bytes object
BUFFER = b'\x8d' #
Guido van Rossum added the comment:
> Disabling Python's emulated InterlockedCompareExchange (for Win95
> compatibility) cures the problem, so the underlying question is why the
> existence of InterlockedCompareExchange is not being autodetected on 64
> bit systems -- and t
Guido van Rossum added the comment:
If you can, please submit a patch that fixes all those issues, with
unit tests and doc changes if at all possible. That will make it much
easier to evaluate the ramifications of your proposal(s).
__
Tracker <[EMAIL PROTEC
Guido van Rossum added the comment:
> Here is the same file with an #if to use to Py_AtExit or destructor case.
> Please us this one instead of the earlier one.
>
> Added file: http://bugs.python.org/file8622/dlibtest.c
I can build it just fine on Ubuntu dapper, but I can't run
Guido van Rossum added the comment:
OK, confirmed. But no insignt in what happened yet... Do you know where
the atexit stuff happens in 2.5?
__
Tracker <[EMAIL PROTECTED]>
<http://bugs.python.org/
Changes by Guido van Rossum:
Removed file: http://bugs.python.org/file8620/dlibtest.c
__
Tracker <[EMAIL PROTECTED]>
<http://bugs.python.org/issue1329>
__
___
Python-bugs-
Guido van Rossum added the comment:
> However, considering the severity of this problem
> (threading.Lock.acquire(0) broken on 64-bit Windows), what do you think
> about issuing a 2.5.2 maintenance release?
Neal Norwitz and Anthony Baxter have been planning to release 2.5.2
for a
Guido van Rossum added the comment:
So is there even a bug? Arguably you shouldn't be writing anything that
late in the life of a shared library.
__
Tracker <[EMAIL PROTECTED]>
<http://bugs.python
Changes by Guido van Rossum:
--
assignee: -> gvanrossum
__
Tracker <[EMAIL PROTECTED]>
<http://bugs.python.org/issue1340>
__
___
Python-bugs-list mailing li
Guido van Rossum added the comment:
Committed revision 58699. (My own interpretation of the patch, with
comment :-)
I expect this will fix a bunch Windows failures; I've seen complaints
inmplicating doubled newlines in a few places, and this mught just be
the cause. T
Guido van Rossum added the comment:
D'oh, I submitted to the wrong branch. The py3k branch will have to
wait until after my son's birthday party. ;-)
--
status: closed -> open
__
Tracker <[EMAIL PROTECTED]>
<http://bug
Guido van Rossum added the comment:
Right. I think the right solution is to add an option to _FileIO that
says "don't close the filedescriptor when close() is called". This
option should only be allowed when the "filename" argument is an
integer file descriptor. It sh
Guido van Rossum added the comment:
New Revision: 58701.
--
status: open -> closed
__
Tracker <[EMAIL PROTECTED]>
<http://bugs.python.org/issue1340>
__
___
P
Guido van Rossum added the comment:
I don't think that patch is the right thing either. Certainly the
comment on the line you're proposing to delete is suggesting that the
close() call was added for a reason.
--
nosy: +gvanrossum
__
Track
Guido van Rossum added the comment:
Looks good, though I can't find anything that would test this.
Can you check this in yourself?
--
assignee: nnorwitz -> janssen
nosy: +gvanrossum
__
Tracker <[EMAIL PROTECTED]>
<http://bugs.pyt
Guido van Rossum added the comment:
Are you sure this is the proper fix? Why does netrc.py insist on not
having \r\n line endings? It opens the file in text mode so I don't
quite understand your patch.
--
nosy: +gvanrossum
__
Tracker <[EMAIL P
Guido van Rossum added the comment:
Looks good. You can check this in yourself right?
--
assignee: -> janssen
nosy: +gvanrossum
resolution: -> accepted
__
Tracker <[EMAIL PROTECTED]>
<http://bugs.pytho
Guido van Rossum added the comment:
Thanks, good catch!
Committed revision 58704.
(in the py3k branch)
--
nosy: +gvanrossum
resolution: -> accepted
status: open -> closed
__
Tracker <[EMAIL PROTECTED]>
<http://bugs.pytho
Guido van Rossum added the comment:
You'll get more traction on this if you submit a patch.
--
nosy: +gvanrossum
__
Tracker <[EMAIL PROTECTED]>
<http://bugs.python
Guido van Rossum added the comment:
Committed revision 58706.
This is in the trunk, i.e. what will become Python 2.6. I don't think
it's worth fixing in 2.5.2, but if you really think it should go there
as well, petition Neal Norwitz.
--
nosy: +gvanrossum
resolution: -
Guido van Rossum added the comment:
If this report is simply due to the lack of certain required packages,
can it just be closed as invalid?
--
nosy: +gvanrossum
__
Tracker <[EMAIL PROTECTED]>
<http://bugs.python.org/
Changes by Guido van Rossum:
--
assignee: -> gvanrossum
__
Tracker <[EMAIL PROTECTED]>
<http://bugs.python.org/issue1329>
__
___
Python-bugs-list mailing li
Guido van Rossum added the comment:
Thanks!!
The patch as given doesn't quite work -- it gives an error message on
string literals like '\s'. By reverting some of your code and only
keeping the bounds checks for the octal escape code I got it to work
though. See my chec
Guido van Rossum added the comment:
Closing.
The make fatal error is just what make prints when a command fails with
a nonzero exit code; regrtest.py returns a nonzero exit code to the
shell for just this purpose.
--
resolution: -> invalid
status: open ->
Changes by Guido van Rossum:
--
priority: normal -> high
__
Tracker <[EMAIL PROTECTED]>
<http://bugs.python.org/issue1171>
__
___
Python-bugs-list mailing li
Changes by Guido van Rossum:
--
assignee: -> gvanrossum
priority: -> high
__
Tracker <[EMAIL PROTECTED]>
<http://bugs.python.org/issue1352>
__
___
Python-bugs
Changes by Guido van Rossum:
--
resolution: -> accepted
status: open -> closed
__
Tracker <[EMAIL PROTECTED]>
<http://bugs.python.org/issue1356>
__
___
Python
Guido van Rossum added the comment:
Better fix:
Committed revision 58708.
__
Tracker <[EMAIL PROTECTED]>
<http://bugs.python.org/issue1359>
__
___
Python-bugs-list
Guido van Rossum added the comment:
(Hold on, the assert I added triggers in debug mode.)
--
status: closed -> open
__
Tracker <[EMAIL PROTECTED]>
<http://bugs.python.o
Guido van Rossum added the comment:
I'm -1 myself. I've rarely needed this -- if I wanted to know the size,
I was almost always going to read the data into memory anyway, so why
not just read it and then ask how much you got? For files on the
filesystem there's os.path.getsiz
Guido van Rossum added the comment:
Good idea.
Are there any places where PyBytes or PyString are written to stderr?
Or can you get away with just supporting PyUnicode?
It's "dumb", not "dump".
I wouldn't explicitly remove the old stderr printer -- it will b
Changes by Guido van Rossum:
--
status: open -> closed
__
Tracker <[EMAIL PROTECTED]>
<http://bugs.python.org/issue1359>
__
___
Python-bugs-list mailing list
Uns
Guido van Rossum added the comment:
Thanks!! Code review:
Shouldn't closefd be passed as 1 in import.c?
I don't see the point of distinguishing between -1 and +1. The block
"if (closefd < 0) { closefd = 1; }" looks rather silly.
In io.py, you should document that cl
Guido van Rossum added the comment:
This (and the other issue you mention) is because the regular acquire()
method on a basic lock cannot be interrupted. That's unlikely to go
away, so you'll just have to live with this. As you've discovered,
specifying a timeout solves the iss
Guido van Rossum added the comment:
This is because the regular acquire() method on a basic lock cannot be
interrupted. That's unlikely to go away, so you'll just have to live
with this. As you've discovered, specifying a timeout solves the issue
(sort of).
--
no
Guido van Rossum added the comment:
Thanks for testing on Leopard! I haven't gotten that yet.
Assigning to Neal since this ought to be fixed before 2.5.2 is released.
(But someone needs to come up with a proper patch.)
--
assignee: -> nnorwitz
nosy: +gvanrossum, nnorwitz
Guido van Rossum added the comment:
OK, thanks. The closefd part is good, but the stderrprinter part has a
problem. On Linux, in a non-debug build, this has the odd side effect
of subtracting one from sys.maxunicode. In a debug build, it dies like
this:
$ ./python -S
python: Modules
Guido van Rossum added the comment:
I've checked the closefd patch (which minor changes) into the py3k branch.
Committed revision 58711.
Please take the stdprinter patch to the original issue (bug 1352).
--
resolution: -> accepted
status: open -
Guido van Rossum added the comment:
I've checked in the patch you added to issue 1329, with one mod: where
you wrote "int fd : 1;" I removed the ": 1" since a field width of one
bit makes no sense here.
--
resolution: -> acc
Guido van Rossum added the comment:
Thanks, I've closed issue 1352 too now.
__
Tracker <[EMAIL PROTECTED]>
<http://bugs.python.org/issue1329>
__
___
Python-bugs-
Guido van Rossum added the comment:
In Python, you can't raise an exception from file_dealloc. (Note how
it is a void function -- there's no way to return an error status.)
Disabling gc however makes sense. I'll think about that. Since you
seem to have the only reproducible occ
Guido van Rossum added the comment:
Fixed by Christian Heimes's patch, see issue 1352 and issue 1329.
--
nosy: +gvanrossum
resolution: -> fixed
status: open -> closed
_
Tracker <[EMAIL PROTECTED]>
<http://bugs.pyt
Guido van Rossum added the comment:
Committed revision 58730.
Thanks!
PS. Christian, please work with Neal or Martin to get developer
privileges...
--
resolution: -> accepted
status: open -> closed
__
Tracker <[EMAIL PROTECTED]>
<http://
Guido van Rossum added the comment:
I've submitted the 'harmless' patch (and much, much more) in r58741.
I'm closing this now, the rest probably has been implemented one way or
another as well. If you see something I missed, please open a new issue
with a patch
Changes by Guido van Rossum:
--
resolution: -> invalid
status: open -> closed
__
Tracker <[EMAIL PROTECTED]>
<http://bugs.python.org/issue1367>
__
___
Python
Guido van Rossum added the comment:
Looks good to me.
--
nosy: +gvanrossum
_
Tracker <[EMAIL PROTECTED]>
<http://bugs.python.org/issue1663329>
_
___
Pyth
Guido van Rossum added the comment:
This makes more sense as a 3rd party library.
--
nosy: +gvanrossum
status: pending -> closed
_
Tracker <[EMAIL PROTECTED]>
<http://bugs.python.org/
Guido van Rossum added the comment:
No clear problem, no patch.
--
nosy: +gvanrossum
resolution: -> wont fix
status: open -> closed
_
Tracker <[EMAIL PROTECTED]>
<http://bugs.python.o
Guido van Rossum added the comment:
Georg, could you explain somewhere in the tracker docs linked from the
tracker side bar what the options are? I looked into giving Christian
more tracker privileges before, but I didn't know what to type in the
Roles box. IOW I don't know what the
New submission from Guido van Rossum:
In Lib/bsddb/test/test_misc.py in the py3k branch I had to disable two
test in order to make progress on a mega-merge from the trunk.
The tests are test01_badpointer and test04_double_free_make_key_dbt. I
commented them out by inserting "## " i
Changes by Guido van Rossum:
--
type: -> crash
__
Tracker <[EMAIL PROTECTED]>
<http://bugs.python.org/issue1371>
__
___
Python-bugs-list mailing list
Uns
Changes by Guido van Rossum:
--
severity: normal -> major
__
Tracker <[EMAIL PROTECTED]>
<http://bugs.python.org/issue1370>
__
___
Python-bugs-list mailing li
Guido van Rossum added the comment:
Hm, what happened to Doc/using? Should that perhaps also be submitted?
__
Tracker <[EMAIL PROTECTED]>
<http://bugs.python.org/issue1370>
__
__
Guido van Rossum added the comment:
On 11/1/07, Georg Brandl <[EMAIL PROTECTED]> wrote:
>
> Georg Brandl added the comment:
>
> I noted that too, should be in the repos now.
Thanks! And thanks for fixing up my mess so quickly!!
__
Tracker
Guido van Rossum added the comment:
I trust that there's a problem, but this can't be right -- the address
of r_strlen is passed to PyArg_ParseTuple corresponding to an 'i' format
letter. That will never do.
--
assignee: -> nnorwitz
nosy
Guido van Rossum added the comment:
Committed revision 58774.
Thanks!!!
--
nosy: +gvanrossum
resolution: -> accepted
status: open -> closed
__
Tracker <[EMAIL PROTECTED]>
<http://bugs.pytho
Guido van Rossum added the comment:
> http://wiki.python.org/moin/TrackerAccessControl
>
> which specifies all permissions in the tracker in detail.
Is it so that Anonymous < User < Developer < Coordinator? If so, the
role field could just be a dropdown instead
Guido van Rossum added the comment:
Yes I did, in r58709, in the trunk.
Please backport to 2.5.2.
--
assignee: gvanrossum ->
__
Tracker <[EMAIL PROTECTED]>
<http://bugs.python.o
Guido van Rossum added the comment:
Also r58708 and r58707 in the py3k-pep3137 branch.
See also bug 1359.
__
Tracker <[EMAIL PROTECTED]>
<http://bugs.python.org/issue1098>
__
__
Guido van Rossum added the comment:
This has been superseded by PEP 3137 and the work I've done in the
py3k-pep3137 branch.
--
resolution: -> out of date
status: open -> closed
__
Tracker <[EMAIL PROTECTED]>
<http://bugs.
Guido van Rossum added the comment:
Fix for all issues committed as revision 58815 (in the py3k branch).
The strlen() check is replaced by something saner.
Thanks for reminding me!
--
resolution: -> fixed
status: open -> closed
_
Tracker &
Guido van Rossum added the comment:
And in the py3k branch as well (r57504).
I'll work on the others and on a fix for the "this is buggy" thing.
_
Tracker <[EMAIL PROTECTED]>
<http://bugs
New submission from Guido van Rossum:
Error output:
[EMAIL PROTECTED]/testtest test_import failed -- Traceback (most
recent call last): File
"/usr/local/google/home/guido/python/py3k-main/Lib/test/test_import.py",
line 184, in test_sys_path_with_unicodemod =
__import__(&qu
Guido van Rossum added the comment:
Committed revision 58819.
--
resolution: -> accepted
status: open -> closed
__
Tracker <[EMAIL PROTECTED]>
<http://bugs.pytho
Guido van Rossum added the comment:
You misunderstand. The try/except is there in case os.stat isn't defined
or its result doesn't have a st_mode attribute. If the stat operation
fails due to a problem with the file, there's not much point in proceeding
since the subsequent op
Changes by Guido van Rossum:
Removed file: http://bugs.python.org/file8681/unnamed
__
Tracker <[EMAIL PROTECTED]>
<http://bugs.python.org/issue1372>
__
___
Python-bugs-list
Guido van Rossum added the comment:
The correct format for a Py_ssize_t is 'n' (at least in the trunk, I
don't have the 2.5 branch handy but I imagine it's the same).
We can figure out the patch from here.
__
Tracker <[EMAIL PROTECTED]&g
Changes by Guido van Rossum:
--
nosy: +gvanrossum
__
Tracker <[EMAIL PROTECTED]>
<http://bugs.python.org/issue1378>
__
___
Python-bugs-list mailing list
Unsubs
Guido van Rossum added the comment:
I'll look at the patches later, but we've gone over this before on the
list. str() of *any* object needs to return *something*. Yes, it's
unfortunate that this masks bugs in the transitional period, but it
really is the best thing in the long ru
Guido van Rossum added the comment:
No -- making str(b) return b.decode("ascii") brings back the same issues
we had with mindlessly mixing PyString and PyUnicode in 2.x. That was a
major disaster.
--
status: open ->
__
Tracker <[EMAIL P
501 - 600 of 5563 matches
Mail list logo
