[issue42990] Improve the C code for calling Python code: _PyEval_EvalCode()

2021-02-18 Thread Guido van Rossum
Guido van Rossum added the comment: Victor > the new globals has no "__builtins__" key. This change is backward > incompatible on purpose. If someone really wants to run a function in a > different builtins namespace, globals['__builtins__'] must be set explici

[issue42840] `type` takes **kwargs for __init_subclass__

2021-02-18 Thread Guido van Rossum
Guido van Rossum added the comment: I'll try to review it in the coming weeks. -- ___ Python tracker <https://bugs.python.org/issue42840> ___ ___ Pytho

[issue43257] get_type_hints evaluates class variables before type hints

2021-02-19 Thread Guido van Rossum
Guido van Rossum added the comment: Sure looks like a compiler bug! Can you investigate whether this occurs in earlier Python versions? Maybe bisect if it doesn’t? -- ___ Python tracker <https://bugs.python.org/issue43

[issue43255] Ceil division with /// operator

2021-02-19 Thread Guido van Rossum
Change by Guido van Rossum : -- nosy: -gvanrossum ___ Python tracker <https://bugs.python.org/issue43255> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue37146] opcode cache for LOAD_GLOBAL emits false alarm in memory leak hunting

2021-02-19 Thread Guido van Rossum
Guido van Rossum added the comment: Please revert this and use a separate build flag (e.g. DISABLE_INLINE_CACHES) for the refleaks run. (Or perhaps provide an -X flag to disable it without the need to recompile.) I am developing new inline cache ideas and of course I need to run in debug

[issue42990] Improve the C code for calling Python code: _PyEval_EvalCode()

2021-02-19 Thread Guido van Rossum
Guido van Rossum added the comment: Thanks, that's clearer. I'm still worried about the change in semantics where globals["__builtins__"] is assigned a different dict after the function object has been created (similar to https://bugs.python.org/file49816/func_builtins2

[issue43271] AMD64 Windows10 3.x crash with Windows fatal exception: stack overflow

2021-02-19 Thread Guido van Rossum
Change by Guido van Rossum : -- nosy: +Mark.Shannon, gvanrossum ___ Python tracker <https://bugs.python.org/issue43271> ___ ___ Python-bugs-list mailin

[issue42128] Structural Pattern Matching (PEP 634)

2021-02-19 Thread Guido van Rossum
Guido van Rossum added the comment: I don't know who's really in charge of the docs. I suppose the PEP authors are, collectively, but that runs the risk that we're all expecting the person to our left in the circle to do it. Would people be okay if I added the tutorial from Ap

[issue42128] Structural Pattern Matching (PEP 634)

2021-02-19 Thread Guido van Rossum
Change by Guido van Rossum : -- pull_requests: +23368 pull_request: https://github.com/python/cpython/pull/24588 ___ Python tracker <https://bugs.python.org/issue42

[issue42128] Structural Pattern Matching (PEP 634)

2021-02-19 Thread Guido van Rossum
Guido van Rossum added the comment: > It's not a huge deal, but I vote that we either drop or rework the > "http_error" examples. I think it gives people a very wrong first impression > that makes the rest of the behavior quite surprising. > > Can it be cha

[issue42990] Improve the C code for calling Python code: _PyEval_EvalCode()

2021-02-19 Thread Guido van Rossum
Guido van Rossum added the comment: Thanks for the clarifications, Victor! So I now understand: the *identity* of the builtins dict used by a function's code is captured when the function object is created. And I understand why: it's so that in the fast path for the LOAD_GLOBAL

[issue43257] get_type_hints evaluates class variables before type hints

2021-02-19 Thread Guido van Rossum
Guido van Rossum added the comment: Oops, I realized it's not really a compiler bug. When the compiler sees class C: str: str = "abc" if effectively rearranges that to class C: str = "abc" __annotations__["str"] = str (where __annotations__ i

[issue42974] tokenize reports incorrect end col offset and line string when input ends without explicit newline

2021-02-19 Thread Guido van Rossum
Change by Guido van Rossum : -- nosy: -gvanrossum ___ Python tracker <https://bugs.python.org/issue42974> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue42128] Structural Pattern Matching (PEP 634)

2021-02-19 Thread Guido van Rossum
Guido van Rossum added the comment: Let's continue this at https://github.com/python/cpython/pull/24588 -- ___ Python tracker <https://bugs.python.org/is

[issue42128] Structural Pattern Matching (PEP 634)

2021-02-19 Thread Guido van Rossum
Guido van Rossum added the comment: Okay, I see. Clearly we should have kept the "DWIM" option, aka "If it starts with a capital letter, it's a value pattern." :-) -- ___ Python tracker <https:

[issue42128] Structural Pattern Matching (PEP 634)

2021-02-19 Thread Guido van Rossum
Guido van Rossum added the comment: But seriously, nothing good can come from social media. It's what drove me to retire in 2018. Just ignore it please. -- ___ Python tracker <https://bugs.python.org/is

[issue42128] Structural Pattern Matching (PEP 634)

2021-02-19 Thread Guido van Rossum
Guido van Rossum added the comment: Carol, the most urgent thing we have going is to come up with text for what's new. I posted a PR that adds my standard "quick" tutorial ( https://github.com/python/cpython/pull/24588) which is also found in Appendix A of PEP 636 (the tuto

[issue43278] unnecessary leading '\n' from Py_GetCompiler() when build with different complier

2021-02-21 Thread Guido van Rossum
Change by Guido van Rossum : -- nosy: -gvanrossum ___ Python tracker <https://bugs.python.org/issue43278> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue43146] 3.10a5 regression: AttributeError: 'NoneType' object has no attribute '__suppress_context__' in traceback.py

2021-02-23 Thread Guido van Rossum
Guido van Rossum added the comment: New changeset 26f18b8540b49d592af66361f8df1a03953d1768 by Irit Katriel in branch 'master': bpo-43146: fix regression in traceback.print_exception(None) (GH-24463) https://github.com/python/cpython/commit/26f18b8540b49d592af66361f8df1a

[issue43146] 3.10a5 regression: AttributeError: 'NoneType' object has no attribute '__suppress_context__' in traceback.py

2021-02-23 Thread Guido van Rossum
Guido van Rossum added the comment: Are you going to create a separate PR or a new issue for the other thing? (And what exactly *is* the other thing? Please summarize.) -- ___ Python tracker <https://bugs.python.org/issue43

[issue43146] 3.10a5 regression: AttributeError: 'NoneType' object has no attribute '__suppress_context__' in traceback.py

2021-02-23 Thread Guido van Rossum
Guido van Rossum added the comment: So the PR just merged fixes that, right? Color me confused. -- ___ Python tracker <https://bugs.python.org/issue43

[issue43146] 3.10a5 regression: AttributeError: 'NoneType' object has no attribute '__suppress_context__' in traceback.py

2021-02-23 Thread Guido van Rossum
Guido van Rossum added the comment: So the remaining question is what to do for print_exception(None)? Honestly the current (new) behavior of printing `NoneType: None` seems fine. -- ___ Python tracker <https://bugs.python.org/issue43

[issue43146] 3.10a5 regression: AttributeError: 'NoneType' object has no attribute '__suppress_context__' in traceback.py

2021-02-23 Thread Guido van Rossum
Guido van Rossum added the comment: New changeset b798ab06937f8bb24b444a49dd42e11fff15e654 by Irit Katriel in branch 'master': bpo-43146: fix None-handling in single-arg traceback.print_exception(None) (GH-24629) https://github.com/python/cpyt

[issue43281] Walrus comprehension rebind checking behavior

2021-02-26 Thread Guido van Rossum
Guido van Rossum added the comment: I'd like Emily to have a look at that. -- nosy: +emilyemorehouse ___ Python tracker <https://bugs.python.org/is

[issue41972] bytes.find consistently hangs in a particular scenario

2021-02-27 Thread Guido van Rossum
Guido van Rossum added the comment: If Tim approves we might get it into alpha 6 which goes out Monday. -- ___ Python tracker <https://bugs.python.org/issue41

[issue43345] Add __required_keys__ and __optional_keys__ to TypedDict documentation

2021-02-27 Thread Guido van Rossum
Guido van Rossum added the comment: New changeset 1e3c68246ee738b5ec5450b1eb39af2fca300cb9 by Paul Bryan in branch 'master': bpo-43345: Enhance TypedDict documentation. (#24668) https://github.com/python/cpython/commit/1e3c68246ee738b5ec5450b1eb39af

[issue43271] AMD64 Windows10 3.x crash with Windows fatal exception: stack overflow

2021-02-28 Thread Guido van Rossum
Guido van Rossum added the comment: Thanks David! So the crash only happens in debug mode? PEP 651 promises to take reduce the C stack usage in the future. Therefore, I would be okay with rolling this back for the time being. If we do roll it back, maybe add a comment to ceval.c explaining

[issue42128] Structural Pattern Matching (PEP 634)

2021-02-28 Thread Guido van Rossum
Guido van Rossum added the comment: New changeset a22bca6b1e2f3dc11a58f3e5ef5c22e26b8a2d80 by Daniel F Moisset in branch 'master': bpo-42128: Add documentation for pattern matching (PEP 634) (#24664) https://github.com/python/cpython/commit/a22bca6b1e2f3dc11a58f3e5ef5c22

[issue43271] AMD64 Windows10 3.x crash with Windows fatal exception: stack overflow

2021-02-28 Thread Guido van Rossum
Guido van Rossum added the comment: Thanks! That's new info, at least, it wasn't clear to me from Victor's original comment that this was for a debug build (even though as you say it can be deduced from context). Do you feel like submitting a PR along the li

[issue43271] AMD64 Windows10 3.x crash with Windows fatal exception: stack overflow

2021-03-03 Thread Guido van Rossum
Guido van Rossum added the comment: New changeset 131d5516409791b170b09a6ef8ed8463c9b09015 by db3l in branch 'master': bpo-43271: Re-enable ceval.c optimizations for Windows debug builds (GH-24739) https://github.com/python/cpython/commit/131d5516409791b170b09a6ef8ed84

[issue43271] AMD64 Windows10 3.x crash with Windows fatal exception: stack overflow

2021-03-03 Thread Guido van Rossum
Guido van Rossum added the comment: Thanks for all your research and the PR! -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker <https://bugs.python.or

[issue43366] Unclosed bracket bug in code.interact prevents identifying syntax errors

2021-03-05 Thread Guido van Rossum
Guido van Rossum added the comment: Maybe we need to add an API (e.g. a flag to compile()) so that we can ask the actual parser the question we're interested in, rather than having to use hacks and heuristics? -- ___ Python tracker &

[issue29982] tempfile.TemporaryDirectory fails to delete itself

2021-03-07 Thread Guido van Rossum
Guido van Rossum added the comment: SGTM -- ___ Python tracker <https://bugs.python.org/issue29982> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue43463] typing.get_type_hints with TYPE_CHECKING imports / getting hints for single argument

2021-03-10 Thread Guido van Rossum
Guido van Rossum added the comment: Maybe return the original string? -- ___ Python tracker <https://bugs.python.org/issue43463> ___ ___ Python-bugs-list mailin

[issue27501] Add typing.py class describing a PEP 3118 buffer object

2020-05-19 Thread Guido van Rossum
Change by Guido van Rossum : -- nosy: +gvanrossum ___ Python tracker <https://bugs.python.org/issue27501> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue40731] CWI url's protocol on LICENSE file from http to https

2020-05-22 Thread Guido van Rossum
Guido van Rossum added the comment: It works just fine with http:// (redirects to https). Thanks for testing our workflow. It works just fine. -- resolution: -> not a bug stage: patch review -> resolved status: open -> closed ___ Pytho

[issue38605] [typing] PEP 563: Postponed evaluation of annotations: enable it by default in Python 3.10

2020-05-26 Thread Guido van Rossum
Guido van Rossum added the comment: - Double forward ref: IMO this can be resolved in the get_type_hints() functions. (Łukasz do you agree?) - inspect.signature(): Maybe this could switch to using typing.get_type_hints()? Then again if performance is important here maybe we cannot change

[issue40794] dataclass signatures and docstrings w/future-annotations

2020-05-27 Thread Guido van Rossum
Guido van Rossum added the comment: It,sounds like you are trying to get the effect of putting 'from __future__ import dataclasses' at the top of dataclasses'.py, right? Are you saying that without this, the output of the test sc

[issue40794] dataclass signatures and docstrings w/future-annotations

2020-05-27 Thread Guido van Rossum
Guido van Rossum added the comment: Have you come up with a fix yet? (Preferably a fix that can be applied locally to dataclasses.py.) -- ___ Python tracker <https://bugs.python.org/issue40

[issue40794] dataclass signatures and docstrings w/future-annotations

2020-05-27 Thread Guido van Rossum
Guido van Rossum added the comment: To clarify, for Eric: what Batuhan did is effectively adding `from __future__ import annotations` to the top of dataclasses.py. I believe the root cause is that dataclasses creates functions by synthesizing `def` statements (in _create_fn()) and the

[issue40794] dataclass signatures and docstrings w/future-annotations

2020-05-27 Thread Guido van Rossum
Guido van Rossum added the comment: You can do this as part of your mega-PR to turn on `from __future__ import annotations` by default. -- ___ Python tracker <https://bugs.python.org/issue40

[issue38605] [typing] PEP 563: Postponed evaluation of annotations: enable it by default in Python 3.10

2020-05-28 Thread Guido van Rossum
Guido van Rossum added the comment: I think in general it is more insightful to discuss the behavior of get_type_hints() given specific things in annotations. We generally don't write forward refs inside forward refs, like "SomeClass['int']". So maybe that code was

[issue38605] [typing] PEP 563: Postponed evaluation of annotations: enable it by default in Python 3.10

2020-05-28 Thread Guido van Rossum
Guido van Rossum added the comment: There will still be a lot of code written that way, because people need compatibility with earlier versions of Python. So I think it should be fixed in get_type_hints(). -- ___ Python tracker <ht

[issue22167] iglob() has misleading documentation (does indeed store names internally)

2020-05-31 Thread Guido van Rossum
Guido van Rossum added the comment: Serhiy, what do you mean by "otherwise we could run out of file descriptiors"? I looked a bit at the code and there are different kinds of algorithms involved for different forms of patterns, and the code also takes vastly different paths for

[issue22167] iglob() has misleading documentation (does indeed store names internally)

2020-05-31 Thread Guido van Rossum
Guido van Rossum added the comment: Hm, yeah. Perhaps we can add some buffering so that for directories with a small number of files (say < 1000) the FD is closed before recursing into it, while for large directories it keeps the FD open until the last block of 1000 DirEntries is read? I

[issue22167] iglob() has misleading documentation (does indeed store names internally)

2020-05-31 Thread Guido van Rossum
Guido van Rossum added the comment: I hope some volunteer will submit a doc PR. In the meantime, throwing out one more idea: perhaps my first idea, to make _glob1() an iterator, could work if we only do it for leaves of the pattern, so for the a*/b*/c* example, only for the c* part

[issue40847] New parser considers empty line following a backslash to be a syntax error, old parser didn't

2020-06-05 Thread Guido van Rossum
Guido van Rossum added the comment: Sure looks like a tokenizer issue to me. For example this is broken in both versions: pass \ pass It complains about an unexpected indent, but it should really be considered a blank line broken in two -- a backslash is supposed to just erase itself

[issue40897] Inheriting from Generic causes inspect.signature to always return (*args, **kwargs) for constructor (and all subclasses)

2020-06-07 Thread Guido van Rossum
Guido van Rossum added the comment: So does that make this "not a bug"? Or is there something to document? For technical reasons we can't just add a __init__ method to Generic, and I doubt that it's feasible to chan

[issue7105] weak dict iterators are fragile because of unpredictable GC runs

2020-06-07 Thread Guido van Rossum
Change by Guido van Rossum : -- nosy: -gvanrossum ___ Python tracker <https://bugs.python.org/issue7105> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue40902] Speed up PEG parser by using operator precedence for binary operators

2020-06-07 Thread Guido van Rossum
Guido van Rossum added the comment: I think this can wait until after beta 2. -- nosy: +gvanrossum ___ Python tracker <https://bugs.python.org/issue40

[issue40897] Inheriting from class that defines __new__ causes inspect.signature to always return (*args, **kwargs) for constructor

2020-06-08 Thread Guido van Rossum
Guido van Rossum added the comment: Changing the topic to not point fingers at Generic. -- nosy: -levkivskyi title: Inheriting from Generic causes inspect.signature to always return (*args, **kwargs) for constructor (and all subclasses) -> Inheriting from class that defines __ne

[issue40847] New parser considers empty line following a backslash to be a syntax error, old parser didn't

2020-06-08 Thread Guido van Rossum
Guido van Rossum added the comment: To be clear, I consider it a bug. -- ___ Python tracker <https://bugs.python.org/issue40847> ___ ___ Python-bugs-list mailin

[issue40939] Remove the old parser

2020-06-11 Thread Guido van Rossum
Guido van Rossum added the comment: Honestly I see no reason to keep that easter egg. Can we remove it please? -- ___ Python tracker <https://bugs.python.org/issue40

[issue40939] Remove the old parser

2020-06-11 Thread Guido van Rossum
Guido van Rossum added the comment: New changeset bcd7deed9118e365c1225de2a2e1a81bf988c6ab by Lysandros Nikolaou in branch 'master': bpo-40939: Remove PEG parser easter egg (__new_parser__) (#20802) https://github.com/python/cpython/commit/bcd7deed9118e365c1225de2a2e1a8

[issue33315] Allow queue.Queue to be used in type annotations

2020-06-13 Thread Guido van Rossum
Change by Guido van Rossum : -- resolution: -> fixed status: open -> closed versions: +Python 3.9 ___ Python tracker <https://bugs.python.org/i

[issue40985] PEG Parser: SyntaxError text empty when last line has a LINECONT

2020-06-15 Thread Guido van Rossum
Guido van Rossum added the comment: Yes, it's clear. :-) This is one reason we need to migrate off bpo and onto GitHub. -- ___ Python tracker <https://bugs.python.org/is

[issue22167] iglob() has misleading documentation (does indeed store names internally)

2020-06-15 Thread Guido van Rossum
Guido van Rossum added the comment: How's this going? -- ___ Python tracker <https://bugs.python.org/issue22167> ___ ___ Python-bugs-list mailing list

[issue22167] iglob() has misleading documentation (does indeed store names internally)

2020-06-16 Thread Guido van Rossum
Guido van Rossum added the comment: Sounds good. FWIW, and totally off-topic, I find it annoying that pathlib's .glob() method supports ** in patterns, but its cousing .match() does not: >>> p = pathlib.Path("Lib/test/support/os_helper.py") >>

[issue40978] Document that typing.SupportsXXX protocols are runtime checkable

2020-06-16 Thread Guido van Rossum
Guido van Rossum added the comment: And here I had hoped that this was a Pull Request. :-) Note that the docs also still state that these are ABCs -- in fact they are Protocols. I'm not sure why the same info should be repeated for the `@runtime_checkable` decorator t

[issue40636] Provide a strict form of zip (PEP-618) requiring same length inputs

2020-06-17 Thread Guido van Rossum
Change by Guido van Rossum : -- nosy: +gvanrossum nosy_count: 5.0 -> 6.0 pull_requests: +20120 pull_request: https://github.com/python/cpython/pull/20921 ___ Python tracker <https://bugs.python.org/issu

[issue40636] Provide a strict form of zip (PEP-618) requiring same length inputs

2020-06-19 Thread Guido van Rossum
Guido van Rossum added the comment: New changeset 59cf853332a82ce92875ea3dd6bba08e1305a288 by Ram Rachum in branch 'master': bpo-40636: Documentation for zip-strict (#20961) https://github.com/python/cpython/commit/59cf853332a82ce92875ea3dd6bba0

[issue41045] f-string's "debug" feature is undocumented

2020-06-19 Thread Guido van Rossum
Guido van Rossum added the comment: Every other detail about f-strings is spelled out meticulously in the reference manual: https://docs.python.org/3/reference/lexical_analysis.html#formatted-string-literals I think it needs to be added here. PS OT: I can't find anything about f-strin

[issue40939] Remove the old parser

2020-06-20 Thread Guido van Rossum
Guido van Rossum added the comment: You can delete symbol.py -- it has no use now that the old parser is gone. We should probably also update the regeneration targets in the Makefile. (At least review them.) -- ___ Python tracker <ht

[issue35975] Put back the ability to parse files where async/await aren't keywords

2020-06-20 Thread Guido van Rossum
Guido van Rossum added the comment: But it's a bug, right? The intention for sure is that the cf_feature_version field is only used when the PyCF_ONLY_AST flags is set in cf_flags, per the docs you cite as [3]. Why wouldn't it be possible to fix that? -- status: clos

[issue41059] Large number of Coverity reports for parser.c

2020-06-20 Thread Guido van Rossum
Guido van Rossum added the comment: Good catch! Are all the coverity complaints about this kind of code? if (_res == NULL && PyErr_Occurred()) { ... } (Mostly for Pablo and Lysandros:) This comes from emit_action(). It is preceded by a line of the form _res = ; Most of the

[issue41060] `with a as b` segfault in new peg parser

2020-06-20 Thread Guido van Rossum
Change by Guido van Rossum : -- nosy: +gvanrossum, pablogsal ___ Python tracker <https://bugs.python.org/issue41060> ___ ___ Python-bugs-list mailing list Unsub

[issue35975] Put back the ability to parse files where async/await aren't keywords

2020-06-20 Thread Guido van Rossum
Change by Guido van Rossum : -- pull_requests: +20193 pull_request: https://github.com/python/cpython/pull/21021 ___ Python tracker <https://bugs.python.org/issue35

[issue35975] Put back the ability to parse files where async/await aren't keywords

2020-06-20 Thread Guido van Rossum
Guido van Rossum added the comment: I'm fixing it -- can you verify? I have no easy way to test this. DO you think we should also add a note to the docs that this was broken in 3.8.0-3? -- ___ Python tracker <https://bugs.python.org/is

[issue35975] Put back the ability to parse files where async/await aren't keywords

2020-06-20 Thread Guido van Rossum
Change by Guido van Rossum : -- status: closed -> open ___ Python tracker <https://bugs.python.org/issue35975> ___ ___ Python-bugs-list mailing list Unsubscrib

[issue35975] Put back the ability to parse files where async/await aren't keywords

2020-06-20 Thread Guido van Rossum
Guido van Rossum added the comment: Hm, the backports have to be done manually, since the 3.8 parser and the 3.10 parser don't overlap, and 3.9 has both versions... -- ___ Python tracker <https://bugs.python.org/is

[issue35975] Put back the ability to parse files where async/await aren't keywords

2020-06-20 Thread Guido van Rossum
Change by Guido van Rossum : -- pull_requests: +20194 stage: resolved -> patch review pull_request: https://github.com/python/cpython/pull/21022 ___ Python tracker <https://bugs.python.org/issu

[issue35975] Put back the ability to parse files where async/await aren't keywords

2020-06-20 Thread Guido van Rossum
Change by Guido van Rossum : -- pull_requests: +20195 pull_request: https://github.com/python/cpython/pull/21023 ___ Python tracker <https://bugs.python.org/issue35

[issue39960] Using typename.__setattr__ in extension type with Py_TPFLAGS_HEAPTYPE is broken (hackcheck too eager?)

2020-06-20 Thread Guido van Rossum
Guido van Rossum added the comment: See also test_carloverre() in test_descr.py. I don't recall exactly what this was about, but that test is definitely relevant. -- ___ Python tracker <https://bugs.python.org/is

[issue35975] Put back the ability to parse files where async/await aren't keywords

2020-06-21 Thread Guido van Rossum
Guido van Rossum added the comment: Okay, I will add that diff (I'll probably add async def to the set of features tested). Do you mind if I just incorporate it in my diff? I could add an acknowledgment in the commit message. Otherwise you could send a separa

[issue40814] Update typing module documentation based on PEP 585

2020-06-21 Thread Guido van Rossum
Guido van Rossum added the comment: I don't think we should deprecate List etc. (PEP 585 specifically punts on the topic) but it's good to start mentioning list[t] etc. in the docs. Do you want to volunteer to write some docs? --

[issue39960] Using typename.__setattr__ in extension type with Py_TPFLAGS_HEAPTYPE is broken (hackcheck too eager?)

2020-06-21 Thread Guido van Rossum
Guido van Rossum added the comment: That sounds like the right thing to do. You should be able to recognize pure Python __setattr__ implementations by the presence of slot_tp_setattro in the tp_setattro slot. (Likewise for __delattr__.) It's been really long since I looked at this --

[issue12782] Multiple context expressions do not support parentheses for continuation across lines

2020-06-25 Thread Guido van Rossum
Guido van Rossum added the comment: But it is undocumented and doesn’t work with -X oldparser. -- --Guido (mobile) -- ___ Python tracker <https://bugs.python.org/issue12

[issue35975] Put back the ability to parse files where async/await aren't keywords

2020-06-27 Thread Guido van Rossum
Guido van Rossum added the comment: New changeset 9d197c7d48147a9ea2f7f7be917f35514a16524b by Guido van Rossum in branch 'master': bpo-35975: Only use cf_feature_version if PyCF_ONLY_AST in cf_flags (#21021) https://github.com/python/cpython/commit/9d197c7d48147a9ea2f7f7be917f35

[issue35975] Put back the ability to parse files where async/await aren't keywords

2020-06-27 Thread Guido van Rossum
Guido van Rossum added the comment: New changeset 2a1ee1d970460047bd88da9638f8c1789431d9ab by Guido van Rossum in branch '3.9': [3.9] bpo-35975: Only use cf_feature_version if PyCF_ONLY_AST in cf_flags (#21022) https://github.com/python/cpyt

[issue35975] Put back the ability to parse files where async/await aren't keywords

2020-06-27 Thread Guido van Rossum
Guido van Rossum added the comment: New changeset e653369e76d7da6bcbcf1f09a141f47fb77df6c3 by Guido van Rossum in branch '3.8': [3.8] bpo-35975: Only use cf_feature_version if PyCF_ONLY_AST in cf_flags (#21023) https://github.com/python/cpyt

[issue35975] Put back the ability to parse files where async/await aren't keywords

2020-06-29 Thread Guido van Rossum
Guido van Rossum added the comment: Fixed again. Thanks Stefan for finding this! I apologize for the bug. -- stage: patch review -> resolved status: open -> closed ___ Python tracker <https://bugs.python.org/i

[issue41184] Reconciling IDLE's Comment Out Region / Uncomment Region with PEP 8 guidelines for commenting

2020-07-01 Thread Guido van Rossum
Guido van Rossum added the comment: The IDLE feature should not change, for all the reasons Terry have. I am quite done with changes to PEP in order to settle arguments, and I do not believe this convention needs mentioning in that PEP. Remember there is text in PEP 8 reminding readers to

[issue39960] Using typename.__setattr__ in extension type with Py_TPFLAGS_HEAPTYPE is broken (hackcheck too eager?)

2020-07-02 Thread Guido van Rossum
Guido van Rossum added the comment: Stefan can you do the 3.8 backport? -- ___ Python tracker <https://bugs.python.org/issue39960> ___ ___ Python-bugs-list m

[issue33864] collections.abc.ByteString does not register memoryview

2020-07-03 Thread Guido van Rossum
Change by Guido van Rossum : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker <https://bugs.python.or

[issue39168] Generic type subscription is a huge toll on Python performance

2020-07-04 Thread Guido van Rossum
Guido van Rossum added the comment: Should this be backported? How far back? -- ___ Python tracker <https://bugs.python.org/issue39168> ___ ___ Python-bug

[issue39168] Generic type subscription is a huge toll on Python performance

2020-07-05 Thread Guido van Rossum
Change by Guido van Rossum : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker <https://bugs.python.or

[issue39960] Using typename.__setattr__ in extension type with Py_TPFLAGS_HEAPTYPE is broken (hackcheck too eager?)

2020-07-05 Thread Guido van Rossum
Guido van Rossum added the comment: You're welcome. Hope this helps Cpython users. -- ___ Python tracker <https://bugs.python.org/issue39960> ___ ___ Pytho

[issue40360] Deprecate lib2to3 (and 2to3) for future removal

2020-07-06 Thread Guido van Rossum
Guido van Rossum added the comment: There's no python-dev discussion; if you want more feedback I recommend starting on python-ideas first (on either forum you may expect pushback because this is not about a proposed change to Python or its workflow). The Lib/ast.py module will contin

[issue40360] Deprecate lib2to3 (and 2to3) for future removal

2020-07-08 Thread Guido van Rossum
Guido van Rossum added the comment: Can that be done as a 3rd party wrapper? Then you would be able to support older Python versions, and typed_ast (which can parse older Python grammars with a newer Python that's older than 3.8). Plus it would be much easier to get your code released

[issue41249] TypedDict inheritance doesn't work with get_type_hints and postponed evaluation of annotations across modules

2020-07-08 Thread Guido van Rossum
Change by Guido van Rossum : -- nosy: +gvanrossum, levkivskyi ___ Python tracker <https://bugs.python.org/issue41249> ___ ___ Python-bugs-list mailing list Unsub

[issue32528] Change base class for futures.CancelledError

2020-07-10 Thread Guido van Rossum
Guido van Rossum added the comment: Can you send a PR against what’s new 3.8? On Fri, Jul 10, 2020 at 20:14 JustAnotherArchivist wrote: > > JustAnotherArchivist added the comment: > > As another datapoint, this also broke some of my code on 3.8 because I

[issue40360] Deprecate lib2to3 (and 2to3) for future removal

2020-07-11 Thread Guido van Rossum
Guido van Rossum added the comment: Thanks for joining in! How do you do incremental parsing with LL1 currently? FWIW I found https://ohmlang.github.io/pubs/sle2017/incremental-packrat-parsing.pdf which may have some useful ideas. -- ___ Python

[issue39960] Using typename.__setattr__ in extension type with Py_TPFLAGS_HEAPTYPE is broken (hackcheck too eager?)

2020-07-14 Thread Guido van Rossum
Guido van Rossum added the comment: Reopening because there appears to be a problem with the fix (see PR 21473). -- status: closed -> open ___ Python tracker <https://bugs.python.org/issu

[issue39960] Using typename.__setattr__ in extension type with Py_TPFLAGS_HEAPTYPE is broken (hackcheck too eager?)

2020-07-14 Thread Guido van Rossum
Guido van Rossum added the comment: @Stefan Do you agree that the fix proposed in PR 21473 needs to be made? -- ___ Python tracker <https://bugs.python.org/issue39

[issue41314] PEP 563 and annotations __future__ mandatory version

2020-07-18 Thread Guido van Rossum
Guido van Rossum added the comment: The PEP now says 3.10, so the docs for __future__ should be fixed. -- resolution: not a bug -> status: closed -> open ___ Python tracker <https://bugs.python.org/i

[issue39603] [security] http.client: HTTP Header Injection in the HTTP method

2020-07-18 Thread Guido van Rossum
Guido van Rossum added the comment: The 3.9 and 3.8 backports are waiting for tests to complete. The 3.7 and 3.6 backports need to be merged by the RM (Ned). Then someone can close this issue. -- nosy: +gvanrossum ___ Python tracker <ht

[issue41295] CPython 3.8.4 regression on __setattr__ in multiinheritance with metaclasses

2020-07-18 Thread Guido van Rossum
Guido van Rossum added the comment: We have a buildbot failure: test_asyncio altered the execution environment. What does that mean? Victor? -- nosy: +gvanrossum ___ Python tracker <https://bugs.python.org/issue41

[issue41295] CPython 3.8.4 regression on __setattr__ in multiinheritance with metaclasses

2020-07-19 Thread Guido van Rossum
Guido van Rossum added the comment: @Łukasz: this should be good for the 3.8.5 release. -- ___ Python tracker <https://bugs.python.org/issue41295> ___ ___ Pytho

[issue39603] [security] http.client: HTTP Header Injection in the HTTP method

2020-07-22 Thread Guido van Rossum
Guido van Rossum added the comment: > It should also include 0x20 (space) since that can also be used to manipulate > the request. Can you indicate how to use a space in the HTTP verb as part of an attack? -- ___ Python tracker

[issue41341] Recursive evaluation of ForwardRef (and PEP 563)

2020-07-22 Thread Guido van Rossum
Guido van Rossum added the comment: New changeset 653f420b53a3aa87316cef59de8d3f5d9e11deb4 by wyfo in branch 'master': bpo-41341: Recursive evaluation of ForwardRef in get_type_hints (#21553) https://github.com/python/cpython/commit/653f420b53a3aa87316cef59de8d3f

<    24   25   26   27   28   29   30   31   32   33   >