[issue39481] Implement PEP 585 (Type Hinting Generics In Standard Collections)

2020-04-09 Thread Guido van Rossum
Guido van Rossum added the comment: At this speed I can merge about 3 PRs per hour. I'll be back tomorrow. -- ___ Python tracker <https://bugs.python.org/is

[issue39481] Implement PEP 585 (Type Hinting Generics In Standard Collections)

2020-04-09 Thread Guido van Rossum
Guido van Rossum added the comment: New changeset e3ec44d692d9442e640cf5b2d8708157a65cec3e by Ethan Smith in branch 'master': bpo-39481: PEP 585 for difflib, filecmp, fileinput (#19422) https://github.com/python/cpython/commit/e3ec44d692d9442e640cf5b2d87081

[issue39481] Implement PEP 585 (Type Hinting Generics In Standard Collections)

2020-04-09 Thread Guido van Rossum
Guido van Rossum added the comment: Check typeshed -- ___ Python tracker <https://bugs.python.org/issue39481> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue39481] Implement PEP 585 (Type Hinting Generics In Standard Collections)

2020-04-10 Thread Guido van Rossum
Guido van Rossum added the comment: New changeset 0361556537686f857f1025ead75e6af4ca7cc94a by Batuhan Taşkaya in branch 'master': bpo-39481: PEP 585 for a variety of modules (GH-19423) https://github.com/python/cpython/commit/0361556537686f857f1025ead75e6a

[issue40246] Different error messages for same error - invalid string prefixes

2020-04-10 Thread Guido van Rossum
Guido van Rossum added the comment: So a slightly shorter example uses ru''. This is an error because you can't combine the r prefix and the u prefix (in fact you can't combine anything with the r prefix). I declare that this is a bug to report EOF here and the code s

[issue40208] Remove deprecated symtable.SymbolTable.has_exec

2020-04-10 Thread Guido van Rossum
Guido van Rossum added the comment: Yeah, this seems safe to remove. If somebody's code breaks, that will just help them remove some dead code. -- ___ Python tracker <https://bugs.python.org/is

[issue30140] Binary arithmetic does not always call subclasses first

2020-04-10 Thread Guido van Rossum
Guido van Rossum added the comment: Let's give up on this one. -- resolution: -> wont fix stage: patch review -> resolved status: open -> closed ___ Python tracker <https://bugs.pyth

[issue40246] Different error messages for same error - invalid string prefixes

2020-04-10 Thread Guido van Rossum
Guido van Rossum added the comment: But that is the tokenize.py module. It does not have 100% the same behavior as the builtin tokenizer.c module. In this case it probably doesn't. -- ___ Python tracker <https://bugs.python.org/is

[issue25680] Selector.select() hangs when there is nothing to select

2020-04-10 Thread Guido van Rossum
Guido van Rossum added the comment: That may well be correct. Do you want to submit a PR to fix it? -- ___ Python tracker <https://bugs.python.org/issue25

[issue40246] Different error messages for same error - invalid string prefixes

2020-04-11 Thread Guido van Rossum
Guido van Rossum added the comment: yes On Sat, Apr 11, 2020 at 04:46 Lysandros Nikolaou wrote: > > Lysandros Nikolaou added the comment: > > I have working code that checks if there is a quotation mark right after > an identifier. Here is an example: > > ╰─ ./py

[issue39481] Implement PEP 585 (Type Hinting Generics In Standard Collections)

2020-04-13 Thread Guido van Rossum
Guido van Rossum added the comment: New changeset 25a6833f7945f14cad83509ec73954d0ad70bdb1 by Chih-Hsuan Yen in branch 'master': bpo-39481: fix test_genericalias on Android (GH-19469) https://github.com/python/cpython/commit/25a6833f7945f14cad83509ec73954

[issue39481] Implement PEP 585 (Type Hinting Generics In Standard Collections)

2020-04-13 Thread Guido van Rossum
Guido van Rossum added the comment: New changeset cecf049673da6a24435acd1a6a3b34472b323c97 by Ethan Smith in branch 'master': bpo-39481: Make functools.cached_property, partial, partialmethod generic (#19427) https://github.com/python/cpython/commit/cecf049673da6a24435acd1a6a3b34

[issue39481] Implement PEP 585 (Type Hinting Generics In Standard Collections)

2020-04-13 Thread Guido van Rossum
Guido van Rossum added the comment: New changeset 8ef875028a3644a329c87ce420a73793e315143f by Ethan Smith in branch 'master': bpo-39481: Make weakref and WeakSet generic (GH-19497) https://github.com/python/cpython/commit/8ef875028a3644a329c87ce420a737

[issue39481] Implement PEP 585 (Type Hinting Generics In Standard Collections)

2020-04-14 Thread Guido van Rossum
Guido van Rossum added the comment: New changeset d01628e411752ee6849f862cae66a1c69fe512b7 by Ethan Smith in branch 'master': bpo-39481: PEP 585 for dataclasses, mailbox, contextvars (GH-19425) https://github.com/python/cpython/commit/d01628e411752ee6849f862cae66a1

[issue39481] Implement PEP 585 (Type Hinting Generics In Standard Collections)

2020-04-14 Thread Guido van Rossum
Guido van Rossum added the comment: Thanks! -- --Guido (mobile) -- ___ Python tracker <https://bugs.python.org/issue39481> ___ ___ Python-bugs-list mailin

[issue40267] Error message differs when an expression is in an fstring

2020-04-15 Thread Guido van Rossum
Guido van Rossum added the comment: New changeset 9a4b38f66b3e674db94e07980e1cacb39e388c73 by Lysandros Nikolaou in branch 'master': bpo-40267: Fix message when last input character produces a SyntaxError (GH-19521) https://github.com/python/cpyt

[issue40267] Error message differs when an expression is in an fstring

2020-04-15 Thread Guido van Rossum
Change by Guido van Rossum : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker <https://bugs.python.or

[issue25680] Selector.select() hangs when there is nothing to select

2020-04-15 Thread Guido van Rossum
Guido van Rossum added the comment: New changeset ba1bcffe5cafc1bb0ac6fdf9ecef51e75e342707 by Russell Davis in branch 'master': bpo-29255: Wait in KqueueSelector.select when no fds are registered (GH-19508) https://github.com/python/cpython/commit/ba1bcffe5cafc1bb0ac6fdf9ecef51

[issue29255] selects.KqueueSelector behaves incorrectly when no fds are registered

2020-04-15 Thread Guido van Rossum
Guido van Rossum added the comment: New changeset ba1bcffe5cafc1bb0ac6fdf9ecef51e75e342707 by Russell Davis in branch 'master': bpo-29255: Wait in KqueueSelector.select when no fds are registered (GH-19508) https://github.com/python/cpython/commit/ba1bcffe5cafc1bb0ac6fdf9ecef51

[issue29255] selects.KqueueSelector behaves incorrectly when no fds are registered

2020-04-15 Thread Guido van Rossum
Change by Guido van Rossum : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker <https://bugs.python.or

[issue25680] Selector.select() hangs when there is nothing to select

2020-04-15 Thread Guido van Rossum
Guido van Rossum added the comment: How ironic, the other issue had to be closed manually. :-) Reopening this one. -- resolution: fixed -> status: closed -> open ___ Python tracker <https://bugs.python.org/i

[issue40296] help(list[int]) fails

2020-04-16 Thread Guido van Rossum
Guido van Rossum added the comment: Yeah, I think help() or pydoc needs to special-case this. (Didn't your other PR attempt to fix this?) Note that issubclass(list[int].__class__, type) returns True -- the __class__ attribute in this case is taken from __origin__, while type() return

[issue40334] PEP 617: new PEG-based parser

2020-04-19 Thread Guido van Rossum
New submission from Guido van Rossum : Note: PEP 617 is currently under review by the Steering Council, but if they approve we'd like to get it into alpha 6, and reviews are welcome (even though we're still finagling some corner cases of the implementation). -- messages: 3

[issue40360] Deprecate lib2to3 (and 2to3) for future removal

2020-04-22 Thread Guido van Rossum
Guido van Rossum added the comment: I am in favor of this. We could promote LibCST, which is based on Parso, which uses a forked version of pgen2 (the parser in lib2to3). I believe one of these could switch to a fork of pegen as its parser, so it will be able to handle new PEG based syntax

[issue40334] PEP 617: new PEG-based parser

2020-04-22 Thread Guido van Rossum
Guido van Rossum added the comment: VIctor, you were very right about longjmp. See https://github.com/we-like-parsers/cpython/pull/119 -- ___ Python tracker <https://bugs.python.org/issue40

[issue40334] PEP 617: new PEG-based parser

2020-04-23 Thread Guido van Rossum
Change by Guido van Rossum : -- pull_requests: +19012 pull_request: https://github.com/python/cpython/pull/19692 ___ Python tracker <https://bugs.python.org/issue40

[issue40334] PEP 617: new PEG-based parser

2020-04-23 Thread Guido van Rossum
Guido van Rossum added the comment: New changeset bc28805570ae3e8835a5d502ae9ab15c52449f77 by Guido van Rossum in branch 'master': bpo-40334: Use old compiler when compile mode is func_type (GH-19692) https://github.com/python/cpython/commit/bc28805570ae3e8835a5d502ae9ab1

[issue40334] PEP 617: new PEG-based parser

2020-04-23 Thread Guido van Rossum
Change by Guido van Rossum : -- pull_requests: +19015 pull_request: https://github.com/python/cpython/pull/19695 ___ Python tracker <https://bugs.python.org/issue40

[issue40334] PEP 617: new PEG-based parser

2020-04-23 Thread Guido van Rossum
Guido van Rossum added the comment: Yeah that's why we have a PR out to delete or skip this test. Pablo and Lysandros will deal with it tomorrow. On Thu, Apr 23, 2020 at 19:33 STINNER Victor wrote: > > STINNER Victor added the comment: > > test_peg_generator leaks refere

[issue40334] PEP 617: new PEG-based parser

2020-04-24 Thread Guido van Rossum
Change by Guido van Rossum : -- pull_requests: +19022 pull_request: https://github.com/python/cpython/pull/19704 ___ Python tracker <https://bugs.python.org/issue40

[issue40334] PEP 617: new PEG-based parser

2020-04-24 Thread Guido van Rossum
Guido van Rossum added the comment: New changeset 0e80b561d442769631d66f1cc8813ac30f97378e by Guido van Rossum in branch 'master': bpo-40334: Add What's New sections for PEP 617 and PEP 585 (GH-19704) https://github.com/python/cpython/commit/0e80b561d442769631d66f1cc

[issue39481] Implement PEP 585 (Type Hinting Generics In Standard Collections)

2020-04-24 Thread Guido van Rossum
Guido van Rossum added the comment: In commit 0e80b561d442769631d66f1cc8813ac30f97378e a What's New section was added. -- ___ Python tracker <https://bugs.python.org/is

[issue40334] PEP 617: new PEG-based parser

2020-04-24 Thread Guido van Rossum
Guido van Rossum added the comment: @Anthony: Presumably some of these will be unavoidable. I see you have PYPY-specific checks in your code already. You could also help by sending us the test programs and the different output produced by the old and the new parser. You could either create

[issue40398] get_args(Callable) fails

2020-04-26 Thread Guido van Rossum
Guido van Rossum added the comment: Maybe it could return (Ellipsis, Any) in that case. The most general form of Callable is Callable[..., Any] and that's that get_args() returns for that. -- ___ Python tracker <https://bugs.python.org/is

[issue40398] get_args(Callable) fails

2020-04-26 Thread Guido van Rossum
Guido van Rossum added the comment: Agreed, that's better! -- ___ Python tracker <https://bugs.python.org/issue40398> ___ ___ Python-bugs-list mailing list

[issue40405] asyncio.as_completed documentation misleading

2020-04-27 Thread Guido van Rossum
Guido van Rossum added the comment: I declare this not a bug. The docs do not promise that the Futures being returned are the *same* Futures that were passed in. They are not. They are (or at least may be) new Futures that represent the same event. Since Futures, when used as dict keys, use

[issue40405] asyncio.as_completed documentation misleading

2020-04-27 Thread Guido van Rossum
Guido van Rossum added the comment: Reopening so as to give the OP one more chance to state their case. They wrote: """ You've immediately closed the issue so I couldn't even reply to it, Unfortunately, it doesn't return a Future object at all, so technically yo

[issue40405] asyncio.as_completed documentation misleading

2020-04-27 Thread Guido van Rossum
Guido van Rossum added the comment: Oh, you're right. The docstring correctly says this. :-( Do you have the power to submit a PR? I think it should just say that the return values are coroutines (which is what it does). @Yury what do you think? -- resolution: not

[issue40408] GenericAlias does not support nested type variables

2020-04-27 Thread Guido van Rossum
Guido van Rossum added the comment: Good catch. Is there a reasonable fix? -- ___ Python tracker <https://bugs.python.org/issue40408> ___ ___ Python-bugs-list m

[issue40334] PEP 617: new PEG-based parser

2020-04-27 Thread Guido van Rossum
Guido van Rossum added the comment: @phr: examples welcome! The bigger and nastier, the better. This *should* all be speedy but it wouldn't hurt to check. -- ___ Python tracker <https://bugs.python.org/is

[issue40291] socket library support for CAN_J1939

2020-04-28 Thread Guido van Rossum
Guido van Rossum added the comment: Looks reasonable. -- nosy: +gvanrossum ___ Python tracker <https://bugs.python.org/issue40291> ___ ___ Python-bugs-list m

[issue40334] PEP 617: new PEG-based parser

2020-04-28 Thread Guido van Rossum
Change by Guido van Rossum : -- pull_requests: +19100 pull_request: https://github.com/python/cpython/pull/19780 ___ Python tracker <https://bugs.python.org/issue40

[issue40246] Different error messages for same error - invalid string prefixes

2020-04-28 Thread Guido van Rossum
Guido van Rossum added the comment: Personally I don't think that `else"stuff"` should become a syntax error. It's no different from other edge cases where for some reason the space seems optional, like `1and 2`. -- ___ Py

[issue40405] asyncio.as_completed documentation misleading

2020-04-28 Thread Guido van Rossum
Guido van Rossum added the comment: Please work this out in the PR between the two of you, Kyle and Bar. -- ___ Python tracker <https://bugs.python.org/issue40

[issue40246] Different error messages for same error - invalid string prefixes

2020-04-29 Thread Guido van Rossum
Guido van Rossum added the comment: If it's all handled by the tokenizer, how come it's different in the new parser? Anyway, it seems we really have to support what the old parser supported here. I don't know exactly what rules it uses. Maybe only look for a string quote follow

[issue40291] socket library support for CAN_J1939

2020-04-29 Thread Guido van Rossum
Guido van Rossum added the comment: Thanks, good luck using this! -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker <https://bugs.python.or

[issue40389] No straightforward way to get repr of Optional

2020-04-29 Thread Guido van Rossum
Guido van Rossum added the comment: New changeset 138a9b9c2a394f30f222c23391f9515a7df9d809 by Vlad Serebrennikov in branch 'master': bpo-40389: Improve repr of typing.Optional (#19714) https://github.com/python/cpython/commit/138a9b9c2a394f30f222c23391f9515a7df9d809 -

[issue40389] No straightforward way to get repr of Optional

2020-04-29 Thread Guido van Rossum
Change by Guido van Rossum : -- stage: patch review -> resolved status: open -> closed ___ Python tracker <https://bugs.python.org/issue40389> ___ ___ Pyth

[issue40360] Deprecate lib2to3 (and 2to3) for future removal

2020-04-29 Thread Guido van Rossum
Guido van Rossum added the comment: It's typically not up to the core devs to pick a winning third party library; we tend to recommend libraries that are already essentially category winners, like requests. In a sense pointing to LibCST *and* parso is redundant because LibCST buil

[issue40360] Deprecate lib2to3 (and 2to3) for future removal

2020-04-30 Thread Guido van Rossum
Guido van Rossum added the comment: A "What's New" entry would go into Doc/whatsnew/3.9.rst and is much more visible to users looking for exciting bits in the new release (the NEWS file is very large, see e.g. https://docs.python.org/3/whatsnew/changelog.html#changelog. The

[issue40360] Deprecate lib2to3 (and 2to3) for future removal

2020-04-30 Thread Guido van Rossum
Guido van Rossum added the comment: IIRC PendingDeprecationError does not mean that the decision hasn't been made yet. It just means it's less urgent for folks to worry about. I believe we tend to change PendingDeprecationError to DeprecationError in the last release before so

[issue40334] PEP 617: new PEG-based parser

2020-04-30 Thread Guido van Rossum
Guido van Rossum added the comment: New changeset c001c09e9059ba04bc088349cd87a1374dc0754f by Guido van Rossum in branch 'master': bpo-40334: Support type comments (GH-19780) https://github.com/python/cpython/commit/c001c09e9059ba04bc088349cd87a1

[issue29587] Generator/coroutine 'throw' discards exc_info state, which is bad

2020-04-30 Thread Guido van Rossum
Guido van Rossum added the comment: New changeset 2514a632fb7d37be24c2059d0e286d35600f9795 by Chris Jerdonek in branch 'master': bpo-29587: Enable implicit exception chaining with gen.throw() (GH-19811) https://github.com/python/cpython/commit/2514a632fb7d37be24c2059d0e286d

[issue29587] Generator/coroutine 'throw' discards exc_info state, which is bad

2020-04-30 Thread Guido van Rossum
Guido van Rossum added the comment: Example 1 is now fixed too by Chris Jerdonek's PR 19811. Thanks Chris! -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker <https://bugs.pyth

[issue29587] Generator/coroutine 'throw' discards exc_info state, which is bad

2020-04-30 Thread Guido van Rossum
Guido van Rossum added the comment: Oh, no! Buildbot failures. Help?! -- ___ Python tracker <https://bugs.python.org/issue29587> ___ ___ Python-bugs-list mailin

[issue29587] Generator/coroutine 'throw' discards exc_info state, which is bad

2020-04-30 Thread Guido van Rossum
Change by Guido van Rossum : -- resolution: fixed -> status: closed -> open ___ Python tracker <https://bugs.python.org/issue29587> ___ ___ Python-bugs-

[issue29587] Generator/coroutine 'throw' discards exc_info state, which is bad

2020-04-30 Thread Guido van Rossum
Guido van Rossum added the comment: Could it be running out of memory due to excessive chaining of tracebacks? (And yes, it's 3.9 only.) -- ___ Python tracker <https://bugs.python.org/is

[issue40334] PEP 617: new PEG-based parser

2020-04-30 Thread Guido van Rossum
Change by Guido van Rossum : -- pull_requests: +19148 pull_request: https://github.com/python/cpython/pull/19828 ___ Python tracker <https://bugs.python.org/issue40

[issue40334] PEP 617: new PEG-based parser

2020-04-30 Thread Guido van Rossum
Change by Guido van Rossum : -- pull_requests: +19150 pull_request: https://github.com/python/cpython/pull/19830 ___ Python tracker <https://bugs.python.org/issue40

[issue40334] PEP 617: new PEG-based parser

2020-04-30 Thread Guido van Rossum
Guido van Rossum added the comment: New changeset 3e0a6f37dfdd595be737baae00ec0e036a912615 by Lysandros Nikolaou in branch 'master': bpo-40334: Add support for feature_version in new PEG parser (GH-19827) https://github.com/python/cpython/commit/3e0a6f37dfdd595be737baae00ec0e

[issue40334] PEP 617: new PEG-based parser

2020-05-01 Thread Guido van Rossum
Guido van Rossum added the comment: New changeset ea7297cf8f1aad4df8921a3d81a75118511afe77 by Pablo Galindo in branch 'master': bpo-40334: unskip test_function_type in test_unparse with the new parser (GH-19837) https://github.com/python/cpyt

[issue40334] PEP 617: new PEG-based parser

2020-05-01 Thread Guido van Rossum
Guido van Rossum added the comment: New changeset d955241469c18c946924dba79c18a9ef200391ad by Pablo Galindo in branch 'master': bpo-40334: Correct return value of func_type_comment (GH-19833) https://github.com/python/cpython/commit/d955241469c18c946924dba79c18a9

[issue40398] typing.get_args(Callable) fails

2020-05-01 Thread Guido van Rossum
Guido van Rossum added the comment: @Serhiy is this fixed by PR 19720? -- ___ Python tracker <https://bugs.python.org/issue40398> ___ ___ Python-bugs-list mailin

[issue29587] Generator/coroutine 'throw' discards exc_info state, which is bad

2020-05-01 Thread Guido van Rossum
Guido van Rossum added the comment: Wow, thanks all! FWIW I agree that ideally things should work with a NULL value... -- --Guido (mobile) -- ___ Python tracker <https://bugs.python.org/issue29

[issue40334] PEP 617: new PEG-based parser

2020-05-01 Thread Guido van Rossum
Guido van Rossum added the comment: Easy issue: the Python.gram file still has a comment saying something like # Simplified grammar -- ___ Python tracker <https://bugs.python.org/issue40

[issue40493] Pegen can't parse some function type comments

2020-05-03 Thread Guido van Rossum
Change by Guido van Rossum : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker <https://bugs.python.or

[issue40494] collections.abc.Callable and type variables

2020-05-04 Thread Guido van Rossum
Guido van Rossum added the comment: Yeah, the fix will require a variant of types.GenericAlias that substitute's type variables in lists. -- ___ Python tracker <https://bugs.python.org/is

[issue40499] asyncio.wait documentation on non-emptiness requirement lost in bpo-33649

2020-05-04 Thread Guido van Rossum
Change by Guido van Rossum : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker <https://bugs.python.or

[issue40499] asyncio.wait documentation on non-emptiness requirement lost in bpo-33649

2020-05-04 Thread Guido van Rossum
Guido van Rossum added the comment: New changeset 9d74658f0a6e8a9b8d6dcf199dda886f35c6ad68 by Joel Rosdahl in branch 'master': bpo-40499: Mention that asyncio.wait() needs a non-empty aws set (GH-19900) https://github.com/python/cpython/commit/9d74658f0a6e8a9b8d6dcf199dda88

[issue21596] asyncio.wait fails when futures list is empty

2020-05-04 Thread Guido van Rossum
Guido van Rossum added the comment: New changeset 9d74658f0a6e8a9b8d6dcf199dda886f35c6ad68 by Joel Rosdahl in branch 'master': bpo-40499: Mention that asyncio.wait() needs a non-empty aws set (GH-19900) https://github.com/python/cpython/commit/9d74658f0a6e8a9b8d6dcf199dda88

[issue33649] asyncio docs overhaul

2020-05-04 Thread Guido van Rossum
Guido van Rossum added the comment: New changeset 9d74658f0a6e8a9b8d6dcf199dda886f35c6ad68 by Joel Rosdahl in branch 'master': bpo-40499: Mention that asyncio.wait() needs a non-empty aws set (GH-19900) https://github.com/python/cpython/commit/9d74658f0a6e8a9b8d6dcf199dda88

[issue40494] collections.abc.Callable and type variables

2020-05-06 Thread Guido van Rossum
Guido van Rossum added the comment: Hm, I am indeed torn. ISTM a subclass just for Callable is slightly better. -- ___ Python tracker <https://bugs.python.org/issue40

[issue40546] Inconsistencies between PEG parser and traceback SyntaxErrors

2020-05-07 Thread Guido van Rossum
Guido van Rossum added the comment: I don't understand why the traceback module is implicated. It just formats the information in the SyntaxError object, same as the builtin printing for syntax errors. The key difference is always in what line/column/text is put in the SyntaxError obje

[issue40546] Inconsistencies between PEG parser and traceback SyntaxErrors

2020-05-07 Thread Guido van Rossum
Guido van Rossum added the comment: For example: raise SyntaxError("message", ("", 1, 3, "text")) Traceback (most recent call last): File "", line 1, in File "", line 1 text ^ SyntaxError: message >>> (I can't

[issue40546] Inconsistencies between PEG parser and traceback SyntaxErrors

2020-05-07 Thread Guido van Rossum
Guido van Rossum added the comment: Aha! So the traceback module does have a difference. First, if the offset points inside the text, there's no difference: >>> raise SyntaxError("message", ("", 1, 4, "text")) Traceback (most recent call las

[issue40546] Inconsistencies between PEG parser and traceback SyntaxErrors

2020-05-07 Thread Guido van Rossum
Guido van Rossum added the comment: Hm, but there the old parser seems at fault: it points to the last space rather than beyond it? -- ___ Python tracker <https://bugs.python.org/issue40

[issue40546] Inconsistencies between PEG parser and traceback SyntaxErrors

2020-05-08 Thread Guido van Rossum
Guido van Rossum added the comment: @Terry: Thanks for confirming the bug in the old parser. Regarding whether column offsets should be 0-based or 1-based: I agree with Tk, but my hand was forced for SyntaxError: we found that it was already using 1-based offsets and we found correct

[issue40397] Refactor typing._GenericAlias

2020-05-09 Thread Guido van Rossum
Guido van Rossum added the comment: @Serhiy can you look at this? A possible fix might be: diff --git a/Lib/typing.py b/Lib/typing.py index 681ab6d21e..adcef1e82b 100644 --- a/Lib/typing.py +++ b/Lib/typing.py @@ -701,7 +701,8 @@ class _GenericAlias(_BaseGenericAlias, _root=True

[issue40397] Refactor typing._GenericAlias

2020-05-09 Thread Guido van Rossum
Guido van Rossum added the comment: I think I have a shorter repro, not involving unions: from typing import * T = TypeVar("T") S = TypeVar("S") U = TypeVar("U") class A(Generic[T]): ... class B(Generic[T]): ... class C(Generic[T, S]): ... print(C[A[U], B[int]][

[issue40334] PEP 617: new PEG-based parser

2020-05-09 Thread Guido van Rossum
Guido van Rossum added the comment: New changeset ac7a92cc0a821699df48bc2e30a02c25d6338f78 by Pablo Galindo in branch 'master': bpo-40334: Avoid collisions between parser variables and grammar variables (GH-19987) https://github.com/python/cpyt

[issue40334] PEP 617: new PEG-based parser

2020-05-09 Thread Guido van Rossum
Guido van Rossum added the comment: FWIW I propose that we add another Misc/NEWS for the same issue summarizing what happened between alpha6 and beta1. (A lot!) -- ___ Python tracker <https://bugs.python.org/issue40

[issue40582] Inconsistent exceptions caused by typing + tuple subclasses

2020-05-10 Thread Guido van Rossum
Guido van Rossum added the comment: I recommend taking this to a user forum or list. I see no but in typing.py here. -- resolution: -> not a bug stage: -> resolved status: open -> closed ___ Python tracker <https://bugs.python.or

[issue40585] compile_command exec not raising syntax error with new PGEN Parser

2020-05-10 Thread Guido van Rossum
Guido van Rossum added the comment: Let's analyze this here rather than in issue40334 (which is getting top-heavy :-). -- nosy: +gvanrossum ___ Python tracker <https://bugs.python.org/is

[issue40334] PEP 617: new PEG-based parser

2020-05-10 Thread Guido van Rossum
Guido van Rossum added the comment: It definitely has its reasons -- there are pernicious edge cases. Probably revealed by the tests. -- ___ Python tracker <https://bugs.python.org/issue40

[issue40585] compile_command exec not raising syntax error with new PGEN Parser

2020-05-10 Thread Guido van Rossum
Change by Guido van Rossum : -- stage: resolved -> patch review ___ Python tracker <https://bugs.python.org/issue40585> ___ ___ Python-bugs-list mai

[issue40585] compile_command exec not raising syntax error with new PGEN Parser

2020-05-10 Thread Guido van Rossum
Change by Guido van Rossum : -- stage: patch review -> resolved ___ Python tracker <https://bugs.python.org/issue40585> ___ ___ Python-bugs-list mai

[issue40257] Improve the use of __doc__ in pydoc

2020-05-10 Thread Guido van Rossum
Guido van Rossum added the comment: Okay, let's reopen. @Matthias, can you clarify your example? What's load()? And what does df?? do? -- status: closed -> open ___ Python tracker <https://bugs.pytho

[issue40257] Improve the use of __doc__ in pydoc

2020-05-10 Thread Guido van Rossum
Guido van Rossum added the comment: Can you all please decide which issue to use? -- ___ Python tracker <https://bugs.python.org/issue40257> ___ ___ Python-bug

[issue40546] Inconsistencies between PEG parser and traceback SyntaxErrors

2020-05-11 Thread Guido van Rossum
Guido van Rossum added the comment: I would carefully think about the meaning of that line and see if there are other permutations, e.g. min(Len(blah), offset - 1) ? It would,be nice to specify what we need here from both parsers and from both code chunks for error printing

[issue40334] PEP 617: new PEG-based parser

2020-05-11 Thread Guido van Rossum
Guido van Rossum added the comment: New changeset 27c0d9b54abaa4112d5a317b8aa78b39ad60a808 by Shantanu in branch 'master': bpo-40334: produce specialized errors for invalid del targets (GH-19911) https://github.com/python/cpython/commit/27c0d9b54abaa4112d5a317b8aa78b

[issue40257] Improve the use of __doc__ in pydoc

2020-05-11 Thread Guido van Rossum
Guido van Rossum added the comment: I'm making this a release blocker -- please everybody come to an agreement or ask on python-dev. -- priority: normal -> release blocker resolution: fixed -> remind ___ Python tracker <https://b

[issue40599] Improve error messages with expected keywords

2020-05-11 Thread Guido van Rossum
Guido van Rossum added the comment: Hmm... The errors get long, and by focusing only on keywords they can be misleading. E.g. >>> from x import a b c File "", line 1 from x import a b c ^ SyntaxError: Invalid syntax. Expected one of: as >&g

[issue40599] Improve error messages with expected keywords

2020-05-11 Thread Guido van Rossum
Guido van Rossum added the comment: I had hoped that error labels would get us closer to error recovery, but it appears that is still quite elusive. :-( -- ___ Python tracker <https://bugs.python.org/issue40

[issue40599] Improve error messages with expected keywords

2020-05-11 Thread Guido van Rossum
Guido van Rossum added the comment: In response to my PEG blogs last year someone showed me an entirely different algorithm, based on first looking for matching parentheses (and other matching things), then for operators by priority, and so on. The approach was designed with C in mind but

[issue39481] Implement PEP 585 (Type Hinting Generics In Standard Collections)

2020-05-11 Thread Guido van Rossum
Guido van Rossum added the comment: New changeset f3a5b7ada0c951f317dbd307de4b410e58d3e1b3 by Batuhan Taskaya in branch 'master': bpo-39481: remove generic classes from ipaddress/mmap (GH-20045) https://github.com/python/cpython/commit/f3a5b7ada0c951f317dbd307de4b41

[issue40612] Make traceback module's formatting of SyntaxError more similar to system formatting

2020-05-12 Thread Guido van Rossum
New submission from Guido van Rossum : The traceback module formats several edge cases of SyntaxError different than CPython's default formatting. - There's an off-by-one error if the column offset (printed as a caret) points past the last character (example: 'a +='). T

[issue40612] Make traceback module's formatting of SyntaxError more similar to system formatting

2020-05-13 Thread Guido van Rossum
Change by Guido van Rossum : -- keywords: +patch pull_requests: +19378 stage: -> patch review pull_request: https://github.com/python/cpython/pull/20072 ___ Python tracker <https://bugs.python.org/issu

[issue40257] Improve the use of __doc__ in pydoc

2020-05-13 Thread Guido van Rossum
Guido van Rossum added the comment: I feel it should. At the very least, a decision should be made on how to move forward. -- ___ Python tracker <https://bugs.python.org/issue40

[issue40619] compile() passes rest of file as SyntaxError().text when file unreadable

2020-05-13 Thread Guido van Rossum
Change by Guido van Rossum : -- nosy: +lys.nikolaou, pablogsal ___ Python tracker <https://bugs.python.org/issue40619> ___ ___ Python-bugs-list mailing list Unsub

[issue40619] compile() passes rest of file as SyntaxError().text when file unreadable

2020-05-13 Thread Guido van Rossum
New submission from Guido van Rossum : Example: >>> compile("pass\n(1+)\npass", "", "exec") Traceback (most recent call last): File "", line 1, in File "", line 2 (1+) pass ^ SyntaxError: invalid syntax >>>

<    21   22   23   24   25   26   27   28   29   30   >