[issue38135] Depth first search in compile.c creates wrong BB order for certain CFG.

2019-09-12 Thread Gregory P. Smith
Gregory P. Smith added the comment: New changeset 99b54d68172ad64ba3d0fdc0137f0df88c28ea2b by Gregory P. Smith (T. Wouters) in branch 'master': Revert "Fix depth-first-search computation in compile.c (GH-16042)" (GH-16050) https://github.com/p

[issue36991] zipfile: AttributeError on extract

2019-09-12 Thread Gregory P. Smith
Change by Gregory P. Smith : -- assignee: -> gregory.p.smith nosy: +gregory.p.smith versions: +Python 3.9 ___ Python tracker <https://bugs.python.org/issu

[issue33312] ubsan undefined behavior sanitizer flags struct _dictkeysobject (PyDictKeysObj)

2019-09-12 Thread Gregory P. Smith
Gregory P. Smith added the comment: automated backport of the gdb/libpython change fails on 3.6, if this is needed there (I haven't looked into the code on that branch), it's a tiny change to apply. i'll leave that to the 3.6 RM to decide if at all. -- resolution:

[issue36991] zipfile: AttributeError on extract

2019-09-12 Thread Gregory P. Smith
Gregory P. Smith added the comment: New changeset 2f1b857562b0f1601c9019db74c29b7d7e21ac9f by Gregory P. Smith (Berker Peksag) in branch 'master': bpo-36991: Fix incorrect exception escaping ZipFile.extract() (GH-13632) https://github.com/python/cpyt

[issue21872] LZMA library sometimes fails to decompress a file

2019-09-12 Thread Gregory P. Smith
Gregory P. Smith added the comment: New changeset 4ffd05d7ec47cfd0d7fc95dce851633be9663255 by Gregory P. Smith (animalize) in branch 'master': bpo-21872: fix lzma library decompresses data incompletely (GH-14048) https://github.com/python/cpyt

[issue37802] micro-optimization of PyLong_FromSize_t()

2019-09-12 Thread Gregory P. Smith
Gregory P. Smith added the comment: New changeset c6734ee7c55add5fdc2c821729ed5f67e237a096 by Gregory P. Smith (Sergey Fedoseev) in branch 'master': bpo-37802: Slightly improve perfomance of PyLong_FromUnsigned*() (GH-15192) https://github.com/python/cpyt

[issue37802] micro-optimization of PyLong_FromSize_t()

2019-09-12 Thread Gregory P. Smith
Change by Gregory P. Smith : -- resolution: -> fixed stage: patch review -> commit review status: open -> closed ___ Python tracker <https://bugs.python.or

[issue37935] Improve performance of pathlib.scandir()

2019-09-12 Thread Gregory P. Smith
Gregory P. Smith added the comment: New changeset 98a4a713d001cf2dfb04a9e318e4aea899bc8fbd by Gregory P. Smith (Miss Islington (bot)) in branch '3.8': bpo-37935: Added tests for os.walk(), glob.iglob() and Path.glob() (GH-15956) (GH-16043) https://github.com/python/cpyt

[issue29988] with statements are not ensuring that __exit__ is called if __enter__ succeeds

2019-09-12 Thread Gregory P. Smith
Gregory P. Smith added the comment: While there is technically still time, it'd take people spending dedicated time on it before the 3.8 release. I won't be. Important? Sure. But not urgent; this bug is not new. We've lived with it for many releases already. I beli

[issue21872] LZMA library sometimes fails to decompress a file

2019-09-12 Thread Gregory P. Smith
Gregory P. Smith added the comment: thanks! -- resolution: -> fixed stage: patch review -> commit review status: open -> closed ___ Python tracker <https://bugs.python.or

[issue34709] Suggestion: make getpass.getuser() also look at SUDO_USER environment variable

2019-09-12 Thread Gregory P. Smith
Gregory P. Smith added the comment: Adding a check for SUDO_USER would break existing uses as it would no longer be reporting the user the process is running as. -- assignee: -> gregory.p.smith resolution: -> rejected stage: patch review -> resolved status: open ->

[issue36046] support dropping privileges when running subprocesses

2019-09-12 Thread Gregory P. Smith
Gregory P. Smith added the comment: New changeset 2b2ead74382513d0bb9ef34504e283a71e6a706f by Gregory P. Smith (Patrick McLean) in branch 'master': bpo-36046: Add user and group parameters to subprocess (GH-11950) https://github.com/python/cpyt

[issue36046] support dropping privileges when running subprocesses

2019-09-12 Thread Gregory P. Smith
Gregory P. Smith added the comment: I'm curious to see what weird things the various buildbot platforms find for this one. crossing my fingers. -- ___ Python tracker <https://bugs.python.org/is

[issue9216] FIPS support for hashlib

2019-09-12 Thread Gregory P. Smith
Gregory P. Smith added the comment: New changeset 7cad53e6b084435a220e6604010f1fa5778bd0b1 by Gregory P. Smith (Christian Heimes) in branch 'master': bpo-9216: Add usedforsecurity to hashlib constructors (GH-16044) https://github.com/python/cpyt

[issue36046] support dropping privileges when running subprocesses

2019-09-12 Thread Gregory P. Smith
Gregory P. Smith added the comment: The 'Debian root' buildbot exposed a unittest issue to deal with: https://buildbot.python.org/all/#/builders/27/builds/3702/steps/5/logs/stdio == ERROR:

[issue36046] support dropping privileges when running subprocesses

2019-09-12 Thread Gregory P. Smith
Gregory P. Smith added the comment: and some Fedora and RHEL bots are failing with: == ERROR: test_extra_groups (test.test_subprocess.POSIXProcessTestCase

[issue36046] support dropping privileges when running subprocesses

2019-09-12 Thread Gregory P. Smith
Change by Gregory P. Smith : -- versions: +Python 3.9 -Python 3.8 ___ Python tracker <https://bugs.python.org/issue36046> ___ ___ Python-bugs-list mailin

[issue36046] support dropping privileges when running subprocesses

2019-09-12 Thread Gregory P. Smith
Gregory P. Smith added the comment: AIX has the same error as RHEL and Fedora https://buildbot.python.org/all/#/builders/161/builds/1615/steps/5/logs/stdio -- ___ Python tracker <https://bugs.python.org/issue36

[issue36046] support dropping privileges when running subprocesses

2019-09-13 Thread Gregory P. Smith
Change by Gregory P. Smith : -- pull_requests: +15712 pull_request: https://github.com/python/cpython/pull/16091 ___ Python tracker <https://bugs.python.org/issue36

[issue38153] Normalize hashing algorithm names

2019-09-13 Thread Gregory P. Smith
Gregory P. Smith added the comment: as discussed, not pushing this back into 3.7 as we aren't hearing users call this a problem. -- versions: -Python 3.7 ___ Python tracker <https://bugs.python.org/is

[issue38153] Normalize hashing algorithm names

2019-09-13 Thread Gregory P. Smith
Gregory P. Smith added the comment: New changeset 995b5d38e7cc24cac3de8dfd516115f86b0bcf80 by Gregory P. Smith (Christian Heimes) in branch 'master': bpo-38153: Normalize hashlib algorithm names (GH-16083) https://github.com/python/cpython/commit/995b5d38e7cc24cac3de8dfd516115

[issue34706] Signature.from_callable sometimes drops subclassing

2019-09-13 Thread Gregory P. Smith
Change by Gregory P. Smith : -- pull_requests: +15726 pull_request: https://github.com/python/cpython/pull/16108 ___ Python tracker <https://bugs.python.org/issue34

[issue34706] Signature.from_callable sometimes drops subclassing

2019-09-13 Thread Gregory P. Smith
Change by Gregory P. Smith : -- versions: +Python 3.8, Python 3.9 ___ Python tracker <https://bugs.python.org/issue34706> ___ ___ Python-bugs-list mailin

[issue34706] Signature.from_callable sometimes drops subclassing

2019-09-13 Thread Gregory P. Smith
Change by Gregory P. Smith : -- assignee: -> gregory.p.smith nosy: +gregory.p.smith ___ Python tracker <https://bugs.python.org/issue34706> ___ ___ Python-

[issue34706] Signature.from_callable sometimes drops subclassing

2019-09-13 Thread Gregory P. Smith
Gregory P. Smith added the comment: New changeset 5b9ff7a0dcb16d6f5c3cd4f1f52e0ca6a4bde586 by Gregory P. Smith in branch 'master': bpo-34706: Preserve subclassing in inspect.Signature.from_callable (GH-16108) https://github.com/python/cpython/commit/5b9ff7a0dcb16d6f5c3cd4f1f52e0c

[issue38205] Python no longer compiles without small integer singletons

2019-09-18 Thread Gregory P. Smith
Gregory P. Smith added the comment: While I don't like how that get_small_int macro is defined... and I don't like that Py_UNREACHABLE() was usable as an expression in the past... it is probably best to just revert 3ab61473ba7f3dca32d779ec2766a4faa0657923. The choice to use a macr

[issue38216] Fix for issue30458 prevents crafting invalid requests

2019-09-19 Thread Gregory P. Smith
Gregory P. Smith added the comment: What's needed here is a Decision. (release managers and steering councils make those) IMNSHO, this regression is intentional and does not feel like a bug. The Python HTTP APIs were never designed with an explicit intent to allow violations o

[issue38216] Fix for issue30458 prevents crafting invalid requests

2019-09-20 Thread Gregory P. Smith
Gregory P. Smith added the comment: All bug fixes are behavior changes. Any broken behavior can be relied upon by someone. So far the only ones who have popped up with this change as being a problem is one project's test suite where the behavior was used by a test because it

[issue38216] Fix for issue30458 (HTTP Header Injection) prevents crafting invalid requests

2019-09-20 Thread Gregory P. Smith
Gregory P. Smith added the comment: > I think this is a false dichotomy; in > https://bugs.python.org/issue36274#msg351834 Jason proposed a few > alternatives that allow for a secure and obvious default API while adding a > new, explicitly unsafe API. I'm not against tha

[issue36587] race in logging code when fork()

2019-09-24 Thread Gregory P. Smith
Gregory P. Smith added the comment: i don't have context for what test was needed where anymore, but https://github.com/python/cpython/pull/12704 removed the _at_fork_acquire_release_weakset. -- resolution: -> out of date stage: -> resolved status: ope

[issue36871] Misleading error from unittest.mock's assert_has_calls

2019-09-24 Thread Gregory P. Smith
Gregory P. Smith added the comment: New changeset 2180f6b058effbf49ec819f7cedbe76ddd4b700c by Gregory P. Smith (Samuel Freilich) in branch 'master': bpo-36871: Avoid duplicated 'Actual:' in assertion message (GH-16361) https://github.com/p

[issue38239] test_gdb fails on AMD64 Fedora Stable LTO 3.8 and AMD64 RHEL8 LTO 3.x: Unexpected gdb output

2019-09-24 Thread Gregory P. Smith
Gregory P. Smith added the comment: The test probably has a fragile regex. I don't spend time with gdb things much myself. -- ___ Python tracker <https://bugs.python.org/is

[issue38239] test_gdb fails on AMD64 Fedora Stable LTO 3.8 and AMD64 RHEL8 LTO 3.x: Unexpected gdb output

2019-09-24 Thread Gregory P. Smith
Change by Gregory P. Smith : -- nosy: -gregory.p.smith ___ Python tracker <https://bugs.python.org/issue38239> ___ ___ Python-bugs-list mailing list Unsub

[issue36871] Misleading error from unittest.mock's assert_has_calls

2019-09-24 Thread Gregory P. Smith
Change by Gregory P. Smith : -- pull_requests: +15954 pull_request: https://github.com/python/cpython/pull/16374 ___ Python tracker <https://bugs.python.org/issue36

[issue36871] Misleading error from unittest.mock's assert_has_calls

2019-09-24 Thread Gregory P. Smith
Gregory P. Smith added the comment: New changeset 4042e1afd252858de53e2b79d946a51a0182d1ba by Gregory P. Smith in branch '3.7': [3.7] bpo-36871: Handle spec errors in assert_has_calls (GH-16364) (GH-16374) https://github.com/python/cpython/commit/4042e1afd252858de53e2b79d946a5

[issue36871] Misleading error from unittest.mock's assert_has_calls

2019-09-24 Thread Gregory P. Smith
Gregory P. Smith added the comment: i believe the issues surfaces in this are fixed at this point. of note, my mock_call_test.py example now passes. i'm not entirely sure that it _should_ pass though, but that depends on what we want create_autospec of a class to do. should that autos

[issue36046] support dropping privileges when running subprocesses

2019-09-24 Thread Gregory P. Smith
Change by Gregory P. Smith : -- resolution: -> fixed stage: patch review -> commit review status: open -> closed ___ Python tracker <https://bugs.python.or

[issue38269] AMD64 Debian PGO 3.x, AMD64 Clang UBSan 2.7 buildbots: No space left on device

2019-09-25 Thread Gregory P. Smith
Change by Gregory P. Smith : -- assignee: -> gregory.p.smith ___ Python tracker <https://bugs.python.org/issue38269> ___ ___ Python-bugs-list mailing list Un

[issue38269] AMD64 Debian PGO 3.x, AMD64 Clang UBSan 2.7 buildbots: No space left on device

2019-09-25 Thread Gregory P. Smith
Gregory P. Smith added the comment: It appears that something in the buildbot configuration (typo?) has changed which caused an entire new set of directories for the builder to be created: @clang-ubsan:/var/lib/buildbot/clang-ubsan$ ls -al total 68056 drwxr-xr-x 14 buildbot buildbot 4096

[issue38269] AMD64 Debian PGO 3.x, AMD64 Clang UBSan 2.7 buildbots: No space left on device

2019-09-25 Thread Gregory P. Smith
Gregory P. Smith added the comment: https://github.com/python/buildmaster-config/pull/108 is to blame. -- ___ Python tracker <https://bugs.python.org/issue38

[issue38269] AMD64 Debian PGO 3.x, AMD64 Clang UBSan 2.7 buildbots: No space left on device

2019-09-25 Thread Gregory P. Smith
Gregory P. Smith added the comment: I'm not going to spend time manually deleting the unused build directories until the typo in the new buildsuffix that caused the disk to fill up is fixed. https://github.com/python/buildmaster-config/pull/111 I don't even understand why the b

[issue38269] AMD64 Debian PGO 3.x, AMD64 Clang UBSan 2.7 buildbots: No space left on device

2019-09-25 Thread Gregory P. Smith
Gregory P. Smith added the comment: >From a yet another one of a plethora of reasons to hate buildbot point of >view... A _log message_ saying "i'm not using this anymore, you can delete >it" is infinitely worse than just going ahead and automatically deleting it.

[issue38269] AMD64 Debian PGO 3.x, AMD64 Clang UBSan 2.7 buildbots: No space left on device

2019-09-25 Thread Gregory P. Smith
Gregory P. Smith added the comment: Let me know when pr 111 is deployed on the build master so I can log in and cleanup the current typo names. otherwise, things are probably running fine for the moment. -- ___ Python tracker <ht

[issue37958] Adding get_profile_dict to pstats

2019-09-25 Thread Gregory P. Smith
Change by Gregory P. Smith : -- versions: +Python 3.9 -Python 3.7 ___ Python tracker <https://bugs.python.org/issue37958> ___ ___ Python-bugs-list mailin

[issue38216] Fix for issue30458 (HTTP Header Injection) prevents crafting invalid requests

2019-09-26 Thread Gregory P. Smith
Gregory P. Smith added the comment: Regardless, since things have already shipped in stable releases, there is a release that code _will_ encounter somewhere that does validate data but does not support overruling that behavior. so i'm not sure if it actually matters to have this in 3

[issue29988] with statements are not ensuring that __exit__ is called if __enter__ succeeds

2019-09-27 Thread Gregory P. Smith
Gregory P. Smith added the comment: As a note on the general pattern, a user at work diagnosed a ^C problem in their code when running on 2.7 to be due to Queue.get's acquire() try: ... finally: release() Pattern, with the KeyboardInterrupt triggering after acquire() but before the

[issue38115] Invalid bytecode offsets in co_lnotab

2019-09-28 Thread Gregory P. Smith
Gregory P. Smith added the comment: New changeset c8165036f374cd2ee64d4314eeb2514f7acb5026 by Gregory P. Smith (T. Wouters) in branch 'master': bpo-38115: Deal with invalid bytecode offsets in lnotab (GH-16079) https://github.com/python/cpython/commit/c8165036f374cd2ee64d4314eeb251

[issue38115] Invalid bytecode offsets in co_lnotab

2019-09-28 Thread Gregory P. Smith
Change by Gregory P. Smith : -- pull_requests: +16049 pull_request: https://github.com/python/cpython/pull/16464 ___ Python tracker <https://bugs.python.org/issue38

[issue37408] [DOC] Precise that Tarfile "format" argument only concerns writing.

2019-09-28 Thread Gregory P. Smith
Gregory P. Smith added the comment: New changeset c5a7e0ce194c0eafe82eb3e431881012398e7d46 by Gregory P. Smith (Pascal Chambon) in branch 'master': bpo-37408: Precise that Tarfile "format" argument only concerns writing. (GH-14389) https://github.com/p

[issue37408] [DOC] Precise that Tarfile "format" argument only concerns writing.

2019-09-28 Thread Gregory P. Smith
Change by Gregory P. Smith : -- assignee: -> docs@python components: +Documentation -Library (Lib) nosy: +docs@python stage: patch review -> backport needed ___ Python tracker <https://bugs.python.org/i

[issue37408] [DOC] Precise that Tarfile "format" argument only concerns writing.

2019-09-28 Thread Gregory P. Smith
Change by Gregory P. Smith : -- versions: +Python 3.8 ___ Python tracker <https://bugs.python.org/issue37408> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue38115] Invalid bytecode offsets in co_lnotab

2019-09-28 Thread Gregory P. Smith
Gregory P. Smith added the comment: New changeset 36c6fa968016a46a39c3cdbd0a17ea5490dfa343 by Gregory P. Smith in branch '3.8': bpo-38115: Deal with invalid bytecode offsets in lnotab (GH-16079) (GH-16464) https://github.com/python/cpython/commit/36c6fa968016a46a39c3cdbd0a17ea

[issue38115] Invalid bytecode offsets in co_lnotab

2019-09-28 Thread Gregory P. Smith
Gregory P. Smith added the comment: thanks Thomas! -- resolution: -> fixed stage: patch review -> commit review status: open -> closed ___ Python tracker <https://bugs.python.or

[issue38216] Fix for issue30458 (HTTP Header Injection) prevents crafting invalid requests

2019-09-28 Thread Gregory P. Smith
Change by Gregory P. Smith : -- versions: -Python 3.6, Python 3.7, Python 3.8, Python 3.9 ___ Python tracker <https://bugs.python.org/issue38216> ___ ___ Pytho

[issue38216] Fix for issue30458 (HTTP Header Injection) prevents crafting invalid requests

2019-09-28 Thread Gregory P. Smith
Gregory P. Smith added the comment: I'd imagine an equivalent of the 3.6 PR would work for 3.5. Someone should look at how to do similar in 2.7 _if_ the project(s) that complained about the problem rely on such behavior in their last 2.7 compatible rel

[issue38326] Concerns with the last minute changes to the PEP 587 API

2019-09-30 Thread Gregory P. Smith
Change by Gregory P. Smith : -- nosy: +gregory.p.smith ___ Python tracker <https://bugs.python.org/issue38326> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue37951] Disallow fork in a subinterpreter broke subprocesses in mod_wsgi daemon mode

2019-10-07 Thread Gregory P. Smith
Gregory P. Smith added the comment: preexec_fn is fundamentally unsupportable. what code is using it, there should be a way not to rely on that. -- ___ Python tracker <https://bugs.python.org/issue37

[issue38417] Add support for settting umask in subprocess children

2019-10-08 Thread Gregory P. Smith
New submission from Gregory P. Smith : Another use of the deprecated unsafe preexec_fn was to call os.umask in the child prior to exec. As seen in https://github.com/freeipa/freeipa/pull/3769 (see the code in there). We should add an explicit feature for this to avoid people's desir

[issue38417] Add support for settting umask in subprocess children

2019-10-08 Thread Gregory P. Smith
Gregory P. Smith added the comment: We don't have to for all possible things, doing this just reduced friction for existing uses. In this case, calling umask in our child ourselves would be easy to support. (easier than the more important setuid/sid/gid/groups-ish stuff that recently

[issue38417] Add support for settting umask in subprocess children

2019-10-09 Thread Gregory P. Smith
Gregory P. Smith added the comment: We should not provide such an "run arbitrary python code before execing the ultimate child" feature in the standard library. It is complicated, and assumes you have an ability to execute a new interpreter with its own slow startup time as an in

[issue38435] Start the deprecation cycle for subprocess preexec_fn

2019-10-10 Thread Gregory P. Smith
New submission from Gregory P. Smith : subprocess's preexec_fn feature needs to enter PendingDeprecationWarning state in 3.9, to become a DeprecationWarning in 3.10, with a goal of removing it in 3.11. Rationale: We now live in a world full of threads, it is entirely unsafe to call

[issue38417] Add support for settting umask in subprocess children

2019-10-10 Thread Gregory P. Smith
Gregory P. Smith added the comment: preexec_fn has been mentally and advisability deprecated for years. :) I'll mark it officially with pending deprecation in 3.9 destined to be removed in 3.11. tracking that in its own rollup issue https://bugs.python.org/issue38435 As far as posix_

[issue38435] Start the deprecation cycle for subprocess preexec_fn

2019-10-10 Thread Gregory P. Smith
Gregory P. Smith added the comment: With task specific arguments. cwd, start_new_session, group, extra_groups, user, etc.. We cannot provide a general do everything replacement and should not try. It not possible. -- ___ Python tracker <ht

[issue38417] Add support for settting umask in subprocess children

2019-10-12 Thread Gregory P. Smith
Change by Gregory P. Smith : -- assignee: -> gregory.p.smith ___ Python tracker <https://bugs.python.org/issue38417> ___ ___ Python-bugs-list mailing list Un

[issue38417] Add support for settting umask in subprocess children

2019-10-12 Thread Gregory P. Smith
Change by Gregory P. Smith : -- keywords: +patch pull_requests: +16306 stage: needs patch -> patch review pull_request: https://github.com/python/cpython/pull/16726 ___ Python tracker <https://bugs.python.org/issu

[issue38417] Add support for settting umask in subprocess children

2019-10-12 Thread Gregory P. Smith
Gregory P. Smith added the comment: New changeset f3751efb5c8b53b37efbbf75d9422c1d11c01646 by Gregory P. Smith in branch 'master': bpo-38417: Add umask support to subprocess (GH-16726) https://github.com/python/cpython/commit/f3751efb5c8b53b37efbbf75d9422c

[issue38417] Add support for settting umask in subprocess children

2019-10-12 Thread Gregory P. Smith
Gregory P. Smith added the comment: Now to see if the more esoteric config buildbots find any platform issues to address... -- resolution: -> fixed stage: patch review -> commit review status: open -> closed ___ Python tracke

[issue38456] Reduce the time test_subprocess takes to complete.

2019-10-12 Thread Gregory P. Smith
New submission from Gregory P. Smith : test_subprocess is one of our long running tests, this slows down CI and buildbots. There is room for improvement in its total execution time. Use this issue as a rollup issue for any such work. we need to keep it reliable, just focus on reducing

[issue38456] Reduce the time test_subprocess takes to complete.

2019-10-12 Thread Gregory P. Smith
Change by Gregory P. Smith : -- keywords: +patch pull_requests: +16315 stage: -> patch review pull_request: https://github.com/python/cpython/pull/16736 ___ Python tracker <https://bugs.python.org/issu

[issue38456] Reduce the time test_subprocess takes to complete.

2019-10-12 Thread Gregory P. Smith
Gregory P. Smith added the comment: New changeset 67b93f80c764bca01c81c989d74a99df208bea4d by Gregory P. Smith in branch 'master': bpo-38456: Use /bin/true in test_subprocess (GH-16736) https://github.com/python/cpython/commit/67b93f80c764bca01c81c989d74a99

[issue38456] Reduce the time test_subprocess takes to complete.

2019-10-12 Thread Gregory P. Smith
Change by Gregory P. Smith : -- pull_requests: +16316 pull_request: https://github.com/python/cpython/pull/16737 ___ Python tracker <https://bugs.python.org/issue38

[issue38473] AttributeError on asserting autospecced mock object added using attach_mock

2019-10-14 Thread Gregory P. Smith
Change by Gregory P. Smith : -- type: -> behavior ___ Python tracker <https://bugs.python.org/issue38473> ___ ___ Python-bugs-list mailing list Unsubscrib

[issue38456] Reduce the time test_subprocess takes to complete.

2019-10-14 Thread Gregory P. Smith
Gregory P. Smith added the comment: New changeset 4f0587f161786318cdfa22c42459676fa42aacb6 by Gregory P. Smith in branch '3.8': [3.8] bpo-38456: Use /bin/true in test_subprocess (GH-16737) https://github.com/python/cpython/commit/4f0587f161786318cdfa22c4245967

[issue38456] Reduce the time test_subprocess takes to complete.

2019-10-14 Thread Gregory P. Smith
Gregory P. Smith added the comment: I assume the CI systems are shared and potentially noisy. It should be easier to look at some logs from slower buildbots. but sadly test_subprocess has fallen off the list of "10 slowest tests" that timing info is supplied for. concurre

[issue33604] HMAC default to MD5 marked as to be removed in 3.6

2019-10-15 Thread Gregory P. Smith
Change by Gregory P. Smith : -- pull_requests: +16362 stage: commit review -> patch review pull_request: https://github.com/python/cpython/pull/16805 ___ Python tracker <https://bugs.python.org/issu

[issue33604] HMAC default to MD5 marked as to be removed in 3.6

2019-10-15 Thread Gregory P. Smith
Gregory P. Smith added the comment: Thanks for the feedback. Better late than never. :) A default algorithm is a bad thing when it comes to authentication. Explicit is better than implicit. A default regularly becomes obsolete as math and cryptanalysis methods move forward and need to be

[issue33604] HMAC default to MD5 marked as to be removed in 3.6

2019-10-15 Thread Gregory P. Smith
Change by Gregory P. Smith : -- assignee: -> gregory.p.smith ___ Python tracker <https://bugs.python.org/issue33604> ___ ___ Python-bugs-list mailing list Un

[issue33604] HMAC default to MD5 marked as to be removed in 3.6

2019-10-15 Thread Gregory P. Smith
Gregory P. Smith added the comment: BTW, if you want the type annotation that'd be used for this, 3.8 effectively removes the Optional[] from the one listed in: https://github.com/python/typeshed/blob/master/stdlib/2and3/hmac.py

[issue38477] magiccube2x2 permutations 28% slower with Python 3.8.0rc1 vs 3.7

2019-10-16 Thread Gregory P. Smith
Gregory P. Smith added the comment: If I compile my own 3.7.5 and 3.8.0 both with --enable-optimizations, I am unable to reproduce this. greg@zoonaut:~/sandbox/python/cpython/lh$ ../b37/python permutations2x2 --max_depth 6 | egrep "^# Total_Time" # Total_Time: 75.92 greg@zoonaut

[issue38477] magiccube2x2 permutations 28% slower with Python 3.8.0rc1 vs 3.7

2019-10-16 Thread Gregory P. Smith
Change by Gregory P. Smith : -- resolution: -> not a bug stage: -> resolved status: open -> closed ___ Python tracker <https://bugs.python.or

[issue33604] HMAC default to MD5 marked as to be removed in 3.6

2019-10-17 Thread Gregory P. Smith
Gregory P. Smith added the comment: New changeset f33c57d5c780da1500619f548585792bb5b750ee by Gregory P. Smith in branch 'master': bpo-33604: Raise TypeError on missing hmac arg. (GH-16805) https://github.com/python/cpython/commit/f33c57d5c780da1500619f54858579

[issue22385] Define a binary output formatting mini-language for *.hex()

2019-10-20 Thread Gregory P. Smith
Change by Gregory P. Smith : -- resolution: -> fixed stage: patch review -> commit review status: open -> closed versions: +Python 3.9 -Python 3.8 ___ Python tracker <https://bugs.python.or

[issue34776] Postponed annotations break inspection of dataclasses

2019-10-23 Thread Gregory P. Smith
Change by Gregory P. Smith : -- versions: +Python 3.9 ___ Python tracker <https://bugs.python.org/issue34776> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue30458] [security][CVE-2019-9740][CVE-2019-9947] HTTP Header Injection (follow-up of CVE-2016-5699)

2019-10-23 Thread Gregory P. Smith
Gregory P. Smith added the comment: Can you please open a separate issue for CVE-2019-18348? It is easier to track that way. (META: In general I think the CVE process is being abused and that these really did not deserve that treatment. https://lwn.net/Articles/801157/ is good reading

[issue34384] os.readlink does not accept pathlib.Path on Windows

2019-10-23 Thread Gregory P. Smith
Gregory P. Smith added the comment: can this be closed? -- nosy: +gregory.p.smith status: pending -> open ___ Python tracker <https://bugs.python.org/issu

[issue30618] readlink for pathlib paths

2019-10-23 Thread Gregory P. Smith
Change by Gregory P. Smith : -- assignee: -> gregory.p.smith nosy: +gregory.p.smith ___ Python tracker <https://bugs.python.org/issue30618> ___ ___ Python-

[issue30618] readlink for pathlib paths

2019-10-23 Thread Gregory P. Smith
Gregory P. Smith added the comment: Thanks Girts! -- resolution: -> fixed stage: patch review -> commit review status: open -> closed ___ Python tracker <https://bugs.python.or

[issue20443] __code__. co_filename should always be an absolute path

2019-10-23 Thread Gregory P. Smith
Gregory P. Smith added the comment: Please revert. An absolute path changes semantics in many real world situations (altering symlink traversals, etc). People expect the current sys.argv[0] behavior which is "similar to C argv" and matches what was passed on the interpreter co

[issue36541] Make lib2to3 grammar more closely match Python

2019-10-23 Thread Gregory P. Smith
Change by Gregory P. Smith : -- versions: +Python 3.9 -Python 3.6 ___ Python tracker <https://bugs.python.org/issue36541> ___ ___ Python-bugs-list mailin

[issue33348] lib2to3 doesn't parse f(*[] or [])

2019-10-23 Thread Gregory P. Smith
Change by Gregory P. Smith : -- versions: +Python 3.9 -Python 3.6 ___ Python tracker <https://bugs.python.org/issue33348> ___ ___ Python-bugs-list mailin

[issue32496] lib2to3 fails to parse a ** of a conditional expression

2019-10-23 Thread Gregory P. Smith
Change by Gregory P. Smith : -- resolution: -> duplicate stage: -> resolved status: open -> closed superseder: -> lib2to3 doesn't parse f(*[] or []) versions: +Python 3.8, Python 3.9 -Python 3.6 ___ Python tracker <htt

[issue33348] lib2to3 doesn't parse f(*[] or [])

2019-10-23 Thread Gregory P. Smith
Change by Gregory P. Smith : -- assignee: -> gregory.p.smith nosy: +gregory.p.smith ___ Python tracker <https://bugs.python.org/issue33348> ___ ___ Python-

[issue33348] lib2to3 doesn't parse f(*[] or [])

2019-10-23 Thread Gregory P. Smith
Change by Gregory P. Smith : -- versions: +Python 2.7 ___ Python tracker <https://bugs.python.org/issue33348> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue36541] Make lib2to3 grammar more closely match Python

2019-10-23 Thread Gregory P. Smith
Change by Gregory P. Smith : -- assignee: -> gregory.p.smith nosy: +gregory.p.smith ___ Python tracker <https://bugs.python.org/issue36541> ___ ___ Python-

[issue36541] Make lib2to3 grammar better match Python, support the := walrus

2019-10-23 Thread Gregory P. Smith
Change by Gregory P. Smith : -- title: Make lib2to3 grammar more closely match Python -> Make lib2to3 grammar better match Python, support the := walrus ___ Python tracker <https://bugs.python.org/issu

[issue38571] Segfault with StopIteration

2019-10-23 Thread Gregory P. Smith
Gregory P. Smith added the comment: There isn't really much we can do without a reasonable repeatable way to reproduce the problem. -- nosy: +gregory.p.smith ___ Python tracker <https://bugs.python.org/is

[issue20443] __code__. co_filename should always be an absolute path

2019-10-24 Thread Gregory P. Smith
Gregory P. Smith added the comment: I think sys.argv[0] is the important one as program logic often tends to use that as an input. I'm honestly unsure of if this will be as much of a problem for .co_filename or sys.path[0]. -- ___ Python tr

[issue20443] __code__. co_filename should always be an absolute path

2019-10-24 Thread Gregory P. Smith
Gregory P. Smith added the comment: (read that as: feel free to keep the behavior for co_filename and path[0] and lets see what happens :) -- ___ Python tracker <https://bugs.python.org/issue20

[issue33348] lib2to3 doesn't parse f(*[] or [])

2019-10-24 Thread Gregory P. Smith
Gregory P. Smith added the comment: I'm marking this fixed, technically it still exists in 2.7. it'll be up to someone who cares about making a change to 2.7 to make a PR to go in there for the final release. It has existed so long, I doubt it matters there. --

[issue38576] CVE-2019-18348: CRLF injection via the host part of the url passed to urlopen()

2019-10-24 Thread Gregory P. Smith
Change by Gregory P. Smith : -- nosy: +gregory.p.smith ___ Python tracker <https://bugs.python.org/issue38576> ___ ___ Python-bugs-list mailing list Unsubscribe:

<    5   6   7   8   9   10   11   12   13   14   >