Gregory P. Smith <[EMAIL PROTECTED]> added the comment:
Indeed IOBase does call close() from its __del__. Excellent. That
makes this simpler. -gps03 attached.
Added file: http://bugs.python.org/file12154/issue3826_socket-gps03.diff
___
Python t
Changes by Gregory P. Smith <[EMAIL PROTECTED]>:
Removed file: http://bugs.python.org/file12152/issue3826_socket-gps01.diff
___
Python tracker <[EMAIL PROTECTED]>
<http://bugs.pytho
Changes by Gregory P. Smith <[EMAIL PROTECTED]>:
--
assignee: -> gregory.p.smith
nosy: +gregory.p.smith
priority: -> normal
___
Python tracker <[EMAIL PROTECTED]>
<http://bugs
Gregory P. Smith <[EMAIL PROTECTED]> added the comment:
I've attached my first attempt at fixing this as io-bufwrite-gps01.
Unfortunately it causes the Lib/test/test_io.py testThreads to fail:
==
FAIL: testThread
Gregory P. Smith <[EMAIL PROTECTED]> added the comment:
Yep, the test was ignoring the return value from BufferedWriter.write.
Fixed in the attached io-bufwrite-gps02.
This can wait for 3.0.1 and 2.6.1/2 (depending on the 2.6.x release
schedule).
--
keywords: +needs review
Adde
Changes by Gregory P. Smith <[EMAIL PROTECTED]>:
--
components: +Library (Lib) -Extension Modules
type: -> resource usage
versions: +Python 2.5, Python 2.6, Python 2.7 -Python 2.4
___
Python tracker <[EMAIL PROTECTED]>
<http
Gregory P. Smith <[EMAIL PROTECTED]> added the comment:
I agree with Amuary, write() traditionally never writes less data unless
the underlying IO is in nonblocking mode.
I'm working up a new patch to write to self.raw in max_buffer_size
chunks with as few data copies as possible,
Gregory P. Smith <[EMAIL PROTECTED]> added the comment:
Okay, here's a new patch that obeys the blocking vs nonblocking
semantics properly. It still needs explicit unit tests for proper behavior.
Added file: http://bugs.python.org/file12158/issue4428-io-bufwrite
Changes by Gregory P. Smith <[EMAIL PROTECTED]>:
Removed file: http://bugs.python.org/file12155/issue4428-io-bufwrite-gps01.diff
___
Python tracker <[EMAIL PROTECTED]>
<http://bugs.pytho
Changes by Gregory P. Smith <[EMAIL PROTECTED]>:
--
versions: +Python 2.5.3
___
Python tracker <[EMAIL PROTECTED]>
<http://bugs.python.org/issue1868>
___
_
Gregory P. Smith <[EMAIL PROTECTED]> added the comment:
Martin: socket.socket has no destructor so a call to
socket.socket._real_close() is not guaranteed. Thats fine as its parent
class from socketmodule.c _socket.socket does the right thing in its
destructor.
Amaury: The case yo
Gregory P. Smith <[EMAIL PROTECTED]> added the comment:
gps05.diff includes the fix and unittests.
Added file: http://bugs.python.org/file12165/issue3826_gps05.diff
___
Python tracker <[EMAIL PROTECTED]>
<http://bugs.pytho
Changes by Gregory P. Smith <[EMAIL PROTECTED]>:
Removed file: http://bugs.python.org/file12154/issue3826_socket-gps03.diff
___
Python tracker <[EMAIL PROTECTED]>
<http://bugs.pytho
Changes by Gregory P. Smith <[EMAIL PROTECTED]>:
Removed file: http://bugs.python.org/file12156/test_makefileclose.patch
___
Python tracker <[EMAIL PROTECTED]>
<http://bugs.pytho
Changes by Gregory P. Smith <[EMAIL PROTECTED]>:
Removed file: http://bugs.python.org/file12163/issue3826_socket-gps04.diff
___
Python tracker <[EMAIL PROTECTED]>
<http://bugs.pytho
Gregory P. Smith <[EMAIL PROTECTED]> added the comment:
this should be trivial to implement (other than urllib and urllib2 being
a giant mess). adding to my queue.
--
assignee: -> gregory.p.smith
nosy: +gregory.p.smith
___
Python tracke
Gregory P. Smith <[EMAIL PROTECTED]> added the comment:
We need make sure this happens for 2.7/3.1.
As its large enough to be a new feature it won't make it into
2.4/2.5/2.6/3.0.
--
nosy: +gregory.p.smith
priority: normal -> high
versions: +Python 2.7, Python 3
Changes by Gregory P. Smith <[EMAIL PROTECTED]>:
--
assignee: -> gregory.p.smith
nosy: +gregory.p.smith
priority: -> normal
versions: +Python 2.7, Python 3.1 -Python 2.5
___
Python tracker <[EMAIL PROTECTED]>
<http://bugs
Gregory P. Smith <[EMAIL PROTECTED]> added the comment:
patch looks good to me.
nitpick comments: use += instead of = and + in:
newsize = newsize + newsize
and
newsize = newsize + BIGCHUNK.
As for the XXX about overflow, so long as BUFSIZ is not defined to be an
insanely large numb
Gregory P. Smith <[EMAIL PROTECTED]> added the comment:
fileio_buffer2.patch looks good other than minor touchups:
Turn the XXX comment into:
/* NOTE: overflow impossible due to limits on BUFSIZ *
Also, 2 << 24 is 32MB yet your error message test says >= 64MB. I think
you mean
Gregory P. Smith added the comment:
this is not a bug. ask this type of question on comp.lang.python.
in short: 'is' is not an equality comparison operator. it compares
object instance identity.
--
nosy: +gregory.p.smith
resolution: -> invalid
status: o
Gregory P. Smith added the comment:
the only intelligence i'm challenging is that this is not appropriate
for a bug tracker. bring it up on a users mailing list.
___
Python tracker
<http://bugs.python.org/i
Gregory P. Smith added the comment:
should the unit test in test_posix5.patch have been removed? (regardless,
its still on the bug tracker via the history links)
___
Python tracker
<http://bugs.python.org/issue1040
Gregory P. Smith added the comment:
utf16_newlines2.patch looks good to me.
This is a data corruption issue. If it is deferred for 3.0.1 it must be
fixed in 3.0.2.
+1 on putting this in 3.0.1.
--
assignee: -> pitrou
nosy: +gregory.p.smith
priority: -> release b
Changes by Gregory P. Smith :
--
nosy: +gregory.p.smith
___
Python tracker
<http://bugs.python.org/issue4688>
___
___
Python-bugs-list mailing list
Unsubscribe:
Gregory P. Smith added the comment:
First: thanks for doing this. I've had a patch sitting in my own
sandbox to release the GIL while hashing for a while but I hadn't
finished testing it. It looks pretty similar to what you've done so
lets go with the patch being develope
Gregory P. Smith added the comment:
from #python-dev discussion.
agreed, magic attributes are annoying. also, my gps05 patch continues
to return the old fileno even after the underlying socket has been
closed. that is a problem.
I like your patch in #4791 but lets keep both sets of our unit
Gregory P. Smith added the comment:
hashlibopenssl_small_lock-4.diff looks good to me.
I also agree that HASHLIB_GIL_MINSIZE should be lowered to 2048.
Commit it, and please backport it to trunk before closing this bug.
--
nosy: -gps
versions: +Python 2.7, Python 3.1 -Python 3.0
Gregory P. Smith added the comment:
The hashlib docs already mention the problems with md5 et al via a
bright red:
"Warning
Some algorithms have known hash collision weaknesses, see the FAQ at the
end."
thanks for closing this. not gonna happen.
--
nosy: +grego
Changes by Gregory P. Smith :
--
nosy: +gregory.p.smith
___
Python tracker
<http://bugs.python.org/issue4753>
___
___
Python-bugs-list mailing list
Unsubscribe:
Gregory P. Smith added the comment:
When treated as an unsigned 32bit value those are identical.
Guido prefers to keep Python 2.x always having signed values for the
scattered crc functions. We changed it for 3.0 because it makes more
sense given that python these days no real fixed-bits
Gregory P. Smith added the comment:
seems there are bugs with it not staying signed as it should on some
64bit platforms. i'll be looking into this shortly. its a good
candidate bug for 2.6.x and 3.0.x releases.
--
keywords: -easy
___
P
Gregory P. Smith added the comment:
err not 3.0.x, 3.0 is always unsigned like anyone sane would want. :)
--
versions: -Python 3.0
___
Python tracker
<http://bugs.python.org/issue1
Gregory P. Smith added the comment:
Agreed, we failed to mention the behavior change in the docs. I'll take
care of that. (if its mentioned at all, its mentioned in a note buried
in the Misc/NEWS file somewhere)
2to3 could presumably be made to notice crc32 and adler32 calls and
Gregory P. Smith added the comment:
binascii and zlib documentation updated in trunk r68535. I'll close the
issue after I've merged it into release26-maint, release30-maint and
py3k.
Any objections to the wording?
http://svn.python.org/view/python/trunk/Doc/library/binascii.rst?
Gregory P. Smith added the comment:
Benchmarking pitrou_dispatch_2.7.patch applied to trunk r68522 on a 32-
bit Efficeon (x86) using gcc 4.2.4-1ubuntu3 yields a 10% pybench
speedup.
___
Python tracker
<http://bugs.python.org/issue4
Gregory P. Smith added the comment:
Committed all of our tests and the actual code to fix the problem from
socket_real_close-5.patch in py3k r68539.
This still needs back porting to release30-maint assuming no other
issues are found with it.
--
keywords: -needs review
Gregory P. Smith added the comment:
Any crash is a potential security problem.
This needs to be fixed in 2.6.x without breaking 2.6.0 extension
compatibility. (requiring extensions to be recompiled to fix the
problem for an extension is fine, but they still need to load and work
normally
Gregory P. Smith added the comment:
nice hack! :)
I'm going to guess that existing code in the wild setting tp_iternext =
&PyObject_GetIter is rare. I certainly can not rule it entirely out but
I don't see anything in the open source world using
http://www.google.com/code
Gregory P. Smith added the comment:
That mostly meant let the buildbots run it and/or see if anyone
complains on a list. Go ahead and backport. :)
___
Python tracker
<http://bugs.python.org/issue3
Gregory P. Smith added the comment:
backported to release30-maint in r68796.
--
resolution: -> fixed
status: open -> closed
___
Python tracker
<http://bugs.python.org/
Changes by Gregory P. Smith :
Removed file: http://bugs.python.org/file12157/issue4428-io-bufwrite-gps02.diff
___
Python tracker
<http://bugs.python.org/issue4
Changes by Gregory P. Smith :
Added file: http://bugs.python.org/file12806/issue4428-io-bufwrite-gps04.diff
___
Python tracker
<http://bugs.python.org/issue4428>
___
___
Gregory P. Smith added the comment:
Updated patch with unit tests to verify the write behavior attached in
-gps04. Up for code review at http://codereview.appspot.com/12470/show
--
keywords: +needs review
___
Python tracker
<http://bugs.python.
Changes by Gregory P. Smith :
Removed file: http://bugs.python.org/file12158/issue4428-io-bufwrite-gps03.diff
___
Python tracker
<http://bugs.python.org/issue4
Gregory P. Smith added the comment:
Reviewers: Antoine Pitrou,
Message:
Just responding to your comments on the support for generators and non
buffer api supporting inputs.
I'll get to the other comments in the code soon with new unit tests for
those cases.
http://codereview.appspo
Gregory P. Smith added the comment:
I know of no code relying on this behavior, I merely duplicated the
behavior that existed while writing the patch. I'm happy to simplify.
Adding Guido to the CC list for a pronouncement.
Guido is it okay to change io.BufferedWriter.write() in rele
Gregory P. Smith added the comment:
I'll take on the two remaining tasks for this:
* add configure magic to detect when the compiler supports this so
that it can default to --with-computed-gotos on modern systems.
* commit the back port to 2.7 trunk.
--
assignee: -> gregory
Gregory P. Smith added the comment:
FYI - As a side note to this issue of removing the clutter of alternate
names - I intend to gather up the worthy non-clutter additional unittest
assertFoo APIs that we have at Google to contribute towards 3.1/2.7, my
goal is to do this before PyCon this year
Changes by Gregory P. Smith :
--
assignee: purcell -> gregory.p.smith
___
Python tracker
<http://bugs.python.org/issue2578>
___
___
Python-bugs-list mai
Changes by Gregory P. Smith :
--
priority: -> normal
versions: +Python 2.7, Python 3.1 -Python 3.0
___
Python tracker
<http://bugs.python.org/issue2578>
___
_
Gregory P. Smith added the comment:
heh yes, not a big deal but this should raise an overflow error in that
case.
--
assignee: -> gregory.p.smith
nosy: +gregory.p.smith
priority: -> low
___
Python tracker
<http://bugs.python.org/
Gregory P. Smith added the comment:
Fixed in trunk (2.7) r69156.
All places in socketmodule that called htons and silently truncated
values that were too large have been changed to raise OverflowError.
Unit tests included.
I'm leaving this open until it is merged into the py3k branch fo
Gregory P. Smith added the comment:
wording updated in r69159, thanks.
___
Python tracker
<http://bugs.python.org/issue4903>
___
___
Python-bugs-list mailing list
Unsub
Gregory P. Smith added the comment:
and r69161, r69160, r69162, r69163, r69164.
--
resolution: -> fixed
status: open -> closed
versions: +Python 2.7, Python 3.1
___
Python tracker
<http://bugs.python.org/
Gregory P. Smith added the comment:
unassigning, i don't have time to look at this one right now.
--
assignee: gregory.p.smith ->
___
Python tracker
<http://bugs.python.or
Changes by Gregory P. Smith :
Added file: http://bugs.python.org/file12914/issue4428-io-bufwrite-gps05.diff
___
Python tracker
<http://bugs.python.org/issue4428>
___
___
Gregory P. Smith added the comment:
I've uploaded a new patch set with more extensive unit tests. It also
handles the case of writing array.array objects (or anything with a
memoryview itemsize > 1). The previous code would buffer by item rather
than by byte. it has been up
Gregory P. Smith added the comment:
fwiw, I decided Guido and Antoine were right and took out the support
for input that did not support len() to keep things a bit simpler.
___
Python tracker
<http://bugs.python.org/issue4
Gregory P. Smith added the comment:
For network tests like this where it is useful to test against external
servers, could we just pick few known external servers that are unlikely
to every go away?
imap.gmail.com:993 for instance? (i don't know enough about imap to
know if it sup
Changes by Gregory P. Smith :
--
nosy: +gregory.p.smith
___
Python tracker
<http://bugs.python.org/issue3959>
___
___
Python-bugs-list mailing list
Unsubscribe:
Gregory P. Smith added the comment:
fixing now.
--
assignee: twouters -> gregory.p.smith
keywords: +easy
nosy: +gregory.p.smith
___
Python tracker
<http://bugs.python.org/issue1
Gregory P. Smith added the comment:
Sad that this was closed as wontfix years ago. anyways I am fixing
this. see #1008086.
--
keywords: +64bit
nosy: +gregory.p.smith
superseder: -> patch for 767150
___
Python tracker
<http://bugs.pyth
Gregory P. Smith added the comment:
fixed in trunk r69519.
needs backporting to release26-maint and release30-maint. leaving open
until that happens.
--
keywords: +64bit -patch
title: patch for 767150 -> socket.inet_aton returns 8 bytes on LP64 platforms
type: -> behavior
ve
Gregory P. Smith added the comment:
Fixed in py3k branch r69524.
needs porting to release30-maint.
possibly also release26-maint and trunk.
--
priority: -> normal
versions: +Python 2.6, Python 2.7
___
Python tracker
<http://bugs.pyth
Gregory P. Smith added the comment:
fyi - I took care of the unicode data acceptance issue for all hashlib
related modules in the py3k branch in r69524.
--
nosy: +gregory.p.smith
___
Python tracker
<http://bugs.python.org/issue4
Gregory P. Smith added the comment:
fyi - I took care of the unicode data acceptance issue for all hashlib
related modules in the py3k branch in r69524.
Yes, the hashlib modules have a -lot- of code in common. Refactoring
that would be nice but i haven't looked into it. I at least
Gregory P. Smith added the comment:
assigning to me so i don't lose track of making sure this happens for
trunk.
--
assignee: -> gregory.p.smith
components: +Extension Modules -Library (Lib)
___
Python tracker
<http://bugs.python.or
Gregory P. Smith added the comment:
A documentation patch would be appreciated, thanks!
--
nosy: +gregory.p.smith
___
Python tracker
<http://bugs.python.org/issue1161
Gregory P. Smith added the comment:
fixed in release30-maint r69555.
sounds like its out of the question for 2.6. i will backport it to
trunk.
--
keywords: +26backport
versions: -Python 2.6, Python 3.0
___
Python tracker
<http://bugs.python.
Gregory P. Smith added the comment:
Agreed, this would be useful. See http://codereview.appspot.com/12470/show if
anyone doesn't believe us.
;)
___
Python tracker
<http://bugs.python.org/i
Gregory P. Smith added the comment:
fixed in trunk r69561.
--
components: +Extension Modules -Library (Lib)
resolution: -> fixed
status: open -> closed
versions: +Python 3.0, Python 3.1
___
Python tracker
<http://bugs.python.org/
Gregory P. Smith added the comment:
>>> os.environ['FOO']
Traceback (most recent call last):
File "", line 1, in
File "/usr/lib/python2.5/UserDict.py", line 22, in __getitem__
raise KeyError(key)
KeyError: 'FOO'
>>> o
Changes by Gregory P. Smith :
--
resolution: -> fixed
status: open -> closed
versions: +Python 2.7, Python 3.0
___
Python tracker
<http://bugs.python.org/
Gregory P. Smith added the comment:
agreed, looks good. (and thats a good motive)
--
nosy: +gregory.p.smith
___
Python tracker
<http://bugs.python.org/issue5
Changes by Gregory P. Smith :
--
dependencies: +longobject.c: minor fixes, cleanups and optimizations
___
Python tracker
<http://bugs.python.org/issue4
Gregory P. Smith added the comment:
Is there anything on our end we can do to prevent this kind of issue in the
future?
Am I wrong to see this as just fixing our package to avoid a design flaw in
Windows OS level package management?
Certainly other packages in the world must run into
Change by Gregory P. Smith :
--
resolution: -> not a bug
stage: -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Gregory P. Smith added the comment:
New changeset b3f2d4c8bab52573605c96c809a1e2162eee9d7e by Ma Lin in branch
'main':
bpo-47040: improve document of checksum functions (gh-31955)
https://github.com/python/cpython/commit/b3f2d4c8bab52573605c96c809a1e2
Change by Gregory P. Smith :
--
title: Remove invalid versionchanged in doc -> Fix confusing versionchanged
note in crc32 and adler32
___
Python tracker
<https://bugs.python.org/issu
Gregory P. Smith added the comment:
```
$ python3.8
Python 3.8.10 (default, Nov 26 2021, 20:14:08)
[GCC 9.3.0] on linux
Type "help", "copyright", "credits" or "license" for more information.
>>> import binascii, zlib
>>> b
Gregory P. Smith added the comment:
it depends on the build. USE_ZLIB_CRC32 causes it due to zlib's 32-bitness as
noted my marko.
$ ./python
Python 3.11.0a6+ (heads/main-dirty:b3f2d4c8ba, Mar 19 2022, 15:32:04) [GCC
9.4.0] on linux
Type "help", "copyright", "
Change by Gregory P. Smith :
--
keywords: +patch
pull_requests: +30089
stage: needs patch -> patch review
pull_request: https://github.com/python/cpython/pull/32000
___
Python tracker
<https://bugs.python.org/issu
Gregory P. Smith added the comment:
FYI - https://bugs.python.org/issue38256 covers the 32-bit bug.
--
___
Python tracker
<https://bugs.python.org/issue47
Gregory P. Smith added the comment:
If you want to backport the documentation updates, feel free to make PRs for
that.
--
assignee: docs@python -> gregory.p.smith
resolution: -> fixed
stage: patch review -> resolved
status: open
Change by Gregory P. Smith :
--
assignee: -> gregory.p.smith
___
Python tracker
<https://bugs.python.org/issue38256>
___
___
Python-bugs-list mailing list
Un
Gregory P. Smith added the comment:
I agree with the decision, assertAlmostEqual is where the feature belongs.
>From a practical point of view I suspect a lot of people who want this in the
>wider world today use just `assert math.isclose(...)` despite the less useful
>erro
Gregory P. Smith added the comment:
The os module provides a pretty low level simple shim over platform APIs. It is
better for logic like this to live in a higher level application library rather
than make big assumptions on the part of the user.
```
try:
os.fdatasync(fd)
except
Gregory P. Smith added the comment:
New changeset 6d290d5862375799e997f1192ef56abca4e9182e by Ma Lin in branch
'3.10':
[3.10] bpo-47040: improve document of checksum functions (GH-31955) (GH-32002)
https://github.com/python/cpython/commit/6d290d5862375799e997f1192ef56a
Gregory P. Smith added the comment:
New changeset 9d1c4d69dbc800ac344565119337fcf490cdc800 by Gregory P. Smith in
branch 'main':
bpo-38256: Fix binascii.crc32() when inputs are 4+GiB (GH-32000)
https://github.com/python/cpython/commit/9d1c4d69dbc800ac344565119337fc
Change by Gregory P. Smith :
--
pull_requests: +30101
pull_request: https://github.com/python/cpython/pull/32013
___
Python tracker
<https://bugs.python.org/issue38
Change by Gregory P. Smith :
--
title: sys.exit() caught in exception handler -> sys.exit() caught in async
event loop exception handler
___
Python tracker
<https://bugs.python.org/issu
Change by Gregory P. Smith :
--
keywords: +patch
nosy: +gregory.p.smith
nosy_count: 4.0 -> 5.0
pull_requests: +30102
stage: needs patch -> patch review
pull_request: https://github.com/python/cpython/pull/32014
___
Python tracker
Change by Gregory P. Smith :
--
assignee: -> gregory.p.smith
___
Python tracker
<https://bugs.python.org/issue47054>
___
___
Python-bugs-list mailing list
Un
Gregory P. Smith added the comment:
can we reliably query for what the default is and add that to the expectations?
or just skip the test if the defaults don't match our expectations (less
ideal)?
if those are a challenge to do reliably - adding 15, 0 to the expected set may
be the
Gregory P. Smith added the comment:
Definitely not an OS specific concept. Big.little configs are all over the
place on all OSes and architectures these days. With a variety of ways OSes
are experimenting with scheduling for them (nevermind that Android and iOS have
been doing this for a
Gregory P. Smith added the comment:
New changeset 4c989e19c84ec224655bbbde9422e16d4a838a80 by Gregory P. Smith in
branch '3.10':
[3.10] bpo-38256: Fix binascii.crc32 large input. (GH-32000) (GH-32013)
https://github.com/python/cpython/commit/4c989e19c84ec224655bbbde9422e1
Change by Gregory P. Smith :
--
pull_requests: +30103
pull_request: https://github.com/python/cpython/pull/32015
___
Python tracker
<https://bugs.python.org/issue38
Gregory P. Smith added the comment:
New changeset 58a7e130375776b192a99b013bc563205a639edc by Gregory P. Smith in
branch '3.9':
bpo-38256: Fix binascii.crc32 large input. (GH-32000) (GH-32013) (GH-32015)
https://github.com/python/cpython/commit/58a7e130375776b192a99b013bc563
Gregory P. Smith added the comment:
3.8 and older are in security fix only mode. 3.9+ have been fixed.
realistically this was a rare issue with multiple workarounds.
The 3.9 and 3.10 fixes were strictly bugfix only. The 3.11 fix included some
performance improvements
701 - 800 of 3274 matches
Mail list logo
