Gregory P. Smith added the comment:
I'm keeping this open until I backport this to subprocess32 for use on Python 2.
--
stage: needs patch -> commit review
___
Python tracker
<http://bugs.python.org
Gregory P. Smith added the comment:
I wouldn't blame android for this; I doubt Android claims to support whatever
standard you are holding it to.
It seems simple enough for us to make the default configurable (a public module
level constant that anyone can override in their code
Gregory P. Smith added the comment:
indeed, i don't know that there is any point to this idea.
i'm all for just getting rid of all uses of select in the stdlib and making
them poll only in 3.4 unless someone can point to a modern system that does not
su
Gregory P. Smith added the comment:
something to include in your statistics is the lengths of the already hashed
data being compared.
i expect there to be a minimum length before this optimization is useful.
--
nosy: +gregory.p.smith
___
Python
Changes by Gregory P. Smith :
--
assignee: -> gregory.p.smith
___
Python tracker
<http://bugs.python.org/issue16327>
___
___
Python-bugs-list mailing list
Un
Gregory P. Smith added the comment:
python 3 already catches all exceptions and handles closing of p2cwrite,
c2pread and errread here. i don't know which branch this patch is against.
Regardless, it makes sense that the other fd's, if created by us, also need to
be cleaned up.
Gregory P. Smith added the comment:
Stubbing _execute_child out for a test is easiest. No need to craft ways to
cause an actual fork failure.
--
___
Python tracker
<http://bugs.python.org/issue16
Gregory P. Smith added the comment:
A Python test that reproduces this would be nice to have though I realize it
isn't something necessarily useful to run as part of a unittest suite given
this one would rely on OS kernel implementation details and chances of race
conditions occu
Changes by Gregory P. Smith :
--
assignee: -> gregory.p.smith
nosy: +gregory.p.smith
versions: +Python 2.7, Python 3.4, Python 3.5
___
Python tracker
<http://bugs.python.org/issu
Gregory P. Smith added the comment:
Can you attach some python code that reproduces this for you? According to
both of the references below it doesn't sound like this is supposed to be a
problem.
http://pubs.opengroup.org/onlinepubs/9699919799/functions/freeaddrinfo.html
claims
Changes by Gregory P. Smith :
--
resolution: -> fixed
stage: -> committed/rejected
status: open -> closed
versions: +Python 3.5
___
Python tracker
<http://bugs.python.or
Gregory P. Smith added the comment:
I added a pointer to subprocess32 in the 2.7 subprocess docs in dd52365c8721.
--
resolution: -> wont fix
stage: -> committed/rejected
status: open -> closed
___
Python tracker
<http://bugs.python.or
Changes by Gregory P. Smith :
--
nosy: +gregory.p.smith
___
Python tracker
<http://bugs.python.org/issue16991>
___
___
Python-bugs-list mailing list
Unsubscribe:
New submission from Gregory P. Smith:
Executing the supplied test code you either get:
sys.version = 3.4.0+ (3.4:635817da596d, Apr 17 2014, 14:30:34)
[GCC 4.6.3]
Results with :
r0= None, expected None
r1= None, expected None
ri0 = None, expected None
ri1 = -9
Gregory P. Smith added the comment:
Attaching a proposed fix for this issue. It should make the wait() and poll()
methods thread safe. I need to turn the reproducer code into an actual test
case and add more test cases for coverage of all code paths being touched.
I haven't examine
Gregory P. Smith added the comment:
It appears to devolve into linear recursion in this case, one per each item in
one of the sequences being searched for a match, so even using a stack seems
wrong as it'd still be linear (though it would prevent the recursion depth
problem).
The m
Gregory P. Smith added the comment:
that seems reasonable. unittest's assertSequenceEqual is using this to attempt
to display a useful error message as to what the delta was; it should try
harder to avoid difflib corner cases.
At the very least, unittest should recover from a difflib fa
Gregory P. Smith added the comment:
See also http://bugs.python.org/issue21288 to consider one
fix/oversite/addition to the existing API as part of this process. (discuss
that there)
by default: use the exact same API as 3.4 if it is suitable for PEP 466 and
2.7.7's needs. the above iss
Changes by Gregory P. Smith :
--
nosy: +gregory.p.smith
___
Python tracker
<http://bugs.python.org/issue21307>
___
___
Python-bugs-list mailing list
Unsubscribe:
Changes by Gregory P. Smith :
--
nosy: +gregory.p.smith
___
Python tracker
<http://bugs.python.org/issue21308>
___
___
Python-bugs-list mailing list
Unsubscribe:
Changes by Gregory P. Smith :
Added file:
http://bugs.python.org/file35007/issue21291-patch-with-test-gps01.diff
___
Python tracker
<http://bugs.python.org/issue21
Gregory P. Smith added the comment:
This fix is also present in subprocess32 3.2.6 on PyPI for use on Python 2.
--
resolution: -> fixed
stage: -> commit review
status: open -> closed
type: -> behavior
___
Python tracker
<http://
Gregory P. Smith added the comment:
I haven't tried a cross compile in ages. If nothing else I don't think this
issue should be closed until we have at least one buildbot setup to cross
compile it and run it on the target platform.
That's on my long "todo for python"
Gregory P. Smith added the comment:
yes. this was overlooked. thanks!
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<http://bugs.python.or
Gregory P. Smith added the comment:
Don't use print (to stdout) or sys.stderr directly. There are already many
other uses of warnings.warn within the zipfile module. Be consistent with
those.
Existing zipfile warnings seem to favor lazily importing warnings when its
needed rather t
Gregory P. Smith added the comment:
The bug was that BadZipFile was being raised when it shouldn't be so I wouldn't
worry about documenting the behavior change other than in the Misc/NEWS entry
that the ultimate commiter writes up.
--
Gregory P. Smith added the comment:
Thanks for the report, diagnosis and patch! Your change looks good to me.
I'll commit it soon.
--
assignee: -> gregory.p.smith
___
Python tracker
<http://bugs.python.org
Gregory P. Smith added the comment:
This was never an enhancement. zipfile was failing to properly deal with real
world data that other zip file tools on the planet were perfectly happy to deal
with. That's a bug. Fixed.
Practicality beats purity.
Be lenient in what you accept.
Gregory P. Smith added the comment:
Are you aware that the subprocess module does use /proc/self/fd in Python 3.2
and later? The fd closing is not done from Python code.
See Modules/_posixsubprocess.c -
http://hg.python.org/cpython/file/53fa2c9523d4/Modules/_posixsubprocess.c
Changes by Gregory P. Smith :
--
nosy: -gps
___
Python tracker
<http://bugs.python.org/issue21618>
___
___
Python-bugs-list mailing list
Unsubscribe:
Gregory P. Smith added the comment:
regardless, the current C code for this does limit itself to the
sysconf(_SC_OPEN_MAX) max_fd from module import time when closing fds found in
/proc/self/fd so this code does still have a bug in that fds higher than that
will remain unclosed (at which
Gregory P. Smith added the comment:
There appear to be a two bugs here, depending on which platform subprocess is
being used on.
1) on systems where it uses /prod/self/fd, /dev/fd or similar:
It should not pay attention to end_fd at all. It knows the list of actual
open fds and should use
Gregory P. Smith added the comment:
Here's a patch with a unittest that reproduces the problem with fixes to stop
using any end_fds. The max fd is only ever used in the absolute fallback
situation where no way to get a list of open fd's is available. In that case it
is obtained fr
Gregory P. Smith added the comment:
Backported to subprocess32 in
https://code.google.com/p/python-subprocess32/source/detail?r=1c27bfe7e98f78e6aaa746b5c0a4d902a956e2a5
--
resolution: -> fixed
stage: patch review -> commit review
status: open -> closed
versions: +P
Gregory P. Smith added the comment:
Something like the patch i'm attaching to socketmodule.c is what I would
prefer. I haven't looked at or tried tests for it yet.
--
assignee: -> gregory.p.smith
keywords: +patch
Added file: http://bugs.python.org/file35465/issue20611-
Changes by Gregory P. Smith :
--
versions: +Python 3.5 -Python 3.3
___
Python tracker
<http://bugs.python.org/issue20611>
___
___
Python-bugs-list mailin
Changes by Gregory P. Smith :
--
stage: -> test needed
___
Python tracker
<http://bugs.python.org/issue20611>
___
___
Python-bugs-list mailing list
Unsubscrib
Gregory P. Smith added the comment:
Can you provide specific details of exactly which python package from which
distro is installed on the machines?
Are the machines hardware or VMs? if they are VMs, what version of what VM
system and what hardware are the VMs running on?
I'm asking be
Gregory P. Smith added the comment:
> That is, shouldn't we look up `pwd.getpwuid(os.getuid()).pw_shell` ?
> (but only when os.getuid() == os.geteuid()?)
No, you can't use the users shell from the pwd module. That can be
any crazy program. Not a functional /bin/sh for use in
Changes by Gregory P. Smith :
--
assignee: -> gregory.p.smith
nosy: +gregory.p.smith
___
Python tracker
<http://bugs.python.org/issue16409>
___
___
Python-
Changes by Gregory P. Smith :
--
resolution: -> fixed
status: open -> closed
___
Python tracker
<http://bugs.python.org/issue16409>
___
___
Python-bugs-
Gregory P. Smith added the comment:
yes please!
Any reason you're using an unsigned int in your loop instead of a Py_uhash_t?
--
nosy: +gregory.p.smith
___
Python tracker
<http://bugs.python.org/is
Gregory P. Smith added the comment:
People have been posting micro-benchmarks (often run wrong) rather than actual
useful benchmarks. Running our real world benchmarks would be more interesting.
--
nosy: +gregory.p.smith
___
Python tracker
<h
Changes by Gregory P. Smith :
--
assignee: gregory.p.smith ->
___
Python tracker
<http://bugs.python.org/issue812369>
___
___
Python-bugs-list mailing list
Un
Changes by Gregory P. Smith :
--
assignee: gregory.p.smith ->
___
Python tracker
<http://bugs.python.org/issue8865>
___
___
Python-bugs-list mailing list
Un
Changes by Gregory P. Smith :
--
resolution: -> fixed
status: open -> closed
___
Python tracker
<http://bugs.python.org/issue9535>
___
___
Python-bugs-list
Gregory P. Smith added the comment:
regardless of knowing how to reproduce this system call behavior, the changes
necessary to handle robustly it are easy enough. fixed.
3.3+ already handled it if a timeout was specified (new feature). I only had
to fix the default no timeout case
Gregory P. Smith added the comment:
fyi - I agree with your comments about the test and assertRaises. This code is
old, there's a lot that could be improved in there. I chose to maintain a
style equivalent to the existing surrounding code.
Feel free to clean th
Gregory P. Smith added the comment:
Thanks! I'm looking into applying these tonight (including 3.2) with a couple
minor edits.
--
___
Python tracker
<http://bugs.python.org/is
Changes by Gregory P. Smith :
--
resolution: -> fixed
stage: patch review -> committed/rejected
status: open -> closed
___
Python tracker
<http://bugs.python.or
Gregory P. Smith added the comment:
To remove the double close fd-reuse-window race condition you describe in 3.2.3
and later I don't think you even need to add that code snippet. Just get rid
of the for loop calling os.close on those three fd's all together. self.stdin,
self.
Changes by Gregory P. Smith :
--
resolution: -> fixed
status: open -> closed
versions: +Python 2.7
___
Python tracker
<http://bugs.python.org/issue16140>
___
__
Changes by Gregory P. Smith :
--
stage: test needed -> committed/rejected
___
Python tracker
<http://bugs.python.org/issue16140>
___
___
Python-bugs-list mai
Gregory P. Smith added the comment:
That test is gross... it creates a nasty cycle of an instance back to itself
via a stubbed out nested function's enclosing scope.
I'm sanitizing it now to simplify the code and not have any cycles.
--
Gregory P. Smith added the comment:
i'm looking at getting this in.
--
assignee: -> gregory.p.smith
___
Python tracker
<http://bugs.python.org/issue8865>
___
Gregory P. Smith added the comment:
Christian Schubert (apexo) - Would you please submit a PSF contributor
agreement form?
http://www.python.org/psf/contrib/
http://www.python.org/psf/contrib/contrib-form-python/
thanks!
--
___
Python tracker
Gregory P. Smith added the comment:
here's an updated patch.
it strikes me that this should not be a very common problem. how many
applications are going to share the same poll object _across_ multiple threads?
if they do and the file descriptor they'll be spending a lot of time
Gregory P. Smith added the comment:
our patches are similar. i updated it to use long long and Py_ssize_t and
Py_CLEAR and Py_RETURN_NONE in a few places and added comments.
getting rid of the CLEAR_UFDS macro as you did is a good idea
Gregory P. Smith added the comment:
Sorry I can't help on the windows side of things. I don't have access to any
windows systems.
--
___
Python tracker
<http://bugs.python.o
Gregory P. Smith added the comment:
I'm running into this on 2.7.3 with code that worked fine on 2.6.5.
The problem appears to be caused by a 'Host' http header that has a unicode
type for the hostname:port value.
Encoding header values makes sense though I haven't yet e
Changes by Gregory P. Smith :
--
nosy: +gregory.p.smith
___
Python tracker
<http://bugs.python.org/issue16475>
___
___
Python-bugs-list mailing list
Unsubscribe:
Gregory P. Smith added the comment:
I would not allow exceptions to propagate. No caller is expecting them.
--
___
Python tracker
<http://bugs.python.org/issue16
Gregory P. Smith added the comment:
pthread_atfork() cannot be used to implement this. Another non-python
thread started by a C extension module or the C application that is
embedding Python within it is always free to call fork() on its own with
zero knowledge that Python even exists at all
Gregory P. Smith added the comment:
I think you are solving a non-problem if you want to expose exceptions from
such hooks. Nobody needs it.
--
___
Python tracker
<http://bugs.python.org/issue16
Gregory P. Smith added the comment:
Any code conversion is useful. This will help with old libraries and is
even good for just updating old 2.4 code to 2.7 best practices.
--
___
Python tracker
<http://bugs.python.org/issue2
Gregory P. Smith added the comment:
Yes. See my comment from June. The write paths need to be taken care of.
--
___
Python tracker
<http://bugs.python.org/issue12
Changes by Gregory P. Smith :
--
nosy: +gregory.p.smith
___
Python tracker
<http://bugs.python.org/issue8713>
___
___
Python-bugs-list mailing list
Unsubscribe:
Changes by Gregory P. Smith :
--
nosy: +gregory.p.smith
___
Python tracker
<http://bugs.python.org/issue16612>
___
___
Python-bugs-list mailing list
Unsubscribe:
Gregory P. Smith added the comment:
it's a potential bug. your patch looks good.
as for _handle_exitstatus referring to SubprocessError, that is fine. In that
situation it is trying to raise the exception and the only time that would ever
be a problem is when called by the gc dur
New submission from Gregory P. Smith:
test_posix.test_getgrouplist is failing for me on my Linux (ubuntu precise)
based desktop at work.
It looks like posix.getgrouplist() is returning all of the larger GIDs. The
lowest one it is reporting for my user is 499 but the more distro specific
Gregory P. Smith added the comment:
would the values returned by getgrouplist always be a non empty subset of
getgroups? (regardless, I expect the id -G process output parsing can be
removed)
--
title: test_posix.test_getgrouplist fails on some systems - incorrectly
comparing
Gregory P. Smith added the comment:
Given where the crash is occurring and that faulthandler traceback it makes me
wonder if it was compiled with a set of openssl headers that don't make the
library it is using at runtime.
If you recompile the interpreter in debug mode (--with-pydebug on
Gregory P. Smith added the comment:
Given this is more of a code coverage test than any need to test the
functionality of the OS library call, just asserting that it returns a
non-empty list is a decent test. :)
--
___
Python tracker
<h
Gregory P. Smith added the comment:
doesn't the size of code setting up ParseTupleWithKeywords and checking the
values afterwards bother you? that's the same thing only much less consistent.
--
___
Python tracker
<http://bugs.python.o
Gregory P. Smith added the comment:
given the behavior you are seeing, I'm not inclined to trust your computer or
however it is configured. I do not believe this is a Python issue.
3.3 works fine on RHEL 6 so it should work fine on CentOS 6.
http://buildbot.python.org/all/builder
Gregory P. Smith added the comment:
There's a bit of an impasse here on the PEP front. Guido said it wasn't
needed. Antoine brings up the point that CPython developers will have to live
with the result of this work so maybe something more easy to read and see in
one place like a
Gregory P. Smith added the comment:
PEPs are perceived as a hurdle. Regardless, clinic.txt would turn into one
pretty easily so just doing it may be easiest. :)
On Fri, Dec 14, 2012 at 12:11 PM, Antoine Pitrou wrote:
>
> Antoine Pitrou added the comment:
>
> > I have no current
Changes by Gregory P. Smith :
--
nosy: +gregory.p.smith
priority: normal -> critical
___
Python tracker
<http://bugs.python.org/issue16742>
___
___
Python-
Gregory P. Smith added the comment:
If someone thinks this should go into 3.2 and 3.3 they're welcome to do it; no
objections from me. (The behavior was unintentional and thus a bug, but it is
still a minor behavior change)
--
nosy: +gregory.p.
Gregory P. Smith added the comment:
Having just looked added something to test_int as part of issue16772... There
appears to be an explicit test _for_ this strange behavior in there:
http://hg.python.org/cpython/file/60f7197f991f/Lib/test/test_int.py#l233
test_base_arg_with_no_x_arg
I have
Gregory P. Smith added the comment:
Thanks for the pointer to round(). PyNumber_AsSsize_t was just what the doctor
ordered.
PS Grump acknowledged and accepted. Its trunk and we're nowhere near a freeze
so I figured it'd be fine to iterate on it in trunk
Gregory P. Smith added the comment:
I used it because Mark suggested it could have the same behavior as round() and
that is the more abstract API that round uses. Regardless, at this point I've
added tests and tested for the TypeError when a float is passed as well as
testing that the
Changes by Gregory P. Smith :
--
assignee: -> serhiy.storchaka
___
Python tracker
<http://bugs.python.org/issue16772>
___
___
Python-bugs-list mailing list
Un
Gregory P. Smith added the comment:
I think the forkserver approach is a good idea. It is what a lot of users will
choose.
forkserver won't work everywhere though so the fork+exec option is still
desirable to have available. Threads can be started by non-python code
(extension module
Gregory P. Smith added the comment:
ah, i missed that update. cool! +1
--
___
Python tracker
<http://bugs.python.org/issue8713>
___
___
Python-bugs-list mailin
Changes by Gregory P. Smith :
--
assignee: -> gregory.p.smith
nosy: +gregory.p.smith -gps
___
Python tracker
<http://bugs.python.org/issue16946>
___
___
Py
Changes by Gregory P. Smith :
--
nosy: -gregory.p.smith
___
Python tracker
<http://bugs.python.org/issue3718>
___
___
Python-bugs-list mailing list
Unsubscribe:
Gregory P. Smith added the comment:
the patch looks good, thanks! one minor comment in a test but i'll take care
of that as i submit.
--
___
Python tracker
<http://bugs.python.org/i
Changes by Gregory P. Smith :
--
resolution: -> fixed
status: open -> closed
___
Python tracker
<http://bugs.python.org/issue6972>
___
___
Python-bugs-list
Gregory P. Smith added the comment:
it was easier to just take care of auditing the write calls as part of this
given the code change was directly related to it.
On Python 2.7 most of the write calls in the builtin file object
(Objects/fileobject.c) rather than the new io module use the libc
Changes by Gregory P. Smith :
--
resolution: -> fixed
status: open -> closed
___
Python tracker
<http://bugs.python.org/issue12268>
___
___
Python-bugs-
New submission from Gregory P. Smith:
Create a malicious .tar file with entries containing absolute or relative paths
and the tarfile module happily uses them as is without sanity checking.
filed in response to http://bugs.python.org/issue6972 which fixed the zipfile
module for this.
I&#
Gregory P. Smith added the comment:
yes, tarfile appears to have the same problem.
http://bugs.python.org/issue17102 filed.
--
___
Python tracker
<http://bugs.python.org/issue6
Changes by Gregory P. Smith :
--
title: baseManager serve_client() not check EINTR when recv request ->
multiprocessing BaseManager serve_client() does not check EINTR on recv
___
Python tracker
<http://bugs.python.org/issu
Gregory P. Smith added the comment:
given issue 1044, this is not high priority. i still think it'd be useful.
--
priority: high -> normal
___
Python tracker
<http://bugs.python.org
Gregory P. Smith added the comment:
I believe this is all done after Serhiy's fixes.
--
assignee: gregory.p.smith -> serhiy.storchaka
status: open -> closed
___
Python tracker
<http://bugs.python
Gregory P. Smith added the comment:
done.
btw, it looks like benjamin.peterson did it for 2.7 yesterday morning but when
'hg graft' is used to apply a change from another branch the roundup
notification mentions the original commit's author, not the person who did the
pu
Gregory P. Smith added the comment:
Suggested workaround: use io.BytesIO instead of cStringIO.
comments on the patch... in short: your patch is changing an ABI and isn't
suitable for a maintenance release.
I'm not sure how much we can usefully do to cStringIO in a maintenance rele
Gregory P. Smith added the comment:
Include/cStringIO.h is public and the name of the structure "PycStringIO" lacks
an _ which implies that it is public.
There appear to be a few references to it in external projects doing some
searching. A (very old) version of twisted/protocols/_
Gregory P. Smith added the comment:
Serhiy's patch looks good to me.
--
nosy: +gregory.p.smith
___
Python tracker
<http://bugs.python.org/issue6083>
___
___
2501 - 2600 of 3274 matches
Mail list logo
