Gregory P. Smith added the comment:
> Can we prefix MEMORY_SANITIZER with _Py_?
Yes, I wondered if I should do that. not that I expect anyone would ever
define it to mean anything else, but that seems like the right thing to do.
https://github.com/python/cpython/pull/10
Gregory P. Smith added the comment:
New changeset 3015fb8ce4d25603434b9b44bb7effb98a481532 by Gregory P. Smith in
branch 'master':
bpo-35214: Add _Py_ prefix to MEMORY_SANITIZER def. (GH-10503)
https://github.com/python/cpython/commit/3015fb8ce4d25603434b9b44bb7eff
Change by Gregory P. Smith :
--
pull_requests: +9766
___
Python tracker
<https://bugs.python.org/issue35214>
___
___
Python-bugs-list mailing list
Unsubscribe:
Gregory P. Smith added the comment:
New changeset 746b2d35ea47005054ed774fecaed64fab803d7d by Gregory P. Smith in
branch 'master':
bpo-35214: Fix OOB memory access in unicode escape parser (GH-10506)
https://github.com/python/cpython/commit/746b2d35ea47005054ed774fecaed6
Gregory P. Smith added the comment:
Is it an actual problem to compile extension modules with -flto? (I realize as
an extension module there isn't a huge benefit to the concept unless it happens
to have multiple source files or link against a non-shared li
Gregory P. Smith added the comment:
Correct, this issue was filed before we had the new pyc options (which came out
of our September core dev. sprint in 2016 iirc).
I'll just close it, the way forward for people using zip files on modern
CPython interpreters is to explicitly use th
Change by Gregory P. Smith :
--
pull_requests: +9789
___
Python tracker
<https://bugs.python.org/issue35214>
___
___
Python-bugs-list mailing list
Unsubscribe:
Gregory P. Smith added the comment:
New changeset b6f4472dc4190e2fd668490d86aeefd2ab0df935 by Gregory P. Smith in
branch '2.7':
[2.7] bpo-35214: Fix OOB memory access in unicode escape parser (GH-10506)
(GH-10538)
https://github.com/python/cpyt
Change by Gregory P. Smith :
--
priority: normal -> release blocker
___
Python tracker
<https://bugs.python.org/issue31354>
___
___
Python-bugs-list mai
Change by Gregory P. Smith :
--
versions: +Python 3.6, Python 3.8
___
Python tracker
<https://bugs.python.org/issue31354>
___
___
Python-bugs-list mailin
Change by Gregory P. Smith :
--
resolution: -> fixed
stage: patch review -> commit review
status: open -> closed
versions: +Python 3.7, Python 3.8 -Python 3.4, Python 3.5
___
Python tracker
<https://bugs.python.or
Change by Gregory P. Smith :
--
versions: +Python 3.8 -Python 3.6
___
Python tracker
<https://bugs.python.org/issue24209>
___
___
Python-bugs-list mailin
Gregory P. Smith added the comment:
I backported the fix to this in the subprocess32 3.2.5rc1 release I made a week
or two ago.
--
resolution: -> fixed
status: open -> closed
___
Python tracker
<http://bugs.python.org/i
Gregory P. Smith added the comment:
Closing and rejecting based on said discussion.
http://mail.python.org/pipermail/python-dev/2013-June/127143.html
--
nosy: +gregory.p.smith
resolution: -> rejected
status: open -> closed
___
Python tracker
Gregory P. Smith added the comment:
I was merely refactoring for PEP3137, the original version of all that code
prior to 2.7 was in Objects/stringobject.c and long predates me.
--
___
Python tracker
<http://bugs.python.org/issue10
Gregory P. Smith added the comment:
_posixsubprocess already uses the Linux getdent64 syscall when available
(though for different reasons: readdir is not safe in that context).
http://hg.python.org/cpython/file/3f3cbfd52f94/Modules/_posixsubprocess.c#l227
Probing for procfs at configure time
Changes by Gregory P. Smith :
--
nosy: +gregory.p.smith
___
Python tracker
<http://bugs.python.org/issue18408>
___
___
Python-bugs-list mailing list
Unsubscribe:
Gregory P. Smith added the comment:
This patch makes sense to me. I've gone over the code and I cannot spot any
adverse effects. I was wondering in particular if anything would be surprised
to find a non-started thread in _active within the short window where that will
be true but no
Gregory P. Smith added the comment:
The interest is there but nobody is designing or implementing it.
Realistically, make a module sporting the proposed API and put it up on pypi
and after success there: raise the issue on python-ideas.
Read the entire thread here first before designing such
Gregory P. Smith added the comment:
Python already ships with SSL support so the legal ship might have sailed ages
ago if thats what PSF lawyers say. (IANAL)
--
resolution: -> later
status: open -> closed
___
Python tracker
<http://bugs.p
Gregory P. Smith added the comment:
note,
http://docs.scipy.org/doc/scipy/reference/stats.html#statistical-functions is a
very popular module for statistics in Python.
One of the more frequent things I see people include the entire beast of a code
base (scipy and numpy) for is the student&#
New submission from Gregory P. Smith:
This is a very odd inconsistency in math.log behavior. That said, it is
probably only a single bit imprecision at the end of the float result. Still,
10 == 10L so I'd expect math.log of both to give the same result.
oss/cpython/2.7:LOAS$ ./python
P
Gregory P. Smith added the comment:
We found this while refactoring an API to be more consistent about returning
longs vs ints in specific cases. This resulted in another unittest that was
using math.log for a nicer display of the value by magnitude to fail as the
result was slightly
Gregory P. Smith added the comment:
your patch makes sense to me.
--
___
Python tracker
<http://bugs.python.org/issue18742>
___
___
Python-bugs-list mailin
Gregory P. Smith added the comment:
I don't see a patch attached, but I do not recall any good reason off the top
of my head for preexec_fn to be called as late as it is. Moving it up to be
called before the fd closing loop makes sense as a bug fix.
All bets are off when it comes to
New submission from Gregory P. Smith:
A few times now I've seen people write something that overrides and
re-implements the unittest.TestCase run() method, copying most of the
implementation but adding one feature:
The ability for pdb.post_mortem() to be called after every phase of exec
Gregory P. Smith added the comment:
Thanks! Backported to subprocess32 in
https://code.google.com/p/python-subprocess32/source/detail?r=4ba30d9c64296ea0d2959790ab22d0f1a2678064
--
___
Python tracker
<http://bugs.python.org/issue18
Gregory P. Smith added the comment:
fyi - i am unable to reproduce this when using subprocess32 instead of
subprocess. https://pypi.python.org/pypi/subprocess32
That is what i recommend _anyone_ using Python 2.x use instead.
Regardless if this was reintroduced in 2.7.5 we need to re-fix it
Changes by Gregory P. Smith :
--
assignee: -> gregory.p.smith
nosy: +gregory.p.smith
resolution: -> fixed
stage: patch review -> committed/rejected
status: open -> closed
type: -> behavior
___
Python tracker
<http://bugs.pyt
Gregory P. Smith added the comment:
FYI - use the changes made in http://bugs.python.org/issue12268 as a guide for
how to deal with EINTR properly at the C level. See the _PyIO_trap_eintr()
function for example.
See also _eintr_retry_call() in Lib/subprocess.py.
FWIW, there are times when
Gregory P. Smith added the comment:
I wrote too many words. In short:
time.sleep()'s behavior should remain as it is today given how it is documented
to behave. If you disagree, consider adding an optional interruptable=False
parameter so that both behavior options exist.
ALL IO call
Gregory P. Smith added the comment:
comments added to the review.
I don't think a DeprecationWarning should be raised as that'll infuriate users
of python programs more than developers who can fix code.
--
___
Python trac
Gregory P. Smith added the comment:
That warning is correct, there's a bug in the code. but given this is only a
bug when PyMem_MALLOC returns NULL I do not expect this to be an issue for
anyone who does not already have issues.
Regardless, I'm
Gregory P. Smith added the comment:
already fixed, I just manually returned NULL. :)
I suppose we could change PyErr_NoMemory's definition in 3.3 to return a "void
*" instead of "PyObject *" but I'd rather not. In this case the warning caused
me to examine th
New submission from Gregory P. Smith :
telnetlib uses select.select. This limits it to being able to work when file
descriptors are still below FD_SETSIZE (often 1024) meaning it can't be used in
some large programs today.
It should use poll.
(it is probably easy to fix this an
Gregory P. Smith added the comment:
Your updated patch looks fine to me. I don't see any reason not to commit it
and mention it in the release notes. If it has bugs, they can be discovered
and fixed later by people with actual relevant hardware an interest.
--
Gregory P. Smith added the comment:
I don't have a problem with always compiling them.
Distro packagers should see that the stand alone versions are not distributed
with their package that has a dependency on openssl as they'll just be a waste
of space. But that is up to the dist
Gregory P. Smith added the comment:
regarding the attached patch, rather than changing the test at all, I'd leave
it as is. The test as is will do what we want on the buildbots (warning us if
they failed to compile when in debug mode). I am not concerned about it
testing if they com
New submission from Gregory P. Smith :
Lib/email/*.py are fond of using
EMPTYSTRING = ''
and within the code:
EMPTYSTRING.join(...)
instead of just writing:
''.join(...)
They should just do the latter. It'll avoid a name lookup and look less silly
t
Gregory P. Smith added the comment:
going forward with reinit_locks.diff makes sense.
I've added comments to it in the code review link. It is "Patch Set 3"
--
___
Python tracker
<http://bugs.py
New submission from Gregory P. Smith :
./python Lib/test/test_file.py# passes
./python Lib/test/test_file.py , )
not raised
==
FAIL: testStdin (__main__.PyOtherFileTests
Gregory P. Smith added the comment:
Anyone using a preexec function in subprocess has already declared that they
like deadlocks so that isn't an issue. :)
--
___
Python tracker
<http://bugs.python.org/i
Gregory P. Smith added the comment:
threading locks cannot be used to protect things outside of a single process.
Any code using them to do that is broken.
In your examples you are suggesting a class that wants to do one or more mysql
actions within a destructor and worried that the __del__
Gregory P. Smith added the comment:
We could make any later attempt to acquire or release a lock that was
reinitialized while it was held raise an exception.
Such exception raising behavior should be conditional at lock construction
time; some code (such as logging) never wants to deal with
Gregory P. Smith added the comment:
subprocess has nothing to do with this bug. subprocess is safe as of Python
3.2 (and the subprocess32 backport for 2.x). Its preexec_fn argument is
already documented as an unsafe legacy. If you want to replace subprocess, go
ahead, write something new
New submission from Gregory P. Smith :
==
ERROR: test_exist_ok_existing_directory (__main__.MakedirTests)
--
Traceback (most recent call last):
File "Lib
Changes by Gregory P. Smith :
--
versions: +Python 3.2
___
Python tracker
<http://bugs.python.org/issue14992>
___
___
Python-bugs-list mailing list
Unsubscribe:
Changes by Gregory P. Smith :
--
assignee: -> gregory.p.smith
resolution: -> fixed
status: open -> closed
___
Python tracker
<http://bugs.python.or
Gregory P. Smith added the comment:
What is x32?
--
___
Python tracker
<http://bugs.python.org/issue15000>
___
___
Python-bugs-list mailing list
Unsubscribe:
Gregory P. Smith added the comment:
Answering my own question I believe x32 is the new ABI being worked on as
described in http://lwn.net/Articles/456731/.
In that light, your patch makes sense assuming the __ILP32__ define is
something gcc's cpp will always be defining when targetin
Gregory P. Smith added the comment:
for reference - https://sites.google.com/site/x32abi/
--
___
Python tracker
<http://bugs.python.org/issue15000>
___
___
Pytho
Changes by Gregory P. Smith :
--
resolution: -> fixed
status: open -> closed
___
Python tracker
<http://bugs.python.org/issue15000>
___
___
Python-bugs-
Changes by Gregory P. Smith :
--
assignee: -> gregory.p.smith
nosy: +gregory.p.smith
___
Python tracker
<http://bugs.python.org/issue8865>
___
___
Python-
New submission from Gregory P. Smith :
Many random bits of the standard library were originally written using
select.select. This is an ancient API that is available everywhere, but these
days you'd be hard pressed to find _any_ system that does not implement the
superior poll() API
Gregory P. Smith added the comment:
I think your approach is fine.
BTW for anyone who wants to chase the larger idea of dealing with all
select.select use, take a look at the prototype for a select.select()
implemented using poll.poll() that I just put in
http://bugs.python.org/issue15032
Gregory P. Smith added the comment:
Thanks. I still intend to get to this.
On Jun 23, 2012 1:59 AM, "Georg Brandl" wrote:
>
> Georg Brandl added the comment:
>
> Deferring for beta1 at least.
>
> --
> priority: rele
Changes by Gregory P. Smith :
--
nosy: +gregory.p.smith
___
Python tracker
<http://bugs.python.org/issue15139>
___
___
Python-bugs-list mailing list
Unsubscribe:
Changes by Gregory P. Smith :
--
nosy: +gregory.p.smith
___
Python tracker
<http://bugs.python.org/issue15061>
___
___
Python-bugs-list mailing list
Unsubscribe:
Gregory P. Smith added the comment:
I'm leaving this open as I still need to audit the write methods and commit the
fix(es) for 2.7.
I tried to merge the test into test_io's signals tests but I could not get that
to actually work to reproduce the original problem so I kept my pro
Gregory P. Smith added the comment:
I'm attaching an updated patch for 2.7. It fixes read, readline, readlines and
readinto and includes tests.
More code auditing for other methods to fix is still needed.
--
versions: -Python 3.1
Added file: http://bugs.python.org/file2614
Gregory P. Smith added the comment:
The 3.* ubuntu arm buildbot hanging in test_io is very odd.
I'm going to undo my supposedly straight forward signal.alarm(...) to
signal.setitimer(...) change first to see if that is related.
--
___
P
Changes by Gregory P. Smith :
Removed file: http://bugs.python.org/file22258/file-signal-eintr-27.diff
___
Python tracker
<http://bugs.python.org/issue12268>
___
___
Pytho
Changes by Gregory P. Smith :
Removed file:
http://bugs.python.org/file22262/test_and_fix_readers_3.2-gps02.diff
___
Python tracker
<http://bugs.python.org/issue12
Gregory P. Smith added the comment:
The uses of fwrite() and fflush() also need this EINTR treatment in 2.7. I
haven't checked the write paths in 3.2 yet.
Also, the fix change to 3.2's _io module needs backporting to 2.7's _io module
for pe
Gregory P. Smith added the comment:
Better debuggability FTW! This is an update to Tools/gdb/ as such I'd like to
see this make it into 3.3.
It doesn't touch the runtime or stdlib so I personally wouldn't consider this
"adding a feature" and thus preventing its i
Gregory P. Smith added the comment:
Nope.
--
___
Python tracker
<http://bugs.python.org/issue15139>
___
___
Python-bugs-list mailing list
Unsubscribe:
Gregory P. Smith added the comment:
Updated in 3.3 for beta2.
I'll leave it up to release managers to decide if they want to apply these
updates for future 2.7 and 3.2 releases (trivial, just be sure to keep our one
local modification adding the "#define XML_HAS_SET_HASH_SALT&q
Gregory P. Smith added the comment:
Reasons why it is a good idea to apply this change to 2.7.4 and 3.2.4:
* Memory leak in poolGrow (CVE-2012-1148)
* Resource leak in readfilemap.c (CVE-2012-1147)
* Buffer over-read and crash in big2_toUtf8 (CVE-2009-3560)
* Parser crash with special UTF-8
Gregory P. Smith added the comment:
looking at this now. 2.7 commit first; then i'll forward port to 3.2/3.3.
--
assignee: jackdied -> gregory.p.smith
___
Python tracker
<http://bugs.python.org
Changes by Gregory P. Smith :
--
resolution: -> fixed
stage: -> committed/rejected
status: open -> closed
___
Python tracker
<http://bugs.python.or
Gregory P. Smith added the comment:
Those should all be fixed as of my most recent commit.
--
___
Python tracker
<http://bugs.python.org/issue14635>
___
___
Pytho
Changes by Gregory P. Smith :
--
nosy: +gregory.p.smith
___
Python tracker
<http://bugs.python.org/issue10399>
___
___
Python-bugs-list mailing list
Unsubscribe:
Changes by Gregory P. Smith :
--
nosy: +gregory.p.smith
___
Python tracker
<http://bugs.python.org/issue11549>
___
___
Python-bugs-list mailing list
Unsubscribe:
Gregory P. Smith added the comment:
makes sense for 3.3 as i would consider it a bug.
i think it is reasonable for 2.7 and 3.2 as well, it is an actual bug that the
value reported to getsizeof on struct.Struct is meaningless.
--
nosy: +gregory.p.smith
Gregory P. Smith added the comment:
The only edit that is needed is for md5 to be documented as unavailable when
Python has been compiled in FIPS-compliant mode. Most of the world does not
and will never use that mode.
md5 is still a perfectly good algorithm for many uses and is required
Changes by Gregory P. Smith :
--
assignee: -> gregory.p.smith
keywords: +needs review
nosy: +gregory.p.smith
___
Python tracker
<http://bugs.python.org/issu
Gregory P. Smith added the comment:
The always present hashes do use openssl if the openssl version hashlib was
compiled against supports them. otherwise it falls back to the builtin C
implementations.
--
___
Python tracker
<h
Changes by Gregory P. Smith :
--
nosy: +gregory.p.smith
___
Python tracker
<http://bugs.python.org/issue15578>
___
___
Python-bugs-list mailing list
Unsubscribe:
Gregory P. Smith added the comment:
I'd also like a command line flag to override PYTHONPATH (which could also be
used in combination with -E so that you could still set the PYTHONPATH while
ignoring everything else). I'll file a separate feature request for that.
-
New submission from Gregory P. Smith:
I'd like a command line flag to override PYTHONPATH. It could also be used in
combination with -E so that you could still set the PYTHONPATH while ignoring
everything else from the environment.
--
messages: 168429
nosy: gregory.p.smith
pri
Gregory P. Smith added the comment:
-1 on doing this from me.
While I don't see it hurting anything when "type(query) is dict" I'd much
rather encourage people to write better tests that do not take the lazy way
out. Tests that get by comparing a generated string to a
Gregory P. Smith added the comment:
easy enough to reproduce...
$ ./python.exe -c 'import os, subprocess as s; os.close(0); os.close(1);
s.Popen(["/bin/true"])'
Traceback (most recent call last):
File "", line 1, in
File "/Users/gps/python/hg/defau
Gregory P. Smith added the comment:
Yes, something along the lines of that patch is what I was thinking. BTW, this
is only necessary for the errpipe_write fd. errpipe_read is for the parent
process.
I'm going to do it within _create_pipe so that the optimal
_posixsubprocess.cloexec
Gregory P. Smith added the comment:
F_DUPFD_CLOEXEC appears exclusive to modern Linux kernels. Any idea how wide
spread support for plain F_DUPFD is? If that is "everywhere" the code I've
just whipped up could lose a lot of loops...
--
___
Gregory P. Smith added the comment:
Here's my initial fix.
If fcntl(errpipe_write, F_DUPFD, 3) is widely available this could be shrunk a
bit to avoid the for loop potentially calling dup a few times and tracking the
wasted fds to close later.
Otherwise if it isn't I'd rather
Gregory P. Smith added the comment:
When we added this functionality to assertEqual we were *intentionally*
conservative on when it would auto-promote to nicer equality comparison
functions. It needs to behave exactly as == would in all situations.
>>> (1,2,3) == [1,2,3]
False
Gregory P. Smith added the comment:
thanks! I'll take care of getting this fix in.
--
assignee: -> gregory.p.smith
___
Python tracker
<http://bugs.python.org
Gregory P. Smith added the comment:
fyi - i suspect Python 3.2 and the backport of that to 2.x
http://code.google.com/p/python-subprocess32/ do not have this issue.
but you didn't give enough information in the bug report for me to know which
pipe and which read call you're talkin
Gregory P. Smith added the comment:
Yeah, sounds like _eintr_retry_call alone isn't appropriate here in 2.7.
I'll fix it.
In practice I doubt this matters much as this error string is likely to be
less than one page (depends on pathnames involved) but it is still
technically in
Changes by Gregory P. Smith :
--
resolution: -> fixed
status: open -> closed
___
Python tracker
<http://bugs.python.org/issue15756>
___
___
Python-bugs-
Gregory P. Smith added the comment:
This was fixed in April.
--
resolution: -> fixed
status: open -> closed
___
Python tracker
<http://bugs.python.org/i
Changes by Gregory P. Smith :
--
priority: normal -> high
___
Python tracker
<http://bugs.python.org/issue12268>
___
___
Python-bugs-list mailing list
Unsubscri
Changes by Gregory P. Smith :
--
resolution: -> fixed
status: open -> closed
___
Python tracker
<http://bugs.python.org/issue2489>
___
___
Python-bugs-list
New submission from Gregory P. Smith:
Ben Leslie writes this on python-dev:
Hi all,
I have a Python program where I have many threads each calling Popen, and I was
hitting some trouble.
I've been seeing this on 3.2.3, however I believe the same issue is still
potentially a problem on
Gregory P. Smith added the comment:
What you've described makes sense.
The file descriptors are indeed conditionally wrapped in file objects using
io.open which could lead to a double close in the error case in a threaded
application. yuck.
1) The code needs to check if the fd was wr
Changes by Gregory P. Smith :
--
assignee: -> gregory.p.smith
nosy: +gregory.p.smith
___
Python tracker
<http://bugs.python.org/issue16134>
___
___
Python-
Gregory P. Smith added the comment:
don't worry about optimization settings in python itself for now. the
canonical optimized version will be in a future openssl version. now that it
has been declared the standard it will get a *lot* more attention in the next
few years.
as it is, we
Gregory P. Smith added the comment:
Unless someone supplies a patch that works inter-operably across all platforms
using public APIs in openssl and with the internals of all of python's builtin
non-openssl hash functions including unitests for all of the above... This
isn't g
New submission from Gregory P. Smith:
The atexit module's _run_exitfuncs() function needs to be a public API. In
Python 2.x it was exposed through a disgusting hack as "sys.exitfunc()" that
the atexit module monkeypatched into place at import time.
This monkeypatching wa
Gregory P. Smith added the comment:
replacing repr(args[0]) with repr(executable) in the identified python should
be sufficient for this bug as originally reported.
BUT it goes deeper: I just ran into this error in a different case. It also
happens when cwd is passed and the chdir(cwd
2401 - 2500 of 3274 matches
Mail list logo
