Gregory P. Smith added the comment:
Thanks for pointing me at this issue Ned. It sounds like there is a behavior
difference between Windows and POSIX systems related to the current directory
and/or which process environment is used by the system call that launches the
new process to find
Change by Gregory P. Smith :
--
assignee: -> gregory.p.smith
___
Python tracker
<https://bugs.python.org/issue15533>
___
___
Python-bugs-list mailing list
Un
Gregory P. Smith added the comment:
Additional related PR: https://github.com/python/cpython/pull/6641 tied to
issue33387 which proposes replacing the existing with and try related bytecodes
with two simpler ones: RERAISE and WITH_EXCEPT_FINISH.
--
nosy: +gregory.p.smith
Change by Gregory P. Smith :
--
nosy: +gregory.p.smith, ncoghlan, serhiy.storchaka
___
Python tracker
<https://bugs.python.org/issue33387>
___
___
Python-bug
Gregory P. Smith added the comment:
IIRC that we decided that CPython and extension modules always require -fwrapv.
--
___
Python tracker
<https://bugs.python.org/issue34
Gregory P. Smith added the comment:
https://github.com/python/cpython/blob/2.7/configure.ac#L1067
appears to add -fwrapv as desired if the gcc or clang version being used
supports it.
--
___
Python tracker
<https://bugs.python.org/issue34
Gregory P. Smith added the comment:
yep. i'm going to close this, it seems arch specific. there isn't much we can
realistically do to prevent people overriding things to their peril for
configure or make. :)
--
resolution: -> not a bug
stage: -> resolved
status
Change by Gregory P. Smith :
--
versions: +Python 3.7, Python 3.8 -Python 3.3
___
Python tracker
<https://bugs.python.org/issue1621>
___
___
Python-bugs-list m
Change by Gregory P. Smith :
--
assignee: -> gregory.p.smith
nosy: +gregory.p.smith
versions: +Python 3.6, Python 3.7, Python 3.8 -Python 3.5
___
Python tracker
<https://bugs.python.org/issu
Change by Gregory P. Smith :
--
pull_requests: +8384
stage: needs patch -> patch review
___
Python tracker
<https://bugs.python.org/issue13312>
___
___
Python-
Gregory P. Smith added the comment:
New changeset 76be0f8b7dbe649ad4821144461800ffb0d0 by Gregory P. Smith in
branch 'master':
bpo-13312: Avoid int underflow in time year. (GH-8912)
https://github.com/python/cpython/commit/76be0f8b7dbe649ad482114446
Gregory P. Smith added the comment:
OverflowError is now raised for negative values that would trigger a problem
and the unittest has been updated to test this.
--
resolution: -> fixed
stage: patch review -> resolved
status: open -&g
Gregory P. Smith added the comment:
someone with modern AIX access reopen if this specific issue still appears to
exist after the 3.8 and 3.7 PRs finish merging.
--
nosy: +gregory.p.smith
stage: patch review -> resolved
status: open -> closed
title: test_subprocess error
Change by Gregory P. Smith :
--
resolution: -> fixed
___
Python tracker
<https://bugs.python.org/issue11193>
___
___
Python-bugs-list mailing list
Unsubscrib
Gregory P. Smith added the comment:
https://github.com/python/cpython/pull/8939 and
https://github.com/python/cpython/pull/8946
--
___
Python tracker
<https://bugs.python.org/issue11
Change by Gregory P. Smith :
--
resolution: -> duplicate
stage: needs patch -> resolved
status: open -> closed
superseder: -> tarfile: Traversal attack vulnerability
___
Python tracker
<https://bugs.python
Gregory P. Smith added the comment:
New changeset 51a4743d19abd016f0772a57fb31df7af9220e18 by Gregory P. Smith
(Matthias Bussonnier) in branch 'master':
bpo-33604: Remove deprecated HMAC default value marked for removal in 3.8
(GH-7063)
https://github.com/python/cpyt
Change by Gregory P. Smith :
--
resolution: -> fixed
stage: patch review -> commit review
status: open -> closed
type: -> behavior
versions: -Python 3.6
___
Python tracker
<https://bugs.python
Gregory P. Smith added the comment:
lets call this fixed. if and only if another Python implementation pipes up as
happier if this exists in an older than 3.8 version we can consider backporting
the same refactoring to that code.
--
resolution: -> fixed
stage: patch rev
Gregory P. Smith added the comment:
My problem with a warning is the standard one: People who see a warning are
often end users of python applications (who don't even have to know what Python
is, let alone know anything about the code). For that reason, never add a
warning to a s
Gregory P. Smith added the comment:
New changeset ce34410b8b67f49d8275c05d51b3ead50cf97f48 by Gregory P. Smith in
branch 'master':
bpo-32270: Don't close stdin/out/err in pass_fds (GH-6242)
https://github.com/python/cpython/commit/ce34410b8b67f49d8275c05d5
Gregory P. Smith added the comment:
This isn't limited to just IPv4Address, the Network classes and the IPv6
classes that accept bytes should also be updated for consistency if we're going
to do this.
(bytes, bytearray, memoryview) make sense to support, and explicitly test in
Gregory P. Smith added the comment:
New changeset f019579828ed62653e2d41c95278308fa076ccaf by Gregory P. Smith (Lew
Kurtz) in branch 'master':
bpo-33460: remove ellipsis that look like continuation prompts (GH-7851)
https://github.com/python/cpyt
Change by Gregory P. Smith :
--
versions: +Python 3.8
___
Python tracker
<https://bugs.python.org/issue33487>
___
___
Python-bugs-list mailing list
Unsubscribe:
Gregory P. Smith added the comment:
New changeset ffa198c642f9c67b84ef192bf0f7016c4249e570 by Gregory P. Smith
(Matthias Bussonnier) in branch 'master':
bpo-33487: improve BZ2File Deprecation and documentation. (GH-6785)
https://github.com/python/cpyt
Gregory P. Smith added the comment:
thanks!
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Gregory P. Smith added the comment:
New changeset 9c4a63fc17efea31ad41f90d28825be37469e0e2 by Gregory P. Smith
(Miss Islington (bot)) in branch '3.7':
bpo-32270: Don't close stdin/out/err in pass_fds (GH-6242) (GH-9148)
https://github.com/python
Gregory P. Smith added the comment:
New changeset 3666b3c1f695a145adab1bf644c22e564e8eb0ee by Gregory P. Smith
(Zackery Spytz) in branch 'master':
bpo-33032: Mention the implicit cache in struct.Struct() docs (GH-7700)
https://github.com/python/cpyt
Gregory P. Smith added the comment:
thanks!
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Gregory P. Smith added the comment:
New changeset 2173bb818c6c726d831b106ed0d3fad7825905dc by Gregory P. Smith
(Miss Islington (bot)) in branch '3.6':
bpo-32270: Don't close stdin/out/err in pass_fds (GH-6242) (GH-9149)
https://github.com/python
New submission from Gregory P. Smith :
filing this issue to track https://github.com/python/cpython/pull/9170
--
assignee: gregory.p.smith
messages: 325073
nosy: gregory.p.smith
priority: normal
pull_requests: 8627
severity: normal
status: open
title: re module microoptimization: speed
Gregory P. Smith added the comment:
Confirming the microoptimization here with a non-debug (opt) build:
~/oss/cpython$ sre-before/python -m timeit -s "import re; s = (b'~' * 100);
f = re.compile(b'\s\w\d').search" "f(s)"
20 loops, best of 5: 1
Gregory P. Smith added the comment:
+1 agreed.
--
nosy: +gregory.p.smith
___
Python tracker
<https://bugs.python.org/issue34637>
___
___
Python-bugs-list mailin
Gregory P. Smith added the comment:
I suggest also allowing the first argument to be a keyword named sequence= as
well. (along the philosophy of positional only arguments on APIs that happen
to be implemented in C in CPython are a bad legacy)
pypy already uses these names:
https
Change by Gregory P. Smith :
--
resolution: -> fixed
stage: -> commit review
status: open -> closed
___
Python tracker
<https://bugs.python.or
Gregory P. Smith added the comment:
This is consistent for me, not random. run -m test.regrtest in -v mode and it
passes. remove the -v and it fails.
run Lib/test/test_pkg.py directly and it fails with the details mentioned here.
this prevents CI builds from succeeding for me now
Gregory P. Smith added the comment:
confirmed that this is present in 3.7 rev 72c34cf6dd as well.
--
nosy: +ned.deily
priority: high -> release blocker
___
Python tracker
<https://bugs.python.org/issu
Gregory P. Smith added the comment:
marking release blocker solely because this prevents CI runs from succeeding.
I'm surprised how long this issue has been here though, i don't know what
caused it to start happening consistently but as with many such heisenbugs
changes at a dist
Gregory P. Smith added the comment:
this also happens in 3.6. whatever the problem is, it has been around a long
time.
--
priority: release blocker -> deferred blocker
versions: +Python 3.6
___
Python tracker
<https://bugs.python.org/issu
Gregory P. Smith added the comment:
and I do agree that it is somewhat random. while i have some situations where
I can reproduce this, i have others where I can rerun exactly the same binary
and single process single thread process running just test_pkg.py and nothing
else where the
Change by Gregory P. Smith :
--
assignee: -> gregory.p.smith
___
Python tracker
<https://bugs.python.org/issue34200>
___
___
Python-bugs-list mailing list
Un
Gregory P. Smith added the comment:
kinda poking at ideas here, but from a lunch conversation could this be related
to the filesystem iteration order within the temp directories.
assigned to me while i investigate possibilities.
--
___
Python
Gregory P. Smith added the comment:
I can make the test reliable... but I wouldn't say I fully understand the
ultimate cause of the problem.
The reliability fix for test_pkg is to stop using test.support.modules_setup()
and test.support.modules_cleanup() in the setUp() and tea
Change by Gregory P. Smith :
--
keywords: +patch
pull_requests: +8679
stage: -> patch review
___
Python tracker
<https://bugs.python.org/issue34200>
___
_
Gregory P. Smith added the comment:
this is also present in 3.5, but it'll be up to the 3.5 release manager to
cherry pick the test_pkg.py reliability fix into the 3.5 branch if it impacts
them during the release process.
--
versions: +Pytho
Gregory P. Smith added the comment:
I still feel like there is an underlying issue within the import system that
use of test.support.modules_cleanup somehow triggers that I never managed to
really understand.
but the particular issue in this bug that people were seeing frequently is
fixed
Change by Gregory P. Smith :
--
stage: -> patch review
type: -> behavior
___
Python tracker
<https://bugs.python.org/issue34658>
___
___
Python-bugs-list
New submission from Gregory P. Smith :
Found in the stdlib test suite while testing the fix for bpo-6721: When
subprocess is called with a preexec_fn and os.register_at_fork has been used
and the fork() system call fails, the Python error state is set before the
"after fork in parent pr
Change by Gregory P. Smith :
--
keywords: +patch
pull_requests: +8687
___
Python tracker
<https://bugs.python.org/issue34658>
___
___
Python-bugs-list mailin
Change by Gregory P. Smith :
--
components: +Extension Modules
___
Python tracker
<https://bugs.python.org/issue34658>
___
___
Python-bugs-list mailing list
Unsub
Gregory P. Smith added the comment:
+1 agreed. this is the simplest approach to start with.
Code to restrict: os.fork itself and disallowing the use of preexec_fn on
subprocess within subinterpreters.
feel free to ignore preexec_fn in subprocess for the time being if desired, we
already
Gregory P. Smith added the comment:
New changeset 19003841e965bbf56fd06824d6093620c1b66f9e by Gregory P. Smith in
branch 'master':
bpo-6721: Hold logging locks across fork() (GH-4071)
https://github.com/python/cpython/commit/19003841e965bbf56fd06824d60936
Change by Gregory P. Smith :
--
pull_requests: +8723
___
Python tracker
<https://bugs.python.org/issue34658>
___
___
Python-bugs-list mailing list
Unsubscribe:
Change by Gregory P. Smith :
--
resolution: -> fixed
stage: patch review -> commit review
status: open -> closed
versions: -Python 3.6
___
Python tracker
<https://bugs.python.or
Gregory P. Smith added the comment:
Given the FreeBSD default and seeming desirability of vfork for this use case,
is there a good reason using vfork could not be the default behavior on any OS
that supports it?
--
___
Python tracker
<ht
Gregory P. Smith added the comment:
Give all of this, the lesson I'd take away is perhaps that we should just
provide the constant in the os module when available at build time (a configure
check) and let people who find a need to use it on their system check for its
presence and use
Gregory P. Smith added the comment:
Agreed on not exposing it.
It seems obsolete in recent glibc and the older glibc implementations that had
it may have made questionable decisions. :)
Thanks for chiming in Florian, and thanks Pablo for your detailed
investigation
Change by Gregory P. Smith :
--
nosy: +gregory.p.smith
versions: +Python 3.8
___
Python tracker
<https://bugs.python.org/issue34776>
___
___
Python-bugs-list m
Gregory P. Smith added the comment:
fwiw, agreed that this should wait for 3.7.2.
--
___
Python tracker
<https://bugs.python.org/issue34776>
___
___
Python-bug
Change by Gregory P. Smith :
--
versions: +Python 3.8
___
Python tracker
<https://bugs.python.org/issue29988>
___
___
Python-bugs-list mailing list
Unsubscribe:
New submission from Gregory P. Smith :
The following test code segfaults on Python 2.7:
```python
import io
class X(io.RawIOBase):
def readable(self):
return True
def readinto(self, b):
if isinstance(b, memoryview):
print(b.format) # XXX boom, crashes here.
return 0
Change by Gregory P. Smith :
--
nosy: +gregory.p.smith
versions: +Python 3.7, Python 3.8 -Python 3.5
___
Python tracker
<https://bugs.python.org/issue15
Gregory P. Smith added the comment:
The problem with a SyntaxWarning is that the wrong people will see it. It gets
in the way of users of applications that happen to be written in Python.
scenarios:
(a) A Python interpreter gets upgraded, and suddenly the _users_ of an
application start
Gregory P. Smith added the comment:
If we were to ship a "chaos" mode in the CPython interpreter itself, I assume
you envision an interpreter flag and/or env var? If it required someone
compiling the interpreter a special way I don't think it would be widely
adopted wi
Gregory P. Smith added the comment:
The intent is to use only enable this during testing / continuous integration.
--
___
Python tracker
<https://bugs.python.org/issue34
Gregory P. Smith added the comment:
New changeset 3b699932e5ac3e76031bbb6d700fbea07492641d by Gregory P. Smith
(Miss Islington (bot)) in branch '3.7':
bpo-6721: Hold logging locks across fork() (GH-4071) (#9291)
https://github.com/python/cpyt
New submission from Gregory P. Smith :
These lines used to exist in Modules/expat/expat_external.h:
/* Namespace external symbols to allow multiple libexpat version to
co-exist. */
#include "pyexpatns.h"
https://github.com/python/cpython/commit/5dc3f23b5fb0b510926012cb3732dae63cd
Gregory P. Smith added the comment:
Not a release blocker as most users probably do not run into this problem, but
the pyexpatns.h mechanics should be restored.
--
assignee: -> gregory.p.smith
components: +Build, Extension Modules
nosy: +benjamin.peterson
stage: -> needs
Gregory P. Smith added the comment:
This appears to not have been shipped in a release yet. It is new in 3.6.7.
cc'ing ned daily to see if he wants to include the fix (the PR is trivial,
coming ASAP).
I don't have a good feel for how this impacts the real world or not.
We notic
Change by Gregory P. Smith :
--
keywords: +patch
pull_requests: +9290
stage: needs patch -> patch review
___
Python tracker
<https://bugs.python.org/issu
Gregory P. Smith added the comment:
New changeset 9d4712bc8f26bf1d7e626b53ab092fe030bcd68d by Gregory P. Smith in
branch 'master':
bpo-35011: Restore use of pyexpatns.h in libexpat (GH-9939)
https://github.com/python/cpython/commit/9d4712bc8f26bf1d7e626b53ab092f
Change by Gregory P. Smith :
--
resolution: -> fixed
stage: patch review -> commit review
status: open -> closed
___
Python tracker
<https://bugs.python.or
Gregory P. Smith added the comment:
correct, i don't see an obvious problem in the existing code.
--
nosy: +gregory.p.smith
___
Python tracker
<https://bugs.python.org/is
Gregory P. Smith added the comment:
FYI, An example of other fallout from this change - patsy broke and needed this
fix:
https://github.com/pydata/patsy/commit/4f53bbaf58c0bf1a9bed73fc67c7c6d0aa7f4e20#diff-53c70e68c6dfd4fe9b08427792cb2bd6
--
nosy: +gregory.p.smith
Gregory P. Smith added the comment:
some pylint fallout appears to be addressed in
https://github.com/PyCQA/pylint/commit/2698cbe56b44df7974de1c3374db8700296c6fad
--
___
Python tracker
<https://bugs.python.org/issue33
Gregory P. Smith added the comment:
New changeset dfba1f67e7f1381ceb7cec8fbcfa37337620a9b0 by Gregory P. Smith (Tal
Einat) in branch 'master':
bpo-33899: Mention tokenize behavior change in What's New (GH-10073)
https://github.com/python
Change by Gregory P. Smith :
--
nosy: +gregory.p.smith
versions: +Python 3.7
___
Python tracker
<https://bugs.python.org/issue33012>
___
___
Python-bugs-list m
Gregory P. Smith added the comment:
I left comments on the github PRs with reasons why, but PR 6008 seems correct.
PR 10057 would leave us with undefined behavior.
--
___
Python tracker
<https://bugs.python.org/issue33
Gregory P. Smith added the comment:
This is presumably also present in 3.6 and 2.7 so I've tagged those on the
issue, but for this kind of change i'd leave it up to release managers to see
if they want to backport something of this nature that late in those release
cycles.
Obser
New submission from Gregory P. Smith :
The behavior change introduced in 3.6.7 and 3.7.1 via
https://bugs.python.org/issue33899 has further consequences:
```python
>>> tokenize.untokenize(tokenize.generate_tokens(io.StringIO('#').readline))
Traceback (most recent call last)
Gregory P. Smith added the comment:
https://bugs.python.org/issue35107 filed to track further fallout from this API
change.
--
___
Python tracker
<https://bugs.python.org/issue33
Gregory P. Smith added the comment:
Interesting! I have a 3.6.2 sitting around and cannot reproduce that "x=1"
behavior.
I don't know what the behavior _should_ be. It just feels natural that
untokenize should be able to round trip anything tokenize or generate_tokens
New submission from Gregory P. Smith :
An off by one error was introduced to peephole.c by the "off by one error fix"
in https://bugs.python.org/issue28517. Clang's memory sanitizer detects it
(msan).
find_op is ultimately called with h == codelen so it accesses one byte out
Gregory P. Smith added the comment:
the off by one error fix here introduced a new off by one error. PR coming,
follow https://bugs.python.org/issue35193 for that.
--
nosy: +gregory.p.smith
___
Python tracker
<https://bugs.python.org/issue28
Change by Gregory P. Smith :
--
keywords: +patch
pull_requests: +9698
stage: -> patch review
___
Python tracker
<https://bugs.python.org/issue35193>
___
_
Gregory P. Smith added the comment:
New changeset 49fa4a9f1ef387e16596f271414c855339eadf09 by Gregory P. Smith in
branch 'master':
bpo-35193: Fix an off by one error in the RETURN_VALUE case. (GH-10418)
https://github.com/python/cpython/commit/49fa4a9f1ef387e16596f271414c85
Change by Gregory P. Smith :
--
pull_requests: +9703
___
Python tracker
<https://bugs.python.org/issue35193>
___
___
Python-bugs-list mailing list
Unsubscribe:
Gregory P. Smith added the comment:
New changeset 65e1a1fd311943866361fcb288c0df65dadbe092 by Gregory P. Smith in
branch '3.6':
bpo-35193: Fix an off by one error in the RETURN_VALUE case. (GH-10418)
(GH-10422)
https://github.com/python/cpyt
Gregory P. Smith added the comment:
I'm working on getting a memory-sanitizer buildbot setup. I'm so happy it made
finding and debugging this relatively easy.
--
resolution: -> fixed
stage: patch review -> resolved
status
New submission from Gregory P. Smith :
clang's memory sanitizer (-fsanitize=memory) turns up useful problems in code.
I'm working on getting a CPython buildbot running it setup but would like our
build to be cleaner to start with before I run that.
These are the initial fixes re
Change by Gregory P. Smith :
--
keywords: +patch
pull_requests: +9746
___
Python tracker
<https://bugs.python.org/issue35214>
___
___
Python-bugs-list mailin
Gregory P. Smith added the comment:
New changeset 1584a0081500d35dc93ff88e5836df35faf3e3e2 by Gregory P. Smith in
branch 'master':
bpo-35214: Initial clang MemorySanitizer support (GH-10479)
https://github.com/python/cpython/commit/1584a0081500d35dc93ff88e5836df
Change by Gregory P. Smith :
--
pull_requests: +9749
___
Python tracker
<https://bugs.python.org/issue35214>
___
___
Python-bugs-list mailing list
Unsubscribe:
Gregory P. Smith added the comment:
New changeset 5f4d05d83fde05fed0b6554d0beee4f1c1f1d8f1 by Gregory P. Smith in
branch '3.7':
[3.7] bpo-35214: Initial clang MemorySanitizer support (GH-10479) (GH-10492)
https://github.com/python/cpython/commit/5f4d05d83fde05fed0b6554d0beee4
Change by Gregory P. Smith :
--
pull_requests: +9751
___
Python tracker
<https://bugs.python.org/issue35214>
___
___
Python-bugs-list mailing list
Unsubscribe:
Gregory P. Smith added the comment:
it still seems relevant, having better docs is always good.
--
___
Python tracker
<https://bugs.python.org/issue25
Gregory P. Smith added the comment:
New changeset 3b5b1c0931cd32253bbf2f3bd74e90ff821e026e by Gregory P. Smith in
branch '3.6':
[3.6] bpo-35214: Initial clang MemorySanitizer support (GH-10479) (GH-10493)
https://github.com/python/cpython/commit/3b5b1c0931cd32253bbf2f3bd74e90
Change by Gregory P. Smith :
--
pull_requests: +9760
___
Python tracker
<https://bugs.python.org/issue35214>
___
___
Python-bugs-list mailing list
Unsubscribe:
Gregory P. Smith added the comment:
yeah, i've been surprised how far i was able to get from an oss CPython tree
and pre-built clang 7 binary installation. If you have headers installed for
common libraries like libssl-dev and libreadline-dev you can't produce an
interpreter th
Change by Gregory P. Smith :
--
pull_requests: +9763
___
Python tracker
<https://bugs.python.org/issue35214>
___
___
Python-bugs-list mailing list
Unsubscribe:
2301 - 2400 of 3274 matches
Mail list logo
