Gregory P. Smith added the comment:
New changeset 79760ed256987cead08d668b95675afba6b3760f by Gregory P. Smith in
branch 'master':
bpo-20104: Add os.posix_spawn documentation. (#6334)
https://github.com/python/cpython/commit/79760ed256987cead08d668b95675a
Gregory P. Smith added the comment:
PR 6332 is overall a good cleanup. I pushed a couple changes to that PR and
left comments for some others. It should go in.
There are basic tests for os.posix_spawn in test_posix.py. More would be nice
as we don't currently have any for the error
Gregory P. Smith added the comment:
https://github.com/python/cpython/pull/6332 appears to address this.
--
___
Python tracker
<https://bugs.python.org/issue33
Gregory P. Smith added the comment:
A raw os.posix_spawn() API has been added to 3.7.
vfork() would likely all sorts of other problems. It is extremely complicated
and implementations have bugs. CERT says never to use it.
https://wiki.sei.cmu.edu/confluence/pages/viewpage.action?pageId
Change by Gregory P. Smith :
--
assignee: -> gregory.p.smith
resolution: -> rejected
stage: -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python
New submission from Gregory P. Smith :
Build CPython (master in this case - though I originally noticed the problem
when building a 3.6 tree) as follows with clang installed:
build$ LD=clang-5.0 LDFLAGS=-fsanitize=undefined CC=clang-5.0 CXX=clang-5.0
CFLAGS=-fsanitize=undefined CXXFLAGS
Change by Gregory P. Smith :
--
nosy: +benjamin.peterson, fweimer
___
Python tracker
<https://bugs.python.org/issue33312>
___
___
Python-bugs-list mailin
Change by Gregory P. Smith :
--
nosy: +twouters
___
Python tracker
<https://bugs.python.org/issue33312>
___
___
Python-bugs-list mailing list
Unsubscribe:
Gregory P. Smith added the comment:
related: https://ssl.icu-project.org/trac/ticket/13503
--
___
Python tracker
<https://bugs.python.org/issue33312>
___
___
Gregory P. Smith added the comment:
I think it is worth getting such a change in.
its arguable that the compiler should be able to see through the union for this
use case but I assume such a fix would only land in a recent clang version.
i'm attaching a variant on your patch that do
Gregory P. Smith added the comment:
notably, C99 variable length arrays syntax is not mentioned as allowed in
https://www.python.org/dev/peps/pep-0007/. If we want to use VLAs, that should
be clarified. But both our solutions should work with [1] instead of [] which
is allowed by the ubsan
Change by Gregory P. Smith :
--
pull_requests: +6233
stage: needs patch -> patch review
___
Python tracker
<https://bugs.python.org/issue33312>
___
___
Python-
Change by Gregory P. Smith :
--
pull_requests: +6234
stage: needs patch -> patch review
___
Python tracker
<https://bugs.python.org/issue24318>
___
___
Python-
Gregory P. Smith added the comment:
FYI - The test suite minus some of the crazier tests (multiprocessing) that the
makefile uses today is the recommended workload and is effectively what linux
distros I've looked at use.
It is a myth that the specific application workload matters a
Gregory P. Smith added the comment:
By my reading on how strict aliasing works, I think just changing the
int64_t[1] or int32_t[1] in my PR to char[1] will work as char is always
assumed to alias?
the clang ubsan i was testing my PR against wasn't warning me about strict
ali
Gregory P. Smith added the comment:
I'm going to see what appveyor says with the VLA code on the PR. I've updated
it to use char[].
--
___
Python tracker
<https://bugs.python.o
Gregory P. Smith added the comment:
My PR is almost a revert of
https://github.com/python/cpython/commit/186122ead26f3ae4c2bc9f6715d2a29d339fdc5a
so I'm curious what your motivation behind that change to use the union was?
--
___
Python tr
Gregory P. Smith added the comment:
New changeset 397f1b28c4a12e3b3ed59a89599eabc457412649 by Gregory P. Smith in
branch 'master':
bpo-33312: Fix clang ubsan out of bounds warnings in dict. (GH-6537)
https://github.com/python/cpython/commit/397f1b28c4a12e3b3ed59a89599eab
Gregory P. Smith added the comment:
If you think this should be written differently, please propose it in a PR so
we can see what you are suggesting.
An unbounded member at the end of a struct is quite a common practice in C.
ex: PyBytesObject
Gregory P. Smith added the comment:
New changeset 392520bd78cd18639a27e5d2803c2e1c2bd593a8 by Gregory P. Smith
(Miss Islington (bot)) in branch '3.7':
bpo-33312: Fix clang ubsan out of bounds warnings in dict. (GH-6537) (GH-6543)
https://github.com/python/cpyt
Gregory P. Smith added the comment:
ned: yes, it supposedly has. test_gdb. in a manner i cannot reproduce or
debug without error output that indicates anything about the problem.
test_gdb passes on my systems.
--
___
Python tracker
<ht
Gregory P. Smith added the comment:
I see one line in Tools/gdb/libpython.py that may be related. i'll try
changing that. the only way i have to _test_ it is to merge it into master.
--
___
Python tracker
<https://bugs.python.org/is
Change by Gregory P. Smith :
--
pull_requests: +6245
___
Python tracker
<https://bugs.python.org/issue33312>
___
___
Python-bugs-list mailing list
Unsubscribe:
Gregory P. Smith added the comment:
New changeset 53f67d401df40486fd0fb8fbcf9da725cd37290c by Gregory P. Smith in
branch 'master':
bpo-33312: update Tools/gdb/libpython.py to match. (GH-6548)
https://github.com/python/cpython/commit/53f67d401df40486fd0fb8fbcf9da7
Gregory P. Smith added the comment:
New changeset 11659d00b9185c8f02ea6b642fa475a80e21f1a9 by Gregory P. Smith
(Miss Islington (bot)) in branch '3.7':
bpo-33312: update Tools/gdb/libpython.py to match. (GH-6549)
https://github.com/python/cpython/commit/11659d00b9185c8f02ea6b642fa475
New submission from Gregory P. Smith :
CPython needs to be regularly built and vetted for C undefined behavior.
CFLAGS=-fsanitize=undefined LDFLAGS=-fsanitize=undefined CC=clang LD=clang
./configure
is all it takes to start with.
if you do this today, test_ctypes will knock your socks off
Gregory P. Smith added the comment:
Sorry for the breakage. I'm glad the fix was that greppable and easy given I
had no idea where to start otherwise. :)
This is in for 3.7. The PR for 3.6 is pending, i want to let it out in the
next 3.7 builds for a while before i merge it into 3.6
Gregory P. Smith added the comment:
+1 in general to this work. Łukasz is effectively preaching to the choir by
looping me in here. :)
It is a big challenge to practically support Python in that we have no good
ability to parse and understand all language syntax versions via a single API
Change by Gregory P. Smith :
--
versions: +Python 3.8 -Python 3.6
___
Python tracker
<https://bugs.python.org/issue26834>
___
___
Python-bugs-list mailin
Gregory P. Smith added the comment:
Since this is a new API, the most important thing is to have decided how we
want it to look in 3.7, it is okay for it to be missing features so long as the
API doesn't prevent them from being added in the future.
ie: It is fine to ship it wi
Gregory P. Smith added the comment:
FWIW, I would _love_ to see this. But I don't wrangle Windows myself so I
can't usefully offer anything other than being happy to volunteer to run a
Clang on Windows buildbot VM once there is something to actually be run.
--
nosy: +grego
Gregory P. Smith added the comment:
Pablo, Victor, Ned and I synced up at the pycon2018 sprints. We're removing
posix_spawn from 3.7 (https://github.com/python/cpython/pull/6794) while the
API is worked on.
--
___
Python tracker
&
Change by Gregory P. Smith :
--
versions: +Python 3.8 -Python 3.7
___
Python tracker
<https://bugs.python.org/issue28287>
___
___
Python-bugs-list mailin
Change by Gregory P. Smith :
--
nosy: +gregory.p.smith
___
Python tracker
<https://bugs.python.org/issue33453>
___
___
Python-bugs-list mailing list
Unsubscribe:
Gregory P. Smith added the comment:
the PRs were merged, marking this as fixed.
--
nosy: +gregory.p.smith
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Gregory P. Smith added the comment:
New changeset 8e633a4035bcff458c45fa095f4b8eab2f158466 by Gregory P. Smith
(Pablo Galindo) in branch '3.7':
bpo-20104: Remove posix_spawn from 3.7 (GH-6794)
https://github.com/python/cpython/commit/8e633a4035bcff458c45fa095f4b8e
Change by Gregory P. Smith :
--
priority: release blocker -> normal
versions: -Python 3.7
___
Python tracker
<https://bugs.python.org/issue20104>
___
___
Py
Change by Gregory P. Smith :
--
components: +Library (Lib)
___
Python tracker
<https://bugs.python.org/issue20104>
___
___
Python-bugs-list mailing list
Unsub
Change by Gregory P. Smith :
--
pull_requests: +6537
___
Python tracker
<https://bugs.python.org/issue24318>
___
___
Python-bugs-list mailing list
Unsubscribe:
Change by Gregory P. Smith :
--
keywords: +patch
pull_requests: +6548
stage: needs patch -> patch review
___
Python tracker
<https://bugs.python.org/issu
Gregory P. Smith added the comment:
If the behavior was consistent from 3.3 through 3.6, that is the behavior we
should keep going forward in 3.7+ without a deprecation period. (and this does
not seem worth deprecating, lets just keep the behavior the same as it was in
3.3-3.6)
That 2.7 is
Gregory P. Smith added the comment:
FYI - We run into this problem getting things using gettext for i18n within a
hermetic zipped up Python application at work. I'm not reopening it as I have
nothing new to propose right now, but figured I'd drop a note that it does seem
like a
Gregory P. Smith added the comment:
any thoughts on this Antoine?
--
nosy: +gregory.p.smith, pitrou
title: `wait` and `as_completed` depend on private api -> concurrent.futures
`wait` and `as_completed` depend on private api
___
Python trac
Gregory P. Smith added the comment:
Please try to reproduce this with Python 3.6.
On 2.7, I highly recommend you stop using the Python 2.7 subprocess module and
install the subprocess32 backport available on PyPI. It is *much* more reliable
Gregory P. Smith added the comment:
Using new syscalls for _posixsubprocess.c would be a feature so it would be
limited to 3.7+ if done at all.
My gut feeling is that the real bug is in *any* library code that uses
pthread_atfork() in a non thread safe manner. That code is fundamentally
Change by Gregory P. Smith :
--
components: +Extension Modules -Interpreter Core
type: behavior -> enhancement
___
Python tracker
<https://bugs.python.org/issu
Change by Gregory P. Smith :
--
assignee: -> gregory.p.smith
nosy: +gregory.p.smith
___
Python tracker
<https://bugs.python.org/issue31756>
___
___
Python-
Change by Gregory P. Smith :
--
pull_requests: +4042
___
Python tracker
<https://bugs.python.org/issue6721>
___
___
Python-bugs-list mailing list
Unsubscribe:
Gregory P. Smith added the comment:
logging is pretty easy to deal with so I created a PR.
bufferedio.c is a little more work as we either need to use the posixmodule.c
os.register_at_fork API or expose it as an internal C API to be able to call it
to add acquires and releases around the
Change by Gregory P. Smith :
--
nosy: -gregory.p.smith
___
Python tracker
<https://bugs.python.org/issue25083>
___
___
Python-bugs-list mailing list
Unsubscribe:
Gregory P. Smith added the comment:
I'm un-cc'ing myself as I don't use Python 2 in an environment where we allow
it to write .pyc files at application runtime.
--
___
Python tracker
<https://bugs.pyt
Gregory P. Smith added the comment:
New changeset 7fed7bd8bb628f0f09c6011871a4ce68afb41b18 by Gregory P. Smith
(andyclegg) in branch 'master':
bpo-31756: subprocess.run should alias universal_newlines to text (#4049)
https://github.com/python/cpyt
Change by Gregory P. Smith :
--
resolution: -> fixed
stage: patch review -> commit review
status: open -> closed
___
Python tracker
<https://bugs.python.or
Gregory P. Smith added the comment:
I'd raise a ValueError in that case.
--
___
Python tracker
<https://bugs.python.org/issue31702>
___
___
Python-bugs-l
Gregory P. Smith added the comment:
I'd stick with ValueError in that case as well. if someone dislikes the
valueerrors because they _want_ to use an invalid one, they can file a bug
and we'll reconsider only if they have a meaningful use case.
On Wed, Oct 25, 2017 at 9:36 AM Serhiy
Gregory P. Smith added the comment:
If we do this, I think we should aim for the complete solution on the most
common posix platforms (Linux and MacOS) as C/C++ extensions are just as happy
to create threads these days. (but if you want to start with a simple python
threads only warning
Gregory P. Smith added the comment:
obviously didn't make it in 3.6 but this still seems desirable. I just saw
someone at work propose a trivial port of golang's sort.Search -
https://golang.org/pkg/sort/#Search - in Python which caused me to hunt for an
issue on bisect ke
Change by Gregory P. Smith :
--
assignee: -> gregory.p.smith
nosy: +gregory.p.smith
___
Python tracker
<https://bugs.python.org/issue25942>
___
___
Python-
Change by Gregory P. Smith :
--
versions: +Python 3.7 -Python 3.5
___
Python tracker
<https://bugs.python.org/issue25942>
___
___
Python-bugs-list mailin
Gregory P. Smith added the comment:
On Mon, Nov 6, 2017 at 3:11 PM Neil Schemenauer
wrote:
>
> Neil Schemenauer added the comment:
>
> Hi Victor,
>
> My first guess is that the build bot is not cleaning the fprofile
> information after updating the source tree. A few
Change by Gregory P. Smith :
--
resolution: -> works for me
stage: -> resolved
status: open -> closed
type: performance -> compile error
___
Python tracker
<https://bugs.python
Gregory P. Smith added the comment:
We're still seeing this (in 2.7.12, but the code at 2.7 head hasn't changed).
In this case the RLock being used within _acquireLock() still exists but is an
incomplete object by the time we use it.
--
resolution: fixed ->
status: c
Change by Gregory P. Smith :
--
assignee: -> gregory.p.smith
___
Python tracker
<https://bugs.python.org/issue21149>
___
___
Python-bugs-list mailing list
Un
Change by Gregory P. Smith :
--
pull_requests: +4321
stage: resolved -> patch review
___
Python tracker
<https://bugs.python.org/issue21149>
___
___
Python-
Gregory P. Smith added the comment:
New changeset e84f6d3817ad3d18fdfbb5223b8078606166cea0 by Gregory P. Smith in
branch '2.7':
[2.7] bpo-21149: Workaround a GC finalization bug in logging. (#4368)
https://github.com/python/cpython/commit/e84f6d3817ad3d18fdfbb5223b8078
Change by Gregory P. Smith :
--
resolution: -> fixed
stage: patch review -> commit review
status: open -> closed
type: -> behavior
___
Python tracker
<https://bugs.python
Gregory P. Smith added the comment:
Given this is gcc exploding, I'm not sure there is anything we can do about it.
I _believe_ we're doing everything right.
--
___
Python tracker
<https://bugs.python.o
Change by Gregory P. Smith :
--
nosy: -gregory.p.smith
___
Python tracker
<https://bugs.python.org/issue13986>
___
___
Python-bugs-list mailing list
Unsubscribe:
Change by Gregory P. Smith :
--
nosy: +gregory.p.smith, twouters
___
Python tracker
<https://bugs.python.org/issue32248>
___
___
Python-bugs-list mailin
Gregory P. Smith added the comment:
New changeset 2d8f06382e7d5a759ca554110a699a397114824a by Gregory P. Smith
(izbyshev) in branch 'master':
bpo-32369: test_subprocess: Fix pass_fds check in test_close_fds() (#4920)
https://github.com/python/cpyt
Gregory P. Smith added the comment:
+1 on doing this.
It might also be worth examining all of the latest package version wheels on
pypi to see which packages claiming to support Python 3 have binary wheels
containing untagged .pyd or .so files.
--
nosy: +gregory.p.smith
Gregory P. Smith added the comment:
Also, even if they are common, it seems reasonable that pip could be trained to
rename untagged binaries on install after doing something to determine if they
should be compatible with >=3.7 or
Change by Gregory P. Smith :
--
keywords: +patch
pull_requests: +4871
stage: -> patch review
___
Python tracker
<https://bugs.python.org/issue32278>
___
___
Py
Change by Gregory P. Smith :
--
nosy: +gregory.p.smith
___
Python tracker
<https://bugs.python.org/issue32278>
___
___
Python-bugs-list mailing list
Unsubscribe:
Change by Gregory P. Smith :
--
pull_requests: +4914
___
Python tracker
<https://bugs.python.org/issue25942>
___
___
Python-bugs-list mailing list
Unsubscribe:
Gregory P. Smith added the comment:
you'll notice I added an alternate PR. I don't like the complication of adding
yet another knob (cleanup_timeout) to subprocesses already giant API surface.
It will rarely be used.
My PR tries to take a practical approach: Just wait a li
New submission from Gregory P. Smith :
We should add a wrapper for both signalfd() and a function to read and decode
the structure from the fd into a dataclass.
The code we need to build such a thing from appears to exist in BSD & MIT
licensed form in:
PyPI contains two extension mo
Gregory P. Smith added the comment:
An example subprocess improvement using sigtimedwait() -
https://github.com/python/cpython/pull/5035 - led me to believe that signalfd()
is superior as it sounds like signalfd() does not require pthread_sigmask
(sigprocmask) global state manipulation calls
Gregory P. Smith added the comment:
New changeset 3ceaed0dce81fd881bbaf2dbdbe827d9681887da by Gregory P. Smith
(Segev Finer) in branch '2.7':
bpo-18035: telnetlib: select.error doesn't have an errno attribute (#5044)
https://github.com/python
Change by Gregory P. Smith :
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
type: -> behavior
___
Python tracker
<https://bugs.python
Gregory P. Smith added the comment:
My reading of the Linux signalfd man page may be optimistic. :)
Regardless, it'd be nice to have it available in the stdlib so it could be used
if deemed useful. I expect this to only ever be added by someone making use of
it in another stdlib module
New submission from Gregory P. Smith :
I've tried reading various RFCs around Base64 encoding, but I couldn't make the
ends meet. Yet there is an inconsistency between base64.decodebytes() and
base64.decode() in that how they handle linebreaks that were used to collate
the en
New submission from Gregory P. Smith :
see the attached sample code demonstrating the problem.
basically lib2to3 fails to parse:
dummy(**kwargs if kwargs else dict())
with an error like:
raise ParseError("bad input", type, value, context)
lib2to3.pgen2.parse.ParseError: bad i
Change by Gregory P. Smith :
--
resolution: rejected ->
stage: needs patch -> patch review
status: closed -> open
type: performance -> enhancement
___
Python tracker
<https://bugs.python
Gregory P. Smith added the comment:
New changeset 93f9a8a5afb58b1d2e4f27bb46d3d4e0fa8c08f0 by Gregory P. Smith in
branch 'master':
bpo-24318: Rewrite the README PGO section. (#6863)
https://github.com/python/cpython/commit/93f9a8a5afb58b1d2e4f27bb46d3d4
Change by Gregory P. Smith :
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Gregory P. Smith added the comment:
New changeset dff46758f267ad6c13096c69c4e1dee17f9969aa by Gregory P. Smith in
branch 'master':
bpo-19950: Clarify unittest TestCase instance use. (GH-6875)
https://github.com/python/cpython/commit/dff46758f267ad6c13096c69c4e1dee17f9969aa
-
Gregory P. Smith added the comment:
Your PRs made modifications to code and did not include a useful commit message
or appropriate NEWS entries for the code modifications.
Further, VSTS is unreliable. core-workflow made a premature decision to turn
off Travis and AppVeyor and make VSTS
Gregory P. Smith added the comment:
I've emailed support@github on this one. Their UI is horrible, "show all
checks" does not show them all. It shows five at most.
It is an invisible scrolling region. We're forced to manually mouse over and
scroll down in that region
Change by Gregory P. Smith :
--
resolution: -> fixed
stage: -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.org/issue33522>
___
___
New submission from Gregory P. Smith :
Clang's undefined behavior sanitizer is flagging several places in CPython
where it is relying on float-cast-overflow behavior. Typically exposed where
an out of bounds floating point value is cast to another type.
The clang compiler is about to
Gregory P. Smith added the comment:
New changeset a5f33a899f6450de96f5e4cd154de4486d50bdd7 by Gregory P. Smith
(Miss Islington (bot)) in branch '3.6':
bpo-19950: Clarify unittest TestCase instance use. (GH-6875) (GH-6939)
https://github.com/python/cpyt
Gregory P. Smith added the comment:
New changeset 436972e295f5057fe7cdd7312f543c2fa884705d by Gregory P. Smith
(Miss Islington (bot)) in branch '3.7':
bpo-19950: Clarify unittest TestCase instance use. (GH-6875) (GH-6938)
https://github.com/python/cpyt
Change by Gregory P. Smith :
--
resolution: -> fixed
stage: patch review -> commit review
status: open -> closed
___
Python tracker
<https://bugs.python.or
Gregory P. Smith added the comment:
A buildbot is up and running:
http://buildbot.python.org/all/#/builders?tags=%2Bubsan
in order to see the errors though, you have to manually string search for
"runtime error" in the giant test logs stdout.
At the moment, Modules/_ctypes
Change by Gregory P. Smith :
--
resolution: -> fixed
stage: -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.org/issue33321>
___
___
Change by Gregory P. Smith :
--
nosy: +twouters
___
Python tracker
<https://bugs.python.org/issue33589>
___
___
Python-bugs-list mailing list
Unsubscribe:
Change by Gregory P. Smith :
--
title: Subprocess Thread handles grow with each call and aren't released until
script ends -> Subprocess Thread handles grow with each call and aren't
released [Windows]
___
Python tracker
<https:/
Gregory P. Smith added the comment:
New changeset 8bb0b5b03cffa2a2e74f248ef479a9e7fbe95cf4 by Gregory P. Smith
(Matthias Bussonnier) in branch 'master':
bpo-33604: Remove Pending from hmac Deprecation warning. (GH-7062)
https://github.com/python/cpyt
Gregory P. Smith added the comment:
FYI - the "ARMv7 Ubuntu 14.04" builder is in serious need of an update, I plan
to turn it into a modern Debian system after 3.7.0 is out the door.
A specific test crashing intermittently seems odd though, this buildbot has
been running the sa
2201 - 2300 of 3274 matches
Mail list logo
