[issue36816] self-signed.pythontest.net TLS certificate key is too weak

2019-05-08 Thread Gregory P. Smith
Change by Gregory P. Smith : -- pull_requests: +13108 ___ Python tracker <https://bugs.python.org/issue36816> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue36855] update tests relying on a copy of a TLS certificate (pem) to support two versions

2019-05-08 Thread Gregory P. Smith
New submission from Gregory P. Smith : We're having pain today due to the Lib/test/selfsigned_pythontestdotnet.pem certificate update sychronization. This wouldn't be painful if our tests relying on a specific certificate matching something elsewhere on the network supporte

[issue36816] self-signed.pythontest.net TLS certificate key is too weak

2019-05-08 Thread Gregory P. Smith
Change by Gregory P. Smith : -- pull_requests: +13109 ___ Python tracker <https://bugs.python.org/issue36816> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue36816] self-signed.pythontest.net TLS certificate key is too weak

2019-05-08 Thread Gregory P. Smith
Change by Gregory P. Smith : -- pull_requests: +13110 ___ Python tracker <https://bugs.python.org/issue36816> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue36816] self-signed.pythontest.net TLS certificate key is too weak

2019-05-08 Thread Gregory P. Smith
Change by Gregory P. Smith : -- pull_requests: +13111 ___ Python tracker <https://bugs.python.org/issue36816> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue36816] self-signed.pythontest.net TLS certificate key is too weak

2019-05-08 Thread Gregory P. Smith
Gregory P. Smith added the comment: New changeset 7b5dca8345f4a909367836a3a2c3c7ac6e4e2c0c by Gregory P. Smith in branch '2.7': [2.7] bpo-36816: Update the self-signed.pythontest.net cert (GH-13192) (GH-13199) https://github.com/python/cpython/commit/7b5dca8345f4a909367836a3a2c3c7

[issue36601] signals can be caught by any thread

2019-05-09 Thread Gregory P. Smith
Change by Gregory P. Smith : -- assignee: -> gregory.p.smith ___ Python tracker <https://bugs.python.org/issue36601> ___ ___ Python-bugs-list mailing list Un

[issue36871] Misleading error from unittest.mock's assert_has_calls

2019-05-09 Thread Gregory P. Smith
New submission from Gregory P. Smith : Thing: mock_thing.method sig=(a=None, b=0) F == FAIL: test_has_calls_on_thing (__main__.MockCallTest) -- Traceback

[issue36601] signals can be caught by any thread

2019-05-09 Thread Gregory P. Smith
Gregory P. Smith added the comment: PR is approved with automerge, just awaiting CI to give it the green light now. -- ___ Python tracker <https://bugs.python.org/issue36

[issue36871] Misleading error from unittest.mock's assert_has_calls

2019-05-09 Thread Gregory P. Smith
Gregory P. Smith added the comment: If you use a debugger on this, you'll discover that what is happening inside of mock's assert_has_calls is that it is catching and swallowing an exception around the inspect.Signature instances bind() call complaining about 'b' being a

[issue36601] signals can be caught by any thread

2019-05-10 Thread Gregory P. Smith
Change by Gregory P. Smith : -- resolution: -> fixed stage: patch review -> commit review status: open -> closed type: -> enhancement versions: +Python 3.8 ___ Python tracker <https://bugs.python

[issue35925] test_httplib test_nntplib test_ssl fail on ARMv7 Debian buster bot (OpenSSL 1.1.1a)

2019-05-11 Thread Gregory P. Smith
Gregory P. Smith added the comment: In our 3.6 tree the test_ssl failure is now: == ERROR: test_protocol_sslv23 (test.test_ssl.ThreadedTests) Connecting to an SSLv23 server with various client options

[issue35925] test_httplib test_nntplib test_ssl fail on ARMv7 Debian buster bot (OpenSSL 1.1.1a)

2019-05-11 Thread Gregory P. Smith
Gregory P. Smith added the comment: (same on 2.7) -- ___ Python tracker <https://bugs.python.org/issue35925> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue35925] test_httplib test_nntplib test_ssl fail on ARMv7 Debian buster bot (OpenSSL 1.1.1a)

2019-05-11 Thread Gregory P. Smith
Change by Gregory P. Smith : -- pull_requests: +13163 stage: backport needed -> patch review ___ Python tracker <https://bugs.python.org/issue35925> ___ ___ Py

[issue35925] test_httplib test_nntplib test_ssl fail on ARMv7 Debian buster bot (OpenSSL 1.1.1a)

2019-05-11 Thread Gregory P. Smith
Change by Gregory P. Smith : -- pull_requests: +13165 ___ Python tracker <https://bugs.python.org/issue35925> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue36895] time.clock() marked for removal in 3.8 – still there.

2019-05-12 Thread Gregory P. Smith
Gregory P. Smith added the comment: New changeset e2500610c62673f42371b54fb0e4de83e4b33146 by Gregory P. Smith (Matthias Bussonnier) in branch 'master': bpo-36895: remove time.clock() as per removal notice. (GH-13270) https://github.com/python/cpyt

[issue36895] time.clock() marked for removal in 3.8 – still there.

2019-05-12 Thread Gregory P. Smith
Gregory P. Smith added the comment: I saw the PR before the bug comment. merged. if we find a _good_ reason to delay this removal a cycle during the 3.8 betas we can bring it back. thanks for staying on top of the removal plan! -- resolution: -> fixed stage: patch rev

[issue36728] Remove PyEval_ReInitThreads() from the public C API

2019-05-12 Thread Gregory P. Smith
Gregory P. Smith added the comment: fwiw - i agree that this can be removed. it has no reason to ever be called directly. i double checked in our massive internal codebase at work and found no calls other than python interpreters themselves. -- nosy: +gregory.p.smith

[issue36906] Compile time textwrap.dedent() equivalent for str or bytes literals

2019-05-13 Thread Gregory P. Smith
New submission from Gregory P. Smith : A Python pattern in code is to keep everything indented to look pretty while, yet when the triple quoted multiline string in question needs to not have leading whitespace, calling textwrap.dedent("""long multiline constant"&quo

[issue35925] test_httplib test_nntplib test_ssl fail on ARMv7 Debian buster bot (OpenSSL 1.1.1a)

2019-05-13 Thread Gregory P. Smith
Gregory P. Smith added the comment: New changeset 7346a16ed584fd1e85359154820d286370b68648 by Gregory P. Smith in branch '2.7': [2.7] bpo-35925: Skip SSL tests that fail due to weak external certs or old TLS (GH-13124) (GH-13253) https://github.com/python/cpyt

[issue35925] test_httplib test_nntplib test_ssl fail on ARMv7 Debian buster bot (OpenSSL 1.1.1a)

2019-05-13 Thread Gregory P. Smith
Gregory P. Smith added the comment: 3.6 (and 3.5 if larry wants) are the only remaining trees to apply this to, assigning to the 3.6 RM. -- assignee: gregory.p.smith -> ned.deily versions: -Python 2.7 ___ Python tracker <https://bugs.pyth

[issue36906] Compile time textwrap.dedent() equivalent for str or bytes literals

2019-05-13 Thread Gregory P. Smith
Gregory P. Smith added the comment: Oh good, I thought this had come up before. Your method idea that could be optimized on literals makes a lot of sense, and is notably more readable than yet another letter prefix. -- ___ Python tracker <ht

[issue36906] Compile time textwrap.dedent() equivalent for str or bytes literals

2019-05-14 Thread Gregory P. Smith
Gregory P. Smith added the comment: I'd say go for it. We can't guarantee we'll accept the feature yet, but I think the .dedent() method with an optimization pass approach is worthwhile making a proof of concept of regardless. -- ___

[issue36760] subprocess.run fails with capture_output=True and stderr=STDOUT

2019-05-14 Thread Gregory P. Smith
Change by Gregory P. Smith : -- keywords: +patch pull_requests: +13233 stage: -> patch review ___ Python tracker <https://bugs.python.org/issue36760> ___ _

[issue36760] subprocess.run fails with capture_output=True and stderr=STDOUT

2019-05-14 Thread Gregory P. Smith
Change by Gregory P. Smith : -- assignee: -> gregory.p.smith components: +Documentation -Library (Lib) versions: +Python 3.8 ___ Python tracker <https://bugs.python.org/issu

[issue36760] subprocess.run fails with capture_output=True and stderr=STDOUT

2019-05-14 Thread Gregory P. Smith
Gregory P. Smith added the comment: New changeset e883091abf7ca84a88e956fe5202e75c53bd4128 by Gregory P. Smith in branch 'master': bpo-36760: Clarify subprocess capture_output docs. (GH-13322) https://github.com/python/cpython/commit/e883091abf7ca84a88e956fe5202e7

[issue36760] subprocess.run fails with capture_output=True and stderr=STDOUT

2019-05-14 Thread Gregory P. Smith
Change by Gregory P. Smith : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker <https://bugs.python.or

[issue36906] Compile time textwrap.dedent() equivalent for str or bytes literals

2019-05-15 Thread Gregory P. Smith
Gregory P. Smith added the comment: Thanks, it's actually good to see this being a feature accepted in other languages. -- priority: low -> normal ___ Python tracker <https://bugs.python.org

[issue14976] queue.Queue() is not reentrant, so signals and GC can cause deadlocks

2018-01-16 Thread Gregory P. Smith
Gregory P. Smith added the comment: Catalin has been examining code... switching concurrent.futures.thread to use SimpleQueue instead of Queue is probably a good idea as the queues in there get used from weakref callbacks. -- ___ Python tracker

[issue14976] queue.Queue() is not reentrant, so signals and GC can cause deadlocks

2018-01-16 Thread Gregory P. Smith
Gregory P. Smith added the comment: https://bugs.python.org/issue32576 filed for that -- ___ Python tracker <https://bugs.python.org/issue14976> ___ ___ Pytho

[issue32576] concurrent.futures.thread potential deadlock due to Queue in weakref callback

2018-01-16 Thread Gregory P. Smith
New submission from Gregory P. Smith : As a follow up to https://bugs.python.org/issue14976 which just introduced queue.SimpleQueue: concurrent.futures.thread currently uses a queue.Queue() from weakref callbacks which could in theory lead to a deadlock when periodic gc triggers a cleanup

[issue21009] Potential deadlock in concurrent futures when garbage collection occurs during Queue.get

2018-01-17 Thread Gregory P. Smith
Gregory P. Smith added the comment: there's a PR on the other issue i opened for this without noticing this one so i'm marking this as the dup. -- nosy: +gregory.p.smith resolution: -> duplicate stage: -> patch review status: open -> closed superseder: queue.Queue

[issue32576] concurrent.futures.thread deadlock due to Queue in weakref callback

2018-01-17 Thread Gregory P. Smith
Change by Gregory P. Smith : -- title: concurrent.futures.thread potential deadlock due to Queue in weakref callback -> concurrent.futures.thread deadlock due to Queue in weakref callback ___ Python tracker <https://bugs.python.org/issu

[issue20104] expose posix_spawn(p)

2018-01-28 Thread Gregory P. Smith
Gregory P. Smith added the comment: New changeset 6c6ddf97c402709713d668d0ed53836a7749ba99 by Gregory P. Smith (Pablo Galindo) in branch 'master': bpo-20104: Expose `posix_spawn` in the os module (GH-5109) https://github.com/python/cpython/commit/6c6ddf97c402709713d668d0ed5383

[issue20104] expose posix_spawn(p)

2018-01-28 Thread Gregory P. Smith
Gregory P. Smith added the comment: remaining work before closing this: Doc/library/os.rst needs to describe os.posix_spawn -- priority: low -> normal ___ Python tracker <https://bugs.python.org/issu

[issue20104] expose posix_spawn(p)

2018-01-29 Thread Gregory P. Smith
Gregory P. Smith added the comment: New changeset 0cd6bca65519109a8a7862d38ba1b8924e432a16 by Gregory P. Smith (Pablo Galindo) in branch 'master': bpo-20104: Fix leaks and errors in new os.posix_spawn (GH-5418) https://github.com/python/cpython/commit/0cd6bca65519109a8a7862d38ba1b8

[issue25942] Add a new optional cleanup_timeout parameter to subprocess.call()

2018-01-29 Thread Gregory P. Smith
Gregory P. Smith added the comment: New changeset f4d644f36ffb6cb11b34bfcf533c14cfaebf709a by Gregory P. Smith in branch 'master': bpo-25942: make subprocess more graceful on ^C (GH-5026) https://github.com/python/cpython/commit/f4d644f36ffb6cb11b34bfcf533c14

[issue25942] Do not immediately SIGKILL subprocess child processes upon ^C

2018-01-29 Thread Gregory P. Smith
Gregory P. Smith added the comment: I went with my change to give the child process a small amount of time to cleanup by default. Not perfect, but this should be more similar to the Python <=3.2 behavior. Lets see if any issues crop up during the 3.7 betas. -- resolution: ->

[issue21417] Compression level for zipfile

2018-01-29 Thread Gregory P. Smith
Gregory P. Smith added the comment: New changeset ce237c7d58ba207575cdfb0195a58a6407fbf717 by Gregory P. Smith (Bo Bayles) in branch 'master': bpo-21417: Add compresslevel= to the zipfile module (GH-5385) https://github.com/python/cpython/commit/ce237c7d58ba207575cdfb0195a58a

[issue32681] Fix uninitialized variable in os_dup2_impl

2018-01-29 Thread Gregory P. Smith
Gregory P. Smith added the comment: New changeset 3d86e484de6334fe16cbab512744597bd0de4e80 by Gregory P. Smith (Stéphane Wirtel) in branch 'master': bpo-32681: Fix an uninitialized variable in the C implementation of os.dup2 (GH-5346) https://github.com/python/cpyt

[issue32441] os.dup2 should return the new fd

2018-01-29 Thread Gregory P. Smith
Gregory P. Smith added the comment: https://github.com/python/cpython/pull/5346 (merged) should fix that warning. -- nosy: +gregory.p.smith ___ Python tracker <https://bugs.python.org/issue32

[issue32681] Fix uninitialized variable in os_dup2_impl

2018-01-29 Thread Gregory P. Smith
Change by Gregory P. Smith : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker <https://bugs.python.or

[issue32102] Add "capture_output=True" option to subprocess.run

2018-01-29 Thread Gregory P. Smith
Change by Gregory P. Smith : -- assignee: -> gregory.p.smith ___ Python tracker <https://bugs.python.org/issue32102> ___ ___ Python-bugs-list mailing list Un

[issue32102] Add "capture_output=True" option to subprocess.run

2018-01-29 Thread Gregory P. Smith
Gregory P. Smith added the comment: New changeset ce0f33d04528fcafc673a8707871f8430d8f7ce8 by Gregory P. Smith (Bo Bayles) in branch 'master': bpo-32102 Add "capture_output=True" to subprocess.run (GH-5149) https://github.com/python/cpython/commit/ce0f33d04528fcafc673

[issue32102] Add "capture_output=True" option to subprocess.run

2018-01-29 Thread Gregory P. Smith
Gregory P. Smith added the comment: Thanks Bo. I agree with Nick, this is a readability win for a common annoying to type otherwise case. -- resolution: -> fixed stage: patch review -> commit review status: open -> closed ___ Pytho

[issue21417] Compression level for zipfile

2018-01-29 Thread Gregory P. Smith
Change by Gregory P. Smith : -- resolution: -> fixed stage: patch review -> commit review status: open -> closed versions: +Python 3.7 -Python 3.5 ___ Python tracker <https://bugs.python.or

[issue31961] subprocess._execute_child doesn't accept a single PathLike argument for args

2018-01-29 Thread Gregory P. Smith
Gregory P. Smith added the comment: New changeset dd42cb71f2cb02f3a32f016137b12a146bc0d0e2 by Gregory P. Smith (Anders Lorentsen) in branch 'master': bpo-31961: subprocess now accepts path-like args (GH-4329) https://github.com/python/cpython/commit/dd42cb71f2cb02f3a32f016137b12a

[issue31961] subprocess._execute_child doesn't accept a single PathLike argument for args

2018-01-29 Thread Gregory P. Smith
Change by Gregory P. Smith : -- assignee: -> gregory.p.smith versions: -Python 3.6, Python 3.8 ___ Python tracker <https://bugs.python.org/issue31961> ___ _

[issue31961] subprocess._execute_child doesn't accept a single PathLike argument for args

2018-01-29 Thread Gregory P. Smith
Gregory P. Smith added the comment: Thanks for the PR! I accepted it as this makes sense as a feature. pathlib all the things! I think the code be polished up a bit to not rely on catching TypeError but this gets the feature in before the 3.7 feature freeze (just). If further changes

[issue20104] expose posix_spawn(p)

2018-01-29 Thread Gregory P. Smith
Change by Gregory P. Smith : -- resolution: -> fixed stage: patch review -> commit review status: open -> closed ___ Python tracker <https://bugs.python.or

[issue20104] expose posix_spawn(p)

2018-01-29 Thread Gregory P. Smith
Change by Gregory P. Smith : -- assignee: -> gregory.p.smith ___ Python tracker <https://bugs.python.org/issue20104> ___ ___ Python-bugs-list mailing list Un

[issue32705] Current Android does not have posix_spawn

2018-01-29 Thread Gregory P. Smith
Gregory P. Smith added the comment: likely. i don't have an android build, please reopen if there are still android posix_spawn related build issues. -- resolution: -> fixed stage: patch review -> resolved status: open -> closed

[issue22908] ZipExtFile in zipfile can be seekable

2018-01-30 Thread Gregory P. Smith
Change by Gregory P. Smith : -- assignee: serhiy.storchaka -> gregory.p.smith nosy: +gregory.p.smith ___ Python tracker <https://bugs.python.org/issu

[issue22908] ZipExtFile in zipfile can be seekable

2018-01-30 Thread Gregory P. Smith
Gregory P. Smith added the comment: New changeset 066df4fd454d6ff9be66e80b2a65995b10af174f by Gregory P. Smith (John Jolly) in branch 'master': bpo-22908: Add seek and tell functionality to ZipExtFile (GH-4966) https://github.com/python/cpython/commit/066df4fd454d6ff9be66e80b2a6599

[issue22908] ZipExtFile in zipfile can be seekable

2018-01-30 Thread Gregory P. Smith
Change by Gregory P. Smith : -- resolution: -> fixed stage: patch review -> commit review status: open -> closed versions: +Python 3.7 -Python 3.5 ___ Python tracker <https://bugs.python.or

[issue32387] Disallow untagged C extension import on major platforms

2018-01-30 Thread Gregory P. Smith
Gregory P. Smith added the comment: did this get discussed on distutils-sig? It's a trivial change (for the POSIX only PR) and would be neat to go through one of the 3.7 beta cycles to see if anything serious an unexpected is likely to come up for a

[issue27987] obmalloc's 8-byte alignment causes undefined behavior

2018-01-30 Thread Gregory P. Smith
Change by Gregory P. Smith : -- nosy: +gregory.p.smith, twouters ___ Python tracker <https://bugs.python.org/issue27987> ___ ___ Python-bugs-list mailin

[issue31912] PyMem_Malloc() should guarantee alignof(max_align_t)

2018-01-30 Thread Gregory P. Smith
Change by Gregory P. Smith : -- nosy: +gregory.p.smith, twouters ___ Python tracker <https://bugs.python.org/issue31912> ___ ___ Python-bugs-list mailin

[issue32387] Disallow untagged C extension import on major platforms

2018-01-30 Thread Gregory P. Smith
Gregory P. Smith added the comment: Interesting use case Josh. I don't know of a good way to deal with non-extension-module Python API using .so files. I like your extension hack, but what is the problem with having the version embedded in the .so

[issue31356] Add context manager to temporarily disable GC

2018-01-31 Thread Gregory P. Smith
Gregory P. Smith added the comment: I would not remove this. It is a new feature, leave it in for 3.7. The style issues and missing error checks are easy to address. We're at 3.7beta1 stage, it is normal to have issues to be cleaned up in a beta re

[issue32731] getpass.getuser() raises an unspecified exceptions (ImportError, OSError, etc)

2018-01-31 Thread Gregory P. Smith
New submission from Gregory P. Smith : This has been true since Python 1.x. getpass.getuser() is documented as "raising an exception" but doesn't specify what exception. On Windows when the environment variables it looks at are not set, an ImportError (!) escapes due to "

[issue31356] Add context manager to temporarily disable GC

2018-02-02 Thread Gregory P. Smith
Change by Gregory P. Smith : -- stage: resolved -> needs patch ___ Python tracker <https://bugs.python.org/issue31356> ___ ___ Python-bugs-list mailing list Un

[issue31356] Add context manager to temporarily disable GC

2018-02-02 Thread Gregory P. Smith
Gregory P. Smith added the comment: The idea which this issue represents is not rejected. It is a good one, we found a need for it during the dev sprint last September. -- priority: release blocker -> normal resolution: rejected -> status: closed -> open versions: +P

[issue31356] Add context manager to temporarily disable GC

2018-02-03 Thread Gregory P. Smith
Gregory P. Smith added the comment: Nick and Raymond: do you remember what our original motivating use cases were for this idea during the sprint? -- ___ Python tracker <https://bugs.python.org/issue31

[issue31961] subprocess._execute_child doesn't accept a single PathLike argument for args

2018-02-04 Thread Gregory P. Smith
Gregory P. Smith added the comment: Don't revert something just because you found a bug, we can fix it. fwiw, the PR passed appveyor's Windows run: https://ci.appveyor.com/project/python/cpython/build/3.7build11551 So if there's a bug, we're missing some k

[issue31961] subprocess._execute_child doesn't accept a single PathLike argument for args

2018-02-05 Thread Gregory P. Smith
Gregory P. Smith added the comment: got any pointers to those? I want to familiarize myself with existing arguments for/against such a feature in subprocess to decide. -- ___ Python tracker <https://bugs.python.org/issue31

[issue31961] subprocess._execute_child doesn't accept a single PathLike argument for args

2018-02-05 Thread Gregory P. Smith
Gregory P. Smith added the comment: I agree with both of you at this point. TODO: Revert the PR and backport that to the 3.7 branch (i'll take care of it) -- resolution: fixed -> stage: resolved -> needs patch ___ Python trac

[issue31961] subprocess._execute_child doesn't accept a single PathLike argument for args

2018-02-05 Thread Gregory P. Smith
Change by Gregory P. Smith : -- nosy: +ned.deily priority: normal -> release blocker versions: +Python 3.8 ___ Python tracker <https://bugs.python.org/issu

[issue32777] subprocess: child_exec() uses _Py_set_inheritable() which is not async-signal-safe

2018-02-05 Thread Gregory P. Smith
Change by Gregory P. Smith : -- assignee: -> gregory.p.smith nosy: +gregory.p.smith ___ Python tracker <https://bugs.python.org/issue32777> ___ ___ Python-

[issue32777] subprocess: child_exec() uses _Py_set_inheritable() which is not async-signal-safe

2018-02-05 Thread Gregory P. Smith
Gregory P. Smith added the comment: out of curiosity, did you actually diagnose a process deadlocked due to this or was it noted via code inspection? this issue has been around since 3.4 and the file descriptor inheritance changes from the looks of things

[issue32777] subprocess: child_exec() uses _Py_set_inheritable() which is not async-signal-safe

2018-02-05 Thread Gregory P. Smith
Gregory P. Smith added the comment: New changeset c1e46e94de38a92f98736af9a42d89c3975a9919 by Gregory P. Smith (Alexey Izbyshev) in branch 'master': bpo-32777: Fix _Py_set_inheritable async-safety in subprocess (GH-5560) https://github.com/python/cpyt

[issue32777] subprocess: child_exec() uses _Py_set_inheritable() which is not async-signal-safe

2018-02-05 Thread Gregory P. Smith
Gregory P. Smith added the comment: New changeset 2bb0bfafb0beb819b7c60d9004382ce6867847c0 by Gregory P. Smith (Miss Islington (bot)) in branch '3.7': bpo-32777: Fix _Py_set_inheritable async-safety in subprocess (GH-5560) (GH-5562) https://github.com/python/cpyt

[issue32777] subprocess: child_exec() uses _Py_set_inheritable() which is not async-signal-safe

2018-02-05 Thread Gregory P. Smith
Gregory P. Smith added the comment: New changeset b90c68586e1f2c45c736dd38880f182be267e2ef by Gregory P. Smith (Miss Islington (bot)) in branch '3.6': bpo-32777: Fix _Py_set_inheritable async-safety in subprocess (GH-5560) (GH-5563) https://github.com/python/cpyt

[issue32777] subprocess: child_exec() uses _Py_set_inheritable() which is not async-signal-safe

2018-02-05 Thread Gregory P. Smith
Change by Gregory P. Smith : -- components: +Extension Modules resolution: -> fixed stage: patch review -> commit review status: open -> closed ___ Python tracker <https://bugs.python.or

[issue31961] subprocess._execute_child doesn't accept a single PathLike argument for args

2018-02-06 Thread Gregory P. Smith
Gregory P. Smith added the comment: Nathaniel's specific description of a problem is wrong. A Path with embedded spaces is treated no different than one without by default. Where things change, and what needs fixing, is when shell=True is passed. In that case a PathLike object should n

[issue32764] Popen doesn't work on Windows when args is a list

2018-02-06 Thread Gregory P. Smith
Change by Gregory P. Smith : -- assignee: -> gregory.p.smith ___ Python tracker <https://bugs.python.org/issue32764> ___ ___ Python-bugs-list mailing list Un

[issue6135] subprocess seems to use local encoding and give no choice

2018-02-06 Thread Gregory P. Smith
Gregory P. Smith added the comment: New changeset fc1ce810f1da593648b4d19e7d582a235ec1dd37 by Gregory P. Smith (Brice Gros) in branch 'master': bpo-6135: Fix subprocess.check_output doc to mention changes in 3.6 (GH-5564) https://github.com/python/cpyt

[issue6135] subprocess seems to use local encoding and give no choice

2018-02-06 Thread Gregory P. Smith
Gregory P. Smith added the comment: New changeset 4e7a964aaf4374fa2f6b45cf5161fa6cd53aec19 by Gregory P. Smith (Miss Islington (bot)) in branch '3.7': bpo-6135: Fix subprocess.check_output doc to mention changes in 3.6 (GH-5564) (GH-5572) https://github.com/python/cpyt

[issue6135] subprocess seems to use local encoding and give no choice

2018-02-06 Thread Gregory P. Smith
Gregory P. Smith added the comment: New changeset 7f95c8c319c1ee593b130d0eb1d4947d9d7e008a by Gregory P. Smith (Miss Islington (bot)) in branch '3.6': bpo-6135: Fix subprocess.check_output doc to mention changes in 3.6 (GH-5564) (GH-5573) https://github.com/python/cpyt

[issue32815] Document text parameter to subprocess.Popen

2018-02-11 Thread Gregory P. Smith
Gregory P. Smith added the comment: New changeset e14c01037877768a3fe766e50d14993bd5d8a67e by Gregory P. Smith (Pablo Galindo) in branch 'master': bpo-32815: Improve docs on the subprocess API *text* parameter (GH-5622) https://github.com/python/cpyt

[issue32815] Document text parameter to subprocess.Popen

2018-02-11 Thread Gregory P. Smith
Gregory P. Smith added the comment: New changeset ba4f218657efcba856d00eb320418355cce8309a by Gregory P. Smith (Miss Islington (bot)) in branch '3.7': bpo-32815: Improve docs on the subprocess API *text* parameter (GH-5622) (GH-5631) https://github.com/python/cpyt

[issue32815] Document text parameter to subprocess.Popen

2018-02-11 Thread Gregory P. Smith
Change by Gregory P. Smith : -- resolution: -> fixed stage: patch review -> commit review status: open -> closed ___ Python tracker <https://bugs.python.or

[issue30028] make test.support.temp_cwd() fork-safe

2018-02-22 Thread Gregory P. Smith
Gregory P. Smith added the comment: New changeset 33dddac00ba8d9b72cf21b8698504077eb3c23ad by Gregory P. Smith (Anselm Kruis) in branch 'master': bpo-30028: make test.support.temp_cwd() fork-safe (GH-1066) https://github.com/python/cpython/commit/33dddac00ba8d9b72cf21b86985040

[issue30028] make test.support.temp_cwd() fork-safe

2018-02-23 Thread Gregory P. Smith
Gregory P. Smith added the comment: New changeset 61bd4d2e6319a3c5c3b9ce5f807b44a45cc1d4a1 by Gregory P. Smith (Anselm Kruis) in branch '2.7': [2.7] bpo-30028: make test.support.temp_cwd() fork-safe (GH-1066) (GH-5825) https://github.com/python/cpyt

[issue30028] make test.support.temp_cwd() fork-safe

2018-02-23 Thread Gregory P. Smith
Gregory P. Smith added the comment: New changeset 9c819a6a7d34594779fea3a25fd69ec5745e185e by Gregory P. Smith (Anselm Kruis) in branch '3.6': [3.6] bpo-30028: make test.support.temp_cwd() fork-safe (GH-1066) (GH-5826) https://github.com/python/cpyt

[issue30028] make test.support.temp_cwd() fork-safe

2018-02-23 Thread Gregory P. Smith
Change by Gregory P. Smith : -- resolution: -> fixed stage: patch review -> commit review status: open -> closed versions: +Python 2.7, Python 3.8 -Python 3.5 ___ Python tracker <https://bugs.python.or

[issue31961] subprocess._execute_child doesn't accept a single PathLike argument for args

2018-02-26 Thread Gregory P. Smith
Gregory P. Smith added the comment: I'm fine with undoing this for 3.7 in light of the many things we don't do "right" all over the place with path like objects. subprocess still presents as a mix of high and low level APIs so if we accept a path like object in a subse

[issue31961] subprocess._execute_child doesn't accept a single PathLike argument for args

2018-02-26 Thread Gregory P. Smith
Gregory P. Smith added the comment: Ned: when removing a feature added in beta1, should we remove the original NEWS entry created for it? Or add a new NEWS entry that states that the previous feature has been reverted? -- ___ Python tracker

[issue21417] Compression level for zipfile

2018-02-26 Thread Gregory P. Smith
Gregory P. Smith added the comment: keeping the conversation in one place, the code review comment was: "I've prefixed this with an underscore because it's not exposed when reading back. ZipInfo has another "private" attribute, _raw_time" compresslevel is docum

[issue32973] Importing the same extension module under multiple names breaks non-reinitialisable extension modules

2018-02-28 Thread Gregory P. Smith
Change by Gregory P. Smith : -- nosy: +gregory.p.smith ___ Python tracker <https://bugs.python.org/issue32973> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue32973] Importing the same extension module under multiple names breaks non-reinitialisable extension modules

2018-02-28 Thread Gregory P. Smith
Change by Gregory P. Smith : -- versions: +Python 3.6, Python 3.7, Python 3.8 ___ Python tracker <https://bugs.python.org/issue32973> ___ ___ Python-bugs-list m

[issue33079] subprocess: document the interaction between subprocess.Popen and os.set_inheritable

2018-03-25 Thread Gregory P. Smith
Change by Gregory P. Smith : -- keywords: +patch pull_requests: +5976 stage: -> patch review ___ Python tracker <https://bugs.python.org/issue33079> ___ ___ Py

[issue33079] subprocess: document the interaction between subprocess.Popen and os.set_inheritable

2018-03-25 Thread Gregory P. Smith
Gregory P. Smith added the comment: I assumed simon meant "close_fds=False" when he wrote open_fds = True. Regardless, supplying any pass_fds forces close_fds=True behavior. File descriptors listed in pass_fds are explicitly set inheritable from within the child process prior to ca

[issue33079] subprocess: document the interaction between subprocess.Popen and os.set_inheritable

2018-03-25 Thread Gregory P. Smith
Gregory P. Smith added the comment: I clarified the docs to mention that the inheritable flag is heeded when close_fds=False in https://github.com/python/cpython/pull/6240/files -- resolution: -> fixed stage: patch review -> resolved status: open -&g

[issue32270] subprocess closes redirected fds even if they are in pass_fds

2018-03-25 Thread Gregory P. Smith
Gregory P. Smith added the comment: This bug stems from: https://github.com/python/cpython/blob/master/Modules/_posixsubprocess.c#L454 When stdout=fd is passed, that results in c2pwrite=fd. The stdin/stdout/stderr pipe fds are closed when > 2 without checking to see if they are listed

[issue32270] subprocess closes redirected fds even if they are in pass_fds

2018-03-25 Thread Gregory P. Smith
Change by Gregory P. Smith : -- keywords: +patch pull_requests: +5977 stage: -> patch review ___ Python tracker <https://bugs.python.org/issue32270> ___ ___ Py

[issue25782] CPython hangs on error __context__ set to the error itself

2018-03-25 Thread Gregory P. Smith
Gregory P. Smith added the comment: I believe the original issue is fixed, the original problem and the one Jack followed up with no longer work in modern Python 3. But there is discussion about possibly doing something better, if anyone is interested in doing that I suggest opening a new

[issue30416] constant folding opens compiler to quadratic time hashing

2018-03-25 Thread Gregory P. Smith
Change by Gregory P. Smith : -- assignee: -> benjamin.peterson ___ Python tracker <https://bugs.python.org/issue30416> ___ ___ Python-bugs-list mailing list Un

[issue32844] subprocess may incorrectly redirect a low fd to stderr if another low fd is closed

2018-03-26 Thread Gregory P. Smith
Gregory P. Smith added the comment: New changeset 0e7144b064a19493a146af94175a087b3888c37b by Gregory P. Smith (Alexey Izbyshev) in branch 'master': bpo-32844: Fix a subprocess misredirection of a low fd (GH5689) https://github.com/python/cpyt

[issue20104] expose posix_spawn(p)

2018-04-01 Thread Gregory P. Smith
Change by Gregory P. Smith : -- pull_requests: +6046 ___ Python tracker <https://bugs.python.org/issue20104> ___ ___ Python-bugs-list mailing list Unsubscribe:

<    17   18   19   20   21   22   23   24   25   26   >