[issue29988] (async) with blocks and try/finally are not as KeyboardInterrupt-safe as one might like

2017-09-04 Thread Gregory P. Smith
Changes by Gregory P. Smith : -- nosy: +gregory.p.smith ___ Python tracker <http://bugs.python.org/issue29988> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue29988] (async) with blocks and try/finally are not as KeyboardInterrupt-safe as one might like

2017-09-04 Thread Gregory P. Smith
Gregory P. Smith added the comment: Yury's in the room here and pointed out how Nick and I are wrong. :) [yay sprints!] async def __aexit__(self, *e): spamity_spam return Awaitable If we resolve the GET_AWAITABLE at BEFORE_ASYNC_WITH time, the spamity_spam within __aexit__ is exe

[issue22536] subprocess should include filename in FileNotFoundError exception

2017-09-04 Thread Gregory P. Smith
Changes by Gregory P. Smith : -- pull_requests: +3335 ___ Python tracker <http://bugs.python.org/issue22536> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue22536] subprocess should include filename in FileNotFoundError exception

2017-09-04 Thread Gregory P. Smith
Gregory P. Smith added the comment: New changeset 1dba3789e335f06e3b01cdc84070f2e828c9b861 by Gregory P. Smith in branch '3.6': bpo-22536 [3.6] Set filename in FileNotFoundError (#3305) https://github.com/python/cpython/commit/1dba3789e335f06e3b01cdc84070f2

[issue24896] It is undocumented that re.UNICODE and re.LOCALE affect re.IGNORECASE

2017-09-04 Thread Gregory P. Smith
Changes by Gregory P. Smith : -- pull_requests: +3340 ___ Python tracker <http://bugs.python.org/issue24896> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue29988] (async) with blocks and try/finally are not as KeyboardInterrupt-safe as one might like

2017-09-04 Thread Gregory P. Smith
Gregory P. Smith added the comment: I do wonder if this is going to raise the urgency of https://bugs.python.org/issue16565 (Increase Py_AddPendingCall array size) or other refactoring of how pending calls are tracked. -- ___ Python tracker <h

[issue16565] Increase Py_AddPendingCall array size

2017-09-04 Thread Gregory P. Smith
Changes by Gregory P. Smith : -- versions: +Python 3.7 -Python 2.7, Python 3.3, Python 3.4, Python 3.5 ___ Python tracker <http://bugs.python.org/issue16

[issue27448] Race condition in subprocess.Popen which causes a huge memory leak

2017-09-05 Thread Gregory P. Smith
Gregory P. Smith added the comment: New changeset 5e8e371364ee58dadb9a4e4e51c7e9cf6bedbfae by Gregory P. Smith in branch '2.7': bpo-27448: Work around a gc.disable race condition in subprocess. (#1932) https://github.com/python/cpython/commit/5e8e371364ee58dadb9a4e4e51c7e9

[issue27448] Race condition in subprocess.Popen which causes a huge memory leak

2017-09-05 Thread Gregory P. Smith
Gregory P. Smith added the comment: the recommendation to use subprocess32 still stands, but this bug has been "fixed" in as much as it can be without a complete rewrite within 2.7. -- resolution: -> fixed stage: -> resolved status

[issue14976] queue.Queue() is not reentrant, so signals and GC can cause deadlocks

2017-09-05 Thread Gregory P. Smith
Gregory P. Smith added the comment: FYI - here is an appropriately licensed (WTFPL) very simple lock-free queue implemented in C: https://github.com/darkautism/lfqueue -- nosy: +gregory.p.smith ___ Python tracker <http://bugs.python.org/issue14

[issue14976] queue.Queue() is not reentrant, so signals and GC can cause deadlocks

2017-09-05 Thread Gregory P. Smith
Gregory P. Smith added the comment: yeah, there are others such as https://www.liblfds.org/ that seem better from that standpoint (gcc, and microsoft compiler support - I'm sure clang is fine as well - anything gcc can do they can do). Ensuring they're supported across build target

[issue31178] [EASY] subprocess: TypeError: can't concat str to bytes, in _execute_child()

2017-09-05 Thread Gregory P. Smith
Gregory P. Smith added the comment: New changeset 3fc499bca18454b9f432b9b0106cab662bfeb549 by Gregory P. Smith (Ammar Askar) in branch 'master': bpo-31178: Avoid concatenating bytes with str in subprocess error (#3066) https://github.com/python/cpyt

[issue31178] [EASY] subprocess: TypeError: can't concat str to bytes, in _execute_child()

2017-09-05 Thread Gregory P. Smith
Gregory P. Smith added the comment: awaiting our new carrot nosed bot the create the backport PR to take care of 3.6 :) -- assignee: -> gregory.p.smith versions: +Python 3.6 -Python 3.7 ___ Python tracker <http://bugs.python.org/issu

[issue31178] [EASY] subprocess: TypeError: can't concat str to bytes, in _execute_child()

2017-09-06 Thread Gregory P. Smith
Changes by Gregory P. Smith : -- pull_requests: +3395 ___ Python tracker <http://bugs.python.org/issue31178> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue29505] Submit the re, json, & csv modules to oss-fuzz testing

2017-09-06 Thread Gregory P. Smith
Gregory P. Smith added the comment: New changeset c5bace2bf7874cf47ef56e1d8d19f79ad892eef5 by Gregory P. Smith (Devin Jeanpierre) in branch 'master': bpo-29505: Add fuzz tests for float(str), int(str), unicode(str) (#2878) https://github.com/python/cpyt

[issue29505] Submit the re, json, & csv modules to oss-fuzz testing

2017-09-06 Thread Gregory P. Smith
Gregory P. Smith added the comment: alright, with that in, feel free to figure out the oss-fuzz configuration side and fire things up Devin. :) -- assignee: -> gregory.p.smith ___ Python tracker <http://bugs.python.org/issu

[issue31178] [EASY] subprocess: TypeError: can't concat str to bytes, in _execute_child()

2017-09-06 Thread Gregory P. Smith
Gregory P. Smith added the comment: New changeset 3bad1650a03fdc8cfdd4cce154e1b2c07e3e4fa0 by Gregory P. Smith in branch '3.6': [3.6] bpo-31178: Avoid concatenating bytes with str in subprocess error (GH-3066) (#3388) https://github.com/python/cpyt

[issue31178] [EASY] subprocess: TypeError: can't concat str to bytes, in _execute_child()

2017-09-06 Thread Gregory P. Smith
Changes by Gregory P. Smith : -- resolution: -> fixed stage: -> resolved status: open -> closed ___ Python tracker <http://bugs.python.org/issue31178> ___ ___

[issue29212] Python 3.6 logging thread name regression with concurrent.future threads

2017-09-06 Thread Gregory P. Smith
Changes by Gregory P. Smith : -- resolution: -> fixed stage: -> resolved status: open -> closed ___ Python tracker <http://bugs.python.org/issue29212> ___ ___

[issue22536] subprocess should include filename in FileNotFoundError exception

2017-09-06 Thread Gregory P. Smith
Changes by Gregory P. Smith : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed versions: +Python 3.6, Python 3.7 -Python 3.4, Python 3.5 ___ Python tracker <http://bugs.python.or

[issue23863] Fix EINTR Socket Module issues in 2.7

2017-09-06 Thread Gregory P. Smith
Gregory P. Smith added the comment: Unassigning because i'm unlikely to get to this in 2.7, it is better to concentrate on ensuring that 3.x stays signal safe. -- assignee: gregory.p.smith -> ___ Python tracker <http://bugs.python.org

[issue22635] subprocess.getstatusoutput changed behavior in 3.4 (maybe 3.3.4?)

2017-09-06 Thread Gregory P. Smith
Changes by Gregory P. Smith : -- pull_requests: +3404 ___ Python tracker <http://bugs.python.org/issue22635> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue22635] subprocess.getstatusoutput changed behavior in 3.4 (maybe 3.3.4?)

2017-09-06 Thread Gregory P. Smith
Gregory P. Smith added the comment: New changeset 738b7d9766e1a794bfba0d515a467ba833ca by Gregory P. Smith in branch 'master': bpo-22635: subprocess.getstatusoutput doc update. (#3398) https://github.com/python/cpython/commit/738b7d9766e1a794bfba0d515a

[issue31370] Remove support for threads-less builds

2017-09-06 Thread Gregory P. Smith
Gregory P. Smith added the comment: I guess Setup.config.in can go. It's only purpose was for autoconf driven Setup changes. -- ___ Python tracker <http://bugs.python.org/is

[issue22635] subprocess.getstatusoutput changed behavior in 3.4 (maybe 3.3.4?)

2017-09-06 Thread Gregory P. Smith
Gregory P. Smith added the comment: marking "closed/resolved" but also "won't fix" as the behavior change remains, but we've done the safest thing at this point: documented the fact. -- resolution: -> wont fix stage: -

[issue31383] Issue with _posixsubprocess when importing subprocess32

2017-09-07 Thread Gregory P. Smith
Gregory P. Smith added the comment: The standard library in Python 2.7 does not have an associated extension module. _posixsubprocess comes from subprocess32. There isn't much point in using subprocess32 on POSIX systems without the _posixsubprocess extension module. If that impo

[issue29766] --with-lto still implied by --enable-optimizations in Python 2.7

2017-09-07 Thread Gregory P. Smith
Gregory P. Smith added the comment: New changeset abea972d2881a1a04ec265f993bb9b56bbc7b224 by Gregory P. Smith (Hanno Schlichting) in branch '2.7': [2.7] bpo-29766: Fix configure/.ac to match LTO/enable-optimizations behavior. (#2705) https://github.com/python/cpyt

[issue29766] --with-lto still implied by --enable-optimizations in Python 2.7

2017-09-07 Thread Gregory P. Smith
Changes by Gregory P. Smith : -- resolution: -> fixed stage: resolved -> commit review status: open -> closed ___ Python tracker <https://bugs.python.or

[issue22635] subprocess.getstatusoutput changed behavior in 3.4 (maybe 3.3.4?)

2017-09-07 Thread Gregory P. Smith
Changes by Gregory P. Smith : -- pull_requests: +3432 ___ Python tracker <https://bugs.python.org/issue22635> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue31356] Add context manager to temporarily disable GC

2017-09-07 Thread Gregory P. Smith
Gregory P. Smith added the comment: I believe Raymond is aware of the thread issue. We discussed it. If gc.disable() would return the previous state of the gc instead of None and an API to enable based on a passed in bool, both of which are written in C and executed with the GIL (or merely

[issue22635] subprocess.getstatusoutput changed behavior in 3.4 (maybe 3.3.4?)

2017-09-07 Thread Gregory P. Smith
Gregory P. Smith added the comment: New changeset 2eb0cb4787d02d995a9bb6dc075983792c12835c by Gregory P. Smith in branch 'master': bpo-22635: Update the getstatusoutput docstring. (#3435) https://github.com/python/cpython/commit/2eb0cb4787d02d995a9bb6dc075983

[issue22635] subprocess.getstatusoutput changed behavior in 3.4 (maybe 3.3.4?)

2017-09-07 Thread Gregory P. Smith
Gregory P. Smith added the comment: New changeset fb4c28c032e26b3cdbe67eae3769d45207ac3507 by Gregory P. Smith (Miss Islington (bot)) in branch '3.6': [3.6] bpo-22635: Update the getstatusoutput docstring. (GH-3435) (#3439) https://github.com/python/cpyt

[issue31354] Fixing a bug related to LTO only build

2017-09-08 Thread Gregory P. Smith
Gregory P. Smith added the comment: New changeset 4c81401b3a9ffa48fc9e19963cbad5111e33 by Gregory P. Smith (octaviansoldea) in branch 'master': bpo-31354: Let configure --with-lto work on all builds https://github.com/python/cpython/commit/4c81401b3a9ffa48fc9e19963c

[issue31354] Fixing a bug related to LTO only build

2017-09-08 Thread Gregory P. Smith
Changes by Gregory P. Smith : -- assignee: -> gregory.p.smith resolution: -> fixed stage: -> resolved status: open -> closed ___ Python tracker <https://bugs.python

[issue29639] test suite intentionally avoids referring to localhost, destroying abstraction away from IPv6 vs IPv4

2017-09-08 Thread Gregory P. Smith
Changes by Gregory P. Smith : -- keywords: +patch pull_requests: +3457 stage: -> patch review ___ Python tracker <https://bugs.python.org/issue29639> ___ _

[issue29505] Submit the re, json, & csv modules to oss-fuzz testing

2017-09-08 Thread Gregory P. Smith
Gregory P. Smith added the comment: i'd rather make this work in oss-fuzz on cpython. can you point me to how oss-fuzz works and what it wants to do so i can better understand what it needs? it it has an expectation that the thing being fuzzed is a single binary with no data or dire

[issue29639] test suite intentionally avoids referring to localhost, destroying abstraction away from IPv6 vs IPv4

2017-09-09 Thread Gregory P. Smith
Gregory P. Smith added the comment: New changeset efb1d0a3c001a6153211063ba439b9847aa03509 by Gregory P. Smith in branch 'master': bpo-29639: change test.support.HOST to "localhost" https://github.com/python/cpython/commit/efb1d0a3c001a6153211

[issue29505] Submit the re, json, & csv modules to oss-fuzz testing

2017-09-11 Thread Gregory P. Smith
Gregory P. Smith added the comment: misquote. that was me objecting to running it internally. :) i believe this is solvable, i haven't had time to spend on this part yet. -- ___ Python tracker <https://bugs.python.org/is

[issue29639] test suite intentionally avoids referring to localhost, destroying abstraction away from IPv6 vs IPv4

2017-09-13 Thread Gregory P. Smith
Gregory P. Smith added the comment: LOL. That is a very strange story and the last thing i'd have expected to fall out from changing one string to another. :) -- ___ Python tracker <https://bugs.python.org/is

[issue23508] Document & unittest the subprocess.getstatusoutput() status value

2017-09-14 Thread Gregory P. Smith
Gregory P. Smith added the comment: documentation updates as part of issue22635. -- assignee: -> gregory.p.smith components: +Documentation resolution: -> fixed stage: -> resolved status: open -> closed superseder: -> subprocess.getstatusoutput changed behavior in 3.

[issue33015] Fix function cast warning in thread_pthread.h

2018-11-30 Thread Gregory P. Smith
Gregory P. Smith added the comment: why was that only an issue on 2.7? -- ___ Python tracker <https://bugs.python.org/issue33015> ___ ___ Python-bugs-list mailin

[issue33015] Fix function cast warning in thread_pthread.h

2018-11-30 Thread Gregory P. Smith
Gregory P. Smith added the comment: I don't think it is crazy for 2.7, but I'd move that to its own issue as you already nicely addressed the problem related to this PR without needing that. -- ___ Python tracker <https://bu

[issue34850] Emit a syntax warning for "is" with a literal

2018-11-30 Thread Gregory P. Smith
Gregory P. Smith added the comment: Given that linters like pylint can already detect the common case of this issue when using `is` and `is not` to compare to a literal where == or != seems more appropriate, I don't think a warning is very useful. In my experience people are more like

[issue34850] Emit a syntax warning for "is" with a literal

2018-12-01 Thread Gregory P. Smith
Gregory P. Smith added the comment: Oh neat, I didn't realize that Nathaniel. That makes such warnings much more useful. I'm fine if you go ahead with this change. In the unlikely event it turns out to cause user annoyance problems in betas due to third party code that can

[issue22005] datetime.__setstate__ fails decoding python2 pickle

2018-12-09 Thread Gregory P. Smith
Change by Gregory P. Smith : -- pull_requests: +10289 ___ Python tracker <https://bugs.python.org/issue22005> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue22005] datetime.__setstate__ fails decoding python2 pickle

2018-12-09 Thread Gregory P. Smith
Gregory P. Smith added the comment: New changeset e328753d91379274b699b93decff45de07854617 by Gregory P. Smith in branch 'master': bpo-22005: Document the reality of pickle compatibility. (GH-11054) https://github.com/python/cpython/commit/e328753d91379274b699b93decff45

[issue22005] datetime.__setstate__ fails decoding python2 pickle

2018-12-09 Thread Gregory P. Smith
Gregory P. Smith added the comment: It is fundamentally impossible for pickled data to magically cross the 2 and 3 language boundary unscathed. The basic str/bytes/unicode types in the language changed meaning. Code must be written manually by the data owners to fix that up based on what

[issue22005] datetime.__setstate__ fails decoding python2 pickle

2018-12-09 Thread Gregory P. Smith
Gregory P. Smith added the comment: Serhiy: should this one be marked fixed? -- assignee: -> serhiy.storchaka stage: patch review -> commit review ___ Python tracker <https://bugs.python.org/i

[issue31823] Opaque default value for close_fds argument in Popen.__init__

2018-12-10 Thread Gregory P. Smith
Change by Gregory P. Smith : -- versions: -Python 3.6 ___ Python tracker <https://bugs.python.org/issue31823> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue31823] Opaque default value for close_fds argument in Popen.__init__

2018-12-10 Thread Gregory P. Smith
Gregory P. Smith added the comment: In 3.6 this help(subprocess.Popen.__init__) is accurate and encourages looking at the docs. In 3.7 and later it'll simply report close_fds=True in the siguature as that is the case in 3.7 onwards. I see nothing to fix here. --

[issue35214] Get the test suite passing with clang Memory Sanitizer enabled

2018-12-11 Thread Gregory P. Smith
Gregory P. Smith added the comment: I believe there are still some issues to deal with. I don't want to close the issue until I've got my buildbot running. -- versions: -Python 3.6 ___ Python tracker <https://bugs.python.o

[issue31823] Opaque default value for close_fds argument in Popen.__init__

2018-12-12 Thread Gregory P. Smith
Gregory P. Smith added the comment: Only if someone can point to a concrete problem to be fixed in the 3.7+ docs. Looking at all references to close_fds in https://docs.python.org/3/library/subprocess.html I don't see one. (I'm not going to touch th

[issue35499] "make profile-opt" overrides CFLAGS_NODIST

2018-12-18 Thread Gregory P. Smith
Gregory P. Smith added the comment: But the `build_all_generate_profile` build is an intermediate instrumented interpreter build, it isn't shipped and things like PGO often require flags that the linker sees in order to generate the instrumented binary. If those are left off of the

[issue34836] test_ssl.test_default_ecdh_curve needs no tls1.3 flag in 2.7, for now

2018-12-26 Thread Gregory P. Smith
Change by Gregory P. Smith : -- assignee: -> christian.heimes ___ Python tracker <https://bugs.python.org/issue34836> ___ ___ Python-bugs-list mailing list Un

[issue35537] use os.posix_spawn in subprocess

2018-12-26 Thread Gregory P. Smith
Gregory P. Smith added the comment: Thanks for all your research and reference links on this! As a _posixsubprocess maintainer, I am not against either posix_spawn or vfork being used directly in the future when feasible. A challenge, especially with platform specific vfork, is making sure

[issue28503] [Patch] '_crypt' module: fix implicit declaration of crypt(), use crypt_r() where available

2018-12-30 Thread Gregory P. Smith
Change by Gregory P. Smith : -- assignee: -> gregory.p.smith nosy: +gregory.p.smith ___ Python tracker <https://bugs.python.org/issue28503> ___ ___ Python-

[issue28503] [Patch] '_crypt' module: fix implicit declaration of crypt(), use crypt_r() where available

2018-12-30 Thread Gregory P. Smith
Change by Gregory P. Smith : -- versions: +Python 3.8 -Python 3.7 ___ Python tracker <https://bugs.python.org/issue28503> ___ ___ Python-bugs-list mailin

[issue28503] [Patch] '_crypt' module: fix implicit declaration of crypt(), use crypt_r() where available

2018-12-30 Thread Gregory P. Smith
Change by Gregory P. Smith : -- pull_requests: +10712 ___ Python tracker <https://bugs.python.org/issue28503> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue28503] [Patch] '_crypt' module: fix implicit declaration of crypt(), use crypt_r() where available

2018-12-30 Thread Gregory P. Smith
Change by Gregory P. Smith : -- pull_requests: +10712, 10713 ___ Python tracker <https://bugs.python.org/issue28503> ___ ___ Python-bugs-list mailing list Unsub

[issue28503] [Patch] '_crypt' module: fix implicit declaration of crypt(), use crypt_r() where available

2018-12-30 Thread Gregory P. Smith
Change by Gregory P. Smith : -- pull_requests: +10712, 10713, 10714 ___ Python tracker <https://bugs.python.org/issue28503> ___ ___ Python-bugs-list mailin

[issue35214] Get the test suite passing with clang Memory Sanitizer enabled

2018-12-30 Thread Gregory P. Smith
Change by Gregory P. Smith : -- pull_requests: +10715 ___ Python tracker <https://bugs.python.org/issue35214> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue35214] Get the test suite passing with clang Memory Sanitizer enabled

2018-12-30 Thread Gregory P. Smith
Change by Gregory P. Smith : -- pull_requests: +10715, 10716 ___ Python tracker <https://bugs.python.org/issue35214> ___ ___ Python-bugs-list mailing list Unsub

[issue35214] Get the test suite passing with clang Memory Sanitizer enabled

2018-12-30 Thread Gregory P. Smith
Change by Gregory P. Smith : -- pull_requests: +10715, 10716, 10717 ___ Python tracker <https://bugs.python.org/issue35214> ___ ___ Python-bugs-list mailin

[issue28503] [Patch] '_crypt' module: fix implicit declaration of crypt(), use crypt_r() where available

2018-12-30 Thread Gregory P. Smith
Gregory P. Smith added the comment: New changeset 387512c7ecde6446f2e29408af2e16b9fc043807 by Gregory P. Smith in branch 'master': bpo-28503: Use crypt_r() when available instead of crypt() (GH-11373) https://github.com/python/cpython/commit/387512c7ecde6446f2e29408af2e16

[issue28503] [Patch] '_crypt' module: fix implicit declaration of crypt(), use crypt_r() where available

2018-12-30 Thread Gregory P. Smith
Gregory P. Smith added the comment: As this is internal only rather than a feature, i'll bring this into 3.7 as well. -- versions: +Python 3.7 ___ Python tracker <https://bugs.python.org/is

[issue28503] [Patch] '_crypt' module: fix implicit declaration of crypt(), use crypt_r() where available

2018-12-30 Thread Gregory P. Smith
Change by Gregory P. Smith : -- stage: patch review -> commit review ___ Python tracker <https://bugs.python.org/issue28503> ___ ___ Python-bugs-list mai

[issue35214] Get the test suite passing with clang Memory Sanitizer enabled

2018-12-30 Thread Gregory P. Smith
Gregory P. Smith added the comment: New changeset b474e6774d60fa67d5373e361a0ed53c18b24f53 by Gregory P. Smith in branch 'master': bpo-35214: MSan workarounds for socket, time, and test_faulthandler. (GH-11375) https://github.com/python/cpython/commit/b474e6774d60fa67d5373e361a0ed5

[issue31122] SSLContext.wrap_socket() throws OSError with errno == 0

2018-12-30 Thread Gregory P. Smith
Gregory P. Smith added the comment: This flakiness just caused a PR merge to be blocked by AppVeyor for me: == ERROR: test_with_statement (test.test_nntplib.NetworkedNNTP_SSLTests

[issue31122] SSLContext.wrap_socket() throws OSError with errno == 0

2018-12-30 Thread Gregory P. Smith
Change by Gregory P. Smith : -- versions: +Python 3.6, Python 3.7, Python 3.8 ___ Python tracker <https://bugs.python.org/issue31122> ___ ___ Python-bugs-list m

[issue31122] SSLContext.wrap_socket() throws OSError with errno == 0

2018-12-30 Thread Gregory P. Smith
Change by Gregory P. Smith : -- versions: -Python 3.5, Python 3.6 ___ Python tracker <https://bugs.python.org/issue31122> ___ ___ Python-bugs-list mailin

[issue31122] SSLContext.wrap_socket() throws OSError with errno == 0

2018-12-30 Thread Gregory P. Smith
Change by Gregory P. Smith : -- stage: -> needs patch ___ Python tracker <https://bugs.python.org/issue31122> ___ ___ Python-bugs-list mailing list Unsubscrib

[issue35225] test_faulthandler fails under ubsan

2018-12-30 Thread Gregory P. Smith
Change by Gregory P. Smith : -- keywords: +patch, patch pull_requests: +10730, 10731 stage: -> patch review ___ Python tracker <https://bugs.python.org/issu

[issue35225] test_faulthandler fails under ubsan

2018-12-30 Thread Gregory P. Smith
Change by Gregory P. Smith : -- keywords: +patch pull_requests: +10730 stage: -> patch review ___ Python tracker <https://bugs.python.org/issue35225> ___ _

[issue35225] test_faulthandler fails under ubsan

2018-12-30 Thread Gregory P. Smith
Change by Gregory P. Smith : -- keywords: +patch, patch, patch pull_requests: +10730, 10731, 10732 stage: -> patch review ___ Python tracker <https://bugs.python.org/issu

[issue35225] test_faulthandler fails under ubsan

2018-12-30 Thread Gregory P. Smith
Change by Gregory P. Smith : -- assignee: -> gregory.p.smith nosy: +gregory.p.smith ___ Python tracker <https://bugs.python.org/issue35225> ___ ___ Python-

[issue35225] test_faulthandler fails under ubsan

2018-12-30 Thread Gregory P. Smith
Gregory P. Smith added the comment: These are all related to the output of the child process containing sanitizer stuff so the stdout/stderr based tests are failing. i skipped two of these for memory sanitizers, the third looks easy enough to fix via the regex. PR attached

[issue35214] Get the test suite passing with clang Memory Sanitizer enabled

2018-12-30 Thread Gregory P. Smith
Gregory P. Smith added the comment: New changeset 01b9664740307b39c2907bd84cbb0b2c35be9df4 by Gregory P. Smith (Miss Islington (bot)) in branch '3.7': bpo-35214: MSan workarounds for socket, time, and test_faulthandler. (GH-11375) (GH-11378) https://github.com/python/cpyt

[issue28503] [Patch] '_crypt' module: fix implicit declaration of crypt(), use crypt_r() where available

2018-12-30 Thread Gregory P. Smith
Gregory P. Smith added the comment: New changeset a144feeb7ec501aaf30072d50e70d54b200e5ef0 by Gregory P. Smith (Miss Islington (bot)) in branch '3.7': bpo-28503: Use crypt_r() when available instead of crypt() (GH-11373) (GH-11376) https://github.com/python/cpyt

[issue28503] [Patch] '_crypt' module: fix implicit declaration of crypt(), use crypt_r() where available

2018-12-30 Thread Gregory P. Smith
Gregory P. Smith added the comment: I'm going to close this as 3.7 and 3.8 are good now, but if someone wants to see the same thing done in 2.7 it should be possible for them make a PR. This is primarily just a configure.ac change. -- resolution: -> fixed stage: commi

[issue35550] Some define guards for Solaris are wrong

2018-12-30 Thread Gregory P. Smith
Gregory P. Smith added the comment: New changeset 6f9bc72c79c3262e5d0f2c0e96b016477399cfb1 by Gregory P. Smith (Jakub KulĂ­k) in branch 'master': bpo-35550: Fix incorrect Solaris define guards (GH-11275) https://github.com/python/cpython/commit/6f9bc72c79c3262e5d0f2c0e96b016

[issue35550] Some define guards for Solaris are wrong

2018-12-30 Thread Gregory P. Smith
Change by Gregory P. Smith : -- assignee: -> gregory.p.smith resolution: -> fixed stage: patch review -> commit review versions: +Python 3.8 ___ Python tracker <https://bugs.python.or

[issue35214] Get the test suite passing with clang Memory Sanitizer enabled

2018-12-30 Thread Gregory P. Smith
Change by Gregory P. Smith : -- pull_requests: +10742 ___ Python tracker <https://bugs.python.org/issue35214> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue35214] Get the test suite passing with clang Memory Sanitizer enabled

2018-12-30 Thread Gregory P. Smith
Change by Gregory P. Smith : -- pull_requests: +10742, 10743, 10744 ___ Python tracker <https://bugs.python.org/issue35214> ___ ___ Python-bugs-list mailin

[issue35214] Get the test suite passing with clang Memory Sanitizer enabled

2018-12-30 Thread Gregory P. Smith
Change by Gregory P. Smith : -- pull_requests: +10742, 10743 ___ Python tracker <https://bugs.python.org/issue35214> ___ ___ Python-bugs-list mailing list Unsub

[issue35225] test_faulthandler fails under ubsan

2018-12-30 Thread Gregory P. Smith
Gregory P. Smith added the comment: my test skipping logic is somehow not detecting my ubsan buildbot https://buildbot.python.org/all/#/builders/135/builds/1108/steps/4/logs/stdio TODO: figure that out. otherwise the regex change fixed test_sigfpe

[issue35225] test_faulthandler fails under ubsan

2018-12-30 Thread Gregory P. Smith
Change by Gregory P. Smith : -- pull_requests: +10745 ___ Python tracker <https://bugs.python.org/issue35225> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue35225] test_faulthandler fails under ubsan

2018-12-30 Thread Gregory P. Smith
Change by Gregory P. Smith : -- pull_requests: +10745, 10746 ___ Python tracker <https://bugs.python.org/issue35225> ___ ___ Python-bugs-list mailing list Unsub

[issue35225] test_faulthandler fails under ubsan

2018-12-30 Thread Gregory P. Smith
Change by Gregory P. Smith : -- pull_requests: +10745, 10746, 10748 ___ Python tracker <https://bugs.python.org/issue35225> ___ ___ Python-bugs-list mailin

[issue35225] test_faulthandler fails under ubsan

2018-12-30 Thread Gregory P. Smith
Change by Gregory P. Smith : -- pull_requests: +10745, 10746, 10747, 10748 ___ Python tracker <https://bugs.python.org/issue35225> ___ ___ Python-bugs-list mailin

[issue35214] Get the test suite passing with clang Memory Sanitizer enabled

2018-12-30 Thread Gregory P. Smith
Gregory P. Smith added the comment: New changeset e5796c42c687e1454e84dcc50e6f67db48ff69a0 by Gregory P. Smith in branch 'master': bpo-35214: Skip test_io tests that'd cause a huge malloc under msan (#11385) https://github.com/python/cpython/commit/e5796c42c687e1454e84dcc50

[issue35214] Get the test suite passing with clang Memory Sanitizer enabled

2018-12-30 Thread Gregory P. Smith
Gregory P. Smith added the comment: Status on my upcoming buildbot host after today's changes: == Tests result: FAILURE == 375 tests OK. 11 tests failed: test_asyncio test_builtin test_code test_ctypes test_ioctl test_openpty test_os test_posix test_pty test_shutil test_uui

[issue35225] test_faulthandler fails under ubsan

2018-12-30 Thread Gregory P. Smith
Gregory P. Smith added the comment: https://buildbot.python.org/all/#/builders/135/builds/1110 == Tests result: SUCCESS == 404 tests OK. 10 slowest tests: - test_tokenize: 3 min 43 sec - test_concurrent_futures: 3 min 28 sec - test_multiprocessing_spawn: 3 min 20 sec - test_tools: 2 min 59

[issue35214] Get the test suite passing with clang Memory Sanitizer enabled

2018-12-30 Thread Gregory P. Smith
Change by Gregory P. Smith : -- pull_requests: +10755 ___ Python tracker <https://bugs.python.org/issue35214> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue35214] Get the test suite passing with clang Memory Sanitizer enabled

2018-12-30 Thread Gregory P. Smith
Change by Gregory P. Smith : -- pull_requests: +10755, 10756, 10757 ___ Python tracker <https://bugs.python.org/issue35214> ___ ___ Python-bugs-list mailin

[issue35214] Get the test suite passing with clang Memory Sanitizer enabled

2018-12-30 Thread Gregory P. Smith
Change by Gregory P. Smith : -- pull_requests: +10755, 10756 ___ Python tracker <https://bugs.python.org/issue35214> ___ ___ Python-bugs-list mailing list Unsub

[issue35214] Get the test suite passing with clang Memory Sanitizer enabled

2018-12-30 Thread Gregory P. Smith
Gregory P. Smith added the comment: New changeset 1d300ce1d8238136595c8fea76266a4755cd73a2 by Gregory P. Smith in branch 'master': bpo-35214: Annotate posix calls for clang MSan. (#11389) https://github.com/python/cpython/commit/1d300ce1d8238136595c8fea76266a

[issue35214] Get the test suite passing with clang Memory Sanitizer enabled

2018-12-30 Thread Gregory P. Smith
Change by Gregory P. Smith : -- pull_requests: +10758, 10759, 10760 ___ Python tracker <https://bugs.python.org/issue35214> ___ ___ Python-bugs-list mailin

[issue35214] Get the test suite passing with clang Memory Sanitizer enabled

2018-12-30 Thread Gregory P. Smith
Change by Gregory P. Smith : -- pull_requests: +10758 ___ Python tracker <https://bugs.python.org/issue35214> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue35214] Get the test suite passing with clang Memory Sanitizer enabled

2018-12-30 Thread Gregory P. Smith
Change by Gregory P. Smith : -- pull_requests: +10758, 10759 ___ Python tracker <https://bugs.python.org/issue35214> ___ ___ Python-bugs-list mailing list Unsub

[issue35214] Get the test suite passing with clang Memory Sanitizer enabled

2018-12-30 Thread Gregory P. Smith
Gregory P. Smith added the comment: New changeset efcf08d8ca9084d8248715f0634c21b705f02ca2 by Gregory P. Smith in branch '3.7': [3.7] bpo-35214: Annotate posix calls for clang MSan. (GH-11389) (GH-11391) https://github.com/python/cpython/commit/efcf08d8ca9084d8248715f0634c21

<    14   15   16   17   18   19   20   21   22   23   >