Gregory P. Smith added the comment:
https://bugs.python.org/issue39376 tracks possible interpreter behavior changes.
--
___
Python tracker
<https://bugs.python.org/issue39
New submission from Gregory P. Smith :
For more context, see https://bugs.python.org/issue39375 which seeks to
document the existing caveats.
POSIX lacks any APIs to access the process global environment in a thread safe
manner. Given this, we could _consider_ preventing os.putenv() and
Gregory P. Smith added the comment:
fwiw, no need to remove that message. We'll want to make the docs clear that
this does not apply to Windows. :)
--
___
Python tracker
<https://bugs.python.org/is
Gregory P. Smith added the comment:
New changeset d3ae95e1e945ed20297e1c38ba43a18b7a868ab6 by Gregory P. Smith
(Alex Rebert) in branch 'master':
bpo-35182: fix communicate() crash after child closes its pipes (GH-17020)
(GH-18117)
https://github.com/python/cpyt
Gregory P. Smith added the comment:
backport automation appears unhappy at the moment. I'm keeping this open and
assigned to me to manually run cherry_picker on this for 3.8 and 3.7 (if still
open for non-security fixes).
--
assignee: -> gregory.p.smith
stage: patc
Gregory P. Smith added the comment:
thanks everyone!
--
resolution: -> fixed
stage: patch review -> commit review
status: open -> closed
versions: +Python 3.9
___
Python tracker
<https://bugs.python.or
Change by Gregory P. Smith :
--
versions: +Python 3.8, Python 3.9
___
Python tracker
<https://bugs.python.org/issue29249>
___
___
Python-bugs-list mailin
Gregory P. Smith added the comment:
Christian added the SHA3 support so is probably best to comment on this. The
way our hashlib code is structured we always use the
https://github.com/python/cpython/tree/master/Modules/_sha3 implementation
rather than OpenSSL for these algorithms due to
Gregory P. Smith added the comment:
Noted, but making it a keyword only argument would break a lot of existing code
that has always just been passing three positional args. Needless pain.
--
stage: patch review -> resolved
status: open ->
Gregory P. Smith added the comment:
yes, Popen's use of a lock since that change means that Popen.wait() cannot be
called in an asynchronous context where its own execution could be blocking the
execution of code that would unlock the lock.
at this point we should probably just doc
Change by Gregory P. Smith :
--
keywords: +3.4regression, 3.5regression
___
Python tracker
<https://bugs.python.org/issue25960>
___
___
Python-bugs-list mailin
Gregory P. Smith added the comment:
Reopening so that spending time on deciding this in the future at least stays
on my radar.
Your workaround sounds like the reasonable, if understandably not pretty
approach for now.
--
resolution: wont fix -> remind
status: closed ->
New submission from Gregory P. Smith :
Easiest to demonstrate as such:
```shell
#!/bin/bash
mkdir bug
touch bug/__init__.py
mkdir bug/foo
touch bug/foo/__init__.py
touch bug/foo/bar.py
python3 -m compileall -d "" bug
python2 -m compileall -d "" bug
echo "prefix
Gregory P. Smith added the comment:
This has probably been happening for many 3 releases. I noticed it on 3.6 when
investigating a problem with wrong paths in tracebacks coming from code which
we used compileall.compile_dir(src_root, quiet=1, ddir=") on.
I'm guessing ddir= (-d
Gregory P. Smith added the comment:
Ironically 3.9a4 gains some compileall enhancements that could be used as an
awkward workaround from https://bugs.python.org/issue38112:
python 2.7 compile_dir(d, ddir="") behavior can be had with
python 3.9a4 compile_dir(d, prependdir="&q
Gregory P. Smith added the comment:
https://bugs.python.org/issue39769 may be of interest. compileall's ddir= does
not behave properly in recursive subdirectories, it did the right thing in 2.7
which is similar to a combination of compile_dir(dir, prependdir=ddir,
stripdir=dir) after
Gregory P. Smith added the comment:
The regression was caused by the parallelization enhancement implementation
from https://bugs.python.org/issue16104
--
___
Python tracker
<https://bugs.python.org/issue39
Gregory P. Smith added the comment:
This caused a regression in behavior. compileall.compile_dir()'s ddir=
parameter no longer does the right thing for any subdirectories.
https://bugs.python.org/issue39769
--
nosy: +gregory.p.smith
___
P
Gregory P. Smith added the comment:
meaning this regression was introduced in 3.5.
--
versions: +Python 3.5
___
Python tracker
<https://bugs.python.org/issue39
Gregory P. Smith added the comment:
belated postmortem: if there had been tests against the filename encoded in the
pycs living in subdirs as generated by compile_dir, this regression would not
have happened.
--
___
Python tracker
<ht
Change by Gregory P. Smith :
--
keywords: +patch
pull_requests: +18036
stage: needs patch -> patch review
pull_request: https://github.com/python/cpython/pull/18676
___
Python tracker
<https://bugs.python.org/issu
Change by Gregory P. Smith :
--
components: +Extension Modules
nosy: +gregory.p.smith
stage: -> needs patch
type: -> behavior
___
Python tracker
<https://bugs.python.org/i
Gregory P. Smith added the comment:
the concept of a native _Bool seems fuzzy. the important thing for the struct
module is to consume sizeof _Bool bytes from the input stream. how those are
interpreted is up to the platform. So if the platform says a bool is 8 bytes
and it only ever
Change by Gregory P. Smith :
--
title: Submit the re, json, & csv modules to oss-fuzz testing -> Submit the re,
json, csv, & struct modules to oss-fuzz testing
___
Python tracker
<https://bugs.python.
Gregory P. Smith added the comment:
New changeset 02673352b5db6ca4d3dc804965facbedfe66425d by Gregory P. Smith in
branch 'master':
bpo-39769: Fix compileall ddir for subpkgs. (GH-18676)
https://github.com/python/cpython/commit/02673352b5db6ca4d3dc804965facb
Gregory P. Smith added the comment:
keeping this open while i investigate if fixing 3.8 and 3.7 is feasible. if
nothing else i'll try to add a note to the docs about the issue in 3.5-3.8 with
a code sample suggested workaround.
--
resolution: -> fixed
stage: patch review -
Change by Gregory P. Smith :
--
pull_requests: +18075
stage: commit review -> patch review
pull_request: https://github.com/python/cpython/pull/18718
___
Python tracker
<https://bugs.python.org/issu
Gregory P. Smith added the comment:
New changeset ce720d3e0674d6ac6f1b950c20a89be4cfde7853 by Gregory P. Smith in
branch '3.8':
bpo-39769: Fix compileall ddir for subpkgs. (GH-18676) (GH-18718)
https://github.com/python/cpython/commit/ce720d3e0674d6ac6f1b950c20a89b
Change by Gregory P. Smith :
--
pull_requests: +18082
pull_request: https://github.com/python/cpython/pull/18725
___
Python tracker
<https://bugs.python.org/issue39
Gregory P. Smith added the comment:
New changeset 7c64726ced3d6b5d04537386d6a9ca6d179c3be4 by Gregory P. Smith in
branch '3.7':
[3.7] bpo-39769: Fix compileall ddir for subpkgs. (GH-18676) (GH-18718)
(GH-18725)
https://github.com/python/cpyt
Gregory P. Smith added the comment:
if anyone needs this on their older 3.6 or 3.5 trees, the 3.7/3.8 patch is a
trivial backport.
--
stage: patch review -> commit review
status: open -> closed
___
Python tracker
<https://bugs.p
Gregory P. Smith added the comment:
FYI - this appears to have caused a regression -
https://bugs.python.org/issue39776
--
nosy: +gregory.p.smith
___
Python tracker
<https://bugs.python.org/issue32
Gregory P. Smith added the comment:
While i don't think this was needed in 3.7 and 3.8, you kept the default
behavior the same so I don't think it is a problem.
If someone builds an interpreter with this configure flag, does it break
compatibility with anything that code may have
Gregory P. Smith added the comment:
I _doubt_ there is code expecting the default year when unspecified to actually
be 1900.
Change that default to any old year with a leap year (1904?) and it'll still
(a) stand out as a special year that can be looked up should it wind up being
_use
Gregory P. Smith added the comment:
fwiw oss-fuzz also finds this on struct (via ubsan)
https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=20949
struct.unpack('?', ' ')
--
___
Python tracker
<https://bug
Gregory P. Smith added the comment:
fyi - we just had a test run into this (in a flaky manner - definitely a race
condition) at work:
```
...
for f in inspect.stack(context=0)
File "/inspect.py", line 1499, in stack
return getouterframes(sys._getframe(1), conte
Gregory P. Smith added the comment:
Serhiy: Why is dict.copy() not thread safe?
if what you say of list(dict) being safe, iterating over that and looking up
the keys would work. But all of this is entirely non-obvious to the reader of
the code. all of these _look_ like they should be safe
Change by Gregory P. Smith :
--
pull_requests: +18143
stage: resolved -> patch review
pull_request: https://github.com/python/cpython/pull/18786
___
Python tracker
<https://bugs.python.org/issu
Gregory P. Smith added the comment:
New changeset 85cf1d514b84dc9a4bcb40e20a12e1d82ff19f20 by Gregory P. Smith in
branch 'master':
bpo-13487: Use sys.modules.copy() in inspect.getmodule() for thread safety.
(GH-18786)
https://github.com/python/cpyt
Gregory P. Smith added the comment:
Testing by changing list(sys.modules.items()) to sys.modules.copy().items()
internally with a large integration test that was reliably flaky on this line
before shows that the .copy().items() worked. The test is reliable again.
So I've gone ahea
Gregory P. Smith added the comment:
If anyone else has a way to reproduce this issue, please run your tests with a
3.7/3.8/3.9 interpreter with the fix I committed applied and report back if you
still see this failure on that line.
I believe this to be fixed based on my own testing so I am
Gregory P. Smith added the comment:
FYI - I updated the ubsan buildbot to clang 9 so this one shows up in there now:
/var/lib/buildbot/workers/clang-ubsan/3.x.gps-clang-ubsan.clang-ubsan/build/Modules/_struct.c:487:28:
runtime error: load of value 116, which is not a valid value for type
New submission from Gregory P. Smith :
Recurring theme: The stdlib has the issue of DeprecationWarning being added to
APIs we are changing or removing a few versions in the future yet we perceive
that many people never actually bother to try checking their code for
deprecation warnings
Gregory P. Smith added the comment:
I think those dict unpacking and merging options are sufficient that adding an
extra_env= parameter would merely complicate the already over complex API.
Thanks for the suggestions folks!
--
resolution: -> rejected
stage: -> resolved
Gregory P. Smith added the comment:
New changeset 9165addc22d05e776a54319a8531ebd0b2fe01ef by Ashwin Ramaswami in
branch 'master':
bpo-38576: Disallow control characters in hostnames in http.client (GH-18995)
https://github.com/python/cpython/commit/9165addc22d05e776a54319a8531eb
Gregory P. Smith added the comment:
Thanks for the PR Ashwin!
--
assignee: -> gregory.p.smith
___
Python tracker
<https://bugs.python.org/issue38576>
___
_
Gregory P. Smith added the comment:
If anyone cares about 2.7, the *final* release is coming up in a few weeks.
They'll need to figure out what it looks like there and get a 2.7 PR reviewed
by the release manager.
--
resolution: -> fixed
stage: patch review -> reso
Gregory P. Smith added the comment:
marking as a 2.7 release blocker just to get benjamin's RM attention before the
final 2.7.
--
assignee: gregory.p.smith -> benjamin.peterson
nosy: +benjamin.peterson
priority: high -> release blocker
stage: resolved -> patch review
New submission from Gregory P. Smith :
The correct C99 way to do this is using a char[]. PyBytesObject and unicode's
struct encoding_map both do this.
Unclear to me if we should backport this to earlier versions or not (because
PyBytesObject may be exposed?) Probably, but I also dou
Change by Gregory P. Smith :
--
keywords: +patch
pull_requests: +18592
pull_request: https://github.com/python/cpython/pull/19232
___
Python tracker
<https://bugs.python.org/issue40
Gregory P. Smith added the comment:
>From the PR comment thread (as I opened that first):
"""Well, there was no other choice in ISO C89 than using char ob_sval[1];, no?
Is char ob_sval[]; supported by the C compiler supported by CPython? Like
Visual Studio, GCC, clang
Change by Gregory P. Smith :
--
nosy: +vstinner
___
Python tracker
<https://bugs.python.org/issue40120>
___
___
Python-bugs-list mailing list
Unsubscribe:
Gregory P. Smith added the comment:
"""
The [1] thing is used in more places:
PyObject *f_localsplus[1]; in PyFrameObject
PyObject *ob_item[1]; in PyTupleObject
void *elements[1]; in asdl_seq and int elements[1];` in asdl_int_seq
digit ob_digit[1]; in PyLongObject
Py_ssi
Change by Gregory P. Smith :
--
stage: patch review -> needs patch
___
Python tracker
<https://bugs.python.org/issue40120>
___
___
Python-bugs-list mai
Change by Gregory P. Smith :
--
title: Undefined C behavior going beyond end of struct via a char[1]. ->
Undefined C behavior going beyond end of struct via a [1] arrays.
___
Python tracker
<https://bugs.python.org/issu
Gregory P. Smith added the comment:
Isn't the only actual way for a C .h file to be compatible with C++ via
extern "C" {
}
which all of our non-meta include files appear to have already?
--
___
Python tracker
<https://bugs.pyt
Gregory P. Smith added the comment:
updates:
- extern "C" is indeed really only about linking so it has no bearing.
What I'm hearing from talking to our C++ compiler team is unfortunately sad:
The C++ standard does not support flexible array member syntax on purpose
beca
Gregory P. Smith added the comment:
New changeset 96c5f5a3a3fabf43e8114d0dbc30bed409da1ba6 by Tim Hatch in branch
'3.7':
[3.7] bpo-36541: lib2to3: Support named assignment expressions (GH-12702)
(GH-19317)
https://github.com/python/cpython/commit/96c5f5a3a3fabf43e8114d0dbc30be
Gregory P. Smith added the comment:
master/3.9 changeset:
https://github.com/python/cpython/commit/3c3aa4516c70753de06bb142b6793d01330fcf0f
3.8 changeset:
https://github.com/python/cpython/commit/1098671e4e5ec1513247f05598158eaa3428c5be
Gregory P. Smith added the comment:
Support for `:=` is in, are we still lacking `f(**not x)` support?
--
___
Python tracker
<https://bugs.python.org/issue36
Gregory P. Smith added the comment:
agreed, being opaque seems ideal.
--
___
Python tracker
<https://bugs.python.org/issue40120>
___
___
Python-bugs-list mailin
Gregory P. Smith added the comment:
PyBytesObject could become a struct that contains a single opaque internal
struct.
there is some code out there that references PyBytesObjects internals by field
name but my searches across a broad swath of code so far seem to suggest that
is so rare
Gregory P. Smith added the comment:
While I did a general apt update on that worker, I suspect I may have knocked
the heatsink loose over the weekend while dealing with an upcoming bot sitting
behind it on the shelf. That'd explain why it is alternately crashing and
making mystery re
Gregory P. Smith added the comment:
bad buildbot hardware. i've taken that bot offline.
--
resolution: -> not a bug
stage: -> resolved
status: open -> closed
type: -> crash
___
Python tracker
<https://bugs.p
Gregory P. Smith added the comment:
Thanks for sharing! It's good to have a patch implementing for others who
might need it to try out.
We experimented with an implementation of this on CPython 2.7 that we called
Eternal Refcounts for YouTube many years ago. For the same reason (s
Gregory P. Smith added the comment:
Marking everything as immortal/eternal after you've loaded your common code &
data but before you do your forking is thenorm for this kind of serving system.
You already presumably have a defined lifetime for the processes so they'll
likely
Gregory P. Smith added the comment:
raspbian failure https://buildbot.python.org/all/#/builders/645/builds/31
--
nosy: +gregory.p.smith
___
Python tracker
<https://bugs.python.org/issue35
Change by Gregory P. Smith :
--
assignee: -> gregory.p.smith
___
Python tracker
<https://bugs.python.org/issue40313>
___
___
Python-bugs-list mailing list
Un
New submission from Gregory P. Smith :
Based on the PEP 617 acceptance thread on python-dev, lib2to3 is eventually
going to run into trouble parsing modern syntax a few releases from now.
It would be better off maintained outside of the standard library. It gets
used by a lot of things and
Change by Gregory P. Smith :
--
components: +2to3 (2.x to 3.x conversion tool)
stage: -> needs patch
___
Python tracker
<https://bugs.python.org/issu
Change by Gregory P. Smith :
--
keywords: +patch
pull_requests: +18969
stage: needs patch -> patch review
pull_request: https://github.com/python/cpython/pull/19645
___
Python tracker
<https://bugs.python.org/issu
Gregory P. Smith added the comment:
Okay,the pending deprecation is in. Keeping open as a reminder to turn that
into a real DeprecationWarning in 3.10 after the 3.9 branch is cut.
We'll then want to track reminding us to remove it in
Gregory P. Smith added the comment:
New changeset 503de7149d03bdcc671dcbbb5b64f761bb192b4d by Carl Meyer in branch
'master':
bpo-40360: Deprecate lib2to3 module in light of PEP 617 (GH-19663)
https://github.com/python/cpython/commit/503de7149d03bdcc671dcbbb5b64f7
Gregory P. Smith added the comment:
I think what we're doing with the documentation update is fine. We can add a
warning on stderr to the tool in 3.11. But I don't expect people will be using
the tool _from_ the latest CPython 3.x by then.
2to3 is already included with Python 2
Gregory P. Smith added the comment:
Adding aliases in openssl is presumably process global right? Is that wise
given it'd mean other openssl using c/c++ code in the process would now see
the same aliases and could behave differently when used with python vs
without?
On Sun, May 3, 2020,
Gregory P. Smith added the comment:
New changeset 18f1c60a1625d341a905c7e07367c32c08f222df by Miro Hrončok in
branch 'master':
bpo-40360: Add a What's New entry for lib2to3 pending deprecation (GH-19898)
https://github.com/python/cpython/commit/18f1c60a1625d341a905c7e07
Gregory P. Smith added the comment:
Thanks!
We use this function internally in some VM traceback grabbing code but the best
solution looks to just be for us to adopt the patch to 3.9 on our interpreter
until we're running on 3.9.
--
nosy: +gregory.p.
New submission from Gregory P. Smith :
PEP 618 https://www.python.org/dev/peps/pep-0618 discussions are still on
going. This issue is being filed to track an implementation, assuming the PEP
is accepted and one is decided upon.
I'm filing it now, as I can at least use the issu
Change by Gregory P. Smith :
--
keywords: +patch
pull_requests: +19422
stage: needs patch -> patch review
pull_request: https://github.com/python/cpython/pull/20118
___
Python tracker
<https://bugs.python.org/issu
Gregory P. Smith added the comment:
New changeset 6a5d3ff67644af42b1a781be2eacb2e82913441c by Gregory P. Smith in
branch 'master':
bpo-40636: Clarify the zip built-in docstring. (GH-20118)
https://github.com/python/cpython/commit/6a5d3ff67644af42b1a781be2eacb2
Gregory P. Smith added the comment:
FWIW, while i'm never a fan of doctests, this would also help reduce the impact
of other golden value tests where different platforms capitalize their error
messages or not.
--
nosy: +gregory.p.smith
versions: +Python 3.10 -Pytho
Gregory P. Smith added the comment:
gross / nice find :)
--
assignee: -> gregory.p.smith
nosy: +gregory.p.smith
___
Python tracker
<https://bugs.python.org/issu
Gregory P. Smith added the comment:
New changeset 86684319d3dad8e1a7b0559727a48e0bc50afb01 by Renato Cunha in
branch 'master':
bpo-42406: Fix whichmodule() with multiprocessing (GH-23403)
https://github.com/python/cpython/commit/86684319d3dad8e1a7b0559727a48e
Gregory P. Smith added the comment:
thanks Renato!
--
resolution: -> fixed
stage: patch review -> commit review
status: open -> closed
___
Python tracker
<https://bugs.python.or
Gregory P. Smith added the comment:
I agree with Victor. When code launches a process with subprocess APIs, it is
expected that the subprocess module manages the process.
Calling os.waitpid directly instead of using subprocess's APIs breaks that
expectation.
Also, WNOWAIT and w
Gregory P. Smith added the comment:
New changeset 8d4f57dbd10846ffb4881b6509a511be0ab3b913 by pxinwr in branch
'master':
bpo-31904: fix test_doctest.py failures for VxWorks (GH-23419)
https://github.com/python/cpython/commit/8d4f57dbd10846ffb4881b6509a511be0ab3b913
-
Gregory P. Smith added the comment:
The Linux kernel code is not sufficiently easy to follow to understand if it
has this issue or if it pre-creates the dirent structures for all fds at
opendir time for /proc/self/fd or if it is iterating through the list of fds in
sorted order so an older
Change by Gregory P. Smith :
--
pull_requests: +22615
pull_request: https://github.com/python/cpython/pull/23759
___
Python tracker
<https://bugs.python.org/issue36
Gregory P. Smith added the comment:
While I said i didn't care... and don't really want to... I found a reason to
at least not omit pep-570 positional only arg parsing support give things like
yapf still use it rather than forking their own copy. PR testing.
-
Gregory P. Smith added the comment:
New changeset 42c9f0fd0a5e67d4ae0022bfd7370cb9725a5b01 by Gregory P. Smith in
branch 'master':
bpo-36541: Add lib2to3 grammar PEP-570 pos-only arg parsing (GH-23759)
https://github.com/python/cpython/commit/42c9f0fd0a5e67d4ae0022bfd7370c
Change by Gregory P. Smith :
--
resolution: out of date -> fixed
stage: patch review -> commit review
status: open -> closed
___
Python tracker
<https://bugs.python.or
Gregory P. Smith added the comment:
New changeset fdb9efce6ac211f973088eef508740c3fa2bd182 by vabr-g in branch
'master':
bpo-41877: Check for misspelled speccing arguments (GH-23737)
https://github.com/python/cpython/commit/fdb9efce6ac211f973088eef508740
Gregory P. Smith added the comment:
The shell was isolating the user from the exec error by always existing and
turning the exec error into a status return.
>>> subprocess.run('foo', shell=True)
/bin/sh: line 1: foo: command not found
CompletedProcess(args=&#
Gregory P. Smith added the comment:
I suggest just adding a couple options to getstatusoutput instead of wrangling
new to-catch-or-not-to-catch APIs if code like your test_posix example is what
you want to replace.
--
___
Python tracker
<ht
Gregory P. Smith added the comment:
We could also be thinking too low level here. We don't have to re-use
returncode for this or do it on POpen itself. This could be done at the
`run()` API level and CompletedProcess could be given state indicating success
or failure of the exec i
Gregory P. Smith added the comment:
arguably run() with check=True could've turned the OSError into a
CalledProcessError [can't do that now, someone surely depends on it]. So if
both are supplied, perhaps it does that instead of returning a CompletedProcess
with .oserror set
Change by Gregory P. Smith :
--
keywords: +patch
pull_requests: +22780
stage: needs patch -> patch review
pull_request: https://github.com/python/cpython/pull/23930
___
Python tracker
<https://bugs.python.org/issu
Change by Gregory P. Smith :
--
nosy: +gregory.p.smith
nosy_count: 2.0 -> 3.0
pull_requests: +22782
pull_request: https://github.com/python/cpython/pull/23932
___
Python tracker
<https://bugs.python.org/issu
Gregory P. Smith added the comment:
New changeset 8badadec53cbf9dc049c5b54198c5689481e3f3f by Gregory P. Smith in
branch 'master':
bpo-42727: Fix the NEWS entry .rst (GH-23932)
https://github.com/python/cpython/commit/8badadec53cbf9dc049c5b54198c56
Change by Gregory P. Smith :
--
versions: +Python 3.10 -Python 3.9
___
Python tracker
<https://bugs.python.org/issue38435>
___
___
Python-bugs-list mailin
1301 - 1400 of 3274 matches
Mail list logo
