Gregory P. Smith added the comment:
At first quick glance, this makes sense and the API looks reasonable.
Question: what happens on interpreter shutdown?
Shutdown obviously finalized and clears out most all dicts. I guess the C
callback simply gets called for each of these? That makes
Change by Gregory P. Smith :
--
nosy: +Mark.Shannon
___
Python tracker
<https://bugs.python.org/issue46896>
___
___
Python-bugs-list mailing list
Unsubscribe:
Gregory P. Smith added the comment:
Per interpreter seems best.
If someone using this feature writes a buggy implementation of a callback that
doesn't chain reliably, that is a bug in their code and all of the fallout from
that is "just" a bug to be fixed in said code.
Think
Gregory P. Smith added the comment:
New changeset 46a116c1c9f6b60a3d35ab9a419f8eee5de2542e by Géry Ogam in branch
'main':
bpo-38738: Fix formatting of True and False in the threading documentation
(GH-31678)
https://github.com/python/cpython/commit/46a116c1c9f6b60a3d35ab9a419f8e
Changes by Gregory P. Smith:
--
title: Fix dumbdbm, which fixes test_shelve (for me); instrument other tests so
we catch this sooner (and more directly) -> [py3k] Fix dumbdbm, which fixes
test_shelve (for me); instrument other tests so we catch this sooner (and more
direc
Changes by Gregory P. Smith:
--
assignee: -> greg
__
Tracker <[EMAIL PROTECTED]>
<http://bugs.python.org/issue1007>
__
___
Python-bugs-list mailing list
Uns
Gregory P. Smith added the comment:
The BerkeleyDB library operates on bytes only. Unicode doesn't make
sense as a key without converting it to a particular encoding first.
Use the unicode object's encode() method if you need to use it as a
database key or create a wrapper object o
Changes by Gregory P. Smith:
--
assignee: -> greg
_
Tracker <[EMAIL PROTECTED]>
<http://bugs.python.org/issue1725856>
_
___
Python-bugs-list mailing li
Gregory P. Smith added the comment:
this was marked 'open' and 'fixed' at the same time. that should be an
invalid state. it was indeed fixed eons ago.
--
nosy: +greg
status: open -> closed
Tracker <[EMAIL PROTECTED
Gregory P. Smith added the comment:
This code deletes the item that the internal database cursor created by
the db.first() call is pointing at. Then when db.first() is called
again it tries to reuse the same cursor. Now to decide if thats the
expected behavior or a real problem and how to fix
Gregory P. Smith added the comment:
My first description wasn't quite accurate. What was happening is that
the __delitem__(i) call by del was closing the existing cursor and
saving the key it was pointing to and the first() and last() methods
were creating a new cursor and trying to restor
Gregory P. Smith added the comment:
Committed to HEAD as r57378
Committed to release25-maint as r57379
Committed to py3k as r57380
--
resolution: -> fixed
status: pending -> closed
_
Tracker <[EMAIL PROTECTED]>
<http://bugs.python.o
Gregory P. Smith added the comment:
Oops. You're right. This was referring to the legacy bsddb185 module
in Modules/bsddbmodule.c. In 2.6 that is never built by default. I'm
marking it as wont fix.
--
resolution: fixed -> wont fix
title: bsddb module needs iterator
Gregory P. Smith added the comment:
looks like someone already committed the one liner dumbdbm latin-1 fix.
But the meat of this patch is the unit test improvements.
I had to fix test_whichdb to exclude dumbdbm as that has no file for
whichdb to test.
committed to py3k as r57419
Changes by Gregory P. Smith:
--
nosy: -greg
_
Tracker <[EMAIL PROTECTED]>
<http://bugs.python.org/issue1583946>
_
___
Python-bugs-list mailing list
Unsubs
Gregory P. Smith added the comment:
Does the existing python SSL implementation allow it to be used over
something other than a socket? If so then yes that makes sense, but
otherwise its best to leave its inheritance from socket.error so that
code that works when handed a regular socket can
New submission from Gregory P. Smith:
I've converted _bsddb.c to use the py3k buffer API for all data and keys
it takes as input. All tests now fail with this error:
BufferError: Cannot make this object read-only.
This presumably results from this call:
PyObject_GetBuffer(obj,
New submission from Gregory P. Smith:
This is my svn diff of a py3k Modules/_bsddb.c converted to use the
buffer API. I'm submitting it here as so it doesn't get misplaced as it
currently won't work until bytes objects support PyBUF_LOCKDATA (a
separate bug)
Changes by Gregory P. Smith:
--
priority: normal ->
__
Tracker <[EMAIL PROTECTED]>
<http://bugs.python.org/issue1035>
__
___
Python-bugs-list mailing list
Uns
New submission from Gregory P. Smith:
The Lib/pdb.py debugger fails in the py3k branch.
Traceback (most recent call last):
File "/usr/local/gps/python/py3k/Lib/pdb.py", line 1247, in main
pdb._runscript(mainpyfile)
File "/usr/local/gps/python/py3k/Lib/pdb.py", line
Gregory P. Smith added the comment:
committed to py3k branch using SIMPLE instead of LOCKDATA: r57610
--
resolution: -> accepted
status: open -> closed
__
Tracker <[EMAIL PROTECTED]>
<http://bugs.pytho
Gregory P. Smith added the comment:
I was running it by typing "./python Lib/pdb.py Lib/test_foo.py"
__
Tracker <[EMAIL PROTECTED]>
<http://bugs.python.org/issue1038>
__
_
Gregory P. Smith added the comment:
I sent an initial patch to the mailing list. Its too late to be ready
for 3.0a1; I'll fix it up next week.
--
assignee: -> gregory.p.smith
__
Tracker <[EMAIL PROTECTED]>
<http://bugs.pyt
Gregory P. Smith added the comment:
i'll take care of this.
--
assignee: -> gregory.p.smith
nosy: +gregory.p.smith
_
Tracker <[EMAIL PROTECTED]>
<http://bugs.python
Gregory P. Smith added the comment:
i'll take care of it. any more info in the interim will be appreciated.
--
assignee: -> gregory.p.smith
nosy: +gregory.p.smith
__
Tracker <[EMAIL PROTECTED]>
<http://bugs.pyt
Gregory P. Smith added the comment:
can you provide a test zip file demonstrating the problem?
--
assignee: -> gregory.p.smith
nosy: +gregory.p.smith
type: crash -> behavior
__
Tracker <[EMAIL PROTECTED]>
<http://bugs.pytho
Gregory P. Smith added the comment:
that looks good to me.
fixed in:
2.6 trunk r58023
release25-maint r58024
py3k r58025
--
resolution: -> fixed
status: open -> closed
__
Tracker <[EMAIL PROTECTED]>
<http://bugs.pytho
Gregory P. Smith added the comment:
socket.error now inherits from IOError as of trunk r58067:
Change socket.error to inherit from IOError rather than being a stand
alone class. This addresses the primary concern in
http://bugs.python.org/issue1706815
python-dev discussion here:
http
Gregory P. Smith added the comment:
Attaching the most recent patch (minor update from the second one i sent
to the python-3000 mailing list to initialize ob_readonly_exports = 0 in
the appropriate places).
Current mailing list discussion is pointing out that the name LOCKDATA
means something
Gregory P. Smith added the comment:
This bug will be taken care of by PEP 3137
http://python.org/dev/peps/pep-3137/ being implemented.
Anyways, no the _bsddb.c changes that I checked in do not cause a
problem because I checked them in using PyBUF_SIMPLE.
Until PEP 3137 is implemented the
New submission from Gregory P. Smith:
This makes all existing bytesobject.c methods use the buffer API rather
than explicitly requiring bytes objects as input. It also fixes input
to append() and remove() that was not strict enough and improves a few
unit tests in that area.
NOTE: this patch
Changes by Gregory P. Smith:
__
Tracker <[EMAIL PROTECTED]>
<http://bugs.python.org/issue1261>
__
___
Python-bugs-list mailing list
Unsubscribe:
http://mail.python.org/mai
Gregory P. Smith added the comment:
> > Patch updated. It now implements the is*() methods for PyBytes. It
> > moves common code into a shared bytes_ctype.c and .h file so that
> > stringobject.c and bytesobject.c can share as much as possible.
>
> Did you move
Changes by Gregory P. Smith:
__
Tracker <[EMAIL PROTECTED]>
<http://bugs.python.org/issue1261>
__
___
Python-bugs-list mailing list
Unsubscribe:
http://mail.python.org/mai
Changes by Gregory P. Smith:
--
nosy: -gps
__
Tracker <[EMAIL PROTECTED]>
<http://bugs.python.org/issue1261>
__
___
Python-bugs-list mailing list
Unsubs
Gregory P. Smith added the comment:
heh yep that does look like a bug. Laughing at that one goes well with
this comment currently in test_dbshelve.py:
# TODO: Add test cases for a DBShelf in a RECNO DB.
i'll fix it. :)
__
Tracker <[EMAIL PROTECTED
New submission from Gregory P. Smith:
If a bsddb.db.DB object is closed before any DBCursor objects
referencing it are closed, python will crash when the cursors are closed
or deleted.
Workaround: never close a database with open cursors. this is annoying
in unittest code where a tearDown
Gregory P. Smith added the comment:
Fixed in python trunk r58434, release25-maint r58435, py3k r58438
--
resolution: -> fixed
status: open -> closed
versions: +Python 2.6, Python 3.0
__
Tracker <[EMAIL PROTECTED]>
<http://bugs.pytho
Changes by Gregory P. Smith:
__
Tracker <[EMAIL PROTECTED]>
<http://bugs.python.org/issue1261>
__
___
Python-bugs-list mailing list
Unsubscribe:
http://mail.python.org/mai
New submission from Gregory P. Smith:
The PyBytes (pep3137 buffer) .extend() method currently only accepts as
input something supporting the pep3118 buffer API. It also needs to
accept an iterable of ints in the 0..255 range.
--
keywords: py3k
messages: 56478
nosy: gregory.p.smith
Changes by Gregory P. Smith:
__
Tracker <[EMAIL PROTECTED]>
<http://bugs.python.org/issue1261>
__
___
Python-bugs-list mailing list
Unsubscribe:
http://mail.python.org/mai
Changes by Gregory P. Smith:
__
Tracker <[EMAIL PROTECTED]>
<http://bugs.python.org/issue1261>
__
___
Python-bugs-list mailing list
Unsubscribe:
http://mail.python.org/mai
Gregory P. Smith added the comment:
Committed revision 58493
--
resolution: -> accepted
status: open -> closed
__
Tracker <[EMAIL PROTECTED]>
<http://bugs.pytho
Changes by Gregory P. Smith:
__
Tracker <[EMAIL PROTECTED]>
<http://bugs.python.org/issue1261>
__
___
Python-bugs-list mailing list
Unsubscribe:
http://mail.python.org/mai
Changes by Gregory P. Smith:
--
nosy: +gregory.p.smith
__
Tracker <[EMAIL PROTECTED]>
<http://bugs.python.org/issue1247>
__
___
Python-bugs-list mailing list
Unsubs
Gregory P. Smith added the comment:
This should be fixed in py3k revision 58761.
--
keywords: +py3k
resolution: -> fixed
status: open -> closed
__
Tracker <[EMAIL PROTECTED]>
<http://bugs.pytho
New submission from Gregory P. Smith:
I'm attaching the patch to add this method here just as a place to track
it for now. It compiles and it looks right, but it causes a crash
within BerkeleyDB when the test case runs using BerkeleyDB 4.6.21. It
passes as expected when using 4.4.20 or 4
Gregory P. Smith added the comment:
option 1 sounds best. i'll take care of this. thanks for noticing this
and providing suggestions and a patch.
__
Tracker <[EMAIL PROTECTED]>
<http://bugs.python
Changes by Gregory P. Smith:
--
components: +Library (Lib) -None
versions: +Python 2.5, Python 2.6
__
Tracker <[EMAIL PROTECTED]>
<http://bugs.python.org/issue1385>
__
__
Gregory P. Smith added the comment:
Fixed in trunk (2.6) svn revision 58868 with rfc 4231 unit tests and
tests for the new warnings.
The fix parts of that diff should be backported to 2.5. I'm leaving the
Python 2.5 flag on the bug until that happens.
I'm leaving Python 3.0 and py
Gregory P. Smith added the comment:
Fixed in release25-maint branch in svn r58870.
--
versions: -Python 2.5
__
Tracker <[EMAIL PROTECTED]>
<http://bugs.python.org/
Gregory P. Smith added the comment:
yeah i've seen this at random times as well. I don't believe its
related to py3k or the pep3137 branch at all, i believe seen it on trunk
but its rare.
For reference, what platform (OS) and BerkeleyDB version did you build
python with when thi
Gregory P. Smith added the comment:
release25-maint and trunk (2.6) appear to do the correct thing when
testing on my ubuntu gutsy linux x86 box. test script and file attached.
The problem is reproducable in a release24-maint build compiled 2007-11-05.
--
nosy: +gregory.p.smith
Added
Gregory P. Smith added the comment:
attaching the test input file. use od -x or similar to compare the
new.csv output with issue1511.csv to see if the problem happened.
its 2.4.. that may be old enough to be considered dead
Added file: http://bugs.python.org/file8817/issue1511.csv
Gregory P. Smith added the comment:
If the server failed to close a transaction the protocol stream is over
unless you mime relying on hope and luck. Poplib has a nasty set of server
implementation bugs to work around here.
Readline as defined today no longer suits its needs but I still
Gregory P. Smith added the comment:
This looks like a bug in your daemon not in subprocess. Your daemon is
intentionally not closing its inherited stderr fd.
--
nosy: +gregory.p.smith
resolution: -> invalid
status: open -> closed
___
Gregory P. Smith added the comment:
+1 nice! A couple minor comments on the code review.
--
nosy: +gregory.p.smith
___
Python tracker
<http://bugs.python.org/issue13
Gregory P. Smith added the comment:
Why make this decision ourselves at all? Copy what Mozilla and Chromium do
by default.
--
___
Python tracker
<http://bugs.python.org/issue13
Gregory P. Smith added the comment:
http://pypi.python.org/pypi/unittest2 says
"There are several places in unittest2 (and unittest) that call str(...) on
exceptions to get the exception message. This can fail if the exception was
created with non-ascii unicode. This is rare and I
Gregory P. Smith added the comment:
We're on python 2.6, otherwise this would be a moot point. but you might want
to include something like that in a new unittest2 backport release.
--
___
Python tracker
<http://bugs.python.org/i
Gregory P. Smith added the comment:
I just nuked the pure Python POSIX subprocess implementation in
70467:75ca834df824. No need for both implementations. _posixsubprocess is now
the only option.
--
___
Python tracker
<http://bugs.python.
Gregory P. Smith added the comment:
Include an appropriate Version Added annotation in the pipe2 documentation.
Otherwise the current patches look good to me.
--
___
Python tracker
<http://bugs.python.org/issue12
Gregory P. Smith added the comment:
I added comments in the code review.
this patch is looking good once the comments are addressed. thanks for your
contribution!
As for talk of support for recursion... thats what os.walk() is for. it
doesn't belong as part of any particular indiv
Gregory P. Smith added the comment:
This was fixed in the other bug in 2.6 and 2.7.
--
dependencies: +socket.readline() interface doesn't handle EINTR properly
nosy: +gregory.p.smith
resolution: -> fixed
status: open -> closed
___
Pyt
New submission from Gregory P. Smith :
The file object readline() and readlines() methods can lose data when an
underlying read system call is interrupted. They will abort with an IOError in
this case but any incomplete line data they have read will be discarded.
readline() and readlines
Gregory P. Smith added the comment:
3.x has the same issue. unittest & patch forthcoming that addresses that as
well.
2.6 also has the issue but it is in security fix only mode so I won't backport
to that.
--
versions: +Python 3.1, Python 3.2, P
Gregory P. Smith added the comment:
.readall() and the equivalent unbounded .read() also have this problem.
--
title: file readline & readlines methods can lose data on EINTR -> file
readline, readlines & readall methods can lose da
Changes by Gregory P. Smith :
Added file: http://bugs.python.org/file22261/test_fileio_readers_3.2-gps01.diff
___
Python tracker
<http://bugs.python.org/issue12
Gregory P. Smith added the comment:
I haven't looked beyond the reading methods it is possible that some of the
write implementations have a similar issue. Patch gps02 for 3.2 attached.
I'll use that as the basis for a stand alone test_file_eintr.py targeted at 2.7.
--
Changes by Gregory P. Smith :
Removed file:
http://bugs.python.org/file22261/test_fileio_readers_3.2-gps01.diff
___
Python tracker
<http://bugs.python.org/issue12
Changes by Gregory P. Smith :
--
nosy: +pitrou
___
Python tracker
<http://bugs.python.org/issue12268>
___
___
Python-bugs-list mailing list
Unsubscribe:
Gregory P. Smith added the comment:
This makes sense, I'll add it to 3.3.
--
assignee: -> gregory.p.smith
nosy: +gregory.p.smith
___
Python tracker
<http://bugs.python.org/i
Gregory P. Smith added the comment:
That failure is likely due to the environment being empty causing the
subprocess to be unable to run. Notice this error message further up:
test_empty_env (test.test_subprocess.ContextManagerTests) ...
/srv/buildbot/buildarea/3.2.bolen-ubuntu/build/python
Gregory P. Smith added the comment:
No Python thread is ever fork safe because the Python interpreter itself can
never be made fork safe. Nor should anyone try to make the interpreter itself
safe. It is too complex and effectively impossible to guarantee.
There is no general solution to this
Gregory P. Smith added the comment:
The fact that it called __get_builtin_constructor implies that the ssl backed
_hashlib module was not available. It looks like the non-openssl standalone
_sha256 module (and likely the _sha512 module) both failed to be compiled.
I would not expect that to
Gregory P. Smith added the comment:
Being able to set which behavior you want in a (?XXX) flag at the start of the
regex is valuable so that applications that take a regex can support the new
syntax automatically when the python version they are running on is updated.
The (?XXX) should
Gregory P. Smith added the comment:
Are there any applications out there that actually rely on forking during
import?
(someone discovered this bug... i'd like to know why. i think its a disgusting
thing to do but never explicitly disallowed it in the
Gregory P. Smith added the comment:
Agreed on the explicit exception and documentation. :)
--
___
Python tracker
<http://bugs.python.org/issue9573>
___
___
Pytho
Gregory P. Smith added the comment:
your updated patch looks good to me. i've posted it here for easy review if
anyone else wants to take a look:
http://codereview.appspot.com/1995049/
--
assignee: gregory.p.smith -> pitrou
___
Python
Gregory P. Smith added the comment:
closing because it is too late to backport this to 2.7. It is available as a
backport in http://code.google.com/p/python-subprocess32/.
As for the idea of not using SIG_IGN and installing a default no-op handler,
that is another approach
Gregory P. Smith added the comment:
Sounds like a good idea. frozensets for both.
--
___
Python tracker
<http://bugs.python.org/issue7418>
___
___
Python-bug
Gregory P. Smith added the comment:
Implemented in py3k r84554.
--
status: open -> closed
___
Python tracker
<http://bugs.python.org/issue7418>
___
___
Python-
Gregory P. Smith added the comment:
libtomcrypt is a _great_ library. That is what hashlib uses for the hash
algorithms when OpenSSL is not available.
But the _primary_ reason for using OpenSSL is that it is the defacto open
source location for the best architecture specific implementations
Gregory P. Smith added the comment:
Overall I like the approach.
A few questions / clarifications:
is errno.EMFILE portable? will that errno test work on both posix and
windows?
should the is_resource_enabled('subprocess') stuff be preserved (why was it
there to begin with? b
Gregory P. Smith added the comment:
looks good to me. commit it. :)
--
Added file: http://bugs.python.org/file18924/unnamed
___
Python tracker
<http://bugs.python.org/issue9895>
___looks good to me. Â com
Gregory P. Smith added the comment:
This bug has turned into a bikeshed.
Lets stop that please.
I _DON'T_ care about performance when it comes to someone submitting an
actual working implementation of a crypto library for inclusion with the
standard library. The first priority needs to
Gregory P. Smith added the comment:
thanks Antoine!
--
Added file: http://bugs.python.org/file19042/unnamed
___
Python tracker
<http://bugs.python.org/issue9950>
___thanks A
Gregory P. Smith added the comment:
can i have you do another experiment here?
after you "ssh r...@testbox /tmp/test.{py,sh}" can you:
1) login to testbox, run pstree -p
2) run an strace -p pid_of_python_or_bash >strace_for_foo.out (for each of the
test.py and test.sh
Gregory P. Smith added the comment:
Ah right, thanks. I added a restore_signals=True argument to Popen in Python
3.2's subprocess module that does what you want:
http://docs.python.org/dev/library/subprocess.html
The way to emulate that in earlier versions is to use a preexec_fn to re
Gregory P. Smith added the comment:
A workaround for those still having problems with this:
stub out subprocess._cleanup with a no-op method.
It it only useful if your app is ever using subprocess and forgetting to call
wait() on Popen objects before they are deleted. If you are, you can
Gregory P. Smith added the comment:
looks harmless to me. though i think issue812369 looks okay as well at first
glance.
--
___
Python tracker
<http://bugs.python.org/issue1545
Gregory P. Smith added the comment:
0001-update-GC-shutdown-patch.patch looks sane to me at first glance. any
other opinions?
--
___
Python tracker
<http://bugs.python.org/issue812
Gregory P. Smith added the comment:
I don't see this issue on netbsd 5.0.2 i386 in the py3k branch.
--
nosy: +gregory.p.smith
___
Python tracker
<http://bugs.python.org/issu
Gregory P. Smith added the comment:
netbsd-wizs-mod.patch applied in 85587.
--
assignee: -> gregory.p.smith
nosy: +gregory.p.smith
resolution: -> accepted
stage: -> committed/rejected
status: open -> closed
___
Python tr
Gregory P. Smith added the comment:
fyi - for information on using gdb 7 with python see
http://bugs.python.org/issue8032
I'm looking at the .gdbinit improvements regardless as not everyone has gdb 7
(notably OS X).
--
resolution: out of date ->
status: closed
Gregory P. Smith added the comment:
everything except the lineno change from gdbinit_python26.patch has been
committed in r85646.
--
___
Python tracker
<http://bugs.python.org/issue3
Gregory P. Smith added the comment:
and the py_decref in there isn't quite right, fixing...
--
___
Python tracker
<http://bugs.python.org/issue3631>
___
___
Gregory P. Smith added the comment:
do we have official python docs on this that I should point to?
--
___
Python tracker
<http://bugs.python.org/issue3
Gregory P. Smith added the comment:
I updated the note in gdbinit to point to Tools/gdb/libpython.py for py3k (3.2)
and 2.7.
Thomas: I didn't do anything with your version of pystack because the existing
versions in 3.2 and 2.7 appear to work fine for me.
--
resolution: ->
Gregory P. Smith added the comment:
This is an application specific optimization that I'd like to see as its own
library or a feature added to NSS or OpenSSL. Regardless if you want this for
python, write an extension module and put it on pypy before aiming for the
stdlib. I understan
101 - 200 of 3274 matches
Mail list logo
