Georg Brandl added the comment:
I don't think there is anything to be done here. cgi.escape() is documented
properly, deprecated in Python 3.x, and changing its implementation is not
really an option now.
--
nosy: +georg.brandl
___
Python tr
Georg Brandl added the comment:
I can't really comment on the grammar changes, but the rest looks good to me.
This is not very smooth, in both versions:
-Consistency within one module or function is most important.
+Consistency within one module or function is the most important thing.
Georg Brandl added the comment:
-Consistency within one module or function is most important.
+Consistency within one module or function is the most important.
You left out "thing" from the patch; is that intended?
--
___
Python trac
Georg Brandl added the comment:
You need to call `x.__len__()` explicitly.
--
___
Python tracker
<http://bugs.python.org/issue26423>
___
___
Python-bugs-list m
Georg Brandl added the comment:
These are interpreted as comments by docutils. "make suspicious" only checks
for markup erroneously remaining in the output. "make check", which runs
tools/rstlint.py, should pick them up though.
--
Georg Brandl added the comment:
Ok, that was a bug in rstlint. Fixed now - and now I can find quite a few
instances, will fix them (most of them are in this patch).
--
___
Python tracker
<http://bugs.python.org/issue26
Georg Brandl added the comment:
Reflow is kinda bad for patch review :)
--
nosy: +georg.brandl
___
Python tracker
<http://bugs.python.org/issue26444>
___
___
Pytho
Georg Brandl added the comment:
Thanks!
--
nosy: +georg.brandl
___
Python tracker
<http://bugs.python.org/issue26442>
___
___
Python-bugs-list mailing list
Unsub
Changes by Georg Brandl :
--
status: languishing -> open
___
Python tracker
<http://bugs.python.org/issue25910>
___
___
Python-bugs-list mailing list
Unsubscrib
Georg Brandl added the comment:
Reopening, for fixing the rest of the broken ones.
--
nosy: +georg.brandl
resolution: fixed ->
status: closed -> open
___
Python tracker
<http://bugs.python.org/i
Georg Brandl added the comment:
I think rephrasing with "... can only be read" would keep the intended meaning,
but avoid the problematic "the namespaces are readonly" meaning.
--
nosy: +georg.brandl
___
Python tracker
<
Georg Brandl added the comment:
Thanks for the patch!
Most "bash" blocks should be "console" (since the prompt is shown). "pycon"
should not be needed, since it is detected automatically.
--
___
Python tracker
<
Georg Brandl added the comment:
Looks good now! I left a few comments on Rietveld.
--
___
Python tracker
<http://bugs.python.org/issue26462>
___
___
Python-bug
Georg Brandl added the comment:
I had no idea we had so many cases of wonky indentation :)
This looks good to me, apart from a few comments I left on rietveld.
--
___
Python tracker
<http://bugs.python.org/issue23
Georg Brandl added the comment:
There's two different uses here:
The one use in "truncated to Integral" means that you get an integer type out.
It is not specified to be `int` because `__trunc__` may return other types. It
could be made into a link like the other use of Integ
Georg Brandl added the comment:
Sure!
--
___
Python tracker
<http://bugs.python.org/issue26525>
___
___
Python-bugs-list mailing list
Unsubscribe:
Georg Brandl added the comment:
That sounds good to me. Maybe without so many parentheses :)
--
nosy: +georg.brandl
___
Python tracker
<http://bugs.python.org/issue26
Georg Brandl added the comment:
That is definitely supported. Whether it's actually useful to document, I'm
not sure.
"except that the original function is not temporarily bound to the name `f`"
could work.
--
___
P
Georg Brandl added the comment:
The patch is definitely an improvement.
What about a remark like ", except that `deco` is evaluated before the function
`f` is created"? That should cover the remaining difference.
--
nosy: +georg.brandl
Georg Brandl added the comment:
The last patch isn't up to date with the PEP; Serhiy's patch is the closest one.
--
___
Python tracker
<http://bugs.python.o
Georg Brandl added the comment:
(Also, toggled your "is committer" bit so you get the Python logo next to your
name.)
--
___
Python tracker
<http://bugs.python.o
Georg Brandl added the comment:
+1
--
___
Python tracker
<http://bugs.python.org/issue26736>
___
___
Python-bugs-list mailing list
Unsubscribe:
https://mail.pyth
Georg Brandl added the comment:
Now that "added" doesn't mention the second argument, the "This one *must* have
the second argument (explanation of the change)." should be changed. Otherwise
+1.
--
___
Python tracker
Georg Brandl added the comment:
Indeed, I don't think the `array` module is much used anymore.
If you're looking to serialize or deserialize fixed-size formats, you'll
probably want the `struct` module. It has both native and fixed-size modes.
For anything else involving arra
Georg Brandl added the comment:
Agreed.
--
resolution: -> not a bug
status: open -> closed
___
Python tracker
<http://bugs.python.org/issue26821>
___
___
Georg Brandl added the comment:
You didn't test your examples:
>>> [] == False
False
False is not equal to the "empty value" of any other type than other numeric
types. (This is mostly because of how booleans were originally introduced to
Python.)
"is fals
Georg Brandl added the comment:
Looks pretty rampant to me :)
Anyway, +1 for fixing, you can just do it without review if you have the time.
--
___
Python tracker
<http://bugs.python.org/issue26
Changes by Georg Brandl :
--
resolution: -> fixed
status: open -> closed
___
Python tracker
<http://bugs.python.org/issue26914>
___
___
Python-bugs-list
Georg Brandl added the comment:
LGTM.
--
nosy: +georg.brandl
___
Python tracker
<http://bugs.python.org/issue26916>
___
___
Python-bugs-list mailing list
Unsub
Georg Brandl added the comment:
Also LGTM. It's easy to spot PEPs written by French people :)
--
___
Python tracker
<http://bugs.python.org/issue26921>
___
___
Georg Brandl added the comment:
Yep, they should all be gone. I tried to make sure by running the sources
through docutils and finding nested nodes.
--
___
Python tracker
<http://bugs.python.org/issue26
Georg Brandl added the comment:
Newer Sphinx versions already redefine docutils' RFC and PEP URLs to use https.
--
___
Python tracker
<http://bugs.python.org/is
Georg Brandl added the comment:
Serhiy, feel free to go ahead and commit, I don't have my keys with me ATM.
--
___
Python tracker
<http://bugs.python.org/is
Georg Brandl added the comment:
New patch; implements the accepted version of the PEP. I added the additional
tests, thanks Stefan!
--
Added file: http://bugs.python.org/file42852/numeric_underscores_final_v5.diff
___
Python tracker
<h
Changes by Georg Brandl :
Added file: http://bugs.python.org/file42854/numeric_underscores_final_v6.diff
___
Python tracker
<http://bugs.python.org/issue26331>
___
___
Changes by Georg Brandl :
Removed file: http://bugs.python.org/file41888/numeric_underscores.diff
___
Python tracker
<http://bugs.python.org/issue26331>
___
___
Python-bug
Changes by Georg Brandl :
Removed file: http://bugs.python.org/file41894/numeric_underscores_v3_full.diff
___
Python tracker
<http://bugs.python.org/issue26331>
___
___
Changes by Georg Brandl :
Removed file: http://bugs.python.org/file42852/numeric_underscores_final_v5.diff
___
Python tracker
<http://bugs.python.org/issue26331>
___
___
Changes by Georg Brandl :
Removed file: http://bugs.python.org/file41892/numeric_underscores_v2.diff
___
Python tracker
<http://bugs.python.org/issue26331>
___
___
Pytho
Georg Brandl added the comment:
Note: the changes for format()ting ("_" as thousands separator) are still
missing. Eric, would you consider doing this part?
--
nosy: +eric.smith
___
Python tracker
<http://bugs.python.o
Georg Brandl added the comment:
Not really, no. You have to add a :ref: target label for the function. If it's
only a few instances, that should be manageable.
--
___
Python tracker
<http://bugs.python.org/is
Georg Brandl added the comment:
Thanks Eric!
Serhiy, do you want to do a review? The v6/v7 patches are based on your
"strict" patch with the constructor changes adapted from v4.
New version v7 addresses the review comments from Stefan and Martin.
--
Added file: http://bugs.
Changes by Georg Brandl :
--
nosy: +michael.foord
___
Python tracker
<http://bugs.python.org/issue27060>
___
___
Python-bugs-list mailing list
Unsubscribe:
Georg Brandl added the comment:
Thanks for the detailed review, Serhiy! Next try incoming.
--
Added file: http://bugs.python.org/file42939/numeric_underscores_final_v8.diff
___
Python tracker
<http://bugs.python.org/issue26
Georg Brandl added the comment:
I agree with Edward. The table makes no distinction between the two group of
builtins, so it is confusing why it would list them not in alphabetical order.
I wouldn't go so far as to call it "disrespectful" though :)
--
nosy
Georg Brandl added the comment:
The example is correct. "r" is a range(0, 20, 2), whose last element is 18.
--
nosy: +georg.brandl
resolution: -> not a bug
status: open -> closed
___
Python tracker
<http://bugs.py
Georg Brandl added the comment:
LGTM.
--
nosy: +georg.brandl
___
Python tracker
<http://bugs.python.org/issue23579>
___
___
Python-bugs-list mailing list
Unsub
Georg Brandl added the comment:
+1
--
nosy: +georg.brandl
___
Python tracker
<http://bugs.python.org/issue23081>
___
___
Python-bugs-list mailing list
Unsub
Georg Brandl added the comment:
And what do you suggest to do about it?
--
nosy: +georg.brandl
___
Python tracker
<http://bugs.python.org/issue23613>
___
___
Pytho
Georg Brandl added the comment:
Well, that's not useful in a generated file. I propose you exclude the doc
build tree from your search, or use a grepping tool like ag that ignores files
ignored by the vcs.
--
___
Python tracker
Georg Brandl added the comment:
> How about we respond to all Windows-specific issues with "switch to Linux"?
How about we don't respond to strawman arguments?
--
___
Python tracker
<http://bugs.
Georg Brandl added the comment:
Most important reason to close this: this is not something to change in Python,
but would have to be changed in Sphinx.
--
resolution: -> third party
status: open -> closed
___
Python tracker
<http://bugs.p
Georg Brandl added the comment:
Well, it's not a complicated script. You're welcome to try and debug it, but
if the bug is in the depths of new pydotorg, I don't know how easy it is to
find.
--
___
Python tracker
<http
Georg Brandl added the comment:
Why is this a bug?
--
___
Python tracker
<http://bugs.python.org/issue24005>
___
___
Python-bugs-list mailing list
Unsubscribe:
Georg Brandl added the comment:
Yeah, agreed.
--
___
Python tracker
<http://bugs.python.org/issue24005>
___
___
Python-bugs-list mailing list
Unsubscribe:
Georg Brandl added the comment:
Please go ahead. Thanks for taking care of this!
--
___
Python tracker
<http://bugs.python.org/issue26331>
___
___
Python-bug
Georg Brandl added the comment:
Thanks Brett!
--
___
Python tracker
<http://bugs.python.org/issue26331>
___
___
Python-bugs-list mailing list
Unsubscribe:
5201 - 5257 of 5257 matches
Mail list logo
