Georg Brandl added the comment:
Done in 8a98ee6baa1e. Thanks!
--
nosy: +georg.brandl
___
Python tracker
<http://bugs.python.org/issue17078>
___
___
Python-bug
Changes by Georg Brandl :
--
resolution: -> fixed
status: open -> closed
___
Python tracker
<http://bugs.python.org/issue17078>
___
___
Python-bugs-list
Georg Brandl added the comment:
Thanks!
--
nosy: +georg.brandl
___
Python tracker
<http://bugs.python.org/issue16155>
___
___
Python-bugs-list mailing list
Unsub
Georg Brandl added the comment:
I was about to suggest deriving your own Path class from Path and str, but got
a base class layout conflict because Path objects define lots of __slots__ :(
--
___
Python tracker
<http://bugs.python.org/issue22
Georg Brandl added the comment:
> That would be a rather horrible solution.
I know :)
--
___
Python tracker
<http://bugs.python.org/issue22570>
___
___
Python-
Georg Brandl added the comment:
Agreed, closing.
--
resolution: -> fixed
status: open -> closed
___
Python tracker
<http://bugs.python.org/issue10583>
___
__
Georg Brandl added the comment:
> I think it is unreasonable to expect authors of 3rd party modules to respect
> PEP 384 if the standard library does not.
I don't understand why you think that. PEP 384 is intended to provide the
means to maintain binary compatibility of extension
Georg Brandl added the comment:
Patch LGTM.
--
nosy: +georg.brandl
___
Python tracker
<http://bugs.python.org/issue22568>
___
___
Python-bugs-list mailin
Georg Brandl added the comment:
Looking at _csv.c, I see a few functions using PyArg_UnpackTuple. They should
be converted too, no?
--
nosy: +georg.brandl
___
Python tracker
<http://bugs.python.org/issue20
Georg Brandl added the comment:
Attached part 1 of mathmodule (17 functions).
I'm looking forward to a suggestion for handling the rest (see FUNC1/1A/2
macros :)
--
keywords: +patch
Added file: http://bugs.python.org/file33419/mathmodule_part1.
Georg Brandl added the comment:
> Wow. I never knew about PyArg_UnpackTuple. You're right, those
> should be converted too. Hooray, more entry points to convert.
> I'll write something up for the howto about UnpackTuple.
One thing to note is that (at least in math
Georg Brandl added the comment:
Another use case here is if you want to "check" the remaining call sites of
(say) PyArg_ParseTuple that aren't generated by clinic.
Call it '--remove' if you want, but the functionality should be useful.
-
Georg Brandl added the comment:
OK, here's a patch for _csv. Two problems here:
First problem is the __new__ method of the Dialect class:
* it has no docstring and no methoddef entry
* it is a class method, but the first arg is conventionally called "type"
I tried to hack
Georg Brandl added the comment:
Tried to tackle symtable -- it uses an O& converter. The clinic howto says
``'O&'````object(converter='name_of_c_function')``
but
Traceback (most recent call last):
File "Tools/clinic/clinic.py", line 2817, in
Georg Brandl added the comment:
_tracemalloc converted.
Its existing docstrings did use the
func(arg: argtype) -> rettype
convention. Is there a way in clinic to retain that?
--
Added file: http://bugs.python.org/file33423/tracemalloc_clinic.pa
Georg Brandl added the comment:
Here's _iomodule. _io.open has a whopping 100-line docstring, which is ...
unfortunate ... to have duplicated in the file :)
--
Added file: http://bugs.python.org/file33424/io_clinic.patch
___
Python tracker
Georg Brandl added the comment:
And _heapq. No problems there, except that it also used "->" return
annotations in the docstring.
--
Added file: http://bugs.python.org/file33425/heapq_clinic.patch
___
Python tracker
<http:/
Georg Brandl added the comment:
And lsprof.
--
Added file: http://bugs.python.org/file33426/lsprof_clinic.patch
___
Python tracker
<http://bugs.python.org/issue20
Georg Brandl added the comment:
I'm in favor of PyPy's behavior: null bytes anywhere in the source, even in
comments, usually mean there's something weird or fishy going on with either
the editor or (if downloaded/copied) the source of the code.
--
nosy
Georg Brandl added the comment:
Here's the signalmodule.
--
keywords: +patch
nosy: +georg.brandl
Added file: http://bugs.python.org/file33427/signal_clinic.patch
___
Python tracker
<http://bugs.python.org/is
New submission from Georg Brandl:
For METH_NOARGS, you can get rid of the separate _impl function. This makes
the generated code much smaller.
--
messages: 207943
nosy: georg.brandl
priority: normal
severity: normal
status: open
title: Argument Clinic: simplify METH_NOARGS generated
Georg Brandl added the comment:
Now without crap.
--
Added file: http://bugs.python.org/file33428/signal_clinic.patch
___
Python tracker
<http://bugs.python.org/issue20
Changes by Georg Brandl :
Removed file: http://bugs.python.org/file33427/signal_clinic.patch
___
Python tracker
<http://bugs.python.org/issue20182>
___
___
Python-bug
New submission from Georg Brandl:
Take for example select.epoll.__new__():
static PyObject *
pyepoll_new(PyTypeObject *type, PyObject *args, PyObject *kwds)
{
int flags = 0, sizehint = FD_SETSIZE - 1;
static char *kwlist[] = {"sizehint", "flags&q
Changes by Georg Brandl :
--
assignee: -> larry
nosy: +larry
___
Python tracker
<http://bugs.python.org/issue20225>
___
___
Python-bugs-list mailing list
Un
Changes by Georg Brandl :
--
assignee: -> larry
nosy: +larry
___
Python tracker
<http://bugs.python.org/issue20226>
___
___
Python-bugs-list mailing list
Un
New submission from Georg Brandl:
This is a request to be able to name C arguments differently from Python
arguments.
Two reasons:
* like for function renaming, some Python argument names are reserved in C
("default" for example, used in sys.getsizeof())
* sometimes the function u
Changes by Georg Brandl :
--
nosy: +serhiy.storchaka
___
Python tracker
<http://bugs.python.org/issue20227>
___
___
Python-bugs-list mailing list
Unsubscribe:
Georg Brandl added the comment:
OK, I see that AC automatically handles case 1, great!
Still you have to decide if you like the code churn caused by case 2.
--
___
Python tracker
<http://bugs.python.org/issue20
Georg Brandl added the comment:
One more: I can't have an argument called "args".
--
___
Python tracker
<http://bugs.python.org/issue20227>
___
___
Georg Brandl added the comment:
Here's sys.
For it to generate the correct code you need to add "args" to c_keywords in
clinic.py.
--
Added file: http://bugs.python.org/file33429/sys_clinic.patch
___
Python tracker
<http
Georg Brandl added the comment:
Sure, I wasn't concerned with compilation, only saving lines of code. But I
agree that the buffer way sounds much more promising.
Just seemed odd that METH_O was clean and METH_NOARGS less so :)
--
___
Python tr
Georg Brandl added the comment:
Nice, thanks.
--
___
Python tracker
<http://bugs.python.org/issue20226>
___
___
Python-bugs-list mailing list
Unsubscribe:
Georg Brandl added the comment:
> There are also several PyArg_ParseTuple-using functions that have the
> same kind of name mismatch, but since the names don't really mean
> anything on the Python side when they're positional-only, I don't feel
> too bad about chan
New submission from Georg Brandl:
In the presence of [ ] , clinic generates PyTuple_Size() calls.
Since argument tuples always are tuples, you can use the macro form
PyTuple_GET_SIZE() to speed it up.
--
assignee: larry
messages: 208007
nosy: georg.brandl, larry
priority: normal
New submission from Georg Brandl:
I had specified c_default=-1 (note missing quotes) somewhere, and it raises an
exception during the clinic --make run; there was no indication which file/line
this was on.
Suggested patch attached.
--
assignee: larry
files
Changes by Georg Brandl :
Removed file: http://bugs.python.org/file33425/heapq_clinic.patch
___
Python tracker
<http://bugs.python.org/issue20186>
___
___
Python-bug
Changes by Georg Brandl :
Removed file: http://bugs.python.org/file33419/mathmodule_part1.patch
___
Python tracker
<http://bugs.python.org/issue20186>
___
___
Python-bug
Changes by Georg Brandl :
Removed file: http://bugs.python.org/file33422/csv_module_clinic.patch
___
Python tracker
<http://bugs.python.org/issue20186>
___
___
Python-bug
Changes by Georg Brandl :
Removed file: http://bugs.python.org/file33423/tracemalloc_clinic.patch
___
Python tracker
<http://bugs.python.org/issue20186>
___
___
Python-bug
Changes by Georg Brandl :
Removed file: http://bugs.python.org/file33424/io_clinic.patch
___
Python tracker
<http://bugs.python.org/issue20186>
___
___
Python-bugs-list m
Changes by Georg Brandl :
Removed file: http://bugs.python.org/file33426/lsprof_clinic.patch
___
Python tracker
<http://bugs.python.org/issue20186>
___
___
Python-bug
Georg Brandl added the comment:
OK, new patches coming in.
--
___
Python tracker
<http://bugs.python.org/issue20186>
___
___
Python-bugs-list mailing list
Unsub
Changes by Georg Brandl :
Removed file: http://bugs.python.org/file33429/sys_clinic.patch
___
Python tracker
<http://bugs.python.org/issue20182>
___
___
Python-bugs-list m
Changes by Georg Brandl :
Removed file: http://bugs.python.org/file33428/signal_clinic.patch
___
Python tracker
<http://bugs.python.org/issue20182>
___
___
Python-bug
Georg Brandl added the comment:
New patch.
In selectmodule.c I haven't touched devpoll and kqueue, which I can't compile
here.
_hashopenssl does weird things with macros, I'm waiting with that.
--
Added file: http://bugs.python.org/file33441/modules_i
Georg Brandl added the comment:
Actually I put all I have in one. Rietveld doesn't care.
The mathmodule still awaits some kind of solution for the macro atrocities.
Objects will be attacked next.
--
Added file: http://bugs.python.org/file33442/modules_issue20186.
New submission from Georg Brandl:
What do you think about this patch?
--
assignee: zach.ware
components: Documentation
files: about.diff
keywords: patch
messages: 208081
nosy: georg.brandl, zach.ware
priority: normal
severity: normal
status: open
title: Doc/about: update a bit
Added
Georg Brandl added the comment:
5735 seems to be correct (see docstring of is_unspecified), although it doesn't
talk about "unspecified".
--
nosy: +georg.brandl
___
Python tracker
<http://bugs.pyt
Georg Brandl added the comment:
That's unfortunate, thanks for catching that. Of course I had markupsafe
installed for my system Python.
One more reason to switch to virtualenv at some point.
I think we can go back to the old Jinja version -- there haven't been bugs to
my kno
Georg Brandl added the comment:
Both your and Berker's (on rietveld) comments sound good.
--
___
Python tracker
<http://bugs.python.org/issue20255>
___
___
Georg Brandl added the comment:
Very nice. Go ahead and commit your version!
--
___
Python tracker
<http://bugs.python.org/issue20255>
___
___
Python-bugs-list m
Georg Brandl added the comment:
Functionality looks good. Implementation I can't say.
--
___
Python tracker
<http://bugs.python.org/issue20268>
___
___
Pytho
Georg Brandl added the comment:
Sure!
--
___
Python tracker
<http://bugs.python.org/issue20268>
___
___
Python-bugs-list mailing list
Unsubscribe:
Georg Brandl added the comment:
I'm actually more on the "fixing a bug" side. For me this is fine for 3.3.
--
___
Python tracker
<http://bugs.pyt
Georg Brandl added the comment:
I guess custom converters are the answer here.
BTW, the "args" argument already works fine since adding it to c_keywords. No
need for a complicated structure :)
--
___
Python tracker
<http://bu
Georg Brandl added the comment:
New patch addressing comments.
--
___
Python tracker
<http://bugs.python.org/issue20182>
___
___
Python-bugs-list mailin
Changes by Georg Brandl :
Added file: http://bugs.python.org/file33491/modules_issue20182_v2.patch
___
Python tracker
<http://bugs.python.org/issue20182>
___
___
Pytho
Georg Brandl added the comment:
Rietveld doesn't like your new patch?
--
___
Python tracker
<http://bugs.python.org/issue20226>
___
___
Python-bugs-list m
Georg Brandl added the comment:
Thx! (without soundcheck)
--
___
Python tracker
<http://bugs.python.org/issue20226>
___
___
Python-bugs-list mailing list
Unsub
Georg Brandl added the comment:
Hmm, the yield statement is now basically the same as any expression statement
-- just like a function call. The only reason it's a separate grammar symbol
is that otherwise yield expressions would have to be parenthesized.
Can the patch be updated to
Georg Brandl added the comment:
+1.
--
nosy: +georg.brandl
___
Python tracker
<http://bugs.python.org/issue20314>
___
___
Python-bugs-list mailing list
Unsub
Changes by Georg Brandl :
--
assignee: docs@python -> larry
nosy: +larry
___
Python tracker
<http://bugs.python.org/issue20312>
___
___
Python-bugs-list mai
Georg Brandl added the comment:
> I would suggest moving the section "4.7.2. printf-style String
> Formatting" from stdtypes to string
That's something I wanted to do for a long time. Problem is that
non-Intersphinx external links will break (and I guess quite a few peopl
Changes by Georg Brandl :
--
priority: normal -> release blocker
___
Python tracker
<http://bugs.python.org/issue19966>
___
___
Python-bugs-list mailing list
Un
Changes by Georg Brandl :
--
nosy: +larry
priority: normal -> release blocker
___
Python tracker
<http://bugs.python.org/issue20316>
___
___
Python-bugs-lis
Georg Brandl added the comment:
> When Mercurial is ported to Python 3 somewhen in the future
Good one.
--
___
Python tracker
<http://bugs.python.org/issu
Georg Brandl added the comment:
Fixed.
--
nosy: +georg.brandl
resolution: -> fixed
status: open -> closed
___
Python tracker
<http://bugs.python.org/i
Georg Brandl added the comment:
Should be figured out for 3.3.4
--
nosy: +georg.brandl
priority: normal -> release blocker
___
Python tracker
<http://bugs.python.org/issu
Georg Brandl added the comment:
OK, thanks for the quick response. Relaxing to normal priority, please close
as required.
--
priority: release blocker -> normal
___
Python tracker
<http://bugs.python.org/issu
Georg Brandl added the comment:
Thanks.
--
resolution: -> wont fix
status: open -> closed
___
Python tracker
<http://bugs.python.org/issue20324>
___
___
Georg Brandl added the comment:
The first sentence of the second new paragraph is a bit ungrammatical, right?
--
___
Python tracker
<http://bugs.python.org/issue11
Georg Brandl added the comment:
Thanks for the report.
I think it's your obligation to surround nonprinting escape sequences with \x01
and \x02, with that change it works for me.
--
nosy: +georg.brandl
resolution: -> works for me
status: open -
Georg Brandl added the comment:
I think you're using the escapes correctly: you must only escape nonprinting
characters. Try
>>> sys.ps1 = '\x01\033[32m\x02>>> \x01\033[0m\x02'
--
status: open -> closed
___
Pyt
Georg Brandl added the comment:
print() is not a good way to emit the warning; please use the warnings module.
--
nosy: +georg.brandl
___
Python tracker
<http://bugs.python.org/issue6
Georg Brandl added the comment:
Um... changing the name "socket.SocketType" from type(socket) to an enum of
SOCK_ constants is not a docs issue, but a regression.
Eli, you introduced this change (inadvertently, I think, which can easily
happen since SocketType is imported by "
Georg Brandl added the comment:
Since the test is still failing on at least 3 stable buildbots, I've reverted
the 3.3 changes for 3.3.4rc1.
--
nosy: +georg.brandl
___
Python tracker
<http://bugs.python.org/is
Georg Brandl added the comment:
Only if the older issue actually has more relevant content, which is not always
the case.
--
nosy: +georg.brandl
___
Python tracker
<http://bugs.python.org/issue20
Georg Brandl added the comment:
> Why should new enums be documented and how are they useful?
Because they are a new public class(-like object) in the module. When renaming
them to a non-public name, as you suggest, that could be left
Georg Brandl added the comment:
I'm not saying the enums are necessary (argue about that with Eli), but that if
they *are* in the module as a public attribute, they *have* to be documented,
period.
--
___
Python tracker
<http://bugs.py
Georg Brandl added the comment:
For 3.3 I prefer the "soft" patch.
--
___
Python tracker
<http://bugs.python.org/issue20283>
___
___
Python-bugs-l
Georg Brandl added the comment:
Looks good. Maybe Larry will want his line of stars though :)
--
___
Python tracker
<http://bugs.python.org/issue15759>
___
___
Georg Brandl added the comment:
"integer enumerations of " sounds weird to me.
Also, here it might be nice to link to IntEnum (use :class:`.IntEnum`).
--
___
Python tracker
<http://bugs.python.o
Georg Brandl added the comment:
OK, 3.3.4rc1 shouldn't have the problem, and neither 3.4.0b4 ff. with the
changes I just checked into hgtouch.
--
___
Python tracker
<http://bugs.python.org/is
Georg Brandl added the comment:
Yes. Probably someone wished they would implement it :)
--
___
Python tracker
<http://bugs.python.org/issue20407>
___
___
Pytho
Georg Brandl added the comment:
I see, there are two "def nsmallest" in heapq.py. Tricky!
--
___
Python tracker
<http://bugs.python.org/issue20407>
___
___
Georg Brandl added the comment:
Well, IntEnum is nowhere documented as a class. IOW,
.. class:: IntEnum
is missing if you want these references to work.
--
___
Python tracker
<http://bugs.python.org/issue20
Georg Brandl added the comment:
IntEnum is not a class in the enum module either, as far as the docs are
concerned ;)
Otherwise :class:`enum.IntEnum` or :class:`.IntEnum` would work, no matter the
source and target documents.
--
___
Python tracker
Georg Brandl added the comment:
Since this is a pretty big code churn, I'd prefer B) for 3.3.4. (3.3.5 will be
soon anyway.)
--
___
Python tracker
<http://bugs.python.org/is
Georg Brandl added the comment:
Matthias and I agreed this isn't necessary since on the relevant distribution
it's already documented.
--
resolution: -> works for me
status: open -> closed
___
Python tracker
<http://bugs.py
Georg Brandl added the comment:
I agree.
--
___
Python tracker
<http://bugs.python.org/issue20517>
___
___
Python-bugs-list mailing list
Unsubscribe:
Georg Brandl added the comment:
-1 as well.
Yury: it's a micro-optimization, the slow builtin lookup becomes a fast local
lookup.
--
nosy: +georg.brandl
___
Python tracker
<http://bugs.python.org/is
Georg Brandl added the comment:
Paul, could you confirm that backing out the 2807a5f011e4 changeset on the 3.3
branch fixes the problem?
--
___
Python tracker
<http://bugs.python.org/issue20
Georg Brandl added the comment:
Yeah, just tried the backout, it doesn't apply cleanly anymore --
Modules/zipimport.c has apparently changed some more afterwards.
I think using the parent changeset is the best thing to do at the moment, until
Greg comes up with a patch.
--
ass
Georg Brandl added the comment:
Which revision is your tip?
In the latest revision, the documentation should refuse being built with 1.0.7.
--
___
Python tracker
<http://bugs.python.org/issue20
Georg Brandl added the comment:
OK. What do you think about rolling a 3.3.5 rc1 release next weekend, with the
final a week later?
--
___
Python tracker
<http://bugs.python.org/issue20
Georg Brandl added the comment:
Thanks for the feedback. This was not the latest tip anyway: in the current tip
the checked-out toolchain is gone and your system Sphinx is used.
--
resolution: -> out of date
status: open -> closed
___
New submission from Georg Brandl:
3.4 cherry-pick: eef7899ea7ab use system doc toolchain instead of checking out
of svn
--
assignee: larry
messages: 211423
nosy: georg.brandl, larry
priority: release blocker
severity: normal
status: open
title: 3.4 cherry-pick: eef7899ea7ab use system
Georg Brandl added the comment:
Well, I thought the installer script can surely be fixed in time. If not, I
agree that this shouldn't be picked yet.
--
___
Python tracker
<http://bugs.python.org/is
Georg Brandl added the comment:
The change was requested by doko for Debian/Ubuntu. As for changing it after
rc1, I agree it is unfortunate. But it doesn't affect the distributed content,
only how the release is built, which I think is exactly what *can* go in the rc
phase.
The P
3701 - 3800 of 5257 matches
Mail list logo
