Georg Brandl added the comment:
I say "fixed": there was a bug (undocumented, but correct behavior) and that
was fixed.
--
resolution: rejected -> fixed
status: open -> closed
___
Python tracker
<http://bugs.py
Georg Brandl added the comment:
I had a look and can't see an example in the "Classes" doc where self might not
be defined. Please reopen with a concrete pointer if you think otherwise.
--
nosy: +georg.brandl
resolution: -> invalid
stat
Georg Brandl added the comment:
Adding a redirect should be easy, yes.
--
___
Python tracker
<http://bugs.python.org/issue16484>
___
___
Python-bugs-list mailin
Georg Brandl added the comment:
Redirects are no problem in principle, but it should not get out of hand. A
simple "this was here but now isn't" page might be better.
--
___
Python tracker
<http://bugs.pyt
Georg Brandl added the comment:
LGTM, except for:
diff -r 907d71668d3c Python/pythonrun.c
--- a/Python/pythonrun.cSun Dec 16 21:10:35 2012 +0100
+++ b/Python/pythonrun.cTue Dec 18 19:35:27 2012 +0200
@@ -2518,7 +2518,7 @@
PyOS_CheckStack(void)
{
__try {
-/* alloca
Georg Brandl added the comment:
I don't think this is the only use of this particular idiom; I recall it is
used every time we "amend" a function with an _Ex version.
Why was this change necessary?
--
nosy: +georg.brandl, pitrou
___
Georg Brandl added the comment:
BTW it would be good if you could have at least one other developer look at
issues like this and get a "LGTM" vote before committing all by yourself.
--
___
Python tracker
<http://bugs.python.o
Georg Brandl added the comment:
Can you give examples? I'm unable to guess what exactly you are reporting from
quick experiments.
--
nosy: +georg.brandl
___
Python tracker
<http://bugs.python.org/is
Georg Brandl added the comment:
Ah. I was thinking of things like ``int('1.2', 10)``, not the base itself
being a float.
In this case, looks like a bug to me.
--
___
Python tracker
<http://bugs.python.o
Georg Brandl added the comment:
There is no silent acceptance. No comment means that nobody reviewed it, which
is no surprise given the number of open issues :)
--
___
Python tracker
<http://bugs.python.org/issue15
Georg Brandl added the comment:
So given #1 and #3, I would recommend reverting the part of the patch that
removes the macro. Changing caller sites in CPython sources is fine.
--
___
Python tracker
<http://bugs.python.org/issue15
Georg Brandl added the comment:
The "self.fout.close()" is not needed here I think.
Another thing the test should test is that the file was actually closed on
exception.
Otherwise, LGTM.
--
nosy: +georg.brandl
___
Python trac
Georg Brandl added the comment:
Looks good to me, except:
the patch contains unrelated whitespace changes. Please don't commit them
along the fix. If you think they are really necessary, they should go in a
separate commit.
--
nosy: +georg.b
Georg Brandl added the comment:
I'd like Antoine to have a look at all that io stuff. It looks quite bloated.
In your except clause, you're not calling self._close.
--
nosy: +pitrou
___
Python tracker
<http://bugs.python.org
Georg Brandl added the comment:
The patch replaces a
Py_CLEAR(tdo->nextlink)
with a construct that does, basically, something like this several times:
Py_DECREF(tdo->nextlink)
tdo->nextlink
which is what leads to the issues that Py_CLEAR is supposed to prevent.
Therefore I t
Georg Brandl added the comment:
And please don't commit cosmetic/"cleanup" changes to bugfix branches in the
future.
--
nosy: +georg.brandl
___
Python tracker
<http://bugs.pyt
Georg Brandl added the comment:
Like Raymond said in the other issue: it's not going to be a problem once
committed, but please be mindful of what you commit to bugfix branches in the
future.
--
___
Python tracker
<http://bugs.py
Georg Brandl added the comment:
That makes it more of a fix, true.
--
___
Python tracker
<http://bugs.python.org/issue16793>
___
___
Python-bugs-list mailin
Georg Brandl added the comment:
In this case it's more of a docutils version problem, I would guess. Tshepang,
can you find out your docutils version?
But "proper" use of the note directive is with an empty line, so we should fix
these instances anyway.
--
nosy
Georg Brandl added the comment:
Fine with me.
--
___
Python tracker
<http://bugs.python.org/issue16813>
___
___
Python-bugs-list mailing list
Unsubscribe:
Georg Brandl added the comment:
Agree with David.
--
nosy: +georg.brandl
status: open -> closed
___
Python tracker
<http://bugs.python.org/issue16814>
___
_
Georg Brandl added the comment:
LGTM.
--
___
Python tracker
<http://bugs.python.org/issue16805>
___
___
Python-bugs-list mailing list
Unsubscribe:
Georg Brandl added the comment:
A simple, minimal-invasive solution would be to allow a signature for
documentation purposes as the first line of the docstrings.
pydoc could recognize this (if docstring.startswith(func.__name__ + '(') or
something like that), and display the given
Georg Brandl added the comment:
This is not a `make' tutorial...
--
___
Python tracker
<http://bugs.python.org/issue16814>
___
___
Python-bugs-list m
Georg Brandl added the comment:
The reference to faulthandler is a good addition. The other added sentence
reads repetitive and can be left out. Proposal:
There are, however, enough ways to crash Python with :mod:`ctypes`, so you
should be careful anyway. The :mod:`faulthandler` module can
Georg Brandl added the comment:
I think you will, Matthew being MRAB on the mailing lists :)
--
nosy: +georg.brandl
___
Python tracker
<http://bugs.python.org/issue16
Changes by Georg Brandl :
--
nosy: +lregebro
___
Python tracker
<http://bugs.python.org/issue16818>
___
___
Python-bugs-list mailing list
Unsubscribe:
Georg Brandl added the comment:
Well, I'm not -1 about the patch. But there is something to be said for
conciseness, and sprinkling the docs with endless alternate routes will not
make it easier to read quickly and get the information you
Georg Brandl added the comment:
LGTM.
--
___
Python tracker
<http://bugs.python.org/issue13951>
___
___
Python-bugs-list mailing list
Unsubscribe:
Georg Brandl added the comment:
> 20+ years of Python success suggest this isn't a problem that needs solving.
That reasoning could be applied to almost all open tracker issues.
> Likewise, Linux itself doesn't preserve the original form of a chmod call.
Where would/could it
Georg Brandl added the comment:
FTR, with C's atexit(3), the handlers are not called either on exec().
--
nosy: +georg.brandl
___
Python tracker
<http://bugs.python.org/is
Georg Brandl added the comment:
It's still a valid bug.
--
nosy: +georg.brandl
resolution: fixed ->
status: closed -> open
___
Python tracker
<http://bugs.python
Georg Brandl added the comment:
David, the "issue" is that Python only allows relative imports within packages.
The OP wants to have a.py and b.py in the same directory and then be able to
said "from . import b" in the a module.
This is a design decision and will not
Georg Brandl added the comment:
Can you point exactly where the "odd behavior" is? Note that "~" is a normal
component for UNIX file/path names, and in such it has no special meaning (as
opposed to "/").
This is why it gets no special handling by any Pyth
Changes by Georg Brandl :
--
nosy: +georg.brandl
___
Python tracker
<http://bugs.python.org/issue9685>
___
___
Python-bugs-list mailing list
Unsubscribe:
Georg Brandl added the comment:
Both are a kind of command-line expansion, see for example bash(1).
Listed there are "brace expansion, tilde expansion, parameter and variable
expansion, command substitution, arithmetic expansion, word splitting, and
pathname expansion". Python do
Georg Brandl added the comment:
LGTM.
--
___
Python tracker
<http://bugs.python.org/issue16877>
___
___
Python-bugs-list mailing list
Unsubscribe:
Georg Brandl added the comment:
Still, actual benefits in some kind of benchmark will be needed to show that
this is not a premature optimization.
--
___
Python tracker
<http://bugs.python.org/issue9
Georg Brandl added the comment:
The "performance" you're measuring here is mostly startup, i.e. loading all
necessary modules. On Python 3, there is more to load, e.g. the filesystem
encoding, therefore startup takes a little longer.
There are efforts to improve startup time,
Georg Brandl added the comment:
I'd like to see a review first. I don't have time to do it myself right now
though.
--
nosy: +georg.brandl
___
Python tracker
<http://bugs.python.
Georg Brandl added the comment:
No need to hurry; no one apparently needs it anyway, and if there is a change
let Martin review it before commit.
--
___
Python tracker
<http://bugs.python.org/issue15
Georg Brandl added the comment:
This is a known issue in older Sphinx versions. I've updated the version used
to build the devguide now; this should fix it.
--
resolution: -> fixed
status: open -> closed
___
Python tracker
<http://b
Georg Brandl added the comment:
This is not a bug: urlparse is there to parse URLs, and URLs start with an URL
scheme such as "http:".
There is no way for a generic URL parser to know that "python.org:80/" is
supposed to be "http://python.org:80/";.
--
Georg Brandl added the comment:
Note that Sphinx' "make text" output already should be suitable. We already
update the pydoc topics with that on every release, so we could just as well do
the same for the IDLE doc. No need for another separate script.
--
nosy
Georg Brandl added the comment:
Hmm, you're right. The behavior has been like this at least since Python 2.5:
Python 2.5.4 (r254:67916, Dec 16 2012, 20:33:12)
[GCC 4.6.3] on linux3
Type "help", "copyright", "credits" or "license" for more i
Georg Brandl added the comment:
Thanks for the report. This statement was actually false for almost all
sequence types, except for those whose slicing returns a list.
--
nosy: +georg.brandl
___
Python tracker
<http://bugs.python.org/issue16
Georg Brandl added the comment:
If I understand your issue correctly, you are expecting all three exception
handlers to be called in innermost-to-outermost order. However, exceptions are
not reraised automatically after "except" blocks; you can insert a bare "raise"
stat
Georg Brandl added the comment:
This kind of change is very similar to other "cleanup" changes, so the
classification of "not a bug fix" seems valid.
--
___
Python tracker
<http://bu
Changes by Georg Brandl :
--
nosy: +pitrou
___
Python tracker
<http://bugs.python.org/issue16937>
___
___
Python-bugs-list mailing list
Unsubscribe:
Georg Brandl added the comment:
It means not write
a = "abc"
as
a = """abc
"""
with the four spaces trailing at the end of the line. I don't think there is a
more concise way of putting it in the PEP.
--
nosy: +georg.bra
Georg Brandl added the comment:
Might make sense to put this in atexit.atfork() to avoid small-module inflation?
--
nosy: +georg.brandl
___
Python tracker
<http://bugs.python.org/issue16
Georg Brandl added the comment:
> I take it this would mean generating help.txt and then checking it in?
> Otherwise, users who built their own Python would likely run into issues with
> IDLE not finding its help file, or would be required to have sphinx available.
Yes, it will be c
Georg Brandl added the comment:
The unified diff is not very helpful; I think somebody has to put the files
side by side and merge.
The pydoc topics are built with a custom Sphinx builder implemented in
tools/sphinxext/pyspecific.py -- but if we just want the vanilla text builder
output it
Georg Brandl added the comment:
To make it actually work, replace "library/idle" by "library/idle.rst".
--
___
Python tracker
<http://bug
Georg Brandl added the comment:
Looks like a bug to me, although it isn't likely to cause great harm.
--
nosy: +georg.brandl
title: Keyword keyword only default parameters are evaluated before po ->
Keyword only argument default values are evaluated before other
Georg Brandl added the comment:
I did test the Makefile change, so this should be good to go. I'll upate PEP
101 once it's in.
--
___
Python tracker
<http://bugs.python.o
Georg Brandl added the comment:
Serhiy: not sure why all those people belong in the nosy list.
--
___
Python tracker
<http://bugs.python.org/issue17049>
___
___
Georg Brandl added the comment:
The patch introduced a Cyrillic "C" into the docs, see below. This makes the
LaTeX build fail.
+ ``foo/bar`` on Unix, and ``С:\foo\bar`` becomes ``foo\bar`` on Windows.
^^
--
nosy: +georg.brandl
stat
Georg Brandl added the comment:
Then I guess there is no reason not to put it in 3.2.4.
--
___
Python tracker
<http://bugs.python.org/issue14340>
___
___
Pytho
Georg Brandl added the comment:
Then I guess there is no reason not to put it in 3.2.4.
--
___
Python tracker
<http://bugs.python.org/issue14340>
___
___
Pytho
Changes by Georg Brandl :
--
nosy: +larry
priority: normal -> release blocker
___
Python tracker
<http://bugs.python.org/issue17106>
___
___
Python-bugs-lis
Georg Brandl added the comment:
Blocker for 3.2.4.
--
___
Python tracker
<http://bugs.python.org/issue17106>
___
___
Python-bugs-list mailing list
Unsubscribe:
Georg Brandl added the comment:
Greg, if you are fine please apply to 3.2 or indicate if it is enough to apply
the same patch as on 3.3/default.
--
___
Python tracker
<http://bugs.python.org/issue14
Georg Brandl added the comment:
While it's nice to look at a graphical representation, clearly there is no deep
interest (and PEP 101 has so many little steps that you couldn't possibly fit
them all into a graph, so you have to consult the text anyway). I see no
reason to keep
Georg Brandl added the comment:
Antoine is right. It's probably ok to remove that suggestion completely.
--
nosy: +georg.brandl
___
Python tracker
<http://bugs.python.org/is
Georg Brandl added the comment:
The SO post is scary. Maybe a non-normalized (smallest representation) PEP393
string is escaping into the wild?
--
nosy: +georg.brandl
___
Python tracker
<http://bugs.python.org/issue17
Changes by Georg Brandl :
--
nosy: +loewis
___
Python tracker
<http://bugs.python.org/issue17137>
___
___
Python-bugs-list mailing list
Unsubscribe:
Changes by Georg Brandl :
--
priority: normal -> high
___
Python tracker
<http://bugs.python.org/issue17137>
___
___
Python-bugs-list mailing list
Unsubscri
Georg Brandl added the comment:
For example, any function where an argument has a "sentinel" object as the
default value, such as socket.create_connection().
--
___
Python tracker
<http://bugs.python.o
Georg Brandl added the comment:
It can be changed up to beta1, with good reasons of course. Many PEPs are
actually out of date with respect to the actual implementation in minor points.
--
nosy: +georg.brandl
___
Python tracker
<h
Georg Brandl added the comment:
That said, for a PEP that has seen so much discussion before being accepted,
the agreed-on API should not be changed lightly.
--
___
Python tracker
<http://bugs.python.org/issue18
Georg Brandl added the comment:
Should be fixed now in 3.2 too.
--
status: open -> closed
___
Python tracker
<http://bugs.python.org/issue16248>
___
___
Python-
Georg Brandl added the comment:
Christian, is the -py32 patch still up to date?
--
nosy: +larry
priority: critical -> release blocker
___
Python tracker
<http://bugs.python.org/issu
Georg Brandl added the comment:
I would propose a leading underscore for these methods; they should make it
clear to the user that the parameter is meant to be "private".
With this line in the docstring, I would wonder "Why is the argument there in
the first place?!"
Georg Brandl added the comment:
I wouldn't add info about the optimization in the docstring.
In _randbelow() I think you missed a call to int().
For _randbelow(), all arguments after "int" are non-public ones.
(_randbelow as a private function wouldn't necessarily need t
Changes by Georg Brandl :
--
Removed message: http://bugs.python.org/msg197774
___
Python tracker
<http://bugs.python.org/issue19024>
___
___
Python-bugs-list m
Georg Brandl added the comment:
I would welcome a "versionchanged" block in the docs addition.
There seems to be a stray space in the string in the last line here:
+try:
+user = pwd.getpwuid(os.g
Georg Brandl added the comment:
Please do not change the ordering of Å -- it is correct after Z, at least in
Swedish, Danish and Norwegian.
If you want to sort German umlauts correctly, in lists of names they are
treated as [aou]+e, so "Löwis" goes before "Lowe".
As for
Georg Brandl added the comment:
[MAL]
> * Commit messages only provide a very terse hint at what a
> particular patch set was meant for. The target audience
> is other core developers.
>
> * News entries explain these patches (there may be more than one
> for a particula
Georg Brandl added the comment:
Senthil: your 3.3->default merge removed the Availability from fpathconf().
--
nosy: +georg.brandl
status: closed -> open
___
Python tracker
<http://bugs.python.org/i
Georg Brandl added the comment:
Note that I'm strongly against this name of the getitem() method.
--
nosy: +georg.brandl
___
Python tracker
<http://bugs.python.org/is
Georg Brandl added the comment:
Thanks for the patch! The amount of unrelated changes (mostly removing ">>>"
empty prompts) makes this a bit hard to review.
Also, I don't think it is too important to link to the "ctypes" module from
within the docs of
Georg Brandl added the comment:
> Right. That's why it should not accept input that can only be
> unordered (including dict and **kwargs) - this is what I mean by
> strict mode.
That's not even true: the empty and the one-element dict are always ordered.
--
Georg Brandl added the comment:
Not really. Would "entry" be acceptable instead of "item"?
--
___
Python tracker
<http://bugs.python.org/issue18986>
___
_
Georg Brandl added the comment:
Hmm, I didn't consider popitem(). Maybe I'm too paranoid about users confusing
__getitem__() and getitem() after all :)
--
___
Python tracker
<http://bugs.python.o
Georg Brandl added the comment:
Well, it is customary for the patch submitter to make the diff. This makes it
much easier for us to review.
Closing for now; please note our suggestions and reopen/resubmit as a diff file
if you feel like it.
--
status: open -> clo
Georg Brandl added the comment:
AFAIR renaming the lowercased versions might lead to trouble with hg on
case-insensitive file systems. Anyone know if that's still the case?
Otherwise README.txt is fine. Although, Windows users will then complain about
the Unix-style line endings becaus
Georg Brandl added the comment:
Searching in headings is implemented in Sphinx 1.2 (soon to be released).
We'll switch to that version at least for 3.3 and 3.4 when it's out, so you
will get the result for the heading there.
The PyOS_snprintf will still be the first result, since
Georg Brandl added the comment:
Searching in headings is implemented in Sphinx 1.2 (soon to be released).
We'll switch to that version at least for 3.3 and 3.4 when it's out, so you
will get the result for the heading there.
The PyOS_snprintf will still be the first result, since
Georg Brandl added the comment:
Let's try a plain rejection first.
--
resolution: -> rejected
status: open -> closed
___
Python tracker
<http://bugs.python.
New submission from Georg Brandl:
As discussed on python-dev.
--
assignee: docs@python
components: Documentation
files: license_fixup_33.patch
keywords: patch
messages: 198036
nosy: docs@python, georg.brandl
priority: normal
severity: normal
status: open
title: Remove detailed listing
Changes by Georg Brandl :
Added file: http://bugs.python.org/file31811/license_fixup_27.patch
___
Python tracker
<http://bugs.python.org/issue19043>
___
___
Python-bug
Georg Brandl added the comment:
Using the "warning" directive can be backported from the 3.x docs.
For 3.x, it's already prominent enough. Your "screen border" is not everyone's
screen border.
--
nosy: +georg.brandl
versions: -Python 2.6, Python 3.1,
Georg Brandl added the comment:
Oh, please. It's big and red and directly below the open() description, how
could you miss it?
--
___
Python tracker
<http://bugs.python.org/is
Georg Brandl added the comment:
> I believe that it is pretty easy with mobile browser due to screen
> constraints. Can you test this on your mobile devices?
Sorry, but we don't adapt the docs *content* to any specific device. You
should never only read just a screenful in any cas
Georg Brandl added the comment:
> me[1]> open() function description is a wrong place for warning that is
related to a whole module
> you[2]> common, it is visible, that's the point anyway
> me[3]> it is not visible on mobile
> you[4]> we do not support mobile
Changes by Georg Brandl :
--
resolution: -> fixed
status: open -> closed
___
Python tracker
<http://bugs.python.org/issue19110>
___
___
Python-bugs-list
Changes by Georg Brandl :
--
nosy: +rhettinger
___
Python tracker
<http://bugs.python.org/issue19121>
___
___
Python-bugs-list mailing list
Unsubscribe:
Georg Brandl added the comment:
Patch LGTM.
--
nosy: +georg.brandl
___
Python tracker
<http://bugs.python.org/issue19148>
___
___
Python-bugs-list mailin
Georg Brandl added the comment:
Yeah, the first message should probably say "one of the hex, bytes, bytes_le,
fields, or int arguments must be given"
--
nosy: +georg.brandl
___
Python tracker
<http://bugs.python.o
3301 - 3400 of 5257 matches
Mail list logo