[issue6517] Emphasising in the docs configparser.SafeConfigParser over ConfigParser

2010-08-03 Thread Fred L. Drake, Jr.
Fred L. Drake, Jr. added the comment: 2010/8/3 Łukasz Langa : > 1) In 3.2 we add an alias: > > InterpolatingConfigParser = SafeConfigParser I'd rather see the class renamed and SafeConfigParser made the alias in 3.2. Otherwise, +1 for this plan (msg 112589), as there's

[issue6517] Emphasising in the docs configparser.SafeConfigParser over ConfigParser

2010-08-03 Thread Fred L. Drake, Jr.
Fred L. Drake, Jr. added the comment: Making ConfigParser an alias for SafeConfigParser creates a silent behavioral change. An application developer may not realize that users rely on the "full" ConfigParser anti-glory and end up breaking their configurations without so much as p

[issue9061] cgi.escape Can Lead To XSS Vulnerabilities

2010-08-03 Thread Fred L. Drake, Jr.
Fred L. Drake, Jr. added the comment: Such constructs are notoriously tedious to grep for; patches are welcome. -- nosy: +fdrake ___ Python tracker <http://bugs.python.org/issue9

[issue6517] Emphasising in the docs configparser.SafeConfigParser over ConfigParser

2010-08-03 Thread Fred L. Drake, Jr.
Fred L. Drake, Jr. added the comment: It doesn't make sense to make any of these changes to Python 2; this really should have been separate from the documentation issue. That's probably understood by everyone, but explicit is better. Merging implementations ---

[issue9421] configparser.ConfigParser's getint, getboolean and getfloat don't accept `vars`

2010-08-03 Thread Fred L. Drake, Jr.
Fred L. Drake, Jr. added the comment: +1 to making support for `vars` consistent across the parser classes. This needs to include documentation (stand-alone + docstrings) that actually make sense; the current docs require reading the code to understand what is going on. (Generally, if you

[issue9452] configparser support for reading from strings and dictionaries

2010-08-03 Thread Fred L. Drake, Jr.
Fred L. Drake, Jr. added the comment: I agree that the existing defaults={...} should never have been added to the stdlib. It made sense in the originating application, but should have been implemented differently to keep application-specific behavior out of what eventually was added to the

[issue9452] configparser support for reading from strings and dictionaries

2010-08-05 Thread Fred L. Drake, Jr.
Fred L. Drake, Jr. added the comment: (Apparently I don't have the right permissions on Rietveld.) - Docstrings should be written in the standard PEP-8 way (single line summary + additional explanation as needed following a blank line). - read_sting and read_dict should still t

[issue9452] configparser support for reading from strings and dictionaries

2010-08-05 Thread Fred L. Drake, Jr.
Fred L. Drake, Jr. added the comment: - Summmary lines in docstrings are one line, as Éric points out. They're summaries, so need not be complete. Use elaboration text as needed, and omit anything that's not relevant in context. An alternate wording to consider: "&qu

[issue9292] Dead code in Modules/pyexpat.c

2010-08-08 Thread Fred L. Drake, Jr.
Fred L. Drake, Jr. added the comment: This patch looks good to me. -- ___ Python tracker <http://bugs.python.org/issue9292> ___ ___ Python-bugs-list mailin

[issue9452] configparser support for reading from strings and dictionaries

2010-08-09 Thread Fred L. Drake, Jr.
Fred L. Drake, Jr. added the comment: Patch committed on py3k branch in r83889. -- resolution: -> accepted status: open -> closed ___ Python tracker <http://bugs.python.org/

[issue9421] configparser.ConfigParser's getint, getboolean and getfloat don't accept `vars`

2010-08-09 Thread Fred L. Drake, Jr.
Fred L. Drake, Jr. added the comment: The getters should all accept a `default` argument that's used when no value is found in the configuration. If the default is given, that should be returned (without conversion), instead of raising an exception. This can be included in the same

[issue9551] ConfigParser.SafeConfigParser.set fails when no value provided

2010-08-09 Thread Fred L. Drake, Jr.
Fred L. Drake, Jr. added the comment: Patch still requires a test. Sorry if I was unclear in IRC. -- ___ Python tracker <http://bugs.python.org/issue9

[issue9421] configparser.ConfigParser's getint, getboolean and getfloat don't accept `vars`

2010-08-10 Thread Fred L. Drake, Jr.
Fred L. Drake, Jr. added the comment: - Using _UNSET & similar in the docs is not good; there used to be a way to note a parameter as optional. Not sure whether there is any more. - Docs for methods which take vars/default should include a note indicating where to find the explana

[issue9551] ConfigParser.SafeConfigParser.set fails when no value provided

2010-08-10 Thread Fred L. Drake, Jr.
Fred L. Drake, Jr. added the comment: Committed on the release27-maint branch as 83931. -- keywords: -needs review resolution: -> accepted status: open -> closed ___ Python tracker <http://bugs.python.org/

[issue9421] configparser.ConfigParser's getint, getboolean and getfloat don't accept `vars`

2010-08-10 Thread Fred L. Drake, Jr.
Fred L. Drake, Jr. added the comment: Even I think the leading underscore screams "don't use this from outside, doofus!" -- ___ Python tracker <http://bugs.py

[issue29601] Need reST markup for enum types

2017-02-19 Thread Fred L. Drake, Jr.
Fred L. Drake, Jr. added the comment: Is there some special treatment you think should be given to specific enum values as well? -- nosy: +fdrake ___ Python tracker <http://bugs.python.org/issue29

[issue9285] Add a profile decorator to profile and cProfile

2017-02-25 Thread Fred L. Drake, Jr.
Changes by Fred L. Drake, Jr. : -- nosy: -fdrake ___ Python tracker <http://bugs.python.org/issue9285> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue27879] add os.syncfs()

2017-03-01 Thread Fred L. Drake, Jr.
Changes by Fred L. Drake, Jr. : -- nosy: +fdrake ___ Python tracker <http://bugs.python.org/issue27879> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue26526] In parsermodule.c, replace over 2KLOC of hand-crafted validation code, with a DFA

2016-05-28 Thread Fred L. Drake, Jr.
Fred L. Drake, Jr. added the comment: I've read through this, but haven't applied the patch & run tests (that's what buildbots are for). No objections. -- ___ Python tracker <http://bugs

[issue23116] Python Tutorial 4.7.1: Improve ask_ok() to cover more input values

2016-06-01 Thread Fred L. Drake, Jr.
Fred L. Drake, Jr. added the comment: +1 for ValueError instead of OSError. -- nosy: +fdrake ___ Python tracker <http://bugs.python.org/issue23116> ___ ___ Pytho

[issue9755] Fix refcounting details in Py3k C API documentation

2016-06-01 Thread Fred L. Drake, Jr.
Fred L. Drake, Jr. added the comment: As mentioned in issue 18085, the original file was not generated, but crafted by hand (though I don't think that really matters). -- ___ Python tracker <http://bugs.python.org/i

[issue18085] Verifying refcounts.dat

2016-06-01 Thread Fred L. Drake, Jr.
Fred L. Drake, Jr. added the comment: I don't think this is a duplicate of issue 9755; this relates to verifying the data, and that revolves around possible process improvements. Whether this issue should be closed is tied to whether the file has been verified, as the issue title suggest

[issue27495] Pretty printing sorting for set and frozenset instances

2016-07-12 Thread Fred L. Drake, Jr.
Fred L. Drake, Jr. added the comment: +1 It could reasonably be argued that not sorting is a bug for already-released 3.x versions. -- ___ Python tracker <http://bugs.python.org/issue27

[issue2175] Expat sax parser silently ignores the InputSource protocol

2013-02-13 Thread Fred L. Drake, Jr.
Changes by Fred L. Drake, Jr. : -- nosy: +fdrake ___ Python tracker <http://bugs.python.org/issue2175> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue17571] broken links on Lib/datetime.py docstring

2013-03-29 Thread Fred L. Drake, Jr.
Fred L. Drake, Jr. added the comment: Let's just update the docstring: """Concrete date/time and related types. See also http://dir.yahoo.com/Reference/calendars/ For a primer on DST, including many current DST rules, see http://webexhibits.org/daylightsaving/ Sources f

[issue17868] pprint long non-printable bytes as hexdump

2013-04-29 Thread Fred L. Drake, Jr.
Changes by Fred L. Drake, Jr. : -- nosy: -fdrake ___ Python tracker <http://bugs.python.org/issue17868> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue17950] Dynamic classes contain non-breakable reference cycles

2013-05-13 Thread Fred L. Drake, Jr.
Changes by Fred L. Drake, Jr. : -- nosy: +fdrake ___ Python tracker <http://bugs.python.org/issue17950> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue17987] test.support.captured_stderr, captured_stdin not documented

2013-05-15 Thread Fred L. Drake, Jr.
New submission from Fred L. Drake, Jr.: The captured_stderr and captured_stdin context managers aren't documented, and should be. -- assignee: docs@python components: Documentation keywords: easy messages: 189311 nosy: docs@python, fdrake priority: normal severity: normal stage:

[issue17995] report,中 高 层 管 理 技 能158766

2013-05-16 Thread Fred L. Drake, Jr.
Changes by Fred L. Drake, Jr. : -- resolution: -> rejected status: open -> closed ___ Python tracker <http://bugs.python.org/issue17995> ___ ___ Pyth

[issue22721] pprint output for sets and dicts is not stable

2014-10-24 Thread Fred L. Drake, Jr.
Fred L. Drake, Jr. added the comment: Stability in output order from pprint is very useful in doctests (yes, some people write documentation that they test). I think fixing any output stability issues would be very worthwhile. -- ___ Python tracker

[issue22721] pprint output for sets and dicts is not stable

2014-10-28 Thread Fred L. Drake, Jr.
Fred L. Drake, Jr. added the comment: Sorting by the repr sounds good, but if some dict keys or set members are strings containing single-quotes, the primary sort will be on the type of quote used for the repr, which would be surprising and significantly less useful

[issue2292] Missing *-unpacking generalizations

2015-01-20 Thread Fred L. Drake, Jr.
Changes by Fred L. Drake, Jr. : -- nosy: -fdrake ___ Python tracker <http://bugs.python.org/issue2292> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue7434] general pprint rewrite

2015-02-03 Thread Fred L. Drake, Jr.
Changes by Fred L. Drake, Jr. : -- nosy: -fdrake ___ Python tracker <http://bugs.python.org/issue7434> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue26124] shlex.quote and pipes.quote do not quote shell keywords

2016-01-15 Thread Fred L. Drake, Jr.
Fred L. Drake, Jr. added the comment: It's not at all obvious that the intention is to ensure such an argument should be treated only as a command external to the shell. If an application really wants to ensure the command is not handled as a shell built-in, it should use shell=False. M

[issue26094] ConfigParser.get() doc to be updated according to the configparser.py header doc

2016-01-15 Thread Fred L. Drake, Jr.
Changes by Fred L. Drake, Jr. : -- nosy: +fdrake ___ Python tracker <http://bugs.python.org/issue26094> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue26366] Use “.. versionadded” over “.. versionchanged” where appropriate

2016-02-19 Thread Fred L. Drake, Jr.
Fred L. Drake, Jr. added the comment: On Fri, Feb 19, 2016 at 10:02 AM, Tony R. wrote: > Holy crap! You all used to use LaTeX?! :D Python's documentation has a long & colorful history. :-) > Well then, if this is the sort of place where the status quo is sacred, then >

[issue26366] Use “.. versionadded” over “.. versionchanged” where appropriate

2016-02-19 Thread Fred L. Drake, Jr.
Fred L. Drake, Jr. added the comment: Another reason to value the status-quo in this case is that this isn't just a matter for the Python documentation; it's about the recommended usage for the markup, which is used by many other packages. Questions that should be discussed include:

[issue26366] Use “.. versionadded” over “.. versionchanged” where appropriate

2016-02-22 Thread Fred L. Drake, Jr.
Fred L. Drake, Jr. added the comment: If no one is planning to propose specific new markup for more fine-grained version annotations, this issue can be closed. -- ___ Python tracker <http://bugs.python.org/issue26

[issue26366] Use “.. versionadded” over “.. versionchanged” where appropriate

2016-02-22 Thread Fred L. Drake, Jr.
Fred L. Drake, Jr. added the comment: For anyone following along only via the tracker, it's worth noting that proposals for new markup are welcome on the docs mailing list. More information is available at: https://mail.python.org/mailman/listinfo

[issue26247] Document Chrome/Chromium for python2.7

2016-03-11 Thread Fred L. Drake, Jr.
Fred L. Drake, Jr. added the comment: The ``versionadded::`` directive should only be used to annotate descriptions of new API entries. While it would be correctly applied to the ``Chrome`` and ``Chromium`` classes, those are not separately documented here, but are only listed in the table

[issue26247] Document Chrome/Chromium for python2.7

2016-03-11 Thread Fred L. Drake, Jr.
Fred L. Drake, Jr. added the comment: Sorry; I guess I wasn't clear. ``versionadded::`` and ``versionchanged::`` are applied to specific API points (modules, classes, methods, attributes) that are identified structurally in the documentation. That isn't the case for this. Whil

[issue26247] Document Chrome/Chromium for python2.7

2016-03-11 Thread Fred L. Drake, Jr.
Fred L. Drake, Jr. added the comment: LGTM Thanks for getting this documented! -- ___ Python tracker <http://bugs.python.org/issue26247> ___ ___ Python-bug

[issue26526] In parsermodule.c, replace over 2KLOC of hand-crafted validation code, with a DFA

2016-05-26 Thread Fred L. Drake, Jr.
Fred L. Drake, Jr. added the comment: I see your message to python-dev, and apologize for taking so long to get to this. I do intend to read through your changes, and hope to be able to make time while I'm at PyCon this coming week. -- ___ P

[issue2174] xml.sax.xmlreader does not support the InputSource protocol

2015-04-06 Thread Fred L. Drake, Jr.
Fred L. Drake, Jr. added the comment: Given that this has languished this long, patching historical releases seems pointless. -- status: open -> closed ___ Python tracker <http://bugs.python.org/iss

[issue22721] pprint output for sets and dicts is not stable

2015-04-06 Thread Fred L. Drake, Jr.
Fred L. Drake, Jr. added the comment: Sorry for the delay. pprint_safe_key.patch looks good to me. -- ___ Python tracker <http://bugs.python.org/issue22

[issue24067] Weakproxy is an instance of collections.Iterator

2015-04-28 Thread Fred L. Drake, Jr.
Fred L. Drake, Jr. added the comment: I don't see any reason for proxy objects to be less hashable than ref objects. As for the p == p case, where the referent has expired, returning True if p is p seems acceptable (along with False inequalities, and True for other comparisons all

[issue24067] Weakproxy is an instance of collections.Iterator

2015-04-28 Thread Fred L. Drake, Jr.
Fred L. Drake, Jr. added the comment: Clearly I've been away from this code for a long time. The hash support for ref objects is definitely a very special case, only intended to support WeakKeyDictionary. We that class implemented in C, we'd probably want the hash support for refs

[issue24067] Weakproxy is an instance of collections.Iterator

2015-04-28 Thread Fred L. Drake, Jr.
Fred L. Drake, Jr. added the comment: > ref objects behave differently: they inherit their referent's hash > value when alive, and remember it. proxy objects could be made to > behave the same way. They could, yes, but that would break the proxy behavior, and the hash <-->

[issue28278] Make `weakref.WeakKeyDictionary.__repr__` meaningful

2016-09-29 Thread Fred L. Drake, Jr.
Fred L. Drake, Jr. added the comment: I don't recall that the issues discussed here were considered when these classes were added; functionality was the issue at the time. I'm not particularly opposed to adding a more data-ful repr for the weakref-oriented mappings, but I&#x

[issue19795] Formatting of True/False/None in docs

2016-10-19 Thread Fred L. Drake, Jr.
Fred L. Drake, Jr. added the comment: Without the star would be right. ReST does not support nested markup, and in this case, I don't think it would make sense anyway. -- nosy: +fdrake ___ Python tracker <http://bugs.python.org/is

[issue28617] Why isn't "in" called a comparison operation?

2016-11-04 Thread Fred L. Drake, Jr.
Fred L. Drake, Jr. added the comment: "in" and "not in" are not comparisons, regardless of implementation mechanics (which could change). They aren't really dependent on iteration, though they often correlate with iteration. I'd rather see them described as &q

<    1   2   3