Florent Xicluna added the comment:
The fix on r77419 do not work.
The patch in attachment behaves better.
--
resolution: fixed ->
status: closed -> open
___
Python tracker
<http://bugs.python.org/
Changes by Florent Xicluna :
--
nosy: +flox
priority: -> normal
___
Python tracker
<http://bugs.python.org/issue7797>
___
___
Python-bugs-list mailing list
Un
Florent Xicluna added the comment:
Fixed with r77586
--
resolution: -> accepted
stage: needs patch -> committed/rejected
status: open -> closed
___
Python tracker
<http://bugs.python.o
Changes by Florent Xicluna :
--
stage: needs patch -> patch review
___
Python tracker
<http://bugs.python.org/issue7732>
___
___
Python-bugs-list mai
Changes by Florent Xicluna :
--
components: +Tests
stage: -> patch review
versions: +Python 2.7, Python 3.1, Python 3.2
___
Python tracker
<http://bugs.python.org/issue
Changes by Florent Xicluna :
Removed file: http://bugs.python.org/file15937/issue7732_find_module.diff
___
Python tracker
<http://bugs.python.org/issue7732>
___
___
Pytho
Florent Xicluna added the comment:
> if PyFile_FromFile fails for another reason (PyString_FromString(name)
> runs out of memory), the fp is not closed and the caller is right to
> call fclose().
As far as I understand, the fp is never left open, when PyFile_FromFile returns
NULL. S
Florent Xicluna added the comment:
AFAICT, in this case, if PyString_FromString gives NULL, then (o_name == NULL)
and the function returns without calling "fill_file_fields".
Hence, the fp is not opened.
Do you suggest some
Changes by Florent Xicluna :
--
nosy: +flox
___
Python tracker
<http://bugs.python.org/issue7624>
___
___
Python-bugs-list mailing list
Unsubscribe:
Florent Xicluna added the comment:
Confirmed.
I got a Py3k warning on 2.7 about "unorderable types".
--
nosy: +flox
versions: +Python 2.7
___
Python tracker
<http://bugs.python.
Florent Xicluna added the comment:
Confirmed with all others "isinstance(..., collections.Hashable)" and similar.
According to the documentation, we might expect the same behavior as for
new-style class.
--
priority: -> normal
stage: -> needs patch
type: ->
Florent Xicluna added the comment:
Wow, critical issue, are you sure?
Here is the patch, with tests.
IMO, the tests may be ported to 3.x.
--
keywords: +patch
stage: needs patch -> patch review
Added file: http://bugs.python.org/file16038/issue7624_abc.d
New submission from Florent Xicluna :
Patch proposed to fix the refleaks.
--
keywords: +patch
stage: -> patch review
Added file: http://bugs.python.org/file16039/issue7808_bsddb3_refleak.diff
___
Python tracker
<http://bugs.python.org/iss
Changes by Florent Xicluna :
--
components: Extension Modules
nosy: flox
priority: normal
severity: normal
status: open
title: test_bsddb3 leaks references
type: performance
versions: Python 2.6, Python 2.7
___
Python tracker
<http://bugs.python.
Changes by Florent Xicluna :
Removed file: http://bugs.python.org/file16038/issue7624_abc.diff
___
Python tracker
<http://bugs.python.org/issue7624>
___
___
Python-bug
Florent Xicluna added the comment:
fixed
--
Added file: http://bugs.python.org/file16040/issue7624_abc.diff
___
Python tracker
<http://bugs.python.org/issue7
Florent Xicluna added the comment:
Thank you for the review and your comments.
Here, the replies.
>
> Amaury review - msg98491
>
> Here is my review of issue7092_syntax_imports_v3.diff:
>
> - test_itertools.py: please replace
> [tuple([arg[i] if i < len(arg) e
Changes by Florent Xicluna :
Added file: http://bugs.python.org/file16042/issue7269_bsddb3.diff
___
Python tracker
<http://bugs.python.org/issue7092>
___
___
Python-bug
Changes by Florent Xicluna :
Removed file: http://bugs.python.org/file16042/issue7269_bsddb3.diff
___
Python tracker
<http://bugs.python.org/issue7092>
___
___
Python-bug
Changes by Florent Xicluna :
Added file: http://bugs.python.org/file16043/issue7092_bsddb3.diff
___
Python tracker
<http://bugs.python.org/issue7092>
___
___
Python-bug
Changes by Florent Xicluna :
--
nosy: +jcea
___
Python tracker
<http://bugs.python.org/issue7808>
___
___
Python-bugs-list mailing list
Unsubscribe:
Changes by Florent Xicluna :
Added file: http://bugs.python.org/file16044/issue7092_test_support.py
___
Python tracker
<http://bugs.python.org/issue7092>
___
___
Pytho
Changes by Florent Xicluna :
Removed file: http://bugs.python.org/file15925/issue7092_json.diff
___
Python tracker
<http://bugs.python.org/issue7092>
___
___
Python-bug
Changes by Florent Xicluna :
Removed file: http://bugs.python.org/file15994/issue7092_syntax_imports_v3.diff
___
Python tracker
<http://bugs.python.org/issue7092>
___
___
Changes by Florent Xicluna :
Removed file: http://bugs.python.org/file15995/issue7092_check_warnings_v3.diff
___
Python tracker
<http://bugs.python.org/issue7092>
___
___
Changes by Florent Xicluna :
Removed file: http://bugs.python.org/file15996/issue7092_filterwarnings_v3.diff
___
Python tracker
<http://bugs.python.org/issue7092>
___
___
Changes by Florent Xicluna :
Added file: http://bugs.python.org/file16046/issue7092_test_exceptions.diff
___
Python tracker
<http://bugs.python.org/issue7092>
___
___
Changes by Florent Xicluna :
Added file: http://bugs.python.org/file16047/issue7092_Wd_warnings.diff
___
Python tracker
<http://bugs.python.org/issue7092>
___
___
Pytho
Changes by Florent Xicluna :
Added file: http://bugs.python.org/file16048/issue7092_syntax_fixes.diff
___
Python tracker
<http://bugs.python.org/issue7092>
___
___
Pytho
Changes by Florent Xicluna :
Added file: http://bugs.python.org/file16049/issue7092_silence_imports.diff
___
Python tracker
<http://bugs.python.org/issue7092>
___
___
Changes by Florent Xicluna :
Added file: http://bugs.python.org/file16050/issue7092_py3k_warnings_args.diff
___
Python tracker
<http://bugs.python.org/issue7092>
___
___
Changes by Florent Xicluna :
Added file: http://bugs.python.org/file16051/issue7092_py3k_warnings_noargs.diff
___
Python tracker
<http://bugs.python.org/issue7
Florent Xicluna added the comment:
Each patch can be reviewed and committed separately (except the last 2).
[patch 1] bsddb3.diff – related to Bsddb3
[patch 2] test_support.diff – new helper "silence_py3k_warnings()"
[patch 3] test_exceptions.diff – "test_pep352" and "
Changes by Florent Xicluna :
Removed file: http://bugs.python.org/file16046/issue7092_test_exceptions.diff
___
Python tracker
<http://bugs.python.org/issue7092>
___
___
Florent Xicluna added the comment:
Cleanup test_exceptions:
- removed "filterwarnings" for "testSlicing"
--
Added file: http://bugs.python.org/file16053/issue7092_test_exceptions_v2.diff
___
Python tracker
<http://bu
Changes by Florent Xicluna :
Removed file: http://bugs.python.org/file16049/issue7092_silence_imports.diff
___
Python tracker
<http://bugs.python.org/issue7092>
___
___
Florent Xicluna added the comment:
Proposed test and fix.
Please comment, there's probably room for improvement.
--
keywords: +patch
stage: needs patch -> patch review
Added file: http://bugs.python.org/file16058/issue7385_memoryview.diff
__
New submission from Florent Xicluna :
test test_capi crashed -- : PyDateTime_CAPI somehow
initialized
1 test failed:
It was introduced in r76824.
It may be fixed with something like r72357.
--
components: Tests
messages: 98579
nosy: benjamin.peterson, flox
priority: normal
severity
Florent Xicluna added the comment:
Patch.
--
keywords: +patch
Added file: http://bugs.python.org/file16059/issue7816_test_capi.diff
___
Python tracker
<http://bugs.python.org/issue7
Changes by Florent Xicluna :
--
stage: -> patch review
___
Python tracker
<http://bugs.python.org/issue7816>
___
___
Python-bugs-list mailing list
Unsubscri
Changes by Florent Xicluna :
Removed file: http://bugs.python.org/file16059/issue7816_test_capi.diff
___
Python tracker
<http://bugs.python.org/issue7816>
___
___
Pytho
Changes by Florent Xicluna :
Removed file: http://bugs.python.org/file16058/issue7385_memoryview.diff
___
Python tracker
<http://bugs.python.org/issue7385>
___
___
Pytho
Florent Xicluna added the comment:
Removed /* XXX */ code
--
Added file: http://bugs.python.org/file16060/issue7385_memoryview.diff
___
Python tracker
<http://bugs.python.org/issue7
Changes by Florent Xicluna :
Removed file: http://bugs.python.org/file16047/issue7092_Wd_warnings.diff
___
Python tracker
<http://bugs.python.org/issue7092>
___
___
Pytho
Changes by Florent Xicluna :
Removed file: http://bugs.python.org/file16050/issue7092_py3k_warnings_args.diff
___
Python tracker
<http://bugs.python.org/issue7
Changes by Florent Xicluna :
Removed file:
http://bugs.python.org/file16051/issue7092_py3k_warnings_noargs.diff
___
Python tracker
<http://bugs.python.org/issue7
Changes by Florent Xicluna :
Added file:
http://bugs.python.org/file16075/issue7092_py3k_warnings_args_v2.diff
___
Python tracker
<http://bugs.python.org/issue7
Changes by Florent Xicluna :
Added file:
http://bugs.python.org/file16076/issue7092_py3k_warnings_noargs_v2.diff
___
Python tracker
<http://bugs.python.org/issue7
Florent Xicluna added the comment:
Small note:
- the unit tests could use assertIsInstance(..., str), assertIsInstance(...,
unicode) instead of the custom methods.
- some "assertTrue" may be replaced by "assertEqual"
--
___
P
New submission from Florent Xicluna :
The cmp(a, b) function is missing in 3.0.
This change is slightly documented in Doc/whatsnew/3.0.rst:
"The cmp() function should be treated as gone."
There's no "-3" warning and no 2to3 fixer for it.
--
messages: 98680
no
Florent Xicluna added the comment:
As a replacement, it could be useful to propose a "universal key" for sort()
method and sorted() builtin.
>>> lst = sorted([{2: '3'}, 1, '05'], key=list.ukey)
>>>
There's a reference
Florent Xicluna added the comment:
Ok.
Maybe we need a "-3" warning and/or a 2to3 fixer?
--
components: +2to3 (2.x to 3.0 conversion tool)
versions: +Python 2.6, Python 2.7
___
Python tracker
<http://bugs.python.
Changes by Florent Xicluna :
--
versions: -Python 2.6
___
Python tracker
<http://bugs.python.org/issue7831>
___
___
Python-bugs-list mailing list
Unsubscribe:
New submission from Florent Xicluna :
The current behavior of "assertSameElements" is not correctly documented.
The unit test confirm that it is a tested behaviour.
However it seems more useful to provide a method which compares the actual
count of each element in both sequence
Florent Xicluna added the comment:
Patch which adds method "assertItemsEqual".
However we could reuse the "assertSameElements" name, and replace the current
implementation: it is still the alpha stage.
--
keywords: +patch
Added file: http://bugs.
Changes by Florent Xicluna :
Removed file: http://bugs.python.org/file16043/issue7092_bsddb3.diff
___
Python tracker
<http://bugs.python.org/issue7092>
___
___
Python-bug
Changes by Florent Xicluna :
Removed file: http://bugs.python.org/file16065/issue7092_bsddb3v2.diff
___
Python tracker
<http://bugs.python.org/issue7092>
___
___
Pytho
Florent Xicluna added the comment:
Proposed patch to filter out some deprecated comparisons in "unittest" module.
--
Added file: http://bugs.python.org/file16096/issue7092_unittest.py
___
Python tracker
<http://bugs.python.
Florent Xicluna added the comment:
Variant based on the previous patches.
It fixes an error relative to assertSameElements: comparing sequences which
contain unorderable types.
Example: [2j, 5j, set(), frozenset()]
The util.unorderable_list_difference() helper is backported from 3.x
Changes by Florent Xicluna :
Removed file: http://bugs.python.org/file16096/issue7092_unittest.py
___
Python tracker
<http://bugs.python.org/issue7092>
___
___
Python-bug
Florent Xicluna added the comment:
test_unittest fixed in r77911. See also #7837.
--
___
Python tracker
<http://bugs.python.org/issue7092>
___
___
Python-bug
Changes by Florent Xicluna :
Removed file: http://bugs.python.org/file16060/issue7385_memoryview.diff
___
Python tracker
<http://bugs.python.org/issue7385>
___
___
Pytho
Florent Xicluna added the comment:
Thanks.
--
Added file: http://bugs.python.org/file16112/issue7385_memoryview_v2.diff
___
Python tracker
<http://bugs.python.org/issue7
Changes by Florent Xicluna :
Removed file: http://bugs.python.org/file16044/issue7092_test_support.py
___
Python tracker
<http://bugs.python.org/issue7092>
___
___
Pytho
Florent Xicluna added the comment:
Docstring added.
Notes:
- there's 2 categories of -3 warnings: SyntaxWarning and DeprecationWarning.
- AFAICT, the WarningsRecorder needs "catch_warnings(record=True)".
And in such case, *all* warnings are silenced.
--
A
Florent Xicluna added the comment:
Backport missing. See #7816
--
nosy: +flox
resolution: -> duplicate
stage: needs patch -> committed/rejected
status: open -> closed
superseder: -> test_capi crashes when run with "-R"
___
New submission from Florent Xicluna :
Currently this context manager is used in 3 different situations:
- to silence standard warnings
- to record warnings in a list, in order to verify them
- to silence py3k warnings
But it does not accept any parameter, and it does not *check* if the
Changes by Florent Xicluna :
--
keywords: +patch
Added file: http://bugs.python.org/file16118/issue7849_check_warnings.diff
___
Python tracker
<http://bugs.python.org/issue7
Florent Xicluna added the comment:
Patch for the context managers.
Patch to fix the stdlib.
--
Added file: http://bugs.python.org/file16119/issue7849_lib_fixes.diff
___
Python tracker
<http://bugs.python.org/issue7
Changes by Florent Xicluna :
--
dependencies: +Improve "test_support.check_warnings()"
___
Python tracker
<http://bugs.python.org/issue7092>
___
___
Florent Xicluna added the comment:
Actually this patch enhances check_warnings() in other ways too:
- it verifies if the warning is effectively raised
- it deals with "py3k" warnings separately
It could be used instead of warnings.filterwarnings() with som
Changes by Florent Xicluna :
Removed file: http://bugs.python.org/file16118/issue7849_check_warnings.diff
___
Python tracker
<http://bugs.python.org/issue7849>
___
___
Florent Xicluna added the comment:
Fixed. Tested with different options: "-Wd", "-3"
--
Added file: http://bugs.python.org/file16120/issue7849_check_warnings_v2.diff
___
Python tracker
<http://bu
Florent Xicluna added the comment:
The enhancement proposed on #7849 should be considered before reviewing the
last 2 patches.
If #7849 is accepted, these patches will need update.
--
___
Python tracker
<http://bugs.python.org/issue7
Florent Xicluna added the comment:
http://www.python.org/dev/buildbot/all/builders/AMD64%20Ubuntu%20trunk/builds/387
--
___
Python tracker
<http://bugs.python.org/issue7
New submission from Florent Xicluna :
On __exit__(), the 3rd argument "exc_value" should contain the instance of the
exception.
But in most cases, it contains only the string representation of the exception.
See attached test case.
Same behavior for KeyError, AttributeError, Ru
Changes by Florent Xicluna :
Removed file: http://bugs.python.org/file16125/case_contextmanager_exit.py
___
Python tracker
<http://bugs.python.org/issue7853>
___
___
Pytho
Changes by Florent Xicluna :
Added file: http://bugs.python.org/file16126/case_contextmanager_exit.py
___
Python tracker
<http://bugs.python.org/issue7853>
___
___
Pytho
Florent Xicluna added the comment:
Patch.
--
keywords: +patch
stage: test needed -> patch review
Added file: http://bugs.python.org/file16137/issue7853_cm_exit.diff
___
Python tracker
<http://bugs.python.org/iss
Florent Xicluna added the comment:
Patch.
--
keywords: +patch
stage: needs patch -> patch review
Added file: http://bugs.python.org/file16138/issue7728_timeout.diff
___
Python tracker
<http://bugs.python.org/iss
Florent Xicluna added the comment:
It could take benefit of "test_support.find_unused_port".
--
components: +Library (Lib)
keywords: +buildbot
nosy: +flox
___
Python tracker
<http://bugs.python.
Florent Xicluna added the comment:
You may use the decorator @unittest.skip("see issue #7857") for these tests,
until it's fixed.
(or @unittest.expectedFailure, if you want to run them anyway)
http://docs.python.org/dev/library/unittest.htm
New submission from Florent Xicluna :
It would be useful to get the actual exception in order to introspect its
attributes.
(See some potential uses in "test_dict")
--
components: Tests
messages: 98882
nosy: flox
priority: normal
severity: normal
status: open
title: sup
Florent Xicluna added the comment:
right, but it could return a wrapper object which receives the exception on
__exit__.
--
___
Python tracker
<http://bugs.python.org/issue7
Changes by Florent Xicluna :
Removed file: http://bugs.python.org/file15951/temp_cwd_decorator_v2.diff
___
Python tracker
<http://bugs.python.org/issue7712>
___
___
Pytho
Changes by Florent Xicluna :
--
title: Add a context manager to change cwd in test.test_support -> Add a
context manager to change cwd in test.test_support and run the test suite in a
temp dir.
___
Python tracker
<http://bugs.python.org/iss
Florent Xicluna added the comment:
It looks fine.
Few comments:
- "{}_python_{}" could be better, to identify the culprit for leftover
directories.
- the warning message may be more specific:
"warnings.warn('tests may fail, unable to switch to ' + name,
Florent Xicluna added the comment:
Patch which fixes the "relative import" issue.
~ $ cd Lib/
~ $ ../python -m test.regrtest
Note: There are some 2-spaces indents for patch readability.
Change them before commit.
--
versions: -Python 2.6, Python 3.1
Added
Changes by Florent Xicluna :
Removed file: http://bugs.python.org/file15956/issue7712_context_manager.diff
___
Python tracker
<http://bugs.python.org/issue7712>
___
___
Florent Xicluna added the comment:
Slightly more readable, without 2-spaces indent.
--
Added file: http://bugs.python.org/file16151/issue7712_context_manager_v3.diff
___
Python tracker
<http://bugs.python.org/issue7
Changes by Florent Xicluna :
Removed file: http://bugs.python.org/file16150/issue7712_context_manager_v2.diff
___
Python tracker
<http://bugs.python.org/issue7
Changes by Florent Xicluna :
Removed file: http://bugs.python.org/file16151/issue7712_context_manager_v3.diff
___
Python tracker
<http://bugs.python.org/issue7
Florent Xicluna added the comment:
There were syntax errors in the previous patch. Sorry.
--
Added file: http://bugs.python.org/file16152/issue7712_context_manager_v3a.diff
___
Python tracker
<http://bugs.python.org/issue7
Changes by Florent Xicluna :
Removed file:
http://bugs.python.org/file16152/issue7712_context_manager_v3a.diff
___
Python tracker
<http://bugs.python.org/issue7
Florent Xicluna added the comment:
Removed the dummy CM hack.
Now it should be ready for final review.
--
Added file: http://bugs.python.org/file16165/issue7712_context_manager_v4.diff
___
Python tracker
<http://bugs.python.org/issue7
Changes by Florent Xicluna :
Removed file: http://bugs.python.org/file16165/issue7712_context_manager_v4.diff
___
Python tracker
<http://bugs.python.org/issue7
Florent Xicluna added the comment:
Let's fix some other tests.
--
Added file: http://bugs.python.org/file16167/issue7712_context_manager_v5.diff
___
Python tracker
<http://bugs.python.org/i
Florent Xicluna added the comment:
Thank you for this answer. The "exception" argument could be useful.
But it does not work as documented on r77999...
Btw, the documentation explains the behaviour I expect...
--
status: closed
Florent Xicluna added the comment:
Fixed (with tests) in r78094. Thank you Michael.
--
___
Python tracker
<http://bugs.python.org/issue7859>
___
___
Python-bug
Changes by Florent Xicluna :
--
keywords: +buildbot
___
Python tracker
<http://bugs.python.org/issue7875>
___
___
Python-bugs-list mailing list
Unsubscribe:
401 - 500 of 1386 matches
Mail list logo