Change by Erlend E. Aasland :
--
nosy: +iritkatriel
___
Python tracker
<https://bugs.python.org/issue46428>
___
___
Python-bugs-list mailing list
Unsubscribe:
Erlend E. Aasland added the comment:
Closing this. Thanks, Ned and Eric!
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Change by Erlend E. Aasland :
--
pull_requests: +28878
pull_request: https://github.com/python/cpython/pull/30680
___
Python tracker
<https://bugs.python.org/issue24
Erlend E. Aasland added the comment:
PR without mapping protocol and context manager submitted: GH-30680. I've also
changed the open API to reflect that of apsw.
--
___
Python tracker
<https://bugs.python.org/is
Change by Erlend E. Aasland :
--
nosy: +erlendaasland
___
Python tracker
<https://bugs.python.org/issue46433>
___
___
Python-bugs-list mailing list
Unsubscribe:
Erlend E. Aasland added the comment:
If you are ok with the proposed API in GH-30680, I'll mark it as ready for
review.
--
___
Python tracker
<https://bugs.python.org/is
Erlend E. Aasland added the comment:
> AFAIK we have committed _PyArg_UnpackKeywordsWithVararg on 3.11 alpha, so I
> think it should be fine.
I see, so no ABI worries then.
--
___
Python tracker
<https://bugs.python.org/i
Erlend E. Aasland added the comment:
Previously, this failure was more sporadic; now it happens almost every single
run on the Azure CI. Has there been updates on the Azure CI lately?
--
___
Python tracker
<https://bugs.python.org/issue41
Erlend E. Aasland added the comment:
Can we close this, or are you expecting more changes?
--
nosy: +erlendaasland
status: open -> pending
___
Python tracker
<https://bugs.python.org/issu
Erlend E. Aasland added the comment:
> Can we close this issue? Or is there a remaining task?
3.9 is still affected; we should fix those types first.
--
___
Python tracker
<https://bugs.python.org/issu
Change by Erlend E. Aasland :
--
versions: +Python 3.9 -Python 3.10
___
Python tracker
<https://bugs.python.org/issue43916>
___
___
Python-bugs-list mailin
Change by Erlend E. Aasland :
--
title: Mark static types newly converted to heap types as immutable: add
Py_TPFLAGS_DISALLOW_INSTANTIATION type flag -> Check that new heap types cannot
be created uninitialised: add Py_TPFLAGS_DISALLOW_INSTANTIATION type f
Erlend E. Aasland added the comment:
FYI: There are only two bug-fix releases left for 3.9.
--
___
Python tracker
<https://bugs.python.org/issue43916>
___
___
Change by Erlend E. Aasland :
--
pull_requests: +29211
pull_request: https://github.com/python/cpython/pull/31030
___
Python tracker
<https://bugs.python.org/issue43
Erlend E. Aasland added the comment:
Did GH-30633 fix this? Is there further work to be done?
--
nosy: +erlendaasland
status: open -> pending
___
Python tracker
<https://bugs.python.org/issu
Erlend E. Aasland added the comment:
It looks like this can be closed. Petr?
--
status: open -> pending
___
Python tracker
<https://bugs.python.org/issu
Erlend E. Aasland added the comment:
Right, this of course affects 3.10 and 3.9. Let me know if you want me to do
the backports :)
(Updating version field for this ticket)
--
versions: +Python 3.10, Python 3.9
___
Python tracker
<ht
Change by Erlend E. Aasland :
--
nosy: -erlendaasland
___
Python tracker
<https://bugs.python.org/issue46200>
___
___
Python-bugs-list mailing list
Unsubscribe:
New submission from Erlend E. Aasland :
`pysqlite_connection_execute_impl()` and friends (executemany, executescript)
goes all the way through the Call API just to call
`pysqlite_connection_cursor_impl`. We can same a lot of calls by calling the
cursor _impl function directly; after all, it
Change by Erlend E. Aasland :
--
keywords: +patch
pull_requests: +29306
stage: -> patch review
pull_request: https://github.com/python/cpython/pull/31127
___
Python tracker
<https://bugs.python.org/issu
Change by Erlend E. Aasland :
--
nosy: +erlendaasland
___
Python tracker
<https://bugs.python.org/issue46657>
___
___
Python-bugs-list mailing list
Unsubscribe:
Erlend E. Aasland added the comment:
The sqlite3 timestamp converter is buggy, as already noted in the docs[^1].
Adding timezone support is out of the question[^2][^3][^4][^5], but fixing it
to be able to discard any attached timezone info _may_ be ok; at first sight, I
don't see how
Change by Erlend E. Aasland :
--
nosy: +lemburg
___
Python tracker
<https://bugs.python.org/issue46662>
___
___
Python-bugs-list mailing list
Unsubscribe:
Erlend E. Aasland added the comment:
I made a list of macros that reuse their argument some time around
February/March 2021. (Each macro is squashed into a single line for some reason
I can't remember.) See attachment, or check out the gist version:
https://gist.github.com/erlend-aa
Erlend E. Aasland added the comment:
> Any update on this?
I was unable to reproduce this last time we visited this issue, but I'll give
it another try.
> If there is no immediate plan to make this change you may close the issue :)
I do not want to close it until I can a) either
Erlend E. Aasland added the comment:
> There will be huge changes for this issue as this keyword has been used in a
> lot of places.
It should be sufficient to change only the exposed headers; that is Include/*.h
and Include/cpython/*.h. We should also change the AC tool, since that
Change by Erlend E. Aasland :
--
Removed message: https://bugs.python.org/msg413055
___
Python tracker
<https://bugs.python.org/issue39355>
___
___
Python-bug
Erlend E. Aasland added the comment:
> There will be huge changes for this issue as this keyword has been used in a
> lot of places.
For external extension modules, it should be sufficient to change only the
exposed headers; that is Include/*.h and Include/cpython/*.h. We shoul
Erlend E. Aasland added the comment:
> Do you plan to make the function public? It would be nice!
See https://github.com/python/cpython/pull/31081
--
___
Python tracker
<https://bugs.python.org/issu
Erlend E. Aasland added the comment:
+1 (what Jelle said)
--
nosy: +erlendaasland
___
Python tracker
<https://bugs.python.org/issue46725>
___
___
Python-bug
Change by Erlend E. Aasland :
--
nosy: +erlendaasland
nosy_count: 4.0 -> 5.0
pull_requests: +29448
pull_request: https://github.com/python/cpython/pull/31288
___
Python tracker
<https://bugs.python.org/issu
Change by Erlend E. Aasland :
--
nosy: +erlendaasland
nosy_count: 5.0 -> 6.0
pull_requests: +29500
pull_request: https://github.com/python/cpython/pull/31351
___
Python tracker
<https://bugs.python.org/issu
Erlend E. Aasland added the comment:
Quoting the docs:
> This is a nonstandard shortcut that creates a cursor object by calling the
> cursor() method, calls the cursor’s execute() method with the parameters
> given, and returns the cursor.
There is already a backlink (or back refe
Erlend E. Aasland added the comment:
The change proposed in GH-31127 was included in GH-31351. Closing this.
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Change by Erlend E. Aasland :
--
pull_requests: +29709
pull_request: https://github.com/python/cpython/pull/31586
___
Python tracker
<https://bugs.python.org/issue43
New submission from Erlend E. Aasland :
Currently, the `step` method of user-defined functions is looked up using
`PyObject_GetAttrString`. Using an interned string and `PyObject_GetAttr`, we
can speed up this a little bit.
--
components: Library (Lib)
messages: 414151
nosy
Change by Erlend E. Aasland :
--
assignee: -> erlendaasland
___
Python tracker
<https://bugs.python.org/issue46874>
___
___
Python-bugs-list mailing list
Un
Change by Erlend E. Aasland :
--
keywords: +patch
pull_requests: +29727
stage: -> patch review
pull_request: https://github.com/python/cpython/pull/31604
___
Python tracker
<https://bugs.python.org/issu
Erlend E. Aasland added the comment:
Can we close this?
--
nosy: +erlendaasland
status: open -> pending
___
Python tracker
<https://bugs.python.org/issu
Change by Erlend E. Aasland :
--
pull_requests: +29732
pull_request: https://github.com/python/cpython/pull/31609
___
Python tracker
<https://bugs.python.org/issue46
New submission from Erlend E. Aasland :
Several sqlite3 methods are "marked" as non-standard in their docstrings. This
is an historic artefact which (I assume) implies that a method is not a part of
the DB-API defined by PEP 249. Questions regarding the "non-standard" stri
Change by Erlend E. Aasland :
--
keywords: +patch
pull_requests: +29735
stage: -> patch review
pull_request: https://github.com/python/cpython/pull/31612
___
Python tracker
<https://bugs.python.org/issu
Change by Erlend E. Aasland :
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Erlend E. Aasland added the comment:
This is not needed. Quoting
https://sqlite.org/compile.html#enable_math_functions:
This option is automatically added to the Makefile by the configure script
on unix platforms, unless the --disable-math option is used.
--
nosy
Erlend E. Aasland added the comment:
Suggesting to close as "not a bug".
--
resolution: -> not a bug
status: open -> pending
___
Python tracker
<https://bugs.py
Erlend E. Aasland added the comment:
Duplicate of bpo-42686.
--
status: pending -> open
___
Python tracker
<https://bugs.python.org/issue46889>
___
___
Py
Erlend E. Aasland added the comment:
FTR, here's 3.10 and 3.11 on my Mac, using the official Python.org installers:
$ python3.10
Python 3.10.2 (v3.10.2:a58ebcc701, Jan 13 2022, 14:50:16) [Clang 13.0.0
(clang-1300.0.29.30)] on darwin
Type "help", "copyright&quo
Erlend E. Aasland added the comment:
+1 for SQLite 3.38.0.
--
___
Python tracker
<https://bugs.python.org/issue46907>
___
___
Python-bugs-list mailing list
Unsub
Erlend E. Aasland added the comment:
Steve, would you mind updating the cpython sources repo? (No hurry; let's see
if a patch release surfaces first.)
--
___
Python tracker
<https://bugs.python.org/is
Change by Erlend E. Aasland :
--
nosy: +erlendaasland
___
Python tracker
<https://bugs.python.org/issue45373>
___
___
Python-bugs-list mailing list
Unsubscribe:
Change by Erlend E. Aasland :
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Change by Erlend E. Aasland :
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Change by Erlend E. Aasland :
--
pull_requests: +29818
pull_request: https://github.com/python/cpython/pull/31698
___
Python tracker
<https://bugs.python.org/issue45
Erlend E. Aasland added the comment:
Regarding _tkinter (Tcl/Tk):
Based on discussion on Discourse
(https://discuss.python.org/t/simplifying-tcl-tk-detection/14066), my current
plan is to just use pkg-config, and drop the rest of the autodetect hackery.
GH-31698 sort'a works given tha
Erlend E. Aasland added the comment:
FYI, tested GH-31698 on Debian 10.3, and it works swell there.
--
___
Python tracker
<https://bugs.python.org/issue45
Erlend E. Aasland added the comment:
> GH-31698 sort'a works given that pkg-config provides us with correct info.
> Sadly it doesn't for Ubuntu [...]
Hm, looking more closely at Ubuntu (20.4), I see that the pkg-config files is
actually correct. I'll have to debug
Erlend E. Aasland added the comment:
FTR:
$ strings /lib/x86_64-linux-gnu/libtcl8.6.so | grep -E "\"
Tcl_Init
$ strings /lib/x86_64-linux-gnu/libtk8.6.so | grep -E "\"
Tk_Init
--
___
Python tracker
<https://bug
Erlend E. Aasland added the comment:
Solved: Ubuntu is fine, we just need to treat LIBS and LDFLAGS with care in
configure.ac. GH-31698 is updated with a fix.
--
___
Python tracker
<https://bugs.python.org/issue45
Change by Erlend E. Aasland :
--
nosy: +erlendaasland
nosy_count: 1.0 -> 2.0
pull_requests: +29854
pull_request: https://github.com/python/cpython/pull/31737
___
Python tracker
<https://bugs.python.org/issu
Change by Erlend E. Aasland :
--
pull_requests: +29866
pull_request: https://github.com/python/cpython/pull/31753
___
Python tracker
<https://bugs.python.org/issue46
Change by Erlend E. Aasland :
--
pull_requests: +29867
pull_request: https://github.com/python/cpython/pull/31754
___
Python tracker
<https://bugs.python.org/issue46
Erlend E. Aasland added the comment:
Reopening bco. broken buildbots.
--
status: closed -> open
___
Python tracker
<https://bugs.python.org/issue45138>
___
_
Erlend E. Aasland added the comment:
Ah, one of my very first contributions, bpo-40318, comes back to haunt me:
In bpo-40318, we migrated from the old SQLite trace API (sqlite3_trace) to
SQLite trace v2 API (sqlite3_trace_v2). GH-19581, which introduced this change,
introduced a bug: the
Change by Erlend E. Aasland :
--
pull_requests: +29888
stage: resolved -> patch review
pull_request: https://github.com/python/cpython/pull/31783
___
Python tracker
<https://bugs.python.org/issu
Change by Erlend E. Aasland :
--
pull_requests: +29892
pull_request: https://github.com/python/cpython/pull/31788
___
Python tracker
<https://bugs.python.org/issue45
Erlend E. Aasland added the comment:
The change that introduced this regression was reverted in GH-31788
--
resolution: -> fixed
stage: -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Change by Erlend E. Aasland :
--
nosy: +erlendaasland
___
Python tracker
<https://bugs.python.org/issue45979>
___
___
Python-bugs-list mailing list
Unsubscribe:
Erlend E. Aasland added the comment:
I'm removing 3.11 from the versions field:
$ python3.11 sqlite3_fatal_python_error.py
Exception ignored in:
Traceback (most recent call last):
File
"/Users/erlendaasland/src/cpython-build/sqlite3_fatal_python_error.py"
Erlend E. Aasland added the comment:
> A perfect repro has been attached, should be run on Linux.
FTR, the repo works on macOS 12.2.1 as well:
$ python3.10 ./sqlite3_fatal_python_error.py
Fatal Python error: PyThreadState_Get: the function must be called with the
GIL held, but
Erlend E. Aasland added the comment:
> My recommended fix is to call sqlite3_close() within
> Py_BEGIN_ALLOW_THREADS/Py_END_ALLOW_THREADS, and manually Py_DECREF all
> connection-related functions afterward.
3.11 already drops the GIL before sqlite3_close_v2(); backporting this c
Erlend E. Aasland added the comment:
Updating to SQLite 3.37 was backported because of a data corruption bug that
was fixed. AFAIK, there’s nothing like that in 3.38. I would prefer waiting to
see if more patch releases appear. (That was also my intent, given how many
patch releases we saw
Erlend E. Aasland added the comment:
Closing this tonight, unless someone objects.
--
status: open -> pending
___
Python tracker
<https://bugs.python.org/issu
Change by Erlend E. Aasland :
--
resolution: -> fixed
stage: patch review -> resolved
status: pending -> closed
___
Python tracker
<https://bugs.python.or
Erlend E. Aasland added the comment:
> If you connect with check_same_thread=False, I believe the issue may still
> present itself on 3.11+
Nope, works swell on my Mac. Do you see this on Linux with latest 3.11?
--
___
Python tracker
Erlend E. Aasland added the comment:
All callbacks triggered from external libraries must protect Python C API
calls. You may call it offending, but that is the reality; a callback may
trigger at any point in time, so we need to make sure the GIL is held before
calling any Py API. That is
Erlend E. Aasland added the comment:
See also bpo-44304
--
nosy: +pablogsal
___
Python tracker
<https://bugs.python.org/issue47019>
___
___
Python-bugs-list m
Erlend E. Aasland added the comment:
See also Petrs msg400205:
> [...] I recommend that any function passed to SQLite (and only those) should
> - be named `*_callback`, for clarity
> - acquire the GIL at the very start
> - release the GIL at
Erlend E. Aasland added the comment:
FYI, PyGILState_Ensure may be called by a thread as many times as you want, and
it has been so for a very long time.
--
___
Python tracker
<https://bugs.python.org/issue47
Erlend E. Aasland added the comment:
Maybe related: bpo-20891
--
___
Python tracker
<https://bugs.python.org/issue47019>
___
___
Python-bugs-list mailin
Erlend E. Aasland added the comment:
> The C++20 "module" keyword is "contextual keyword". It's only a keyword if
> the first line if a file contains "module".
Great! No changes needed. Thanks for investigating.
--
_
Erlend E. Aasland added the comment:
Let's hold these PRs a couple of weeks in case more patch releases appear. IMO
we can hold it until a week or two before the beta phase kicks in.
--
___
Python tracker
<https://bugs.python.org/is
Erlend E. Aasland added the comment:
> Erlend - would you be up for write permissions on the cpython-source-deps
> repo so you can push the SQLite updates yourself.
Yep, I’m fine with that.
--
___
Python tracker
<https://bugs.p
Erlend E. Aasland added the comment:
Great, thanks :)
--
___
Python tracker
<https://bugs.python.org/issue46907>
___
___
Python-bugs-list mailing list
Unsub
Erlend E. Aasland added the comment:
Anthony: you should be able to build the _tkinter by manually specifying the
compiler and linker flags using the `TCLTK_CFLAGS` and `TCLTK_LIBS` environment
variables. AFAICS, the flags provided by pkgconfig in Ubuntu 20.04 should work
well in 18.04
Change by Erlend E. Aasland :
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Change by Erlend E. Aasland :
--
resolution: -> duplicate
stage: -> resolved
status: open -> closed
superseder: -> Add create_window_function() to sqlite3.Connection
___
Python tracker
<https://bugs.python
Erlend E. Aasland added the comment:
I cannot reproduce this with Python 3.8, 3.9, nor 3.10 (macOS builds from
python.org). Suggesting to close this.
--
nosy: +erlendaasland
status: open -> pending
___
Python tracker
<https://bugs.pyth
Erlend E. Aasland added the comment:
You need to create your type objects dynamically when using the Limited API.
See PEP 384 for how to do so:
https://www.python.org/dev/peps/pep-0384/#type-objects
Quoting from the PEP:
"The structure of type objects is not available to applica
New submission from Erlend E. Aasland :
sqlite3_stmt_busy() has been around since SQLite 3.7.10. I suggest to drop the
in_use field of pysqlite_Statement in favour of sqlite3_stmt_busy(); we do not
need to duplicate functionality already present in SQLite.
There was a bugfix for
Erlend E. Aasland added the comment:
> Hm, I guess we could use sqlite3_stmt_busy() instead of the in_use flag.
I opened bpo-44073 for this.
--
___
Python tracker
<https://bugs.python.org/issu
Erlend E. Aasland added the comment:
$ git diff --stat
Modules/_sqlite/connection.c | 1 -
Modules/_sqlite/cursor.c | 5 +
Modules/_sqlite/statement.c | 14 +-
Modules/_sqlite/statement.h | 2 --
4 files changed, 2 insertions(+), 20 deletions
Change by Erlend E. Aasland :
--
keywords: +patch
pull_requests: +24636
stage: -> patch review
pull_request: https://github.com/python/cpython/pull/25984
___
Python tracker
<https://bugs.python.org/issu
Erlend E. Aasland added the comment:
Here's a trick I often recommend:
Do as the CI; use the posix-deps-apt.sh script!
You'll find it in your CPython git repo:
$ cd cpython.git # change working dir to the CPython git repo
$ cat .github/workflows/posix-deps-apt.sh
#!/bin/sh
apt-
New submission from Erlend E. Aasland :
Today, the sqlite3 extension module keeps two[1] lists of statements:
1. The statement cache[2], stored in pysqlite_Connection.statement_cache
2. A weak ref. list (hard coded limited to 200 statements in
_pysqlite_drop_unused_statement_references
Erlend E. Aasland added the comment:
Berker/Serhiy, weak ref. list question:
Could also the pysqlite_Statement.in_weakreflist member go? Seems to be ok:
$ git diff --shortstat
3 files changed, 13 insertions(+), 72 deletions(-)
$ ./python.exe -m test -R : test_sqlite
0:00:00 load avg: 0.83
Change by Erlend E. Aasland :
--
keywords: +patch
pull_requests: +24651
stage: -> patch review
pull_request: https://github.com/python/cpython/pull/25998
___
Python tracker
<https://bugs.python.org/issu
Change by Erlend E. Aasland :
--
title: [sqlite3] optimisation: remove statement weak ref list from connection
object -> [sqlite3] remove superfluous statement weak ref list from connection
object
___
Python tracker
<https://bugs.pyth
Erlend E. Aasland added the comment:
What would be the use case for this?
--
nosy: +erlendaasland
___
Python tracker
<https://bugs.python.org/issue41
Erlend E. Aasland added the comment:
As Gerhard said in msg233384, there is already a statement cache.
sqlite3_prepare_v2() is only called if the statement is not found in the cache.
Current behaviour:
>>> import sqlite3
>>> cx = sqlite3.connect(":memor
Change by Erlend E. Aasland :
--
nosy: +berker.peksag
___
Python tracker
<https://bugs.python.org/issue22956>
___
___
Python-bugs-list mailing list
Unsubscribe:
101 - 200 of 829 matches
Mail list logo