Erik Bray added the comment:
> When run from an uninstalled checkout, for example when developing, the
> file will be found in the checkout. When run after being installed on
> a Debian system, the file will be found in /usr/local/share
> /spam/templates/log.txt. Each Python
Erik Bray added the comment:
FWIW, I'm for the first option for specifying package_data:
[files]
package_data =
spam = first second third
I'm pretty sure this is how I ended up implementing it in d2to1, since I needed
this functionality.
Theoretically spaces could be support
New submission from Erik Bray :
I have a use case where I have a small library of setup_hook functions for
various purposes that are used by multiple projects. Some projects may want to
use more than one of these setup_hooks.
I can certainly create a wrapper hook for each function that calls
Erik Bray added the comment:
Great! I'll add a patch shortly.
--
___
Python tracker
<http://bugs.python.org/issue12240>
___
___
Python-bugs-list m
Erik Bray added the comment:
Adds support for multiple setup_hooks and updates the docs.
For now I left the option name as "setup_hook", though it might make sense to
rename it to "setup_hooks" for consistency's sake.
--
keywords: +patch
Added file: http://
Erik Bray added the comment:
Done. Also added support for multi-valued description-file values.
--
Added file: http://bugs.python.org/file22276/issue11595-2.patch
___
Python tracker
<http://bugs.python.org/issue11
Erik Bray added the comment:
Thanks Eric for your review. Obviously the last patch was rushed, and I didn't
even run the tests. It also got my changes for issue12240 mixed into it. So
I've gone ahead and attached an updated patch which incorporates your review
comments.
--
Erik Bray added the comment:
Here's an update with tests. It should be applied after my patch for
issue11595.
--
Added file: http://bugs.python.org/file22299/python_issue12240-2.patch
___
Python tracker
<http://bugs.python.org/is
New submission from Erik Bray :
I just saw issue11637 [Add cwd to sys.path for hooks] and was reminded that
this would also be useful (and in fact necessary if hook code is in a package
that's under some root other than cwd).
On a related matter, the current use of Distribution.package_d
New submission from Erik Bray :
This issue was first mentioned in issue12375. The Distribution.package_dir
attribute (which also appears in a few commands) is not used in a consistent
manner. Some code expects it to be a string, while other code expects it to be
a dict.
I believe the
Erik Bray added the comment:
Added issue12377 for packages_root/package_dir cleanup.
--
___
Python tracker
<http://bugs.python.org/issue12375>
___
___
Python-bug
Erik Bray added the comment:
Good to know! The majority of my development is still on 2.x so it's easy to
forget things like that.
--
___
Python tracker
<http://bugs.python.org/is
New submission from Erik Bray :
Attached is a patch that fixes a few miscellaneous bugs in cfg_to_args() that
were holding me up. Namely:
* A bad variable name (file -> path)
* A few more fields needed to be in MULTI_FIELDS
* Added support for packages_root -> package_dir conversion
Erik Bray added the comment:
I've got an additional patch to this function that also adds support for the
package_data option, for extension modules (at least as they are currently
specified in setup.cfg), and adds support for running setup_hook.
The only problem is that it's s
New submission from Erik Bray :
In distutils the package_data option can be supplied a list of glob patterns
for each package. distutils2 currently only supports one glob per package.
This could easily be fixed by simply allowing more than one `package_name =
pattern` value in the
Erik Bray added the comment:
As far as I've been able to tell there is no proposed syntax in the docs
specifically for package_data. The docs for the resources option seems to
suggest separating globs with spaces, which would be fine by me (wouldn't allow
paths that contain s
Erik Bray added the comment:
Thanks for asking. Indeed the fix to that issue was included in
https://cygwin.com/git/?p=newlib-cygwin.git;a=commit;h=5ca28a0cd71436a84797d5d66831790004e0
and as Cygwin obsoletes old releases rather quickly I see no reason to keep
this issue open
Erik Bray added the comment:
That person was me--I have the keys to a cygwin buildbot, but it's currently
not running. I lost the urgency to make cygwin fully supported, though it's
come a long way. In particular the deprecation of distutils should help nix
some of the lon
Erik Bray added the comment:
To my knowledge this issue is *not* fixed upstream. However, my PR no doubt
needs rebasing.
--
___
Python tracker
<https://bugs.python.org/issue31
Change by Erik Bray :
--
keywords: +patch
nosy: +erik.bray
nosy_count: 1.0 -> 2.0
pull_requests: +27357
stage: -> patch review
pull_request: https://github.com/python/cpython/pull/14013
___
Python tracker
<https://bugs.python.org/i
Change by Erik Bray :
--
pull_requests: +27359
pull_request: https://github.com/python/cpython/pull/4149
___
Python tracker
<https://bugs.python.org/issue45
Change by Erik Bray :
--
pull_requests: +20873
pull_request: https://github.com/python/cpython/pull/21729
___
Python tracker
<https://bugs.python.org/issue20
Erik Bray added the comment:
Indeed, this can be closed.
--
resolution: -> fixed
stage: -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Change by Erik Bray :
--
keywords: +patch
nosy: +erik.bray
nosy_count: 4.0 -> 5.0
pull_requests: +21125
stage: -> patch review
pull_request: https://github.com/python/cpython/pull/21918
___
Python tracker
<https://bugs.python.org/i
Change by Erik Bray :
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Erik Bray added the comment:
This patch works for me, and I'm happy with the syntax. Thanks!
--
___
Python tracker
<http://bugs.python.org/issue11805>
___
___
Erik Bray added the comment:
+1 for the wildcard syntax.
--
___
Python tracker
<http://bugs.python.org/issue14549>
___
___
Python-bugs-list mailing list
Unsub
Erik Bray added the comment:
Potential downside:
Say I have foo, foo.bar, and foo.tests. I want to install foo and foo.bar, but
not foo.tests. Then I have to manually list all the packages I do want:
packages =
foo
foo.bar
That's fine, but one nice thing about find_packag
Erik Bray added the comment:
I vaguely recall seeing some discussion about this on python-dev or elsewhere
and wish I had chimed in sooner, as I didn't realize action was going to be
taken on this so soon.
This completely breaks building extension modules on Windows-based platforms
Change by Erik Bray :
--
pull_requests: +13461
___
Python tracker
<https://bugs.python.org/issue21536>
___
___
Python-bugs-list mailing list
Unsubscribe:
Change by Erik Bray :
--
pull_requests: +13463
___
Python tracker
<https://bugs.python.org/issue21536>
___
___
Python-bugs-list mailing list
Unsubscribe:
Erik Bray added the comment:
Thanks everyone. And FWIW I agree the original change is positive overall, if a
bit presumptuous about different linkers' behaviors :)
--
___
Python tracker
<https://bugs.python.org/is
Erik Bray added the comment:
I think this issue can probably be closed. It refers to a very old version of
Cygwin as well as old versions of Python. I don't have any problem building
the _curses or _io modules on recent versions of Cygwin (>=2.9) and with
current cpython master
Change by Erik Bray :
--
pull_requests: +13877
pull_request: https://github.com/python/cpython/pull/14013
___
Python tracker
<https://bugs.python.org/issue28
Erik Bray added the comment:
FWIW (unsurprisingly) the new test added here is broken on Cygwin, whose libc's
(newlib) behavior in this undefined case. So I get:
>>> from datetime import date
>>> t = date(2005, 1, 1)
>>> t.strftime("%Y"
Erik Bray added the comment:
>> Or we could steal a bit in the opcode encoding or something.
> That seems like a very reasonable and easy-to-implement solution. It > would
> generalize this check:
> https://github.com/python/cpython/blob/e82cf8675bacd7a03de508ed11865
Erik Bray added the comment:
Actually I just finished reading njs's blog post, and as he points out that
special case for SETUP_FINALLY is basically broken. There are other cases
where it doesn't really work either. For example if you have:
if ...:
do_someth
Changes by Erik Bray :
--
pull_requests: +2546
___
Python tracker
<http://bugs.python.org/issue24766>
___
___
Python-bugs-list mailing list
Unsubscribe:
Erik Bray added the comment:
This seems to be fixing a number of different Cygwin issues, many of which are
known (some of these patches come from the Cygwin port of Python). However,
some of these issues are already being handled separately, such as #25658, and
I think rather than one big
New submission from Erik Bray:
The test ctypes.test.test_structures.StructureTestCase.test_pass_by_value fails
on 64-bit Cygwin and MinGW using the system libffi with:
==
FAIL: test_pass_by_value
Changes by Erik Bray :
--
pull_requests: +1656
___
Python tracker
<http://bugs.python.org/issue30353>
___
___
Python-bugs-list mailing list
Unsubscribe:
Erik Bray added the comment:
Thanks for pointing that out. Indeed it's the same symptom, but slightly
different cause. libffi has different implementations of its calling routines
for different architectures/platforms depending on the machine architecture and
calling conventions used
Erik Bray added the comment:
Sure, thanks for pointing that out.
--
___
Python tracker
<http://bugs.python.org/issue30353>
___
___
Python-bugs-list mailin
Changes by Erik Bray :
--
pull_requests: +1760
___
Python tracker
<http://bugs.python.org/issue29804>
___
___
Python-bugs-list mailing list
Unsubscribe:
Erik Bray added the comment:
Iryna, I updated the pull request with a slightly updated fix. Could you
confirm again, when you get a chance, that it works for arm64? Thanks.
--
___
Python tracker
<http://bugs.python.org/issue30
Erik Bray added the comment:
Thanks for checking!
--
___
Python tracker
<http://bugs.python.org/issue30353>
___
___
Python-bugs-list mailing list
Unsubscribe:
Erik Bray added the comment:
Perhaps it would be better if the `xcrun --show-sdk-path` thing were run at
configure-time and its result shoved into a variable we can read with
sysconfig.get_config_var()
--
nosy: +erik.bray
___
Python tracker
Erik Bray added the comment:
Coincidentally I just encountered this myself when trying to activate a venv
created by Python for Windows while in a Cygwin shell. Indeed, bash for Cygwin
is just like bash anywhere else, and considers it a syntax error to encounter
unexpected CR's.
Erik Bray added the comment:
> Users might be better off by not seeing an unhelpful error message when
> passing in a numpy.int32, or they might be worse-off by having lost a cue
> that they were writing inefficient code (which invisibly creates temporary
> integer objects on eve
Erik Bray added the comment:
On Feb 8, 2018 12:55, "Jeroen Demeyer" wrote:
New submission from Jeroen Demeyer :
Displaying the source code in tracebacks for Cython-compiled extension
modules in IPython no longer works due to PEP 302. Various fixes are
possible, the two most obviou
Erik Bray added the comment:
This has a backport PR now for 3.6. Once that PR is merged I think we can
close this as fixed.
--
stage: patch review -> backport needed
versions: +Python 3.6
___
Python tracker
<https://bugs.python.org/issu
Erik Bray added the comment:
I keep forgetting about this (given that it's like 5 years old now). Let me
see if I can make a new PR for it...
--
___
Python tracker
<https://bugs.python.org/is
Erik Bray added the comment:
+1, that seems obvious to me like better behavior.
--
___
Python tracker
<https://bugs.python.org/issue32797>
___
___
Python-bug
New submission from Erik Bray :
I'm trying once again to get the test suite up to snuff on Cygwin so I can
start running a buildbot (particularly now that PEP 539 is done). However, as
of issue28180 the build fails with:
gcc-o python.exe Programs/python.o libpython3.7m.dll.a -lintl
Change by Erik Bray :
--
keywords: +patch
pull_requests: +4097
stage: -> patch review
___
Python tracker
<https://bugs.python.org/issue31877>
___
___
Python-
Change by Erik Bray :
--
pull_requests: +4099
stage: commit review -> patch review
___
Python tracker
<https://bugs.python.org/issue2445>
___
___
Python-
New submission from Erik Bray :
On Cygwin, ioctl() is found in sys/ioctl.h (as on Darwin). Without adding
something to the effect of
#ifdef __CYGWIN__
# include
#endif
the _socket module cannot compile on Cygwin. A fix was this was included in
the (rejected) https://bugs.python.org
Change by Erik Bray :
--
keywords: +patch
pull_requests: +4100
stage: -> patch review
___
Python tracker
<https://bugs.python.org/issue31878>
___
___
Python-
Change by Erik Bray :
--
nosy: +erik.bray
___
Python tracker
<https://bugs.python.org/issue31828>
___
___
Python-bugs-list mailing list
Unsubscribe:
Change by Erik Bray :
--
pull_requests: +4102
___
Python tracker
<https://bugs.python.org/issue16135>
___
___
Python-bugs-list mailing list
Unsubscribe:
Change by Erik Bray :
--
pull_requests: +4113
___
Python tracker
<https://bugs.python.org/issue16135>
___
___
Python-bugs-list mailing list
Unsubscribe:
New submission from Erik Bray :
Some of the tests for asyncio and asyncore block forever on Cygwin, due to a
known (and seemingly difficult to fix) bug [1] in Cygwin involving SO_PEERCRED
on UNIX sockets.
SO_PEERCRED is a socket option that can be used to exchange file ownership info
of the
Change by Erik Bray :
--
keywords: +patch
pull_requests: +4115
stage: -> patch review
___
Python tracker
<https://bugs.python.org/issue31882>
___
___
Python-
New submission from Erik Bray :
There is an acknowledged bug in Cygwin's implementation of wcsxfrm() [1] that
can cause heap corruption in certain cases. This bug has since been fixed in
Cygwin 2.8.1-1 [2] and all current and future releases. However, that was
relatively recent (July
Change by Erik Bray :
--
keywords: +patch
pull_requests: +4116
stage: -> patch review
___
Python tracker
<https://bugs.python.org/issue31883>
___
___
Python-
New submission from Erik Bray :
Like issue31882, this is to mention an upstream bug in Cygwin that causes one
of the tests in the test_socket test suite to hang indefinitely. That bug is
fixed upstream [1], but for now it would still be better to skip the test on
Cygwin.
The bug is that in
Change by Erik Bray :
--
keywords: +patch
pull_requests: +4119
stage: -> patch review
___
Python tracker
<https://bugs.python.org/issue31885>
___
___
Python-
Change by Erik Bray :
--
pull_requests: +4120
stage: -> patch review
___
Python tracker
<https://bugs.python.org/issue4032>
___
___
Python-bugs-list mai
Erik Bray added the comment:
To be clear, are you saying there shouldn't be a workaround to the underlying
issue (I agree), or are you saying the test skip shouldn't even be added? I'm
in favor of just skipping the test since it's still a problem on (currently)
recent
Erik Bray added the comment:
Well, I agree there's an unfortunate trade-off here: One can skip the test,
allowing the test suite to work on slightly older versions of Cygwin, from
before this issue was fixed. However, I then lose regression testing on newer
versions. My personal feeli
Erik Bray added the comment:
Well, we'll see how long it takes me to get them to respond on that. If it's
not too much trouble then I'll be happy to drop this issue.
--
___
Python tracker
<https://bugs.pyt
Change by Erik Bray :
--
pull_requests: +4305
___
Python tracker
<https://bugs.python.org/issue28441>
___
___
Python-bugs-list mailing list
Unsubscribe:
New submission from Erik Bray :
Several of the tests in test_c_locale_coercion (particularly
LocaleCoercionTests._check_c_locale_coercion) tend to assume that the system
default locale used when setting setlocale(category, "") and when all the
relevant environment variables are e
Change by Erik Bray :
--
keywords: +patch
pull_requests: +4316
stage: -> patch review
___
Python tracker
<https://bugs.python.org/issue32002>
___
___
Python-
Erik Bray added the comment:
Yes, I looked at some of the other issues pertaining to this, but it wasn't
immediately apparent how to kill multiple birds with one stone, so here I just
focused on this one assumption.
--
___
Python tracker
&
Erik Bray added the comment:
In my PR there's a behavior test for the default, so we don't have to hard-code
that on a per-platform basis at least. The C != POSIX thing I'm not sure you
can easily test for.
--
___
Python
New submission from Erik Bray :
In Python 2 it was possible to directly manipulate the list of registered
atexit handlers through atexit._exithandlers. Obviously I'm not complaining
that this went away, as it was an underscored attribute. But this possibility
was still useful in the co
New submission from Erik Bray :
This is basically the same as #26939, but rather than Android running in an
emulator it is affecting Cygwin running in a slow VM (in this case it's on my
university's OpenStack infrastructure--I don't know what hypervisor they're
using but
Erik Bray added the comment:
Indeed, this is a duplicate of #28459. I'll also update the existing patch to
a pull request.
--
resolution: -> duplicate
stage: needs patch -> resolved
status: open -> closed
___
Python t
Erik Bray added the comment:
Right, the current patch is really combining several issues. I'll make a PR
from it that just fixes the _pyio issue. I'll also open an issue for fixing
the ctypes bug (this is a patch I've had in my cygwin branch for ages but just
never got aro
Change by Erik Bray :
--
keywords: +patch
pull_requests: +4855
stage: -> patch review
___
Python tracker
<https://bugs.python.org/issue32243>
___
___
Python-
Change by Erik Bray :
--
pull_requests: +4856
stage: -> patch review
___
Python tracker
<https://bugs.python.org/issue23428>
___
___
Python-bugs-list mai
New submission from Erik Bray :
Per Serhiy's comment in this thread
https://mail.python.org/pipermail/python-ideas/2017-December/048413.html (which
I agree with), several of the PyLong_ functions have behavior carried over from
Python 2 of calling __int__ on their arguments if the inp
Erik Bray added the comment:
Per the discussion in https://trac.sagemath.org/ticket/24757, it would also be
nice if some other common iterables like map and filter implemented a similar
__length_hint__ which would interrogate whatever iterables were give as their
argument(s).
To summarize
Erik Bray added the comment:
> Thinking about the generator-iterator case a bit more, "False" would be a bad
> default for that. Allowing "NotImplemented" to indicate the ambiguous "Might
> be finite, might be infinite" state, and using that as the de
Erik Bray added the comment:
I just encountered this as well. The way catch_warnings is implemented is a
bit "dumb" in how it treats _filter_version (it calls _filters_mutated even if
the active filters are not actually changed when entering catch_warnings).
More sig
Erik Bray added the comment:
Yes, I think `catch_warnings` should back up and restore the relevant
`__warningregistry__`. At which point it's not even clear to me what value
there is in the _filter_version...
--
___
Python tracker
&
Erik Bray added the comment:
Yes, it's a dupe. There was enough time after I later made the PR for this
that I forgot I already opened an issue for it.
--
resolution: -> duplicate
stage: patch review -> resolved
status: open -> closed
Erik Bray added the comment:
I originally opened this in https://bugs.python.org/issue29253 but then made a
dupe of my own bug! Anyways, there's a (nearly year old) pull request for it
now.
--
___
Python tracker
<https://bugs.py
New submission from Erik Bray :
This is essentially the same as issue21124, but introduced more recently with
the addition of the _abc_data_type in the _abc module.
The workaround is simply to use PyVarObject_HEAD_INIT(NULL, 0) instead of
PyVarObject_HEAD_INIT(&PyType_Type, 0); PyType_R
Change by Erik Bray :
--
keywords: +patch
pull_requests: +7967
stage: needs patch -> patch review
___
Python tracker
<https://bugs.python.org/issue34211>
___
_
New submission from Erik Bray :
Since issue30860, libpython is no longer able to be linked as a shared library,
because built-in modules are not compiled with the correct external linkage
flags.
This is due to the removal of -DPy_BUILD_CORE, which in pyport.h is used to
control wither
Change by Erik Bray :
--
keywords: +patch
pull_requests: +7968
stage: -> patch review
___
Python tracker
<https://bugs.python.org/issue34212>
___
___
Python-
Erik Bray added the comment:
> For those who are not very aware of Cygwin issues: what is wrong with
>
> PyVarObject_HEAD_INIT(&PyType_Type, 0);
I'm glad you asked, because it actually got me thinking, and since I added a
fix (albeit an unsatisfying one) for issue34212, thi
Erik Bray added the comment:
> What makes functions different from variables? Aren't they essentially just
> pointers?
You're on the right track by noting a difference between functions and data
variables. I can tell you off the bat that when it comes to data imported
Erik Bray added the comment:
Brett:
> As Nick said, we have no generalized concept of source maps and I think
coming up with that is what will be required to solve this as i personally
don't view Loader.get_source() is not meant to be a generalized concept of
some form of source
Erik Bray added the comment:
To add, while an enhancement just to linecache would make sense in its own
right, I don't see the problem with also extending the Loader.get_source() API
to be more useful as well. Its current behavior is to just return a string (or
None), but it seems
Erik Bray added the comment:
> To do that, I believe it can be made to work in much the same way it did in
> Python 2 if SageMath were to do the following:
>
> 1. Define a subclass of ExtensionModuleLoader [1] that overrides get_source()
> to also look for a ".pyx&q
Change by Erik Bray :
--
pull_requests: +8199
___
Python tracker
<https://bugs.python.org/issue34212>
___
___
Python-bugs-list mailing list
Unsubscribe:
Erik Bray added the comment:
I added a new PR modifying makesetup and adding a new variable to
Makefile.pre.in, PY_BUILTIN_MODULE_CFLAGS, explicitly for building built-in
modules.
I think this, or some version of it, is a cleaner solution than my previous
brute-force approach
1 - 100 of 179 matches
Mail list logo
