Change by Eric Snow :
--
nosy: +steve.dower
___
Python tracker
<https://bugs.python.org/issue37316>
___
___
Python-bugs-list mailing list
Unsubscribe:
Eric Snow added the comment:
FWIW, performance benefits when subinterpreters stop sharing the GIL are not
the only benefit. In fact, PEP 554 is specifically written to avoid that
consideration, focusing on the benefits of the concurrency model (i.e. CSP).
So I wouldn't call this poin
Eric Snow added the comment:
@Davin, we've spoken before about something similar for multiprocessing, IIRC.
:)
--
nosy: +davin
___
Python tracker
<https://bugs.python.org/is
Eric Snow added the comment:
Thanks, Carl Bordum Hansen!
--
nosy: +eric.snow
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Eric Snow added the comment:
Note that in Python 3.7 we consolidated a bunch of the global runtime state.
The "main_thread" static in ceval.c moved to the internal struct
_PyRuntimestate and in 3.7 it is accessible as
_Runtime.ceval.pending.main_thread (but only if you
Eric Snow added the comment:
FWIW, this might also have implications for thread shutdown during
runtime/interpreter finalization.
--
nosy: +vstinner
___
Python tracker
<https://bugs.python.org/issue37
New submission from Eric Snow :
In early 2014 (3.3), when argument clinic was added, we added support for
turning func.__text_signature__ into an inspect.Signature object. However, at
that time we did not add support for annotations (see the nested "parse_name()"
in _signatu
New submission from Eric Snow :
In early 2014 (3.3), when argument clinic was added, we added support for
turning func.__text_signature__ into an inspect.Signature object. However, the
functionality to convert a string into a Signature was never exposed publicly.
Here's a patch to
Eric Snow added the comment:
Note that there has been a little discussion of this in the past, particularly
around the time that argument clinic was introduced:
https://bugs.python.org/issue23967#msg241140.
--
___
Python tracker
<ht
New submission from Eric Snow :
When writing an importer, the finder (either MetaPathFinder or PathEntryFinder)
must implement `find_spec()`. A useful tool for that is the existing
`spec_from_loader()`. [1] The docs for `MetaPathFinder.find_spec()` and
`PathEntryFinder.find_spec()` should
Change by Eric Snow :
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Eric Snow added the comment:
@potomak, thanks for doing this!
--
___
Python tracker
<https://bugs.python.org/issue37284>
___
___
Python-bugs-list mailin
Eric Snow added the comment:
Sorry, @Batuhan. We appreciate your effort and would be glad to see more
contributions from you. I hope you at least learned something positive while
working on this. :)
--
___
Python tracker
<ht
Eric Snow added the comment:
Hmm, looks like this was already fixed by Serhiy (for bpo-35454) the day before
I opened this issue. :)
3.8/master: GH-11077 8905fcc85a6fc3ac394bc89b0bbf40897e9497a6
3.7: GH-11105 62674f3a36ec55f86a5f20ee028a37fbd549bd6c
3.6: GH-11106
Eric Snow added the comment:
+1 on using a string for Parameter.annotation and Signature.return_annotation.
--
___
Python tracker
<https://bugs.python.org/issue37
Eric Snow added the comment:
FTR, Antoine originally removed in b43c4caf81b10e5c7ebaeb3a712c6db584f60bbd and
added back (but deprecated) a few days later in
b43c4caf81b10e5c7ebaeb3a712c6db584f60bbd. [1] That happened in September 2017
for Python 3.7.
[1] https://bugs.python.org
Eric Snow added the comment:
New changeset 854d0a4b98b13629252e21edaf2b785b429e5135 by Eric Snow (Joannah
Nanjekye) in branch 'master':
bpo-36487: Make C-API docs clear about what the main interpreter is. (gh-12666)
https://github.com/python/cpyt
Eric Snow added the comment:
Thanks, Joannah!
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
versions: +Python 3.9
___
Python tracker
<https://bugs.python.or
Eric Snow added the comment:
New changeset 375f35be0688da0fc0f27afc4faea76590d7c24d by Eric Snow (Miss
Islington (bot)) in branch '3.8':
bpo-36487: Make C-API docs clear about what the main interpreter is. (gh-15080)
https://github.com/python/cpyt
New submission from Eric Snow:
CPython's C code makes extensive use of global variables. The globals fall
into one of several categories:
* (effectively) constants (incl. static types)
* freelists, caches, and counters
* used exclusively in main or in REPL
* process-global state
* m
Changes by Eric Snow :
--
pull_requests: +2665
___
Python tracker
<http://bugs.python.org/issue30860>
___
___
Python-bugs-list mailing list
Unsubscribe:
Eric Snow added the comment:
One thing I'd like to also try is to use a freelist embedded in _PyRuntimeState
for the PyInterpreterState and PyThreadState linked lists.
--
___
Python tracker
<http://bugs.python.org/is
Changes by Eric Snow :
--
nosy: +eric.snow
___
Python tracker
<http://bugs.python.org/issue1644818>
___
___
Python-bugs-list mailing list
Unsubscribe:
Eric Snow added the comment:
On Thu, Aug 31, 2017 at 1:32 PM, Brett Cannon wrote:
> I think throwing a TypeError is valid if it's triggering an assertion error
> that is already there.
+1
> P.S. Thanks for all the fuzz testing you're doing, O
Eric Snow added the comment:
Hmm. What problems are you seeing with deep copies? copy.deepcopy() should
work since SimpleNamespace is picklable. [1][2] I don't have any problems:
>>> import types, copy
>>> ns = types.SimpleNamespace(x=1, y=2)
>>> copie
Eric Snow added the comment:
> This mostly influences the Python interpreter start-up time
> (because of extensive use of ABCs in importlib)
Just to be clear, the only ABCs in importlib are in importlib.abc (and used by
importlib.util). This does not impact interpreter s
Eric Snow added the comment:
> For now, this proposal is on hold because
> 1) it isn't clear that it should be done,
> 2) it needs a lot of serious discussion before proceeding,
> 3) it may be premature while the status of the regular dict
> is still in flux.
+1
Eric Snow added the comment:
We're dropping PyInterpreterState.modules (#28411).
--
resolution: -> wont fix
stage: -> resolved
status: open -> closed
superseder: -> Eliminate PyInterpreterState.modules.
___
Python tracker
<ht
Eric Snow added the comment:
New changeset 86b7afdfeee77993fe896a2aa13b3f4f95973f16 by Eric Snow in branch
'master':
bpo-28411: Remove "modules" field from Py_InterpreterState. (#1638)
https://github.com/python/cpython/commit/86b7afdfeee77993fe89
Changes by Eric Snow :
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<http://bugs.python.or
Eric Snow added the comment:
New changeset 76d5abc8684bac4f2fc7cccfe2cd940923357351 by Eric Snow in branch
'master':
bpo-30860: Consolidate stateful runtime globals. (#2594)
https://github.com/python/cpython/commit/76d5abc8684bac4f2fc7cccfe2cd94
Changes by Eric Snow :
--
pull_requests: +3387
___
Python tracker
<http://bugs.python.org/issue30860>
___
___
Python-bugs-list mailing list
Unsubscribe:
Changes by Eric Snow :
--
pull_requests: +3388
___
Python tracker
<http://bugs.python.org/issue30860>
___
___
Python-bugs-list mailing list
Unsubscribe:
Changes by Eric Snow :
--
pull_requests: -3387
___
Python tracker
<http://bugs.python.org/issue30860>
___
___
Python-bugs-list mailing list
Unsubscribe:
Eric Snow added the comment:
New changeset 05351c1bd8b70d1878527762174cdaaba3572395 by Eric Snow in branch
'master':
Revert "bpo-30860: Consolidate stateful runtime globals." (#3379)
https://github.com/python/cpython/commit/05351c1bd8b70d187852
Changes by Eric Snow :
--
pull_requests: +3403
___
Python tracker
<http://bugs.python.org/issue30860>
___
___
Python-bugs-list mailing list
Unsubscribe:
New submission from Eric Snow:
This builds on issue #30439.
--
assignee: eric.snow
messages: 301540
nosy: eric.snow
priority: normal
severity: normal
stage: needs patch
status: open
title: Add the interpreters module to stdlib (PEP 554).
type: enhancement
versions: Python 3.7
Eric Snow added the comment:
New changeset 2ebc5ce42a8a9e047e790aefbf9a94811569b2b6 by Eric Snow in branch
'master':
bpo-30860: Consolidate stateful runtime globals. (#3397)
https://github.com/python/cpython/commit/2ebc5ce42a8a9e047e790aefbf9a94
Changes by Eric Snow :
--
keywords: +patch
pull_requests: +3452
___
Python tracker
<https://bugs.python.org/issue30860>
___
___
Python-bugs-list mailing list
Unsub
Eric Snow added the comment:
FYI, the merged code introduced a bunch of new warnings on Windows. I'm
looking into it.
--
___
Python tracker
<https://bugs.python.org/is
Eric Snow added the comment:
The gmane link isn't working for me. Here's the mailing list archive thread:
https://mail.python.org/pipermail/python-dev/2014-November/thread.html#137262
https://mail.python.org/pipermail/python-dev/2014-December/thread.h
Changes by Eric Snow :
--
nosy: +eric.snow
___
Python tracker
<https://bugs.python.org/issue31420>
___
___
Python-bugs-list mailing list
Unsubscribe:
Eric Snow added the comment:
I'm looking into this.
--
___
Python tracker
<https://bugs.python.org/issue31420>
___
___
Python-bugs-list mailing list
Unsubscr
Changes by Eric Snow :
--
assignee: -> eric.snow
___
Python tracker
<https://bugs.python.org/issue31420>
___
___
Python-bugs-list mailing list
Unsubscrib
Eric Snow added the comment:
Moving warnoptions (and xoptions) out of PyInterpreterState seems like a good
idea to me for the same reasons as applied to sys.modules. The case for these
two is even stronger since they are only used in sysmodule.c
Changes by Eric Snow :
--
pull_requests: +3499
___
Python tracker
<https://bugs.python.org/issue30860>
___
___
Python-bugs-list mailing list
Unsubscribe:
Changes by Eric Snow :
--
keywords: +patch
pull_requests: +3500
stage: -> patch review
___
Python tracker
<https://bugs.python.org/issue31420>
___
___
Python-
Eric Snow added the comment:
@skrah, could you see if the PR for issue #31420 resolves this? I'm guessing
it won't, but you indicated that the two issues might be related. Thanks!
--
___
Python tracker
<https://bugs.python.o
Eric Snow added the comment:
I'm looking into this.
--
assignee: -> eric.snow
___
Python tracker
<https://bugs.python.org/issue31407>
___
___
Python-bug
Changes by Eric Snow :
--
pull_requests: +3501
___
Python tracker
<https://bugs.python.org/issue30860>
___
___
Python-bugs-list mailing list
Unsubscribe:
Changes by Eric Snow :
--
keywords: +patch
pull_requests: +3502
stage: needs patch -> patch review
___
Python tracker
<https://bugs.python.org/issue31407>
___
_
Eric Snow added the comment:
I've verified that the PR fixes the problem.
--
___
Python tracker
<https://bugs.python.org/issue31407>
___
___
Python-bugs-l
Eric Snow added the comment:
I'm looking into this.
--
assignee: -> eric.snow
___
Python tracker
<https://bugs.python.org/issue31404>
___
___
Python-bug
Eric Snow added the comment:
New changeset ba6d5d1defd7a281c8c8804e4b4cfd7370886236 by Eric Snow in branch
'master':
bpo-30860: Always provide serialno. (#3507)
https://github.com/python/cpython/commit/ba6d5d1defd7a281c8c8804e4b4cfd
Changes by Eric Snow :
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Eric Snow added the comment:
New changeset ba6d5d1defd7a281c8c8804e4b4cfd7370886236 by Eric Snow in branch
'master':
bpo-30860: Always provide serialno. (#3507)
https://github.com/python/cpython/commit/ba6d5d1defd7a281c8c8804e4b4cfd
Changes by Eric Snow :
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Eric Snow added the comment:
On Sun, Sep 10, 2017 at 10:27 PM, Serhiy Storchaka
wrote:
> Note that mixed insertion and deletion is worst-case O(n) in current
> implementation.
Could you elaborate? Note that every operation of the current
implementation matches the complexity of the
Eric Snow added the comment:
New changeset fc1bf872e9d31f3e837f686210f94e57ad3d6582 by Eric Snow in branch
'master':
bpo-30860: Move windows.h include out of internal/*.h. (#3458)
https://github.com/python/cpython/commit/fc1bf872e9d31f3e837f686210f94e
Eric Snow added the comment:
This is pretty messy. :( Ideally we would disallow setting sys.modules to
anything except a dict (or perhaps any mapping). However, we don't have that
option currently (see
https://github.com/ericsnowcurrently/cpython/tree/sys-module). In the meantime
we
Eric Snow added the comment:
> It means rebuilding hash table to clean up dummy entries.
> So, even when dict size is not increasing, remove + insert loop has
> worst case O(n), amortized O(1) complexity.
Ah, so it matches the pure Python implementa
Eric Snow added the comment:
> I haven't finished reviewing PR 1638. I'm not sure that this change
> is worth. It breaks a code that assumes that sys.module is a dict,
> and I afraid it slows down importing. Maybe revert this change until
> resolving all problems?
Yeah
Eric Snow added the comment:
FYI, this broke some (very) corner cases. See issue #31404.
--
___
Python tracker
<https://bugs.python.org/issue28411>
___
___
Pytho
Changes by Eric Snow :
--
keywords: +patch
pull_requests: +3554
stage: -> patch review
___
Python tracker
<https://bugs.python.org/issue31404>
___
___
Python-
Changes by Eric Snow :
--
pull_requests: +3555
___
Python tracker
<https://bugs.python.org/issue28411>
___
___
Python-bugs-list mailing list
Unsubscribe:
Eric Snow added the comment:
We're reverting this (see #31404), so back to the drawing board...
--
resolution: fixed ->
stage: resolved -> needs patch
status: closed -> open
___
Python tracker
<https://bugs.pyth
Eric Snow added the comment:
New changeset 93c92f7d1dbb6e7e472f1d0444c6968858113de2 by Eric Snow in branch
'master':
bpo-31404: Revert "remove modules from Py_InterpreterState (#1638)" (#3565)
https://github.com/python/cpython/commit/93c92f7d1dbb6e7e472f
Eric Snow added the comment:
New changeset 93c92f7d1dbb6e7e472f1d0444c6968858113de2 by Eric Snow in branch
'master':
bpo-31404: Revert "remove modules from Py_InterpreterState (#1638)" (#3565)
https://github.com/python/cpython/commit/93c92f7d1dbb6e7e472f
Changes by Eric Snow :
--
pull_requests: +3557
___
Python tracker
<https://bugs.python.org/issue31420>
___
___
Python-bugs-list mailing list
Unsubscribe:
Changes by Eric Snow :
--
pull_requests: +3556
___
Python tracker
<https://bugs.python.org/issue30860>
___
___
Python-bugs-list mailing list
Unsubscribe:
Eric Snow added the comment:
New changeset dae0276bb6bc7281d59fb0b8f1aab31634ee80dc by Eric Snow in branch
'master':
bpo-30860: Fix a refleak. (#3567)
https://github.com/python/cpython/commit/dae0276bb6bc7281d59fb0b8f1aab31634ee80dc
--
Eric Snow added the comment:
New changeset dae0276bb6bc7281d59fb0b8f1aab31634ee80dc by Eric Snow in branch
'master':
bpo-30860: Fix a refleak. (#3567)
https://github.com/python/cpython/commit/dae0276bb6bc7281d59fb0b8f1aab31634ee80dc
--
Changes by Eric Snow :
--
pull_requests: +3566
stage: needs patch -> patch review
___
Python tracker
<https://bugs.python.org/issue28411>
___
___
Python-
Eric Snow added the comment:
New changeset d393c1b227f22fb9af66040b2b367c99a4d1fa9a by Eric Snow in branch
'master':
bpo-28411: Isolate PyInterpreterState.modules (#3575)
https://github.com/python/cpython/commit/d393c1b227f22fb9af66040b2b367c
Changes by Eric Snow :
--
pull_requests: +3584
___
Python tracker
<https://bugs.python.org/issue28411>
___
___
Python-bugs-list mailing list
Unsubscribe:
Changes by Eric Snow :
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Eric Snow added the comment:
New changeset 3f9eee6eb4b25fe1926eaa5f00e02344b126f54d by Eric Snow in branch
'master':
bpo-28411: Support other mappings in PyInterpreterState.modules. (#3593)
https://github.com/python/cpython/commit/3f9eee6eb4b25fe1926eaa5f00e023
Changes by Eric Snow :
--
pull_requests: +3596
___
Python tracker
<https://bugs.python.org/issue28411>
___
___
Python-bugs-list mailing list
Unsubscribe:
Changes by Eric Snow :
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Changes by Eric Snow :
--
pull_requests: +3597
___
Python tracker
<https://bugs.python.org/issue31404>
___
___
Python-bugs-list mailing list
Unsubscribe:
Change by Eric Snow :
--
nosy: +petr.viktorin
___
Python tracker
<https://bugs.python.org/issue35420>
___
___
Python-bugs-list mailing list
Unsubscribe:
New submission from Eric Snow :
For a while now the signal handling machinery has piggy-backed on ceval's
"pending calls" machinery (e.g. Py_AddPendingCall). This is a bit confusing.
It also increases the risk with unrelated changes to the pending calls code.
--
assi
Change by Eric Snow :
--
keywords: +patch
pull_requests: +10214
stage: needs patch -> patch review
___
Python tracker
<https://bugs.python.org/issu
Eric Snow added the comment:
Correct. The remaining call to Py_AddPendingCall in the signal-handling code
is fine.
This issue is only indirectly related. I suppose you could consider it a
follow-up to #30703. The PR for that issue (GH-2415) switches from using
pending calls for signal
New submission from Eric Snow :
Currently the list of pending calls (see Include/internal/pycore_ceval.h) is
implemented as a circular buffer. A linked list would be easier to understand
and modify. It also allows for removing the restriction on the number of
pending calls
Change by Eric Snow :
--
pull_requests: +10353
___
Python tracker
<https://bugs.python.org/issue35446>
___
___
Python-bugs-list mailing list
Unsubscribe:
Change by Eric Snow :
--
keywords: +patch
pull_requests: +10354
stage: needs patch -> patch review
___
Python tracker
<https://bugs.python.org/issu
Change by Eric Snow :
--
pull_requests: -10353
___
Python tracker
<https://bugs.python.org/issue35446>
___
___
Python-bugs-list mailing list
Unsubscribe:
Eric Snow added the comment:
I suppose performance could have been a motivator originally. However, I don't
see a benefit now that signals handlers are no longer pending calls. If it's a
real problem then we can leverage a free list.
As to complexity, the motivator for this
Change by Eric Snow :
--
nosy: +emilyemorehouse
___
Python tracker
<https://bugs.python.org/issue35423>
___
___
Python-bugs-list mailing list
Unsubscribe:
New submission from Eric Snow :
In the C-API documentation the entry for PyImport_AddModuleObject[1] does not
indicate that it returns a borrowed reference.
[1] https://docs.python.org/3/c-api/import.html#c.PyImport_AddModuleObject
--
assignee: docs@python
components: Documentation
New submission from Eric Snow :
In _imp_create_dynamic_impl() [1] the case where
_PyImport_FindExtensionObject() returns NULL may leave an error set. Either
the error should be raised (like _imp_create_builtin() does) or it should be
cleared (via PyErr_Clear()).
--
components
Change by Eric Snow :
--
nosy: +eric.snow
type: -> behavior
versions: +Python 3.6
___
Python tracker
<https://bugs.python.org/issue35470>
___
___
Python-
Change by Eric Snow :
--
nosy: +barry, brett.cannon
___
Python tracker
<https://bugs.python.org/issue35526>
___
___
Python-bugs-list mailing list
Unsubscribe:
Change by Eric Snow :
--
nosy: +eric.snow
___
Python tracker
<https://bugs.python.org/issue34522>
___
___
Python-bugs-list mailing list
Unsubscribe:
Change by Eric Snow :
--
nosy: +eric.snow
___
Python tracker
<https://bugs.python.org/issue35381>
___
___
Python-bugs-list mailing list
Unsubscribe:
Eric Snow added the comment:
New changeset a909460a09cca79bd051c45b02e650862a57dbd9 by Eric Snow (Michael
Felt) in branch 'master':
bpo-34569: Fix subinterpreter 32-bit ABI, pystate.c/_new_long_object()
(gh-9127)
https://github.com/python/cpyt
Eric Snow added the comment:
Thanks, Michael.
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
New submission from Eric Snow :
The code in Modules/signalsmodule.c (as well as a few other places in the code)
has a concept of a "main" thread. It's the OS thread where Py_Initialize() was
called (and likely the process's original thread). For various good reasons,
w
Eric Snow added the comment:
New changeset fdf282d609fd172d52b59a6f1f062eb701494528 by Eric Snow in branch
'master':
bpo-35423: Stop using the "pending calls" machinery for signals. (gh-10972)
https://github.com/python/cpython/commit/fdf282d609fd172d52b5
801 - 900 of 2629 matches
Mail list logo