Changes by Eric Snow :
Removed file: http://bugs.python.org/file40126/odict-correct-resize.diff
___
Python tracker
<http://bugs.python.org/issue24667>
___
___
Python-bug
Changes by Eric Snow :
--
nosy: +brett.cannon, eric.snow, gregory.p.smith, ncoghlan, superluser, twouters
___
Python tracker
<http://bugs.python.org/issue24
Changes by Eric Snow :
--
nosy: +gregory.p.smith, superluser, twouters
___
Python tracker
<http://bugs.python.org/issue19699>
___
___
Python-bugs-list mailin
Changes by Eric Snow :
--
nosy: +brett.cannon, eric.snow, ncoghlan, superluser
versions: +Python 3.6 -Python 3.5
___
Python tracker
<http://bugs.python.org/issue23
Changes by Eric Snow :
--
versions: +Python 3.5, Python 3.6
___
Python tracker
<http://bugs.python.org/issue24792>
___
___
Python-bugs-list mailing list
Unsub
Changes by Eric Snow :
--
nosy: +eric.snow, superluser
___
Python tracker
<http://bugs.python.org/issue23327>
___
___
Python-bugs-list mailing list
Unsubscribe:
Changes by Eric Snow :
--
nosy: +superluser
versions: +Python 3.6 -Python 3.4
___
Python tracker
<http://bugs.python.org/issue5950>
___
___
Python-bugs-list mailin
Changes by Eric Snow :
--
versions: +Python 3.6
___
Python tracker
<http://bugs.python.org/issue19883>
___
___
Python-bugs-list mailing list
Unsubscribe:
Changes by Eric Snow :
--
versions: +Python 3.6 -Python 3.5
___
Python tracker
<http://bugs.python.org/issue19699>
___
___
Python-bugs-list mailing list
Unsub
Changes by Eric Snow :
--
nosy: +eric.snow, superluser
___
Python tracker
<http://bugs.python.org/issue19883>
___
___
Python-bugs-list mailing list
Unsubscribe:
Changes by Eric Snow :
--
type: crash -> behavior
versions: +Python 3.5, Python 3.6
___
Python tracker
<http://bugs.python.org/issue23327>
___
___
Python-
Changes by Eric Snow :
--
nosy: +superluser
___
Python tracker
<http://bugs.python.org/issue21062>
___
___
Python-bugs-list mailing list
Unsubscribe:
Changes by Eric Snow :
--
nosy: +gregory.p.smith, superluser
versions: +Python 3.6 -Python 3.4
___
Python tracker
<http://bugs.python.org/issue17004>
___
___
Pytho
Changes by Eric Snow :
--
nosy: +gregory.p.smith, superluser
versions: +Python 3.6 -Python 3.5
___
Python tracker
<http://bugs.python.org/issue1116520>
___
___
Changes by Eric Snow :
--
nosy: +superluser
versions: +Python 3.6 -Python 3.3
___
Python tracker
<http://bugs.python.org/issue19081>
___
___
Python-bugs-list m
Changes by Eric Snow :
--
nosy: +superluser
versions: +Python 3.6 -Python 3.3
___
Python tracker
<http://bugs.python.org/issue14678>
___
___
Python-bugs-list m
Changes by Eric Snow :
--
nosy: +superluser
versions: +Python 3.6 -Python 3.4
___
Python tracker
<http://bugs.python.org/issue16651>
___
___
Python-bugs-list m
Changes by Eric Snow :
--
nosy: +brett.cannon, gregory.p.smith, superluser
stage: -> patch review
versions: +Python 3.6 -Python 3.4
___
Python tracker
<http://bugs.python.org/issu
Changes by Eric Snow :
--
versions: +Python 3.4, Python 3.5, Python 3.6 -Python 3.2
___
Python tracker
<http://bugs.python.org/issue8400>
___
___
Python-bug
Changes by Eric Snow :
--
nosy: +brett.cannon, gregory.p.smith, superluser
___
Python tracker
<http://bugs.python.org/issue8400>
___
___
Python-bugs-list mailin
Changes by Eric Snow :
--
stage: -> patch review
type: -> behavior
___
Python tracker
<http://bugs.python.org/issue17633>
___
___
Python-bugs-list
Changes by Eric Snow :
--
nosy: +superluser
versions: +Python 3.6 -Python 3.3, Python 3.4
___
Python tracker
<http://bugs.python.org/issue14905>
___
___
Python-bug
Changes by Eric Snow :
--
nosy: +gregory.p.smith, superluser
versions: +Python 3.6 -Python 3.5
___
Python tracker
<http://bugs.python.org/issue17633>
___
___
Pytho
Changes by Eric Snow :
--
nosy: +gregory.p.smith
___
Python tracker
<http://bugs.python.org/issue14905>
___
___
Python-bugs-list mailing list
Unsubscribe:
Eric Snow added the comment:
Fair enough.
--
resolution: -> not a bug
stage: needs patch -> resolved
status: open -> closed
___
Python tracker
<http://bugs.python.or
Eric Snow added the comment:
@Fabian, hey, thanks for bringing it to our attention!
--
___
Python tracker
<http://bugs.python.org/issue24667>
___
___
Python-bug
Eric Snow added the comment:
If I don't get any feedback before then, I'll commit the patch on Friday.
--
___
Python tracker
<http://bugs.python.o
Eric Snow added the comment:
That's good to know. Thanks.
--
___
Python tracker
<http://bugs.python.org/issue24667>
___
___
Python-bugs-list mailing list
Eric Snow added the comment:
I've pushed the fix for RC1. Thanks again Fabian for bringing it to our
attention.
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<http://bugs.pyth
Eric Snow added the comment:
> Yeah, I stopped it at 300k iterations. No problems. Glad this fix got
in for rc1.
Thanks for the double-check, Larry. I'd done similar testing, though not
as exhaustively. :) Getting a fix in for RC1 was pretty important to me.
It stretched me a bit, b
Eric Snow added the comment:
patch LGTM. Presumably the divergence between importlib (in _handle_fromlist)
and import.c was strictly accidental (i.e. lack of test coverage).
--
stage: patch review -> commit review
___
Python tracker
&l
Eric Snow added the comment:
Looks fine to me. Nick had suggested calling exec_builtin from exec_dynamic
(to the same effect as your patch), but I don't consider that much of an issue.
:)
--
stage: -> commit review
___
Python tracke
Changes by Eric Snow :
--
nosy: +eric.snow
___
Python tracker
<http://bugs.python.org/issue24846>
___
___
Python-bugs-list mailing list
Unsubscribe:
Eric Snow added the comment:
This sort of thread belongs on python-id...@python.org, not on the tracker.
Please post there (feel free to reference this issue; also add a link to the
thread here). TBH, I think there's a larger discussion to be had regarding the
topic of other u
Eric Snow added the comment:
That said...
What's the benefit of it being a decorator? The docstring? Access to
func.__name__? It could just as well be:
class attribute:
_name = None
def __get__(self, instance, owner):
if instance is
Eric Snow added the comment:
No worries, Emanuel. Thanks for bringing it up. I'd still be interested to
see what sort discussion ensued if you took this to python-ideas. Starting a
thread on the topic has been on my todo list for a while but other matters
always end up taking prece
Eric Snow added the comment:
"Hybrid Nathaniel/Brett approach" LGTM
--
___
Python tracker
<http://bugs.python.org/issue24305>
___
___
Python-bugs-l
Eric Snow added the comment:
I've posted a counter-proposal on python-ideas:
https://mail.python.org/pipermail/python-ideas/2015-August/035614.html
Basically: instead of "classproperty", add a more lenient alternative to
classmethod which allows composition. I called it
Eric Snow added the comment:
I also posted a broader proposal:
https://mail.python.org/pipermail/python-ideas/2015-August/035615.html
--
___
Python tracker
<http://bugs.python.org/issue24
Eric Snow added the comment:
Doesn't the fix mean that `vars(MyNamedtuple)` will no longer work? While I
personally don't mind (though I prefer that spelling) and appreciate the
benefit of simpler code, isn't there a backward-compatibility issue here?
I do concede that
Eric Snow added the comment:
Thanks for taking care of this, Victor (and Serhiy). :)
--
stage: -> resolved
type: -> behavior
___
Python tracker
<http://bugs.python.org/i
Eric Snow added the comment:
Yeah, this definitely relates to the project I'm working on.
--
___
Python tracker
<http://bugs.python.org/issue24991>
___
___
Eric Snow added the comment:
While I recognize the practicality/purity argument here, I somewhat agree with
Mark. Assigning to module.__class__ makes sense for the use case, but it does
open up a number of negative possible side effects (e.g. changing
sys.__class__). Ideally it would be
Eric Snow added the comment:
OrderedDict has a C implementation now. So try the following:
try:
from _collections import OrderedDict
except ImportError:
from collections import OrderedDict
--
nosy: +eric.snow
___
Python tracker
<h
Eric Snow added the comment:
I'm fairly sure this was just an oversight on my part.
--
___
Python tracker
<http://bugs.python.org/issue25186>
___
___
Pytho
New submission from Eric Snow:
(a generalization of issue #21335)
One way or another, we should be able to record the appropriate path in the
resulting data when a module is frozen. Keeping track of the source location
is useful when debugging, especially with tracebacks. Also see a related
Eric Snow added the comment:
The underlying issue extends to all frozen modules. I've opened #25268 to
consider how we might address it.
--
nosy: +eric.snow
___
Python tracker
<http://bugs.python.org/is
Changes by Eric Snow :
--
nosy: +lemburg
___
Python tracker
<http://bugs.python.org/issue25268>
___
___
Python-bugs-list mailing list
Unsubscribe:
Changes by Eric Snow :
--
nosy: +eric.snow
___
Python tracker
<http://bugs.python.org/issue12238>
___
___
Python-bugs-list mailing list
Unsubscribe:
Changes by Eric Snow :
--
assignee: -> serhiy.storchaka
___
Python tracker
<http://bugs.python.org/issue25406>
___
___
Python-bugs-list mailing list
Unsubscrib
Eric Snow added the comment:
@Serhiy, patch LGTM. Thanks for taking care of it.
--
stage: patch review -> commit review
___
Python tracker
<http://bugs.python.org/issu
Eric Snow added the comment:
Thanks for working on this, Serhiy. I've left a review.
As to the points you outlined, I have concerns with the impact of #3 and #5 on
subclasses. Notably od.__class__ is not necessarily the same as type(od).
Also #7 may introduce an unhandled re-ent
Eric Snow added the comment:
Regarding Py_TYPE(od) vs. od.__class__, there is a difference for subclasses,
as you demonstrated in your example. [1] Thanks for explaining your rationale.
I now understand your argument about using PyTYPE() for repr and pickle in C
types. I still have
Eric Snow added the comment:
Regarding #5, you're right about OrderedDict().__dict__ being empty for the C
implementation. (Nice observation!) So I'm okay with ripping all that code
out of odict_reduce(). Since we're still accessing od.__dict__ through
_PyObject_GetAttrId()
Eric Snow added the comment:
Regarding #7, I see what you did now. That looks fine to me.
--
___
Python tracker
<http://bugs.python.org/issue25410>
___
___
Pytho
Eric Snow added the comment:
new patch LGTM
--
___
Python tracker
<http://bugs.python.org/issue25410>
___
___
Python-bugs-list mailing list
Unsubscribe:
Eric Snow added the comment:
> Backward compatibility related to __class__ assignment was already broken in C
> implementation. In 3.4 following code works:
[snip]
> In 3.5 it doesn't.
Depending on what feedback we get from python-dev, that may need to be
fixed. I'd be in
Eric Snow added the comment:
Posted to python-dev:
https://mail.python.org/pipermail/python-dev/2015-October/141953.html
https://mail.python.org/pipermail/python-dev/2015-October/141954.html
--
stage: patch review -> commit review
___
Pyt
Eric Snow added the comment:
both patches* LGTM
* odict_type.patch and odict_add_new_node_leak.patch
--
___
Python tracker
<http://bugs.python.org/issue25
Eric Snow added the comment:
And thanks again, Serhiy, for taking the time on this. :)
--
___
Python tracker
<http://bugs.python.org/issue25410>
___
___
Python-bug
Eric Snow added the comment:
Thanks for solving this!
odict-trashcan.v3.patch LGTM
--
stage: patch review -> commit review
___
Python tracker
<http://bugs.python.org/issu
Eric Snow added the comment:
Since the python-dev discussion about __class__, leaving the Python
implementation alone is fine with me.
--
stage: patch review -> commit review
___
Python tracker
<http://bugs.python.org/issu
Eric Snow added the comment:
LGTM as long as you also add PurePythonOrderedDictSubclassTests to match
CPythonOrderedDictSubclassTests (per PEP 399).
--
nosy: +eric.snow
stage: -> commit review
___
Python tracker
<http://bugs.python.org/issu
Eric Snow added the comment:
Regarding dict.__setitem__, see issue #24726. Raymond outlined what needs to
be fixed.
--
___
Python tracker
<http://bugs.python.org/issue25
Changes by Eric Snow :
--
stage: commit review -> patch review
___
Python tracker
<http://bugs.python.org/issue25449>
___
___
Python-bugs-list mailing list
Un
Eric Snow added the comment:
FTR, this will likely involve more than just fixing odict_repr().
--
___
Python tracker
<http://bugs.python.org/issue24726>
___
___
Eric Snow added the comment:
Review posted. Aside from a couple minor comments, LGTM. Thanks for doing this.
Incidentally, it should be possible to auto-detect independent changes to the
underlying dict and sync the odict with those changes. However, doing so
likely isn't wor
Eric Snow added the comment:
I will review those patches soon.
--
___
Python tracker
<http://bugs.python.org/issue25410>
___
___
Python-bugs-list mailin
Eric Snow added the comment:
All 3 patches look fine to me.
In "odict_resize_sentinel.patch", it would be nice if you could accomplish that
with a single sentinel. However, fixing the bug is more critical.
--
___
Python trac
Changes by Eric Snow :
--
stage: patch review -> commit review
___
Python tracker
<http://bugs.python.org/issue25410>
___
___
Python-bugs-list mailing list
Un
Eric Snow added the comment:
I agree with Raymond.
--
stage: patch review -> commit review
___
Python tracker
<http://bugs.python.org/issue25462>
___
___
Py
Eric Snow added the comment:
FWIW, I totally support this. I originally had a patch up that did so but
Raymond indicated that he'd rather not split the tests out though I made
exactly the same arguments that you have. Perhaps he's changed his mind in the
intervening y
Eric Snow added the comment:
I agree with Raymond.
--
___
Python tracker
<http://bugs.python.org/issue25623>
___
___
Python-bugs-list mailing list
Unsubscribe:
Changes by Eric Snow :
--
nosy: +eric.snow, superluser
___
Python tracker
<http://bugs.python.org/issue25711>
___
___
Python-bugs-list mailing list
Unsubscribe:
Changes by Eric Snow :
--
nosy: +superluser
___
Python tracker
<http://bugs.python.org/issue25710>
___
___
Python-bugs-list mailing list
Unsubscribe:
Eric Snow added the comment:
LGTM
Thanks for doing that. It's definitely cleaner. :)
--
stage: patch review -> commit review
___
Python tracker
<http://bugs.python.org
Eric Snow added the comment:
That's an interesting thought. My intuition is that it wouldn't be worth doing.
It would certainly trade one development overhead for another, so it's a bit of
a wash there, I think. Are there other spots in the stdlib that rely on the
magic numb
Eric Snow added the comment:
python-dev thread:
https://mail.python.org/pipermail/python-dev/2016-February/143374.html
Notably:
https://github.com/pantsbuild/pex/pull/211
--
nosy: +eric.snow
___
Python tracker
<http://bugs.python.
Eric Snow added the comment:
(Note that PathFinder.invalidate_caches() loops over sys.path_importer_cache
and invalidates the cache of each path entry finder therein. What you're
suggesting is clearing sys.path_importer_cache after the loop finishes.)
Hmm. The distinction is be
Eric Snow added the comment:
Re: the kw-only arg, it seems weird to accommodate the implementation of one
meta-path finder in the signature of importlib.invalidate_caches().
Here's an alternative:
Use a different sys.path_importer_cache sentinel internally (in PathFinder) and
never
Changes by Eric Snow :
--
nosy: +benjamin.peterson, rhettinger
___
Python tracker
<http://bugs.python.org/issue26495>
___
___
Python-bugs-list mailing list
Unsub
Eric Snow added the comment:
Oh, and spec.loader for namespace package is set to None.
--
___
Python tracker
<http://bugs.python.org/issue26569>
___
___
Python-bug
Eric Snow added the comment:
Also, beside namespace packages, custom loaders may run into a similar problem
with get_filename() and probably other code in there. It looks like the pyclbr
module assumes that modules will be either builtin or loaded through
SourceFileLoader. For example, you
Eric Snow added the comment:
Ah, you're talking about deleting Lib/test/__init__.py. Doing so makes it a
namespace package. The loader we use for namespace packages [1] does not have
a get_filename() method. So the problem to solve is supporting namespace
packages in Lib/pycl
Eric Snow added the comment:
Well, your patch is correct even if not ideal. :) Landing it as a short-term
solution is fine. Just keep this issue open so we can address the problem more
completely later.
--
components: +Interpreter Core
stage: -> commit review
type: -> be
Eric Snow added the comment:
And thanks for addressing this here. :)
--
___
Python tracker
<http://bugs.python.org/issue26569>
___
___
Python-bugs-list mailin
New submission from Eric Snow:
(see issue26569)
The pyclbr module is showing its age (born 1995). It assumes there are only 2
module types (builtin and source-based), particularly in readmodule() and
readmodule_ex(). Really it should be source-based and "everything else".
For in
Eric Snow added the comment:
Yeah, I've opened issue26584 to keep the matters separate. We can address a
more comprehensive cleanup there.
--
resolution: -> fixed
stage: commit review -> resolved
status: open -> closed
___
Python
Eric Snow added the comment:
Hmm. These two should be equivalent:
if spec.loader.is_package(fullmodule):
dict['__path__'] = [os.path.dirname(fname)]
if spec.submodule_search_locations is not None:
dict['__path__'] = spec.submodule_search_locations
Do you
Eric Snow added the comment:
Yeah, I'm pretty sure that TODO is out of date.
--
___
Python tracker
<http://bugs.python.org/issue19944>
___
___
Python-bugs-l
Eric Snow added the comment:
FYI: https://mail.python.org/pipermail/python-dev/2016-April/144320.html
--
nosy: +eric.snow
___
Python tracker
<http://bugs.python.org/issue23
Changes by Eric Snow :
--
nosy: +eric.snow
___
Python tracker
<http://bugs.python.org/issue26865>
___
___
Python-bugs-list mailing list
Unsubscribe:
Eric Snow added the comment:
I've gone ahead and pushed the patch.
--
resolution: -> fixed
stage: test needed -> resolved
status: open -> closed
___
Python tracker
<http://bugs.pyth
Eric Snow added the comment:
Could I get a quick review on this. There shouldn't be anything surprising or
controversial here. I'm pretty confident about the patch and it's pretty
low-impact so if I don't hear back in the next day or two I'll merge it.
Note: the po
Changes by Eric Snow :
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
versions: +Python 3.6 -Python 3.4, Python 3.5
___
Python tracker
<http://bugs.python.or
Eric Snow added the comment:
The last dependencies have now been closed!
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<http://bugs.python.or
Changes by Eric Snow :
--
versions: +Python 3.6 -Python 3.5
___
Python tracker
<http://bugs.python.org/issue19711>
___
___
Python-bugs-list mailing list
Unsub
Changes by Eric Snow :
Removed file: http://bugs.python.org/file39456/just-default-to-odict.diff
___
Python tracker
<http://bugs.python.org/issue24254>
___
___
Python-bug
Eric Snow added the comment:
Here's a refresh of the patch that only sets the default definition namespace
(and does not introduce __definition_order__).
--
Added file: http://bugs.python.org/file42834/just-default-to-odict.diff
___
Python tr
Eric Snow added the comment:
I haven't looked to closely but I'm guessing that pdb.set_trace() causes
something to get imported (i.e. there's an import statement in a function body
somewhere). Consequently sys.modules is updated (by that "distant" import
statement
2401 - 2500 of 2629 matches
Mail list logo
