Changes by Eric Snow :
--
nosy: +ericsnow
___
Python tracker
<http://bugs.python.org/issue10403>
___
___
Python-bugs-list mailing list
Unsubscribe:
Changes by Eric Snow :
--
nosy: +ericsnow
___
Python tracker
<http://bugs.python.org/issue12491>
___
___
Python-bugs-list mailing list
Unsubscribe:
Changes by Eric Snow :
--
nosy: +ericsnow
___
Python tracker
<http://bugs.python.org/issue11549>
___
___
Python-bugs-list mailing list
Unsubscribe:
Changes by Eric Snow :
--
nosy: +ericsnow
___
Python tracker
<http://bugs.python.org/issue2377>
___
___
Python-bugs-list mailing list
Unsubscribe:
Changes by Eric Snow :
--
nosy: +ericsnow
___
Python tracker
<http://bugs.python.org/issue12374>
___
___
Python-bugs-list mailing list
Unsubscribe:
Changes by Eric Snow :
--
nosy: +ericsnow
___
Python tracker
<http://bugs.python.org/issue11435>
___
___
Python-bugs-list mailing list
Unsubscribe:
Changes by Eric Snow :
--
nosy: +ericsnow
___
Python tracker
<http://bugs.python.org/issue11561>
___
___
Python-bugs-list mailing list
Unsubscribe:
Changes by Eric Snow :
--
nosy: +ericsnow
___
Python tracker
<http://bugs.python.org/issue2636>
___
___
Python-bugs-list mailing list
Unsubscribe:
Changes by Eric Snow :
--
nosy: +ericsnow
___
Python tracker
<http://bugs.python.org/issue12535>
___
___
Python-bugs-list mailing list
Unsubscribe:
Changes by Eric Snow :
--
nosy: +ericsnow
___
Python tracker
<http://bugs.python.org/issue10224>
___
___
Python-bugs-list mailing list
Unsubscribe:
Changes by Eric Snow :
--
nosy: +ericsnow
___
Python tracker
<http://bugs.python.org/issue1559549>
___
___
Python-bugs-list mailing list
Unsubscribe:
Changes by Eric Snow :
--
nosy: +ericsnow
___
Python tracker
<http://bugs.python.org/issue11470>
___
___
Python-bugs-list mailing list
Unsubscribe:
Changes by Eric Snow :
--
nosy: +ericsnow
___
Python tracker
<http://bugs.python.org/issue2506>
___
___
Python-bugs-list mailing list
Unsubscribe:
Eric Snow added the comment:
But it is curious that the submodules were added to sys.modules even though the
package failed to import.
--
nosy: +ericsnow
___
Python tracker
<http://bugs.python.org/issue12
Changes by Eric Snow :
--
nosy: +ericsnow
___
Python tracker
<http://bugs.python.org/issue8916>
___
___
Python-bugs-list mailing list
Unsubscribe:
Eric Snow added the comment:
Yeah, I missed the line where he imported foo.bar in "foo/__init__.py", and
thought something else was going on.
"foo/__init__.py" does not have to finish importing (just has to be on
sys.modules) at the point foo.bar is imported.
Changes by Eric Snow :
--
nosy: +ericsnow
___
Python tracker
<http://bugs.python.org/issue12531>
___
___
Python-bugs-list mailing list
Unsubscribe:
Changes by Eric Snow :
--
nosy: +ericsnow
___
Python tracker
<http://bugs.python.org/issue11343>
___
___
Python-bugs-list mailing list
Unsubscribe:
Changes by Eric Snow :
--
nosy: +ericsnow
___
Python tracker
<http://bugs.python.org/issue1284670>
___
___
Python-bugs-list mailing list
Unsubscribe:
Changes by Eric Snow :
--
nosy: +ericsnow
___
Python tracker
<http://bugs.python.org/issue12583>
___
___
Python-bugs-list mailing list
Unsubscribe:
New submission from Eric Snow :
Several import-related sys variables are set in _PyImportHooks_Init (in
Python/import.c), which is called in Python/pythonrun.c. I have included a
patch that moves that initialization from _PyImportHooks_Init to a new
_SysImportState_Init function in Python
Changes by Eric Snow :
--
nosy: +ericsnow
___
Python tracker
<http://bugs.python.org/issue7897>
___
___
Python-bugs-list mailing list
Unsubscribe:
Changes by Eric Snow :
--
nosy: +ericsnow
___
Python tracker
<http://bugs.python.org/issue12626>
___
___
Python-bugs-list mailing list
Unsubscribe:
New submission from Eric Snow :
The sys.modules dict is a special object. It is the only variable of the
CPython interpreter object that is exposed in the sys module[1]. Everything
else in sys lives in the module. However, the modules dict lives in the
interpreter object and is bound to
Eric Snow added the comment:
Would an implementation detail note be inappropriate here? I only ask because
it looks like the imp module's use of interp->modules is implementation
specific.
Here's a patch for Doc/library/sys.rst that adds the note.
--
assignee: -
Eric Snow added the comment:
And this doesn't impact "if x is None", so +1.
--
nosy: +ericsnow
___
Python tracker
<http://bugs.python.org/issue12647>
___
_
Changes by Eric Snow :
--
nosy: +ericsnow
___
Python tracker
<http://bugs.python.org/issue12675>
___
___
Python-bugs-list mailing list
Unsubscribe:
Eric Snow added the comment:
You can already get the better prefix using os.path, albeit less efficiently.
Here's an example:
def commondirname(paths):
subpath = os.path.commonprefix(paths)
for path in paths:
if path == subpath:
return subpath
Changes by Eric Snow :
--
nosy: +ericsnow
___
Python tracker
<http://bugs.python.org/issue12691>
___
___
Python-bugs-list mailing list
Unsubscribe:
Eric Snow added the comment:
Eli, I interpreted it the same way you did. In the doc, "type methods" are
those that map directly to PyTypeObject. Any custom type methods go in
tp_methods. You could almost call the former "PyTypeObject methods" rather
than "typ
Eric Snow added the comment:
http://docs.python.org/dev/extending/newtypes.html
--
___
Python tracker
<http://bugs.python.org/issue12672>
___
___
Python-bug
New submission from Eric Snow :
The idea of moving the devguide into the cpython repo, presumably under Doc/,
was mentioned in a thread on python-dev[1] (related to issue 12652). Does
anyone have any objections?
I'm guessing that Brett made a separate repo (A) for simplicity and (B) be
Eric Snow added the comment:
I suppose it doesn't have to be in Doc/.
--
title: Move devguide into /Docs of cpython repo -> Move devguide into cpython
repo
___
Python tracker
<http://bugs.python.org
Eric Snow added the comment:
That's fine. The discussion had moved away from the devguide, so I figured it
would be worth following up. You guys have made some good points.
--
resolution: -> rejected
status: open -> closed
___
Pyt
New submission from Eric Snow :
Apparently docstrings for classes are immutable:
>>> class X:
... "some doc"
...
>>> X.__doc__
'some doc'
>>> X.__doc__ = "another doc"
Traceback (most recent call last):
File "", line
New submission from Eric Snow :
This patch adds f_func to PyFrameObject and sets it for functions that get
called (in PyFrame_New). For classes and modules it is set to None. The
difference in performance was not noticable, as far as I could tell. However,
I am willing to do more than just
Eric Snow added the comment:
Thanks for the review, Nick. I'll be uploading a new patch in a couple hours
with your recommended fixes.
Regarding the comments on python-ideas, would it be better to use a weakref
proxy around the function, to help with the reference cycles? That
Eric Snow added the comment:
On second thought, I probably won't be able to get an updated patch tonight. I
need to mull over the PyEval_EvalFunction implementation and the interaction
with fast_function.
--
___
Python tracker
Changes by Eric Snow :
--
nosy: +eric.snow
___
Python tracker
<http://bugs.python.org/issue12919>
___
___
Python-bugs-list mailing list
Unsubscribe:
New submission from Eric Snow :
While perhaps esoteric, it looks like exec'ing a code object that has freevars,
using a closure that has too few cells causes a segfault. I believe the
problem is around line 3276 of ceval.c at the PyTuple_GET_ITEM call:
if (PyTuple_GET_SI
Eric Snow added the comment:
I'm hoping to "release" it this week. Nick helped be a bunch with it during
pycon sprints. I basically took call_function in ceval.c and got it working
for arbitrary code blocks and exposed it as exec_closure to look like exec.
On Thu, Mar 24,
Eric Snow added the comment:
It's a C function that for now I have in an extension module. If it turns
out to be useful I am going to try to get it put into the builtins, but I
don't want to get ahead of myself.
--
Added file: http://bugs.python.org/file213
Eric Snow added the comment:
In 2.7 I get the following (if Y does not inherit from object):
>>> print('res:', 1 in y)
('X contains:', 1)
('res:', False)
This makes sense with old style classes. With Y(object):
>>> print('res:',
Eric Snow added the comment:
Duplicate of issue8130.
"When an exception has been assigned using as target, it is cleared at the end
of the except clause." [1]
See:
[1] http://docs.python.org/py3k/reference/compound_stmts.html#the-try-statement
[2] http://www.python.org/dev/pep
Eric Snow added the comment:
Wow! I was literally working on this problem yesterday. The abstract check is
done at instantiation time (in object.__new__, typeobject.c). So as it stands
__new__ has no way to validate that all your abstract properties have been
implemented unless they are
Eric Snow added the comment:
As far as I have found, there isn't a way to make it work implicitly without
changing object.__new__. I just posted some of the approaches I could think of
to python-list:
http://mail.python.org/pipermail/python-list/2011-May/1272604.html
Mostly it is a m
New submission from Eric Snow :
tl;dr let's move PyInterpreterState.config to _PyRuntimeState.config.
Historically the runtime has been initialized using Py_Initialize(). PEP 587
added Py_InitializeFromConfig(), which takes a PyConfig and allows all sorts of
customization of the ru
Change by Eric Snow :
--
keywords: +patch
pull_requests: +29879
stage: needs patch -> patch review
pull_request: https://github.com/python/cpython/pull/31771
___
Python tracker
<https://bugs.python.org/issu
Eric Snow added the comment:
> After a new `&_Py_ID(__orig_class__)` is added to
> Objects/genericaliasobject.c, running `make regen-global-objects` starts
>
> gcc -pthread -c [snipped] -DPy_BUILD_CORE -o Objects/genericaliasobject.o
> Objects/genericaliasobject.c
>
Change by Eric Snow :
--
pull_requests: +30151
pull_request: https://github.com/python/cpython/pull/32061
___
Python tracker
<https://bugs.python.org/issue46
Eric Snow added the comment:
Here are reasons why PyConfig relates to the runtime and not each interpreter:
* PyConfig was introduced so embedders could dictate how the *runtime*
should be initialized
* after initialization, it represents how the runtime was initialized
* in the public API
Change by Eric Snow :
--
pull_requests: +30154
pull_request: https://github.com/python/cpython/pull/32063
___
Python tracker
<https://bugs.python.org/issue46
Eric Snow added the comment:
New changeset 21412d037b07c08266e96dfd0c0e44a1b7693bc1 by Eric Snow in branch
'main':
bpo-46541: Add a Comment About When to Use _Py_DECLARE_STR(). (gh-32063)
https://github.com/python/cpython/commit/21412d037b07c08266e96dfd0c0e44
Eric Snow added the comment:
New changeset febf54bcf3fdc45ad84b4073e24bbaaee0ac8b2a by Eric Snow in branch
'main':
bpo-46712: Do not Regen Deep-Frozen Modules before Generating Global Objects
(gh-32061)
https://github.com/python/cpython/commit/febf54bcf3fdc45ad84b4073e24bba
New submission from Eric Snow :
The "Check if generated files are up to date" GitHub check for PRs has been
failing recently. It may also impact local usage of "make regen-all".
Example: https://github.com/python/cpython/runs/5719012664
This may be related to gh-32061.
Eric Snow added the comment:
There's probably something racy with make.
See:
https://github.com/python/cpython/runs/5712538599?check_suite_focus=true#step:10:1147
--
___
Python tracker
<https://bugs.python.org/is
Change by Eric Snow :
--
keywords: +patch
pull_requests: +30240
stage: needs patch -> patch review
pull_request: https://github.com/python/cpython/pull/32162
___
Python tracker
<https://bugs.python.org/issu
Eric Snow added the comment:
New changeset 4c116f716bd1c174d6530b9a7a5ed3863927a109 by Eric Snow in branch
'main':
bpo-47146: Eliminate a race between make regen-deepfreeze and make
regen-global-objects. (gh-32162)
https://github.com/python/cpyt
Eric Snow added the comment:
Looks like that fixed it, per https://github.com/python/cpython/pull/32134.
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Eric Snow added the comment:
Looks like this is still an intermittent problem:
* https://github.com/python/cpython/pull/32195
+ failed: https://github.com/python/cpython/runs/5756616733
+ failed: https://github.com/python/cpython/runs/5753267869
+ failed: https://github.com/python
Change by Eric Snow :
--
pull_requests: +30281
stage: needs patch -> patch review
pull_request: https://github.com/python/cpython/pull/32206
___
Python tracker
<https://bugs.python.org/issu
Eric Snow added the comment:
New changeset db4dada5108dd49ebca23e4559a53630a2df8447 by Eric Snow in branch
'main':
bpo-47146: Avoid Using make Recursively (gh-32206)
https://github.com/python/cpython/commit/db4dada5108dd49ebca23e4559a536
Eric Snow added the comment:
I re-ran jobs that had failed before I merged that gh-32206. Several passed,
but the following are still failing:
* https://github.com/python/cpython/pull/32188
+ https://github.com/python/cpython/runs/5773938424
* https://github.com/python/cpython/pull/32132
Eric Snow added the comment:
Brandt pointed out this is consistently reproducible locally:
make clean regen-all -j
I'll get this sorted out today.
--
___
Python tracker
<https://bugs.python.org/is
Change by Eric Snow :
--
pull_requests: +30294
stage: needs patch -> patch review
pull_request: https://github.com/python/cpython/pull/32218
___
Python tracker
<https://bugs.python.org/issu
Eric Snow added the comment:
New changeset e7bb7c2f047b4f97e4426c42ae209c969808069d by Eric Snow in branch
'main':
bpo-47146: Stop Depending On regen-deepfreeze For regen-global-objects
(gh-32218)
https://github.com/python/cpython/commit/e7bb7c2f047b4f97e4426c42ae209c
Eric Snow added the comment:
I'll keep an eye on PRs for the next day or so.
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> pending
___
Python tracker
<https://bugs.pyth
Eric Snow added the comment:
Specifically: https://github.com/python/cpython/actions/workflows/build.yml.
--
status: pending -> open
___
Python tracker
<https://bugs.python.org/issu
Eric Snow added the comment:
Looks like gh-32218 worked.
--
status: open -> closed
___
Python tracker
<https://bugs.python.org/issue47146>
___
___
Python-
Change by Eric Snow :
--
nosy: +Mark.Shannon
___
Python tracker
<https://bugs.python.org/issue47185>
___
___
Python-bugs-list mailing list
Unsubscribe:
Eric Snow added the comment:
The relevant module attributes are described in the importlib docs:
https://docs.python.org/3/library/importlib.html#importlib.abc.Loader.load_module
--
versions: +Python 3.7, Python 3.8, Python 3.9 -Python 3.3, Python 3.4
Change by Eric Snow :
--
pull_requests: +15413
pull_request: https://github.com/python/cpython/pull/15760
___
Python tracker
<https://bugs.python.org/issue36
Change by Eric Snow :
--
pull_requests: +15518
pull_request: https://github.com/python/cpython/pull/15877
___
Python tracker
<https://bugs.python.org/issue36
Change by Eric Snow :
--
nosy: +pitrou
___
Python tracker
<https://bugs.python.org/issue38091>
___
___
Python-bugs-list mailing list
Unsubscribe:
Eric Snow added the comment:
I'm guessing it should have been
https://mail.python.org/pipermail/python-list/2011-May/604497.html.
--
___
Python tracker
<https://bugs.python.org/is
Change by Eric Snow :
--
nosy: +eric.snow
___
Python tracker
<https://bugs.python.org/issue37888>
___
___
Python-bugs-list mailing list
Unsubscribe:
Eric Snow added the comment:
Yeah, I'm fine with dropping this. In the file we have some global and some
local, so my suggestion was to consolidate a little. However, it mostly
doesn't matter. :)
--
resolution: -> rejected
stage: needs patch -> resolved
status
Change by Eric Snow :
--
nosy: +brett.cannon, eric.snow
___
Python tracker
<https://bugs.python.org/issue38091>
___
___
Python-bugs-list mailing list
Unsub
Eric Snow added the comment:
@Jeroen, see Dino's expalantion in https://bugs.python.org/issue38075#msg351627
(relative to the "random" module).
--
___
Python tracker
<https://bugs.pyt
Eric Snow added the comment:
New changeset ac46eb4ad6662cf6d771b20d8963658b2186c48c by Eric Snow (Dino
Viehland) in branch 'master':
bpo-38113: Update the Python-ast.c generator to PEP384 (gh-15957)
https://github.com/python/cpython/commit/ac46eb4ad6662cf6d771b20d896365
Change by Eric Snow :
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Eric Snow added the comment:
New changeset ee536b2020b1f0baad1286dbd4345e13870324af by Eric Snow in branch
'master':
bpo-36876: Add a tool that identifies unsupported global C variables. (#15877)
https://github.com/python/cpython/commit/ee536b2020b1f0baad1286dbd4345e
Eric Snow added the comment:
@db3l, I'll take a look right away.
--
___
Python tracker
<https://bugs.python.org/issue36876>
___
___
Python-bugs-list m
Change by Eric Snow :
--
pull_requests: +15640
pull_request: https://github.com/python/cpython/pull/16017
___
Python tracker
<https://bugs.python.org/issue36
Eric Snow added the comment:
New changeset 64535fc6c0712caef0bc46be30e661f7ccf8280e by Eric Snow in branch
'master':
bpo-36876: Skip test_check_c_globals for now. (gh-16017)
https://github.com/python/cpython/commit/64535fc6c0712caef0bc46be30e661
Change by Eric Snow :
--
pull_requests: +15681
pull_request: https://github.com/python/cpython/pull/16058
___
Python tracker
<https://bugs.python.org/issue36
New submission from Eric Snow :
(This is a sub-task of bpo-36876, "Global C variables are a problem.".)
Currently Argument Clinic generates "_PyArg_Parser _parser" as a static
variable. Dropping "static" solves the problem of thread safety (e.g. for
subin
Eric Snow added the comment:
New changeset 088b63ea7a8331a3e34bc93c3b873c60354b4fad by Eric Snow in branch
'master':
bpo-36876: Fix the globals checker tool. (gh-16058)
https://github.com/python/cpython/commit/088b63ea7a8331a3e34bc93c3b873c
Eric Snow added the comment:
That might work. :)
There are two key problems under subinterpreters that do not share the GIL:
* races on refcount operations
* cache thrashing due to refcount operations (under multi-core threads)
A lock would certainly mitigate the first problem. I'
New submission from Eric Snow :
A "PyInterpreterState *interp" field on PyTypeObject would allow us to quickly
access the originating interpreter from any object. This will help us avoid
more costly lookups. The additional pointer used for this should not have a
significant imp
Eric Snow added the comment:
Yeah, dropping str support is fine. It wouldn't be hard to add it back in if
later we find it's useful. :)
--
___
Python tracker
<https://bugs.python.o
Change by Eric Snow :
--
pull_requests: +15890
pull_request: https://github.com/python/cpython/pull/16304
___
Python tracker
<https://bugs.python.org/issue38
Eric Snow added the comment:
FWIW, I support reverting the removal of PyThreadState_DeleteCurrent(). We
only reverted under the assumption that no one was using this function.
Clearly we were mistaken. :)
I'll re-open #37878 to revive the discussion about documenting the function
(
Eric Snow added the comment:
FWIW, when we un-revert we should be sure to move PyThreadState_DeleteCurrent()
from Include/pystate.h to Include/cpython/pystate.h. (I suppose that could be
done in a separate PR to keep the git history clear
Eric Snow added the comment:
s/un-revert/revert/
--
___
Python tracker
<https://bugs.python.org/issue38266>
___
___
Python-bugs-list mailing list
Unsubscribe:
Eric Snow added the comment:
I *was* going to suggest that we also put an underscore prefix on the name, but
I couldn't think of a reason why we would want to discourage use (other than to
reduce the size of the [supported] public API). Moving it to
Include/cpython/pystate.h is pro
Eric Snow added the comment:
@Joannah, sounds good. Thanks!
--
___
Python tracker
<https://bugs.python.org/issue38266>
___
___
Python-bugs-list mailin
Eric Snow added the comment:
I've re-opened this issue to address the original point: documenting
PyThreadState_DeleteCurrent(). FWIW, I don't see a problem with documenting it
if we're keeping it around (which it looks like we are).
We will address reverting GH-
Eric Snow added the comment:
+1 to the suggested "whatsnew" updates. If no one beats me to it I'll work on
a PR soon.
--
___
Python tracker
<https://bugs.pyt
Eric Snow added the comment:
New changeset 6693f730e0eb77d9453f73a3da33b78a97e996ee by Eric Snow in branch
'master':
bpo-38187: Fix a refleak in Tools/c-analyzer. (gh-16304)
https://github.com/python/cpython/commit/6693f730e0eb77d9453f73a3da33b7
201 - 300 of 2629 matches
Mail list logo
