Changes by Eric Snow :
--
nosy: +eric.snow
___
Python tracker
<http://bugs.python.org/issue15894>
___
___
Python-bugs-list mailing list
Unsubscribe:
Changes by Eric Snow :
--
nosy: +eric.snow
___
Python tracker
<http://bugs.python.org/issue15892>
___
___
Python-bugs-list mailing list
Unsubscribe:
Changes by Eric Snow :
--
nosy: +eric.snow
___
Python tracker
<http://bugs.python.org/issue15905>
___
___
Python-bugs-list mailing list
Unsubscribe:
Changes by Eric Snow :
--
nosy: +eric.snow
___
Python tracker
<http://bugs.python.org/issue12680>
___
___
Python-bugs-list mailing list
Unsubscribe:
Changes by Eric Snow :
--
nosy: +eric.snow
___
Python tracker
<http://bugs.python.org/issue7559>
___
___
Python-bugs-list mailing list
Unsubscribe:
Changes by Eric Snow :
--
nosy: +eric.snow
___
Python tracker
<http://bugs.python.org/issue15415>
___
___
Python-bugs-list mailing list
Unsubscribe:
Changes by Eric Snow :
--
nosy: +eric.snow
___
Python tracker
<http://bugs.python.org/issue16027>
___
___
Python-bugs-list mailing list
Unsubscribe:
Changes by Eric Snow :
--
nosy: +eric.snow
___
Python tracker
<http://bugs.python.org/issue16047>
___
___
Python-bugs-list mailing list
Unsubscribe:
Changes by Eric Snow :
--
resolution: -> works for me
status: open -> closed
___
Python tracker
<http://bugs.python.org/issue13863>
___
___
Python-bugs-
Eric Snow added the comment:
actually still valid for previous to 3.3
--
nosy: +eric.snow
resolution: works for me ->
status: closed -> open
___
Python tracker
<http://bugs.python.org/i
Changes by Eric Snow :
--
nosy: +eric.snow
status: pending -> open
___
Python tracker
<http://bugs.python.org/issue13028>
___
___
Python-bugs-list mai
Eric Snow added the comment:
Is this still an issue?
--
nosy: +eric.snow
status: open -> pending
___
Python tracker
<http://bugs.python.org/issue15599>
___
_
Changes by Eric Snow :
--
nosy: +eric.snow
___
Python tracker
<http://bugs.python.org/issue16049>
___
___
Python-bugs-list mailing list
Unsubscribe:
Changes by Eric Snow :
--
nosy: +eric.snow
___
Python tracker
<http://bugs.python.org/issue16101>
___
___
Python-bugs-list mailing list
Unsubscribe:
Changes by Eric Snow :
--
nosy: +eric.snow
___
Python tracker
<http://bugs.python.org/issue13290>
___
___
Python-bugs-list mailing list
Unsubscribe:
Changes by Eric Snow :
--
nosy: +eric.snow
___
Python tracker
<http://bugs.python.org/issue8478>
___
___
Python-bugs-list mailing list
Unsubscribe:
Changes by Eric Snow :
--
nosy: +eric.snow
___
Python tracker
<http://bugs.python.org/issue16144>
___
___
Python-bugs-list mailing list
Unsubscribe:
Changes by Eric Snow :
--
nosy: +eric.snow
___
Python tracker
<http://bugs.python.org/issue16213>
___
___
Python-bugs-list mailing list
Unsubscribe:
Changes by Eric Snow :
--
nosy: +eric.snow
___
Python tracker
<http://bugs.python.org/issue5128>
___
___
Python-bugs-list mailing list
Unsubscribe:
Changes by Eric Snow :
--
nosy: +eric.snow
___
Python tracker
<http://bugs.python.org/issue16217>
___
___
Python-bugs-list mailing list
Unsubscribe:
Changes by Eric Snow :
--
status: open -> pending
___
Python tracker
<http://bugs.python.org/issue13028>
___
___
Python-bugs-list mailing list
Unsubscri
Changes by Eric Snow :
--
nosy: +eric.snow
___
Python tracker
<http://bugs.python.org/issue10966>
___
___
Python-bugs-list mailing list
Unsubscribe:
Changes by Eric Snow :
--
nosy: +eric.snow
___
Python tracker
<http://bugs.python.org/issue15104>
___
___
Python-bugs-list mailing list
Unsubscribe:
Changes by Eric Snow :
--
nosy: +eric.snow
___
Python tracker
<http://bugs.python.org/issue16386>
___
___
Python-bugs-list mailing list
Unsubscribe:
Changes by Eric Snow :
--
nosy: +eric.snow
___
Python tracker
<http://bugs.python.org/issue16384>
___
___
Python-bugs-list mailing list
Unsubscribe:
Changes by Eric Snow :
--
nosy: +eric.snow
___
Python tracker
<http://bugs.python.org/issue8745>
___
___
Python-bugs-list mailing list
Unsubscribe:
Changes by Eric Snow :
--
nosy: +eric.snow
___
Python tracker
<http://bugs.python.org/issue16194>
___
___
Python-bugs-list mailing list
Unsubscribe:
Eric Snow added the comment:
The following from the changeset left me with questions:
-from _functools import partial, reduce
+try:
+from _functools import reduce
+except ImportError:
+pass
* Why the try block when there wasn't one before?
* Should reduce be added to __all__
Changes by Eric Snow :
--
nosy: +eric.snow
___
Python tracker
<http://bugs.python.org/issue8400>
___
___
Python-bugs-list mailing list
Unsubscribe:
Changes by Eric Snow :
--
nosy: +brett.cannon, eric.snow
___
Python tracker
<http://bugs.python.org/issue16467>
___
___
Python-bugs-list mailing list
Unsubscribe:
Eric Snow added the comment:
> Possibly reduce could be handled in a similar way with a fallback python
> implementation? Otherwise your suggestion of conditionally adding it to
> __all__
> makes sense to me.
In the meantime I'd expect the import of _functools.reduce to not
Changes by Eric Snow :
--
nosy: +eric.snow
___
Python tracker
<http://bugs.python.org/issue16474>
___
___
Python-bugs-list mailing list
Unsubscribe:
Eric Snow added the comment:
I agree with Andrew.
--
___
Python tracker
<http://bugs.python.org/issue16386>
___
___
Python-bugs-list mailing list
Unsubscribe:
Eric Snow added the comment:
Though I haven't been able to get to this, I do have a demo of sorts that I've
been using elsewhere:
https://bitbucket.org/ericsnowcurrently/pylt/src/default/pylt/_importing.py?at=default#cl-225
--
___
Pyth
Eric Snow added the comment:
I'd say ModuleNotFoundError. You could argue that other exception types aren't
really errors in certain circumstances. I'd think that generally this would be
an error.
--
___
Python tracker
<http
Eric Snow added the comment:
Effectively the exception indicates that the import system had an error.
--
___
Python tracker
<http://bugs.python.org/issue15
Eric Snow added the comment:
Don't underestimate the potential value of having the fullname when overriding
the method in a subclass.
--
___
Python tracker
<http://bugs.python.org/is
Eric Snow added the comment:
I'll take a look but can't say when. My wife's is having a baby in the next
couple days so I'm a bit swamped. :)
--
___
Python tracker
<http://bu
Eric Snow added the comment:
Keep in mind that it's pretty easy to roll your own CM wrapper:
@contextlib.contextmanager
def closes(file):
yield file
file.close()
Then you can do this:
with closes(StringIO()) as test:
test.write("hi!")
return test.getvalue()
Thi
Eric Snow added the comment:
I agree with Benjamin re: __args__ and __kw__.
--
___
Python tracker
<http://bugs.python.org/issue12370>
___
___
Python-bugs-list m
Changes by Eric Snow :
--
nosy: +eric.snow
___
Python tracker
<http://bugs.python.org/issue10914>
___
___
Python-bugs-list mailing list
Unsubscribe:
Eric Snow added the comment:
borrowed the time machine did we? ;)
--
___
Python tracker
<http://bugs.python.org/issue1286>
___
___
Python-bugs-list mailin
Eric Snow added the comment:
Sorry, just now digging out of a massive backlog here. The originally proposed
name of "source_to_code()" might be more appropriate than compile_source().
The relationship to compilation is not compulsory and the name/docstring/docs
might imply that.
Eric Snow added the comment:
This proposal only affects the initialization of sys.path[0], and not any of
the other sys.path entries made by site.py or otherwise.
--
___
Python tracker
<http://bugs.python.org/issue13
Eric Snow added the comment:
Things are working as they should here. The key points:
* when running a script, sys.path[0] is set to the script's directory (with no
script sys.path[0] is set to the CWD, see issue13475),
* pkg/tests/__init__.py is loaded and executed twice: once as the s
Eric Snow added the comment:
oops. too slow. :)
--
___
Python tracker
<http://bugs.python.org/issue16570>
___
___
Python-bugs-list mailing list
Unsubscribe:
Changes by Eric Snow :
--
status: open -> closed
___
Python tracker
<http://bugs.python.org/issue16606>
___
___
Python-bugs-list mailing list
Unsubscri
Eric Snow added the comment:
What is wrong with the following?
class Point(namedtuple('Point', 'x y')):
"""A 2-dimensional coordinate
x - the abscissa
y - the ordinate
"""
This seems more clear to me. namedtuple is in som
Eric Snow added the comment:
+1, Terry
--
___
Python tracker
<http://bugs.python.org/issue16669>
___
___
Python-bugs-list mailing list
Unsubscribe:
Eric Snow added the comment:
Patch looks good to me. Are there any other exceptions that might be included
here?
--
nosy: +brett.cannon, eric.snow
___
Python tracker
<http://bugs.python.org/issue16
Changes by Eric Snow :
--
nosy: +eric.snow
___
Python tracker
<http://bugs.python.org/issue16795>
___
___
Python-bugs-list mailing list
Unsubscribe:
Eric Snow added the comment:
Looks like a case where the concrete dict API is ignoring subtype
implementations.
In your example the attribute access will be handled by a LOAD_ATTR which calls
PyObject_GetAttr() (Python/ceval.c:2369). That ends up calling
PyFunction_Type.tp_getattro
New submission from Eric Snow:
Here's an initial stab at writing OrderedDict in C. Though, the implementation
is not heavily optimized and isn't super subclass-friendly, my hope is that
it's relatively close to the final version. I'm getting this up now to get
some eyes
Eric Snow added the comment:
@Benjamin: Yeah, I've fixed that.
@Ezio: Good point. I've touched that up.
Once I have cleared up reference counting issues I'll put up a new patch.
--
___
Python tracker
<http://bugs.pyt
Changes by Eric Snow :
--
nosy: +eric.snow
___
Python tracker
<http://bugs.python.org/issue16803>
___
___
Python-bugs-list mailing list
Unsubscribe:
Eric Snow added the comment:
Also missing a pure-Python implementation:
collections.defaultdict (relatively trivial)
collections.deque
In the spirit of what Brett said, I found that PyPy has an implementation
already:
https://bitbucket.org/pypy/pypy/src/default/lib_pypy/_collections.py
Changes by Eric Snow :
--
nosy: +eric.snow
___
Python tracker
<http://bugs.python.org/issue1674555>
___
___
Python-bugs-list mailing list
Unsubscribe:
Eric Snow added the comment:
Here's a cleanup of test.test_collections that helps keep the subsequent patch
(still forthcoming) cleaner.
--
Added file: http://bugs.python.org/file28839/cleanup-test-collections.diff
___
Python tracker
New submission from Eric Snow:
Related to issue #16817 and to my efforts on a C OrderedDict, I think it would
be nice to have a class decorator that handles most of the PEP 399 requirements
for you. The attached patch adds such a decorator to test.support.
--
assignee: eric.snow
Eric Snow added the comment:
So the current solution is to temporarily put the relevant module in place in
sys.modules, right? That seems to be the solution that Stefan recommended and
used in the decimal module. Sounds good to me.
I'm hitting this while doing the PEP 399 two-step fo
Eric Snow added the comment:
One lingering doubt I have is about how I throw the two new test case classes
into the globals. They're already getting bound, as a pair, to the original
test class's name...
--
___
Python trac
Eric Snow added the comment:
One step I left out is handling the whole pickle/copyreg case outlined by
#16817.
--
___
Python tracker
<http://bugs.python.org/issue17
Changes by Eric Snow :
--
nosy: +eric.snow
___
Python tracker
<http://bugs.python.org/issue14715>
___
___
Python-bugs-list mailing list
Unsubscribe:
Changes by Eric Snow :
--
nosy: +eric.snow
___
Python tracker
<http://bugs.python.org/issue16737>
___
___
Python-bugs-list mailing list
Unsubscribe:
Changes by Eric Snow :
--
nosy: +eric.snow
___
Python tracker
<http://bugs.python.org/issue16748>
___
___
Python-bugs-list mailing list
Unsubscribe:
Changes by Eric Snow :
--
nosy: +eric.snow
___
Python tracker
<http://bugs.python.org/issue11995>
___
___
Python-bugs-list mailing list
Unsubscribe:
Eric Snow added the comment:
The decorator also mitigates the problem described in issue #16835.
--
___
Python tracker
<http://bugs.python.org/issue17037>
___
___
Eric Snow added the comment:
In my case I've been doing PEP 399 for collections.OrderedDict. It struck me
that the boilerplate could be stowed away in a decorator. It's more than just
adding a couple subclasses. Here's what it covers:
* add the test case subclasses,
Eric Snow added the comment:
> Do you have a real use case for the 'names' argument?
My use case was with the tests for OrderedDict. The existing tests don't refer
to collections.OrderedDict, but rather to OrderedDict (looked up from the
globals). The names argume
Eric Snow added the comment:
> What's the reason for moving the OrderedDict tests in a separate file?
Following the precedent of collections.deque and collections.defaultdict:
* a big chunk of code
* the default implementation will be coming via _col
New submission from Eric Snow:
In http://docs.python.org/dev/c-api/memory.html#examples:
char *buf1 = PyMem_New(char, BUFSIZ);
char *buf2 = (char *) malloc(BUFSIZ);
char *buf3 = (char *) PyMem_Malloc(BUFSIZ);
...
PyMem_Del(buf3
Eric Snow added the comment:
Thanks for clarifying, Stefan. Are you opposed to a comment in the example?
--
___
Python tracker
<http://bugs.python.org/issue17
New submission from Eric Snow:
http://docs.python.org/dev/c-api/typeobj.html
I found the the documentation for PyTypeObject to be somewhat harder to use
than it need be. In the end I distilled the info down for my own use. I'm
comfortable with what I came up with, so I'd like t
Eric Snow added the comment:
Sorry, I'd meant something like this:
char *buf1 = PyMem_New(char, BUFSIZ);
char *buf2 = (char *) malloc(BUFSIZ);
char *buf3 = (char *) PyMem_Malloc(BUFSIZ);
...
/* in reverse order */
PyMem_Del
Eric Snow added the comment:
(changing the title to disassociate it from a particular solution)
>> * make sure the original test case does not get used (#16835),
>
> PEP 399 dictates that the base class does not inherit from
> unittest.TestCase, so why would it be used?
Sorry fo
Eric Snow added the comment:
> I think something similar has already been proposed and rejected on another
> issue.
Wouldn't surprise me. I'll look for it. I know there's been a bunch of
traffic relative to PEP 399 and to test discovery, so I'm guessing I missed
Eric Snow added the comment:
Here's an updated patch after feedback. Thanks Ezio!
--
Added file: http://bugs.python.org/file28865/typeobj-doc.diff
___
Python tracker
<http://bugs.python.org/is
Changes by Eric Snow :
Removed file: http://bugs.python.org/file28864/typeobj-doc.diff
___
Python tracker
<http://bugs.python.org/issue17045>
___
___
Python-bugs-list m
Eric Snow added the comment:
+1 to where Brett's taking this. I really like having the PEP399Tests class
encapsulating the various boilerplate parts, with some of them as methods,
rather than trying to pack them all into one all-powerful decorator.
It would be worth raising an excepti
Eric Snow added the comment:
FWIW, here's a little more explanation on my original thoughts, none of which
I'm married to.
Most of the magic in my patch came messing with the globals (swap out the
module and module attrs; add in the two new classes; ditch the original class).
Eric Snow added the comment:
+1 on requires_accelerator(). It could also be used for individual test
methods. Similar decorators-as-methods could be added later, where
appropriate, for other special cases, like handling the pickle situation
described in #16817
Changes by Eric Snow :
--
nosy: +eric.snow
___
Python tracker
<http://bugs.python.org/issue17093>
___
___
Python-bugs-list mailing list
Unsubscribe:
Changes by Eric Snow :
--
nosy: +eric.snow
___
Python tracker
<http://bugs.python.org/issue17099>
___
___
Python-bugs-list mailing list
Unsubscribe:
Changes by Eric Snow :
--
nosy: +eric.snow
___
Python tracker
<http://bugs.python.org/issue17098>
___
___
Python-bugs-list mailing list
Unsubscribe:
Changes by Eric Snow :
--
nosy: +eric.snow
___
Python tracker
<http://bugs.python.org/issue17100>
___
___
Python-bugs-list mailing list
Unsubscribe:
Eric Snow added the comment:
Are you thinking of issue 15833?
--
___
Python tracker
<http://bugs.python.org/issue13192>
___
___
Python-bugs-list mailing list
Unsub
Eric Snow added the comment:
Yeah, at some point I will. :) I've been pretty focused on implementing a
C-OrderedDict, which I'm (hopefully) wrapping up pretty soon. Once that
happens I'm going to revisit a bunch of the open tickets I have. If you want
to push this sooner
Eric Snow added the comment:
Other than the language reference (with its updated info on imports--thanks
Barry!), what other documentation would benefit from a note on this? Somwhere
in http://docs.python.org/dev/tutorial/modules.html?
--
nosy: +eric.snow
Eric Snow added the comment:
> By the way,...
Yeah, PEP 420 (implemented in 3.3) introduced namespace packages. The new
behavior you're thinking of is where a package doesn't need a __init__.py. So
path-based lookup for modules, the order goes like this (for "import
spa
Eric Snow added the comment:
My vote is for making this a ValueError in both cases (and amending the doc
appropriately as well). The error amounts to the same thing: the module did
not have loader (implicitly or explicitly). If someone wants to distinguish
between the two they can
Eric Snow added the comment:
+1
--
nosy: +eric.snow
___
Python tracker
<http://bugs.python.org/issue17117>
___
___
Python-bugs-list mailing list
Unsubscribe:
Eric Snow added the comment:
> In all honesty I would like to tweak imp.new_module()/PyModule_Create()...
+1
--
nosy: +eric.snow
___
Python tracker
<http://bugs.python.org/issu
Eric Snow added the comment:
> [document that] the language reference and importlib docs now supersede the
> PEP
Agreed. PEP 302 is even crustier now than it was a year ago and Barry's new
import page in the language reference obviates the need for 302 as the de
Eric Snow added the comment:
Here's an updated patch. I still have some ref-counting issues, but the patch
is much closer to what I expect will be the final version. At this point it
passes all the main unit tests (segfaults in some of the supplemental Mapping
tests).
One key thing is
Changes by Eric Snow :
Removed file: http://bugs.python.org/file28762/odict.diff
___
Python tracker
<http://bugs.python.org/issue16991>
___
___
Python-bugs-list mailin
Eric Snow added the comment:
Looks like I didn't get the patch lined up to tip so the review link isn't
showing up. I'll have to fix that tomorrow.
--
___
Python tracker
<http://bugs.pyt
Eric Snow added the comment:
Agreed. It should also link to the new import section in the language
reference rather than to the import statement.
--
nosy: +eric.snow
___
Python tracker
<http://bugs.python.org/issue17
Changes by Eric Snow :
Added file: http://bugs.python.org/file28971/cleanup-test-collections.diff
___
Python tracker
<http://bugs.python.org/issue16991>
___
___
Python-bug
Changes by Eric Snow :
Added file: http://bugs.python.org/file28972/odict.diff
___
Python tracker
<http://bugs.python.org/issue16991>
___
___
Python-bugs-list mailin
Changes by Eric Snow :
Removed file: http://bugs.python.org/file28971/cleanup-test-collections.diff
___
Python tracker
<http://bugs.python.org/issue16991>
___
___
Pytho
1801 - 1900 of 2629 matches
Mail list logo