Changes by Eric Snow :
--
resolution: -> fixed
stage: needs patch -> committed/rejected
status: open -> pending
type: -> enhancement
___
Python tracker
<http://bugs.python
Eric Snow added the comment:
The doc deprecations should now be complete.
--
___
Python tracker
<http://bugs.python.org/issue19713>
___
___
Python-bugs-list mailin
Eric Snow added the comment:
P.S. changeset b78de8029606 should have referred to #19710.
--
___
Python tracker
<http://bugs.python.org/issue19713>
___
___
Pytho
Eric Snow added the comment:
I'm leaving this as pending for the moment in case we notice anything I missed.
--
status: pending -> open
___
Python tracker
<http://bugs.python.org
Changes by Eric Snow :
--
status: open -> pending
___
Python tracker
<http://bugs.python.org/issue19710>
___
___
Python-bugs-list mailing list
Unsubscrib
Eric Snow added the comment:
Here's a patch that simply adds all the deprecation warnings. It does not
include any effort to silence the zillion warnings that happen when the test
suite is run with -Wall. I plan on addressing all those when I have some time.
That will be a matt
Eric Snow added the comment:
I'd meant to do that. I'll update the patch when I have a chance.
--
___
Python tracker
<http://bugs.python.org/issue19713>
___
__
New submission from Eric Snow:
The modulefinder module (Lib/modulefinder.py) provides a ModuleFinder class
(plus 2 helpers) you can use to see what modules a script imports (directly or
indirectly). The module's implementation is centered on the old
imp.find_/load_module() API (whic
New submission from Eric Snow:
Python/makeopcodetargets.py uses deprecated imp APIs. It should be refactored
to use newer import-related APIs.
--
components: Library (Lib)
messages: 206577
nosy: eric.snow
priority: low
severity: normal
status: open
title: "mode
New submission from Eric Snow:
Mac/Tools/bundlebuilder.py uses deprecated imp APIs. It should be refactored
to use the current import-related APIs.
--
messages: 206578
nosy: eric.snow
priority: low
severity: normal
status: open
title: "modernize" the Mac bundlebuilder.py s
Eric Snow added the comment:
Thanks for working this out, Nick!
--
___
Python tracker
<http://bugs.python.org/issue19700>
___
___
Python-bugs-list mailin
Eric Snow added the comment:
If anyone notices any issues with the doc changes, please open a new issue.
--
status: pending -> closed
___
Python tracker
<http://bugs.python.org/issu
Changes by Eric Snow :
Removed file:
http://bugs.python.org/file33172/issue19713-deprecation-warnings.diff
___
Python tracker
<http://bugs.python.org/issue19713>
___
___
Eric Snow added the comment:
Here's an updated patch that does most of the deprecations and
adjustments/silencings to accommodate the deprecations. The main things left
to adjust are many importlib tests and pkgutil/test_pkgutil.
I'm still on the fence about deprecation wa
Changes by Eric Snow :
--
nosy: +eric.snow
___
Python tracker
<http://bugs.python.org/issue18576>
___
___
Python-bugs-list mailing list
Unsubscribe:
Eric Snow added the comment:
find_loader() is now deprecated and we're going to support auto-importing
parent modules in find_spec() (see #19944)
--
nosy: +eric.snow
resolution: -> duplicate
stage: test needed -> committed/rejected
status: open -> closed
supers
Eric Snow added the comment:
I've closed #16492 in favor of this ticket.
--
___
Python tracker
<http://bugs.python.org/issue19944>
___
___
Python-bugs-list m
Eric Snow added the comment:
I'm glad you spoke up, Nick. Holding off on the DeprecationWarnings is fine
with me. It's not like we are going to drop support for the APIs before Python
4! That said, DeprecationWarnings are disabled by default. So how big a deal
do you think it i
Eric Snow added the comment:
Sounds good. Thanks for the explanation. It sounds like you're effectively
concerned just with finder.find_module() and loader.load_module() (which is
fine with me). Everything else (including some of the ABCs) is 3.3-only. For
the sake of simplicity I
Eric Snow added the comment:
Unless there are objections, I'll commit this in the next day or two.
--
___
Python tracker
<http://bugs.python.org/is
Eric Snow added the comment:
My bad, Larry. I guess I was reading between the lines too much. :)
--
___
Python tracker
<http://bugs.python.org/issue19
Eric Snow added the comment:
Yeah, it was while writing tests that I ran into this.
--
___
Python tracker
<http://bugs.python.org/issue19927>
___
___
Python-bug
Eric Snow added the comment:
Right now say you have 2 module specs that are the same. The only difference
is that the 2 loaders are not the same instance (they were created separately
with the same arguments, ergo equal). The two specs will not compare as equal
even though they are equal
Eric Snow added the comment:
I'm fine with this. Thanks, Larry, for your attentiveness and diligence.
--
___
Python tracker
<http://bugs.python.org/is
Eric Snow added the comment:
Any thoughts on the latest patch?
--
___
Python tracker
<http://bugs.python.org/issue19944>
___
___
Python-bugs-list mailin
Eric Snow added the comment:
Here's a patch with tests that cover find_module() and find_spec() for
WindowsRegistryFinder (the missing case) and fixes the bug.
--
keywords: +patch
nosy: +eric.snow
stage: test needed -> patch review
Added file: http://bugs.python.org/f
Eric Snow added the comment:
The patch passes on my linux box and on my windows 7 laptop (using Visual
Studio 2010 Express).
--
___
Python tracker
<http://bugs.python.org/issue20
Changes by Eric Snow :
Removed file: http://bugs.python.org/file33294/issue20097-tests.diff
___
Python tracker
<http://bugs.python.org/issue20097>
___
___
Python-bug
Eric Snow added the comment:
Here's an updated patch that fixes as copy-and-paste mistake.
--
Added file: http://bugs.python.org/file33295/issue20097-tests.diff
___
Python tracker
<http://bugs.python.org/is
Eric Snow added the comment:
Thanks for the review, Victor. As to that note, it is the subject of issue
#19714.
--
assignee: brett.cannon -> eric.snow
dependencies: -Add tests for importlib.machinery.WindowsRegistryFinder
resolution: -> fixed
stage: patch review ->
Eric Snow added the comment:
I added 2 rudimentary tests for issue #20097 which gives at least coverage in
the test suite, but we need the following tests still:
* registry entry exists and module is found (spec returned)
* registry entry exists and module is not found (None returned
Eric Snow added the comment:
Good points, Nick. I was trying to limit touches on _bootstrap.py for 3.4, but
that "simple" patch is mostly just a hacky band-aid. Here's a patch that
hopefully stands on its own and still limits touches. (The patch is the
bare-bones changes on
Eric Snow added the comment:
find_spec() is at package level because find_module() is and for no other good
reason I'm aware of. I'd be just fine with moving it to util. I don't expect
it to be used enough to warrant that top-level placement.
Regarding builtins.__import__(),
Eric Snow added the comment:
Here's a patch that updates a couple files to not use find_module/load_module.
These are the only changes like this (of consequence) outside pydoc, pkgutil,
and importlib, which are covered by other tickets.
--
Added file: http://bugs.python.org/file
New submission from Eric Snow:
Here's a patch that does the minimum of updating pkgutil and its tests to move
away from find_module/load_module. I'm not sure there is much more to do than
this.
--
keywords: +patch
Added file: http://bugs.python.org/file33301/issue197
Eric Snow added the comment:
Here's a patch that updates pydoc to move away from find_module/load_module.
These 4 don't need to change for PEP 451:
safeimport()
HTMLDoc.docmodule()
HTMLDoc.index()
TextDoc.docmodule()
--
keywords: +patch
Added file: http://bugs.python.org
Eric Snow added the comment:
Could this wait for 3.5?
--
___
Python tracker
<http://bugs.python.org/issue19699>
___
___
Python-bugs-list mailing list
Unsubscribe:
Eric Snow added the comment:
Here's an outline of how I see __main__.__spec__ playing out relative to the
various cmdline interfaces.
== == == ===
- -c -m dir file name loader origin cached has_loc
Eric Snow added the comment:
For the record, normal start-up happens like this (simplified):
1. prep for and create/initialize interpreter
2. exec the site module in the __main__ namespace (unless -S)
3. do the interface-specific stuff
Note: exec of the site module does not impact the spec
Eric Snow added the comment:
Food for thought:
We could (for 3.5) add an importer just for __main__ that gives us the
appropriate spec and loads __main__ accordingly. Such a loader could even
incorporate exec of the site module (and any PYTHONSTARTUP script
Eric Snow added the comment:
I'm fine with leaving __spec__ as None for those remaining cases. It
definitely simplifies this ticket. :) Do you see any reason to not close this
one at this point?
--
___
Python tracker
<http://bugs.py
Eric Snow added the comment:
I'll commit it in a little while. Thanks.
--
versions: +Python 3.4 -Python 3.5
___
Python tracker
<http://bugs.python.org/is
Changes by Eric Snow :
--
resolution: -> fixed
stage: patch review -> committed/rejected
status: open -> closed
___
Python tracker
<http://bugs.python.or
Eric Snow added the comment:
There wasn't much left to do for pkgutil after all. :)
--
resolution: -> fixed
stage: -> committed/rejected
status: open -> closed
___
Python tracker
<http://bugs.pyth
Eric Snow added the comment:
At this point the only places using find_module and load_module are pydoc,
importlib, and some oddballs that aren't worth worrying about. Issue #19703
covers the pydoc changes.
--
dependencies: +Update pydoc to PE
New submission from Eric Snow:
I'm guessing this is a very seldom (never?) used code path. I've included a
patch to test and fix the problem. The patch includes several related tests
for pydoc.
$ py3 -c 'import pydoc;
pydoc.synopsis("/opt/python3.4/lib/python3.4/lib-
Eric Snow added the comment:
Here's a new patch relative to the patch for issue #20123.
--
dependencies: +pydoc.synopsis fails to load binary modules
Added file: http://bugs.python.org/file33310/issue19703-use-new-api.diff
___
Python tracker
Changes by Eric Snow :
Removed file: http://bugs.python.org/file33302/issue19703-use-new-api.diff
___
Python tracker
<http://bugs.python.org/issue19703>
___
___
Python-bug
Eric Snow added the comment:
FYI, I found this while working on issue #19703.
--
___
Python tracker
<http://bugs.python.org/issue20123>
___
___
Python-bugs-list m
Eric Snow added the comment:
I should clarify. That last commit was not the patch that adds the warnings.
I'm going to update that patch and attach it here when I get the chance.
--
___
Python tracker
<http://bugs.python.org/is
New submission from Eric Snow:
In issue #19713, it came up that while PEP 451 deprecated Loader.load_module(),
it did not provide a suitable replacement for calling it directly. We've
worked around this in the stdlib by making calls to private APIs, but that
won't work so we
Eric Snow added the comment:
Hmm. That's a good question. There really isn't a simple, public-API
replacement. I've opened issue #20125 to discuss our options. Feel free to
offer any suggestions there. Thanks for b
Changes by Eric Snow :
--
nosy: +larry
___
Python tracker
<http://bugs.python.org/issue20125>
___
___
Python-bugs-list mailing list
Unsubscribe:
https://mail.pyth
Eric Snow added the comment:
Not sure why I nosy'ed you, either. :)
--
___
Python tracker
<http://bugs.python.org/issue20123>
___
___
Python-bugs-list m
Eric Snow added the comment:
I'll take a look. It could be something with #19713 or #19708 that also failed
there.
The other failing buildbot for those 3 changesets is
http://buildbot.python.org/all/builders/x86%20Windows7%203.x/builds
Eric Snow added the comment:
Thanks for taking a look. Here's the patch that I totally forget to attach.
--
keywords: +patch
Added file: http://bugs.python.org/file33311/issue20123-fix-pydoc-synopsis.diff
___
Python tracker
<http://bugs.py
New submission from Eric Snow:
While looking at the logs of a buildbot failure [1], I took a look at
Lib/test/test_threaded_import.py. In
ThreadedImportTests.check_parallel_module_init() it makes a bunch of threaded
calls to the module-level "task()" function. There may be a race
Eric Snow added the comment:
The windows buildbot failure looks like a race condition in a test unrelated to
my changes (see issue #20127). I'm looking at the FreeBSD failure now.
--
___
Python tracker
<http://bugs.python.org/is
Eric Snow added the comment:
Which passed on the subsequent run...
--
___
Python tracker
<http://bugs.python.org/issue19927>
___
___
Python-bugs-list mailin
Eric Snow added the comment:
The FreeBSD failure happened in test_threading (apparently), where it was the
last test to "finish". In the passing run it finished 339/388 -- the seed was
different (1253928 vs. 5389019).
This does not seem to be related to my 3 changesets. I'
Changes by Eric Snow :
Removed file:
http://bugs.python.org/file33311/issue20123-fix-pydoc-synopsis.diff
___
Python tracker
<http://bugs.python.org/issue20123>
___
___
Eric Snow added the comment:
Sounds good to me. Here's an updated patch.
--
Added file: http://bugs.python.org/file33312/issue20123-fix-pydoc-synopsis.diff
___
Python tracker
<http://bugs.python.org/is
Eric Snow added the comment:
Ah, I missed that in your earlier suggestion. I followed your recommendation.
Thanks for that. :)
--
resolution: -> fixed
stage: patch review -> committed/rejected
status: open -> closed
___
Python track
Eric Snow added the comment:
This broke one of the FreeBSD buildbots:
http://buildbot.python.org/all/builders/AMD64%20FreeBSD%209.0%203.x/builds/6102
--
status: closed -> open
___
Python tracker
<http://bugs.python.org/issu
Eric Snow added the comment:
I've run out of time to trouble-shoot the failure (specific to 1 buildbot).
Until I can get back to it, I've disabled the problematic test (even though
it's only a problem on 1 buildbot).
--
___
Python
Eric Snow added the comment:
The buildbot is happy again. I'll address fixing that test in issue #20128.
--
status: open -> closed
___
Python tracker
<http://bugs.python.org
New submission from Eric Snow:
The test (added in issue #20123) broke one of the stable FreeBSD buildbots:
http://buildbot.python.org/all/builders/AMD64%20FreeBSD%209.0%203.x/builds/6102
The log for that test run indicates the traceback and the test can be found in
Lib/test/test_pydoc.py
Changes by Eric Snow :
--
status: pending -> closed
___
Python tracker
<http://bugs.python.org/issue19927>
___
___
Python-bugs-list mailing list
Unsubscrib
Changes by Eric Snow :
Removed file: http://bugs.python.org/file33310/issue19703-use-new-api.diff
___
Python tracker
<http://bugs.python.org/issue19703>
___
___
Python-bug
Eric Snow added the comment:
Here's a slightly updated patch.
--
assignee: -> eric.snow
stage: -> patch review
type: -> enhancement
Added file: http://bugs.python.org/file33313/issue19703-use-new-api.diff
___
Python
Eric Snow added the comment:
Okay, there were a few lingering changes (mostly related to
importlib.find_loader). Here's a patch.
--
Added file:
http://bugs.python.org/file33314/issue19713-more-API-adjustments.diff
___
Python tracker
Eric Snow added the comment:
...and the patch.
--
Added file:
http://bugs.python.org/file33315/issue19713-deprecation-warnings.diff
___
Python tracker
<http://bugs.python.org/issue19
Eric Snow added the comment:
Here's a patch that should round out the changes for this ticket, adding the
various deprecation warnings. Most of the patch involves silencing warnings or
cleaning up importlib tests relative to the deprecated
Changes by Eric Snow :
--
dependencies: +Check pkgutil for anything missing for PEP 451
___
Python tracker
<http://bugs.python.org/issue19713>
___
___
Python-bug
Changes by Eric Snow :
--
assignee: -> eric.snow
___
Python tracker
<http://bugs.python.org/issue19713>
___
___
Python-bugs-list mailing list
Unsubscrib
Changes by Eric Snow :
Removed file:
http://bugs.python.org/file33202/issue19713-deprecation-warnings.diff
___
Python tracker
<http://bugs.python.org/issue19713>
___
___
Eric Snow added the comment:
Brett: What do you think about moving importlib.find_spec() to importlib.util?
--
___
Python tracker
<http://bugs.python.org/issue19
Changes by Eric Snow :
--
resolution: -> fixed
stage: patch review -> committed/rejected
status: open -> closed
___
Python tracker
<http://bugs.python.or
Eric Snow added the comment:
Larry: There wasn't any API change for this issue. It was a matter of fixing
up places that were still using find_module/find_loader/load_module.
--
resolution: -> fixed
stage: test needed -> committed/rejected
status: ope
Eric Snow added the comment:
Also:
changeset: 88332:bfcbe41e892d4451b53bb5674fc4fa4ae791ec8c
user:Eric Snow
date:Mon Jan 06 20:42:59 2014 -0700
summary: Remove more usage of APIs deprecated by PEP 451.
--
___
Python tracker
Eric Snow added the comment:
Yeah, waiting on this until 3.5 is fine with me. Arfrever brought it up so I
at least wanted to track it.
--
stage: -> needs patch
versions: +Python 3.5 -Python 3.4
___
Python tracker
<http://bugs.pyth
Eric Snow added the comment:
Here's an update to the patch. It includes doc and test changes. It also
moves find_spec() into importlib.util.
(I'm removing the other patches since I don't consider them valid approaches
any longer).
--
Added file:
http://bugs.pytho
Eric Snow added the comment:
(...and to reduce any confusion on which patch is under consideration.)
--
___
Python tracker
<http://bugs.python.org/issue19
Changes by Eric Snow :
Removed file:
http://bugs.python.org/file33112/issue19944-find-spec-mirror-import-module-simple.diff
___
Python tracker
<http://bugs.python.org/issue19
Changes by Eric Snow :
Removed file:
http://bugs.python.org/file33111/issue19944-find-spec-mirror-import-module.diff
___
Python tracker
<http://bugs.python.org/issue19
Changes by Eric Snow :
Removed file:
http://bugs.python.org/file33087/issue19944-find-spec-parent-module.diff
___
Python tracker
<http://bugs.python.org/issue19
Changes by Eric Snow :
Removed file:
http://bugs.python.org/file33299/issue19944-find-spec-mirror-import-module-direct.diff
___
Python tracker
<http://bugs.python.org/issue19
Eric Snow added the comment:
About the only thing left for this ticket is to finish up writing a few tests
and round out some documentation.
--
dependencies: -Update pickle to take advantage of PEP 451, Update zipimport
for PEP 451
___
Python
Eric Snow added the comment:
There are a few lingering to-do comments that will need to be addressed as part
of the remaining work:
Lib/test/test_importlib/extension/test_case_sensitivity.py:# XXX find_spec tests
Lib/test/test_importlib/extension/test_finder.py:# XXX find_spec tests
Lib/test
Eric Snow added the comment:
If nothing else comes up, this will be the last PEP-451 functional change for
3.4.
--
___
Python tracker
<http://bugs.python.org/issue19
Eric Snow added the comment:
I realized today that this should probably be fixed in 3.3 as well, as RDM
implied by marking it as also a 3.3 bug. :)
--
resolution: fixed ->
stage: committed/rejected -> patch review
status: closed -> open
versions: -P
Eric Snow added the comment:
Good catch. I've gone through looking for other such left-overs from earlier
patches that included deprecation warnings for loader.load_module(), but this
is the only one I found. However, I did notice that _SpecMethods.from_module()
does not get used any
Eric Snow added the comment:
utils.module_to_load() has been removed (it was introduced in 3.4) and
module_for_loader() remains deprecated. The import machinery now does the work
that both functions did, rendering them unnecessary. I guess I failed to take
a look at whatsnew relative all
Eric Snow added the comment:
The difference is that inspect.signature is not friendly to Signature
subclasses. Without from_callable you can't customize the behavior in
inspect.signature easily.
--
___
Python tracker
<http://bugs.py
Eric Snow added the comment:
It's not about customizing inspect.signature. It's about customizing the
nice behavior of that function, including what type it returns.
--
___
Python tracker
<http://bugs.python.o
Eric Snow added the comment:
This is a duplicate of #16251, no? Pickle looks up dunder ;) methods on
instances rather than on classes, so __getattr__() gets triggered unexpectedly.
I had to work around this in some code of mine by special-casing in
__getattr__() names that start with
Changes by Eric Snow :
--
resolution: -> fixed
stage: -> committed/rejected
status: open -> pending
type: -> enhancement
___
Python tracker
<http://bugs.python
Eric Snow added the comment:
Looks like 3b8a2281d323aa9abf497192b01cf906b98ed3d8 broke the buildbots.
e.g.
http://buildbot.python.org/all/builders/AMD64%20FreeBSD%2010.0%203.x/builds/1533
--
nosy: +eric.snow
___
Python tracker
<h
Eric Snow added the comment:
FYI: on my local box I saw only the 2 failed tests in test_telnetlib.
--
___
Python tracker
<http://bugs.python.org/issue20
Eric Snow added the comment:
A better example:
http://buildbot.python.org/all/builders/AMD64%20FreeBSD%2010.0%203.x/builds/1538
--
___
Python tracker
<http://bugs.python.org/issue20
2801 - 2900 of 6609 matches
Mail list logo
