Eric Snow added the comment:
The change in Lib/test/coding20731.py was the result of running
PCbuild/fix_encoding.py.
--
status: open -> pending
___
Python tracker
<http://bugs.python.org/issu
Changes by Eric Snow :
--
pull_requests: +1846
status: pending -> open
___
Python tracker
<http://bugs.python.org/issue22257>
___
___
Python-bugs-list mai
Eric Snow added the comment:
New changeset e0918ecf93a458d4e005650f816d64654e73fc2a by Eric Snow in branch
'master':
bpo-22257: Fix CLI by using int instead of char (compares to EOF). (#1765)
https://github.com/python/cpython/commit/e0918ecf93a458d4e005650f816d64
Changes by Eric Snow :
--
pull_requests: +1852
___
Python tracker
<http://bugs.python.org/issue22257>
___
___
Python-bugs-list mailing list
Unsubscribe:
Eric Snow added the comment:
reverting the change to that test: https://github.com/python/cpython/pull/1770
--
___
Python tracker
<http://bugs.python.org/issue22
Changes by Eric Snow :
--
pull_requests: +1853
___
Python tracker
<http://bugs.python.org/issue22257>
___
___
Python-bugs-list mailing list
Unsubscribe:
Eric Snow added the comment:
Thanks for pointing this out, Serhiy. I'll take a look in the morning.
--
___
Python tracker
<http://bugs.python.org/is
Eric Snow added the comment:
Yeah, I some extra checks (involving pointers) to that test and some platforms
don't work as expected. I'll take a look in the morning.
--
___
Python tracker
<http://bugs.python.o
Eric Snow added the comment:
That looks similar to other failures due to an issue fixed in a later PR. It
shouldn't be an issue any longer. I'll double check in the morning.
--
___
Python tracker
<http://bugs.python.o
Eric Snow added the comment:
New changeset 1abcf6700b4da6207fe859de40c6c1bada6b4fec by Eric Snow in branch
'master':
bpo-22257: Private C-API for core runtime initialization (PEP 432). (#1772)
https://github.com/python/cpython/commit/1abcf6700b4da6207fe859de40c6c1
Eric Snow added the comment:
New changeset c7ec9985bbdbb2b073f2c37febd18268817da29a by Eric Snow in branch
'master':
bpo-22257: Private C-API for main interpreter initialization (PEP 432). (#1729)
https://github.com/python/cpython/commit/c7ec9985bbdbb2b073f2c37febd182
Eric Snow added the comment:
Apparently it is PRId64.
--
___
Python tracker
<http://bugs.python.org/issue29102>
___
___
Python-bugs-list mailing list
Unsubscribe:
Changes by Eric Snow :
--
pull_requests: +1874
___
Python tracker
<http://bugs.python.org/issue30447>
___
___
Python-bugs-list mailing list
Unsubscribe:
Eric Snow added the comment:
(see issue30447)
--
___
Python tracker
<http://bugs.python.org/issue29102>
___
___
Python-bugs-list mailing list
Unsubscribe:
Changes by Eric Snow :
--
pull_requests: +1885
___
Python tracker
<http://bugs.python.org/issue30439>
___
___
Python-bugs-list mailing list
Unsubscribe:
Changes by Eric Snow :
--
pull_requests: +1886
___
Python tracker
<http://bugs.python.org/issue30439>
___
___
Python-bugs-list mailing list
Unsubscribe:
Eric Snow added the comment:
New changeset d1c3c13fedaf62b71445ccd048e395aa4a7d510f by Eric Snow in branch
'master':
bpo-30447: Fix/skip the subinterpreters test on some platforms. (#1791)
https://github.com/python/cpython/commit/d1c3c13fedaf62b71445ccd048e395
Eric Snow added the comment:
I've fixed the compiler warning via d1c3c13fedaf62b71445ccd048e395aa4a7d510f.
--
status: open -> closed
___
Python tracker
<http://bugs.python.org
Changes by Eric Snow :
--
resolution: -> fixed
stage: -> resolved
status: open -> closed
___
Python tracker
<http://bugs.python.org/issue30447>
___
Changes by Eric Snow :
--
pull_requests: +1903
___
Python tracker
<http://bugs.python.org/issue22257>
___
___
Python-bugs-list mailing list
Unsubscribe:
Eric Snow added the comment:
proposed: https://mail.python.org/pipermail/python-ideas/2017-May/045765.html
--
___
Python tracker
<http://bugs.python.org/issue30
New submission from Eric Snow:
Per Object/dictobject.c, PyDict_GetItemWithError() returns a borrowed
reference. However, the documentation does not say so. That should be fixed.
--
messages: 294506
nosy: eric.snow
priority: normal
severity: normal
status: open
title: Docs for
Changes by Eric Snow :
--
assignee: -> eric.snow
components: +Documentation
stage: -> needs patch
versions: +Python 3.7
___
Python tracker
<http://bugs.python.org/i
Changes by Eric Snow :
--
pull_requests: +1904
___
Python tracker
<http://bugs.python.org/issue30475>
___
___
Python-bugs-list mailing list
Unsubscribe:
Eric Snow added the comment:
At this point I'm not convinced the failure is due to my recent changes.
Regardless, I do agree with you about detecting hard crashes.
--
___
Python tracker
<http://bugs.python.org/is
Changes by Eric Appelt :
--
nosy: +Eric Appelt
___
Python tracker
<http://bugs.python.org/issue30145>
___
___
Python-bugs-list mailing list
Unsubscribe:
Eric Appelt added the comment:
> 2b - I propose to take a simple protocol like Memcache or
> Redis and simply implement it using the streams API. We’ll only
> need two methods: set and get; and in the end we’ll teach the user
> how things really work and how to design async APIs.
Changes by Eric Snow :
--
resolution: -> fixed
stage: needs patch -> resolved
status: open -> closed
___
Python tracker
<http://bugs.python.or
Changes by Eric Snow :
--
keywords: +easy
___
Python tracker
<http://bugs.python.org/issue30535>
___
___
Python-bugs-list mailing list
Unsubscribe:
Eric Snow added the comment:
Sorry I didn't see the just-landed PR earlier, but it may make sense to not
skip that test under *any* release level for a micro version > 0:
@unittest.skipUnless(
(sys.version_info.micro > 0 or
sys.version_info.releaselevel
Eric Snow added the comment:
Thanks for taking care of this, Victor, Stéphane & Louie!
--
___
Python tracker
<http://bugs.python.org/issue30547>
___
___
Python
Eric Snow added the comment:
New changeset be3b295838547bba267eb08434b418ef0df87ee0 by Eric Snow in branch
'master':
bpo-35886: Make PyInterpreterState an opaque type in the public API. (GH-11731)
https://github.com/python/cpython/commit/be3b295838547bba267eb08434b418
Change by Eric Snow :
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Change by Eric Snow :
--
pull_requests: -11124
___
Python tracker
<https://bugs.python.org/issue35724>
___
___
Python-bugs-list mailing list
Unsubscribe:
Eric Snow added the comment:
New changeset 64d6cc826dacebc2493b1bb5e8cb97828eb76f81 by Eric Snow in branch
'master':
bpo-35724: Explicitly require the main interpreter for signal-handling.
(GH-11530)
https://github.com/python/cpython/commit/64d6cc826dacebc2493b1bb5e8cb97
Change by Eric Snow :
--
assignee: -> eric.snow
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python
New submission from Eric Snow :
After discussions about our use of the public C-API in stdlib extension
modules, I realized that I'd written the _xxsubinterpreters module using
internal C-API. However, there's no reason not to stick to the public C-API.
Fixing this will requir
Change by Eric Snow :
--
keywords: +patch
pull_requests: +12034
stage: needs patch -> patch review
___
Python tracker
<https://bugs.python.org/issu
Eric Snow added the comment:
New changeset ef4ac967e2f3a9a18330cc6abe14adb4bc3d0465 by Eric Snow in branch
'master':
bpo-33608: Factor out a private, per-interpreter _Py_AddPendingCall().
(GH-11617)
https://github.com/python/cpython/commit/ef4ac967e2f3a9a18330cc6abe14ad
Change by Eric Snow :
--
pull_requests: +12057
___
Python tracker
<https://bugs.python.org/issue33608>
___
___
Python-bugs-list mailing list
Unsubscribe:
Eric Snow added the comment:
GH-11617 has introduces a slight performance regression which will need to be
resolved. If I can't find the problem right away then I'll probably
temporarily revert the commit.
See https://mail.python.org/pipermail/python-dev/2019-February/1
Eric Snow added the comment:
@Armin, thanks for fixing things on your end so quickly. :)
Adding PyInterpreterState.dict and a public getter function (a la
PyThreadState) is probably fine. I'm just not sure how that relates to the
problem with cffi's use of the "builtins
Eric Snow added the comment:
On Mon, Feb 25, 2019 at 3:02 AM STINNER Victor wrote:
> But that's where I suggested to test "popular C extensions" with a C API
> change before merging it. It's ok if issues are discovered later, but the
> author of backward inco
Eric Snow added the comment:
At least, it *might* be a performance regression. Here are the two commits I
tried:
after: ef4ac967e2f3a9a18330cc6abe14adb4bc3d0465 (PR #11617, from this issue)
before: 463572c8beb59fd9d6850440af48a5c5f4c0c0c9 (the one right before)
After building each (a
Eric Snow added the comment:
Here's what I did (more or less):
$ python3 -m pip install --user perf
$ python3 -m perf system tune
$ git clone g...@github.com:python/performance.git
$ git clone g...@github.com:python/cpython.git
$ cd cpython
$ git che
Eric Snow added the comment:
...so it doesn't appear that my PR introduces a performance regression.
--
___
Python tracker
<https://bugs.python.org/is
Eric Snow added the comment:
FYI, I have a couple of small follow-up changes to land before I close this
issue.
--
___
Python tracker
<https://bugs.python.org/issue33
Eric Snow added the comment:
+1 from me
@Armin, thanks to Nick I understand your request better now. I'll put up a PR
by the end of the week if no one beats me to it.
--
nosy: +arigo, eric.snow
___
Python tracker
<https://bugs.py
Change by Eric Snow :
--
pull_requests: +12086
___
Python tracker
<https://bugs.python.org/issue33608>
___
___
Python-bugs-list mailing list
Unsubscribe:
New submission from Eric Snow :
PyInterpreterState_Main() is a function in the public C-API that returns a
pointer to the main interpreter's state. The main interpreter is the first one
created by the CPython runtime during startup (e.g. when the "python" command
is run).
Do
Eric Snow added the comment:
New changeset b05b711a2cef6c6c381e01069dedac372e0b9fb2 by Eric Snow in branch
'master':
bpo-33608: Use _Py_AddPendingCall() in _PyCrossInterpreterData_Release().
(gh-12024)
https://github.com/python/cpython/commit/b05b711a2cef6c6c381e01069dedac
Eric Snow added the comment:
Thinking about this, what is the key difference with the existing
PyModule_GetState() function? Is it just the return type (module-defined void
* vs. a regular dict)? Certainly it provides a C-only namespace that all
extensions can share (like
Eric Snow added the comment:
New changeset bda918bf65a88560ec453aaba0758a9c0d49b449 by Eric Snow in branch
'master':
bpo-33608: Simplify ceval's DISPATCH by hoisting eval_breaker ahead of time.
(gh-12062)
https://github.com/python/cpython/commit/bda918bf65a88560ec453aaba
Eric Snow added the comment:
I've merged the PR for hoisting eval_breaker before the ceval loop starts.
@Raymond, see if that addresses the performance regression you've been seeing.
I'll close this issue after I've sorted out the buildbot issues David mentioned
(on
Change by Eric Snow :
--
nosy: +petr.viktorin
___
Python tracker
<https://bugs.python.org/issue36124>
___
___
Python-bugs-list mailing list
Unsubscribe:
Change by Eric Snow :
--
keywords: +patch
pull_requests: +12135
stage: needs patch -> patch review
___
Python tracker
<https://bugs.python.org/issu
Change by Eric Snow :
--
assignee: -> eric.snow
___
Python tracker
<https://bugs.python.org/issue36124>
___
___
Python-bugs-list mailing list
Unsubscrib
Eric Snow added the comment:
New changeset bcfa450f210074e16feb761ae5b3e966a2532fcf by Eric Snow in branch
'master':
bpo-36097: Use only public C-API in the_xxsubinterpreters module (adding as
necessary). (#12003)
https://github.com/python/cpyt
Change by Eric Snow :
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Eric Snow added the comment:
At this point I'm not terribly interested in this. :)
--
resolution: -> wont fix
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.pyth
Eric Snow added the comment:
That's okay, Victor. Thanks for jumping on this. I'll take a look when I get
a chance.
--
___
Python tracker
<https://bugs.python.o
Eric Snow added the comment:
I'll re-merge this once this problem in issue #33608 is resolved.
--
resolution: fixed ->
stage: resolved ->
status: closed -> open
___
Python tracker
<https://bugs.pyth
Eric Snow added the comment:
Actually, this is independent of that change. It had to be reverted because
the PR was based on the earlier PR from #33608. So I may merge this
separately...or not, since it would mean having to sort out merge conflicts. :)
--
stage: -> needs pa
Eric Snow added the comment:
Thanks for taking a look Victor! That info is helpful. It will likely be a
few days before I can sort this out.
Once I have addressed the problem I'll re-merge. I plan on using the
"buildbot-custom" branch to make sure the buildbots are happy
Eric Snow added the comment:
This is resolved with gh-12159, no?
--
___
Python tracker
<https://bugs.python.org/issue36177>
___
___
Python-bugs-list mailin
Eric Snow added the comment:
This is resolved with gh-12159, no?
--
nosy: +eric.snow
___
Python tracker
<https://bugs.python.org/issue36114>
___
___
Python-bug
Eric Snow added the comment:
This is resolved with gh-12159, no?
--
nosy: +eric.snow
___
Python tracker
<https://bugs.python.org/issue36116>
___
___
Python-bug
Eric Snow added the comment:
On Sat, Mar 2, 2019 at 12:33 AM Armin Rigo wrote:
> PyModule_GetState() requires having the module object that corresponds
> to the given interpreter state. I'm not sure how a C extension module is
> supposed to get its own module object corres
Eric Snow added the comment:
Also, while PyThreadState_GetDict() is the inspiration here, we don't have to
copy it exactly. For instance, PyInterpreterState_GetDict() takes a
PyInterpreterState* argument, whereas PyThreadState_GetDict() takes no
arguments and gets the PyThreadState*
Change by Eric Snow :
--
pull_requests: +12228
stage: -> patch review
___
Python tracker
<https://bugs.python.org/issue33608>
___
___
Python-bugs-list mai
Change by Eric Snow :
--
pull_requests: +12231
___
Python tracker
<https://bugs.python.org/issue33608>
___
___
Python-bugs-list mailing list
Unsubscribe:
Change by Eric Snow :
--
pull_requests: +12234
___
Python tracker
<https://bugs.python.org/issue33608>
___
___
Python-bugs-list mailing list
Unsubscribe:
Change by Eric Snow :
--
pull_requests: +12235
___
Python tracker
<https://bugs.python.org/issue33608>
___
___
Python-bugs-list mailing list
Unsubscribe:
Change by Eric Snow :
--
pull_requests: +12236
___
Python tracker
<https://bugs.python.org/issue33608>
___
___
Python-bugs-list mailing list
Unsubscribe:
Eric Snow added the comment:
New changeset 5be45a6105d656c551adeee7770afdc3b806fbb5 by Eric Snow in branch
'master':
bpo-33608: Minor cleanup related to pending calls. (gh-12247)
https://github.com/python/cpython/commit/5be45a6105d656c551adeee7770afd
Eric Snow added the comment:
New changeset 8479a3426eb7d1840473f7788e639954363ed37e by Eric Snow in branch
'master':
bpo-33608: Make sure locks in the runtime are properly re-created. (gh-12245)
https://github.com/python/cpython/commit/8479a3426eb7d1840473f7788e6399
Eric Snow added the comment:
New changeset 842a2f07f2f08a935ef470bfdaeef40f87490cfc by Eric Snow in branch
'master':
bpo-33608: Deal with pending calls relative to runtime shutdown. (gh-12246)
https://github.com/python/cpython/commit/842a2f07f2f08a935ef470bfdaeef4
Change by Eric Snow :
--
pull_requests: +12326
stage: needs patch -> patch review
___
Python tracker
<https://bugs.python.org/issue36097>
___
___
Python-
Change by Eric Snow :
--
pull_requests: +12327
___
Python tracker
<https://bugs.python.org/issue33608>
___
___
Python-bugs-list mailing list
Unsubscribe:
Eric Snow added the comment:
New changeset c11183cdcff6af13c4339fdcce84ab63f7930ddc by Eric Snow in branch
'master':
bpo-36097: Use only public C-API in the_xxsubinterpreters module (adding as
necessary). (gh-12359)
https://github.com/python/cpyt
Eric Snow added the comment:
New changeset d2fdd1fedf6b9dc785cf5025b548a989faed089a by Eric Snow in branch
'master':
bpo-36124: Add PyInterpreterState.dict. (gh-12132)
https://github.com/python/cpython/commit/d2fdd1fedf6b9dc785cf5025b548a9
Eric Snow added the comment:
@arigo, thanks for nudging us here. :) Let me know if there's anything else
that would help here.
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python t
Eric Snow added the comment:
> Neil Schemenauer added the comment:
> Regarding m_traverse, maybe the list of finalizers should be stored somewhere
> in the interpreter
> state, not in the atexit module state. That would make more sense to me.
> atexit could merely be
>
Eric Snow added the comment:
In Python, multiplication on a list does not make copies of the values in the
original list. So what you have done is equivalent to the following:
a = [0, 0]
b = [a, a]
M = [b, b]
Hence:
>>> M[0] is M[1]
True
>>> M[0][0] is M[0][1
Eric Snow added the comment:
As Inada-san indicated, the problem might be resolved already. So without the
option of reproducing the problem, it will be hard to resolve this.
Here's some information you could provide that might help narrow down the scope
a bit:
* what (stdlib/third-
Eric Snow added the comment:
Also:
* are any of your threads daemon threads?
--
___
Python tracker
<https://bugs.python.org/issue36469>
___
___
Python-bug
Change by Eric Snow :
--
nosy: +eric.snow
___
Python tracker
<https://bugs.python.org/issue30703>
___
___
Python-bugs-list mailing list
Unsubscribe:
Eric Snow added the comment:
* Are any signals (or signal handlers) involved?
* Are you monkeypatching any builtins, builtin/stdlib modules (or any parts of
those)?
Keep in mind that a number of bugs have been fixed in later releases related to
the various things I've asked about.
Eric Snow added the comment:
At this point I think it's likely that the problem relates to how daemon
threads are handled during runtime finalization.
What normally happens in the main thread of the "python3" executable is this:
1. Python runtime initializes
2. main interpre
Eric Snow added the comment:
Here are some things that would likely help:
* in the main thread stop your daemon threads if you hit SystemExit
* make sure daemon threads release/acquire the GIL frequently (so they notice
finalization)
* make sure daemon threads otherwise exit promptly (no
New submission from Eric Snow :
Daemon threads keep running until they finish or until finalization starts.
For the latter, there is a check right after the thread acquires the GIL which
causes the thread to exit if runtime finalization has started. [1] However,
there are functions in the
Eric Snow added the comment:
I've opened issue36475 for the two C-API functions that do not cause daemon
threads to exit.
--
___
Python tracker
<https://bugs.python.org/is
Eric Snow added the comment:
Looking at the stack traces for all your threads (super helpful, BTW), I saw 4
groups:
* (1) main thread (blocked on GIL during runtime finalization)
+ Thread 1
* (12) blocked on GIL in call to PyEval_RestoreThread() (socket, select,
time.sleep(), file.read
Change by Eric Snow :
--
components: +Interpreter Core
___
Python tracker
<https://bugs.python.org/issue36475>
___
___
Python-bugs-list mailing list
Unsubscribe:
New submission from Eric Snow :
Among the first 3 things that happen in Py_FinalizeEx() are, in order:
1. wait for all non-daemon threads (of the main interpreter) to finish
2. call registered atexit funcs
3. mark the runtime as finalizing
At that point the only remaining Python threads are
Eric Snow added the comment:
I've also opened issues #36476 and #36477.
--
___
Python tracker
<https://bugs.python.org/issue36469>
___
___
Python-bugs-l
New submission from Eric Snow :
When using subinterpreters, any that exist when Py_FinalizeEx() is called do
not appear to get cleaned up during runtime finalization. Maybe I've been
looking at the code too much and I'm missing something. :)
This really isn't a problem excep
Eric Snow added the comment:
FYI, I've opened issue36477 to deal with the subinterpreters case.
--
___
Python tracker
<https://bugs.python.org/is
Eric Snow added the comment:
@Remy, aside from the recommendations I've made, I'm not sure what else we can
do to help. Before we close the issue, I'd really like to ensure that one of
those threads is holding the GIL still. It would definitely be a problem if a
thread exi
Change by Eric Snow :
--
resolution: -> duplicate
stage: needs patch -> resolved
status: open -> closed
superseder: -> Lingering subinterpreters should be implicitly cleared on
shutdown
___
Python tracker
<https://bugs.python
1601 - 1700 of 6312 matches
Mail list logo