Eli Bendersky added the comment:
Time for your friendly devil's advocate... We're using and loving this language:
>>> class Foo:
... bar = 2
...
>>> f = Foo()
>>> f.bar
2
>>> f.bar = 42
>>> f.bar
42
>>>
So let's stop
Eli Bendersky added the comment:
"You do not have permission to edit user" - in a red banner, no less. Blasphemy.
--
___
Python tracker
<http://bugs.python.o
Eli Bendersky added the comment:
On Wed, Sep 4, 2013 at 1:57 PM, Ethan Furman wrote:
>
> Ethan Furman added the comment:
>
> Eli Bendersky added the comment:
> >
> > So let's stop trying to make enums even more alien. This is a non-issue
> in Python.
>
Eli Bendersky added the comment:
On Wed, Sep 4, 2013 at 5:27 PM, Nikolaus Rath wrote:
>
> Nikolaus Rath added the comment:
>
> On 09/04/2013 06:03 AM, Eli Bendersky wrote:
> > Why guess... did you try it in the code?
>
> I don't follow... why guess what? And try wha
Eli Bendersky added the comment:
On Wed, Sep 4, 2013 at 3:05 PM, Ethan Furman wrote:
>
> Ethan Furman added the comment:
>
> Yes, as a matter of fact:
>
> --> Test.this
>
> --> Test.this = 'other'
> --> Test.this
> 'other'
> --&
Eli Bendersky added the comment:
Thanks, I moved the NEWS entry to the right place. Yes, all tests pass. I'll
update whatsnew separately.
--
___
Python tracker
<http://bugs.python.org/is
Changes by Eli Bendersky :
--
resolution: -> fixed
stage: patch review -> committed/rejected
status: open -> closed
versions: -Python 3.4
___
Python tracker
<http://bugs.python.or
Changes by Eli Bendersky :
--
nosy: +eli.bendersky
___
Python tracker
<http://bugs.python.org/issue18945>
___
___
Python-bugs-list mailing list
Unsubscribe:
Eli Bendersky added the comment:
+1 For the general idea
+1 For the more generic approach of which "lowercase" is just one special case
+10 to make this a PEP so that more people have a chance to express their
opinion (currently only those who noticed it on the issues mailing list
Eli Bendersky added the comment:
lgtm. kill 'em
--
nosy: +eli.bendersky
___
Python tracker
<http://bugs.python.org/issue18281>
___
___
Python-bugs-list m
Eli Bendersky added the comment:
I'm having trouble reproducing the problem, Germán. Running with Python 3.3.2
from a couple of days ago:
Python 3.3.2+ (3.3:0eef1670f316, Sep 8 2013, 08:31:59)
[GCC 4.6.3] on linux
Type "help", "copyright", "credits"
Eli Bendersky added the comment:
Thanks for this report, Germán (and the other issue as well). I'll do my best
to take a look later this week.
--
assignee: -> eli.bendersky
stage: -> patch review
type: -> behavior
versions: +Python 3.4
Eli Bendersky added the comment:
Can you specify how you import ET? I.e. from the pure Python or the C
accelerator?
Also, do you realize that the element iterparse returns should be discarded
with 'clear'? [see tutorial here:
http://eli.thegreenplace.net/2012/03/15/processing-xml
Eli Bendersky added the comment:
Thanks for the report - such regressions are taken seriously and will be fixed.
Ezio - you can go ahead and prepare a patch. I'm currently away from home
(business trip) but I will look into it when I get back next
Eli Bendersky added the comment:
Ezio,
Your patch looks good, with these notes:
* When raising TypeError in the Python constructor, say that 'attrib' must be a
dict, otherwise it's not clear *what* must be a dict.
* The 'attrib' keyword handling has to be added to
Eli Bendersky added the comment:
Here's a simpler testcase:
import xml.etree.ElementTree as ET
class XElement(ET.Element):
def __init__(self, tag, attrib={}):
ET.Element.__init__(self, tag, attrib)
e = XElement('test')
e.text = 'failure&#
Changes by Eli Bendersky :
--
assignee: -> eli.bendersky
resolution: -> fixed
stage: needs patch -> committed/rejected
status: open -> closed
___
Python tracker
<http://bugs.python
Changes by Eli Bendersky :
--
nosy: +eli.bendersky
___
Python tracker
<http://bugs.python.org/issue14884>
___
___
Python-bugs-list mailing list
Unsubscribe:
Eli Bendersky added the comment:
Nitpicking: the drop down (in both VC++ 2008 & 2010 express) is named "Solution
Configurations" [note the 's' in the end]
But this name does now appear anywhere - only if you hover on the dropbox. I
don't mind either way - ei
Eli Bendersky added the comment:
LGTM. Brian, any objections to commit?
P.S. Michael: I usually like numbering successive versions of a patch (like
setup.1.patch, setup.2.patch, or a similar scheme) - this makes it easier to
refer to more than one version in a discussion without getting
Eli Bendersky added the comment:
Done (with a tiny fix inserting parens to avoid ambiguity in a sentence).
Thanks for the contribution!
--
resolution: -> fixed
stage: patch review -> committed/rejected
status: open -> closed
___
Pytho
Eli Bendersky added the comment:
The whole namespace issue is not very well documented in the ReST doc for ET -
should open a new issue on this
--
___
Python tracker
<http://bugs.python.org/issue14
Eli Bendersky added the comment:
Updated patch with fixed error messages, additional tests and some
documentation. No support in SubElement yet
--
Added file: http://bugs.python.org/file25741/issue14818.3.patch
___
Python tracker
<h
Eli Bendersky added the comment:
Hi Leon,
Do you have an interest in pursuing this issue?
--
___
Python tracker
<http://bugs.python.org/issue14078>
___
___
Pytho
Eli Bendersky added the comment:
I don't think this is an enhancement to ET, because ET was not designed to be a
streaming parser, which is what is required here. ET was designed to read a
whole valid XML document. There is 'iterparse', as Antoine mentioned, but it is
des
Eli Bendersky added the comment:
I'm working on completing this issue. It will be done in stages, with each
stage committed as a separate chunk of functionality.
* Make TreeBuilder an actual exported type (subclassable) from _elementtree
* TreeBuilder constructor should accept argumen
Eli Bendersky added the comment:
* Another problem: the C implementation of XMLParser does not take 3 positional
args, but only 2. Although the 'html' arg is documented as "unsupported", it
should still be taken and silently ignored, similarly t
Eli Bendersky added the comment:
The latest commit completes this issue.
--
resolution: -> fixed
stage: test needed -> committed/rejected
status: open -> closed
___
Python tracker
<http://bugs.python.or
Eli Bendersky added the comment:
I propose to close this issue. If the problem in json is real and someone
thinks it has to be fixed, a separate issue specifically for json should be
opened.
--
___
Python tracker
<http://bugs.python.
Eli Bendersky added the comment:
Done with the recent completion of #14007
--
resolution: -> fixed
stage: needs patch -> committed/rejected
status: open -> closed
___
Python tracker
<http://bugs.python.or
Eli Bendersky added the comment:
Thanks. Fixed in changeset eb1d633fe307.
I'll watch the bots to see no problems remain.
--
status: open -> closed
___
Python tracker
<http://bugs.python.org
Changes by Eli Bendersky :
--
resolution: -> fixed
stage: -> committed/rejected
status: open -> closed
___
Python tracker
<http://bugs.python.or
Changes by Eli Bendersky :
--
versions: -Python 3.2
___
Python tracker
<http://bugs.python.org/issue14424>
___
___
Python-bugs-list mailing list
Unsubscribe:
Eli Bendersky added the comment:
Fixed what was relevant for default (3.3) in 90f0dd118aa4 (the commit message
there has a typo in the issue number).
Since 3.3 is going to be out soon, I see no real reason to backport to 3.2
If anyone is willing to create a complete patch for 2.7 that fixes
Changes by Eli Bendersky :
--
resolution: -> wont fix
stage: -> committed/rejected
status: open -> closed
___
Python tracker
<http://bugs.python.or
Changes by Eli Bendersky :
--
resolution: -> fixed
stage: -> committed/rejected
status: open -> closed
___
Python tracker
<http://bugs.python.or
Eli Bendersky added the comment:
Any progress, or can this issue be closed?
--
___
Python tracker
<http://bugs.python.org/issue14377>
___
___
Python-bugs-list m
Changes by Eli Bendersky :
--
resolution: -> wont fix
stage: patch review -> committed/rejected
status: open -> closed
___
Python tracker
<http://bugs.python.or
Changes by Eli Bendersky :
--
nosy: -eli.bendersky
___
Python tracker
<http://bugs.python.org/issue11379>
___
___
Python-bugs-list mailing list
Unsubscribe:
Changes by Eli Bendersky :
--
nosy: -eli.bendersky
___
Python tracker
<http://bugs.python.org/issue1040439>
___
___
Python-bugs-list mailing list
Unsubscribe:
Changes by Eli Bendersky :
--
nosy: -eli.bendersky
___
Python tracker
<http://bugs.python.org/issue14097>
___
___
Python-bugs-list mailing list
Unsubscribe:
Changes by Eli Bendersky :
--
nosy: -eli.bendersky
___
Python tracker
<http://bugs.python.org/issue13455>
___
___
Python-bugs-list mailing list
Unsubscribe:
Changes by Eli Bendersky :
--
nosy: -eli.bendersky
___
Python tracker
<http://bugs.python.org/issue12907>
___
___
Python-bugs-list mailing list
Unsubscribe:
Eli Bendersky added the comment:
Agree with Serhiy. Why are these flags required in Element?
Also, I'm moving this to 3.4 since the patch came too late in the 3.3 process -
the first beta is very soon, after which we prefer not to add new features.
--
priority: normal -> l
Eli Bendersky added the comment:
This looks rejected to me. Any opposition to closing the issue?
--
___
Python tracker
<http://bugs.python.org/issue14
Eli Bendersky added the comment:
Note: last traces of Python bootstrap code were removed from _elementtree in
changeset 652d148bdc1d
--
___
Python tracker
<http://bugs.python.org/issue13
New submission from Eli Bendersky :
The XincludeTest test-case in test_xml_etree is now skipped, because it fails
in an intermittent manner. I can reproduce the failure when running full
regrtest with -j1, but not -j8, and not when run individually.
The failure is most likely due to the test
Eli Bendersky added the comment:
After some tinkering I found which test when run before test_xml_etree causes
it to crash:
$ ./python -m test.regrtest test___all__ test_xml_etree
[1/2] test___all__
[2/2] test_xml_etree
Fatal Python error: Segmentation fault
Current thread 0x7f771ecec700
Eli Bendersky added the comment:
As suspected, the cause is that xinclude_loader manages to somehow import the C
version of ET, although test_xml_etree tries to enforce the Python version.
This is probably because test___all__ imports all modules and leaves stuff in
the import cache.
What
Eli Bendersky added the comment:
Here is a patch that solves the current problem.
A longer term solution would be to have a cleaner test plan for ET in general,
without monkey-patching at all, and without state that causes test-order
dependencies.
--
keywords: +patch
Added file
New submission from Eli Bendersky :
As #15075 demonstrated, the ET tests are sensitive to execution order because
of the way they operate.
Two sets of tests (one for the C module and one for the pure Python module)
operate from the same test code, monkey-patching the imported module. This
Eli Bendersky added the comment:
Opened #15083 to track the *actual* solution to this problem, which should
restructure the tests to be safer.
--
superseder: -> Rewrite ElementTree tests in a cleaner and safer way
___
Python tracker
&l
Eli Bendersky added the comment:
No need, the cause for the segfault is known. What happens is that Element
objects from the Python module get intermixed with Element objects from the C
module, and these are incompatible. The C module traversal functions assume
they can cast Elements to a
Eli Bendersky added the comment:
Out of curiosity, why don't the constituents of Element (i.e. the tag, the
attributes dict, etc.) count for its size?
--
___
Python tracker
<http://bugs.python.org/is
Eli Bendersky added the comment:
Martin, thanks for the explanation. The patch LGTM, then.
Could it be useful to document this a bit more explicitly in the description of
sys.getsizeof? The most intuitive thing to expect from it is to compute the
*total* size including contained objects. So
Changes by Eli Bendersky :
--
nosy: +eli.bendersky
___
Python tracker
<http://bugs.python.org/issue1767933>
___
___
Python-bugs-list mailing list
Unsubscribe:
Changes by Eli Bendersky :
--
nosy: +eli.bendersky
___
Python tracker
<http://bugs.python.org/issue9458>
___
___
Python-bugs-list mailing list
Unsubscribe:
Changes by Eli Bendersky :
--
nosy: +eli.bendersky
___
Python tracker
<http://bugs.python.org/issue13823>
___
___
Python-bugs-list mailing list
Unsubscribe:
Eli Bendersky added the comment:
I will try to find time to review it before the fork, but since time is tight I
don't promise.
That said, this patch falls more into the bugfix category than a new feature,
so I think it will be OK after beta as
Eli Bendersky added the comment:
Committed all fixes in http://hg.python.org/cpython/rev/7d252dbfbee3
--
resolution: -> fixed
stage: patch review -> committed/rejected
status: open -> closed
___
Python tracker
<http://bugs.python.or
Changes by Eli Bendersky :
--
status: open -> closed
___
Python tracker
<http://bugs.python.org/issue14202>
___
___
Python-bugs-list mailing list
Unsubscri
Eli Bendersky added the comment:
Serhiy, note that _SimpleElementPath is now gone in 3.3, since ElementPath.py
is always there in stdlib. Could you update the patch to reflect this?
Another thing. I'm trying really hard to phase out the doctest tests of etree,
replacing them with uni
Eli Bendersky added the comment:
Please make sure that the patch(es) apply cleanly to 3.3, since this is the
version I'll be focusing on.
--
___
Python tracker
<http://bugs.python.org/i
Changes by Eli Bendersky :
--
components: +Library (Lib)
stage: -> test needed
versions: +Python 3.4 -Python 3.2
___
Python tracker
<http://bugs.python.org/issu
Eli Bendersky added the comment:
I see no harm in modifying the signature of the private _serialize_* functions
to accept another argument or dict of options.
--
___
Python tracker
<http://bugs.python.org/issue14
Eli Bendersky added the comment:
Thanks for your work on this, Serhiy. I made some comments in the code-review
tool, mainly about the complexity of the resulting code.
Great work on switching the tests to unittest, much appreciated.
--
___
Python
Eli Bendersky added the comment:
Can this be honestly classified as a bugfix though? If it's a feature it will
have to be postponed to 3.4
--
___
Python tracker
<http://bugs.python.org/is
Eli Bendersky added the comment:
Thanks, this looks much better. I've reviewed the _4 patch with some minor
comments.
--
___
Python tracker
<http://bugs.python.org/issu
Eli Bendersky added the comment:
Serhiy - why did you remove that documentation bit?
--
___
Python tracker
<http://bugs.python.org/issue15296>
___
___
Python-bug
Changes by Eli Bendersky :
--
priority: -> deferred blocker
___
Python tracker
<http://bugs.python.org/issue14790>
___
___
Python-bugs-list mailing list
Un
Eli Bendersky added the comment:
Eric: your note appears to be fixed in the code.
Can this issue be closed?
--
nosy: +eli.bendersky
___
Python tracker
<http://bugs.python.org/issue14
Eli Bendersky added the comment:
Switching this to 3.3 only
Fixes for 1-3 committed in caea3c64442b
--
___
Python tracker
<http://bugs.python.org/issue13
Eli Bendersky added the comment:
Fixed in 3.3
Thanks for the patch
--
status: open -> closed
___
Python tracker
<http://bugs.python.org/issue15296>
___
___
Py
Eli Bendersky added the comment:
Done (except 5 and 6, which are non-issues on a second look)
--
status: open -> closed
versions: +Python 3.3 -Python 2.7
___
Python tracker
<http://bugs.python.org/issu
Eli Bendersky added the comment:
Serhiy, can you also take a look at #9458 - it may be related?
--
___
Python tracker
<http://bugs.python.org/issue1767
Eli Bendersky added the comment:
Closing, as I don't think it's terribly important to backport this.
--
resolution: -> fixed
status: open -> closed
___
Python tracker
<http://bugs.py
Eli Bendersky added the comment:
I agree with Serhiy that this is more of a documentation/understanding issue
than a real bug. I've clarified the doc of ElementTree.write a bit to make it
explicit what stream is expected for 'write'.
--
assignee: -> docs
Eli Bendersky added the comment:
About (1):
It's customary for Python to accept "truthful" values (like non-empty strings)
as True. I see no harm in that. Strict type-checking to boolean True in each
and every place is not necessary.
About (2):
Similarly, this isn't pr
Eli Bendersky added the comment:
I'm changing the issue name to reflect the direction it's taken. Florent, once
3.3 is branched, could you please refresh the patch vs. head for 3.4 (don't
forget the "what's new") and I'll review it for commit.
-
Eli Bendersky added the comment:
I'd also expand the doc of register_namespace to note what it should and
shouldn't be used for (once this feature is added).
--
___
Python tracker
<http://bugs.python.o
Eli Bendersky added the comment:
I agree, but this will now be delayed to 3.4, since it's not a bug-fixing
change in functionality.
P.S. is there any way to create a test for it?
--
assignee: -> eli.bendersky
priority: normal -> low
type: -> behavior
versions
Changes by Eli Bendersky :
--
versions: -Python 3.3
___
Python tracker
<http://bugs.python.org/issue15083>
___
___
Python-bugs-list mailing list
Unsubscribe:
Changes by Eli Bendersky :
--
nosy: -eli.bendersky
___
Python tracker
<http://bugs.python.org/issue10908>
___
___
Python-bugs-list mailing list
Unsubscribe:
Changes by Eli Bendersky :
--
nosy: -eli.bendersky
___
Python tracker
<http://bugs.python.org/issue9914>
___
___
Python-bugs-list mailing list
Unsubscribe:
Changes by Eli Bendersky :
--
nosy: -eli.bendersky
___
Python tracker
<http://bugs.python.org/issue10342>
___
___
Python-bugs-list mailing list
Unsubscribe:
Changes by Eli Bendersky :
--
nosy: -eli.bendersky
___
Python tracker
<http://bugs.python.org/issue9325>
___
___
Python-bugs-list mailing list
Unsubscribe:
Eli Bendersky added the comment:
ping
--
___
Python tracker
<http://bugs.python.org/issue14332>
___
___
Python-bugs-list mailing list
Unsubscribe:
Changes by Eli Bendersky :
--
nosy: -eli.bendersky
___
Python tracker
<http://bugs.python.org/issue13386>
___
___
Python-bugs-list mailing list
Unsubscribe:
Changes by Eli Bendersky :
--
nosy: -eli.bendersky
___
Python tracker
<http://bugs.python.org/issue10685>
___
___
Python-bugs-list mailing list
Unsubscribe:
Changes by Eli Bendersky :
--
nosy: -eli.bendersky
___
Python tracker
<http://bugs.python.org/issue13997>
___
___
Python-bugs-list mailing list
Unsubscribe:
Eli Bendersky added the comment:
Fixed the invariant violation in changeset 64ff90e07d71
I'll review the performance difference separately
--
___
Python tracker
<http://bugs.python.org/issu
Eli Bendersky added the comment:
I posted a message to python-dev about the performance issue
--
___
Python tracker
<http://bugs.python.org/issue1767933>
___
___
Eli Bendersky added the comment:
I agree. Any improvement is preferred over just letting this decay in the issue
tracker ;-)
--
___
Python tracker
<http://bugs.python.org/issue14
Eli Bendersky added the comment:
I tried blocking the import of 'pyexpat' in a test by using
test.support.import_fresh_module, placing 'pyexpat' into the blocked list, but
it doesn't work (i.e. pyexpat, if it
Eli Bendersky added the comment:
Benjamin, what "old behavior"? Did it happen to raise ImportError historically
and only recent changes made it RuntimeError? I'm not sure this is the case.
--
___
Python tracker
<http://bugs.pyt
Eli Bendersky added the comment:
Committed fixes to raise ImportError in both Python 3.2 and 3.3
At the moment no test added because I'm having trouble using
import_fresh_module to avoid re-importing of pyexpat in the etree tests (it
gets imported a
New submission from Eli Bendersky :
>From this pydev thread:
>http://mail.python.org/pipermail/python-dev/2012-July/120981.html
"BytesIO is actually missing an optimisation that is already used in
StringIO: the StringIO C implementation uses a fragment accumulator
internally, an
Eli Bendersky added the comment:
This optimization for StringIO was done in issue #13149
--
___
Python tracker
<http://bugs.python.org/issue15381>
___
___
Pytho
Eli Bendersky added the comment:
Frankly, I don't think the problem is serious enough to warrant a backport to
3.2, given that 3.3 gonna be out in a few weeks. The issue was open for 5 years
without anyone seriously complaining :)
--
___
P
Eli Bendersky added the comment:
I wonder if this is a fair comparison, Serhiy. Strings are unicode underneath,
so they have a large overhead per string (more data to copy around). Increasing
the length of the strings changes the game because due to PEP 393, the overhead
for ASCII-only
701 - 800 of 1229 matches
Mail list logo
