Eli Bendersky added the comment:
On Mon, Oct 28, 2013 at 6:00 AM, Martin Panter wrote:
>
> Martin Panter added the comment:
>
> The best way to work around it for me is just to ignore the warning. It
> doesn’t really worry me that much, I only noticed it while porting a
> p
Eli Bendersky added the comment:
Thanks for the report, Peter. This is indeed a documentation fix for Python
3.3; note that in 3.4 (default branch), the restriction was lifted and
iterparse now accepts any iterable sequence. The documentation also reflects
that (saying that 'events&
Changes by Eli Bendersky :
--
stage: -> needs patch
___
Python tracker
<http://bugs.python.org/issue19452>
___
___
Python-bugs-list mailing list
Unsubscrib
Changes by Eli Bendersky :
--
resolution: -> fixed
stage: needs patch -> committed/rejected
status: open -> closed
___
Python tracker
<http://bugs.python.or
Changes by Eli Bendersky :
--
nosy: -eli.bendersky
___
Python tracker
<http://bugs.python.org/issue16425>
___
___
Python-bugs-list mailing list
Unsubscribe:
Eli Bendersky added the comment:
Thanks for the report, Martin. I'll take a look once I get some time
--
___
Python tracker
<http://bugs.python.org/is
New submission from Eli Bendersky:
It was mentioned in one of the recent python-dev threads that making the Python
code-base simpler to encourage involvement of contributors is a goal, so I
figured this may be relevant.
I've recently written a new parser for the ASDL specification lan
Changes by Eli Bendersky :
--
nosy: +eric.snow
___
Python tracker
<http://bugs.python.org/issue19655>
___
___
Python-bugs-list mailing list
Unsubscribe:
Eli Bendersky added the comment:
FWIW, asdl_c.py could use some "modernization", but I'll defer this to a later
cleanup in order to do things gradually.
The same can be said for the Makefile rules - they can be simpler and more
efficient (no need to invoke asdl_c / parse the
Eli Bendersky added the comment:
Larry, ease your worries: note that I only tagged this on version 3.5!
That said, this parser runs during the build and produces a .h file and .c file
- these partake in the build; I verified that the generated code is *identical*
to before, so there'
Changes by Eli Bendersky :
--
nosy: -eli.bendersky
___
Python tracker
<http://bugs.python.org/issue13633>
___
___
Python-bugs-list mailing list
Unsubscribe:
Eli Bendersky added the comment:
Does anyone have comments on the code or can I prepare a patch for default?
Would it make sense to wait with this until the 3.4 branch is created or can I
just commit to default? Note that this change is not a new feature and is
essentially a no-op as far as
Eli Bendersky added the comment:
Antoine, am I missing something - I don't see documentation for the
construction of Path/PurePath?
--
nosy: +eli.bendersky
___
Python tracker
<http://bugs.python.org/is
Eli Bendersky added the comment:
Yes, I've seen that. What I mean is that there's no clear signature defined
with each argument explained, as the other stdlib documentation usually does.
Section 11.1.2.1 uses a more descriptive approach, while I was also expecting a
formal specifi
Eli Bendersky added the comment:
It's just a matter of looking for a familiar pattern while going over an
unfamiliar doc page, I guess. I'll give it a try and see if it helps.
Another question: What is the real purpose of pure paths? One thing I see is
using them to, say, manipula
Eli Bendersky added the comment:
>
>
> Antoine Pitrou added the comment:
>
> > Another question: What is the real purpose of pure paths? One thing I
> > see is using them to, say, manipulate Windows paths on a Posix machine
> > for some reason.
>
> Yes. Also
Eli Bendersky added the comment:
Larry Hastings added the comment:
>
> Are the generated files *byte for byte* the same as produced by the
> existing parser generation process?
>
Correct. The generator runs during the build (in the Makefile), but only if
the files were out-of-da
Eli Bendersky added the comment:
On Sun, Nov 24, 2013 at 2:58 PM, Larry Hastings wrote:
>
> Larry Hastings added the comment:
>
> The rule is, no new features. Bug and security fixes from now on.
>
> It isn't always clear whether or not something is a new "feat
Eli Bendersky added the comment:
Thanks for the clarifications, Antoine. I'll see if I can come up with a doc
patch that will try to emphasize these points. I'll probably just open a new,
doc-issue to stop overloading this one.
--
New submission from Eli Bendersky:
Following up from Issue #19673; The initial patch clarifies the use cases of
pure vs. concrete paths a bit and adds explicit signatures for the path class
constructors (moving the construction discussion under the parent class).
Also, IMHO an inheritance
Changes by Eli Bendersky :
--
keywords: +patch
Added file: http://bugs.python.org/file32858/issue19799.initial.patch
___
Python tracker
<http://bugs.python.org/issue19
Changes by Eli Bendersky :
--
keywords: -easy
___
Python tracker
<http://bugs.python.org/issue19624>
___
___
Python-bugs-list mailing list
Unsubscribe:
Changes by Eli Bendersky :
--
nosy: +eli.bendersky
___
Python tracker
<http://bugs.python.org/issue14910>
___
___
Python-bugs-list mailing list
Unsubscribe:
Eli Bendersky added the comment:
Attaching a new patch. Hopefully the image will be viewable in the code review
tool
--
Added file: http://bugs.python.org/file32869/issue19799.2.patch
___
Python tracker
<http://bugs.python.org/issue19
Eli Bendersky added the comment:
Just in case it isn't:
https://dl.dropboxusercontent.com/u/15602400/images/pathlib-inheritance.png
--
___
Python tracker
<http://bugs.python.org/is
New submission from Eli Bendersky:
Prefix matching behavior can lead to bugs when combined with parse_known_args.
See this thread for more details:
https://mail.python.org/pipermail/python-dev/2013-November/130601.html
Issue #14910 deals with making it optional, but until 3.5 we'll have
Eli Bendersky added the comment:
Here's a patch for 3.3; if it looks ok i'll merge it to default and also to 2.7
--
keywords: +patch
Added file: http://bugs.python.org/file32870/issue19814.doc33.patch
___
Python tracker
<http://bu
Eli Bendersky added the comment:
On Wed, Nov 27, 2013 at 6:21 AM, STINNER Victor wrote:
>
> STINNER Victor added the comment:
>
> Could you please attach the picture separatly?
>
>
Done
--
___
Python tracker
<http://bugs.
Changes by Eli Bendersky :
Added file: http://bugs.python.org/file32871/pathlib-inheritance.png
___
Python tracker
<http://bugs.python.org/issue19799>
___
___
Python-bug
Eli Bendersky added the comment:
>
> STINNER Victor added the comment:
>
> Which tool did you use to draw this schema? You may attach also the source
> if someone would like to modify it in the future.
>
Sorry, but there's no source. I drew it graphically. But since I did
Eli Bendersky added the comment:
I don't see how these implementation details are relevant. The patch adds a
link to the existing abbreviations section, which mentions parse_args - so it's
clear that this behavior exists in both.
Yes, #14910 (to which I pointed in the original messa
Eli Bendersky added the comment:
Thanks for the report & patches. Fixed in all active branches.
--
resolution: -> fixed
stage: needs patch -> committed/rejected
status: open -> closed
___
Python tracker
<http://bugs.pytho
Eli Bendersky added the comment:
If I don't see any further objections I'll go ahead and commit this by the end
of the week
--
___
Python tracker
<http://bugs.python.o
Eli Bendersky added the comment:
Committed in 90b56ec318b6
--
resolution: -> fixed
stage: patch review -> committed/rejected
status: open -> closed
versions: +Python 3.2 -Python 3.4, Python 3.5
___
Python tracker
<http://bugs.python.or
Changes by Eli Bendersky :
--
resolution: -> fixed
stage: -> committed/rejected
status: open -> closed
___
Python tracker
<http://bugs.python.or
Eli Bendersky added the comment:
Thanks. I left some comments in the code review tool
--
___
Python tracker
<http://bugs.python.org/issue19687>
___
___
Python-bug
Eli Bendersky added the comment:
Nosy-ing myself since I just ran into it. Annoying issue that precludes from
using argparse's builtin '-' recognition for reading binary data.
I'll try to carve some time later to look at the patches.
--
nosy: +eli.bendersky
v
Eli Bendersky added the comment:
The patch looks reasonable? Is the only remaining problem with crafting the
test?
--
___
Python tracker
<http://bugs.python.org/issue14
Eli Bendersky added the comment:
[sorry, the first question mark shouldn't be - the patch indeed looks
reasonable to me]
Steven - how about launching a subprocess for stdin tests to avoid weird issues?
--
___
Python tracker
<http://bugs.py
Eli Bendersky added the comment:
On Tue, Jun 24, 2014 at 2:29 PM, Ned Deily wrote:
>
> Ned Deily added the comment:
>
> The 3.3 branch is now only open for security fixes so this issue doesn't
> appear to warrant backporting there.
>
> --
>
These questio
Eli Bendersky added the comment:
On Tue, Jun 24, 2014 at 3:18 PM, Ned Deily wrote:
>
> Ned Deily added the comment:
>
> It is described in the developer's guide. The current status is
> summarized here:
>
> https://docs.python.org/devguide/devcycle.html#summary
Eli Bendersky added the comment:
Daniel, I left some comments in Rietveld. Also it doesn't seem that you
addressed the previously left comments when you fixed up the patch.
--
___
Python tracker
<http://bugs.python.org/is
Eli Bendersky added the comment:
No worries, Daniel. You should have received an email when comments were posted
to the review, did you? If you you may want to check your settings in the bug
tracker.
I left a couple of additional comments on the documentation file, but other
than that this
Eli Bendersky added the comment:
Ezio, could you see if your comments were addressed?
Steven, do you want to take another look, or is this OK to commit?
--
___
Python tracker
<http://bugs.python.org/issue14
Eli Bendersky added the comment:
>> I could continue the discussion about databases, but it feels like a waste
>> of time to me. The main principle is: If something has an important property
>> (in this case an enum object's numerical value), it should be publicly
>
Changes by Eli Bendersky :
--
nosy: -eli.bendersky
___
Python tracker
<http://bugs.python.org/issue18986>
___
___
Python-bugs-list mailing list
Unsubscribe:
Eli Bendersky added the comment:
The source for the diagram is here:
https://docs.google.com/drawings/d/1F8do-1WL1sIGkZuiufcxcpZRtS0w4SwAowq-Uamrwt8/edit?usp=sharing
Anyone - feel free to copy that doc over and create a new diagram with smaller
whitespacing. Let me know if there are any
Eli Bendersky added the comment:
Yep, the overriding of the type name was inadvertent. Nothing sacred about it,
so Ethan's SocketKind is just as good.
--
___
Python tracker
<http://bugs.python.org/is
Eli Bendersky added the comment:
Ethan, the patch you committed here seems obscure to me. Why __reduce_ex__ and
not __reduce__? Where are the accompanying documentation changes? Can you
clarify more how the full logic of pickling now works - preferably in comments
withing the code
Eli Bendersky added the comment:
I left some comments in #20653
As for cherry-picking this into 3.4, I'm not sure. Ethan - what is the worst
scenario this patch enables to overcome? Someone getting locked in to by-value
pickling with certain enums i
Eli Bendersky added the comment:
If you were enlightened about how to use the pickle protocols, please explains
this better in the code. Currently the code says:
# check for a supported pickle protocols, and if not present sabotage
+# pickling, since it won't work a
Eli Bendersky added the comment:
The discussion in #20653 is ongoing but I have to say I don't feel confident
about this issue at all.
If anything, I'd prefer to explicitly mark "advanced pickling support" for
enums as provisional in 3.4 - this is a simple documentation fi
Eli Bendersky added the comment:
> Many comments, Eli's and Serhey's code changes incorporated.
Looks better, thanks. I left some comments in Rietveld.
--
___
Python tracker
<http://bugs.pytho
Eli Bendersky added the comment:
Can you upload the new patch?
--
___
Python tracker
<http://bugs.python.org/issue20653>
___
___
Python-bugs-list mailin
Eli Bendersky added the comment:
The new "junk heuristic" has been added to difflib.py in SVN revision 26661 in
2002 (which is, incidentally, the last revision to modify difflib.py). Its
commit log says:
-
Mostly in SequenceMatcher.
New submission from Eli Bendersky :
This link: http://docs.python.org/dev/py3k/
Isn't working. I have always used it to see the latest documentation from 3.2,
and it is linked in the left-hand side of the screen on docs.python.org as
"Python 3.2 (in development)" under
Changes by Eli Bendersky :
--
type: -> behavior
___
Python tracker
<http://bugs.python.org/issue9160>
___
___
Python-bugs-list mailing list
Unsubscri
Eli Bendersky added the comment:
Thanks!
Now let's see what the other devs say. The first response seems not to have
understood what you meant completely :-)
Eli
On Wed, Jul 7, 2010 at 01:18, Terry J. Reedy wrote:
>
> Terry J. Reedy added the comment:
>
> [Also po
Changes by Eli Bendersky :
Removed file: http://bugs.python.org/file17891/unnamed
___
Python tracker
<http://bugs.python.org/issue2986>
___
___
Python-bugs-list mailin
Eli Bendersky added the comment:
I apologize for the previous message. It was created by mistake - by replying
to Terry's mail which came from the bugtracker.
I wish I knew how to remove it from here - is this possible and I'm missing the
relevant
Changes by Eli Bendersky :
--
nosy: +eli.bendersky
___
Python tracker
<http://bugs.python.org/issue9132>
___
___
Python-bugs-list mailing list
Unsubscribe:
Eli Bendersky added the comment:
I agree with Terry's proposal. Here's a patch file for
Doc/reference/expressions.rst that implements the change.
--
Added file: http://bugs.python.org/file17967/issue9132.2.patch
___
Python trac
Eli Bendersky added the comment:
Attaching a patch file for Lib/idlelib/IOBinding.py, diffed against the latest
SVN trunk.
--
keywords: +patch
nosy: +eli.bendersky
Added file: http://bugs.python.org/file17968/issue9122.1.patch
___
Python tracker
New submission from Eli Bendersky :
The documentation of the standard 'trace' module (Doc/library/trace.rst) is
sorely lacking. Arguments are not explained, some key methods are not
documented at all, and the CoverageResults class isn't documented.
Usage of these appears in
Eli Bendersky added the comment:
I would like to submit a patch here. However, a decision has to be reached as
for what to do exactly.
The most straightforward approach is remove the extension of types_map in the
SimpleHTTPServer code. Is this acceptable, or are there hidden problems
Changes by Eli Bendersky :
--
nosy: +eli.bendersky
___
Python tracker
<http://bugs.python.org/issue9214>
___
___
Python-bugs-list mailing list
Unsubscribe:
New submission from Eli Bendersky :
Running:
py3d -m trace -C . --listfuncs trace_target.py
Where py3d points to a freshly compiled Python 3 trunk interpreter, results in
an error:
functions called:
Traceback (most recent call last):
File "/home/eliben/python_src/eliben-py3k/Lib/run
Eli Bendersky added the comment:
The fix is simple one-liner, so here's a patch.
--
keywords: +patch
Added file: http://bugs.python.org/file18038/issue9282.1.patch
___
Python tracker
<http://bugs.python.org/i
New submission from Eli Bendersky :
Due to a discussion on python-dev (Subject: "Markup of command-line options in
Python's .rst documentation"), Georg Brandl checked in revision r82961 with a
clarification of :option: markup which should only be used for Python
interpre
Eli Bendersky added the comment:
Patch
--
keywords: +patch
Added file: http://bugs.python.org/file18080/issue9312.1.patch
___
Python tracker
<http://bugs.python.org/issue9
Eli Bendersky added the comment:
Terry,
Re doctest.rst - appears to be a merging issue. I will see how to resolve it
once we figure out what to do with :program:
Éric,
Good point - I'll ask pydev and will update the patch accord
New submission from Eli Bendersky :
Brought up in issue 9282: unit tests should be added for the trace module.
Minor naming problem: Lib/test/test_trace.py is currently employed for testing
the sys.settrace method.
Suggestion: name the unit tests of the trace module test_trace_module.py
Eli Bendersky added the comment:
I've opened issue 9315 to address the lack of unit tests for trace.py
I think that this should be committed regardless, since it fixes a serious bug
in the module. Adding unit tests can take time, and is less cri
Eli Bendersky added the comment:
Even the following simple test file:
--
import pickle
data = {'a' : [1, 2, 3], 'b': 5}
ps = pickle.dumps(data)
newdata = pickle.loads(ps)
print(newdata)
--
When traced generates an empty trace file f
Eli Bendersky added the comment:
I didn't hit refresh before posting so didn't see your message, Alexander. The
problem indeed seems to be deeper.
--
___
Python tracker
<http://bugs.python.
Eli Bendersky added the comment:
trace.py uses settrace to do its heavy lifting. In the "local trace" function
for counting, localtrace_count:
def localtrace_count(self, frame, why, arg):
if why == "line":
filename = frame.f_code.co_filenam
Eli Bendersky added the comment:
Alexander,
I propose an alternative patch (attached issue9317.2.diff). It uses:
with open(progname) as fp:
code = compile(fp.read(), progname, 'exec')
t.run(code)
Since the `run` method of Trace already
Eli Bendersky added the comment:
<<<<
Your new patch makes perfect sense, but can you check of regular
python invocation uses runpy these days. If it does, it may make sense
to include it in trace at least optionally.
>>>>
I'm not sure I understand what you m
Eli Bendersky added the comment:
>
> Sorry, typing on the phone. s/of/if/ in my message above. What I mean
> is that as far as I know, when you run a script from command line,
> python loads it using functions in runpy. Arguably this means that
> these functions should show
New submission from Eli Bendersky :
[This bug was discovered by Alexander Belopolsky, during the work on Issue 9317]
Bug report
**
The attached traceme.py file demonstrates the following problem:
With python 2.7:
$ python2 -m trace -c -s traceme.py
lines cov% module (path
Changes by Eli Bendersky :
--
components: +Library (Lib)
keywords: +patch
Added file: http://bugs.python.org/file18106/issue9323.1.patch
___
Python tracker
<http://bugs.python.org/issue9
Eli Bendersky added the comment:
1. I've created Issue 9323 to address the bug with __main__, with the proposed
patch.
2. Agreed about the unit tests (Issue 9315). I'll try to get the basic testing
framework for trace.py created over t
Eli Bendersky added the comment:
Attaching a patch vs. the 2.6 maintenance branch for the Doc/library/trace.rst
file
* Fixed some formatting issues for command line options and class references
* Documented all relevant user-accessible methods
* Divided command-line options logically into sub
Eli Bendersky added the comment:
Here's a patch for Doc/library/difflib.rst of the 2.6 branch, following Terry's
suggested addition to the docs of the SequenceMatcher class.
Tested 'make html'.
--
keywords: +patch
Added file: http://bugs.python.org/file18171/issu
New submission from Eli Bendersky :
The first paragraph in its documentation says:
"""
In the Python interpreter, do "from pydoc import help" to provide online
help. Calling help(thing) on a Python object documents the object.
"""
Which is no longer a
Eli Bendersky added the comment:
I'm attaching a file with some unit tests for Lib/trace.py module in Python
2.7. Currently the unit tests check the API only, for line counting, func call
counting and function caller relationships, because these can be tested through
the API, wi
Eli Bendersky added the comment:
Alexander,
1. Done
2. Done
3. Done. Made docstrings follow PEP 257, to the best of my understanding
4. Done. Attached patch is made on fresh SVN 2.7 branch, file renamed to
test_trace.py and 'svn add' executed
5. I'm not sure I agree with yo
Changes by Eli Bendersky :
Removed file: http://bugs.python.org/file18205/test_trace.py
___
Python tracker
<http://bugs.python.org/issue9315>
___
___
Python-bugs-list m
Changes by Eli Bendersky :
--
keywords: +patch
Added file: http://bugs.python.org/file18206/issue9315.1.patch
___
Python tracker
<http://bugs.python.org/issue9
Eli Bendersky added the comment:
Hello,
I'm attaching a patch for this issue.
1. _from_iterable in KeysView and ItemsView overridden as per Daniel's
suggestion (Lib/_abcoll.py)
2. Added a test case to Lib/test/test_collections.py that uses this test case
(creates the subclass an
Eli Bendersky added the comment:
The test failure of the py3k ports boils down to this: the 'runfunc' method of
'Trace' appears as a caller to '_traced_func_importing_caller'. In 2.7 it
appears as 'Trace.runfunc', in py3k as just 'runfunc'
Eli Bendersky added the comment:
Attaching an updated patch, with the trailing whitespace removed. Hope it's
more acceptable now.
P.S. Please let me know how to detect such issues in future patches.
--
Added file: http://bugs.python.org/file18267/issue9214.2.
Eli Bendersky added the comment:
Some more unit tests show that a problem with method names exists in
Lib/trace.py even in 2.7 (and probably earlier). When tracing an instance
method with `runfunc`, its name is reported as follows:
ClassName'>.method_name
In
Eli Bendersky added the comment:
Attaching new patch. This patch is for 2.7 (as you suggested earlier, since
it's easy to forward-port to py3k with 2to3) and affects Misc/NEWS,
Lib/trace.py and Lib/test/test_trace.py (which is added).
In Lib/trace.py:
- Fixed the problem with class
Eli Bendersky added the comment:
Ouch, sorry Here it is (issue9315.1.patch)
--
Added file: http://bugs.python.org/file18275/issue9315.2.patch
___
Python tracker
<http://bugs.python.org/issue9
Changes by Eli Bendersky :
Removed file: http://bugs.python.org/file18269/issue9315.1.patch
___
Python tracker
<http://bugs.python.org/issue9315>
___
___
Python-bug
Eli Bendersky added the comment:
[I wish I could edit/delete my older messages]
I've attached a new file, named issue9315.2.patch, with the updated patch. I
usually add a numeric prefix before the .patch ending to distinguish
consecutive versions of the same patch, and in this case I
Eli Bendersky added the comment:
Alexander,
Your issue9315.3.patch file doesn't contain the new test module at all.
I'm attaching the updated test_trace.py, fixing the problem with running via
regrtest. The problem was very simple and not about the fake module - I fixed
to r
Eli Bendersky added the comment:
I see a curious behavior with the test runs. To reproduce:
1. Clean up .pyc files in test/ dir
2. Run: py27 regrtest.py -v test_trace---> SUCCESS
3. Run again: py27 regrtest.py -v test_trace---> FAIL
Initial investigation points to my usage of __
Eli Bendersky added the comment:
The single test-runner in regrtest.py (runtest_inner) uses the standard import
machinery (__import__) to load tests. Thus, is the test has been loaded
recently (**) it is reloaded from its .pyc file. In such a case, its module
__file__ var points to the .pyc
1001 - 1100 of 1229 matches
Mail list logo
