Eli Bendersky added the comment:
Indeed, unix_terminate is invoked on Windows, and since Windows now has
"os.kill" it runs. However, it appears that the actual os.kill call throws
OSError, saying:
[Error 87] The parameter is
Eli Bendersky added the comment:
Here's a simple reproducer for the same problem, without the context of IDLE.
As far as I understand, what IDLE's spawn and then kill process are doing is:
import os
from signal import SIGTERM
pid = os.spawnv(os.P_NOWAIT, "notepad.exe&
Eli Bendersky added the comment:
Georg, I'm now debugging into win32_kill, and it's an error in OpenProcess, so
this *could* be a security issue.
The process is started with _spawnv, so maybe this causes problems opening it
with OpenPro
Eli Bendersky added the comment:
According to
http://msdn.microsoft.com/en-us/library/7zt1y878%28v=vs.80%29.aspx, on Windows
_spawnv in async mode (P_NOWAIT) returns the process _handle_, not the process
ID.
win32_kill uses OpenProcess, passing it pid to obtain the handle, but this pid
is
Eli Bendersky added the comment:
I don't think there's a problem with os.spawnv and os.kill - they do what their
docs describe.
IMHO, the solution should be to change IDLE so that it uses subprocess.Popen
for both starting and killing the chi
Eli Bendersky added the comment:
OK, the bots are green again after the last push.
Sorry about that, folks. I tested this on two different machines (Ubuntu & Win
XP) before pushing the original commit.
--
___
Python tracker
&
Eli Bendersky added the comment:
Terry,
What still bugs me is that it isn't clear what change from 3.2 to 3.2.1 caused
this problem to manifest.
Also, I'm not sure why you mention the sockets vs. pipes issue.
--
___
Python trac
Changes by Eli Bendersky :
--
nosy: +eli.bendersky
___
Python tracker
<http://bugs.python.org/issue5441>
___
___
Python-bugs-list mailing list
Unsubscribe:
Eli Bendersky added the comment:
Terry, I'd like to move this forward. New interfaces or not, making the
documentation more comprehensible is an important goal in itself.
Could you please comment on rurpy2's latest notes - I will adapt the patch for
latest 2.7/3.2/3.3 heads and
Changes by Eli Bendersky :
--
nosy: -eli.bendersky
___
Python tracker
<http://bugs.python.org/issue12043>
___
___
Python-bugs-list mailing list
Unsubscribe:
Changes by Eli Bendersky :
--
nosy: -eli.bendersky
___
Python tracker
<http://bugs.python.org/issue2091>
___
___
Python-bugs-list mailing list
Unsubscribe:
Changes by Eli Bendersky :
--
nosy: +eli.bendersky
___
Python tracker
<http://bugs.python.org/issue12642>
___
___
Python-bugs-list mailing list
Unsubscribe:
New submission from Eli Bendersky :
The 'a' conversion type isn't documented in library/stdtypes.rst
--
assignee: eli.bendersky
components: Documentation
keywords: gsoc
messages: 141228
nosy: eli.bendersky
priority: low
severity: normal
status: open
title: document the
Eli Bendersky added the comment:
%r has note (5) saying "The precision determines the maximal number of
characters used."
Does this apply to %a as well?
Other than that, LGTM
--
___
Python tracker
<http://bugs.python.o
Eli Bendersky added the comment:
Yeah, the note should probably be clarified to mention that if precision is
specified, only the first precision characters will be shown. The field width
is covered globally (for all conversion types) in note 4 above the table.
While we're at it, note
Eli Bendersky added the comment:
Looks good. How about also adding some tests for the original request of
supporting bytearrays in ljust/rjust/center?
--
___
Python tracker
<http://bugs.python.org/issue12
New submission from Eli Bendersky :
>From Ezio Melotti's email to python-dev:
diff --git a/Doc/library/test.rst b/Doc/library/test.rst
--- a/Doc/library/test.rst
+++ b/Doc/library/test.rst
@@ -447,7 +447,7 @@
Module and package deprecation messages are suppresse
Eli Bendersky added the comment:
It appears this breaks "make patchcheck" in trunk:
./python ./Tools/scripts/patchcheck.py
Getting the list of files that have been added/changed ... 5 files
Fixing whitespace ... Traceback (most recent call last):
File "./Tools/scripts/patch
Eli Bendersky added the comment:
Petri, thanks for the patch. I've updated Misc/NEWS and committed it.
Unless there are objections or problems, I will close this issue in a day or
two.
--
resolution: -> fixed
stage: patch review -> committ
Changes by Eli Bendersky :
--
priority: normal -> high
stage: committed/rejected -> needs patch
___
Python tracker
<http://bugs.python.org/issue10639>
___
__
Eli Bendersky added the comment:
This is a good example of why passing parameters into functions by means of
globals sucks. In reindent.py, main() sets the spec_newline global which
check() uses, but this was forgotten in patchcheck.py which also uses
reindent.check()
IMHO reindent.py
Eli Bendersky added the comment:
Terry,
""" When I tried the same fix in idlelib/PyShell.py, adding 'import subprocess'
and changing
self.rpcpid = os.spawnv(os.P_NOWAIT, sys.executable, args)
to
self.rpcpid = subprocess.Popen(args).pid
(args begins
Eli Bendersky added the comment:
Ezio, I've taken the liberty to adapt your patch with the suggested fixes and
commit it to both 3.2 and 3.3
If everything is OK, this issue can be close (I'll do it in a few days if no
one
Changes by Eli Bendersky :
--
resolution: -> fixed
status: open -> closed
___
Python tracker
<http://bugs.python.org/issue12644>
___
___
Python-bugs-list
New submission from Eli Bendersky :
First step in transition:
Attaching a patch to devguide's runtests.rst to incorporate existing
test.support documentation from 3.3 head, with some small markup changes
suitable for the devguide.
--
components: Devguide
files: devguide_test_su
Changes by Eli Bendersky :
--
nosy: +eli.bendersky
___
Python tracker
<http://bugs.python.org/issue11699>
___
___
Python-bugs-list mailing list
Unsubscribe:
Eli Bendersky added the comment:
Petri,
I think the "to" after "belongs" is redundant.
Also, the issue lists 3.2 and 3.3 - is the fix relevant there too? If yes, can
you prepare a patch for 3.2? (I will merge it to 3.3 too)
--
__
Eli Bendersky added the comment:
I've committed a fix into 2.7, taking Terry's advice ("in function calls"
subsection instead of "statement") and Eric's sequence/iterable correction into
account.
If this looks OK, I will commit a simi
Eli Bendersky added the comment:
Éric - when I was just starting contributing patches to Python, I was strictly
disciplined by veteran devs to stay within 80 chars no matter what :-)
--
___
Python tracker
<http://bugs.python.org/issue12
Eli Bendersky added the comment:
Jason, one way or another, a prompt fix for trunk is required, since `make
patchcheck` is an important step for committing patches.
--
___
Python tracker
<http://bugs.python.org/issue10
Eli Bendersky added the comment:
"make patchcheck" is working again.
Thanks
--
Added file: http://bugs.python.org/file22798/unnamed
___
Python tracker
<http://bugs.python.org/issue10639>
___
Changes by Eli Bendersky :
--
resolution: -> fixed
status: open -> closed
___
Python tracker
<http://bugs.python.org/issue12531>
___
___
Python-bugs-list
Changes by Eli Bendersky :
--
status: open -> closed
___
Python tracker
<http://bugs.python.org/issue12380>
___
___
Python-bugs-list mailing list
Unsubscri
Eli Bendersky added the comment:
Attaching an initial patch for Lib/idlelib/PyShell.py
It uses subprocess.Popen instead of spawn&kill, in the way discussed in earlier
messages.
As far as I can tell, IDLE opens and restarts shells successfully, without
leaving zombies behind. I only te
Eli Bendersky added the comment:
I've now tested this on Ubuntu Linux as well. IDLE works, no zombies left
behind.
--
keywords: -patch
___
Python tracker
<http://bugs.python.org/is
Eli Bendersky added the comment:
Armin, adding you as the optparse expert - could you see the doc change makes
sense?
[I will then do the commit work]
--
nosy: +aronacher
___
Python tracker
<http://bugs.python.org/issue11
Eli Bendersky added the comment:
Done.
Petri - thanks for the contribution.
--
resolution: -> fixed
status: open -> closed
___
Python tracker
<http://bugs.python.org/i
Eli Bendersky added the comment:
Nick, fair enough, but I think it would be more appropriate (and useful) to
close this issue as rejected and open a new one.
--
___
Python tracker
<http://bugs.python.org/issue12
Eli Bendersky added the comment:
Georg, since the issue was originally opened to track the solution, not the
problem, I just figured it may be useful to mention that this solution was
rejected and close the issue, for better historical record. Otherwise some
years from now no one will
New submission from Eli Bendersky :
Reading the C API documentation: extending/newtypes.html
Some problems:
1. In the first paragraph of 2.1 - "to distinguish them from things like
[].append", it's unclear what [].append is. Maybe "[] and append"?
2. The C coding conv
Eli Bendersky added the comment:
Vinay, I can't reproduce your problem here (tried installing Python and running
from there), but I suspect it's a sys.path issue (you don't have os.curdir on
it, I do). Please let me know
Eli Bendersky added the comment:
Vinay, great news. Thanks.
--
___
Python tracker
<http://bugs.python.org/issue11049>
___
___
Python-bugs-list mailing list
Unsub
Eli Bendersky added the comment:
On Fri, Aug 5, 2011 at 09:43, Ned Deily wrote:
>
> Ned Deily added the comment:
>
> With Eli's concurrence, I have applied the updated patch to 3.2 (for 3.2.2)
> and to default (for 3.3).
>
> --
>
Tested this on Windows
Eli Bendersky added the comment:
Éric,
I know perfectly well that [].append is valid Python, but I don't think this is
the clearest way to give an example of an object method. I think spelling
[].append's meaning more explicitly would be better.
I'm also aware that there are t
Changes by Eli Bendersky :
--
keywords: -easy
versions: +Python 3.3 -Python 2.7
___
Python tracker
<http://bugs.python.org/issue12672>
___
___
Python-bugs-list m
Eli Bendersky added the comment:
> Would it be clearer if we replaced the literal with a name?
>
> These C functions are called “type methods” to distinguish them from
> - things like [].append (which we call “object methods”).
> + methods bound to specific instanc
Eli Bendersky added the comment:
Maybe it should say:
"... to distinguish them from custom class methods such as list's append"
I think this is more correct, because it clearly refers to the methods placed
in the 'tp_methods' field of a type.
... and also drop t
Eli Bendersky added the comment:
Terry, I'm not 100% sure about what you mean by "Python wrapper objects ...
visible from Python", but I think I'll disagree.
There's a big difference between "C functions" in general and "type methods"
this doc
Eli Bendersky added the comment:
"[].append is a Python-level method object that wraps a C function."
What makes you think that? There's no Python implementation of .append that I
know of. Neither is there a Python implementation of the Noddy.name method that
is discussed in
New submission from Eli Bendersky :
User report (Jiachang Xu) from the docs mailing list:
The theading.Condition.notify method has a parameter - n, which isn't
documented in the the documentation of the threading module.
1. The parameter should be documented
2. notify() is mentioned mul
New submission from Eli Bendersky :
The threading module has very few methods with docstrings. Docstrings should be
added to all public methods (contents can be borrowed from the documentation).
--
assignee: docs@python
components: Documentation
keywords: easy
messages: 142247
nosy
Eli Bendersky added the comment:
Opened Issue 12768 on the general lack of docstrings in the threading module
--
___
Python tracker
<http://bugs.python.org/issue12
Eli Bendersky added the comment:
David, while you make a valid point, consider that 'n' is part of the public
API of the threading module (although not documented) and it's conceivable that
there is existing code "in the wild" using it. To do what you suggest we s
Eli Bendersky added the comment:
I asked the user who reported this documentation omission what he's using the
'n' argument for. His reply:
"Yes I am using the n parameter, it is mainly to implement a subclass of
Queue that supports "bulk" get and put
Changes by Eli Bendersky :
--
resolution: -> fixed
status: open -> closed
___
Python tracker
<http://bugs.python.org/issue12672>
___
___
Python-bugs-list
Eli Bendersky added the comment:
Wouldn't it be better to just add the flag to the example and then explain it
in a few sentences?
--
nosy: +eli.bendersky
___
Python tracker
<http://bugs.python.org/is
Eli Bendersky added the comment:
On Mon, Aug 22, 2011 at 07:39, Graeme Cross wrote:
>
> Graeme Cross added the comment:
>
> Threading module docstrings added for all classes and public methods;
> mainly used a summarised version of information from the documentation.
>
Th
Changes by Eli Bendersky :
Removed file: http://bugs.python.org/file22987/unnamed
___
Python tracker
<http://bugs.python.org/issue12768>
___
___
Python-bugs-list mailin
Eli Bendersky added the comment:
Graeme - could you specify which version of Python this patch applies to?
--
___
Python tracker
<http://bugs.python.org/issue12
Eli Bendersky added the comment:
The usual procedure for committing to both 3.2 and 3.3 is to apply a patch to
3.2 and then merge it to 3.3 - could you check if the patch also works for 3.2
and if not, generate a patch for 3.2? I will do the merge when committing
New submission from Eli Bendersky :
User report from docs@python:
On
http://docs.python.org/faq/programming.html
for i in range[3]:
Should be:
for i in range(3):
--
assignee: docs@python
components: Documentation
keywords: easy
messages: 142952
nosy: docs@python, eli.bendersky
Eli Bendersky added the comment:
Éric, yeah I received an email. Hopefully Graeme did too.
It's a shame a new review isn't notified in the tracker instead.
--
___
Python tracker
<http://bugs.python.o
New submission from Eli Bendersky :
In the 2.7 docs, re.compile has this signature:
re.compile(pattern[, flags])
>From here it isn't clear what the default value of 'flags' is, to be able to
>write code like this:
re.compile(pattern, re.I if options['ignor
Eli Bendersky added the comment:
Ezio,
"but using ints instead of flags is discouraged (see #11957). OTOH there's no
re.NOFLAGS flag that can be used instead."
Indeed, there's no re.NOFLAGS, and as I mentioned the 3k docs mention 0 as the
default value, thus (in a way)
Eli Bendersky added the comment:
Regarding backporting 106ee4eb5970 - it's probably a good thing to do but I
wouldn't mix it with this issue.
--
___
Python tracker
<http://bugs.python.o
Changes by Eli Bendersky :
--
nosy: +eli.bendersky
___
Python tracker
<http://bugs.python.org/issue11155>
___
___
Python-bugs-list mailing list
Unsubscribe:
Eli Bendersky added the comment:
Alexander, I agree that the documentation isn't yet in a perfect state and can
be further improved. Since there's still time for the next milestone of 3.2,
there's no reason not to improve it.
So I'm open to ideas and am willing to submit
Eli Bendersky added the comment:
Compiling py3k from main repo doesn't work:
ould not find platform dependent libraries
Consider setting $PYTHONHOME to [:]
Traceback (most recent call last):
File "/home/eliben/python_src/eliben-py3k/Lib/site.py", line 540, in
main()
Fil
Eli Bendersky added the comment:
`make distclean` worked for me (tipped at #python-dev), after it ./configure
and make succeeded. I must say it's not 100% intuitive, I'm used to just using
`make clean` for a complete cleanup.
--
___
Pyth
Eli Bendersky added the comment:
Attaching a patch (developed jointly with Terry Reedy) for 2.7 that adds an
'autojunk' parameter to SequenceMatcher's constructor. The parameter is True by
default which retains the current behavior in 2.6 and earlier, but can be set
by the u
New submission from Eli Bendersky :
The Py_Main function has a section under #ifdef __INSURE__ at the end, where it
does:
_Py_ReleaseInternedStrings();
_Py_ReleaseInternedUnicodeStrings();
The first function doesn't exist in Python 3K, so there will be a compile error
with __INS
Changes by Eli Bendersky :
--
nosy: +eli.bendersky
___
Python tracker
<http://bugs.python.org/issue1397474>
___
___
Python-bugs-list mailing list
Unsubscribe:
Eli Bendersky added the comment:
Terry,
I'm attaching a patch for 2.7, however it's more proof-of-concept than final,
because I have a few comments. The patch generally implements your
documentation suggestion without the `import *` warning and without adding the
final example.
Eli Bendersky added the comment:
Barry, I've taken the liberty to add you to the nosy list because I found in
the logs you've originally added this code (in 2001!!)
I hope it's OK with you :-)
--
nosy: +barry
___
Python
Eli Bendersky added the comment:
Is it really *interesting* to trace separate parts of list comprehensions
like this? What would one want to do that? The only idea I have in mind of
perhaps for comprehensions containing 'if's, to know how many times the
comprehension was actually exe
New submission from Eli Bendersky :
The following minor issues may affect the readability of the code implementing
symbol tables in Include/symtable.h and Python/symtable.c
* The comment for st_global in symtable.h says: "borrowed ref to
st_top->st_symbols. typo? (st_top->
Changes by Eli Bendersky :
--
title: Cosmetic issues that might be worthy a fix in symtable.h/c -> Cosmetic
issues that may warrant a fix in symtable.h/c
___
Python tracker
<http://bugs.python.org/iss
Eli Bendersky added the comment:
Adding a documentation patch for 3.1 which is similar to the 2.6 documentation
patch that's been committed by Georg into 2.6
--
Added file: http://bugs.python.org/file19538/issue2986.docs31.1.patch
___
P
Eli Bendersky added the comment:
Attaching a new patch for 2.7 freshly generated vs. current 2.7 maintenance
branch from SVN.
--
Added file: http://bugs.python.org/file19569/issue2986.fix27.5.patch
___
Python tracker
<http://bugs.python.
Eli Bendersky added the comment:
On Fri, Nov 12, 2010 at 05:05, Terry J. Reedy wrote:
Please let me know if there are problems applying it and with which
versions, I will fix it up to bring it up to date. It's a tricky patch
(affects many files in many places), so there might be difficu
Eli Bendersky added the comment:
Alexander, http://bugs.python.org/file19553/trace-deprecations.diff looks good
to me
--
___
Python tracker
<http://bugs.python.org/issue10
Eli Bendersky added the comment:
Alexander,
I'm submitting a patch for Doc/library/trace.rst for 3.2, incorporating the
stylistic changes you propose.
It would be really great to see this fixed for the next release of 3.2, since
the documentation improvement is major, and it's
Eli Bendersky added the comment:
On Thu, Feb 24, 2011 at 05:26, Éric Araujo wrote:
>
> Éric Araujo added the comment:
>
> Ray: Eli can just refresh his patch and commit. Note that the patch program
> will prompt you for a file name if it can’t find the file for a diff hunk,
Changes by Eli Bendersky :
--
nosy: +ncoghlan
___
Python tracker
<http://bugs.python.org/issue10516>
___
___
Python-bugs-list mailing list
Unsubscribe:
Eli Bendersky added the comment:
A slightly revised patch committed in revision 88554:
1. Fixed Éric's whitespace comment
2. Fixed a test in test_descrtut.py which was listing list's methods
3. Moved the change to collections.py onto Lib/collections/__init__.py
4. Added NEWS entry
É
Eli Bendersky added the comment:
Following the python-dev discussion, attaching a patch for removing fcmp and
replacing its uses with assertAlmostEqual when needed.
All tests pass and patchcheck is clean.
Please review before I commit.
--
nosy: +terry.reedy
Added file: http
Eli Bendersky added the comment:
Georg,
Good catch on the tuples in assertAlmostEqual, thanks! I see three methods of
resolution:
1. Since the floats in this case are powers of 1/2, they could be tested for
exact equality, or do you figure there are platforms where this is not
guaranteed
Eli Bendersky added the comment:
Attaching a revised patch with (2) implemented.
--
Added file: http://bugs.python.org/file20885/issue11015.py3k.remove_fcmp.2.patch
___
Python tracker
<http://bugs.python.org/issue11
Eli Bendersky added the comment:
On Fri, Feb 25, 2011 at 10:11, Georg Brandl wrote:
>
> Georg Brandl added the comment:
>
> Reading "clear and copy are not supported by bytearray": shouldn't they be?
Perhaps they should, and it's not a big deal to implemen
Eli Bendersky added the comment:
> Georg Brandl added the comment:
>
> Yes, that looks good now.
>
Thanks. fcmp & FUZZ removal committed in revision 88558
--
___
Python tracker
<http://bugs.py
Eli Bendersky added the comment:
Attaching a patch adding copy() and clear() to bytearrays, with tests and doc.
I didn't add the methods to MutableSequence because I have a doubt about it -
in particular which exception get raised by .pop if it's empty. Curiously,
lists and bytear
Eli Bendersky added the comment:
Committed the bytearray methods in revision 88733.
Closing this issue. Will handle wrong exception and MutableSequence ABC method
addition in separate issues.
--
status: open -> closed
___
Python tracker
&l
New submission from Eli Bendersky :
bytearray.pop() currently throws OverflowError when popping an empty bytearray,
instead of IndexError.
See Issue #10516 for reference discussion.
--
assignee: rhettinger
components: Interpreter Core
keywords: easy, needs review
messages: 129989
nosy
Eli Bendersky added the comment:
The attached patch changes the exception thrown to IndexError, as well as
aligning the error message to the one thrown by list.
--
keywords: +patch
Added file: http://bugs.python.org/file20986/issue11386.1.patch
New submission from Eli Bendersky :
Now that both list and bytearray support the clear() method (see issue #10516),
MutableSequence.clear() has to be implemented.
This is pending on commit for issue #11386, which fixes the exception thrown by
bytearray.pop() when the bytearray is empty
Eli Bendersky added the comment:
Committed into py3k, revision 88735
--
assignee: eli.bendersky -> rhettinger
resolution: accepted ->
versions: -Python 3.2
___
Python tracker
<http://bugs.python.org/i
Eli Bendersky added the comment:
Committed into release32-maint, revision 88739
--
___
Python tracker
<http://bugs.python.org/issue11386>
___
___
Python-bug
Eli Bendersky added the comment:
Can't find other instances of this bug, so I'm closing the issue.
--
status: open -> closed
___
Python tracker
<http://bugs.pytho
Eli Bendersky added the comment:
Committed in revision 88740
The non-abstract methods of MutableSequence and other classes currently seem to
have no unit-tests. Any ideas about the best testing strategy for them?
--
___
Python tracker
<h
Eli Bendersky added the comment:
Indeed it does - good catch :-)
I'll backport to 2.7 soon
--
___
Python tracker
<http://bugs.python.org/issue11386>
___
___
101 - 200 of 1229 matches
Mail list logo
