Dong-hee Na added the comment:
@pablogsal
I agree with hotfix is needed and also for discussion.
I left a comment for PR 18118. Please take a look :)
--
___
Python tracker
<https://bugs.python.org/issue39
New submission from Dong-hee Na :
./python.exe -m pyperf timeit -s 'a = [1]*100' 'a.count(1)'
Current Master: Mean +- std dev: 1.05 us +- 0.03 us
My patch: Mean +- std dev: 423 ns +- 11 ns
This is the side-effect of pr 17022.
--
assignee: corona10
messages: 3
Change by Dong-hee Na :
--
nosy: +inada.naoki, pablogsal, vstinner
___
Python tracker
<https://bugs.python.org/issue39425>
___
___
Python-bugs-list mailin
Change by Dong-hee Na :
--
keywords: +patch
pull_requests: +17506
stage: -> patch review
pull_request: https://github.com/python/cpython/pull/18119
___
Python tracker
<https://bugs.python.org/issu
Change by Dong-hee Na :
--
versions: +Python 3.7
___
Python tracker
<https://bugs.python.org/issue39425>
___
___
Python-bugs-list mailing list
Unsubscribe:
New submission from Dong-hee Na :
./python.exe -m pyperf timeit "a = 3.5" "b = a // 2"
AS-IS: Mean +- std dev: 377 ns +- 4 ns
my patch: Mean +- std dev: 204 ns +- 2 ns
--
assignee: corona10
messages: 360559
nosy: corona10
priority: normal
severity: normal
status: o
Change by Dong-hee Na :
--
type: -> performance
___
Python tracker
<https://bugs.python.org/issue39434>
___
___
Python-bugs-list mailing list
Unsubscrib
Change by Dong-hee Na :
--
keywords: +patch
pull_requests: +17533
stage: -> patch review
pull_request: https://github.com/python/cpython/pull/18147
___
Python tracker
<https://bugs.python.org/issu
Dong-hee Na added the comment:
> Is this worth optimizing? Floating-point floor division is a comparatively
> rare operation.
1. I don't want to say that this should always be optimized.
2. However, this operation is a relatively primitive python operation. I think
this optimizat
Dong-hee Na added the comment:
And on the other side,
>>> 3.8 // 0.0
Traceback (most recent call last):
File "", line 1, in
ZeroDivisionError: float divmod()
I think that people expect
ZeroDivisionError: float floor division by zero
not the current message.
I caugh
Dong-hee Na added the comment:
> (e.g., because someone decides to "fix" the floor float division)
Okay, what if we create a common divmod function except for creating a tuple?
--
___
Python tracker
<https://bugs.pytho
Dong-hee Na added the comment:
@mark.dickinson
I extract the common function.
Now maintainence cost is same as AS-IS.
optimization is still work :)
AS-IS: Mean +- std dev: 360 ns +- 19 ns
TO-BE: Mean +- std dev: 185 ns +- 8 ns
what do you think
Change by Dong-hee Na :
--
title: Add float __floordiv__ fast path -> Remove unnecessary logic of float
__floordiv__
___
Python tracker
<https://bugs.python.org/issu
Change by Dong-hee Na :
--
versions: +Python 3.9
___
Python tracker
<https://bugs.python.org/issue39434>
___
___
Python-bugs-list mailing list
Unsubscribe:
Dong-hee Na added the comment:
I agree with inada.naoki
--
nosy: +corona10
___
Python tracker
<https://bugs.python.org/issue39380>
___
___
Python-bugs-list m
New submission from Dong-hee Na :
class poc() :
def __eq__(self,other) :
l.clear()
return NotImplemented
l = [poc(), poc(), poc()]
3 in l
[1]2606 segmentation fault
sigh..
--
assignee: corona10
messages: 360686
nosy: corona10, pablogsal, vstinner
priority
Dong-hee Na added the comment:
I will send a patch ASAP.
--
___
Python tracker
<https://bugs.python.org/issue39453>
___
___
Python-bugs-list mailing list
Unsub
Change by Dong-hee Na :
--
keywords: +patch
pull_requests: +17567
stage: -> patch review
pull_request: https://github.com/python/cpython/pull/18181
___
Python tracker
<https://bugs.python.org/issu
Change by Dong-hee Na :
--
pull_requests: +17579
pull_request: https://github.com/python/cpython/pull/18202
___
Python tracker
<https://bugs.python.org/issue39
Change by Dong-hee Na :
--
pull_requests: +17581
pull_request: https://github.com/python/cpython/pull/18204
___
Python tracker
<https://bugs.python.org/issue39
Change by Dong-hee Na :
--
pull_requests: +17582
pull_request: https://github.com/python/cpython/pull/18205
___
Python tracker
<https://bugs.python.org/issue39
Change by Dong-hee Na :
--
pull_requests: +17583
pull_request: https://github.com/python/cpython/pull/18206
___
Python tracker
<https://bugs.python.org/issue39
Change by Dong-hee Na :
--
pull_requests: +17584
pull_request: https://github.com/python/cpython/pull/18207
___
Python tracker
<https://bugs.python.org/issue38
Change by Dong-hee Na :
--
versions: +Python 3.6
___
Python tracker
<https://bugs.python.org/issue38610>
___
___
Python-bugs-list mailing list
Unsubscribe:
Change by Dong-hee Na :
--
nosy: +corona10
___
Python tracker
<https://bugs.python.org/issue39482>
___
___
Python-bugs-list mailing list
Unsubscribe:
Change by Dong-hee Na :
--
keywords: +patch
pull_requests: +17624
stage: -> patch review
pull_request: https://github.com/python/cpython/pull/18245
___
Python tracker
<https://bugs.python.org/issu
Dong-hee Na added the comment:
@nanjekyejoannah
Thanks for the update :)
--
nosy: +corona10
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Dong-hee Na added the comment:
I add martin.panter to review this issue as the core developer.
--
nosy: +corona10, martin.panter
___
Python tracker
<https://bugs.python.org/issue39
Dong-hee Na added the comment:
IMHO, Although this status code is also listed on the MDN guide,
IANA left 418 as the unassigned code.
ref0: https://developer.mozilla.org/en-US/docs/Web/HTTP/Status
ref1: https://www.iana.org/assignments/http-status-codes/http-status-codes.xhtml
New submission from Dong-hee Na :
status code 103 and 425 is missing.
https://www.iana.org/assignments/http-status-codes/http-status-codes.xhtml
--
components: Library (Lib)
messages: 361114
nosy: corona10, martin.panter
priority: normal
severity: normal
status: open
title: Update
Dong-hee Na added the comment:
See the docs that we follow IANA
https://docs.python.org/3/library/http.html?highlight=iana#http-status-codes
--
___
Python tracker
<https://bugs.python.org/issue39
Change by Dong-hee Na :
--
keywords: +patch
pull_requests: +17667
stage: -> patch review
pull_request: https://github.com/python/cpython/pull/18293
___
Python tracker
<https://bugs.python.org/issu
Change by Dong-hee Na :
--
pull_requests: -17667
___
Python tracker
<https://bugs.python.org/issue39509>
___
___
Python-bugs-list mailing list
Unsubscribe:
Change by Dong-hee Na :
--
pull_requests: +17668
pull_request: https://github.com/python/cpython/pull/18294
___
Python tracker
<https://bugs.python.org/issue39
Change by Dong-hee Na :
--
nosy: +rhettinger
___
Python tracker
<https://bugs.python.org/issue39509>
___
___
Python-bugs-list mailing list
Unsubscribe:
Dong-hee Na added the comment:
Thanks good catch :)
--
___
Python tracker
<https://bugs.python.org/issue39434>
___
___
Python-bugs-list mailing list
Unsub
Dong-hee Na added the comment:
@Ido Michael
I left review comments for you :)
Thanks for the contribution.
--
nosy: +corona10
___
Python tracker
<https://bugs.python.org/issue38
Change by Dong-hee Na :
--
nosy: +corona10
___
Python tracker
<https://bugs.python.org/issue39558>
___
___
Python-bugs-list mailing list
Unsubscribe:
Change by Dong-hee Na :
--
pull_requests: +17785
pull_request: https://github.com/python/cpython/pull/18411
___
Python tracker
<https://bugs.python.org/issue39
Dong-hee Na added the comment:
+1 for me to close this issue.
On the master branch, this issue is not reproducible.
I am closing this issue, if someone wants to open this issue, please re-open
this :)
--
nosy: +corona10
resolution: -> out of date
stage: -> resolved
status
Dong-hee Na added the comment:
FYI, I am working on to add Py_IS_TYPE macro. :)
--
nosy: +corona10
___
Python tracker
<https://bugs.python.org/issue39
Change by Dong-hee Na :
--
pull_requests: +17861
pull_request: https://github.com/python/cpython/pull/18488
___
Python tracker
<https://bugs.python.org/issue39
Change by Dong-hee Na :
--
pull_requests: +17883
pull_request: https://github.com/python/cpython/pull/18507
___
Python tracker
<https://bugs.python.org/issue39
Change by Dong-hee Na :
--
pull_requests: +17884
pull_request: https://github.com/python/cpython/pull/18508
___
Python tracker
<https://bugs.python.org/issue39
Change by Dong-hee Na :
--
pull_requests: +17898
pull_request: https://github.com/python/cpython/pull/18521
___
Python tracker
<https://bugs.python.org/issue39
Dong-hee Na added the comment:
IMHO, I can not see a noticeable performance improvement.
I think that the modern compiler will optimize the reused variable. ;)
The below result might be noise.
[master]
./python.exe -m pyperf timeit "A = list(range(10**3)); B = list(range(10**3))&qu
Dong-hee Na added the comment:
> it appears that Visual Studio on Windows 10 was not doing the optimization
> one might expect.
Hmm, Is this build on release mode?
--
___
Python tracker
<https://bugs.python.org/i
Dong-hee Na added the comment:
Debug mode is not meaningful.
Visual Studio will optimize fully on release mode.
--
___
Python tracker
<https://bugs.python.org/issue39
Dong-hee Na added the comment:
Yes, this is duplicated issue.
--
nosy: +corona10
___
Python tracker
<https://bugs.python.org/issue39780>
___
___
Python-bug
New submission from Dong-hee Na :
Modules/_testcapimodule.c:6808:15: warning: variable ‘res’ set but not used
[-Wunused-but-set-variable]
6808 | PyObject *res;
This warning is noticed after bpo-38913 is fixed.
My GCC version is 9.2.0 :)
--
messages: 363355
nosy: corona10
Change by Dong-hee Na :
--
keywords: +patch
nosy: +corona10
nosy_count: 3.0 -> 4.0
pull_requests: +18135
stage: -> patch review
pull_request: https://github.com/python/cpython/pull/18779
___
Python tracker
<https://bugs.python.org/i
Change by Dong-hee Na :
--
nosy: +corona10
nosy_count: 10.0 -> 11.0
pull_requests: +18140
pull_request: https://github.com/python/cpython/pull/18779
___
Python tracker
<https://bugs.python.org/iss
Dong-hee Na added the comment:
I will take look at this issue :)
--
___
Python tracker
<https://bugs.python.org/issue39851>
___
___
Python-bugs-list mailin
Change by Dong-hee Na :
--
pull_requests: +18251
pull_request: https://github.com/python/cpython/pull/18894
___
Python tracker
<https://bugs.python.org/issue39
Change by Dong-hee Na :
--
pull_requests: +18252
pull_request: https://github.com/python/cpython/pull/18895
___
Python tracker
<https://bugs.python.org/issue39
Change by Dong-hee Na :
--
nosy: +corona10
nosy_count: 5.0 -> 6.0
pull_requests: +18288
pull_request: https://github.com/python/cpython/pull/18936
___
Python tracker
<https://bugs.python.org/issu
Change by Dong-hee Na :
--
pull_requests: +18328
pull_request: https://github.com/python/cpython/pull/18980
___
Python tracker
<https://bugs.python.org/issue37
Change by Dong-hee Na :
--
pull_requests: +18334
pull_request: https://github.com/python/cpython/pull/18986
___
Python tracker
<https://bugs.python.org/issue37
Change by Dong-hee Na :
--
nosy: +corona10
nosy_count: 13.0 -> 14.0
pull_requests: +18363
pull_request: https://github.com/python/cpython/pull/19015
___
Python tracker
<https://bugs.python.org/issue1
Change by Dong-hee Na :
--
pull_requests: +18368
pull_request: https://github.com/python/cpython/pull/19019
___
Python tracker
<https://bugs.python.org/issue37
Dong-hee Na added the comment:
> cpython/Modules/readline.c:90:20: error: unknown type name
'PyModule'
get_readline_state(PyModule *module)
Compile is failure after PR 19017 is merged on macOS.
--
nosy: +corona10
___
Python tr
Dong-hee Na added the comment:
See also: https://github.com/python/cpython/runs/509226542#step:4:305
--
___
Python tracker
<https://bugs.python.org/issue39
Dong-hee Na added the comment:
I reopen this issue for the above problem
--
resolution: fixed ->
status: closed -> open
___
Python tracker
<https://bugs.python.org/i
Dong-hee Na added the comment:
Victor,
frozenset is the last basic builtin collection which is not applied to this
improvement yet.
frozenset also show similar performance improvement by using vectorcall
pyperf compare_to master.json bpo-37207.json
Mean +- std dev: [master] 2.26 us +- 0.06
Change by Dong-hee Na :
--
pull_requests: +18395
pull_request: https://github.com/python/cpython/pull/19044
___
Python tracker
<https://bugs.python.org/issue1635
Change by Dong-hee Na :
--
pull_requests: +18404
pull_request: https://github.com/python/cpython/pull/19053
___
Python tracker
<https://bugs.python.org/issue37
Change by Dong-hee Na :
--
pull_requests: +18409
pull_request: https://github.com/python/cpython/pull/19057
___
Python tracker
<https://bugs.python.org/issue1635
Change by Dong-hee Na :
--
pull_requests: +18426
pull_request: https://github.com/python/cpython/pull/19071
___
Python tracker
<https://bugs.python.org/issue1635
Change by Dong-hee Na :
--
pull_requests: +18430
pull_request: https://github.com/python/cpython/pull/19074
___
Python tracker
<https://bugs.python.org/issue1635
New submission from Dong-hee Na :
example:
https://github.com/python/cpython/pull/19073/checks?check_run_id=519539592
I suggest to not to add information for os.getgrouplist
if the OSError is raised.
--
components: Tests
messages: 364607
nosy: corona10, vstinner
priority: normal
Dong-hee Na added the comment:
or adding might be great just like getpwuid
--
___
Python tracker
<https://bugs.python.org/issue40014>
___
___
Python-bugs-list m
Change by Dong-hee Na :
--
keywords: +patch
pull_requests: +18431
stage: -> patch review
pull_request: https://github.com/python/cpython/pull/19075
___
Python tracker
<https://bugs.python.org/issu
New submission from Dong-hee Na :
See: https://github.com/python/cpython/pull/19084#discussion_r395486583
--
assignee: corona10
components: C API
messages: 364661
nosy: corona10, vstinner
priority: normal
severity: normal
status: open
title: Add _PyModule_AddType private helper
Change by Dong-hee Na :
--
keywords: +patch
pull_requests: +18448
stage: -> patch review
pull_request: https://github.com/python/cpython/pull/19088
___
Python tracker
<https://bugs.python.org/issu
Change by Dong-hee Na :
--
versions: +Python 3.7, Python 3.8
___
Python tracker
<https://bugs.python.org/issue40020>
___
___
Python-bugs-list mailing list
Unsub
Change by Dong-hee Na :
--
pull_requests: +18480
pull_request: https://github.com/python/cpython/pull/19119
___
Python tracker
<https://bugs.python.org/issue40
Change by Dong-hee Na :
--
nosy: +corona10
___
Python tracker
<https://bugs.python.org/issue40050>
___
___
Python-bugs-list mailing list
Unsubscribe:
Change by Dong-hee Na :
--
nosy: +corona10
___
Python tracker
<https://bugs.python.org/issue40058>
___
___
Python-bugs-list mailing list
Unsubscribe:
New submission from Dong-hee Na :
Some of modules is not using PyType_FromSpec.
We need to convert them.
This changes can bring
- allow to destroy types at exit!
- allow subinterpreters to have their own "isolated" typ
--
messages: 365087
nosy: corona10, vstinner
priori
Change by Dong-hee Na :
--
keywords: +patch
pull_requests: +18537
stage: -> patch review
pull_request: https://github.com/python/cpython/pull/19177
___
Python tracker
<https://bugs.python.org/issu
Change by Dong-hee Na :
--
versions: +Python 3.9
___
Python tracker
<https://bugs.python.org/issue40077>
___
___
Python-bugs-list mailing list
Unsubscribe:
Change by Dong-hee Na :
--
components: +C API
___
Python tracker
<https://bugs.python.org/issue40077>
___
___
Python-bugs-list mailing list
Unsubscribe:
Change by Dong-hee Na :
--
pull_requests: +18565
pull_request: https://github.com/python/cpython/pull/19202
___
Python tracker
<https://bugs.python.org/issue40
Dong-hee Na added the comment:
> And I would prefer to first see the overhead of PyType_FromSpec(), and
> discuss the advantages and drawbacks.
Should we stop the work until the overhead is measured?
--
___
Python tracker
Change by Dong-hee Na :
--
nosy: +corona10
___
Python tracker
<https://bugs.python.org/issue40003>
___
___
Python-bugs-list mailing list
Unsubscribe:
Change by Dong-hee Na :
--
pull_requests: +18568
pull_request: https://github.com/python/cpython/pull/19205
___
Python tracker
<https://bugs.python.org/issue40
Change by Dong-hee Na :
--
title: Add _PyModule_AddType private helper function -> Add PyModule_AddType
helper function
___
Python tracker
<https://bugs.python.org/issu
Dong-hee Na added the comment:
@vstinner
IMHO, we can close this issue after PR 19205 is merged.
Most of use cases are replaced to PyModule_AddType.
--
___
Python tracker
<https://bugs.python.org/issue40
Change by Dong-hee Na :
--
resolution: -> duplicate
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Change by Dong-hee Na :
Added file: https://bugs.python.org/file49008/bench_subclass_check.py
___
Python tracker
<https://bugs.python.org/issue40077>
___
___
Python-bug
Change by Dong-hee Na :
Added file: https://bugs.python.org/file49007/bench_isinstance_check.py
___
Python tracker
<https://bugs.python.org/issue40077>
___
___
Python-bug
Dong-hee Na added the comment:
It shown 1% slower for performance.
+--+-++
| Benchmark| master-subclass | bpo-40077-subclass
Dong-hee Na added the comment:
> Can you try to measure the _abc._abc_instancecheck() and
> _abc._abc_subclasscheck()
I 've submitted the benchmark :)
--
___
Python tracker
<https://bugs.python.
Dong-hee Na added the comment:
> You pass a *type to isinstance() in bench_isinstance_check.py.
Thanks for the catch my mistake.
The result is showing:
Not significant (1): bench _abc_instancecheck
--
Added file: https://bugs.python.org/file49009/bench_isinstance_check
Change by Dong-hee Na :
--
pull_requests: +18601
pull_request: https://github.com/python/cpython/pull/19242
___
Python tracker
<https://bugs.python.org/issue1635
Change by Dong-hee Na :
--
pull_requests: +18602
pull_request: https://github.com/python/cpython/pull/19243
___
Python tracker
<https://bugs.python.org/issue1635
Dong-hee Na added the comment:
@vstinner @petr.viktorin
I 'd like to experiment dict vector call and finalize the work.
Can I proceed it?
--
___
Python tracker
<https://bugs.python.org/is
Change by Dong-hee Na :
--
keywords: +patch
nosy: +corona10
nosy_count: 2.0 -> 3.0
pull_requests: +18636
stage: -> patch review
pull_request: https://github.com/python/cpython/pull/19177
___
Python tracker
<https://bugs.python.org/i
Change by Dong-hee Na :
Added file: https://bugs.python.org/file49020/bench_dict_update.py
___
Python tracker
<https://bugs.python.org/issue37207>
___
___
Python-bug
Dong-hee Na added the comment:
+--+---+-+
| Benchmark| master-dict-empty | bpo-37207-dict-empty|
+==+===+=+
| bench dict empty | 502 ns| 443 ns
801 - 900 of 1592 matches
Mail list logo