[issue29922] error message when __aexit__ is not async

2017-03-27 Thread R. David Murray
R. David Murray added the comment: This is a specific example of the general problem reported in issue 25538. -- nosy: +r.david.murray resolution: -> duplicate stage: -> resolved status: open -> closed superseder: -> Traceback from __exit__ method i

[issue29573] NamedTemporaryFile with delete=True should not fail if file already deleted

2017-03-27 Thread R. David Murray
R. David Murray added the comment: He's still going to get an error using your code, Christian. But if he knows that the file being gone is OK, he can catch and ignore the error. Having exit do the unlink wouldn't help him; in that case he'd have to wrap the whole 'w

[issue29573] NamedTemporaryFile with delete=True should not fail if file already deleted

2017-03-27 Thread R. David Murray
R. David Murray added the comment: His problem is that the file has already been deleted by the time the subprocess returns, so the unlink is going to raise an exception. -- ___ Python tracker <http://bugs.python.org/issue29

[issue29928] Add f-strings to Glossary

2017-03-28 Thread R. David Murray
R. David Murray added the comment: "raw" and "byte" are one syllable names, and thus as easy and more meaningful to say than "r-string" or "b-string". "unicode string" is more descriptive and not much longer, but "u-string" does occa

[issue16011] "in" should be consistent with return value of __contains__

2017-03-28 Thread R. David Murray
R. David Murray added the comment: New changeset 0ae7c8bd614d3aa1fcaf2d71a10ff1148c80d9b5 by R. David Murray (Amit Kumar) in branch 'master': bpo-16011 clarify that 'in' always returns a boolean value https://github.com/python/cpython/commit/0ae7c8bd614d3aa1fcaf

[issue10379] locale.format() input regression

2017-03-28 Thread R. David Murray
Changes by R. David Murray : -- stage: needs patch -> backport needed ___ Python tracker <http://bugs.python.org/issue10379> ___ ___ Python-bugs-list mai

[issue10379] locale.format() input regression

2017-03-28 Thread R. David Murray
Changes by R. David Murray : -- stage: backport needed -> needs patch ___ Python tracker <http://bugs.python.org/issue10379> ___ ___ Python-bugs-list mai

[issue16011] "in" should be consistent with return value of __contains__

2017-03-28 Thread R. David Murray
R. David Murray added the comment: Thanks, -- stage: patch review -> backport needed ___ Python tracker <http://bugs.python.org/issue16011> ___ ___ Python-

[issue10379] locale.format() input regression

2017-03-28 Thread R. David Murray
R. David Murray added the comment: New changeset 1cf93a76c2cf307f2e1e514a8944864f746337ea by R. David Murray (Garvit Khatri) in branch 'master': bpo-10379: add 'monetary' to format_string, deprecate format https://github.com/python/cpython/commit/1cf93a76c2cf307f2e1e

[issue10379] locale.format() input regression

2017-03-28 Thread R. David Murray
R. David Murray added the comment: Oops. I merged the patch without coming back here first :(. Still getting used to the new workflow. It turns out that format has a parameter, monetary, that isn't supported by format_string. So what we did was add that parameter to format_strin

[issue29928] Add f-strings to Glossary

2017-03-28 Thread R. David Murray
R. David Murray added the comment: Agreed with Brett. What I was trying to say was that we aren't going to get people to change to a different term, nor are the other 'x-string' abbreviations interesting, so we should document just f-string. But I wasn't exactly clear th

[issue29951] PyArg_ParseTupleAndKeywords exception messages containing "function"

2017-03-31 Thread R. David Murray
R. David Murray added the comment: If you want to be completely unambiguous, you could say "keyword argument names". "keyword argument" appears to mean different things in different contexts; sometimes it means the name and the value together, sometimes one or the other

[issue29947] In SocketServer, why not passing a factory instance for the RequestHandlerClass instead of the class itself?

2017-03-31 Thread R. David Murray
R. David Murray added the comment: I think I'm missing something here. What prevents one from passing a factory function as the RequestHandlerClass argument? In Python, a class name *is* a factory function for class instances. -- nosy: +r.david.m

[issue29947] In SocketServer, why not passing a factory instance for the RequestHandlerClass instead of the class itself?

2017-04-01 Thread R. David Murray
R. David Murray added the comment: Well, we could document it as a factory argument, and explain that the argument name is an historical artifact. -- ___ Python tracker <http://bugs.python.org/issue29

[issue29947] In SocketServer, why not passing a factory instance for the RequestHandlerClass instead of the class itself?

2017-04-01 Thread R. David Murray
R. David Murray added the comment: Given how old socket server is, and that it doesn't actually require that API, we should probably just reword the documentation so that it is clear that RequestHandlerClass is the default Handler implementation (and that you can work with setup/handle/f

[issue29947] In SocketServer, why not passing a factory instance for the RequestHandlerClass instead of the class itself?

2017-04-02 Thread R. David Murray
R. David Murray added the comment: Yes, the difficulty in renaming the parameter was why I suggested a doc change only. I'm not sure it it is worth it to go through a deprecation cycle for socketserver to change the name, though it certainly would be nice. Martin and I could make

[issue29964] %z directive has no effect on the output of time.strptime

2017-04-03 Thread R. David Murray
R. David Murray added the comment: Yes, that's exactly right. 'time' is a low-level os-function wrapper, and inherits many of the deficiencies of the platform. datetime attempts to be a more comprehensive, portable solution. (But even it has its quirks...timez

[issue29968] Document that no characters are allowed to proceed \ in explicit line joining

2017-04-03 Thread R. David Murray
R. David Murray added the comment: I think you meant "the language reference" rather than "the devguide". The sentence about the comment is redundant with the preceding line that says that the thing that results in a join is a physical line that ends with a backslash (

[issue29968] Document that no characters are allowed to proceed \ in explicit line joining

2017-04-03 Thread R. David Murray
R. David Murray added the comment: I also have no idea what your comment about stripping white space is in reference to ;) -- ___ Python tracker <http://bugs.python.org/issue29

[issue29968] Document that no characters are allowed to proceed \ in explicit line joining

2017-04-04 Thread R. David Murray
R. David Murray added the comment: I don't see any omission, myself. Keep in mind that the language reference is as much or more of a specification as it is a reference, so we tend to try to use the minimum language that precisely describes the expected behavior. Which is why I sugg

[issue29980] OSError: multiple exceptions should preserve the exception type if it is common

2017-04-04 Thread R. David Murray
New submission from R. David Murray: create_connection will try multiple times to connect if there are multiple addresses returned by getaddrinfo. If all connections file it inspects the exceptions, and raises the first one if they are all equal. But since the addresses are often different

[issue29980] OSError: multiple exceptions should preserve the exception type if it is common

2017-04-04 Thread R. David Murray
R. David Murray added the comment: If all connections fail (not file :) -- ___ Python tracker <http://bugs.python.org/issue29980> ___ ___ Python-bugs-list mailin

[issue7659] Attribute assignment on object() instances raises wrong exception

2017-04-04 Thread R. David Murray
R. David Murray added the comment: Agreed. Time to close this. -- resolution: -> not a bug stage: needs patch -> resolved status: open -> closed ___ Python tracker <http://bugs.python.o

[issue29986] Documentation recommends raising TypeError from tp_richcompare

2017-04-04 Thread R. David Murray
R. David Murray added the comment: The documentation is technically correct, as far as I can see. Issue 8743 is not about disallowing certain comparison operations, but rather incorrectly implementing the earlier sentence in that same doc section: "If the comparison is undefined, it

[issue29353] Incorrect handling of HTTP response with "Content-Type: message/rfc822" header

2017-04-05 Thread R. David Murray
R. David Murray added the comment: I'm not surprised that trying to render a message parsed with 'headersonly' fails. headersonly treats the entire message body as a single string payload. I'm not sure what the correct behavior should be for the email package, but the fa

[issue29993] error of parsing encoded words in email of standard library

2017-04-05 Thread R. David Murray
R. David Murray added the comment: I consciously decided not to backport this to 2.7 at the time, though I'm not sure I said that out loud. I think it is too much of a behavior change for 2.7. -- resolution: -> rejected stage: -> resolved status: ope

[issue29993] error of parsing encoded words in email of standard library

2017-04-05 Thread R. David Murray
R. David Murray added the comment: Actually, looking at the issue related to the patch, we conferred at the time, Barry, and decided on no backports. It was applied only to default. Sijian: the reason we put the issue number in the commit message is because the issue often contains relevant

[issue30012] gzip.open(filename, "rt") fails on Python 2.7.11 on win32, invalid mode rtb

2017-04-07 Thread R. David Murray
R. David Murray added the comment: I don't think this is really a bug, I think it's a consequence of the different byte/string models of python2 and python3 coupled with the different binary/text models of posix and windows. -- nosy: +r.da

[issue30018] multiprocessing.Pool garbles call stack for __new__

2017-04-07 Thread R. David Murray
R. David Murray added the comment: I suspect you just need to add pickle support to your class. When I subclassed str in the email package, I found I needed to do that. I'd have to go through the docs again to remember how the code works, but you can take a look at the BaseHeader cla

[issue30020] Make attrgetter use namedtuple

2017-04-08 Thread R. David Murray
R. David Murray added the comment: This is a clever idea, but I vote -1 for this proposal. I think it makes attrgetter more complex for little purpose. The fact that only some attribute names work and the others get mangled makes the API very ugly and not, IMO, desirable. Finally, if you

[issue30031] Improve queens demo (use argparse and singular form)

2017-04-10 Thread R. David Murray
R. David Murray added the comment: I'm not sure about using argparse. Currently the demo uses no imports. I'm not strongly against, though. Did you mean __init__ instead of __new__? Also, its value could be made True and False instead of 0 and 1. (Which tells you how old th

[issue30033] email module base64-encodes utf-8 text

2017-04-10 Thread R. David Murray
R. David Murray added the comment: Yes, this sub-optimal, but it's the way it works in the legacy API, and we aren't going to change the legacy (compat32) API at this point. The new policies and the new API in python3 handle this sensibly. -- resolution: -> out

[issue30031] Improve queens demo (use argparse and singular form)

2017-04-10 Thread R. David Murray
R. David Murray added the comment: Yeah, I was wondering if part of the demo was to show something that can be done with no library support...but that probably isn't the case. -- ___ Python tracker <http://bugs.python.org/is

[issue30032] email module creates base64 output with incorrect line breaks

2017-04-10 Thread R. David Murray
R. David Murray added the comment: This appears to be a problem in the new API as well. I don't think we can change the legacy API because its been that way forever and applications might be depending on it (that is, the library preserves exactly what it is handed, and an application

[issue30032] email module creates base64 output with incorrect line breaks

2017-04-10 Thread R. David Murray
R. David Murray added the comment: Actually, I think the fix would go in the generator, not in the contentmanager, but it's been long enough since I've worked on the code that I'm not sure. -- ___ Python tracker <http://bugs.pyt

[issue30032] email module creates base64 output with incorrect line breaks

2017-04-10 Thread R. David Murray
R. David Murray added the comment: That is true for text/ types, yes. The policy is named after the target wire protocol, and if you are transmitting an email message over SMTP, that implies MIME. What to do if you are not sending it over SMTP, though, is a tougher question. One could

[issue30032] email module creates base64 output with incorrect line breaks

2017-04-10 Thread R. David Murray
Changes by R. David Murray : -- versions: -Python 2.7 ___ Python tracker <http://bugs.python.org/issue30032> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue30032] email module creates base64 output with incorrect line breaks

2017-04-10 Thread R. David Murray
Changes by R. David Murray : -- components: +email ___ Python tracker <http://bugs.python.org/issue30032> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue30033] email module base64-encodes utf-8 text

2017-04-10 Thread R. David Murray
R. David Murray added the comment: The API exists in python3.5 and python3.4 as well, it was just provisional. Very few things changed between the provisional version and the final version in 3.6. -- ___ Python tracker <http://bugs.python.

[issue30032] email module creates base64 output with incorrect line breaks

2017-04-10 Thread R. David Murray
R. David Murray added the comment: Huh. I ran something like that test and thought I saw the reverse. I guess I misread my terminal. Looking at the code, set_content does take care to fix the line ending according to the policy before doing the encoding. -- resolution: -> out

[issue30032] email module creates base64 output with incorrect line breaks

2017-04-10 Thread R. David Murray
R. David Murray added the comment: There is, however, an issue that if you pass a message with the default policy to the generator and specify SMTP as the policy, it doesn't *recode* the line endings. I thought there was an open issue for that, but I can't find it. One solution w

[issue30034] csv reader chokes on bad quoting in large files

2017-04-10 Thread R. David Murray
R. David Murray added the comment: In my experience CSV files with fields with embedded newlines are pretty common. I don't really think we want to support invalid CSV files. -- nosy: +r.david.murray ___ Python tracker <http://bugs.py

[issue30034] csv reader chokes on bad quoting in large files

2017-04-10 Thread R. David Murray
R. David Murray added the comment: Well, ETL is semi-standardized. Try dealing with csv files exported from excel spreadsheets written by non-programmers :) "e"X is not a quoting the csv module will produce, but I don't think it is a csv error. insofar as csv has a standard,

[issue30040] new empty dict can be more small

2017-04-11 Thread R. David Murray
R. David Murray added the comment: I've worked on an application (proprietary, unfortunately) that created a lot of empty dictionaries that only sometimes got populated. It involved sqlalchemy, but I don't remember if the dicts came from sqlalchemy itself or from the code that used

[issue30040] new empty dict can be more small

2017-04-11 Thread R. David Murray
R. David Murray added the comment: Sorry, but I no longer have access to that application (I'm a consultant, and the owner is no longer a client). -- ___ Python tracker <http://bugs.python.org/is

[issue30056] RuntimeWarning: invalid value encountered in maximum/minimum

2017-04-12 Thread R. David Murray
R. David Murray added the comment: Numpy is not part of the python standard library. You should report this issue to the numpy bug tracker, which appears to be here: https://github.com/numpy/numpy/issues. Or perhaps first ask the numpy community if this is really a bug: the new version

[issue30063] DeprecationWarning in json/encoder.py

2017-04-13 Thread R. David Murray
R. David Murray added the comment: If a warning is causing iPython to hang, there is something seriously wrong with iPython. A warning is just a message written to stderr, it doesn't affect the execution of the program. The json module does not natively support datetime, so whatev

[issue30063] DeprecationWarning in json/encoder.py

2017-04-13 Thread R. David Murray
R. David Murray added the comment: In case it wasn't clear: I seriously doubt that iPython is hanging due to the warning, I think something else must be happening and the warning is a red herring. -- ___ Python tracker <http://bugs.py

[issue30071] Duck-typing inspect.isfunction()

2017-04-14 Thread R. David Murray
R. David Murray added the comment: The python standard library makes extensive use of duck typing. Duck typing is a pretty fundamental part of the design of Python, IMO. Even the ABC module does a bunch of duck typing, rather than requiring strict subclassing or registration. I think the

[issue30063] DeprecationWarning in json/encoder.py

2017-04-14 Thread R. David Murray
R. David Murray added the comment: I don't believe that warning message is generated by the python standard library. I can't find it in the codebase, and I can't think of any context in which we'd have a reason to g

[issue30063] DeprecationWarning in json/encoder.py

2017-04-14 Thread R. David Murray
R. David Murray added the comment: As for the filterwarnings, If you can come up with a demonstration of a problem that does not involve third party code, please open a new issue with the reproducer. -- ___ Python tracker <http://bugs.python.

[issue30063] DeprecationWarning in json/encoder.py

2017-04-14 Thread R. David Murray
R. David Murray added the comment: Yes, but the way deprecation warnings work is that there is a stacklevel specified, and the line reported in the error is that number of steps back up the call stack from where the warning was actually issued. The json module doesn't natively h

[issue30063] DeprecationWarning in json/encoder.py

2017-04-14 Thread R. David Murray
R. David Murray added the comment: I thought something like that might be the problem with your attempt to suppress the warnings. A library really should not call a global state function such as filterwarnings, that should be done only by the application. You might want to file a bug report

[issue30078] "-m unittest --help" says nothing about direct script exection

2017-04-15 Thread R. David Murray
R. David Murray added the comment: Agreed that it looks like another example line should be added to the help for this case. -- nosy: +r.david.murray stage: -> needs patch versions: +Python 3.7 -Python 3.3, Python 3.4, Python 3.5 ___ Python trac

[issue30079] Explain why it is recommended to pass args as a string rather than as a sequence If shell is True

2017-04-15 Thread R. David Murray
R. David Murray added the comment: Because passing a sequence to shell=True won't work on unix. It only works more-or-less by accident on windows, even though the current docs kind of encourage it. Yes, I think it would be good if these sentences were clarified. See also issue

[issue22319] mailbox.MH chokes on directories without .mh_sequences

2017-04-16 Thread R. David Murray
R. David Murray added the comment: Honestly, given the open questions my inclination would be to reject this. -- ___ Python tracker <http://bugs.python.org/issue22

[issue30079] Explain why it is recommended to pass args as a string rather than as a sequence If shell is True

2017-04-16 Thread R. David Murray
R. David Murray added the comment: Note the subtlety here on unix: rdmurray@pydev:~/python/p36[3.6]>cat temp.sh #!/bin/bash echo $0 echo $1 >>> subprocess.call(['./temp.sh', 'spam', 'eggs'], shell=True) ./temp.sh 0 >>> subprocess.c

[issue30079] Explain why it is recommended to pass args as a string rather than as a sequence If shell is True

2017-04-16 Thread R. David Murray
R. David Murray added the comment: Woops, cut and paste error, there should have been an "echo $2" line in that script as well. -- ___ Python tracker <http://bugs.python.o

[issue22319] mailbox.MH chokes on directories without .mh_sequences

2017-04-16 Thread R. David Murray
R. David Murray added the comment: The support. ClawsMail is broken, IMO. -- ___ Python tracker <http://bugs.python.org/issue22319> ___ ___ Python-bugs-list m

[issue22319] mailbox.MH chokes on directories without .mh_sequences

2017-04-16 Thread R. David Murray
R. David Murray added the comment: If there is a way to resolve the lock issue we can consider it. But (without looking at the code again) I suspect the locking is too deeply embedded in the mbox logic for this to be a safe change. -- ___ Python

[issue30087] pdb issue with type conversion

2017-04-17 Thread R. David Murray
Changes by R. David Murray : -- resolution: -> not a bug ___ Python tracker <http://bugs.python.org/issue30087> ___ ___ Python-bugs-list mailing list Un

[issue30088] mailbox.Maildir doesn't create subdir structure when create=True and base dir exists

2017-04-17 Thread R. David Murray
R. David Murray added the comment: Just create a subdirectory inside the tempdir to hold your Maildir folder. I think it is not worth complicating the API for this use case, since it does have a simple solution. -- versions: -Python 2.7, Python 3.5, Python 3.6

[issue30088] mailbox.Maildir doesn't create subdir structure when create=True and base dir exists

2017-04-17 Thread R. David Murray
R. David Murray added the comment: Right. Which is why you get an error if you try to use an empty directory as if it was a maildir :) create=True creates the *directory* and initializes it. That seems clear to me, and exactly what I would expect. "The mailbox" is the directo

[issue30098] Verbose TypeError for asyncio.ensure_future

2017-04-18 Thread R. David Murray
R. David Murray added the comment: I don't think your specialized error message adds anything. The the most common mistake, IMO, is going to be not realizing that run_coroutine_threadsafe don't return one of the acceptable types. So being told that concurrent.future.Future is not

[issue30103] uu package uses old encoding

2017-04-19 Thread R. David Murray
Changes by R. David Murray : -- components: +Library (Lib) -Extension Modules ___ Python tracker <http://bugs.python.org/issue30103> ___ ___ Python-bugs-list m

[issue30103] uu package uses old encoding

2017-04-19 Thread R. David Murray
Changes by R. David Murray : -- type: behavior -> enhancement versions: +Python 3.7 -Python 3.4 ___ Python tracker <http://bugs.python.org/issue30103> ___ _

[issue30116] numpy.ndarray.T doesn't change the structure

2017-04-20 Thread R. David Murray
R. David Murray added the comment: Numpy is not part of the Python standard library. You'll need to engage with the numpy community on this question. (I say engage with them on the question, not report a bug to them, because I highly doubt this is a bug...there's probably some

[issue18971] Use argparse in the profile/cProfile modules

2017-04-20 Thread R. David Murray
R. David Murray added the comment: Well, part of the point of the tests is to make sure the module's behavior doesn't change when doing the conversion to argparse. But "behavior changing" doesn't extend to the exact format of the output...that can change, as long

[issue30120] add new key words to keyword lib

2017-04-20 Thread R. David Murray
Changes by R. David Murray : -- resolution: -> duplicate stage: -> resolved status: open -> closed superseder: -> keyword module missing async and await keywords ___ Python tracker <http://bugs.python

[issue30122] Added missing archive programs and close option to Windows docs.

2017-04-21 Thread R. David Murray
R. David Murray added the comment: Please close the redundant PRs. I've commented on pr1228. -- nosy: +r.david.murray ___ Python tracker <http://bugs.python.org/is

[issue30122] Added missing archive programs and close option to Windows docs.

2017-04-21 Thread R. David Murray
R. David Murray added the comment: To be clear: backport PRs should be created only after a PR has been approved. -- ___ Python tracker <http://bugs.python.org/issue30

[issue30122] Added missing archive programs and close option to Windows docs.

2017-04-21 Thread R. David Murray
R. David Murray added the comment: Also, please review the (newly rewritten) section in the devguide about PRs. I see now that there were changes made from the original here already, but I don't see the commits that made those changes. The history of changes should be kept duri

[issue30129] functools.partialmethod should look more like what it's impersonating.

2017-04-21 Thread R. David Murray
R. David Murray added the comment: Yes, please do provide an example. Your final words do not make a convincing case that this is a problem in python3 :) -- nosy: +r.david.murray ___ Python tracker <http://bugs.python.org/issue30

[issue30133] Strings that end with properly escaped backslashes cause error to be thrown in re.search/sub/etc. functions.

2017-04-21 Thread R. David Murray
R. David Murray added the comment: I think you are missing a re.escape around text. Text is otherwise not a valid replacement pattern. -- nosy: +r.david.murray ___ Python tracker <http://bugs.python.org/issue30

[issue30133] Strings that end with properly escaped backslashes cause error to be thrown in re.search/sub/etc. functions.

2017-04-21 Thread R. David Murray
R. David Murray added the comment: Good point, re.escape is for literal text you want to insert into a matching pattern, but the replacement template isn't a matching pattern. Do we need a different escape function? I guess the function solution is e

[issue30139] Fix for issue 8743 not available in python MacOS 3.5.1

2017-04-22 Thread R. David Murray
R. David Murray added the comment: Then you have a broken copy of 3.5.1. There is nothing OS-specific about that file. -- nosy: +r.david.murray ___ Python tracker <http://bugs.python.org/issue30

[issue30146] Fix for issue 8743 not available in python MacOS 3.6.1

2017-04-23 Thread R. David Murray
R. David Murray added the comment: You don't appear to have successfully attached the script. Can you try again please? The patching in the issue you point to does not patch __and__, it just sets it equal to __rand__. -- nosy: +r.david.m

[issue30147] change in re.escape output is not docuented in whatsnew

2017-04-23 Thread R. David Murray
R. David Murray added the comment: re.escape was escaping too much previously, and this has been fixed in 3.7 (and only 3.7, because it may cause testing issues such as you have observed). See issue 29995. A note needs to be added to the 'porting' section of whats new cov

[issue30160] BaseHTTPRequestHandler.wfile: supported usage unclear

2017-04-25 Thread R. David Murray
R. David Murray added the comment: I would like to say that the latter interpretation is "obviously" correct, except that it clearly wasn't obvious to you. The fact that it "contains the output stream" I would have thought was pretty clear: if you are writing to it,

[issue30161] Using `with` statement causes dict to start papering over attribute errors

2017-04-25 Thread R. David Murray
R. David Murray added the comment: You've closed stderr. -- nosy: +r.david.murray resolution: -> not a bug stage: -> resolved status: open -> closed ___ Python tracker <http://bugs.pyth

[issue30157] csv.Sniffer.sniff() regex error

2017-04-25 Thread R. David Murray
R. David Murray added the comment: If it is a bug that indicates there is at least one missing unit test :) Maybe the OP will contribute a test. -- nosy: +r.david.murray ___ Python tracker <http://bugs.python.org/issue30

[issue30181] Incorrect parsing of test case docstring

2017-04-27 Thread R. David Murray
R. David Murray added the comment: Considering that in the cpython test suite we avoid using docstrings in unittests because of this "feature" of unittest, I doubt anyone on the core team is going to be motivated to fix this :) That doesn't mean we won't accept a PR, b

[issue30160] BaseHTTPRequestHandler.wfile: supported usage unclear

2017-04-27 Thread R. David Murray
R. David Murray added the comment: My impression is that the sentence is there because you are acting directly on the raw byte stream, which you are not in the other cases. (Well, rfile, but that's reading, so what you do there doesn't affect the wire protoco

[issue30175] Random test_imaplib.test_logincapa_with_client_certfile failure on x86 Gentoo Installed with X 3.x

2017-04-27 Thread R. David Murray
R. David Murray added the comment: Setting up an imap server on pythontest is the "right" answer. Somebody has to do the work, though :) -- nosy: +r.david.murray ___ Python tracker <http://bugs.python.o

[issue30146] Difference in behavior between set() and collections.abc.MutableSet() derived objects

2017-04-27 Thread R. David Murray
R. David Murray added the comment: For backward compatibility reasons, history will win. I'm not sure if documenting the additional restrictions of the concrete stdlib types in the ABC docs makes sense, either, since the ABCs are intentionally the minimal requirements for a concrete ty

[issue30146] Difference in behavior between set() and collections.abc.MutableSet() derived objects

2017-04-27 Thread R. David Murray
R. David Murray added the comment: I suppose someone could propose a set of tests that an implementation of an ABC type should pass, to complement the stdlib type tests. There would probably be a lot of bikeshedding involved in such tests though, so I don't hold out great hope anything

[issue30186] Python interpreter calling "PathCchCombineEx" on startup, Windows 8 and above only

2017-04-27 Thread R. David Murray
R. David Murray added the comment: Indeed, it sounds like wine is claiming to be Windows 7 but then implementing (as not implemented) later-than-windows-7 apis. That definitely sounds like a bug in wine. -- nosy: +r.david.murray ___ Python tracker

[issue29621] telnetlib.Telnet.write gives confusing error message when a string is passed in

2017-04-27 Thread R. David Murray
R. David Murray added the comment: We generally don't do this kind of type checking in the standard library. The message may not be clear, but it is accurate and decipherable, especially given the fact that the write parameter name is 'buffer'. I don't think anything

[issue30175] Random test_imaplib.test_logincapa_with_client_certfile failure on x86 Gentoo Installed with X 3.x

2017-04-27 Thread R. David Murray
R. David Murray added the comment: I think Benjamin is the only one who has done any work on it so far. I think you'd ask the infrastructure team for access if you want to do so. -- ___ Python tracker <http://bugs.python.org/is

[issue26362] Approved API for creating a temporary file path

2017-05-01 Thread R. David Murray
R. David Murray added the comment: You are depending on a non-portable feature of os.rename there, so I'm not convinced this makes a good use case for the Python stdlib. -- nosy: +r.david.murray ___ Python tracker <http://bugs.python.org/is

[issue26362] Approved API for creating a temporary file path

2017-05-01 Thread R. David Murray
R. David Murray added the comment: Yes, and I'm saying his example doesn't work on Windows (on windows, it does not accomplish his goal). So I'm not sure it is a use case appropriate for the standard library. I'm not saying it definitely isn't,

[issue30221] Deprecate assertNotAlmostEqual

2017-05-01 Thread R. David Murray
R. David Murray added the comment: Not only is not something to be surprised about, it would be surprising for it to be absent. So the user cognitive overhead of removing it is quite possibly higher than that of it being there. -- nosy: +r.david.murray

[issue30262] Don't expose sqlite3 Cache and Statement

2017-05-05 Thread R. David Murray
R. David Murray added the comment: If these objects have been exposed in the past, we won't simply delete them. At a minimum there would need to be a deprecation period, but is there a real motivation for deleting them? -- nosy: +r.david.m

[issue30262] Don't expose sqlite3 Cache and Statement

2017-05-05 Thread R. David Murray
R. David Murray added the comment: Sorry, by "real motivation" I meant something beyond just cleaning up the API...that's a real motivation, it may just not be enough. -- ___ Python tracker <http://bugs.pyt

[issue30268] Make mimetypes.guess_type accept path-like objects

2017-05-05 Thread R. David Murray
R. David Murray added the comment: Why do you think this is a bug? -- nosy: +r.david.murray ___ Python tracker <http://bugs.python.org/issue30268> ___ ___ Pytho

[issue30268] Make mimetypes.guess_type accept path-like objects

2017-05-05 Thread R. David Murray
R. David Murray added the comment: To clarify my question, I don't think it is a bug, but the fact that you do might mean there needs to be a doc clarification. Or it might not. Or, there might be a desirable enhancement here, maybe relating to the pathlike pro

[issue30262] Don't expose sqlite3 Cache and Statement

2017-05-05 Thread R. David Murray
R. David Murray added the comment: That's the same motivation, not a new one :) Someone somewhere may be using them for something, they've been around for a long time. I hope not, though. -- ___ Python tracker <http://bugs.python.o

[issue30270] Remove sqlite3.Cache display method

2017-05-05 Thread R. David Murray
R. David Murray added the comment: If it is there for debugging, why would we want to remove it? -- nosy: +r.david.murray ___ Python tracker <http://bugs.python.org/issue30

[issue30262] Don't expose sqlite3 Cache and Statement

2017-05-05 Thread R. David Murray
R. David Murray added the comment: No, I'm arguing purely from a generic backward compatibility perspective. There does not seem to be me be sufficient benefit to removing them to justify doing it. -- ___ Python tracker <http://bugs.py

[issue30262] Don't expose sqlite3 Cache and Statement

2017-05-06 Thread R. David Murray
R. David Murray added the comment: They are not part of the API, that is why they are not documented. The convention of "always" using _ prefixed names for non-API stuff is (relatively) recent. It used to be we just didn't document the non-API stuff. Your second arg

<    49   50   51   52   53   54   55   56   57   58   >