R. David Murray added the comment:
Committed in r88203.
--
resolution: -> fixed
stage: commit review -> committed/rejected
status: open -> closed
___
Python tracker
<http://bugs.python.or
R. David Murray added the comment:
I would open three new bugs to address the issues you raise. It ought to be
possible to rename things so that we can eliminate the pre-population of
NOTTESTS (if not I'd like to know why not!). STDTESTS appear to move certain
tests to the front, pos
R. David Murray added the comment:
As long as we are modifying that code, how about fixing the use of 'dict' as a
variable name? Alternative patch attached.
--
nosy: +r.david.murray
Added file: http://bugs.python.org/file20544/pyc
R. David Murray added the comment:
One fix or the other ought to go in, IMO.
--
___
Python tracker
<http://bugs.python.org/issue11020>
___
___
Python-bugs-list m
R. David Murray added the comment:
For the record, can you point to the relevant part of the relevant RFC?
--
assignee: -> r.david.murray
nosy: +r.david.murray
stage: -> needs patch
versions: +Python 3.1, Python 3.2 -Python 2.6
___
Python t
R. David Murray added the comment:
I haven't looked at the items Haypo has pointed to yet, but I have looked at
the API issues (get_string, add, etc). It seems to me that we have to make a
decision here: do we break API backward compatibility and convert to consuming
and emitting
R. David Murray added the comment:
I wasn't around when that decision was made, but looking at the posixmodule.c
source, system is a straightforward wrapper, but popen gets...byzantine on
anything but unix.
--
nosy: +r.david.murray
___
P
R. David Murray added the comment:
09 is still an invalid token in python3. Since int('09') works in python2 it
might be worth looking in to this further.
--
nosy: +r.david.murray
___
Python tracker
<http://bugs.python.o
R. David Murray added the comment:
Well, it is certainly intentional, then. Whether it is good is a different
story, but also a moot question since optparse has been replaced by argparse.
--
___
Python tracker
<http://bugs.python.org/issue11
Changes by R. David Murray :
--
nosy: +r.david.murray
stage: -> needs patch
versions: +Python 2.7, Python 3.1, Python 3.2 -3rd party
___
Python tracker
<http://bugs.python.org/issu
R. David Murray added the comment:
A feature request can only go in to 3.3 at this point. ConfigParser has had a
serious overhaul in 3.2, by the way.
--
assignee: -> lukasz.langa
nosy: +lukasz.langa, r.david.murray
versions: +Python 3.3 -Python
R. David Murray added the comment:
Well, there's still a backward compatibility issue: if this is changed,
currently working code may break. Maybe Lukasz or Fred will have a guess as to
how likely that is, because I don't.
--
nos
R. David Murray added the comment:
I would say so, otherwise how are you going to run the tests you write :)
As for the other issue...I hadn't counted one for --testdir, but making that a
new issue was a good idea. So the other two I had in mind was for STDTESTS and
NOTTESTS. I still
R. David Murray added the comment:
Attached is a patch that builds on Victor's patch, but takes the approach I
discussed of maintaining backward compatibility (for the most part; see below).
The test suite in this version is substantially unchanged. The major changes
are adding test
R. David Murray added the comment:
Steffen: thanks for testing. Do those error messages have tracebacks? Can you
post them? Can you post example messages and a short program that demonstrates
the problem? I'm going to be creating some non-ascii test cases, but any
additional info yo
R. David Murray added the comment:
The OSX build process is...hairy. Windows likewise (because you have to use MS
tools). Elsewhere, it is pretty straightforward :)
The 10.4 deployment target is the one we want. You can build for a 10.4
deployment target even if you are using a later SDK
R. David Murray added the comment:
I don't see those error messages in the mailbox source. I'm guess your
application isn trapping the errors in a try/except. In that case, just do a
bare 'raise' in the except clause, and you should get the full traceback.
I'm su
R. David Murray added the comment:
What is the data type returned by your get_msg? I bet it is string, and email
can't handle messages in string format that have non-ASCII characters (I'm
adding an explicit error message for this). You either need to use a Message
object, or, m
R. David Murray added the comment:
I'm updating the patch to contain a couple tests using non-ASCII. More are
needed.
Before this patch, one could process a file containing non-ASCII characters as
text, and if your default encoding happened to be able to decode it, things
would appe
Changes by R. David Murray :
Removed file: http://bugs.python.org/file20565/mailbox3.patch
___
Python tracker
<http://bugs.python.org/issue9124>
___
___
Python-bugs-list m
R. David Murray added the comment:
Code patch looks good to me. Unittest tests pass.
--
nosy: +r.david.murray
___
Python tracker
<http://bugs.python.org/issue10
R. David Murray added the comment:
Well, that's a bunch of code, and I'm afraid I don't know what your answer to
my question was. What error do you get now if you use the new version of
mailbox3.patch?
If you feed the new mailbox/email bytes, it will preserve the bytes as
R. David Murray added the comment:
Added two more tests of non-ASCII. I think the tests now cover the necessary
cases.
I still want to do a full code review tomorrow, but I think the patch is in
final form if anyone else is available to do a review as well.
Georg, are you OK with this
Changes by R. David Murray :
Added file: http://bugs.python.org/file20585/mailbox3.patch
___
Python tracker
<http://bugs.python.org/issue9124>
___
___
Python-bugs-list m
Changes by R. David Murray :
Removed file: http://bugs.python.org/file20579/mailbox3.patch
___
Python tracker
<http://bugs.python.org/issue9124>
___
___
Python-bugs-list m
R. David Murray added the comment:
If you are using the most recent mailbox3 patch (I should have renamed it,
sorry...I've no done so to make it clear) you should be getting an error
message that tells you to use binary or Message. So I don't understand how you
are getting this m
Changes by R. David Murray :
--
assignee: -> r.david.murray
nosy: +r.david.murray
___
Python tracker
<http://bugs.python.org/issue11050>
___
___
Python-
R. David Murray added the comment:
Victor: yes, I was thinking that when I added that comment but forgot to come
back to it. Thanks for spotting that.
Another thing I forgot about yesterday is that I activated the commented out
statements that do linesep transformations on the binary file
New submission from R. David Murray :
One of the new tests introduced for #9124 fails for the Bably mailbox format.
The failing tests pass a file to the add method (test_add_binary_file,
test_add_nonascii_binary_file, test_add_text_file_warns). The failing part of
the tests have been
R. David Murray added the comment:
OK, I've added deprecation warnings for using StringIO or text mode files as
input. I found one bug thereby, but it is a bug that pre-existed the patch
(see issue 11062).
I've completed my code review.
To address Victor's question about t
R. David Murray added the comment:
(I hope you meant I was working on a patch :)
Patch is done, but there is one remaining test failure that I'm not sure how to
handle. The test is test_add_text_file_warns. The code checks to see if a
file is a subclass of io.TextIOWrapper, and if so
R. David Murray added the comment:
Benjamin suggested using hasattr(message, 'buffer'), and that works great. The
test revealed a bug in the patch, which is now fixed.
All tests pass on windows. As far as I'm concerned the patch is ready to go.
Other reviews would of co
R. David Murray added the comment:
Committed (with RM approval on IRC) in r88252.
Note that this does not necessarily solve the performance problem. A new issue
should be opened for that if it still exist.
--
resolution: -> fixed
stage: commit review -> committed/rejected
R. David Murray added the comment:
I have no idea what "a static context" means, so it wouldn't make it any
clearer to me. Can you explain further what your confusion is?
--
nosy: +r.david.murray
type: -> feature request
versions: +Python 2.7, Python 3.1, Pyth
R. David Murray added the comment:
I still don't understand. I haven't used threading much, but I don't believe
I've ever used a static method with it.
--
___
Python tracker
<http://bug
New submission from R. David Murray :
Inspired by what happened in issue 8973, I offer the attached patch for
test__all__ to have it check the __all__ list for duplicates. Interestingly,
the first failure is not in struct, but in os. Obviously the patch can't be
applied until the
R. David Murray added the comment:
Well, the test stops testing after the first failure. Perhaps another
enhancement request would be to make test__all__ a parameterized test so that
it tests all modules even if one or more fail.
On linux, the dups are putenv and unsetenv. And yes, deeper
R. David Murray added the comment:
Well, checking if the token is there before adding it would certainly be a fix,
but I think it would be worth understanding why it gets added if it is already
there, because instead perhaps it is possible to simply remove the adding code
from os.py
R. David Murray added the comment:
I'll leave priority setting to tarek, but it doesn't look to me like raising
the priority is going to make any difference, since it doesn't sound from
reading the ticket like anyone has found a solution yet (other than offering
6
R. David Murray added the comment:
FYI, a python traceback is not a segfault. Nor is it a 'crash' in the sense we
use in this tracker.
The warning has been added to the download page, though there is discussion
about whether or not it should be more prominent.
-
R. David Murray added the comment:
Eric, what you say is technically true, but we don't have any other place to
track PEP bugs.
--
assignee: -> docs@python
components: +Documentation
nosy: +docs@python, r.david.murray
resolution: invalid ->
stage: committed/rejected -&g
R. David Murray added the comment:
I see correct doc strings on both 2.7 head and 3.1.
--
nosy: +r.david.murray
___
Python tracker
<http://bugs.python.org/issue571
Changes by R. David Murray :
--
assignee: -> r.david.murray
nosy: +r.david.murray
stage: needs patch -> patch review
versions: +Python 3.3
___
Python tracker
<http://bugs.python.org/
R. David Murray added the comment:
Why not just put them in the 'abc' namespace? IMO, collections.abc.Callable
makes a lot less sense than abc.Mapping.
--
nosy: +r.david.murray
___
Python tracker
<http://bugs.python.o
R. David Murray added the comment:
Hmm. OK, so it is just Callable that is the odd man out.
But in that case, shouldn't the pattern be adopted by the other modules that
define abcs as well? And if the distinction isn't sharp enough in those other
modules to justify that, then
R. David Murray added the comment:
Well, the bug tracker isn't really the place to get help on using Python. I
would suggest posting to python-list, you are more likely to find people with
the time to help you there. You should also take a look at the Turtle demo
programs, I'm p
R. David Murray added the comment:
Steffan: I'm not sure what your post means, but I think there is a chance you
might be confused about something. Python should *never* change the locale
from the C locale. A Python *program* can do so, by calling setlocale, but
Python itself shoul
R. David Murray added the comment:
Ned: I read the bits in the turtle docs about -n as meaning *if* you use -n
*then* you should set this profile option (but if you don't, things should
work). I didn't go over the docs in detail, though, so maybe I'm misreading.
Since yo
R. David Murray added the comment:
Ah, in that case I think the docs could be improved on that point.
--
___
Python tracker
<http://bugs.python.org/issue11
R. David Murray added the comment:
This is fixed in py3k rc2, and thus will be fixed in 3.2. The trick will be
figuring out which update fixed it, to see if we can backport to 3.1 and 2.7.
Since issue 10841 touched stdio handling in Windows, I suspect that may be the
source, so I'm a
R. David Murray added the comment:
Duplicate of issue 6784. (If you disagree explain why here, please.)
--
nosy: +r.david.murray
resolution: -> duplicate
stage: -> committed/rejected
status: open -> closed
superseder: -> byte/unicode pickle incompatibilities between
Changes by R. David Murray :
--
nosy: +jdharper
___
Python tracker
<http://bugs.python.org/issue6784>
___
___
Python-bugs-list mailing list
Unsubscribe:
R. David Murray added the comment:
Looks like this was closed due to lack of appropriate people reviewing it,
rather than because such a review was done.
--
nosy: +brian.curtin, r.david.murray, tim.golden
resolution: out of date ->
status: closed -> open
versions: +Python 3.3 -
Changes by R. David Murray :
--
nosy: -BreamoreBoy
___
Python tracker
<http://bugs.python.org/issue1103350>
___
___
Python-bugs-list mailing list
Unsubscribe:
R. David Murray added the comment:
My notes say that this bug is "similar to issue 5610", the fix for which made
it in to 2.6. I meant to come back and see if that fix fixed this bug, but I
forgot. The fix is different, so it is worth verifying that this test case
fails in 2.5
R. David Murray added the comment:
Looks good to me. I've added the #6510 as superseder, though I doubt we'll
ever make use of that info :)
--
superseder: -> email feedparser.py CRLFLF bug: $ vs \Z
___
Python tracker
<http:/
David-Sarah Hopwood added the comment:
Feedback from Julie Solon of Microsoft:
> These console functions share a per-process heap that is 64K. There is some
> overhead, the heap can get fragmented, and calls from multiple threads all
> affect how much is available for this buffer.
R. David Murray added the comment:
Great. Thanks for reporting it, and I'm glad we managed to already have it
fixed :)
--
resolution: -> fixed
stage: -> committed/rejected
status: open -> closed
___
Python tracker
<http:
R. David Murray added the comment:
There is no underlying file object. I presume you mean the reader/writer
object? Which have no close method, so there is no point in making them a
context manager. There is zero benefit and positive cost (an additional
nesting level). Just use with to
R. David Murray added the comment:
Steffen, I appreciate your testing this. Your error report doesn't have enough
information for me to reproduce the problem. Can you post a short test case,
including a sample email/mailbox file if needed, that reproduces the problem
you are seeing?
Changes by R. David Murray :
--
assignee: -> r.david.murray
___
Python tracker
<http://bugs.python.org/issue6>
___
___
Python-bugs-list mailing list
Un
R. David Murray added the comment:
Perhaps your problem with test_mailbox is that you are running the test_mailbox
from a checkout, but using an installed python3 that is not RC2, rather than
the python3 built from the checkout?
--
___
Python
R. David Murray added the comment:
Again, can you provide example input data and a short program that demonstrates
the problem? There's nothing I can reproduce in your report/question.
As far as I noticed, the caught exceptions all occur at places where no output
has yet been done t
Changes by R. David Murray :
--
components: +Library (Lib) -None
nosy: +asksol, jnoller
type: crash -> behavior
___
Python tracker
<http://bugs.python.org/issu
R. David Murray added the comment:
If you do 'python -c "import uuid" under strace, _posixsubprocess is definitely
loaded, and a pipe2 call is made.
Take a look at the code starting at (py3k trunk) line 418 (try:). That's where
the weird stuff happens, which is what the
R. David Murray added the comment:
Thanks, much easier to communicate when runnable code is involved :) Now I can
see what you mean about it writing the From. I will figure out why and fix it
so that the From line is not written.
The traceback from email.generator is unfortunate. I should
R. David Murray added the comment:
Well, it's not really a duplicate, but rather invalid, since the 2.7 behavior
is more correct than the 2.6 behavior. Not that it matters all that much what
particular resolution is attached to a bug.
Arve: It is unfortunate that the bug fix in issue
R. David Murray added the comment:
The point is that subprocess (now!) is *not* interpreting the arguments when
shell is false. It is passing them through to Windows. What windows does with
them after that is out of the control of subprocess (and always has been
R. David Murray added the comment:
As noted in issue 8972, it's not clear what such a mode should actually do. If
you have a concrete proposal you could make it, probably on the python-ideas
mailing list. But I'm personally not in favor of it; I prefer maintaining as
much API c
R. David Murray added the comment:
There is a link 'report tracker problem' at the bottom of the left hand column.
Unfortunately you have to create an account there to submit an issue :(
--
nosy: +r.david.murray
resolution: -> invalid
stage: -> committed/rejec
R. David Murray added the comment:
Yes, having a cmd.exe 'quote' function, parallel to the shutil 'quote'
function, would be an excellent addition to the stdlib. You could open a
feature request for that.
--
___
P
R. David Murray added the comment:
This is a topic more suited to python-ideas. It isn't likely to get much
traction there, but you can try :)
--
nosy: +r.david.murray
resolution: -> rejected
stage: -> committed/rejected
status: ope
R. David Murray added the comment:
easy_install is not part of python. Please report this to the easy_install bug
tracker instead.
--
nosy: +r.david.murray, tarek
resolution: -> later
stage: -> committed/rejected
status: open -&g
R. David Murray added the comment:
Xuanji: yes, your test_ignores_stuff_appended_past_comments is exactly what I
was asking for. I've put this patch on my review list, but I may not get to it
until after 3.2 final.
--
___
Python tracker
R. David Murray added the comment:
This appears to be a duplicate of issue 9298. Yves, if you disagree let me
know what's different.
--
nosy: +r.david.murray
resolution: -> duplicate
stage: -> committed/rejected
status: open -> closed
type: -> behavior
vers
R. David Murray added the comment:
See also duplicate issue 11156.
--
nosy: +y...@zioup.com
___
Python tracker
<http://bugs.python.org/issue9298>
___
___
Pytho
Changes by R. David Murray :
--
versions: +Python 3.3
___
Python tracker
<http://bugs.python.org/issue9298>
___
___
Python-bugs-list mailing list
Unsubscribe:
Changes by R. David Murray :
--
superseder: -> binary email attachment issue with base64 encoding
___
Python tracker
<http://bugs.python.org/issue11156>
___
_
R. David Murray added the comment:
Yes, when I said "new version", I meant "new major version", as in email6. I
have plans for this, but I'm waiting until after the release of 3.2 to make a
presentation about it to the email-sig.
--
versions
R. David Murray added the comment:
This looks like a duplicate of issue 10973.
--
nosy: +r.david.murray
resolution: -> duplicate
stage: -> committed/rejected
status: open -> closed
superseder: -> OS X 10.6 IDLE, tkinter: Cocoa Tk 8.5 crash when composite
character typ
R. David Murray added the comment:
Upon reflection I don't think my suggested email API change is a good one.
Currently it is possible to create a Message using non-ASCII headers and
manipulate that message. The fact that you can't serialize that message is,
really, a bug: one
R. David Murray added the comment:
Here is the promised patch, with tests. For once writing the patch was harder
than writing the tests, but only just :)
I'm not sure all the 100% sure the cleanups will work on all systems (I'm
looking at you, Windows), but since any problems wil
Changes by R. David Murray :
--
nosy: +rhettinger
___
Python tracker
<http://bugs.python.org/issue11180>
___
___
Python-bugs-list mailing list
Unsubscribe:
R. David Murray added the comment:
The finally was doing a _sync_close, which flushes the tmp file and closes it.
The except Exception is checking if any non-BaseException error occurs,
*removing* the tmp file, and re-raising the exception. There's nothing to
flush/close in that
R. David Murray added the comment:
Duh. After writing all that you'd think I'd have seen my mistake. That's what
reviews are for. So I guess it should be BaseException, since the most likely
one is keyboard interrupt and this would prevent a corrupted mailbo
R. David Murray added the comment:
Yves: thanks for the patches. If you feel like redoing the test one as a patch
against Lib/email/test/test_email.py, that would be great. I'd suggest having
the test just split the lines and do
assertLessEqual(max([len(x) for x in lines]), 76
R. David Murray added the comment:
Revised patch using BaseException.
--
Added file: http://bugs.python.org/file20746/mailbox_cleanup2.patch
___
Python tracker
<http://bugs.python.org/issue11
R. David Murray added the comment:
Woops. Thanks for catching that. Will fix before commit.
--
___
Python tracker
<http://bugs.python.org/issue6>
___
___
R. David Murray added the comment:
Well, under the (C) hood, it is in fact the same method, it just takes a
variable number of arguments (and ignores them, in the __exit__ case). The
fact that the arguments are rejected in the 'release' case is because of how
the C function is de
R. David Murray added the comment:
Making the tests pass on Jython is certainly worthwhile, if anyone wants to do
it. At a quick glance it looks like the optparse tests just need to be updated
and made a bit more lenient. Since Jython is lagging CPython by so much a fix
isn't going to
Changes by R. David Murray :
--
nosy: +benjamin.peterson
___
Python tracker
<http://bugs.python.org/issue11195>
___
___
Python-bugs-list mailing list
Unsubscribe:
R. David Murray added the comment:
Yeah, sometimes you just have to read the source.
Previous to Python3.2, RLock was implemented in Python, and the two methods are
actually different methods there. In Python3.2, rlock.release ==
rlock.__exit__ is True.
--
resolution: -> inva
R. David Murray added the comment:
Committed in r88403.
--
resolution: -> fixed
stage: patch review -> committed/rejected
status: open -> closed
___
Python tracker
<http://bugs.python.or
R. David Murray added the comment:
Decided to backport the fix to 2.7, even though the tests won't backport.
r88406.
--
___
Python tracker
<http://bugs.python.org/is
Changes by R. David Murray :
--
nosy: +mrabarnett
___
Python tracker
<http://bugs.python.org/issue11198>
___
___
Python-bugs-list mailing list
Unsubscribe:
Changes by R. David Murray :
--
resolution: -> invalid
stage: -> committed/rejected
status: open -> closed
___
Python tracker
<http://bugs.python.or
R. David Murray added the comment:
Looks good to me.
I wonder if the existing example should be moved up above the description of
the chmod flags, though. This update puts it even farther away from the
functions it is an example of
R. David Murray added the comment:
Interesting. I would actually have expected the observed behavior. I think of
the : in a dictionary literal as an assignment.
--
nosy: +r.david.murray
___
Python tracker
<http://bugs.python.org/issue11
Changes by R. David Murray :
--
nosy: +r.david.murray
___
Python tracker
<http://bugs.python.org/issue670664>
___
___
Python-bugs-list mailing list
Unsubscribe:
Changes by R. David Murray :
--
nosy: +rhettinger
___
Python tracker
<http://bugs.python.org/issue11208>
___
___
Python-bugs-list mailing list
Unsubscribe:
3801 - 3900 of 12938 matches
Mail list logo
