Chris Jerdonek added the comment:
As discussed above and because this comment thread is getting very long, I'm
going to start proposing smaller issues off of this one. In this way we can
start committing as we reach agreement, and hash out any disagreements in more
focused contexts a
Changes by Chris Rebert :
--
nosy: +cvrebert
___
Python tracker
<http://bugs.python.org/issue17279>
___
___
Python-bugs-list mailing list
Unsubscribe:
Chris Jerdonek added the comment:
I don't think support.temp_cwd() should be changed for this issue (or needs to
be). Also, changing it in the proposed way could mask errors in the test suite
since tests were written against the current behavior.
regrtest.py and __main__.py should
Chris Jerdonek added the comment:
Attaching patch.
The use of "global TEMPDIR" isn't ideal. Alternatively, TEMPDIR's value when
sysconfig.is_python_build() is true can be set when initially setting TEMPDIR:
http://hg.python.org/cpython/file/96f08a22f562/Lib/t
Changes by Chris Jerdonek :
--
stage: needs patch -> patch review
___
Python tracker
<http://bugs.python.org/issue17283>
___
___
Python-bugs-list mai
Chris Jerdonek added the comment:
Attaching an improved patch.
This patch improves the introductory wording, adds some additional hyperlinks,
and changes the order of one of the inserted sections.
--
Added file: http://bugs.python.org/file29227/issue-16406-4.patch
Chris Jerdonek added the comment:
Here is a new patch which does not use the global keyword.
--
Added file: http://bugs.python.org/file29228/issue-17283-2.patch
___
Python tracker
<http://bugs.python.org/issue17
Chris Jerdonek added the comment:
> I still fail to understand what are you trying to achieve.
My goal is to reach consensus on changes and have them committed. In its
current form, I don't agree with the patch. The length of the comment thread
and the length of the patch has discou
Chris Jerdonek added the comment:
For the record, I don't recall *any* changes being made to any of the patches
in response to mine or others' comments, other than dividing them up. So we're
not talking about perfection. If they're going to be committed as is, it might
Chris Jerdonek added the comment:
> But, surely at this point, it would be easier to get meaningful additional
> review after the current set of changes are committed rather than continually
> redoing a large set of patches.
This was my reason for asking early on that the changes be
Chris Jerdonek added the comment:
> Currently the section covers all the fundamental Mercurial-related operations
> that a committers needs to know (set up, commit, merge, push), not just
> committing.
The point of the change in section title is to have a title so non-committers
Chris Jerdonek added the comment:
Why must we mention graft at all? I've never had a need for it. It seems
simpler and just as effective to run `hg import` on the original patch.
I think it's preferable that the steps we recommend to work on all systems.
Then we won't have
Chris Jerdonek added the comment:
> AFAICT, the recommendation to use hg "git" format is currently only mentioned
> in the Committing section
> (http://docs.python.org/devguide/committing.html#minimal-configuration) but
> not elsewhere, in particular, not http://do
Chris Jerdonek added the comment:
I think making the sections more focused helps because sections are the
linkable units, and sections can be freely moved around once they are more
stand-alone (e.g. into or out of the FAQ).
In issue 16931 in response to Ned, I suggested adding a general
Chris Jerdonek added the comment:
If you start with a patch against 3.x, which is the normal case, why go to the
trouble of grafting from the patch modified for 2.7? It seems you're just
creating more trouble for yourself (introducing more conflicts you have to
resolve, etc) when you al
Chris Jerdonek added the comment:
> Reapplying the patch means that I have to do import + commit at least, and
> possibly reapply manually changes that I've already done on 2.7.
Since 2.7 is more different from 3.2 than is 3.4, it seems more likely that
grafting from 2.7 to 3.x wil
Chris Jerdonek added the comment:
Thanks a lot for the review, Petri.
--
resolution: -> fixed
stage: patch review -> committed/rejected
status: open -> closed
___
Python tracker
<http://bugs.python.or
Chris Jerdonek added the comment:
The fix for issue 17283 has been committed now, which should make this slightly
easier to fix (e.g. change one place instead of two).
--
___
Python tracker
<http://bugs.python.org/issue15
Chris Jerdonek added the comment:
Thanks a lot for taking the time to review, guys.
--
resolution: -> fixed
stage: patch review -> committed/rejected
status: open -> closed
___
Python tracker
<http://bugs.python.or
New submission from Chris Jerdonek:
As suggested by Éric in a Rietveld comment to issue 16406, this issue is to
make the "PyPI package display" section of the distutils docs use the right
terminology:
"It’s too bad this part of the documentation use “package” with the meanin
Chris Jerdonek added the comment:
I created issue 17311 for a suggestion Éric made on Rietveld.
--
___
Python tracker
<http://bugs.python.org/issue16406>
___
___
Chris Jerdonek added the comment:
Here is a patch that updates Geoff's patch to the latest code, and addresses
the directory creation issue.
--
Added file: http://bugs.python.org/file29269/issue15305-3.patch
___
Python tracker
Changes by Chris Jerdonek :
--
stage: -> patch review
type: -> enhancement
versions: +Python 3.4 -Python 3.3
___
Python tracker
<http://bugs.python.org/i
New submission from Chris Jerdonek:
test_aifc's AIFCLowLevelTest.test_write_aiff_by_extension() leaves a test file
behind. I'm not sure what other versions are affected.
--
keywords: easy
messages: 183175
nosy: chris.jerdonek, r.david.murray
priority: normal
severity: no
Changes by Chris Jerdonek :
--
components: +Tests
___
Python tracker
<http://bugs.python.org/issue17312>
___
___
Python-bugs-list mailing list
Unsubscribe:
New submission from Chris Jerdonek:
test_logging leaves behind a file called test.log in the current working
directory. I haven't narrowed down to the specific test, and I'm not sure what
other versions are affected.
--
components: Tests
messages: 183176
nosy: chri
New submission from Chris Jerdonek:
test_posixpath leaves behind a file of the following form when running on Mac
OS X:
lrwxr-xr-x @test_17700_tmpa -> @test_17700_tmpa/b
I'm not sure which test it is or which other versions are affected.
--
components: Tests
messages: 183
Chris Jerdonek added the comment:
The link for convenience:
http://docs.python.org/dev/distutils/packageindex.html#pypi-package-display
--
___
Python tracker
<http://bugs.python.org/issue17
Chris Jerdonek added the comment:
Thanks for investigating.
Yes, currently regrtest.py deletes the containing directory. But this doesn't
happen when running with plain unittest. If each test cleans up after itself,
this will give us more flexibility in moving from regrtest to a uni
Chris Jerdonek added the comment:
The first and/or main place that recommends "hg graft" should link to the
section with more detail for cases where users experience problems with graft.
I also agree that the section should mention the case-folding error. I'm using
a pretty
Chris Jerdonek added the comment:
> Extending regrtest to support unittest test discovery directly is also a
> worthwhile specific proposal.
Updating the tests to support discovery in all cases is discussed in (meta)
issue 16748. There are also many individual issues in the tracker (o
Chris Jerdonek added the comment:
Ezio, did you delete the section on null-merging in your commits? I don't see
it in the devguide anymore.
--
___
Python tracker
<http://bugs.python.org/is
New submission from Chris Jerdonek:
This issue is to improve the organization of the PyPI section of the Distutils
documentation, now that the information has been combined into one page.
A patch is attached.
Improvements include:
(1) Creating a section for command options common to both
Chris Jerdonek added the comment:
The "refs" output also complicates testing in some cases, e.g.
http://hg.python.org/cpython/file/bc4458493024/Lib/test/test_subprocess.py#l61
http://hg.python.org/cpython/file/bc4458493024/Lib/test/test_subprocess.py#l786
--
nosy: +chri
Chris Jerdonek added the comment:
The file gets created in the current working directory. You won't see it when
using regrtest since regrtest creates and then deletes a temp working directory.
To see it easier, try running instead:
./python.exe -m unittest test.test_posi
Chris Jerdonek added the comment:
Similar to as I stated in issue 17315, you won't see it when using regrtest
since regrtest creates and then deletes a temp working directory.
The file gets created and is left behind in the current working directory. Try
running using unittest
Chris Jerdonek added the comment:
Thanks.
--
___
Python tracker
<http://bugs.python.org/issue17312>
___
___
Python-bugs-list mailing list
Unsubscribe:
Chris Jerdonek added the comment:
Thanks, I confirmed the fix.
--
___
Python tracker
<http://bugs.python.org/issue17315>
___
___
Python-bugs-list mailin
New submission from Chris Adams:
I noticed an interesting failure while using re.match / re.sub to look for
non-Cyrillic characters in allegedly Russian text:
>>> re.sub(r'[\s\u0400-\u0527]+', ' ', 'Архангельская губерния',
>>> flags=re.IGNOR
Chris Adams added the comment:
Ah, that explains it - I'd been hoping based on the re.DEBUG output that the
explicit unicode ranges were preserved.
I found #3511 before opening this one but don't believe the decision should be
the same since this isn't a mixed numeric/a
New submission from Chris Tandiono:
Currently, random.sample(population, k) raises a ValueError if k is out of the
range of [0, len(population)], inclusive. However, the message says "Sample
larger than population" even when the real problem is that k < 0. The attached
patch fix
Changes by Chris Tandiono :
--
title: Providing invalid value to -> Providing invalid value to random.sample
can result in incorrect error message
___
Python tracker
<http://bugs.python.org/issu
Chris Tandiono added the comment:
Hmm. I'm not sure I buy the argument that the new message is less useful
(wouldn't you like to know the exact values that caused the problem? that's
what int() does when you provide it garbage). I guess it could be less
informative, since you
Chris Calloway added the comment:
Yes, that's why I opened it. Feel free to submit patches if you think I'm
moving too slowly.
--
___
Python tracker
<http://bugs.python.o
Chris Adams added the comment:
Ezio: given the non-obvious failure, what do you think of at least documenting
this and issuing a warning any time both re.UNICODE and re.IGNORECASE are set?
--
___
Python tracker
<http://bugs.python.org/issue17
New submission from Chris Angelico:
The timeit module is commonly used via the convenience function timeit.timeit,
which is listed in the documentation as the recommended "Python Interface":
http://docs.python.org/3/library/timeit.html
However, this function is not listed in __all_
Changes by Chris Angelico :
--
nosy: +Rosuav
___
Python tracker
<http://bugs.python.org/issue17575>
___
___
Python-bugs-list mailing list
Unsubscribe:
Changes by Chris Calloway :
--
nosy: +cbc
___
Python tracker
<http://bugs.python.org/issue15351>
___
___
Python-bugs-list mailing list
Unsubscribe:
Changes by Chris Kaynor :
--
nosy: +DragonFireCK
___
Python tracker
<http://bugs.python.org/issue17263>
___
___
Python-bugs-list mailing list
Unsubscribe:
New submission from Chris Angelico:
As of PEP 393, a string's width is recorded in its header - effectively, a
marker that says whether the highest codepoint in the string is >0x, >0xFF,
or <=0xFF. This is, on some occasions, useful to know; for instance, when
testing stri
Chris Angelico added the comment:
And of course, I make a copy/paste error in a trivial piece of example code.
def str_width(s):
width=1
for ch in map(ord,s):
if ch > 0x: return 4
if ch > 0xFF: width=2
return width
--
___
Chris Angelico added the comment:
CPython also knows the length of a string, which means that len(s) is a fast
operation. I wouldn't expect anyone to rewrite len() as:
def get_string_length(s):
length=0
for ch in s:
length+=1
return length
even though that works. No, we have a
Changes by Chris Calloway :
Removed file: http://bugs.python.org/file26635/issue-15518-1.patch
___
Python tracker
<http://bugs.python.org/issue15518>
___
___
Python-bug
Chris Calloway added the comment:
OK, I got to participate in my Python user group hack night this week where I
actually got to work on my projects instead of spending all night helping
newbies on their projects. I used the time to refactor all the previous patches
for this issue on which I
Changes by Chris Calloway :
Removed file: http://bugs.python.org/file29681/issue-15518-1.patch
___
Python tracker
<http://bugs.python.org/issue15518>
___
___
Python-bug
Chris Calloway added the comment:
Replaced patch to fix a few under-informative test messages.
--
Added file: http://bugs.python.org/file29682/issue-15518-1.patch
___
Python tracker
<http://bugs.python.org/issue15
Changes by Chris Calloway :
Removed file: http://bugs.python.org/file29682/issue-15518-1.patch
___
Python tracker
<http://bugs.python.org/issue15518>
___
___
Python-bug
Chris Calloway added the comment:
The attached file test_filecmp_layouts.rst documents the directory and file
layouts for complete test coverage of filecmp.dircmp report methods to aid in
review discussion of patch.
--
Added file: http://bugs.python.org/file29745
Chris Calloway added the comment:
The attached file test_filecmp_reports.rst documents the reports generated by
filecmp.dircmp test methods if the directory and file layouts in
test_filecmp_layouts.rst are followed to aid in review discussion of patch.
--
Added file: http
Chris Calloway added the comment:
The attached patch issue-15518-1.patch replaces previous patch proposals for
this issue.
The patch implements the suggestion to factor code common to report TestCase
classes into a common base class BaseReportTestCase. Apologies for not having
that in the
Changes by Chris Calloway :
Removed file: http://bugs.python.org/file29747/issue-15518-1.patch
___
Python tracker
<http://bugs.python.org/issue15518>
___
___
Python-bug
Chris Calloway added the comment:
Fix calls to BaseReportTestCase methods in subclasses. Not an override so don't
need super().
--
Added file: http://bugs.python.org/file29749/issue-15518-1.patch
___
Python tracker
<http://bugs.py
Changes by Chris Calloway :
Removed file: http://bugs.python.org/file29749/issue-15518-1.patch
___
Python tracker
<http://bugs.python.org/issue15518>
___
___
Python-bug
Chris Calloway added the comment:
I replaced issue-15518-1.patch. I believe it now addresses all the concerns
expressed thus far. If reviewed favorably, I will extend it to clean-up the
pre-existing tests to address the concerns noted about them, especially since
the filecmpdata directory
Changes by Chris Calloway :
Removed file: http://bugs.python.org/file29758/issue-15518-1.patch
___
Python tracker
<http://bugs.python.org/issue15518>
___
___
Python-bug
Chris Calloway added the comment:
I'm uploading a new patch which gets rid of the temp_cwd calls as suggested in
the review. The patch is not complete in that the explanatory comments
suggested in the review and revising the pre-existing tests have not been
completed yet. However, I wa
New submission from Chris PeBenito:
Python 3.3/3.4 sometimes does not recognize a legitimate IPv6Network netmask:
$ python3
Python 3.3.5 (default, May 28 2014, 13:56:57)
[GCC 4.7.3] on linux
Type "help", "copyright", "credits" or "license" for more
Chris PeBenito added the comment:
That's unfortunate. The library provides factory functions so v4 and v6
addresses/networks are easily handled together, and yet it seems to have been
overlooked that you can do this:
ipaddress.ip_network('192.168.1.0/255.255.255.0')
New submission from Chris PeBenito:
Here:
https://docs.python.org/3/library/ipaddress.html#ipaddress.IPv6Network
In the constructor documentation, item 1 says:
"""
A string consisting of an IP address and an optional mask, separated by a slash
(/). The IP address is the netwo
Chris PeBenito added the comment:
I understand the resistance; I'm fine closing this as "won't implement", though
this is not for academic use. In a nutshell, my package currently has a set of
classes to represent an SELinux policy, and the SELinux policy language
repr
Chris Rebert added the comment:
Ping! It's been about 3 months since this was given the green light...
--
___
Python tracker
<http://bugs.python.org/is
New submission from Chris Angelico:
See PEP for full details. Attached is POC patch: behaviour is altered globally
(rather than respecting a __future__ directive), and minimal changes are made
elsewhere to make the test suite mostly pass (test_generators does not - it'll
need
Chris Angelico added the comment:
Marc, are those all cases where the "raise StopIteration" is actually inside a
generator? If so, it can be trivially replaced with "return". Yes, it'll break
that way of spelling it, but it's a completely mechanical transformation
Chris Angelico added the comment:
Yep, the question is whether any of the "raise StopIteration" lines are
actually non-local flow control. If they're local, then it's easy: mechanical
replacement with "return" and it becomes compatible with all versions (unless
Chris Angelico added the comment:
Sadly, I don't know of a way to check if that's the case, other than by
manually going through and eyeballing the code - if there's "raise
StopIteration", see if there's also "yield" in the same function. The three
cite
Chris Angelico added the comment:
Known issues with the current patch, if anyone feels like playing with this who
better knows the code:
1) Needs a __future__ directive to control behaviour
2) test_generators needs to be heavily reworked
3) The test of what exception was thrown needs to also
Chris Rebert added the comment:
Thanks Serhiy!
--
___
Python tracker
<http://bugs.python.org/issue21514>
___
___
Python-bugs-list mailing list
Unsubscribe:
Chris Rebert added the comment:
Ping!
Seems like this should be closed since the new RFC explicitly legalizes the
feature in question and since the docs explicitly warn about the
interoperability of the feature.
--
___
Python tracker
<h
Changes by Chris Rebert :
--
nosy: +cvrebert
___
Python tracker
<http://bugs.python.org/issue22936>
___
___
Python-bugs-list mailing list
Unsubscribe:
Changes by Chris Rebert :
--
nosy: +cvrebert
___
Python tracker
<http://bugs.python.org/issue22951>
___
___
Python-bugs-list mailing list
Unsubscribe:
Chris Angelico added the comment:
Stefan, I'm not sure - I don't know the details of the C API here. But I tried
commenting out everything but that one line, and while it does result in
RuntimeError, it doesn't do the exception chaining. Currently, I believe the
exception isn
Chris Angelico added the comment:
Yeah, I saw that. Since that function begins with an underscore, I thought it
best to replicate its behaviour rather than to call it. Either way ought to
work though.
--
___
Python tracker
<http://bugs.python.
Chris Rebert added the comment:
Here is a patch that adds the necessary warnings from issue 7950.
Please review it when you get a chance.
--
keywords: +patch
Added file: http://bugs.python.org/file37338/fix-21557.patch
___
Python tracker
<h
Chris Rebert added the comment:
Ping. This small patch has been waiting nearly 3 months for a review.
--
___
Python tracker
<http://bugs.python.org/issue22
Chris Rebert added the comment:
WebM's docs use "video/webm" and never use an "application/*" type.
See http://www.webmproject.org/docs/container/
They also specify "audio/webm" for audio-only content, but both use the same
file extension, so associating &q
Chris Rebert added the comment:
Yes, the existing patch looks fine.
--
___
Python tracker
<http://bugs.python.org/issue16329>
___
___
Python-bugs-list mailin
New submission from Chris Hand:
The current implementation of readline implements the redisplay function, but
not the forced version. This patch maintains the current behavior as the
default, but also allows a bool to be passed which, if True, calls
rl_forced_update_display instead
New submission from Chris Jerdonek:
The documentation for os.path.normcase(path) is currently confusing or
self-contradictory.
Currently, it reads--
"Normalize the case of a pathname. On Unix and Mac OS X, this returns the path
unchanged; on case-insensitive filesystems, it converts the
New submission from Chris Jerdonek:
pathlib's relative_to(other) can give a confusing message when "other" is
os.curdir.
For example--
Python 3.4.2 (default, Nov 12 2014, 18:23:59)
[GCC 4.2.1 Compatible Apple LLVM 6.0 (clang-600.0.54)] on darwin
Type "help&quo
Chris Jerdonek added the comment:
By the way, here is another (less) confusing error message:
>>> Path("foo").relative_to("fo")
Traceback (most recent call last):
File "", line 1, in
File
"/opt/local/Library/Frameworks/Python.fra
Chris Jerdonek added the comment:
Was this also fixed for Mac OS X? Mac OS X is also case-insensitive by
default, and on Python 3.4.2 I'm getting:
>>> Path("Foo").relative_to("foo")
Traceback (most recent call last):
File "", line 1
New submission from Chris Jerdonek:
I have observed that when running unit tests using unittest's test discovery,
unittest can simultaneously (1) modify sys.path unnecessarily (by adding a path
that is already in sys.path with a different case), and (2) modify sys.path by
adding a path o
Changes by Chris Rebert :
--
nosy: +cvrebert
___
Python tracker
<http://bugs.python.org/issue19776>
___
___
Python-bugs-list mailing list
Unsubscribe:
New submission from Chris Angelico:
Creating an issue to keep track of a patch, but this probably wants to be
discussed on python-ideas.
The attached patch allows a Python function to be put into sys.__getglobal__,
which then works like __getattr__ but for global names. This allows
Chris Angelico added the comment:
I can have a poke at the __future__ import tonight, but my main concern is
memory management - I'm not sufficiently familiar with the exception handling
calls to be sure that I'm neither leaking nor over-freeing anything. There's
also a seconda
Chris Angelico added the comment:
PyErr_Restore doesn't seem to trigger exception chaining. But thanks for the
tip about explicitly setting the traceback; not sure how I missed that, but now
the StopIteration traceback is visible.
Minor point: The previous patch was setting the __context
Changes by Chris Angelico :
Added file: http://bugs.python.org/file37641/stopiter.py
___
Python tracker
<http://bugs.python.org/issue22906>
___
___
Python-bugs-list mailin
Chris Angelico added the comment:
Nick, any particular reason for pointing to
https://hg.python.org/cpython/annotate/bbf16fd024df/Lib/__future__.py rather
than https://hg.python.org/cpython/annotate/tip/Lib/__future__.py ? I'm looking
at both, a
Changes by Chris Angelico :
--
type: -> behavior
___
Python tracker
<http://bugs.python.org/issue23192>
___
___
Python-bugs-list mailing list
Unsubscrib
New submission from Chris Angelico:
As yield is an expression, it's legal in a lambda function, which then
means you have a generator function. But it's not quite the same as
the equivalent function made with def:
$ python3
Python 3.5.0a0 (default:1c51f1650c42+, Dec 29 2014, 02:2
2501 - 2600 of 2758 matches
Mail list logo
