Chris Jerdonek added the comment:
Sorry, I see that you changed the logic of get_argspec(). In that case, you
should probably update the docstring of get_argspec() as well as the code
comment I referenced (so that both say which lines are checked rather than the
first line
Chris Jerdonek added the comment:
I would separate the issue of fixing the test (behavior) from adding support
for multi-line tool tips (enhancement). Unless the policy for IDLE is
different, it seems the latter should be limited to 3.4
Chris Jerdonek added the comment:
I don't think it was ever a requirement of docstrings that their signature fit
on one line or that they render fully in IDLE. Other built-in functions have
multi-line signatures going back 10+ years (e.g. 32e7d0898eab).
I still think that the renderi
New submission from Chris Jerdonek:
This issue is to add support for rendering multi-line docstring signatures in
IDLE calltips (e.g. iter(), min(), int(), etc). This was suggested by Serhiy
in the comments to issue 16629.
--
components: IDLE
messages: 177118
nosy: chris.jerdonek
Chris Jerdonek added the comment:
I created issue 16638 to add support for multi-line signatures.
> Then what about this issue?
This issue is to fix the failing test. The test that is failing is to check
that fetch_tip correctly returns the first line of a built-in's docstring and
Chris Jerdonek added the comment:
[Continuing a discussion/question from the issue 16629 comments]
> > For example, why not be smarter about detecting the end of the signature
> > (e.g. first line not having "->")?
> The objection is that there are such s
Chris Jerdonek added the comment:
Yes, I think so. I should be able to get to it in the next few days unless
someone else beats me to it.
--
___
Python tracker
<http://bugs.python.org/issue16
Changes by Chris Jerdonek :
--
resolution: -> fixed
stage: needs patch -> committed/rejected
status: open -> closed
___
Python tracker
<http://bugs.python.or
Changes by Chris Jerdonek :
--
nosy: +chris.jerdonek
___
Python tracker
<http://bugs.python.org/issue4395>
___
___
Python-bugs-list mailing list
Unsubscribe:
Chris Jerdonek added the comment:
It seems the clinic.txt DSL document should be proofread for proper/consistent
use of argument/parameter (e.g. as described in the recently added
http://docs.python.org/dev/glossary.html#term-parameter ). To choose a couple
random examples--
+Argument
Changes by Chris Jerdonek :
--
nosy: +ezio.melotti
___
Python tracker
<http://bugs.python.org/issue16612>
___
___
Python-bugs-list mailing list
Unsubscribe:
Chris Jerdonek added the comment:
I've been meaning to ask Georg or anyone else knowledgeable about what options
we have for redirects, etc. -- specifically for this issue. Maybe something
similar can even be done using Sphinx.
If we can't redirect, I was thinking even a stub p
Changes by Chris Withers :
--
nosy: -cjw296
___
Python tracker
<http://bugs.python.org/issue7741>
___
___
Python-bugs-list mailing list
Unsubscribe:
Chris Jerdonek added the comment:
Would it make sense for this list to be somehow reflected in or be
reconstructible from the documentation?
--
nosy: +chris.jerdonek
___
Python tracker
<http://bugs.python.org/issue16
Chris Jerdonek added the comment:
FYI, in the 3.2 branch I get 4 failures rather than just the one due to int:
$ ./python.exe Lib/idlelib/CallTips.py
int - expected
'int(x[, base]) -> integer'
- but got
'int(x=0) -> integer'
list.append - expected
'L.append(obje
Chris Jerdonek added the comment:
Thanks a lot, Roger!
--
resolution: -> fixed
stage: patch review -> committed/rejected
status: open -> closed
___
Python tracker
<http://bugs.python.or
New submission from Chris Jerdonek:
There are three IDLE test failures in the 3.2 branch:
$ ./python.exe Lib/idlelib/CallTips.py
list.append - expected
'L.append(object) -> None -- append object to end'
- but got
'L.append(object) -- append object to end'
[].append - ex
Chris Jerdonek added the comment:
I created issue 16655 for the three test failures I observed above.
--
___
Python tracker
<http://bugs.python.org/issue16
Chris Jerdonek added the comment:
> What lines end with a colon?
He probably means semicolon, for example:
+int dir_fd = DEFAULT_DIR_FD;
+default=None
--
___
Python tracker
<http://bugs.python.org/issu
Chris Jerdonek added the comment:
I think he's saying that a test package will never be discovered by default,
because the default value of discover()'s pattern argument is test*.py:
http://hg.python.org/cpython/file/bc322469a7a8/Lib/unittest/loader.py#l152
So I think he wan
Chris Jerdonek added the comment:
This might be a good place to use the newly-documented "positional-only"
nomenclature:
http://docs.python.org/2.7/glossary.html#term-parameter
--
nosy: +chris.jerdonek
___
Python tracker
<http://bu
Chris Jerdonek added the comment:
Is issue 13386 one of the issues you had in mind, Éric? I don't know the
current best practices for all of the signature edge cases, but Ezio might.
Personally, I think explicitly stating in the text that the parameters are
positional-only can&#
Chris Jerdonek added the comment:
This issue only applies to 2.7. Keyword arguments are accepted in 3.x. See
the interactive example here, for example:
http://docs.python.org/3.2/library/socket.html#socket.getaddrinfo
--
versions: -Python 2.6
Chris Jerdonek added the comment:
Could you mock or monkey-patch what you are getting a tool tip for (i.e. set
the "external" string you are checking for)?
--
___
Python tracker
<http://bugs.python.o
Chris Jerdonek added the comment:
Also see this e-mail to docs@:
http://mail.python.org/pipermail/docs/2012-December/012028.html
> Subject: [docs] FOO and BAR
>
> Do you think it would be possible to write your documentation avoiding the
> silly usage of FOO and BAR everywhere? Th
Chris Jerdonek added the comment:
Hi Jan, yes, the documentation now describes the non-Windows behavior, which is
different from the Windows behavior. See the comment just before yours on what
still needs to be done to resolve this issue. I was in the middle of creating
a bunch of test
Changes by Chris Jerdonek :
--
nosy: +chris.jerdonek
___
Python tracker
<http://bugs.python.org/issue16714>
___
___
Python-bugs-list mailing list
Unsubscribe:
Chris Angelico added the comment:
I'm experiencing a similar issue. Fresh install of 3.3 today from the .msi
installer on the web site, identifies itself as:
Python 3.3.0 (v3.3.0:bd8afb90ebf2, Sep 29 2012, 10:55:48) [MSC v.1600 32 bit
(Intel)] on win32
To reproduce: Copy and paste
Chris Jerdonek added the comment:
> It will help if Python docs contained a definition of what can be considered
> 'binary data' and link this term from hexlify description to this definition.
I believe this is part of the goal of issue 16518, where "bytes-like object&q
Chris Jerdonek added the comment:
After this issue is resolved, the binascii docs can be updated as suggested in
issue 16724.
--
___
Python tracker
<http://bugs.python.org/issue16
New submission from Chris Jerdonek:
Currently, PEP 1 can be read to mean that should be CC'ed on
all e-mails related to PEPs. However, this isn't the intent because, for
example, it is okay to have discussions about PEPs on python-dev or
python-ideas without involving .
I
Changes by Chris Jerdonek :
--
keywords: +patch
Added file: http://bugs.python.org/file28389/issue-16746-1.patch
___
Python tracker
<http://bugs.python.org/issue16
Chris Jerdonek added the comment:
Thanks a lot, Nick. It looks like you also went ahead and took care of issue
16746. :)
--
___
Python tracker
<http://bugs.python.org/issue16
Chris Jerdonek added the comment:
This issue was just addressed by Nick's fix for issue 16581, specifically the
following parts of http://hg.python.org/peps/rev/24d5623ab21e :
+ is a mailing list consisting of PEP editors. All
+email related to PEP administration (such as requesting
Chris Jerdonek added the comment:
By the way, thanks for the clarifying info, David. Also, I thought I was the
one that was going to be accused of reading the original text like a computer.
:)
--
___
Python tracker
<http://bugs.python.
Chris Jerdonek added the comment:
If you are changing just a few minor things, can you resubmit the patch without
reflowing? It will be easier to see what minor things have changed. (It is
okay to have the occasional short line to avoid having long lines. Reflowing
can be done as part of a
Chris Jerdonek added the comment:
The reason in part is because of the lack of unit tests of regrtest (as
commenters above have noted). By preserving the getopt interface, we can keep
almost all of the untested code as is.
You should view the patch as a first step in refactoring to use
Chris Jerdonek added the comment:
Yes, I agree with all of that but thought it would be easier to review if done
incrementally as separate steps. In any case, I will look for Anton's patch on
the review tool in case I have any com
Chris Jerdonek added the comment:
> Do you like to apply Chris patch and wait for next step appear?
Just to clarify, I think this should read "apply Chris patch after
updating/reviewing." A couple file renames are needed, and I noticed a typo in
a docstring. Other changes
Chris Jerdonek added the comment:
> why regrlib.py at all? Why isn't the code in regrtest.py?
It was for a few related reasons. It was primarily to make it easier to reason
about testing regrtest, and to avoid at the outset any pitfalls that might
arise from the circularity of
Chris Jerdonek added the comment:
By the way, I am in the process of cleaning up the patch a bit.
--
___
Python tracker
<http://bugs.python.org/issue15
Chris Jerdonek added the comment:
Here is an updated, improved patch.
--
Added file: http://bugs.python.org/file28422/issue-15302-3.patch
___
Python tracker
<http://bugs.python.org/issue15
Changes by Chris Jerdonek :
--
nosy: +chris.jerdonek
___
Python tracker
<http://bugs.python.org/issue16772>
___
___
Python-bugs-list mailing list
Unsubscribe:
Changes by Chris Jerdonek :
--
nosy: +chris.jerdonek
___
Python tracker
<http://bugs.python.org/issue16773>
___
___
Python-bugs-list mailing list
Unsubscribe:
Chris Jerdonek added the comment:
This is good work. Thanks.
> I think merging test_int and test_long is hard task and should be done in
> separated issue.
I meant "share" rather than "merge." For the tests you're adding, isn't it
simply a matter of pu
Chris Jerdonek added the comment:
A test also needs to be added, though I'm sure one will be added as part of
issue 16761.
--
___
Python tracker
<http://bugs.python.org/is
Chris Jerdonek added the comment:
Note that "hg graft" is already mentioned/discussed in the devguide here:
http://docs.python.org/devguide/committing.html#porting-between-major-versions
--
___
Python tracker
<http://bugs.python.o
Chris Jerdonek added the comment:
See this thread:
http://mail.python.org/pipermail/python-dev/2012-December/123283.html
--
___
Python tracker
<http://bugs.python.org/issue16
Chris Jerdonek added the comment:
It's enough not to make the problem worse, which is why I suggested it and what
I wanted to avoid. If you copy-paste the tests you're adding now, it worsens
the problem and makes it that much more tedious to fix later on (and to
maintain in th
Chris Jerdonek added the comment:
Yes, it is a better approach. At first glance, the patches look okay to me.
--
___
Python tracker
<http://bugs.python.org/issue16
Chris Jerdonek added the comment:
Other things that should be done include porting the more comprehensive tests
in a recent changeset from 2.7 to 3.x and refactoring the try-except of one of
the tests as necessary (see the Rietveld comments of issue 16761 for details on
both).
The various
Chris Jerdonek added the comment:
> BTW, maybe someone should create an issue for full tests coverage of regrtest?
I think such an issue would need to be a meta-issue because it is a very large
task (involving many patches) and may never be truly finished.
> Chris, would you commit it?
Chris Jerdonek added the comment:
Benjamin, do you not want a new file at all, or are you just asking for a
different name? regrlib was the previous name unless you have another
suggestion.
--
___
Python tracker
<http://bugs.python.org/issue15
Chris Jerdonek added the comment:
I'm attaching an updated patch incorporating David and Benjamin's suggestion.
(Thanks a lot for the feedback, by the way.) I also added a test for the help
option and refactored to avoid having to use context managers to check
sys.argv, sys.s
Chris Jerdonek added the comment:
Here is an alternative patch with a cleaner diff (keeping the help-related
strings at the top before the import statements).
--
Added file: http://bugs.python.org/file28449/issue-15302-5.patch
___
Python tracker
Chris Jerdonek added the comment:
Thanks. I replied.
--
___
Python tracker
<http://bugs.python.org/issue15302>
___
___
Python-bugs-list mailing list
Unsubscribe:
New submission from Chris Jerdonek:
Currently, adding new int() and long() tests that are common to both requires
duplicating the tests in both test_int and test_long, which makes the tests
harder to review and maintain and keep in synch.
Providing a simple way to share tests between test_int
Chris Jerdonek added the comment:
Attaching patch. The tests moved to SharedTestCaseMixin in this patch are
tests that were very recently added (as part of issue 16045) and that are
planned on being added to test_long as part of issue 16784.
--
keywords: +patch
Added file: http
Chris Jerdonek added the comment:
I created issue 16790 to allow the sharing of tests between test_int and
test_long in 2.7. I don't think issue 16761 and issue 16772 should be
prerequisites to this issue though because both issues could benefit from issue
16790 being committed first (
Chris Jerdonek added the comment:
Agreed. I just didn't want it to be a requirement of beginning shared tests in
case anyone objects to refactoring existing tests in 2.7 -- as opposed to using
it for the addition of new tests.
--
___
P
Chris Jerdonek added the comment:
Good point. New patch coming shortly.
--
___
Python tracker
<http://bugs.python.org/issue16790>
___
___
Python-bugs-list mailin
Chris Jerdonek added the comment:
> In any case the final version of those changes should be applied to 3.2 and
> 3.3 too (if no one objects).
+1
--
___
Python tracker
<http://bugs.python.org/i
Chris Jerdonek added the comment:
Note that we need to be more careful about checking for duplicate test names
now.
--
Added file: http://bugs.python.org/file28451/issue-16790-2-27.patch
___
Python tracker
<http://bugs.python.org/issue16
Chris Jerdonek added the comment:
After this issue, the ordering of new test_int test cases in 3.x should
preferably match the ordering in 2.7 for easier back-porting when the tests are
new in both. For example, test_no_args() and test_keyword_args() could go at
the top of 3.x's IntTest
Chris Jerdonek added the comment:
Updating patch after Benjamin's review.
In this new patch, in test_regrtest I now use the current, actual getopt code
to test and demonstrate backwards compatibility. Note that when I pasted the
code, I also fixed the three typos in the current getopt
Chris Jerdonek added the comment:
The attached patch will fix this issue as well as issue 15325 and issue 15326.
Also, I'm removing issue 15302 as a superseder because that issue is limited to
3.4. The attached patch is for prior versions. (Also, it doesn't hurt to
apply this
Chris Jerdonek added the comment:
Rietveld is erroring out on me again whenever I try to reply to a comment, so
I'm posting my comment here.
On 2012/12/27 18:29:22, Benjamin Peterson wrote:
> > On 2012/12/27 04:44:33, Benjamin Peterson wrote:
> > > if val:
> >
> &
Chris Jerdonek added the comment:
Thanks for the reviews, Serhiy.
--
resolution: -> fixed
stage: patch review -> committed/rejected
status: open -> closed
___
Python tracker
<http://bugs.python.or
Changes by Chris Jerdonek :
--
nosy: +chris.jerdonek
___
Python tracker
<http://bugs.python.org/issue16793>
___
___
Python-bugs-list mailing list
Unsubscribe:
Changes by Chris Jerdonek :
--
nosy: +chris.jerdonek
___
Python tracker
<http://bugs.python.org/issue16792>
___
___
Python-bugs-list mailing list
Unsubscribe:
Chris Jerdonek added the comment:
LGTM.
--
___
Python tracker
<http://bugs.python.org/issue16793>
___
___
Python-bugs-list mailing list
Unsubscribe:
Chris Jerdonek added the comment:
When this patch is updated because of the commit for issue 16790, in 3.x can
the edited test cases be moved to the top of the test class per the following
comment (as appropriate)?
http://bugs.python.org/issue16790#msg178282
As stated there, this will make
Changes by Chris Jerdonek :
--
title: --match does not work for regrtest -> --fromfile, --match, and
--randomize don't work in regrtest
___
Python tracker
<http://bugs.python.org
Changes by Chris Jerdonek :
--
resolution: -> duplicate
stage: patch review -> committed/rejected
status: open -> closed
superseder: Use argparse instead of getopt in test.regrtest -> --fromfile,
--match, and --randomize don't
Changes by Chris Jerdonek :
--
resolution: -> duplicate
stage: patch review -> committed/rejected
status: open -> closed
superseder: Use argparse instead of getopt in test.regrtest -> --fromfile,
--match, and --randomize don't work in regrtest
versions: +Python 2.7, P
Chris Jerdonek added the comment:
I agree with Serhiy here. This use case seems too specialized, and there are
easy ways to achieve the same thing in code.
--
nosy: +chris.jerdonek
___
Python tracker
<http://bugs.python.org/issue16
Chris Jerdonek added the comment:
You can use assertIs() in 2.7 as well, no?
+@test_support.cpython_only
+def test_small_ints(self):
+self.assertTrue(int('10') is 10)
--
___
Python tracker
<http://bugs.python.o
Changes by Chris Jerdonek :
--
resolution: -> fixed
stage: patch review -> committed/rejected
status: open -> closed
type: enhancement -> behavior
___
Python tracker
<http://bugs.python
Chris Jerdonek added the comment:
Thanks again for your reviews, Benjamin (and others).
I created issue 16799 for the next phase of this process: changing
regrtest.main() from operating on getopt-style parsed options to an argparse
Namespace object.
--
resolution: -> fixed
st
New submission from Chris Jerdonek:
Issue 15302 switched regrtest from getopt to argparse for parsing options.
However, regrtest.main() still expects and operates on getopt-style options.
This issue is to continue the regrtest refactoring and replace the use of
getopt-style options with an
Changes by Chris Jerdonek :
--
title: switch regrtest from getopt-style options to argparse Namespace object
-> switch regrtest from getopt options to argparse Namespace
___
Python tracker
<http://bugs.python.org/issu
Chris Jerdonek added the comment:
Since regrtest is now using argparse (as of 6e2e5adc0400), is there a reason to
keep this issue open? Or should the issue be retitled (current title: "Move
test.regrtest from getopt to argparse")? There seem to be some thoughts in the
comment
Chris Jerdonek added the comment:
> I actually think this issue can be closed as fixed: the current code looks
> fine to me, and I don't think the fix should be backported.
How about backporting the tests? In addition to adding tests for the fix, Greg
added more comprehensive te
Chris Jerdonek added the comment:
Another task: backport the tests for current behavior added under issue 16772
(e.g. test_int_base_limits() tests).
--
___
Python tracker
<http://bugs.python.org/issue16
Chris Jerdonek added the comment:
Improvement of int/long tests should also be reflected in the Tests section of
Misc/NEWS. An entry wasn't added in issue 16045. For linking purposes, this
issue number would probably be the best to use for such an
Chris Jerdonek added the comment:
Here is a patch to start using a Namespace object.
I also noticed that the usage() function I removed in 6e2e5adc0400 is still
used elsewhere in regrtest.main(), so this patch also fixes that.
--
keywords: +patch
Added file: http://bugs.python.org
Chris Jerdonek added the comment:
Was argparse ever supposed to support inputs of the form given in the example
(i.e. different positional arguments straddling optional arguments): 'yy -x zz'?
The usage string shows up as: "usage: test.py [-h] [-x] y [z [z ...]]" The
or
Chris Jerdonek added the comment:
Thanks for the patch.
Out of curiosity, does anyone know if the following works on all or most
systems?
$ open _build/html/index.html
That could also be added to save time for people that don't already know.
--
nosy: +chris.jerdonek
resol
Chris Jerdonek added the comment:
Thanks. Btw, it works for me on Mac OS X I believe out of the box:
Help: Open opens files from a shell.
By default, opens each file using the default application for that file.
If the file is in the form of a URL, the file will be opened as a URL
Chris Jerdonek added the comment:
Another option is to give the shorter option as an alternative. I for one
didn't know about that option but would have liked to. Patch attached.
Also, this way we can give the shorter option and the reader can still see
pretty easily what it i
Chris Jerdonek added the comment:
> Another option is to give the shorter option as an alternative.
s/shorter option/one-liner/
--
___
Python tracker
<http://bugs.python.org/issu
Chris Jerdonek added the comment:
Changed lines should still be reflowed to respect the column limit. I was just
referring to the unchanged lines before and afterwards that shouldn't be
reflowed.
Not reflowing makes it easier for people viewing diffs on python-checkins and
hg.pytho
Chris Jerdonek added the comment:
Content-wise the patch looks pretty good. I agree with the recommendations. A
couple suggestions though: I would break up the 20 lines of command-line
commands. Right now that chunk is a bit too long to grasp meaningfully. My
suggestion would be to break
Chris Jerdonek added the comment:
I observed this issue earlier in issue 16799. See that issue for a fix. Can
one of you review that patch? Thanks.
--
___
Python tracker
<http://bugs.python.org/issue16
Changes by Chris Jerdonek :
--
dependencies: +switch regrtest from getopt options to argparse Namespace
___
Python tracker
<http://bugs.python.org/issue16
Changes by Chris Jerdonek :
--
assignee: -> chris.jerdonek
___
Python tracker
<http://bugs.python.org/issue16854>
___
___
Python-bugs-list mailing list
Un
Chris Jerdonek added the comment:
One thing that occurred to me is that it is often or usually not sufficient to
go from 2.7 to 3.2 and on forward because applying a patch made against the
default branch loses information if first applied to an earlier branch. The
given workflow assumes no
Chris Jerdonek added the comment:
Thanks. Andrew, could you also take a quick look at this?
--
title: switch regrtest from getopt options to argparse Namespace -> start using
argparse.Namespace in regrtest
___
Python tracker
&l
Chris Jerdonek added the comment:
I would also take out the sentence about forgetting about the issue, because
that's just one of several possible reasons and I don't think usually the main
reason.
--
nosy: +chris.jerdonek
___
Python trac
Chris Jerdonek added the comment:
Here is another recent comment from Georg on this topic:
"And please don't commit cosmetic/"cleanup" changes to bugfix branches in the
future."
(from http://bugs.python.org/issue16793#msg178372 )
---
2001 - 2100 of 2758 matches
Mail list logo
