Changes by Brian Curtin :
--
type: crash -> behavior
versions: -Python 2.5, Python 2.6, Python 3.4
___
Python tracker
<http://bugs.python.org/issue11891>
___
_
Brian Curtin added the comment:
2.6 is only receiving security fixes at the moment, so it won't make it into
there.
--
nosy: +brian.curtin
___
Python tracker
<http://bugs.python.org/is
Changes by Brian Curtin :
--
resolution: -> out of date
stage: -> committed/rejected
status: open -> closed
versions: -Python 3.4
___
Python tracker
<http://bugs.python.or
Changes by Brian Curtin :
--
nosy: +brian.curtin
___
Python tracker
<http://bugs.python.org/issue11834>
___
___
Python-bugs-list mailing list
Unsubscribe:
Brian Curtin added the comment:
I created/assigned #10646 to myself for other samefile issues - I can cover
this as well unless someone beats me to it.
--
assignee: -> brian.curtin
nosy: +brian.curtin
stage: -> needs patch
versions: +Pyth
Changes by Brian Curtin :
--
resolution: -> fixed
stage: patch review -> committed/rejected
status: open -> closed
___
Python tracker
<http://bugs.python.or
Brian Curtin added the comment:
> I'm not confident to start using this build until I can pin down why eg
> test_argparse and test_import are failing.
Feel free to look into the failures in Lib/test/test_argparse.py and
Lib/test/test_import.py
--
nosy: +b
Changes by Brian Curtin :
--
nosy: +brian.curtin
___
Python tracker
<http://bugs.python.org/issue11344>
___
___
Python-bugs-list mailing list
Unsubscribe:
Changes by Brian Curtin :
--
components: +Tests -Build
type: crash -> behavior
___
Python tracker
<http://bugs.python.org/issue11955>
___
___
Python-bugs-lis
Changes by Brian Curtin :
--
components: +Tests -Build
type: crash -> behavior
___
Python tracker
<http://bugs.python.org/issue11956>
___
___
Python-bugs-lis
Changes by Brian Curtin :
--
components: +Tests -Build
nosy: -brian.curtin
type: crash -> behavior
versions: +Python 3.3 -Python 3.4
___
Python tracker
<http://bugs.python.org/issu
Changes by Brian Curtin :
--
stage: -> needs patch
___
Python tracker
<http://bugs.python.org/issue11954>
___
___
Python-bugs-list mailing list
Unsubscri
New submission from Brian Curtin :
Attached is a patch that adds documentation for a few things that have existed
in subprocess for a while without documentation.
The "startupinfo" parameter takes subprocess.STARTUPINFO object which takes a
few different options for its attributes
Changes by Brian Curtin :
--
assignee: -> brian.curtin
nosy: +brian.curtin
___
Python tracker
<http://bugs.python.org/issue11361>
___
___
Python-bugs-list mai
Brian Curtin added the comment:
Thanks for having a look, Ezio.
--
resolution: -> fixed
stage: patch review -> committed/rejected
status: open -> closed
___
Python tracker
<http://bugs.python.or
Brian Curtin added the comment:
Duplicate of #11642, #11272, and #11278.
This is fixed. It'll be released in 3.2.1
--
nosy: +brian.curtin
resolution: -> duplicate
stage: -> committed/rejected
___
Python tracker
<http://bugs.python.
Brian Curtin added the comment:
Thanks for the patches and reviews!
--
assignee: -> brian.curtin
resolution: -> fixed
stage: needs patch -> committed/rejected
type: -> behavior
___
Python tracker
<http://bugs.python
Changes by Brian Curtin :
--
status: open -> closed
___
Python tracker
<http://bugs.python.org/issue11834>
___
___
Python-bugs-list mailing list
Unsubscri
Brian Curtin added the comment:
On XP, os.path.samefile is really "os.path.abspath(x) == os.path.abspath(y)",
which does not work correctly with different cases. We could add a ".lower()"
to line 657 of Lib/ntpath.py so the abspath is always returned in lower, so the
XP
Brian Curtin added the comment:
I don't have time to test it at the moment, but it seems fine to me.
--
___
Python tracker
<http://bugs.python.org/is
Changes by Brian Curtin :
--
nosy: +brian.curtin
___
Python tracker
<http://bugs.python.org/issue12018>
___
___
Python-bugs-list mailing list
Unsubscribe:
Brian Curtin added the comment:
Seems like it would be enough to add a wait() at the end?
diff -r 9e473917cbfb Lib/subprocess.py
--- a/Lib/subprocess.py Mon May 09 21:17:02 2011 +0200
+++ b/Lib/subprocess.py Mon May 09 15:30:02 2011 -0500
@@ -796,6 +796,7 @@
self.stderr.close
Brian Curtin added the comment:
Actually, I don't think the wait() is a good idea. If you want to block and
infinitely wait on the process to close, you should do so explicitly.
It's probably better that we try to use terminate() or kill() and raise if t
Brian Curtin added the comment:
Hm, yeah, not sure what I was thinking there.
I'm thinking there's not a lot we can do here, but also not a lot that we
should do here. We don't want to wait, and we don't want to close, so maybe we
should just document that the usage shoul
Brian Curtin added the comment:
Looks like we already mention that.
"""
Popen objects are supported as context managers via the with statement, closing
any open file descriptors on exit.
"""
Antoine, do you think this should be more strongly worded?
Brian Curtin added the comment:
Issues with Regexp should probably be handled on the Regexp tracker.
--
nosy: +brian.curtin
___
Python tracker
<http://bugs.python.org/issue2
Brian Curtin added the comment:
Are you able to narrow it down to which security update(s) caused the breakage?
--
___
Python tracker
<http://bugs.python.org/issue6
Brian Curtin added the comment:
Don't do anything you're not comfortable with. If you can get your system to
whatever state it was in the past where things worked properly, feel free to
dig into it. I will try to look into this situation and see if there's anything
in these s
Brian Curtin added the comment:
Out of the patches listed,
http://www.microsoft.com/technet/security/advisory/2269637.mspx is the only
part that appears to be related in any way, although it doesn't specify a whole
lot on the surface. The title is "Insecure Library Loading Could Al
Brian Curtin added the comment:
Hirokazu contacted me directly with these patches a few days ago but I haven't
been able to email him because his host's DNS is apparently down.
The tests in this patch do not end up testing anything, so we'll need to start
with a proper tes
Brian Curtin added the comment:
That's already fixed, it'll be in 3.2.1
--
nosy: +brian.curtin
___
Python tracker
<http://bugs.python.org/issue11990>
___
__
Brian Curtin added the comment:
Looks like I was referring to a different patch from the email - sorry for any
confusion.
--
___
Python tracker
<http://bugs.python.org/issue12
Changes by Brian Curtin :
--
Removed message: http://bugs.python.org/msg136132
___
Python tracker
<http://bugs.python.org/issue12084>
___
___
Python-bugs-list m
Brian Curtin added the comment:
Wow, nice analysis. http://connect.microsoft.com/ is the external Microsoft bug
tracker, as far as I know.
--
___
Python tracker
<http://bugs.python.org/issue6
Brian Curtin added the comment:
If we can generate a testable MSI file that would be the best. Including a very
small pre-generated MSI for the purposes of the test would be acceptable.
As-is, the tests don't pass because my machine has
C:\Windows\installer\1032f.msi that gets used fo
Brian Curtin added the comment:
I'm hoping to. I have time to work on it tonight and tomorrow night US/Chicago
time and will keep you posted.
--
assignee: -> brian.curtin
___
Python tracker
<http://bugs.python.org
Brian Curtin added the comment:
With the patch applied, the new test fails along with
test.test_os.WalkTests.test_traversal and
test.test_os.Win32SymlinkTests.test_directory_link.
Overall, I agree that this doesn't work correctly. The patch, which is pretty
large, breaks more than it
Brian Curtin added the comment:
This is intentional. See the implementation of join in Lib/posixpath.py and the
Windows implementation in Lib/ntpath.py which also includes a comment
explaining why.
# path is not empty and does not end with a backslash,
# but b is empty; since, e.g., split(&#
Changes by Brian Curtin :
--
nosy: +brian.curtin
___
Python tracker
<http://bugs.python.org/issue11455>
___
___
Python-bugs-list mailing list
Unsubscribe:
Brian Curtin added the comment:
Please report this to the regex bug tracker.
--
nosy: +brian.curtin
resolution: -> rejected
stage: -> committed/rejected
status: open -> closed
___
Python tracker
<http://bugs.python.or
Brian Curtin added the comment:
Fixed in r86506 for py3k. The maintenance branches recently had an RC in
preparation for a release -- I'll backport once they go out.
--
assignee: -> brian.curtin
nosy: +brian.curtin
resolution: -> accepted
type: feature request ->
Brian Curtin added the comment:
joblack - are you still seeing issues with this?
--
___
Python tracker
<http://bugs.python.org/issue10002>
___
___
Python-bug
Brian Curtin added the comment:
This can't actually work. You can't delete a directory which has open handles
to it on Windows, namely the Python process you're running in that directory.
The empty file path isn't really the issue here. shutil.rmtree(os.getcwd())
attempt
Brian Curtin added the comment:
I'm not sure how that would work in terms of redistributing, and how we'd
handle it within our own build process. This close to the beta I'm -1 on adding
that API.
--
___
Python tracker
<http
Brian Curtin added the comment:
Daniel: If you need VS2008, you can get it here:
http://www.microsoft.com/express/Downloads/#2008-Visual-CPP
--
___
Python tracker
<http://bugs.python.org/issue10
Changes by Brian Curtin :
--
nosy: +asksol
___
Python tracker
<http://bugs.python.org/issue7506>
___
___
Python-bugs-list mailing list
Unsubscribe:
Brian Curtin added the comment:
Closing - OpenSSL was upgraded to version 1.0.0a a few months ago.
--
resolution: -> out of date
status: open -> closed
___
Python tracker
<http://bugs.python.org/
Changes by Brian Curtin :
--
stage: -> committed/rejected
___
Python tracker
<http://bugs.python.org/issue8569>
___
___
Python-bugs-list mailing list
Unsubscri
Changes by Brian Curtin :
--
nosy: +brian.curtin
___
Python tracker
<http://bugs.python.org/issue4925>
___
___
Python-bugs-list mailing list
Unsubscribe:
Brian Curtin added the comment:
Can you provide a test case for this?
--
nosy: +asksol, brian.curtin
stage: -> unit test needed
___
Python tracker
<http://bugs.python.org/iss
Brian Curtin added the comment:
I don't think this is a feature request. This batch file should always run the
version of the file for which the batch is installed. For it to be generic and
end up using another installed version is incorrect. With that said...
Fixed in r86651, r86652
Brian Curtin added the comment:
True. I'll correct it.
--
___
Python tracker
<http://bugs.python.org/issue6378>
___
___
Python-bugs-list mailing list
Unsubsc
Brian Curtin added the comment:
Corrected in r86655, r86656, and r86657.
--
___
Python tracker
<http://bugs.python.org/issue6378>
___
___
Python-bugs-list mailin
Brian Curtin added the comment:
The addition of the Setup.sample to Tools/msi/msi.py was only done in 3.2. I
backported it to 3.1 in r8 and 2.7 in r86667.
--
assignee: tarek -> brian.curtin
nosy: +brian.curtin
resolution: -> fixed
stage: -> committed/rejected
sta
Brian Curtin added the comment:
I'm with Tim and Mark - can't reproduce this, so I'm closing the report. If you
are able to find another case which can reproduce this, feel free to re-open.
--
resolution: -> rejected
stage: -> committed/rejected
status: open
Changes by Brian Curtin :
--
nosy: -phillip.m.feld...@gmail.com
___
Python tracker
<http://bugs.python.org/issue1859>
___
___
Python-bugs-list mailing list
Unsub
Brian Curtin added the comment:
Committed to py3k in r86727.
I think this should be backported to the maintenance branches, but not until
after the upcoming point releases. Although those branches won't have the
ability to create hard links, they should have the ability to view inform
Brian Curtin added the comment:
Removing link to #10027. It's fixed for py3k but the issue should stay open for
backport to other branches.
--
dependencies: -os.lstat/os.stat don't set st_nlink on Windows
resolution: -> fixed
___
P
Brian Curtin added the comment:
Fixed in r86733.
--
stage: patch review -> committed/rejected
status: open -> closed
___
Python tracker
<http://bugs.python.org/
Brian Curtin added the comment:
I'll come up with a patch for Amaury's message.
Hirokazu - I didn't see that MSDN page, thanks. Without st_ino, I'll need to
find a way around the block of lines 1941-1954 in Lib/tarfile.py. That's what
was causing a test failure in t
New submission from Brian Curtin :
My build slave shows a test failure at test_dont_copy_file_onto_link_to_itself.
This happens because the implementation of _samefile in Lib/shutil.py (line 70)
doesn't work for Windows hard links.
Patch on the way.
--
assignee: brian.c
Brian Curtin added the comment:
Here is a patch.
os.path.samefile and hard links don't work for Windows the same way they do for
Mac/Linux. In the case where we are on Windows and a link comes into the
_samefile function, check that it's a link and then use os.path.sameopenfile.
I
Brian Curtin added the comment:
Jeff Hardy just made this change for IronPython 2.7:
http://bitbucket.org/ironpython/ironlanguages/changeset/b6bb2a9a7bc5
Any opposition to us matching that so they don't need to patch
Lib/subproce
Brian Curtin added the comment:
Amaury -- how does issue8879_unicode.diff look? Made the suggested change and
added a test.
--
stage: committed/rejected -> patch review
Added file: http://bugs.python.org/file19862/issue8879_unicode.diff
___
Pyt
Brian Curtin added the comment:
Committed in r86854 with your win32_error suggestion. Thanks for your help and
input.
--
___
Python tracker
<http://bugs.python.org/issue8
Brian Curtin added the comment:
Maybe the test should be Windows-only?
I don't really know the answer...things tend to fall apart when I get involved
with Unicode, encoding, codecs, etc. :/
--
___
Python tracker
<http://bugs.python.org/i
Brian Curtin added the comment:
What installer?
Please provide a patch.
--
nosy: +brian.curtin
priority: normal -> low
stage: -> needs patch
___
Python tracker
<http://bugs.python.org/i
Brian Curtin added the comment:
Fixed in r86906. Split the shared setUp/tearDown into individual methods for
each part.
--
resolution: -> fixed
stage: -> committed/rejected
status: open -> closed
___
Python tracker
<http://bug
Brian Curtin added the comment:
Fixed in r86935.
Tests pass on the following setups:
- Windows 7 (regular user - no symlink privilege)
- Windows 7 (administrator + symlink privilege)
- Windows Server 2003 (no symlink abilities)
- Arch Linux (just a sanity check)
I'm going to create a f
New submission from Brian Curtin :
A section in the Windows FAQ should better explain the recent addition of
os.symlink and how it can be used, along with examples.
If a user just sits down and hits Start>Run>python, os.symlink will almost
positively not be available. I'll need
Brian Curtin added the comment:
Here's a patch for the ResourceWarnings that were introduced.
--
nosy: +brian.curtin
Added file: http://bugs.python.org/file19909/warnings.diff
___
Python tracker
<http://bugs.python.org/is
Brian Curtin added the comment:
Will PYTHONIMAGINARYPERMUTATIONDIR accept imaginary numbers? If so, we will
also need PYTHONIMAGINARYPERMUTATIONDIRIMAGINARYIDENTIFIER.
--
nosy: +brian.curtin
___
Python tracker
<http://bugs.python.org/issue10
Brian Curtin added the comment:
yes
--
___
Python tracker
<http://bugs.python.org/issue10562>
___
___
Python-bugs-list mailing list
Unsubscribe:
http://mail.pyth
Brian Curtin added the comment:
> So the presence of os.symlink depends on some dynamic privilege?
Yes.
> Why not simply raise an exception when the user has not enough
> privileges? (I mean OSError or WindowsError of course, not AttributeError)
My thinking was that anyone writ
Brian Curtin added the comment:
Here's a patch which implements the context manager and adds a few tests and a
small doc change.
Tested on Mac and Windows.
--
keywords: +patch
nosy: +brian.curtin
Added file: http://bugs.python.org/file19916/subprocess
Brian Curtin added the comment:
I updated the doc to be much more simple. I got used to sys.executable based
tests :) New patch attached.
As for __del__, I think it should do it's thing, and the exit will do it's own.
Context managers are traditionally used on file-based things,
Brian Curtin added the comment:
Committed in r86951. Thanks for the reviews!
--
assignee: -> brian.curtin
resolution: -> fixed
stage: needs patch -> committed/rejected
___
Python tracker
<http://bugs.python.or
Changes by Brian Curtin :
--
nosy: -brian.curtin
___
Python tracker
<http://bugs.python.org/issue10562>
___
___
Python-bugs-list mailing list
Unsubscribe:
Brian Curtin added the comment:
> a test isn't actually needed for this patch.
This is incorrect.
--
nosy: +brian.curtin
___
Python tracker
<http://bugs.python.org
Changes by Brian Curtin :
--
components: +Library (Lib)
stage: -> unit test needed
versions: +Python 2.7, Python 3.1, Python 3.2 -Python 2.5, Python 2.6
___
Python tracker
<http://bugs.python.org/issu
Changes by Brian Curtin :
--
nosy: +brian.curtin
___
Python tracker
<http://bugs.python.org/issue10634>
___
___
Python-bugs-list mailing list
Unsubscribe:
Brian Curtin added the comment:
No, and please do not clutter this issue with any perceived typo discussions.
--
nosy: +brian.curtin
___
Python tracker
<http://bugs.python.org/issue10
Brian Curtin added the comment:
I'll come up with a patch to make the attribute always available, but raise
OSError when the privilege is not held.
--
resolution: fixed ->
___
Python tracker
<http://bugs.python.or
Brian Curtin added the comment:
Changing "Completing" to "Complete" seems fine to me.
Here is a screenshot of where this currently appears:
http://i.imgur.com/RX9b9.png
--
___
Python tracker
<http://bug
New submission from Brian Curtin :
ntpath.samefile is currently implemented using GetFinalPathNameByHandle, which
doesn't work for hard links.
Since I introduced values for os.stat().st_ino in #8879 (which implemented
os.link), I suspect we can possibly change ntpath.samefile to be the
Changes by Brian Curtin :
--
type: crash -> behavior
___
Python tracker
<http://bugs.python.org/issue10647>
___
___
Python-bugs-list mailing list
Unsubscri
Brian Curtin added the comment:
I don't see this on a US/English version of Windows 7 with 3.2b1 installed.
cp932 is the default on a Japanese version, correct?
(I'm not very good with all of this encoding stuff so I don't know how much
help I can be)
--
nosy
Brian Curtin added the comment:
I don't see this on a US/English version of Windows 7 with 3.2b1 installed.
--
nosy: +brian.curtin
___
Python tracker
<http://bugs.python.org/is
Brian Curtin added the comment:
You can create a branch, checkin to that branch, then specify that a specific
buildbot runs your branch. See the "force build" page of a build slave.
Additionally, I can give you access to my build slave, the Windows Server 2008
one, but that may
Brian Curtin added the comment:
Here's a patch. I think this works more like what you guys are looking for.
Tests pass on Windows 7 and I checked it on a Mac to be sure, and it's good
there too.
--
Added file: http://bugs.python.org/file20178/issue93
Brian Curtin added the comment:
(hit enter too soon, sorry)
The patch makes os.symlink always available on Windows machines, but it will
only have an effect when privileged. Windows XP and Windows 2003 will still
receive NotImplementedError, as the underlying calls aren't available ther
Brian Curtin added the comment:
Thanks for having a look.
Checked in with the suggested changes to r87539.
--
resolution: -> fixed
stage: commit review -> committed/rejected
status: open -> closed
___
Python tracker
<http://bug
Brian Curtin added the comment:
Checked in a small doc update in r87547. Removes the part about os.symlink not
being available, and mentions the OSError.
--
___
Python tracker
<http://bugs.python.org/issue9
Brian Curtin added the comment:
Looks like this might be an issue with the Windows Server 2008 build slave. I
restarted it last night and a bunch of builds after that have failed due to
this test.
--
resolution: fixed ->
stage: committed/rejected ->
status: closed -
Brian Curtin added the comment:
Oops, sorry. Fixed in r87561.
--
stage: commit review -> committed/rejected
status: open -> closed
___
Python tracker
<http://bugs.python.org/
Brian Curtin added the comment:
This isn't failing in manual runs of regrtest -uall on that machine.
--
status: open -> pending
___
Python tracker
<http://bugs.python.or
Brian Curtin added the comment:
Looks like whatever caused this is now gone.
--
resolution: -> fixed
stage: -> committed/rejected
status: pending -> closed
___
Python tracker
<http://bugs.python.o
Brian Curtin added the comment:
Alexander:
>PCbuild\amd64\python_d.exe
Python 3.2b2+ (py3k, Jan 3 2011, 10:24:18) [MSC v.1500 64 bit (AMD64)] on win32
Type "help", "copyright", "credits" or "license" for more information.
>>> import time
[5
Brian Curtin added the comment:
No crash on 0-day or 300,000. I bumped it up to 3,000,000 and got a
UnicodeDecodeError, although I'm not sure of the relevance of that to this
issue.
>>> time.asctime((12345, 1, 0, 0, 0, 0, 0, 0, 0))
'Mon Jan 01 00:00:00 <345'
[5
Brian Curtin added the comment:
Closed. I'll be adding this in #10608.
--
resolution: -> duplicate
stage: needs patch -> committed/rejected
status: open -> closed
superseder: -> Add a section to Windows FAQ explaining os.symlink
_
301 - 400 of 1382 matches
Mail list logo
