New submission from Brian Brazil :
fileio_init will leak a fd if you open a file for append that isn't seekable.
We should close this fd before returning the failure.
The attached patch fixes this and a resource warning in the tests, but I'm
unsure if it'd be better to use inte
Brian Brazil added the comment:
Version 2 of the patch is attached.
This fixes a warning at line 256 in test_fileio.py:
f = _FileIO("/dev/tty", "a")
on my Hardy machine.
--
Added file: http://bugs.python.org/file19433/fil
Brian Curtin added the comment:
Is there a reason this removes the Release x64 configuration?
--
nosy: +brian.curtin
___
Python tracker
<http://bugs.python.org/issue9
Brian Curtin added the comment:
Let me rephrase that: What makes the Release x64 configuration unnecessary,
thus removed?
--
___
Python tracker
<http://bugs.python.org/issue9
New submission from Brian Brazil :
Please see attached patch.
--
components: Tests
files: test_pkgimport_fd_leak.patch
keywords: patch
messages: 120014
nosy: bbrazil
priority: normal
severity: normal
status: open
title: Fix resource warnings in test_pkgimport
versions: Python 3.3
Added
New submission from Brian Brazil :
Please see attached.
--
components: Tests
files: test_os_fd_leak.patch
keywords: patch
messages: 120015
nosy: bbrazil
priority: normal
severity: normal
status: open
title: Fix resource warnings in test_os
versions: Python 3.3
Added file: http
Brian Brazil added the comment:
I'm used to a slightly different style guide, v2 has the right indentation.
--
Added file: http://bugs.python.org/file19438/test_os_fd_leak_v2.patch
___
Python tracker
<http://bugs.python.org/is
New submission from Brian Brazil :
Please see attached patch.
--
components: Tests
files: test_tokenize_fd_leak.patch
keywords: patch
messages: 120019
nosy: bbrazil
priority: normal
severity: normal
status: open
title: Fix resource warnings in distutil test_tokenize
versions: Python 3.3
Brian Curtin added the comment:
Fixed in r85984. Thanks.
--
assignee: -> brian.curtin
nosy: +brian.curtin
resolution: -> fixed
stage: -> committed/rejected
status: open -> closed
type: -> resource usage
versions: +Python
Brian Curtin added the comment:
Fixed in r85987. Made both places hunks of the patch use the context manager.
--
assignee: -> brian.curtin
nosy: +brian.curtin
resolution: -> fixed
stage: -> committed/rejected
type: -> resource usage
versions: +Python 3.2
Changes by Brian Curtin :
--
status: open -> closed
___
Python tracker
<http://bugs.python.org/issue10257>
___
___
Python-bugs-list mailing list
Unsubscri
Brian Curtin added the comment:
Fixed in r85990. Thanks.
--
assignee: -> brian.curtin
nosy: +brian.curtin
resolution: -> fixed
stage: -> committed/rejected
status: open -> closed
type: -> resource usage
versions: +Python
Brian Brazil added the comment:
Fixing title.
--
title: Fix resource warnings in distutil test_tokenize -> Fix resource warnings
in test_tokenize
___
Python tracker
<http://bugs.python.org/issu
New submission from Brian Brazil :
Please see attached.
--
components: Tests
files: test_smtplib_fd_leak.patch
keywords: patch
messages: 120047
nosy: bbrazil
priority: normal
severity: normal
status: open
title: Fix resource warnings in test_smtplib
versions: Python 3.3
Added file: http
New submission from Brian Brazil :
Please see attached.
It's possible that this change will lead to fds leaking if someone is passing
in a fd, however a) this is consistent with how other modules (e.g. uu) do it
and b) of the 2 (!) uses of this module I found on Google Codesearch, both
Brian Curtin added the comment:
Forget the attachment?
--
nosy: +brian.curtin
type: -> resource usage
versions: +Python 3.2 -Python 3.3
___
Python tracker
<http://bugs.python.org/issu
New submission from Brian Brazil :
I missed this when fixing issue 10246. The attached patch fixes this and adds a
test that produces a resource warning with the old code.
--
components: Library (Lib)
files: uu_decode_fd_leak.patch
keywords: patch
messages: 120054
nosy: bbrazil
Brian Brazil added the comment:
That'd help alright.
--
keywords: +patch
Added file: http://bugs.python.org/file19446/sunau_fd_leak.patch
___
Python tracker
<http://bugs.python.org/is
Brian Brazil added the comment:
The patch is against current SVN.
--
___
Python tracker
<http://bugs.python.org/issue10266>
___
___
Python-bugs-list mailin
Brian Brazil added the comment:
Currently, if you pass in a fd it'll be closed by the __del__. My patch no
longer does this so any use of the module depending on this behaviour could
leak an fd. However, noone seems to use the module that way.
V2 attached.
--
Added file:
Brian Brazil added the comment:
The garbage collector should take care of the vast majority of these, it's only
bugs in the C like issue 10253 that I'd worry about.
--
___
Python tracker
<http://bugs.python.o
Brian Curtin added the comment:
A fix to this would help silence a number of ResourceWarning messages coming
out of the test suite.
--
nosy: +brian.curtin
___
Python tracker
<http://bugs.python.org/issue9
New submission from Brian Brazil :
Please see attached.
--
components: Tests
files: test_sax_fd_leak.patch
keywords: patch
messages: 120077
nosy: bbrazil
priority: normal
severity: normal
status: open
title: Fix some resource warnings in test_sax
versions: Python 3.3
Added file: http
New submission from Brian Brazil :
Please see attached.
--
components: Tests
files: test_threading_fd_leak.patch
keywords: patch
messages: 120079
nosy: bbrazil
priority: normal
severity: normal
status: open
title: Fix resource warnings in test_threading
Added file: http
Brian Curtin added the comment:
See the "types" module, specifically types.ModuleType. Compare that to your
"type(os)" result.
This is not a support channel. Please see python-list for these types of
questions.
--
nosy: +brian.curtin
resolution: -> reject
New submission from Brian Brazil :
If saxutils.prepare_input_source is passed a filename or url, it'll end up
leaking an fd via IncrementalParser.parse and ExpatParser.parse. This can be
seen by enabling resource warnings and running test_sax.
This should be fixed.
--
compo
New submission from Brian Curtin :
==
FAIL: test_garbage_at_shutdown (test.test_gc.GCTests)
--
Traceback (most recent call last):
File "c:\python-dev\py3
New submission from Brian Curtin :
The attached patch cleans up the numerous ResourceWarning messages that
distutils test runs generate. The changes basically just close all open files -
some in the test suite, some in the library code.
No context managers were used since distutils appears in
Brian Curtin added the comment:
Wow, I should open my eyes. Dupe of #10252
--
assignee: tarek ->
resolution: -> duplicate
stage: patch review -> committed/rejected
status: open -> closed
___
Python tracker
<http://bugs.python
Brian Curtin added the comment:
The patch shouldn't use context managers, as distutils claims to support 2.3.
#10290 contains a similar patch which doesn't use 'with'. (Sorry to duplicate
efforts here, forgot to search...)
--
nosy: +brian.curtin
sta
Brian Brazil added the comment:
I don't see your patch on the other bug, so I've updated mine not to use with.
--
Added file: http://bugs.python.org/file19470/distutils_fd_leak_v2.patch
___
Python tracker
<http://bugs.python.o
New submission from Brian Curtin :
As shown in a debug run of test_multiprocessing, at least two places in
managers.py apparently leave open sockets. Lines 786 and 805 are the culprits,
both util log lines.
--
components: Library (Lib)
messages: 120367
nosy: asksol, brian.curtin
Brian Curtin added the comment:
Works for me.
--
assignee: brian.curtin -> pitrou
___
Python tracker
<http://bugs.python.org/issue10279>
___
___
Python-
Changes by Brian Curtin :
--
nosy: -brian.curtin
___
Python tracker
<http://bugs.python.org/issue1926>
___
___
Python-bugs-list mailing list
Unsubscribe:
Brian Curtin added the comment:
Works for me. I think it should be ok to commit.
--
assignee: -> ocean-city
___
Python tracker
<http://bugs.python.org/issu
Changes by Brian Curtin :
Added file: http://bugs.python.org/file19524/fix_pipe_close.diff
___
Python tracker
<http://bugs.python.org/issue10252>
___
___
Python-bug
New submission from Brian Warner :
I noticed that the UnicodeDecodeError exception produced by trying to do
open(fn).readlines() (i.e. using the default ASCII encoding) on a file that's
actually UTF-8 reports the wrong offset for the first undecodeable character.
From what I can tel
Changes by Brian Curtin :
--
type: security -> behavior
___
Python tracker
<http://bugs.python.org/issue9995>
___
___
Python-bugs-list mailing list
Unsubscri
Brian Warner added the comment:
> Use .readline() to locate an invalid byte is not the right algorithm. If
> you would like to do that, you should open the file in binary mode and
> decodes the content yourself, chunk by chunk. Or if you manipulate small
> files, you can use .r
Brian Curtin added the comment:
> Still not sure why they were not showing up on the buildbots. Victor was
> working from an svn checkout and I from the binary installer, so it's not
> just a difference in the svn eol handling.
I too had only been seeing this in my checkout,
Brian Curtin added the comment:
The patch works for me.
Unfortunately my knowledge on this particular area is very low so I can't
really evaluate the patch.
--
___
Python tracker
<http://bugs.python.org/i
Brian Quinlan added the comment:
Looks good but you forgot to actually use your new Waiter ;-)
Committed as r86491.
--
resolution: -> fixed
stage: patch review -> committed/rejected
status: open -> closed
___
Python track
Changes by Brian Curtin :
--
nosy: +brian.curtin, loewis
___
Python tracker
<http://bugs.python.org/issue11288>
___
___
Python-bugs-list mailing list
Unsubscribe:
Brian Curtin added the comment:
It works fine for me. Just did a 32-bit Python 3.2 install on a Windows 7
64-bit machine and IDLE works.
--
___
Python tracker
<http://bugs.python.org/issue11
Changes by Brian Curtin :
--
assignee: -> lukasz.langa
nosy: +lukasz.langa
___
Python tracker
<http://bugs.python.org/issue11324>
___
___
Python-bugs-list mai
Brian Curtin added the comment:
Santoso - since this is a feature request it would need to be retargeted to 3.3
--
versions: +Python 3.3 -Python 2.7
___
Python tracker
<http://bugs.python.org/issue7
Brian Curtin added the comment:
-1 on going back through blah/xblah all over again.
--
nosy: +brian.curtin
___
Python tracker
<http://bugs.python.org/issue11
Brian Curtin added the comment:
FYI this was created during my PyCon talk...needed a non-dev account for the
demo.
--
nosy: +brian.curtin
___
Python tracker
<http://bugs.python.org/issue11
Brian Curtin added the comment:
This is a duplicate of #6727, which is now easier to fix due to the symlink
work in 3.2.
--
resolution: -> duplicate
stage: -> committed/rejected
status: open -> closed
___
Python tracker
<http://bug
Changes by Brian Curtin :
--
nosy: +brian.curtin
___
Python tracker
<http://bugs.python.org/issue6727>
___
___
Python-bugs-list mailing list
Unsubscribe:
New submission from Brian Merrell :
The following works on Win7x64 Python 2.6.5 and breaks on Ubuntu
10.04x64-2.6.5. This raises three issues:
1) Shouldn't anything generated by json.dumps be parsed by json.loads?
2) It appears this is an invalid unicode character. Shouldn't this
Brian Curtin added the comment:
Agreed, looks fine.
--
___
Python tracker
<http://bugs.python.org/issue11488>
___
___
Python-bugs-list mailing list
Unsubscribe:
Brian Merrell added the comment:
>I am not sure this should be fixed in 2.x. Lone surrogates seem to >round-trip
>just fine in 2.x and there likely to be existing code that >relies on this.
I generally agree but am then at a loss as to how to detect and deal with lone
surrogate
Brian Curtin added the comment:
Attached is a slightly updated version of the patch. If the assertEqual for any
reason were to fail, the file wouldn't be closed, leading to a ResourceWarning.
That'll work on 3.2+, but if this is backported consideration will have to be
made
Brian Curtin added the comment:
The 3.x side of things is taken care of. Still need to see if there is any
issue on 2.7 where things are organized differently and dbm is in C.
--
assignee: -> brian.curtin
stage: -> commit review
___
Changes by Brian Curtin :
--
keywords: +needs review
nosy: +brian.curtin
stage: -> patch review
___
Python tracker
<http://bugs.python.org/issue11503>
___
_
Changes by Brian Curtin :
--
assignee: -> brian.curtin
keywords: +needs review
stage: -> patch review
versions: +Python 2.7, Python 3.1, Python 3.2, Python 3.3
___
Python tracker
<http://bugs.python.org/i
Changes by Brian Curtin :
--
resolution: -> rejected
stage: -> committed/rejected
status: open -> closed
___
Python tracker
<http://bugs.python.o
Changes by Brian Curtin :
--
resolution: -> rejected
stage: -> committed/rejected
status: open -> closed
___
Python tracker
<http://bugs.python.org/
Brian Curtin added the comment:
I showed robquad how to do the review stuff at PyCon but I forgot about the
publish part. Robbie, if you hit "Publish + Mail Comments" near the top of the
page after you've left comments, it'll send them out.
What he noticed was that chan
Brian Curtin added the comment:
Many thanks for the patch, Denver!
--
assignee: -> brian.curtin
resolution: -> fixed
stage: -> committed/rejected
status: open -> closed
___
Python tracker
<http://bugs.python
Brian Curtin added the comment:
Tested the patch on Windows -- all tests pass.
--
___
Python tracker
<http://bugs.python.org/issue11503>
___
___
Python-bug
Changes by Brian Curtin :
--
nosy: +brian.curtin
___
Python tracker
<http://bugs.python.org/issue11577>
___
___
Python-bugs-list mailing list
Unsubscribe:
Brian Curtin added the comment:
I'm not seeing those warnings anymore, so I think the patch can be ignored.
--
___
Python tracker
<http://bugs.python.org/is
Brian Curtin added the comment:
I made a bunch of the stat changes in 3.2 so I'll assign this to myself and
take a look.
--
assignee: -> brian.curtin
stage: -> needs patch
___
Python tracker
<http://bugs.python.
Brian Curtin added the comment:
Thanks for the patch!
--
assignee: -> brian.curtin
nosy: +brian.curtin
resolution: -> fixed
stage: -> committed/rejected
status: open -> closed
___
Python tracker
<http://bugs.python
Changes by Brian Curtin :
--
nosy: +brian.curtin
___
Python tracker
<http://bugs.python.org/issue11629>
___
___
Python-bugs-list mailing list
Unsubscribe:
Brian Curtin added the comment:
You should report this to whoever makes npyio.py
--
nosy: +brian.curtin
resolution: -> invalid
stage: -> committed/rejected
status: open -> closed
___
Python tracker
<http://bugs.python.or
Changes by Brian Curtin :
--
components: +Extension Modules, Windows -Library (Lib)
nosy: +brian.curtin
stage: -> needs patch
type: -> behavior
___
Python tracker
<http://bugs.python.org/i
Brian Curtin added the comment:
This is incorrect. Please look at Python/bltinmodule.c for how input() is
implemented - there is no eval involved.
--
nosy: +brian.curtin
___
Python tracker
<http://bugs.python.org/issue11
Changes by Brian Curtin :
--
type: security ->
___
Python tracker
<http://bugs.python.org/issue11641>
___
___
Python-bugs-list mailing list
Unsubscri
Brian Curtin added the comment:
3.2.1 will have the fix.
--
nosy: +brian.curtin
resolution: -> duplicate
stage: -> committed/rejected
status: open -> closed
___
Python tracker
<http://bugs.python.or
Brian Quinlan added the comment:
I would suggest that you base your patch on 3.3/default.
--
___
Python tracker
<http://bugs.python.org/issue11635>
___
___
Pytho
Brian Quinlan added the comment:
Your approach seems workable but your patch allows the interpreter to exit
while work items are still being processed. See the comment at the top of
concurrent/futures/thread.py.
--
___
Python tracker
<h
Brian Quinlan added the comment:
Sorry, I didn't read an error message very carefully. When I apply your patch I
see:
>>> from concurrent.futures import *
>>> from time import *
>>> t = ThreadPoolExecutor(5)
>>> t.submit(sleep, 100)
>>>
Erro
Brian Curtin added the comment:
I believe there was a previous request for this which was rejected, likely for
reasons Amaury listed.
--
nosy: +brian.curtin, loewis
___
Python tracker
<http://bugs.python.org/issue11
Brian Curtin added the comment:
SYNCHRONIZE comes for free on pipes created with CreateNamedPipe, so there's
nothing to do there.
I think it's more likely that we'll have to use WaitForMultipleObjects and
include the pipe handle with a signal handler for Ctrl-C. I believ
Changes by Brian Curtin :
--
nosy: -brian.curtin
___
Python tracker
<http://bugs.python.org/issue1602>
___
___
Python-bugs-list mailing list
Unsubscribe:
Brian Curtin added the comment:
Attaching an initial patch implementing the same functionality but using
WaitForMultipleObjects. Here's some details:
WFMO takes an array of objects to wait on, which is the pipe handle and
sigint_event which is a handle to an event which gets set when C
Brian Curtin added the comment:
In the end, this is a duplicate of #11272 -- it's not specific to distutils but
this is where the issue pops up. input() in 3.2.0 isn't working properly so you
won't be able to run the register command. This is fixed for 3.2.1
In the meantime,
Changes by Brian Curtin :
--
nosy: +brian.curtin
___
Python tracker
<http://bugs.python.org/issue1673007>
___
___
Python-bugs-list mailing list
Unsubscribe:
Brian Curtin added the comment:
Closing as duplicate. #1673007 tackles the same issues and has a few patches
available.
--
nosy: +brian.curtin
resolution: -> duplicate
stage: test needed -> committed/rejected
status: open -> closed
superseder: -> urllib2 requests hi
Brian Quinlan added the comment:
No, I wasn't able to replicate.
--
___
Python tracker
<http://bugs.python.org/issue10632>
___
___
Python-bugs-list m
Brian Curtin added the comment:
Can you add your tests to Lib/test/test_netrc.py?
--
nosy: +brian.curtin
___
Python tracker
<http://bugs.python.org/issue11
Brian Quinlan added the comment:
This is the expected behavior.
Future.cancel() returns a bool indicating if the future was cancelled or not.
If it returns False then there is no way to stop it.
The behavior that you are seeing for shutdown is documented as:
"""
shutdown(wai
Brian Quinlan added the comment:
Filing a new bug might have been a mistake. Once the investigation in issue
10517 isolated the failure as being in a different module, I thought it best to
file a new bug with a minimal repro case.
Fill free to cleanup
New submission from Brian Curtin :
Attached is a patch which adds skip_unless_unattended, which ideally would be
used with at least test_faulthandler when running on Windows.
Running the tests on a Windows desktop results in the user having to click
through Windows Error Reporting dialogs in
Brian Curtin added the comment:
Attached is an example of how this might be used with
Lib/test/test_faulthandler.py
--
nosy: +haypo, loewis
Added file: http://bugs.python.org/file21494/faulthandler_example.diff
___
Python tracker
<h
Brian Curtin added the comment:
Big +1. I'll work up a patch.
--
assignee: -> brian.curtin
___
Python tracker
<http://bugs.python.org/issue11750>
___
_
Changes by Brian Curtin :
--
nosy: +brian.curtin
___
Python tracker
<http://bugs.python.org/issue11754>
___
___
Python-bugs-list mailing list
Unsubscribe:
Changes by Brian Curtin :
--
nosy: +brian.curtin
___
Python tracker
<http://bugs.python.org/issue11758>
___
___
Python-bugs-list mailing list
Unsubscribe:
Changes by Brian Curtin :
--
nosy: +brian.curtin
___
Python tracker
<http://bugs.python.org/issue10175>
___
___
Python-bugs-list mailing list
Unsubscribe:
Brian Curtin added the comment:
http://psf.upfronthosting.co.za/roundup/meta is the bug tracker for the bug
tracker.
Also, consider that if you are subscribed to any of the tracker mailing lists
such as python-bugs-list, you might get multiple copies of tracker comments.
--
nosy
Changes by Brian Curtin :
--
stage: -> needs patch
type: -> behavior
___
Python tracker
<http://bugs.python.org/issue11776>
___
___
Python-bugs-list
New submission from Brian Quinlan :
from concurrent import futures
with futures.ThreadPoolExecutor(max_workers=5) as e:
e.map(print, range(10))
# No output
--
assignee: bquinlan
components: Library (Lib)
messages: 133104
nosy: bquinlan
priority: normal
severity: normal
status: open
Brian Quinlan added the comment:
I think that it surprising behavior, especially considering that asking for the
*first* element in the iterator causes *all* of the futures to be created.
--
___
Python tracker
<http://bugs.python.org/issue11
Brian Curtin added the comment:
Disabling and re-enabling is another possibility, and it's probably more likely
to help in the long run. Most (all?) Windows machines have error reporting
enabled unless you mess with the registry manually, so the only place tests
would be run with my
Brian Quinlan added the comment:
Nice catch. I hadn't noticed that the docs are lying :-)
--
___
Python tracker
<http://bugs.python.org/issue11777>
___
___
Changes by Brian Quinlan :
--
resolution: -> fixed
status: open -> closed
___
Python tracker
<http://bugs.python.org/issue11777>
___
___
Python-bugs-list
Brian Curtin added the comment:
This looks reasonable to me. If no one beats me to it, I'll check it in tonight.
--
___
Python tracker
<http://bugs.python.org/i
301 - 400 of 1992 matches
Mail list logo
